| *** suro-patz has quit IRC | 00:01 | |
| *** adrian_otto has joined #openstack-containers | 00:10 | |
| eliqiao1 | hello, any cores around? | 00:12 |
|---|---|---|
| eliqiao1 | can you kindly help to merge https://review.openstack.org/#/c/194568/ and https://review.openstack.org/#/c/194569/ | 00:13 |
| *** adrian_otto has quit IRC | 00:13 | |
| eliqiao1 | I don't want others patch blocked by them | 00:13 |
| *** adrian_otto has joined #openstack-containers | 00:14 | |
| *** adrian_otto has quit IRC | 00:16 | |
| *** adrian_otto has joined #openstack-containers | 00:18 | |
| *** rlrevell has joined #openstack-containers | 00:22 | |
| *** dims has joined #openstack-containers | 00:23 | |
| *** harshs has quit IRC | 00:24 | |
| Kennan | eliqiao1 checking | 00:28 |
| *** harshs has joined #openstack-containers | 00:31 | |
| *** rlrevell has quit IRC | 00:31 | |
| *** rlrevell has joined #openstack-containers | 00:31 | |
| *** jjlehr has joined #openstack-containers | 00:32 | |
| *** rlrevell has quit IRC | 00:32 | |
| *** adrian_otto has quit IRC | 00:34 | |
| openstackgerrit | Merged openstack/magnum: Object: pass filter to bay list https://review.openstack.org/194568 | 00:34 |
| *** bradjones has quit IRC | 00:34 | |
| eliqiao1 | Kennan: cool, thanks boss. | 00:35 |
| *** bradjones has joined #openstack-containers | 00:35 | |
| *** bradjones has quit IRC | 00:35 | |
| *** bradjones has joined #openstack-containers | 00:35 | |
| Kennan | wcl it is my duty to do that | 00:35 |
| Kennan | eliqiao1: there? | 00:39 |
| eliqiao1 | yes | 00:39 |
| *** thomasem has quit IRC | 00:40 | |
| Kennan | hi eliqiao1: | 00:40 |
| Kennan | query = query.filter(models.Bay.status.in_(filters['status'])) | 00:40 |
| eliqiao1 | yes? | 00:40 |
| Kennan | where is in_ come from? | 00:40 |
| Kennan | why not try like this query.filter_by(status=filters['status']) ? | 00:41 |
| *** thomasem has joined #openstack-containers | 00:41 | |
| eliqiao1 | Kennan: wait a moment please, it should be inhrite from base class. I will search the code. | 00:42 |
| Kennan | I found above all use filter_by | 00:42 |
| eliqiao1 | because filter['status'] is a list | 00:42 |
| eliqiao1 | like status=['create_in_progress', 'delete_in_progress'] | 00:42 |
| eliqiao1 | if you use fiter_by then you will get sql statement like 'where status=['create_in_progress', 'delete_in_progress']' which is wrong.. | 00:43 |
| Kennan | why we choose eliqiao1: status list such kind api? | 00:44 |
| Kennan | do we have other operators like or, and | 00:44 |
| eliqiao1 | Kennan: sorry , can you repeat? | 00:45 |
| Kennan | eliqiao1: could you give what's API look like when trying filtering function(rest API) ? | 00:46 |
| Kennan | I mean querying parameter in URL | 00:46 |
| eliqiao1 | Kennan: no REST api will use it. | 00:46 |
| Kennan | so you mean we have no REAT API to achieving querying ? | 00:47 |
| eliqiao1 | https://review.openstack.org/#/c/194514/2/magnum/service/periodic.py | 00:47 |
| eliqiao1 | line 70 | 00:47 |
| eliqiao1 | Kennan: an periodic task will use it. | 00:47 |
| eliqiao1 | s/an/a | 00:48 |
| Kennan | ok so you have another bp which depend on that function | 00:49 |
| Kennan | is it ? | 00:49 |
| Kennan | eliqiao1: if that is the case, it means your bp need such function | 00:50 |
| Kennan | it should a part of your bp instead of a bug, which is not easy to follow | 00:50 |
| Kennan | why design like a status with list | 00:50 |
| eliqiao1 | Kennan: yeah | 00:51 |
| Kennan | I suggest you add that a paritally-implement of bp for that | 00:51 |
| eliqiao1 | Kennan: hmm.. actually , hongbin requires a bug tracking.. | 00:51 |
| Kennan | instead creation a bug | 00:51 |
| *** rlrevell has joined #openstack-containers | 00:52 | |
| Kennan | it is a bp you implemented that, I did not find bug is meaningful for that | 00:52 |
| eliqiao1 | can you check hongbin's comments on https://review.openstack.org/#/c/187090/6/magnum/service/periodic.py | 00:52 |
| eliqiao1 | Kennan: there's no dependency on it actually | 00:53 |
| eliqiao1 | Kennan: that bp can go without this patch. | 00:54 |
| eliqiao1 | Kennan: but It would query all bays from db then do a filter outside. | 00:54 |
| Kennan | you gave your perdioc task bp call that function | 00:54 |
| Kennan | right? | 00:54 |
| eliqiao1 | Kennan: perdioc task bp can go with/without this function. | 00:56 |
| eliqiao1 | but with function , the code will be easier | 00:56 |
| eliqiao1 | Kennan: but this patch depends on that one(which you just help merged) | 00:56 |
| Kennan | eliqiao1: if that case, it means you need such code, and code is a part of bp needs(actually, I don't think it is good to track with bug, as it is new requirements to filter with status) | 00:57 |
| Kennan | if new requirements, it is better part of bp | 00:57 |
| Kennan | but not a big issue | 00:57 |
| eliqiao1 | Kennan: I don't want to block periodic task bp review(as for as I know , deadline is 25th?) | 00:57 |
| eliqiao1 | Kennan: okay , your suggestion is make this patch as part of bp? | 00:58 |
| Kennan | considering the work efforts, I think it is ok to do it right now, Next time, I suggest not mess bug and bps | 00:59 |
| *** eghobo has quit IRC | 00:59 | |
| eliqiao1 | Kennan: yes sir, will follow it next time. | 01:00 |
| *** erkules_ has joined #openstack-containers | 01:03 | |
| Kennan | eliqiao1: | 01:03 |
| Kennan | a minor comment, pls check if reasonable | 01:03 |
| eliqiao1 | okay. thanks | 01:03 |
| *** erkules has quit IRC | 01:05 | |
| openstackgerrit | Eli Qiao proposed openstack/magnum: DB: Support filter_by status in get_bay_list https://review.openstack.org/194569 | 01:06 |
| eliqiao1 | Kennan: ^^^ done | 01:06 |
| Kennan | eliqiao1: I +2 it, other core review may help it merge, like madhuri_ or others | 01:11 |
| eliqiao1 | Kennan: thank you. nice! | 01:11 |
| Kennan | wcl | 01:11 |
| madhuri_ | done Kennan eliqiao1 | 01:11 |
| eliqiao1 | madhuri_: :) thanks | 01:12 |
| *** yuanying-alt has joined #openstack-containers | 01:13 | |
| *** Tango has quit IRC | 01:14 | |
| *** yuanying-alt has quit IRC | 01:18 | |
| *** hongbin has joined #openstack-containers | 01:24 | |
| hongbin | madhuri_: you there? | 01:26 |
| madhuri_ | yes | 01:26 |
| hongbin | This patch https://review.openstack.org/#/c/193921/ | 01:26 |
| madhuri_ | I was looking for you only | 01:26 |
| madhuri_ | Ok | 01:26 |
| hongbin | Does you have a revision? | 01:26 |
| madhuri_ | No this is the patch after changes implemented | 01:27 |
| hongbin | K | 01:27 |
| madhuri_ | Most of the attributes are dict only | 01:27 |
| hongbin | KK | 01:27 |
| madhuri_ | And also about your patch https://review.openstack.org/#/c/194866/ | 01:28 |
| hongbin | I have +2 on it | 01:28 |
| madhuri_ | Thanks hongbin :) | 01:28 |
| madhuri_ | First of all thanks for the patch :) | 01:28 |
| hongbin | Second? | 01:28 |
| madhuri_ | about the change in test file | 01:29 |
| madhuri_ | Are the changes actually needed. | 01:29 |
| hongbin | Yes, otherwise the tests will fail | 01:29 |
| madhuri_ | I think you mocked the property k8s_api | 01:29 |
| hongbin | Yes, I do | 01:29 |
| madhuri_ | How the test fail? | 01:30 |
| hongbin | It called the actual k8s api | 01:30 |
| hongbin | which failed on url format | 01:30 |
| madhuri_ | Ok I see | 01:30 |
| madhuri_ | Thank you | 01:31 |
| madhuri_ | I will +2 it | 01:31 |
| hongbin | thx | 01:31 |
| openstackgerrit | Merged openstack/magnum: Unknown type 'any' in pythonk8sclient removed. https://review.openstack.org/193921 | 01:38 |
| *** Marga_ has joined #openstack-containers | 01:39 | |
| openstackgerrit | Madhuri Kumari proposed openstack/magnum: Add TLS support in Magnum. https://review.openstack.org/194905 | 01:39 |
| openstackgerrit | Madhuri Kumari proposed openstack/magnum: Add TLS support in Magnum. https://review.openstack.org/194905 | 01:43 |
| *** harshs has quit IRC | 01:46 | |
| openstackgerrit | Madhuri Kumari proposed openstack/magnum: Add TLS support in Magnum. https://review.openstack.org/194905 | 01:47 |
| openstackgerrit | Merged openstack/magnum: DB: Support filter_by status in get_bay_list https://review.openstack.org/194569 | 01:50 |
| *** jruano has joined #openstack-containers | 01:53 | |
| *** rlrevell1 has joined #openstack-containers | 01:56 | |
| *** julim has joined #openstack-containers | 01:58 | |
| *** rlrevell has quit IRC | 01:59 | |
| *** erkules has joined #openstack-containers | 02:00 | |
| *** erkules_ has quit IRC | 02:03 | |
| *** sdake has joined #openstack-containers | 02:04 | |
| *** tobe has joined #openstack-containers | 02:06 | |
| *** kebray_ has joined #openstack-containers | 02:15 | |
| *** Drago has quit IRC | 02:16 | |
| *** kebray has quit IRC | 02:18 | |
| *** sthillma has quit IRC | 02:24 | |
| *** eghobo has joined #openstack-containers | 02:24 | |
| *** unicell has quit IRC | 02:28 | |
| *** sdake has quit IRC | 02:33 | |
| *** skoar has quit IRC | 02:40 | |
| *** eghobo has quit IRC | 02:43 | |
| *** dims has quit IRC | 02:51 | |
| *** apuimedo has quit IRC | 02:57 | |
| *** rlrevell1 has quit IRC | 03:00 | |
| *** yuanying-alt has joined #openstack-containers | 03:02 | |
| *** hongbin has quit IRC | 03:05 | |
| *** yuanying-alt has quit IRC | 03:06 | |
| *** harshs has joined #openstack-containers | 03:08 | |
| *** sankarshan is now known as sankarshan_away | 03:10 | |
| openstackgerrit | Lan Qi Song proposed openstack/python-magnumclient: Rename image_id to image when create a container https://review.openstack.org/194917 | 03:11 |
| *** bradjones has quit IRC | 03:16 | |
| *** bradjones has joined #openstack-containers | 03:18 | |
| *** bradjones has quit IRC | 03:18 | |
| *** bradjones has joined #openstack-containers | 03:18 | |
| *** skoar has joined #openstack-containers | 03:19 | |
| *** julim has quit IRC | 03:26 | |
| *** sthillma has joined #openstack-containers | 03:33 | |
| *** eghobo has joined #openstack-containers | 03:36 | |
| *** sdake has joined #openstack-containers | 03:37 | |
| *** jruano has quit IRC | 03:38 | |
| *** jruano has joined #openstack-containers | 03:40 | |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task framework https://review.openstack.org/187090 | 03:53 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add make_admin_context to Magnum context https://review.openstack.org/193029 | 03:53 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task to sync bay status https://review.openstack.org/194514 | 03:53 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Allow admin context to query all bay https://review.openstack.org/193031 | 03:53 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Support use admin creds in KeystoneClientV3 https://review.openstack.org/193030 | 03:53 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Devstack: Add admin creds in magnum.conf https://review.openstack.org/194925 | 03:53 |
| *** eghobo has quit IRC | 03:58 | |
| *** coolsvap|away is now known as coolsvap | 04:03 | |
| *** yuanying-alt has joined #openstack-containers | 04:03 | |
| *** yuanying-alt has quit IRC | 04:07 | |
| openstackgerrit | ZhiQiang Fan proposed openstack/magnum: port to oslo.service https://review.openstack.org/194932 | 04:12 |
| *** slagle_ has joined #openstack-containers | 04:16 | |
| *** coolsvap has quit IRC | 04:17 | |
| *** slagle has quit IRC | 04:18 | |
| openstackgerrit | ZhiQiang Fan proposed openstack/magnum: port to oslo.service https://review.openstack.org/194932 | 04:21 |
| *** slagle has joined #openstack-containers | 04:23 | |
| *** eghobo has joined #openstack-containers | 04:23 | |
| *** coolsvap has joined #openstack-containers | 04:23 | |
| *** slagle_ has quit IRC | 04:26 | |
| *** Marga_ has quit IRC | 04:27 | |
| *** lan has quit IRC | 04:27 | |
| *** lan has joined #openstack-containers | 04:28 | |
| *** rbradfor_ has joined #openstack-containers | 04:34 | |
| *** fawadkhaliq has joined #openstack-containers | 04:36 | |
| *** eghobo_ has joined #openstack-containers | 04:36 | |
| *** rbradfor has quit IRC | 04:37 | |
| *** eghobo has quit IRC | 04:39 | |
| *** Marga_ has joined #openstack-containers | 04:40 | |
| *** skoar has quit IRC | 04:41 | |
| *** jruano has quit IRC | 04:43 | |
| *** achanda has joined #openstack-containers | 04:44 | |
| *** unicell has joined #openstack-containers | 04:55 | |
| *** adrian_otto has joined #openstack-containers | 05:02 | |
| *** adrian_otto has quit IRC | 05:03 | |
| *** achanda has quit IRC | 05:06 | |
| *** kebray_ has quit IRC | 05:09 | |
| *** skoar has joined #openstack-containers | 05:20 | |
| *** unicell1 has joined #openstack-containers | 05:21 | |
| *** unicell has quit IRC | 05:22 | |
| *** fawadkhaliq has quit IRC | 05:24 | |
| *** tobe has quit IRC | 05:29 | |
| *** tobe has joined #openstack-containers | 05:29 | |
| *** achanda has joined #openstack-containers | 05:30 | |
| *** rlrevell has joined #openstack-containers | 05:31 | |
| *** achanda has quit IRC | 05:35 | |
| *** skoar has quit IRC | 05:35 | |
| *** rlrevell has quit IRC | 05:42 | |
| *** rlrevell has joined #openstack-containers | 05:43 | |
| *** lan has quit IRC | 05:43 | |
| *** rlrevell has quit IRC | 05:45 | |
| *** lan has joined #openstack-containers | 05:49 | |
| *** yuanying-alt has joined #openstack-containers | 05:52 | |
| openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Not need to use bay uuid https://review.openstack.org/194946 | 05:53 |
| *** yuanying-alt has quit IRC | 05:56 | |
| *** Marga_ has quit IRC | 06:00 | |
| *** harshs has quit IRC | 06:05 | |
| *** Marga_ has joined #openstack-containers | 06:06 | |
| *** fawadkhaliq has joined #openstack-containers | 06:11 | |
| *** Kennan has quit IRC | 06:12 | |
| *** destiny has joined #openstack-containers | 06:12 | |
| *** Kennan has joined #openstack-containers | 06:13 | |
| *** belmoreira has joined #openstack-containers | 06:18 | |
| *** bradjones has quit IRC | 06:20 | |
| *** bradjones has joined #openstack-containers | 06:22 | |
| *** bradjones has quit IRC | 06:22 | |
| *** bradjones has joined #openstack-containers | 06:22 | |
| *** bradjones has quit IRC | 06:36 | |
| *** bradjones has joined #openstack-containers | 06:39 | |
| *** bradjones has quit IRC | 06:39 | |
| *** bradjones has joined #openstack-containers | 06:39 | |
| *** sankarshan_away is now known as sankarshan | 06:40 | |
| *** suro-patz has joined #openstack-containers | 06:52 | |
| openstackgerrit | ZhiQiang Fan proposed openstack/magnum: port to oslo.service https://review.openstack.org/194932 | 06:54 |
| *** suro-patz1 has joined #openstack-containers | 06:56 | |
| *** suro-patz has quit IRC | 06:59 | |
| *** coolsvap has quit IRC | 07:01 | |
| *** slagle_ has joined #openstack-containers | 07:02 | |
| *** slagle has quit IRC | 07:05 | |
| openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Make swarm work with atomic image https://review.openstack.org/194963 | 07:06 |
| openstackgerrit | ZhiQiang Fan proposed openstack/magnum: remove duplicate option settings https://review.openstack.org/194964 | 07:07 |
| *** fawadk has joined #openstack-containers | 07:09 | |
| *** coolsvap has joined #openstack-containers | 07:10 | |
| *** coolsvap is now known as coolsvap|away | 07:11 | |
| *** coolsvap|away is now known as coolsvap | 07:12 | |
| *** fawadkhaliq has quit IRC | 07:12 | |
| *** sthillma has quit IRC | 07:13 | |
| *** BertrandN has joined #openstack-containers | 07:14 | |
| *** coolsvap is now known as coolsvap|away | 07:15 | |
| *** coolsvap|away is now known as coolsvap | 07:18 | |
| *** alex_klimov has joined #openstack-containers | 07:27 | |
| *** jjlehr has quit IRC | 07:28 | |
| *** eghobo_ has quit IRC | 07:38 | |
| *** yuanying-alt has joined #openstack-containers | 07:40 | |
| eliqiao1 | hi Kennan | 07:41 |
| *** yuanying-alt has quit IRC | 07:45 | |
| Kennan | hi eliqiao1 | 07:59 |
| eliqiao1 | Kennan can you check my comments on https://review.openstack.org/#/c/193029/ | 08:00 |
| Kennan | let me check | 08:00 |
| Kennan | I replied that | 08:02 |
| Kennan | I think we can add doc for that parameter | 08:03 |
| Kennan | if we know that's meaning | 08:03 |
| eliqiao1 | :param show_deleted: if True, will show deleted items when query db | 08:05 |
| eliqiao1 | Kennan: how about this? | 08:05 |
| Kennan | ok eliqiao1 | 08:05 |
| Kennan | I think it is fine | 08:05 |
| eliqiao1 | Kennan: thanks will update | 08:06 |
| Kennan | wcl | 08:06 |
| *** fawadkhaliq has joined #openstack-containers | 08:06 | |
| *** fawadk has quit IRC | 08:09 | |
| *** suro-patz1 has quit IRC | 08:12 | |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Devstack: Add admin creds in magnum.conf https://review.openstack.org/194925 | 08:25 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task framework https://review.openstack.org/187090 | 08:25 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add make_admin_context to Magnum context https://review.openstack.org/193029 | 08:25 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task to sync bay status https://review.openstack.org/194514 | 08:25 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Allow admin context to query all bay https://review.openstack.org/193031 | 08:25 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Support use admin creds in KeystoneClientV3 https://review.openstack.org/193030 | 08:25 |
| *** openstack has quit IRC | 08:25 | |
| *** openstack has joined #openstack-containers | 08:27 | |
| -cameron.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 08:27 | |
| *** fawadkhaliq has quit IRC | 08:40 | |
| *** fawadkhaliq has joined #openstack-containers | 08:40 | |
| *** fawadk has joined #openstack-containers | 08:46 | |
| *** bradjones has quit IRC | 08:49 | |
| *** fawadkhaliq has quit IRC | 08:49 | |
| *** rlrevell has joined #openstack-containers | 08:50 | |
| *** bradjones has joined #openstack-containers | 08:51 | |
| *** bradjones has quit IRC | 08:51 | |
| *** bradjones has joined #openstack-containers | 08:51 | |
| openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Fix the wrong number for minion node https://review.openstack.org/194993 | 08:51 |
| *** j___ has joined #openstack-containers | 08:56 | |
| *** rlrevell has quit IRC | 09:04 | |
| eliqiao1 | hi is Sergey around? | 09:07 |
| *** Marga_ has quit IRC | 09:08 | |
| eliqiao1 | oh , sorry , should be Tom. | 09:09 |
| *** bradjones has quit IRC | 09:09 | |
| *** rlrevell has joined #openstack-containers | 09:11 | |
| *** Marga_ has joined #openstack-containers | 09:11 | |
| *** bradjones has joined #openstack-containers | 09:11 | |
| *** bradjones has quit IRC | 09:11 | |
| *** bradjones has joined #openstack-containers | 09:11 | |
| *** oro has joined #openstack-containers | 09:12 | |
| *** Marga_ has quit IRC | 09:27 | |
| *** sankarshan is now known as sankarshan_away | 09:29 | |
| *** sankarshan_away is now known as sankarshan | 09:29 | |
| *** yuanying-alt has joined #openstack-containers | 09:29 | |
| *** rlrevell has quit IRC | 09:30 | |
| *** yuanying-alt has quit IRC | 09:33 | |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Devstack: Add admin creds in magnum.conf https://review.openstack.org/194925 | 09:36 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task framework https://review.openstack.org/187090 | 09:36 |
| openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task to sync bay status https://review.openstack.org/194514 | 09:36 |
| *** alex_klimov has quit IRC | 09:37 | |
| *** Marga_ has joined #openstack-containers | 09:48 | |
| *** sankarshan is now known as sankarshan_away | 09:48 | |
| *** dims has joined #openstack-containers | 09:50 | |
| *** Marga_ has quit IRC | 10:05 | |
| *** Marga_ has joined #openstack-containers | 10:06 | |
| *** DRoBeR has joined #openstack-containers | 10:14 | |
| *** Marga_ has quit IRC | 10:28 | |
| *** coolsvap is now known as coolsvap|away | 10:28 | |
| *** Marga_ has joined #openstack-containers | 10:28 | |
| *** yuanying has quit IRC | 10:29 | |
| *** alex_klimov has joined #openstack-containers | 10:29 | |
| *** rlrevell has joined #openstack-containers | 10:33 | |
| *** rlrevell has quit IRC | 10:35 | |
| *** sankarshan_away is now known as sankarshan | 10:37 | |
| *** tobe has quit IRC | 10:45 | |
| *** rlrevell has joined #openstack-containers | 10:47 | |
| *** rlrevell has quit IRC | 10:58 | |
| *** yuanying-alt has joined #openstack-containers | 11:18 | |
| *** Marga_ has quit IRC | 11:20 | |
| *** yuanying-alt has quit IRC | 11:22 | |
| *** bradjones has quit IRC | 11:29 | |
| *** bradjones has joined #openstack-containers | 11:30 | |
| *** bradjones has quit IRC | 11:30 | |
| *** bradjones has joined #openstack-containers | 11:30 | |
| *** daneyon has quit IRC | 11:33 | |
| *** daneyon has joined #openstack-containers | 11:34 | |
| *** brendenblanco has quit IRC | 11:45 | |
| *** brendenblanco has joined #openstack-containers | 11:50 | |
| *** alex_klimov has quit IRC | 11:54 | |
| *** alex_klimov has joined #openstack-containers | 11:55 | |
| openstackgerrit | Merged openstack/magnum: Add make_admin_context to Magnum context https://review.openstack.org/193029 | 11:57 |
| *** hongbin has joined #openstack-containers | 12:08 | |
| hongbin | Is any core here? I need a review on this patch https://review.openstack.org/#/c/194866/ . This is an important fix I think. | 12:13 |
| *** alex_klimov has quit IRC | 12:20 | |
| *** alex_klimov has joined #openstack-containers | 12:21 | |
| *** sdake_ has joined #openstack-containers | 12:21 | |
| *** sdake has quit IRC | 12:22 | |
| hongbin | Also, I need another core to review this patch as well https://review.openstack.org/#/c/194378/ | 12:26 |
| *** jruano has joined #openstack-containers | 12:33 | |
| *** fawadk has quit IRC | 12:49 | |
| *** Marga_ has joined #openstack-containers | 12:57 | |
| *** sankarshan is now known as sankarshan_away | 12:57 | |
| *** jjlehr has joined #openstack-containers | 13:01 | |
| *** yuanying-alt has joined #openstack-containers | 13:04 | |
| *** jruano has quit IRC | 13:07 | |
| *** yuanying-alt has quit IRC | 13:09 | |
| *** fawadkhaliq has joined #openstack-containers | 13:11 | |
| *** jruano has joined #openstack-containers | 13:16 | |
| *** ioni has joined #openstack-containers | 13:19 | |
| *** achanda has joined #openstack-containers | 13:20 | |
| *** prad has joined #openstack-containers | 13:20 | |
| *** hongbin has quit IRC | 13:23 | |
| *** fawadkhaliq has quit IRC | 13:29 | |
| *** Marga_ has quit IRC | 13:29 | |
| *** Marga_ has joined #openstack-containers | 13:30 | |
| *** rlrevell has joined #openstack-containers | 13:33 | |
| *** rlrevell has quit IRC | 13:34 | |
| *** rpothier has joined #openstack-containers | 13:34 | |
| *** dane_leblanc has joined #openstack-containers | 13:37 | |
| *** rlrevell has joined #openstack-containers | 13:42 | |
| *** dims has quit IRC | 14:02 | |
| *** dims has joined #openstack-containers | 14:03 | |
| *** dboik has joined #openstack-containers | 14:03 | |
| *** absubram has joined #openstack-containers | 14:03 | |
| *** yuanying-alt has joined #openstack-containers | 14:06 | |
| *** logan2 has quit IRC | 14:08 | |
| *** yuanying-alt has quit IRC | 14:10 | |
| *** julim has joined #openstack-containers | 14:11 | |
| apmelton | Kennan: ping | 14:12 |
| *** julim has quit IRC | 14:16 | |
| *** dboik_ has joined #openstack-containers | 14:17 | |
| *** dboik has quit IRC | 14:20 | |
| *** achanda has quit IRC | 14:27 | |
| *** fawadkhaliq has joined #openstack-containers | 14:29 | |
| *** logan2 has joined #openstack-containers | 14:31 | |
| *** harshs has joined #openstack-containers | 14:34 | |
| *** fawadkhaliq has quit IRC | 14:35 | |
| *** alex_klimov has quit IRC | 14:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/195113 | 14:39 |
| *** Marga_ has quit IRC | 14:40 | |
| *** mfalatic has joined #openstack-containers | 14:42 | |
| *** Marga_ has joined #openstack-containers | 14:42 | |
| *** achanda has joined #openstack-containers | 14:45 | |
| *** oro has quit IRC | 14:46 | |
| *** absubram has quit IRC | 14:48 | |
| *** Marga_ has quit IRC | 14:48 | |
| *** Marga_ has joined #openstack-containers | 14:54 | |
| tcammann | larsks: hello, could you briefly explain to me why docker.socket process is no longer needed. I'm trying to land it in Magnum | 14:57 |
| tcammann | This is the patch you made https://github.com/larsks/heat-kubernetes/commit/9cf50dd95f654ea294612aeda3c281f785a5e8cc | 14:57 |
| *** sdake_ is now known as sdake | 14:58 | |
| tcammann | and why dockerroot group is also no longer necessary https://github.com/larsks/heat-kubernetes/commit/ed9fd0ccb5fa724deda7b4a755ce0a2ec939a312 | 14:58 |
| tcammann | Thanks! | 14:59 |
| *** Marga_ has quit IRC | 15:00 | |
| larsks | tcammann: because now the docker daemon starts up automatically, rather than relying on socket activation...because now that docker can restart containers automatically, it needs to be running when the system boots even if there have not been any client connections. | 15:01 |
| *** Marga_ has joined #openstack-containers | 15:01 | |
| *** Marga_ has quit IRC | 15:01 | |
| *** Marga_ has joined #openstack-containers | 15:01 | |
| larsks | In general, it makes sense to restrict docker api access to only the root user, because someone with access to the docker api can access arbitrary files on the host and modify the host networking and kill/inspect host processes. | 15:02 |
| *** daneyon_ has joined #openstack-containers | 15:03 | |
| tcammann | Great, thanks larsks. | 15:04 |
| *** daneyon has quit IRC | 15:06 | |
| *** logan2 has quit IRC | 15:07 | |
| *** alex_klimov has joined #openstack-containers | 15:09 | |
| *** hongbin has joined #openstack-containers | 15:11 | |
| *** julim has joined #openstack-containers | 15:12 | |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Backport "docker group is no longer used" https://review.openstack.org/192587 | 15:16 |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Backport "docker.socket is no longer used" https://review.openstack.org/192586 | 15:16 |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Backport "tie minion registration to kubelet activation" https://review.openstack.org/192589 | 15:16 |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Backport "configure docker storage correctly" https://review.openstack.org/192588 | 15:16 |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Backport "docker_volume_size should be numeric" https://review.openstack.org/192590 | 15:16 |
| *** julim has quit IRC | 15:16 | |
| *** julim has joined #openstack-containers | 15:17 | |
| *** unicell has joined #openstack-containers | 15:18 | |
| *** logan2 has joined #openstack-containers | 15:18 | |
| *** Drago has joined #openstack-containers | 15:19 | |
| *** unicell1 has quit IRC | 15:19 | |
| *** Drago has quit IRC | 15:20 | |
| *** Drago has joined #openstack-containers | 15:20 | |
| *** Tango has joined #openstack-containers | 15:23 | |
| *** eghobo has joined #openstack-containers | 15:27 | |
| *** achanda_ has joined #openstack-containers | 15:27 | |
| *** harshs__ has joined #openstack-containers | 15:29 | |
| *** achanda has quit IRC | 15:29 | |
| *** EricGonczer_ has joined #openstack-containers | 15:31 | |
| *** harshs has quit IRC | 15:31 | |
| *** harshs__ is now known as harshs | 15:31 | |
| *** achanda_ has quit IRC | 15:32 | |
| *** eghobo has quit IRC | 15:38 | |
| *** logan2 has quit IRC | 15:39 | |
| hongbin | madhuri_: Hey, when you have chance, could you take a look at this bug https://bugs.launchpad.net/magnum/+bug/1468414 | 15:42 |
| openstack | Launchpad bug 1468414 in Magnum "Duplicated methods at generated k8s api client" [Undecided,New] | 15:42 |
| *** zul has quit IRC | 15:45 | |
| *** zul has joined #openstack-containers | 15:46 | |
| *** yuanying-alt has joined #openstack-containers | 15:54 | |
| *** fawadkhaliq has joined #openstack-containers | 15:59 | |
| *** yuanying-alt has quit IRC | 15:59 | |
| *** fawadkhaliq has quit IRC | 16:03 | |
| *** sthillma has joined #openstack-containers | 16:11 | |
| *** belmoreira has quit IRC | 16:12 | |
| *** unicell has quit IRC | 16:12 | |
| *** j___ has quit IRC | 16:15 | |
| *** wznoinsk has quit IRC | 16:15 | |
| *** kebray has joined #openstack-containers | 16:17 | |
| *** destiny has quit IRC | 16:20 | |
| *** nihilifer has quit IRC | 16:22 | |
| *** BertrandN has quit IRC | 16:24 | |
| openstackgerrit | Merged openstack/magnum: Support use admin creds in KeystoneClientV3 https://review.openstack.org/193030 | 16:28 |
| *** kebray has quit IRC | 16:38 | |
| *** unicell has joined #openstack-containers | 16:47 | |
| *** alex_klimov has quit IRC | 16:48 | |
| *** wznoinsk has joined #openstack-containers | 16:51 | |
| *** eghobo has joined #openstack-containers | 16:51 | |
| *** eghobo has quit IRC | 16:52 | |
| *** achanda has joined #openstack-containers | 16:52 | |
| *** dontalton has joined #openstack-containers | 16:52 | |
| *** kebray has joined #openstack-containers | 16:53 | |
| *** daneyon_ has quit IRC | 16:53 | |
| *** daneyon has joined #openstack-containers | 16:53 | |
| *** harshs has quit IRC | 16:54 | |
| *** eghobo has joined #openstack-containers | 17:00 | |
| *** daneyon has left #openstack-containers | 17:01 | |
| *** achanda has quit IRC | 17:03 | |
| *** kebray has quit IRC | 17:04 | |
| *** fawadkhaliq has joined #openstack-containers | 17:07 | |
| *** julim_ has joined #openstack-containers | 17:10 | |
| *** julim has quit IRC | 17:10 | |
| *** suro-patz has joined #openstack-containers | 17:13 | |
| *** oro has joined #openstack-containers | 17:17 | |
| *** jjfreric has joined #openstack-containers | 17:20 | |
| *** eghobo has quit IRC | 17:25 | |
| *** julim_ has quit IRC | 17:26 | |
| *** julim has joined #openstack-containers | 17:27 | |
| *** openstackgerrit has quit IRC | 17:38 | |
| *** openstackgerrit has joined #openstack-containers | 17:38 | |
| *** yuanying-alt has joined #openstack-containers | 17:43 | |
| *** yuanying-alt has quit IRC | 17:47 | |
| *** fawadkhaliq has quit IRC | 17:49 | |
| *** jjlehr has quit IRC | 17:53 | |
| *** zul has quit IRC | 17:55 | |
| *** achanda has joined #openstack-containers | 17:56 | |
| *** logan2 has joined #openstack-containers | 18:00 | |
| *** harlowja has quit IRC | 18:00 | |
| *** suro-patz has quit IRC | 18:01 | |
| *** suro-patz has joined #openstack-containers | 18:03 | |
| *** harlowja has joined #openstack-containers | 18:04 | |
| *** skoar has joined #openstack-containers | 18:04 | |
| *** oro has quit IRC | 18:04 | |
| *** jjlehr has joined #openstack-containers | 18:22 | |
| *** achanda has quit IRC | 18:27 | |
| *** achanda has joined #openstack-containers | 18:28 | |
| *** kebray has joined #openstack-containers | 18:28 | |
| *** kebray has quit IRC | 18:31 | |
| *** mfalatic has quit IRC | 18:33 | |
| *** achanda has quit IRC | 18:33 | |
| *** julim_ has joined #openstack-containers | 18:34 | |
| *** julim has quit IRC | 18:34 | |
| *** mfalatic has joined #openstack-containers | 18:36 | |
| *** mfalatic has quit IRC | 18:39 | |
| *** achanda has joined #openstack-containers | 18:40 | |
| *** mfalatic has joined #openstack-containers | 18:40 | |
| *** julim_ has quit IRC | 18:41 | |
| *** logan2 has quit IRC | 18:46 | |
| *** absubram has joined #openstack-containers | 18:49 | |
| *** fawadkhaliq has joined #openstack-containers | 18:52 | |
| *** julim has joined #openstack-containers | 18:56 | |
| openstackgerrit | Tom Cammann proposed openstack/magnum: Replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/195270 | 19:00 |
| *** suro-patz has quit IRC | 19:11 | |
| *** harlowja has quit IRC | 19:15 | |
| *** harlowja has joined #openstack-containers | 19:15 | |
| *** Marga_ has quit IRC | 19:21 | |
| *** achanda has quit IRC | 19:23 | |
| *** Marga_ has joined #openstack-containers | 19:31 | |
| *** yuanying-alt has joined #openstack-containers | 19:31 | |
| *** Marga_ has quit IRC | 19:34 | |
| *** Marga_ has joined #openstack-containers | 19:34 | |
| *** yuanying-alt has quit IRC | 19:36 | |
| *** zul has joined #openstack-containers | 19:40 | |
| *** zul has quit IRC | 19:44 | |
| *** zul has joined #openstack-containers | 19:45 | |
| *** fawadkhaliq has quit IRC | 19:46 | |
| *** Marga_ has quit IRC | 19:46 | |
| *** Marga_ has joined #openstack-containers | 19:55 | |
| *** rpothier has quit IRC | 19:59 | |
| *** Marga_ has quit IRC | 20:00 | |
| *** Marga_ has joined #openstack-containers | 20:02 | |
| *** oro has joined #openstack-containers | 20:05 | |
| *** daneyon has joined #openstack-containers | 20:08 | |
| *** harlowja has quit IRC | 20:18 | |
| *** harlowja has joined #openstack-containers | 20:18 | |
| *** oro has quit IRC | 20:19 | |
| *** julim has quit IRC | 20:30 | |
| *** daneyon has quit IRC | 20:33 | |
| *** julim has joined #openstack-containers | 20:35 | |
| *** alex_klimov has joined #openstack-containers | 20:36 | |
| *** abe_music has quit IRC | 20:37 | |
| *** sthillma has quit IRC | 20:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum: Updated from global requirements https://review.openstack.org/195113 | 20:38 |
| *** sthillma has joined #openstack-containers | 20:38 | |
| *** julim has quit IRC | 20:39 | |
| *** julim has joined #openstack-containers | 20:41 | |
| *** julim has quit IRC | 20:41 | |
| *** julim has joined #openstack-containers | 20:44 | |
| *** adrian_otto has joined #openstack-containers | 20:45 | |
| *** adrian_otto has quit IRC | 20:46 | |
| *** adrian_otto has joined #openstack-containers | 20:46 | |
| *** sthillma has quit IRC | 20:52 | |
| *** julim has quit IRC | 20:53 | |
| *** sthillma has joined #openstack-containers | 20:57 | |
| *** belmoreira has joined #openstack-containers | 20:58 | |
| *** rlrevell has quit IRC | 20:58 | |
| *** jruano has quit IRC | 20:59 | |
| *** jruano has joined #openstack-containers | 21:01 | |
| *** jruano has quit IRC | 21:02 | |
| *** julim has joined #openstack-containers | 21:03 | |
| *** adrian_otto has quit IRC | 21:04 | |
| *** adrian_otto has joined #openstack-containers | 21:05 | |
| *** adrian_otto has quit IRC | 21:08 | |
| *** adrian_otto has joined #openstack-containers | 21:12 | |
| *** yuanying-alt has joined #openstack-containers | 21:20 | |
| *** yuanying-alt has quit IRC | 21:24 | |
| *** hblixt has joined #openstack-containers | 21:25 | |
| *** adrian_otto1 has joined #openstack-containers | 21:27 | |
| *** dboik_ has quit IRC | 21:27 | |
| *** adrian_otto has quit IRC | 21:30 | |
| *** adrian_otto1 has quit IRC | 21:31 | |
| openstackgerrit | Merged openstack/magnum: Updated from global requirements https://review.openstack.org/195113 | 21:32 |
| *** adrian_otto has joined #openstack-containers | 21:35 | |
| *** muralia has quit IRC | 21:39 | |
| *** julim has quit IRC | 21:48 | |
| *** julim has joined #openstack-containers | 21:49 | |
| *** jjfreric has quit IRC | 21:52 | |
| *** sdake_ has joined #openstack-containers | 21:55 | |
| *** EricGonczer_ has quit IRC | 21:58 | |
| *** sdake has quit IRC | 21:59 | |
| *** dboik has joined #openstack-containers | 22:01 | |
| *** julim has quit IRC | 22:07 | |
| *** hblixt has quit IRC | 22:15 | |
| *** belmoreira has quit IRC | 22:19 | |
| *** jruano has joined #openstack-containers | 22:27 | |
| *** belmoreira has joined #openstack-containers | 22:29 | |
| *** suro-patz has joined #openstack-containers | 22:35 | |
| *** belmoreira has quit IRC | 22:35 | |
| *** prad has quit IRC | 22:38 | |
| *** jruano has quit IRC | 22:40 | |
| *** dboik has quit IRC | 22:46 | |
| *** adrian_otto has quit IRC | 22:50 | |
| *** belmoreira has joined #openstack-containers | 22:53 | |
| *** adrian_otto has joined #openstack-containers | 22:53 | |
| *** hongbin has quit IRC | 22:57 | |
| *** eghobo has joined #openstack-containers | 22:57 | |
| *** jjlehr has quit IRC | 22:58 | |
| *** Drago has quit IRC | 22:59 | |
| *** suro-patz has quit IRC | 23:04 | |
| *** hblixt has joined #openstack-containers | 23:05 | |
| *** adrian_otto has quit IRC | 23:05 | |
| *** yuanying-alt has joined #openstack-containers | 23:09 | |
| *** eghobo_ has joined #openstack-containers | 23:11 | |
| *** blixt_ has joined #openstack-containers | 23:11 | |
| *** yuanying-alt has quit IRC | 23:13 | |
| *** eghobo has quit IRC | 23:14 | |
| *** hblixt has quit IRC | 23:15 | |
| *** belmoreira has quit IRC | 23:15 | |
| *** bradjones has quit IRC | 23:26 | |
| *** bradjones has joined #openstack-containers | 23:26 | |
| *** bradjones has quit IRC | 23:26 | |
| *** bradjones has joined #openstack-containers | 23:26 | |
| *** alex_klimov has quit IRC | 23:29 | |
| *** Marga_ has quit IRC | 23:30 | |
| *** sdake_ has quit IRC | 23:40 | |
| *** sthillma has quit IRC | 23:41 | |
| *** sthillma has joined #openstack-containers | 23:42 | |
| *** dboik has joined #openstack-containers | 23:47 | |
| *** dane_leblanc has quit IRC | 23:51 | |
| openstackgerrit | Merged openstack/magnum: Backport "docker.socket is no longer used" https://review.openstack.org/192586 | 23:57 |
| openstackgerrit | Merged openstack/magnum: Backport "docker group is no longer used" https://review.openstack.org/192587 | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!