*** sdake_ has joined #openstack-containers | 00:00 | |
*** eghobo has quit IRC | 00:00 | |
*** adrian_otto has quit IRC | 00:00 | |
*** dims has joined #openstack-containers | 00:01 | |
*** sdake has quit IRC | 00:02 | |
*** eghobo has joined #openstack-containers | 00:08 | |
*** sdake has joined #openstack-containers | 00:09 | |
*** suro-patz has quit IRC | 00:11 | |
*** sdake_ has quit IRC | 00:13 | |
*** manjeets has joined #openstack-containers | 00:22 | |
*** SourabhP has quit IRC | 00:27 | |
*** SourabhP has joined #openstack-containers | 00:31 | |
*** dims has quit IRC | 00:50 | |
*** ameybhide has quit IRC | 00:51 | |
*** fawadkhaliq has joined #openstack-containers | 00:53 | |
*** wanghua has joined #openstack-containers | 00:53 | |
*** diga5 has joined #openstack-containers | 00:55 | |
*** fawadkhaliq has quit IRC | 00:56 | |
*** diga5 has quit IRC | 00:58 | |
*** ybathia has quit IRC | 00:58 | |
*** dims has joined #openstack-containers | 00:58 | |
*** wanghua has quit IRC | 00:59 | |
*** wanghua has joined #openstack-containers | 00:59 | |
*** humble_ has joined #openstack-containers | 01:00 | |
openstackgerrit | Merged openstack/magnum: Docker container-create fails with Unicode is not supported https://review.openstack.org/198916 | 01:01 |
---|---|---|
*** zhenguo has joined #openstack-containers | 01:03 | |
*** wanghua has quit IRC | 01:03 | |
*** manjeets has quit IRC | 01:04 | |
*** daneyon has joined #openstack-containers | 01:06 | |
*** manjeets has joined #openstack-containers | 01:06 | |
*** Tango has joined #openstack-containers | 01:09 | |
*** achanda has joined #openstack-containers | 01:13 | |
*** SourabhP has quit IRC | 01:24 | |
*** erkules has joined #openstack-containers | 01:25 | |
*** erkules_ has quit IRC | 01:28 | |
*** manjeets has quit IRC | 01:29 | |
*** sthillma has quit IRC | 01:42 | |
*** eghobo has quit IRC | 01:43 | |
*** kan__ has joined #openstack-containers | 01:49 | |
*** harshs has quit IRC | 01:51 | |
*** skoar has quit IRC | 02:03 | |
*** daneyon has quit IRC | 02:08 | |
*** daneyon has joined #openstack-containers | 02:08 | |
openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task to sync up bay status https://review.openstack.org/194514 | 02:09 |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Fix minion registration failure https://review.openstack.org/198939 | 02:14 |
*** skoar has joined #openstack-containers | 02:15 | |
*** dboik_ has joined #openstack-containers | 02:24 | |
*** dboik_ has quit IRC | 02:31 | |
openstackgerrit | Merged openstack/magnum: Remove duplicated definition of class "APIBase" https://review.openstack.org/198509 | 02:34 |
*** skoar has quit IRC | 02:42 | |
*** daneyon has quit IRC | 02:45 | |
*** kebray has joined #openstack-containers | 02:56 | |
*** kebray has quit IRC | 02:57 | |
*** kebray has joined #openstack-containers | 02:58 | |
openstackgerrit | Merged openstack/magnum: Fix sample link in magnum/api/controllers/link.py https://review.openstack.org/198507 | 03:13 |
*** skoar has joined #openstack-containers | 03:15 | |
*** julim has joined #openstack-containers | 03:31 | |
*** hongbin has quit IRC | 03:32 | |
sdake | madhuri ping | 03:34 |
sdake | madhuri if you are around today ping me when you can | 03:35 |
sdake | its important (see inbox) | 03:35 |
sdake | atleast important to me :) | 03:35 |
*** dims has quit IRC | 03:39 | |
*** eghobo has joined #openstack-containers | 03:50 | |
*** suro-patz has joined #openstack-containers | 03:51 | |
madhuri | sdake, Hi | 03:53 |
madhuri | I read your mail | 03:53 |
madhuri | Will share all the details | 03:53 |
sdake | any inside tips you could provide would be higly valuable | 03:53 |
sdake | please keep me on the cc | 03:53 |
madhuri | Sure | 03:54 |
sdake | and please keep private ;) | 03:54 |
madhuri | Ok :) | 03:54 |
*** skoar has left #openstack-containers | 03:59 | |
*** harshs has joined #openstack-containers | 04:10 | |
*** julim has quit IRC | 04:19 | |
madhuri | sdake, ping | 04:30 |
*** Marga_ has joined #openstack-containers | 04:32 | |
*** Marga_ has quit IRC | 04:32 | |
*** Marga_ has joined #openstack-containers | 04:33 | |
*** dims has joined #openstack-containers | 04:40 | |
*** dims_ has joined #openstack-containers | 04:41 | |
*** adrian_otto has joined #openstack-containers | 04:43 | |
*** dims has quit IRC | 04:45 | |
*** dims_ has quit IRC | 04:46 | |
*** adrian_otto has quit IRC | 04:48 | |
*** suro-patz has quit IRC | 04:56 | |
*** nihilifer has joined #openstack-containers | 04:59 | |
*** SourabhP has joined #openstack-containers | 05:04 | |
*** SourabhP_ has joined #openstack-containers | 05:09 | |
*** SourabhP has quit IRC | 05:11 | |
*** SourabhP_ is now known as SourabhP | 05:11 | |
*** Marga_ has quit IRC | 05:18 | |
*** Marga_ has joined #openstack-containers | 05:19 | |
*** achanda has quit IRC | 05:23 | |
*** yuanying_ has joined #openstack-containers | 05:40 | |
eliqiao | hi madhuri | 05:42 |
openstackgerrit | Eli Qiao proposed openstack/magnum: Add periodic task to sync up bay status https://review.openstack.org/194514 | 05:42 |
*** harshs has quit IRC | 05:43 | |
*** yuanying has quit IRC | 05:44 | |
*** unicell has joined #openstack-containers | 05:44 | |
*** yuanying_ has quit IRC | 05:44 | |
*** juggler_ has joined #openstack-containers | 05:46 | |
*** juggler has quit IRC | 05:49 | |
*** yuanying has joined #openstack-containers | 05:51 | |
*** ig0r_ has joined #openstack-containers | 05:52 | |
*** wanghua has joined #openstack-containers | 05:52 | |
*** humble_ has quit IRC | 05:53 | |
*** harshs has joined #openstack-containers | 05:53 | |
*** humble_ has joined #openstack-containers | 05:55 | |
*** ig0r__ has quit IRC | 05:55 | |
*** unicell has quit IRC | 05:56 | |
*** wanghua has quit IRC | 05:58 | |
*** unicell has joined #openstack-containers | 05:58 | |
*** j___ has joined #openstack-containers | 05:59 | |
*** suro-patz has joined #openstack-containers | 06:00 | |
*** dane_leblanc has quit IRC | 06:02 | |
*** yuanying has quit IRC | 06:04 | |
humble_ | hi all, can we use container-create in k8sbay? | 06:07 |
*** yuanying has joined #openstack-containers | 06:10 | |
Kennan | hi humble_ i don't think you can use that | 06:14 |
*** yuanying has quit IRC | 06:14 | |
*** suro-patz has quit IRC | 06:15 | |
humble_ | Kennan: why we don't forbid it in the codes | 06:15 |
*** yuanying has joined #openstack-containers | 06:16 | |
Kennan | humble_ I think k8s default mininal container unit is pods | 06:17 |
Kennan | not containers | 06:17 |
eliqiao | hi Kennan, can I ask a question? | 06:19 |
Kennan | hi eliqiao: | 06:19 |
humble_ | Kennan: yes, we only can use container-create in swarm bay. So i think we should return forbidden action when a user use container-create in k8s bay. | 06:19 |
Kennan | humble_: I think it was this fix https://review.openstack.org/#/c/198456/ | 06:21 |
eliqiao | I see from code that when calling container-list will query all containers by docker client_api , but if one of them fails, container-list will report exception without any results | 06:21 |
eliqiao | Kennan: this is too bad, user can do nothing on that containers, how about we ignor the exceptions and set it to error state? | 06:22 |
eliqiao | Kennan: I found this patch #link https://review.openstack.org/#/c/180384/, but seems in some cases, it can not work well | 06:23 |
Kennan | eliqiao: what do you mean if one of them fails ? what's the failure case | 06:26 |
Kennan | and for the last question | 06:26 |
Kennan | what's case for it not work well? | 06:26 |
eliqiao | I got this exception "image or container param is undefined", it is reported by docker client | 06:27 |
Kennan | eliqiao: what's the error msg in docker side? what image or container param undefined? | 06:29 |
eliqiao | Kennan: hmm... can you tell how can I get such message? | 06:33 |
Kennan | hi eliqiao: the docker backend finally got from docker python client | 06:33 |
Kennan | found the image which hit issue | 06:33 |
Kennan | and use docker-py directly from python | 06:34 |
Kennan | execute that and found what's the root cause | 06:34 |
Kennan | eliqiao: check this https://docker-py.readthedocs.org/en/latest/api/ | 06:34 |
eliqiao | Kennan: thx, okay let me try, ttl | 06:34 |
Kennan | it could help you | 06:34 |
eliqiao | Kennan: got it,thx | 06:35 |
*** belmoreira has joined #openstack-containers | 06:43 | |
madhuri | hi eliqiao | 06:44 |
eliqiao | oh hi madhuri, I just see you around that time, I am looking for you to help merge patch | 06:46 |
eliqiao | madhuri: appreciate if if you have time to help on https://review.openstack.org/#/c/180384/ | 06:46 |
eliqiao | madhuri, thank in advance | 06:47 |
madhuri | This patch is already merged eliqiao | 06:48 |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side https://review.openstack.org/198984 | 06:48 |
eliqiao | sorry for wrong link should be this one, https://review.openstack.org/#/c/194514/ jay and hong bin have +2 on it | 06:49 |
madhuri | Ok sure I will take a look on it | 06:50 |
eliqiao | magnum are going to support baremetal ? | 06:52 |
*** j___ has quit IRC | 06:52 | |
*** eghobo has quit IRC | 06:52 | |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side https://review.openstack.org/198984 | 06:54 |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side https://review.openstack.org/198984 | 06:58 |
*** BertrandN has joined #openstack-containers | 07:03 | |
*** Marga__ has joined #openstack-containers | 07:03 | |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/python-magnumclient: Add platform support in client side https://review.openstack.org/198988 | 07:03 |
*** Marga_ has quit IRC | 07:06 | |
*** j___ has joined #openstack-containers | 07:06 | |
*** SourabhP has quit IRC | 07:07 | |
*** SourabhP has joined #openstack-containers | 07:09 | |
*** madhuri has quit IRC | 07:21 | |
*** juggler_ is now known as juggler | 07:23 | |
eliqiao | Kennan: I found the root cause why container-list failed | 07:24 |
juggler | is Kennan here? | 07:25 |
Kennan | eliqiao: what's the issue | 07:25 |
Kennan | juggler: what's up | 07:25 |
*** belmoreira has quit IRC | 07:26 | |
eliqiao | Kennan: quite simliar with https://bugs.launchpad.net/magnum/+bug/1449872 | 07:26 |
openstack | Launchpad bug 1449872 in Magnum "Container create failed on docker but still saved in magnum" [Undecided,In progress] - Assigned to Lan Qi song (lqslan) | 07:26 |
juggler | Regarding: https://review.openstack.org/#/c/189584/2/doc/source/dev/dev-quickstart.rst , I am puzzled by the comment. | 07:26 |
juggler | The URL was included as an aid... | 07:27 |
juggler | to direct the user to additional information to configure their devstack. | 07:27 |
eliqiao | Kennan: here is how I reproduce it http://paste.openstack.org/show/351079/ | 07:27 |
juggler | A newcomer to the dev-quickstart document... | 07:27 |
Kennan | juggler: what can I help you? | 07:28 |
juggler | would have no idea where that dev-manual-devstack.rst is located. | 07:28 |
Kennan | juggler: | 07:29 |
Kennan | https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst | 07:29 |
Kennan | check above link | 07:29 |
juggler | you might help in explaining why the repeat -1's | 07:29 |
*** BertrandN has quit IRC | 07:29 | |
juggler | yes, I know what that document is. | 07:29 |
Kennan | juggler: if you want to fix the devstack detailed configuration | 07:29 |
Kennan | you should refer to devstack official link | 07:30 |
Kennan | instead of manual guide link | 07:30 |
Kennan | in magnum | 07:30 |
juggler | I do not want to fix the devstack detailed configuration. That was never the bug's intent. | 07:30 |
juggler | This is an issue of assuring that the dev-quickstart.rst mentions the EXISTENCE/LOCATION of the dev-manual-devstack.rst | 07:32 |
juggler | Without that key information, a newcomer has no idea what a "devstack guide" is and will spend extra cycles asking around | 07:32 |
*** harshs has quit IRC | 07:32 | |
*** kebray has quit IRC | 07:33 | |
*** Tango has quit IRC | 07:33 | |
Kennan | juggler: I did not know what's not clear for here | 07:35 |
Kennan | You need to make customized setting according to your environment requirement, refer devstack guide for details | 07:35 |
Kennan | it is said user need to refer devstack guide | 07:35 |
Kennan | it is not manual magnum guide | 07:36 |
juggler | it is believed that the intent of current development is to to refer to the dev-manual-devstack.rst document | 07:39 |
*** dims has joined #openstack-containers | 07:43 | |
*** BertrandN has joined #openstack-containers | 07:45 | |
*** dims has quit IRC | 07:48 | |
juggler | Kennan you there? | 07:51 |
Kennan | hi just come, had some issue | 07:51 |
juggler | oh ok | 07:52 |
*** SourabhP has quit IRC | 07:55 | |
Kennan | hi juggler: I did not think it was intent to refer manual guide. it was for devstack customizaton, as many customization not explained in manual-devstack guide | 07:56 |
Kennan | it was in devstack official guide | 07:56 |
*** macjack has joined #openstack-containers | 07:56 | |
Kennan | and devstack have more than that, it is there to get understood what can configuration | 07:56 |
Kennan | like ovs and etc. | 07:57 |
juggler | ok...so how are newcomers going to know of the existence of the https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-manual-devstack.rst then? it's my gathering from channel chats here that this is an important piece in the puzzle | 07:58 |
*** SourabhP has joined #openstack-containers | 07:58 | |
Kennan | hi juggler: if you really want to link manual guide from dev-qucik guide | 08:00 |
Kennan | I suggest you can refer what did in manual guide (ref to manual guide) | 08:04 |
Kennan | https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-manual-devstack.rst | 08:04 |
Kennan | juggler usually I think if user can find dev quick guide, it is easy for him to find manul guide. As it is targeted for developers(from github) | 08:05 |
juggler | "what did"? sorry I do not follow | 08:05 |
*** j___ has quit IRC | 08:05 | |
*** SourabhP has quit IRC | 08:06 | |
Kennan | since that link is source code, it could finally published magnum dev wiki with tox -e docs | 08:06 |
Kennan | it woudl have index.html | 08:06 |
*** erkules has quit IRC | 08:06 | |
*** erkules has joined #openstack-containers | 08:06 | |
Kennan | like this | 08:07 |
Kennan | If you are getting started with Magnum it is recommended you follow the :ref:`dev-quickstart` t | 08:07 |
*** SourabhP has joined #openstack-containers | 08:12 | |
juggler | the doc/source/dev/dev-quickstart.rst file does not use wiki syntax, though | 08:12 |
openstackgerrit | Eli Qiao proposed openstack/magnum: API: don't query Error state containers from docker_client https://review.openstack.org/199007 | 08:15 |
*** SourabhP_ has joined #openstack-containers | 08:15 | |
*** SourabhP has quit IRC | 08:16 | |
*** SourabhP_ is now known as SourabhP | 08:16 | |
juggler | well, Kennan, it is late here. i plan to be at the meeting this morning if you have additional comments/feedback. | 08:18 |
juggler | bottom line is that without including this URL in that document, it makes it harder to find for newcomers. | 08:19 |
juggler | perhaps adrian_otto may have additional feedback on the review | 08:20 |
*** j___ has joined #openstack-containers | 08:20 | |
Kennan | juggler: Still usually newcomers not need to check manual-install guide, it is too details(more is about devsstack itself) | 08:20 |
Kennan | it not help anything about magnum | 08:20 |
juggler | i beg to differ | 08:25 |
juggler | let's consult adrian_otto then for guidance | 08:30 |
Kennan | hi, juggler, you may can inovlve other reviers options about that, As I said, it is use tox to produce finally guide, many projects follow that | 08:31 |
Kennan | quick-guide is for new comers to start, they not to worry so many devstack configuration at the first time | 08:31 |
*** SourabhP has quit IRC | 08:36 | |
juggler | as a newcomer reading that, i had no idea where to go next. leaving that person in the dark is not good. | 08:44 |
juggler | i would hope one of our goals is to make this easier for people | 08:45 |
Kennan | hi eliqiao: you can open a bug for that, I did not remember clearly, it was introduced by new code? | 08:46 |
juggler | later Kennan. tty at the meeting, or next time | 08:46 |
Kennan | you'd better involve more reviewers options about it. As I said :) | 08:47 |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/python-magnumclient: Add platform support in client side https://review.openstack.org/198988 | 08:49 |
eliqiao | Kennan: #link https://launchpad.net/bugs/1472132 | 08:50 |
openstack | Launchpad bug 1472132 in Magnum "container-list fails after container-create fail with 500" [Undecided,In progress] - Assigned to Eli Qiao (taget-9) | 08:50 |
Kennan | ok eliqiao: I tried that case before, not hit that. maybe regression issue | 08:52 |
Kennan | did that container exist in docker swarm? eliqiao: ? | 08:53 |
Kennan | I think it only exist in magnum side | 08:53 |
eliqiao | Kennan: you are right | 08:53 |
eliqiao | Kennan: post() create an container object in db, then call conductor to create container in swarm, but failed | 08:54 |
eliqiao | Kennan: #link https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/container.py#L364 | 08:55 |
Kennan | Hi eliqiao: | 08:56 |
Kennan | yes, but when you call container-list | 08:57 |
Kennan | it would loop call container-show in docker-conductor | 08:57 |
Kennan | it had | 08:57 |
Kennan | except errors.APIError as api_error | 08:57 |
Kennan | if '404' in error_message: | 08:57 |
eliqiao | Kennan: by checking the status in magnum DB, that container's status is "ERROR" , and then if we do container-list, it will first _find_container_by_name, but got {}, then with {} , call result = docker.inspect_container(docker_id) | 08:57 |
Kennan | yes, wouldn't it hit exception and catch by | 08:58 |
eliqiao | I don't get errors.APIError | 08:58 |
Kennan | oh, I think it was docker-py new changes, | 08:58 |
Kennan | before it would fall to exception | 08:58 |
Kennan | and check return code is 404 | 08:58 |
Kennan | and set error | 08:58 |
Kennan | I remembered before | 08:59 |
Kennan | what did the docker.inspect_container(docker_id) return then ? | 08:59 |
eliqiao | don't think so, I never update my docker-py | 08:59 |
eliqiao | Kennan: check this http://paste.openstack.org/show/351373/ | 09:01 |
*** j___ has quit IRC | 09:02 | |
Kennan | you can check our docker-py before docker-py>=1.1.0, right now, I found the env is 1.2.3 | 09:02 |
Kennan | as devstack install magnum, would finally fetch latest docker-py | 09:03 |
eliqiao | {} is returned by https://github.com/openstack/magnum/blob/master/magnum/conductor/handlers/docker_conductor.py#L159 | 09:03 |
Kennan | pip freeze | grep -i docker-py | 09:03 |
Kennan | got 1.2.3 in my env | 09:03 |
eliqiao | me too docker-py==1.2.3 | 09:04 |
eliqiao | taget@taget-ThinkStation-P300:/opt/stack/magnum$ pip list | grep docker-py | 09:04 |
eliqiao | docker-py (1.2.3) | 09:04 |
eliqiao | Kennan: if so, this should be a critical bug ? | 09:05 |
eliqiao | Kennan: or high | 09:05 |
Kennan | yes, I think it is critical bug, | 09:05 |
Kennan | but let's first invetigate | 09:05 |
Kennan | we should also need make it work in 1.2.3 | 09:06 |
Kennan | as we not need to update 1.2.3 in requirements if it is not must | 09:06 |
eliqiao | invetigate in which version docker-py change the behavior? | 09:07 |
Kennan | not sure if it is this case | 09:08 |
Kennan | https://github.com/docker/docker-py/commit/de2f58d818565dd | 09:08 |
Kennan | but I think let's change magnum code to support that 1.2.3 also | 09:08 |
Kennan | is better | 09:08 |
Kennan | seems not | 09:08 |
Kennan | it is inspect_images | 09:08 |
eliqiao | Kennan: Sorry , not feling well, should go home, I have patch on https://review.openstack.org/#/c/199007/, leave comments if you have any idea. thanks | 09:09 |
Kennan | ok eliqiao: take care | 09:09 |
eliqiao | Kennan: BTW, where is your location ? BJ/Xi'an | 09:09 |
Kennan | BJ | 09:10 |
eliqiao | Kennan: cool, actually I am ibmer later year , hehe... | 09:10 |
eliqiao | Kennan: I should go , thx | 09:10 |
Kennan | wcl | 09:11 |
*** j___ has joined #openstack-containers | 09:21 | |
*** dims has joined #openstack-containers | 09:44 | |
*** dims_ has joined #openstack-containers | 09:45 | |
*** dims__ has joined #openstack-containers | 09:46 | |
*** dims has quit IRC | 09:48 | |
*** dims_ has quit IRC | 09:50 | |
*** dims__ has quit IRC | 09:50 | |
openstackgerrit | Merged openstack/magnum: Swith auth_uri to use v2.0 https://review.openstack.org/197865 | 09:52 |
openstackgerrit | Merged openstack/magnum: Remove unused fields "from_*" from API controller https://review.openstack.org/198505 | 09:55 |
*** yuanying_ has joined #openstack-containers | 09:57 | |
*** yuanying has quit IRC | 10:00 | |
openstackgerrit | Kai Qiang Wu(Kennan) proposed openstack/magnum: Add ironic support in magnum server side https://review.openstack.org/198984 | 10:02 |
*** yuanying_ has quit IRC | 10:07 | |
*** yuanying has joined #openstack-containers | 10:07 | |
*** madhuri has joined #openstack-containers | 10:08 | |
madhuri | eliqiao, ping | 10:08 |
Kennan | yuanying: there? | 10:17 |
yuanying | hi | 10:17 |
Kennan | hi yuanying: I am not sure what do you mean add wait contditon for master | 10:18 |
Kennan | where should we add that? | 10:18 |
yuanying | kubecluster.yaml use it for master | 10:19 |
yuanying | oh | 10:19 |
yuanying | change to master_wc_notify | 10:19 |
*** diga has quit IRC | 10:20 | |
Kennan | yuanying: could you specify it ? | 10:20 |
yuanying | wait a moment | 10:20 |
Kennan | with paste for what change should like | 10:20 |
yuanying | kubecluster.yaml has master_wait_handle | 10:21 |
yuanying | https://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/kubecluster.yaml#L96 | 10:21 |
yuanying | https://github.com/openstack/magnum/blob/master/magnum/templates/heat-kubernetes/kubecluster.yaml#L228 | 10:22 |
yuanying | if script is finished, that status is notified to heat | 10:23 |
yuanying | I think master_wait_handle is needed to track finishing the kubernetes install script | 10:24 |
yuanying | when software_deploymen was used, software deployment notified that to heat | 10:25 |
Kennan | I not sure if it is needed, all resource becase creation_compleate finally even not with that | 10:26 |
Kennan | yuanying: you said that was for notifying heat to become compleate-finished? | 10:27 |
Kennan | to update heat stack status? | 10:27 |
yuanying | when stack status is creation_complete, kubernetes can be used by user, it means all script should be finished | 10:27 |
yuanying | Kennan: yes | 10:28 |
yuanying | if there is no master_wc_notify, stack status will be creation_complete but script will not be finished | 10:29 |
Kennan | ok yuanying: let me try that | 10:29 |
Kennan | yuanying: do you think we need master_wait_condition ? | 10:31 |
yuanying | I think we need it | 10:32 |
Kennan | yuanying: kube_minions now depend on kube_master | 10:33 |
Kennan | in ironic templates | 10:33 |
Kennan | so if it need depend on master_wait_condition? | 10:33 |
yuanying | kube_minion can request to kube_master, when kubernetes service doesn't finished setup? | 10:34 |
Kennan | I am not sure if wc_notify issue, just 30 mins ago, I tried to add depends on master_wait_condition for kube_minions | 10:36 |
Kennan | it just have one master setup | 10:36 |
Kennan | and node would not setup | 10:36 |
yuanying | I think it's better that minion node depends on master_wait_condition | 10:36 |
Kennan | master_wait_condition always in create_in_progress | 10:37 |
Kennan | and never ends | 10:37 |
yuanying | really? | 10:37 |
yuanying | hmm | 10:37 |
Kennan | yes, I tried that (without wc_notify) | 10:37 |
Kennan | I think wc_notfiy has nothing with that wait_condition | 10:37 |
Kennan | right? becasue from templates I not find it have depends on that | 10:38 |
yuanying | wc_notify is needed | 10:38 |
Kennan | OK. I would try again with (as before) | 10:38 |
Kennan | depends_on: | 10:39 |
Kennan | - kube_master | 10:39 |
Kennan | - master_wait_condition | 10:39 |
Kennan | I not think it could success | 10:39 |
Kennan | but let me try first | 10:39 |
* Kennan leave for supper | 10:43 | |
*** dims has joined #openstack-containers | 10:46 | |
*** dims has quit IRC | 10:51 | |
*** Marga__ has quit IRC | 11:00 | |
*** Marga_ has joined #openstack-containers | 11:02 | |
*** Marga_ has quit IRC | 11:15 | |
*** Marga_ has joined #openstack-containers | 11:17 | |
*** humble_ has quit IRC | 11:20 | |
*** eliqiao has quit IRC | 11:25 | |
*** eliqiao has joined #openstack-containers | 11:27 | |
*** j___ has quit IRC | 11:53 | |
*** j___ has joined #openstack-containers | 11:53 | |
*** dims has joined #openstack-containers | 12:02 | |
*** diga has joined #openstack-containers | 12:03 | |
*** j___ has quit IRC | 12:04 | |
*** dims has quit IRC | 12:07 | |
*** j___ has joined #openstack-containers | 12:15 | |
*** diga_ has joined #openstack-containers | 12:16 | |
*** diga has quit IRC | 12:20 | |
*** hongbin has joined #openstack-containers | 13:01 | |
*** dane_leblanc has joined #openstack-containers | 13:01 | |
*** jruano has joined #openstack-containers | 13:03 | |
*** dane_leblanc has quit IRC | 13:07 | |
*** dims has joined #openstack-containers | 13:19 | |
*** dboik has joined #openstack-containers | 13:20 | |
*** wanghua has joined #openstack-containers | 13:20 | |
*** nihilifer has quit IRC | 13:23 | |
*** julim has joined #openstack-containers | 13:24 | |
*** yuanying-alt has joined #openstack-containers | 13:25 | |
*** jruano has quit IRC | 13:27 | |
*** jruano has joined #openstack-containers | 13:27 | |
*** jjlehr has joined #openstack-containers | 13:28 | |
*** dane_leblanc has joined #openstack-containers | 13:30 | |
*** hongbin has quit IRC | 13:45 | |
*** j___ has quit IRC | 13:47 | |
*** jruano_ has joined #openstack-containers | 13:49 | |
*** jruano has quit IRC | 13:50 | |
*** adrian_otto has joined #openstack-containers | 13:50 | |
*** nihilifer has joined #openstack-containers | 13:51 | |
*** jruano_ is now known as jruano | 13:52 | |
*** kan__ has quit IRC | 13:57 | |
*** jruano has quit IRC | 13:58 | |
*** hongbin has joined #openstack-containers | 14:01 | |
*** jruano has joined #openstack-containers | 14:02 | |
*** Kennan2 has joined #openstack-containers | 14:03 | |
*** zhenguo has quit IRC | 14:03 | |
*** Kennan has quit IRC | 14:03 | |
*** jruano has quit IRC | 14:06 | |
*** j___ has joined #openstack-containers | 14:09 | |
*** sdake has quit IRC | 14:14 | |
*** sdake has joined #openstack-containers | 14:14 | |
*** j___ has quit IRC | 14:21 | |
*** wwallnrr__ has joined #openstack-containers | 14:21 | |
*** yuanying-alt has quit IRC | 14:23 | |
*** Drago has joined #openstack-containers | 14:38 | |
*** Drago has quit IRC | 14:43 | |
*** Drago has joined #openstack-containers | 14:43 | |
*** adrian_otto has quit IRC | 14:55 | |
*** bradjones|away is now known as bradjones | 14:56 | |
*** achanda has joined #openstack-containers | 14:56 | |
*** BertrandN has quit IRC | 15:00 | |
*** adrian_otto has joined #openstack-containers | 15:02 | |
*** achanda has quit IRC | 15:02 | |
*** rpothier has joined #openstack-containers | 15:04 | |
*** adrian_otto has quit IRC | 15:05 | |
*** adrian_otto has joined #openstack-containers | 15:05 | |
*** adrian_otto has quit IRC | 15:09 | |
*** adrian_otto has joined #openstack-containers | 15:09 | |
*** adrian_otto has quit IRC | 15:13 | |
*** adrian_otto has joined #openstack-containers | 15:13 | |
*** dims has quit IRC | 15:16 | |
*** adrian_otto has quit IRC | 15:17 | |
*** kebray has joined #openstack-containers | 15:17 | |
*** jruano has joined #openstack-containers | 15:19 | |
*** SourabhP has joined #openstack-containers | 15:21 | |
*** jruano has quit IRC | 15:22 | |
*** SourabhP_ has joined #openstack-containers | 15:23 | |
*** SourabhP has quit IRC | 15:26 | |
*** SourabhP_ is now known as SourabhP | 15:26 | |
*** dims has joined #openstack-containers | 15:43 | |
*** nihilifer has quit IRC | 15:47 | |
*** sdake_ has joined #openstack-containers | 15:48 | |
*** adrian_otto has joined #openstack-containers | 15:48 | |
*** sdake has quit IRC | 15:48 | |
*** jjfreric has joined #openstack-containers | 15:48 | |
*** unicell has quit IRC | 15:49 | |
adrian_otto | The Containers Team meeting will begin in 10 minutes in #openstack-meeting-alt so I look forward to seeing you all there! | 15:50 |
*** j___ has joined #openstack-containers | 15:52 | |
*** eghobo has joined #openstack-containers | 15:57 | |
*** sthillma has joined #openstack-containers | 15:58 | |
*** kebray has quit IRC | 15:59 | |
*** Tango has joined #openstack-containers | 15:59 | |
*** daneyon has joined #openstack-containers | 16:00 | |
*** mfalatic has joined #openstack-containers | 16:01 | |
*** kebray has joined #openstack-containers | 16:01 | |
*** suro-patz has joined #openstack-containers | 16:05 | |
*** gnep has joined #openstack-containers | 16:12 | |
*** gnep has quit IRC | 16:13 | |
*** manjeets has joined #openstack-containers | 16:14 | |
*** fawadkhaliq has joined #openstack-containers | 16:15 | |
*** absubram has joined #openstack-containers | 16:16 | |
*** unicell has joined #openstack-containers | 16:23 | |
*** SourabhP has quit IRC | 16:26 | |
*** manjeets has quit IRC | 16:27 | |
*** unicell has quit IRC | 16:28 | |
*** unicell has joined #openstack-containers | 16:28 | |
*** sdake_ is now known as sdae | 16:35 | |
*** sdae is now known as sdake | 16:39 | |
*** harshs has joined #openstack-containers | 16:53 | |
*** Tango has quit IRC | 17:04 | |
*** vahidh has joined #openstack-containers | 17:10 | |
*** david-lyle has quit IRC | 17:19 | |
*** sthillma has quit IRC | 17:19 | |
*** Tango has joined #openstack-containers | 17:20 | |
*** pradk has joined #openstack-containers | 17:21 | |
openstackgerrit | Tom Cammann proposed openstack/magnum: Check for Python 2 when using unicode builtin https://review.openstack.org/199189 | 17:23 |
*** achanda has joined #openstack-containers | 17:25 | |
*** manjeets has joined #openstack-containers | 17:40 | |
*** SourabhP has joined #openstack-containers | 17:42 | |
*** j___ has quit IRC | 17:46 | |
*** SourabhP has quit IRC | 17:48 | |
*** SourabhP has joined #openstack-containers | 17:48 | |
*** adrian_otto has quit IRC | 17:50 | |
*** adrian_otto has joined #openstack-containers | 17:51 | |
*** jjfreric has quit IRC | 17:57 | |
*** jjfreric has joined #openstack-containers | 17:57 | |
*** manjeets has quit IRC | 17:58 | |
*** harshs has quit IRC | 18:02 | |
*** adrian_otto has quit IRC | 18:02 | |
*** dane_leblanc has quit IRC | 18:03 | |
*** julim_ has joined #openstack-containers | 18:03 | |
*** sthillma has joined #openstack-containers | 18:03 | |
*** jjfreric has quit IRC | 18:04 | |
*** coolsvap|away is now known as coolsvap | 18:04 | |
*** julim has quit IRC | 18:05 | |
*** jjfreric has joined #openstack-containers | 18:07 | |
*** adrian_otto has joined #openstack-containers | 18:08 | |
*** ybathia has joined #openstack-containers | 18:11 | |
*** dane_leblanc has joined #openstack-containers | 18:11 | |
*** adrian_otto has quit IRC | 18:12 | |
*** harshs has joined #openstack-containers | 18:12 | |
*** adrian_otto has joined #openstack-containers | 18:12 | |
openstackgerrit | Martin Falatic proposed openstack/magnum: Updated Magnum documentation https://review.openstack.org/199212 | 18:25 |
*** adrian_otto has quit IRC | 18:32 | |
*** adrian_otto has joined #openstack-containers | 18:33 | |
*** adrian_otto has quit IRC | 18:35 | |
*** adrian_otto has joined #openstack-containers | 18:35 | |
*** sdake has quit IRC | 18:36 | |
*** adrian_otto has quit IRC | 18:51 | |
*** achanda has quit IRC | 18:51 | |
*** sdake has joined #openstack-containers | 18:52 | |
*** dims has quit IRC | 18:53 | |
*** gordc has joined #openstack-containers | 18:55 | |
*** gordc has left #openstack-containers | 18:55 | |
*** sdake_ has joined #openstack-containers | 18:56 | |
*** dims has joined #openstack-containers | 18:58 | |
*** sdake has quit IRC | 19:00 | |
*** kebray has quit IRC | 19:02 | |
*** harlowja_ has joined #openstack-containers | 19:02 | |
*** harlowja has quit IRC | 19:03 | |
*** ybathia has quit IRC | 19:06 | |
*** ybathia has joined #openstack-containers | 19:06 | |
*** harshs has quit IRC | 19:08 | |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Add documentation for smart scale down feature https://review.openstack.org/198799 | 19:21 |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Implement bay smart scale down https://review.openstack.org/196526 | 19:21 |
*** sthillma has quit IRC | 19:24 | |
*** harshs has joined #openstack-containers | 19:30 | |
openstackgerrit | Martin Falatic proposed openstack/magnum: Updated Magnum documentation https://review.openstack.org/199212 | 19:31 |
mfalatic | jjlehr - Thanks for the helpful feedback on my submission! I've resubmitted with updates. | 19:33 |
mfalatic | Also, is there something you ran that automated the doc check? Also, do any build jobs run automatically when we submit work for Magnum or is that something I need to run manually (I notice nothing had run yet for my initial submission) | 19:33 |
*** achanda has joined #openstack-containers | 19:37 | |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Remove unreachable code in API utils https://review.openstack.org/198040 | 19:39 |
*** kebray has joined #openstack-containers | 19:40 | |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Validate bay type on creating resources https://review.openstack.org/198456 | 19:41 |
*** skoar has joined #openstack-containers | 19:42 | |
openstackgerrit | Hongbin Lu proposed openstack/magnum: Eliminate mutable default arguments https://review.openstack.org/198465 | 19:45 |
*** dims has quit IRC | 19:48 | |
*** jruano has joined #openstack-containers | 19:49 | |
*** kebray has quit IRC | 19:50 | |
*** david-lyle has joined #openstack-containers | 19:50 | |
*** adrian_otto has joined #openstack-containers | 19:59 | |
*** adrian_otto has quit IRC | 20:00 | |
*** wshao has joined #openstack-containers | 20:00 | |
*** adrian_otto has joined #openstack-containers | 20:01 | |
*** kebray has joined #openstack-containers | 20:04 | |
*** manjeets has joined #openstack-containers | 20:12 | |
*** fawadkhaliq has quit IRC | 20:15 | |
*** kebray has quit IRC | 20:17 | |
jjlehr | mfalatic: No problem! The trailing whitespaces and unused indents are highlighted in red by gerrit. I would think the pep8 tests would catch those. You can run the pep8 tests by following the testing instructions in the quickstart guide. | 20:18 |
jjlehr | https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst#setup-dev-environment | 20:18 |
*** kebray has joined #openstack-containers | 20:18 | |
jjlehr | Usually Jenkins automatically runs build jobs and tests when you submit a change for review. Perhaps it doesn't run them if no actual code changes are made, but I don't know. Perhaps someone else could answer that better. | 20:19 |
*** daneyon has quit IRC | 20:26 | |
*** skoar has quit IRC | 20:28 | |
*** coolsvap is now known as coolsvap|away | 20:39 | |
mfalatic | jjlehr - I wouldn't have considered pep8 to be appropriate for docs in general, but the main question was whether you ran a tool specifically for checking docs (and evidently there's not one). I will pay closer attention to such potential bugs in the future though, I just could've sworn I squashed them on the first pass! :-D | 20:41 |
mfalatic | (I should've caught most of them in my usual editor anyway) | 20:42 |
mfalatic | jjlehr Most importantly, thank you again for catching that! | 20:43 |
*** sthillma has joined #openstack-containers | 20:46 | |
jjlehr | mfalatic: Oh duh, of course pep8 wouldn't be appropriate....silly me :) | 20:46 |
mfalatic | Well, strictly speaking it might work, but it's not the first thing I'd reach for... | 20:48 |
jjlehr | Looks like Jenkins got around to your change after all | 20:59 |
mfalatic | Indeed! | 20:59 |
*** jjfreric has quit IRC | 21:01 | |
*** wshao has quit IRC | 21:03 | |
*** julim_ has quit IRC | 21:04 | |
*** daneyon has joined #openstack-containers | 21:10 | |
*** dims has joined #openstack-containers | 21:13 | |
*** wshao has joined #openstack-containers | 21:13 | |
*** kebray has quit IRC | 21:16 | |
*** skoar has joined #openstack-containers | 21:19 | |
*** sdake_ is now known as sdake | 21:20 | |
*** kebray has joined #openstack-containers | 21:21 | |
*** dboik has quit IRC | 21:25 | |
*** dims has quit IRC | 21:30 | |
*** pradk has quit IRC | 21:32 | |
*** ameybhide has joined #openstack-containers | 21:34 | |
*** dims has joined #openstack-containers | 21:35 | |
*** dims has quit IRC | 21:35 | |
*** Guest7393 has joined #openstack-containers | 21:35 | |
*** dane_leblanc has quit IRC | 21:41 | |
*** manjeets_ has joined #openstack-containers | 21:41 | |
*** manjeets has quit IRC | 21:43 | |
*** rpothier has quit IRC | 21:44 | |
*** sdake_ has joined #openstack-containers | 21:48 | |
*** wshao has quit IRC | 21:51 | |
*** sdake has quit IRC | 21:52 | |
*** jjlehr has quit IRC | 21:55 | |
*** Drago has quit IRC | 22:00 | |
*** wshao has joined #openstack-containers | 22:05 | |
*** Drago has joined #openstack-containers | 22:07 | |
*** unicell has quit IRC | 22:10 | |
*** unicell has joined #openstack-containers | 22:10 | |
suro-patz | jjlehr: mfalatic: our tox.ini excludes 'doc/' for target pep8/flake8, but 'tox -edocs' should be good for testing the doc changes - https://github.com/openstack/magnum/blob/master/doc/source/dev/dev-quickstart.rst#building-developer-documentation | 22:12 |
suro-patz | https://github.com/openstack/magnum/blob/master/tox.ini#L61 | 22:14 |
*** wshao has quit IRC | 22:20 | |
*** fawadkhaliq has joined #openstack-containers | 22:22 | |
openstackgerrit | Ton Ngo proposed openstack/magnum: Instruction for building Fedora Atomic image https://review.openstack.org/196145 | 22:24 |
*** Tango has quit IRC | 22:31 | |
*** daneyon has quit IRC | 22:34 | |
*** adrian_otto has quit IRC | 22:44 | |
*** jruano has quit IRC | 22:58 | |
*** fawadkhaliq has quit IRC | 23:02 | |
*** hongbin has quit IRC | 23:06 | |
*** absubram has quit IRC | 23:11 | |
*** zhenguo has joined #openstack-containers | 23:14 | |
*** Tango has joined #openstack-containers | 23:15 | |
mfalatic | sdake - can I get your input on https://review.openstack.org/199212 ? | 23:19 |
*** manjeets_ has quit IRC | 23:19 | |
openstackgerrit | Ton Ngo proposed openstack/magnum: Instruction for building Fedora Atomic image https://review.openstack.org/196145 | 23:33 |
*** yuanying_ has joined #openstack-containers | 23:53 | |
*** kebray has quit IRC | 23:56 | |
*** yuanying has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!