*** sdake_ is now known as sdake | 00:10 | |
*** huzhengchuan has joined #openstack-containers | 00:10 | |
*** hongbin has quit IRC | 00:24 | |
*** Drago1 has quit IRC | 00:24 | |
*** adrian_otto has joined #openstack-containers | 00:38 | |
*** tovin07 has joined #openstack-containers | 00:49 | |
*** tonanhngo has quit IRC | 00:57 | |
*** vijendar1 has joined #openstack-containers | 00:57 | |
*** vijendar1 has quit IRC | 00:57 | |
*** mtanino has quit IRC | 01:00 | |
*** code34 has quit IRC | 01:04 | |
*** zz_dimtruck is now known as dimtruck | 01:12 | |
*** dsariel has quit IRC | 01:15 | |
*** tonanhngo has joined #openstack-containers | 01:17 | |
*** kevinz has joined #openstack-containers | 01:20 | |
openstackgerrit | Adrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance https://review.openstack.org/430071 | 01:21 |
---|---|---|
*** tonanhngo has quit IRC | 01:22 | |
openstackgerrit | Adrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance https://review.openstack.org/430071 | 01:23 |
*** sdake has quit IRC | 01:24 | |
ianychoi | adrian_otto, hello. Just a reminder for creating stable/ocata branch for magnum-ui => Would be there other things rather than the last review (string bug change) which block the stable branch creation in magnum-ui? | 01:25 |
adrian_otto | will do, thanks ianychoi | 01:26 |
adrian_otto | that's the only thing, and it's minot, so not a blocker | 01:26 |
adrian_otto | s/minot/minor/ | 01:26 |
ianychoi | adrian_otto, I see. Just one thing I commented was that patching po files directly in the repo is not a good idea | 01:27 |
ianychoi | After seeing the patch later, I updated all the translated strings in Zanata - translation platform | 01:27 |
ianychoi | adrian_otto, to summarize: https://review.openstack.org/#/c/429058/ patched *.po files directly in the repo -> https://review.openstack.org/#/c/429352/ overwrote the result from Zanata -> I updated translated strings in Zanata -> translated strings were finally landed to magnum-ui by https://review.openstack.org/#/c/429513/ | 01:30 |
*** yamamoto has quit IRC | 01:34 | |
openstackgerrit | Adrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance https://review.openstack.org/430071 | 01:35 |
*** yamamoto has joined #openstack-containers | 01:38 | |
openstackgerrit | Adrian Otto proposed openstack/magnum master: WIP: Adding Magnum Governance https://review.openstack.org/430071 | 01:42 |
*** yamamoto has quit IRC | 01:43 | |
adrian_otto | ianychoi: okay, so does that mean we should merge all three? | 01:50 |
adrian_otto | all three have merged. | 01:51 |
adrian_otto | so it's time to branch. | 01:51 |
*** vijendar1 has joined #openstack-containers | 01:56 | |
*** vijendar2 has joined #openstack-containers | 01:58 | |
*** vijendar1 has quit IRC | 01:59 | |
*** adisky_ has quit IRC | 01:59 | |
*** vijendar2 has quit IRC | 02:00 | |
*** vijendar has joined #openstack-containers | 02:00 | |
*** vijendar1 has joined #openstack-containers | 02:02 | |
*** vijendar has quit IRC | 02:02 | |
*** adrian_otto has quit IRC | 02:04 | |
*** Syed__ has quit IRC | 02:15 | |
*** vijendar2 has joined #openstack-containers | 02:24 | |
*** vijendar1 has quit IRC | 02:24 | |
*** adrian_otto has joined #openstack-containers | 02:27 | |
*** vijendar2 has quit IRC | 02:29 | |
*** sacharya_ has joined #openstack-containers | 02:34 | |
*** sacharya has quit IRC | 02:36 | |
*** fragatin_ has joined #openstack-containers | 02:37 | |
*** sdake has joined #openstack-containers | 02:39 | |
*** fragatina has quit IRC | 02:40 | |
*** yamamoto has joined #openstack-containers | 02:40 | |
*** yamamoto has quit IRC | 03:01 | |
*** sdake has quit IRC | 03:01 | |
*** sdake has joined #openstack-containers | 03:02 | |
openstackgerrit | Cao Xuan Hoang proposed openstack/magnum master: Remove support for py34 https://review.openstack.org/430522 | 03:04 |
*** mtanino has joined #openstack-containers | 03:07 | |
*** crazymozart has joined #openstack-containers | 03:10 | |
*** fragatin_ has quit IRC | 03:21 | |
*** mtanino has quit IRC | 03:22 | |
*** fragatina has joined #openstack-containers | 03:24 | |
*** fragatina has quit IRC | 03:24 | |
*** fragatina has joined #openstack-containers | 03:25 | |
*** vimal has joined #openstack-containers | 03:33 | |
*** fragatin_ has joined #openstack-containers | 03:33 | |
crazymozart | could anybody tell me why "container" is removed from UI? | 03:36 |
*** fragatina has quit IRC | 03:37 | |
*** fragatin_ has quit IRC | 03:37 | |
*** adisky_ has joined #openstack-containers | 03:39 | |
ianychoi | adrian_otto, what I meant is that in your patch: https://review.openstack.org/#/c/429058/ => I suggest not to directly update *.po files in the patches, since later "Import from Zanata" will override *.po files stored in translation platform. | 03:44 |
adrian_otto | ianychoi: Ok, noted. Thanks. | 03:45 |
ianychoi | adrian_otto, yep since all three have merged it would be nice if magnum-ui will have stable/ocata branch. Thanks! | 03:45 |
*** hongbin has joined #openstack-containers | 03:51 | |
*** sdake_ has joined #openstack-containers | 03:54 | |
*** ricolin has joined #openstack-containers | 03:55 | |
*** sdake has quit IRC | 03:57 | |
*** mdnadeem has joined #openstack-containers | 04:00 | |
*** vimal has quit IRC | 04:01 | |
*** fragatina has joined #openstack-containers | 04:09 | |
*** fragatina has quit IRC | 04:12 | |
*** fragatina has joined #openstack-containers | 04:12 | |
*** fragatina has quit IRC | 04:13 | |
*** fragatina has joined #openstack-containers | 04:13 | |
*** askb has quit IRC | 04:24 | |
*** vimal has joined #openstack-containers | 04:25 | |
*** dimtruck is now known as zz_dimtruck | 04:26 | |
*** hongbin has quit IRC | 04:27 | |
*** faizy has joined #openstack-containers | 04:30 | |
*** askb has joined #openstack-containers | 04:30 | |
*** huzhengchuan has quit IRC | 04:39 | |
openstackgerrit | Merged openstack/magnum master: Trivial: Fix typo in exception message https://review.openstack.org/427214 | 04:40 |
*** sacharya has joined #openstack-containers | 04:43 | |
*** sacharya_ has quit IRC | 04:43 | |
*** huzhengchuan has joined #openstack-containers | 04:52 | |
*** sacharya_ has joined #openstack-containers | 04:56 | |
*** sacharya has quit IRC | 04:57 | |
*** chhavi has joined #openstack-containers | 04:58 | |
*** janki has joined #openstack-containers | 05:12 | |
*** zz_dimtruck is now known as dimtruck | 05:17 | |
*** tonanhngo has joined #openstack-containers | 05:25 | |
*** vijendar has joined #openstack-containers | 05:26 | |
*** vijendar has quit IRC | 05:27 | |
*** vijendar has joined #openstack-containers | 05:27 | |
*** vijendar1 has joined #openstack-containers | 05:29 | |
*** vijendar has quit IRC | 05:29 | |
*** dimtruck is now known as zz_dimtruck | 05:29 | |
*** vijendar has joined #openstack-containers | 05:31 | |
*** vijendar1 has quit IRC | 05:31 | |
*** vijendar has quit IRC | 05:32 | |
*** vijendar has joined #openstack-containers | 05:32 | |
*** huzhengchuan has quit IRC | 05:34 | |
*** PanFengyun has quit IRC | 05:34 | |
*** huzhengchuan has joined #openstack-containers | 05:35 | |
*** zenirc369 has joined #openstack-containers | 05:36 | |
*** vijendar has quit IRC | 05:42 | |
*** sacharya_ has quit IRC | 05:43 | |
*** zenirc369 has quit IRC | 05:44 | |
*** PanFengyun has joined #openstack-containers | 05:47 | |
*** zenirc369 has joined #openstack-containers | 05:56 | |
*** yolanda_ has quit IRC | 06:02 | |
*** yolanda_ has joined #openstack-containers | 06:02 | |
*** adrian_otto has quit IRC | 06:13 | |
*** zz_dimtruck is now known as dimtruck | 06:20 | |
*** sdake_ is now known as sdake | 06:27 | |
*** dimtruck is now known as zz_dimtruck | 06:30 | |
*** huzhengchuan has quit IRC | 06:34 | |
*** adrian_otto has joined #openstack-containers | 06:43 | |
*** huzhengchuan has joined #openstack-containers | 06:48 | |
*** rcernin has joined #openstack-containers | 06:59 | |
*** hishh has joined #openstack-containers | 07:10 | |
*** zz_dimtruck is now known as dimtruck | 07:21 | |
*** sdake_ has joined #openstack-containers | 07:23 | |
*** tonanhngo has quit IRC | 07:25 | |
*** sdake has quit IRC | 07:26 | |
*** pcaruana has joined #openstack-containers | 07:29 | |
*** dimtruck is now known as zz_dimtruck | 07:32 | |
*** adrian_otto has quit IRC | 07:33 | |
*** crazymozart has quit IRC | 07:36 | |
*** david-lyle_ has joined #openstack-containers | 07:37 | |
*** yamamoto has joined #openstack-containers | 07:56 | |
*** yamamoto has quit IRC | 07:56 | |
*** PanFengyun has quit IRC | 08:00 | |
*** vijaykc4 has joined #openstack-containers | 08:02 | |
*** tonanhngo has joined #openstack-containers | 08:03 | |
*** mloncan has joined #openstack-containers | 08:04 | |
*** tonanhngo has quit IRC | 08:04 | |
*** sdake_ is now known as dake | 08:05 | |
*** pcastets has joined #openstack-containers | 08:08 | |
*** sdake has joined #openstack-containers | 08:14 | |
*** dake has quit IRC | 08:17 | |
*** yamamoto has joined #openstack-containers | 08:20 | |
*** zz_dimtruck is now known as dimtruck | 08:23 | |
*** dsariel has joined #openstack-containers | 08:26 | |
*** yamamoto has quit IRC | 08:26 | |
*** david-lyle_ has quit IRC | 08:28 | |
*** mjura has joined #openstack-containers | 08:28 | |
*** dimtruck is now known as zz_dimtruck | 08:33 | |
*** vijaykc4 has quit IRC | 08:36 | |
*** vijaykc4 has joined #openstack-containers | 08:36 | |
*** vijaykc4 has quit IRC | 08:37 | |
*** vijaykc4 has joined #openstack-containers | 08:37 | |
*** vijaykc4 has quit IRC | 08:38 | |
*** vijaykc4 has joined #openstack-containers | 08:38 | |
*** vijaykc4 has quit IRC | 08:38 | |
*** vijaykc4 has joined #openstack-containers | 08:39 | |
*** huzhengchuan has quit IRC | 08:39 | |
*** vijaykc4 has quit IRC | 08:39 | |
*** vijaykc4 has joined #openstack-containers | 08:40 | |
*** vijaykc4 has quit IRC | 08:40 | |
*** vijaykc4 has joined #openstack-containers | 08:40 | |
*** vijaykc4 has quit IRC | 08:41 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: Add WSGI script to deploy Magnum behind Apache https://review.openstack.org/427723 | 08:42 |
*** prameswar has joined #openstack-containers | 08:44 | |
*** dsariel has quit IRC | 08:45 | |
ArchiFleKs | strigazi: Hello, I'm having trouble testing swarm_v2, I copy the folder an change os_distro, but template is not listed in magnum-driver-manage, documentation here seems out of date http://docs.openstack.org/developer/magnum/dev/cluster-type-definition.html | 08:49 |
*** huzhengchuan has joined #openstack-containers | 08:52 | |
*** hishh has quit IRC | 09:00 | |
strigazi | ArchiFleKs, you need to add the entrypoint too like https://github.com/strigazi/magnum/blob/swarm_fedora_atomic_v2_inplace/setup.cfg#L65 | 09:11 |
*** vijaykc4 has joined #openstack-containers | 09:18 | |
*** zenirc369 has quit IRC | 09:24 | |
*** zz_dimtruck is now known as dimtruck | 09:24 | |
*** ricolin has quit IRC | 09:24 | |
*** fragatina has quit IRC | 09:30 | |
*** fragatina has joined #openstack-containers | 09:30 | |
*** hishh has joined #openstack-containers | 09:31 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Add custom etcd service configuration based on static IPs https://review.openstack.org/411862 | 09:31 |
*** openstackgerrit has quit IRC | 09:34 | |
*** dimtruck is now known as zz_dimtruck | 09:34 | |
*** swatson__ has joined #openstack-containers | 09:36 | |
*** zenirc369 has joined #openstack-containers | 09:38 | |
*** ricolin has joined #openstack-containers | 09:38 | |
*** crazymozart has joined #openstack-containers | 09:39 | |
*** chhavi has quit IRC | 09:42 | |
*** lbragstad_ has joined #openstack-containers | 09:43 | |
*** dims_ has joined #openstack-containers | 09:44 | |
*** sahilsinha_ has joined #openstack-containers | 09:44 | |
*** filler_ has joined #openstack-containers | 09:44 | |
*** crazymozart has quit IRC | 09:45 | |
*** chriscaudre has quit IRC | 09:45 | |
*** huzhengchuan has quit IRC | 09:45 | |
*** askb has quit IRC | 09:45 | |
*** swatson_ has quit IRC | 09:45 | |
*** yasemin has quit IRC | 09:45 | |
*** dims has quit IRC | 09:45 | |
*** filler has quit IRC | 09:45 | |
*** sahilsinha has quit IRC | 09:45 | |
*** lbragstad has quit IRC | 09:45 | |
*** filler_ is now known as filler | 09:45 | |
*** openstackgerrit has joined #openstack-containers | 09:48 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Remove defaults network from child templates https://review.openstack.org/411866 | 09:48 |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Add custom etcd service configuration based on static IPs https://review.openstack.org/411862 | 09:48 |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Add SERVICE_ACCOUNT_KEY to Kuberneres cluster configuration https://review.openstack.org/411863 | 09:48 |
*** vijendar has joined #openstack-containers | 09:49 | |
*** vijaykc4 has quit IRC | 09:50 | |
*** vijaykc4 has joined #openstack-containers | 09:51 | |
*** huzhengchuan has joined #openstack-containers | 09:51 | |
*** askb has joined #openstack-containers | 09:52 | |
*** yasemin has joined #openstack-containers | 09:52 | |
*** vijendar has quit IRC | 09:53 | |
*** swatson__ has quit IRC | 09:54 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Add custom docker REGISTRY_URL option https://review.openstack.org/411867 | 09:56 |
*** salmankhan has joined #openstack-containers | 10:00 | |
*** crazymozart has joined #openstack-containers | 10:00 | |
*** danil has joined #openstack-containers | 10:03 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Build openSUSE Leap 42.1 OpenStack Magnum image https://review.openstack.org/397743 | 10:15 |
*** yamamoto has joined #openstack-containers | 10:17 | |
openstackgerrit | Michal Jura proposed openstack/magnum master: [suse] Build openSUSE Leap 42.1 OpenStack Magnum image https://review.openstack.org/397743 | 10:17 |
*** kevinz has quit IRC | 10:17 | |
ArchiFleKs | strigazi: OK thanks i'll test it today ;) | 10:22 |
*** yamamoto has quit IRC | 10:22 | |
*** zz_dimtruck is now known as dimtruck | 10:25 | |
*** dimtruck is now known as zz_dimtruck | 10:34 | |
*** vijaykc4 has quit IRC | 10:36 | |
openstackgerrit | Kevin Lefevre proposed openstack/magnum master: Make request insecure when talking to endpoints https://review.openstack.org/430755 | 10:45 |
*** salmankhan has quit IRC | 10:45 | |
*** salmankhan has joined #openstack-containers | 10:45 | |
*** hishh1 has joined #openstack-containers | 10:47 | |
*** hishh has quit IRC | 10:49 | |
*** hishh1 is now known as hishh | 10:49 | |
*** dsariel has joined #openstack-containers | 10:59 | |
*** sdake has quit IRC | 11:11 | |
*** sdake has joined #openstack-containers | 11:11 | |
*** vijaykc4 has joined #openstack-containers | 11:15 | |
*** yamamoto has joined #openstack-containers | 11:20 | |
*** vijaykc4 has quit IRC | 11:22 | |
*** vijaykc4 has joined #openstack-containers | 11:22 | |
*** yamamoto has quit IRC | 11:26 | |
*** sdake has quit IRC | 11:43 | |
*** ricolin has quit IRC | 11:54 | |
*** chhavi has joined #openstack-containers | 11:54 | |
*** huzhengchuan has quit IRC | 12:02 | |
*** dave-mccowan has joined #openstack-containers | 12:08 | |
*** huzhengchuan has joined #openstack-containers | 12:14 | |
*** faizy has quit IRC | 12:16 | |
*** hishh has quit IRC | 12:18 | |
openstackgerrit | Spyros Trigazis proposed openstack/magnum stable/newton: Fix gate: caused by tempest(removal of "service" param) https://review.openstack.org/427630 | 12:19 |
*** huzhengchuan has quit IRC | 12:25 | |
*** zz_dimtruck is now known as dimtruck | 12:26 | |
*** salmankhan has quit IRC | 12:28 | |
*** salmankhan has joined #openstack-containers | 12:28 | |
*** lilia_ has quit IRC | 12:30 | |
*** lilia has joined #openstack-containers | 12:30 | |
*** yamamoto has joined #openstack-containers | 12:35 | |
*** dimtruck is now known as zz_dimtruck | 12:36 | |
*** huzhengchuan has joined #openstack-containers | 12:37 | |
*** chhavi has quit IRC | 12:44 | |
*** yamamoto has quit IRC | 12:48 | |
*** huzhengchuan has quit IRC | 12:51 | |
*** jmckind has joined #openstack-containers | 12:57 | |
*** askb has quit IRC | 12:58 | |
*** hishh has joined #openstack-containers | 12:59 | |
*** yatin_on_leave has quit IRC | 13:00 | |
*** vimal has quit IRC | 13:04 | |
*** zenirc369 has quit IRC | 13:07 | |
*** catintheroof has joined #openstack-containers | 13:08 | |
*** yatin_on_leave has joined #openstack-containers | 13:12 | |
*** OGtrilliams has joined #openstack-containers | 13:19 | |
*** lbragstad_ is now known as lbragstad | 13:29 | |
*** ricolin has joined #openstack-containers | 13:36 | |
*** sdake has joined #openstack-containers | 13:36 | |
*** janki has quit IRC | 13:38 | |
*** robcresswell has joined #openstack-containers | 13:39 | |
robcresswell | Hey magnum/ magnum-ui devs can we get a response on https://review.openstack.org/#/c/429753/ please? There have been several emails but nobody from the Magnum team has responded as far as I can tell. | 13:39 |
strigazi | robcresswell which reqs must be removed? | 13:41 |
strigazi | these https://github.com/openstack/magnum-ui/blob/master/requirements.txt#L18-L39 ? | 13:41 |
*** AlexeyAbashkin has joined #openstack-containers | 13:42 | |
*** AlexeyAbashkin has quit IRC | 13:42 | |
strigazi | robcresswell ^^ | 13:42 |
strigazi | In your mail you said all xstatic packages | 13:42 |
robcresswell | strigazi: Yeah; I dont believe you need any of those | 13:45 |
robcresswell | in your requirements | 13:45 |
*** OGtrilliams has quit IRC | 13:45 | |
robcresswell | or any of django requirements either | 13:45 |
*** janki has joined #openstack-containers | 13:46 | |
robcresswell | They should all be there because of Horizon anyway | 13:46 |
*** kevinz has joined #openstack-containers | 13:47 | |
*** chhavi has joined #openstack-containers | 13:49 | |
*** yamamoto has joined #openstack-containers | 13:49 | |
*** faizy has joined #openstack-containers | 13:52 | |
*** yamamoto has quit IRC | 13:55 | |
*** OGtrilliams has joined #openstack-containers | 13:58 | |
*** kevinz has quit IRC | 14:04 | |
*** kevinz has joined #openstack-containers | 14:05 | |
strigazi | robcresswell https://review.openstack.org/430941 Remove Xstatic packages from requirements | 14:08 |
robcresswell | strigazi: Could you comment on the review further up please? We need infra to unblock that patch. Its important. | 14:09 |
strigazi | I was doing so | 14:10 |
strigazi | :) | 14:10 |
robcresswell | Or rather, we need whoever is PTL to comment. I dont know who that is atm | 14:10 |
robcresswell | strigazi: Thanks :) | 14:10 |
*** AlexeyAbashkin has joined #openstack-containers | 14:13 | |
*** kevinz has quit IRC | 14:18 | |
*** mdnadeem has quit IRC | 14:19 | |
*** mjura has quit IRC | 14:22 | |
*** salmankhan has quit IRC | 14:23 | |
*** m1dev has joined #openstack-containers | 14:27 | |
*** zz_dimtruck is now known as dimtruck | 14:28 | |
*** vijaykc4 has quit IRC | 14:31 | |
*** mjura has joined #openstack-containers | 14:34 | |
*** salmankhan has joined #openstack-containers | 14:37 | |
*** dimtruck is now known as zz_dimtruck | 14:37 | |
*** vijendar1 has joined #openstack-containers | 14:40 | |
strigazi | robcresswell I'll ping our PTL | 14:48 |
strigazi | done | 14:50 |
*** chris_hultin|AWA is now known as chris_hultin | 14:55 | |
*** mtanino has joined #openstack-containers | 14:58 | |
*** chhavi has quit IRC | 14:58 | |
*** vijendar2 has joined #openstack-containers | 15:00 | |
*** vijendar1 has quit IRC | 15:01 | |
*** tonanhngo has joined #openstack-containers | 15:01 | |
*** vijendar1 has joined #openstack-containers | 15:02 | |
*** vijendar2 has quit IRC | 15:02 | |
*** tonanhngo has quit IRC | 15:02 | |
*** AlexeyAbashkin has quit IRC | 15:05 | |
*** zz_dimtruck is now known as dimtruck | 15:05 | |
*** adrian_otto1 has joined #openstack-containers | 15:05 | |
*** vijendar1 has quit IRC | 15:07 | |
*** jasond has joined #openstack-containers | 15:08 | |
*** vijendar1 has joined #openstack-containers | 15:16 | |
adrian_otto1 | strigazi: I have a question about https://review.openstack.org/430941 | 15:19 |
strigazi | shoot | 15:19 |
adrian_otto1 | are we sure that we don't need those libraries? I have not yet tested to see if everything works without them, so I'm reluctant to vote on it. | 15:19 |
*** sacharya has joined #openstack-containers | 15:20 | |
*** dave-mccowan has quit IRC | 15:20 | |
*** adrian_otto1 is now known as adrian_otto | 15:21 | |
adrian_otto | I am willing to merge it if we have at least two people verify that it does not cause a regression. I'm not convinced that we have automated testing that would catch such a regression. | 15:21 |
adrian_otto | on that software at least. | 15:21 |
strigazi | All these libraries are reuquired by horizon | 15:22 |
strigazi | and magnum-ui requires horizon, I'm having one more close look | 15:22 |
strigazi | I'll get back to you in 10' | 15:23 |
adrian_otto | ok, thx | 15:23 |
*** hongbin has joined #openstack-containers | 15:26 | |
*** fragatina has quit IRC | 15:30 | |
strigazi | adrian_otto all xstatic reqs in magnum-ui are in the horizon (exact same version) apart from XStatic-Magic-Search which is taken into horizon. Since magnum-ui is a horizon plugin and they can't live apart, all xstatic magnum-ui reqs will be there. I'm checking again for XStatic-Magic-Search | 15:30 |
*** fragatina has joined #openstack-containers | 15:30 | |
*** EricGonczer_ has joined #openstack-containers | 15:30 | |
adrian_otto | strigazi: acknowledged | 15:31 |
*** huzhengchuan has joined #openstack-containers | 15:31 | |
*** vijendar1 has quit IRC | 15:32 | |
*** EricGonc_ has joined #openstack-containers | 15:34 | |
strigazi | In the last mail by Richard Jones it's mentioned that xstatic-magic-search is imported into horizon, shouldn't be a problem | 15:34 |
strigazi | adrian_otto http://lists.openstack.org/pipermail/openstack-dev/2017-February/111770.html | 15:35 |
*** EricGonczer_ has quit IRC | 15:35 | |
adrian_otto | yes, I saw that last night. | 15:37 |
strigazi | I think it's safe, the dependencies are the same | 15:38 |
*** dave-mccowan has joined #openstack-containers | 15:38 | |
adrian_otto | ok | 15:38 |
*** vijendar has joined #openstack-containers | 15:43 | |
*** danil has quit IRC | 15:45 | |
*** mjura has quit IRC | 15:46 | |
*** janki has quit IRC | 15:49 | |
*** mjura has joined #openstack-containers | 15:50 | |
adrian_otto | strigazi: I replied to the ML thread approving the FFE, and voted to merge the two related patches. | 15:54 |
robcresswell | thanks for the mailer response adrian_otto | 15:55 |
strigazi | adrian_otto, thanks. Maybe approve the magnum-ui chnage too? | 15:55 |
*** huzhengchuan has quit IRC | 15:56 | |
adrian_otto | strigazi: can you help me understand the urgency? | 15:56 |
adrian_otto | I think I'm missing some of the context of what the release team is doing at this moment | 15:57 |
*** adrian_otto has quit IRC | 15:57 | |
strigazi | adrian_otto, In our side is not super urgent since we approved the openstack/requirements change. The problem may arise when packagers will try to package magnum-ui. We can wait for shu-muto to approve as well | 16:00 |
*** EricGonc_ has quit IRC | 16:00 | |
*** vijaykc4 has joined #openstack-containers | 16:01 | |
*** Drago1 has joined #openstack-containers | 16:03 | |
*** vijaykc4 has quit IRC | 16:03 | |
*** Syed__ has joined #openstack-containers | 16:04 | |
*** zenirc369 has joined #openstack-containers | 16:05 | |
*** vijendar has quit IRC | 16:09 | |
*** adrian_otto has joined #openstack-containers | 16:15 | |
*** vijendar has joined #openstack-containers | 16:16 | |
strigazi | adrian_otto, About these changes https://review.openstack.org/#/q/4c0850731d40c7d42ec1a9e18c43a3614b931558,n,z I think we need to revert and make something it opt-in (or not even that). We should do secure requests by default IMO | 16:19 |
strigazi | adrian_otto, About these changes https://review.openstack.org/#/q/4c0850731d40c7d42ec1a9e18c43a3614b931558,n,z I think we need to revert and make them opt-in (or not even that). We should do secure requests by default IMO | 16:19 |
adrian_otto | yes, I prefer secure by default as the guiding principle | 16:20 |
adrian_otto | I expect these were proposed for a reason, but I did not review them, so I'm not sure what that was. Has that reason been eliminated? | 16:21 |
strigazi | It's about the requests that the cluster nodes do to magnum. The reason is: "A lot of deployments use self signed certs" | 16:21 |
strigazi | "Curl breaks in those cases trying to validate certs against known set of CAs" | 16:22 |
strigazi | That's the commit message, there is no bug | 16:22 |
adrian_otto | we could use letsencrypt certs by default | 16:22 |
*** dimtruck is now known as zz_dimtruck | 16:23 | |
strigazi | It's per deployment I think. eg we have signed certs by some known CA | 16:24 |
adrian_otto | or we could still use self signed certificates, and turn off certificate validation in our curl requests | 16:24 |
adrian_otto | that's still better than using raw HTTP | 16:24 |
*** zz_dimtruck is now known as dimtruck | 16:24 | |
adrian_otto | in fact, we could have an optional configuration option to disable cert checks in curl requests, and disable that option by default | 16:25 |
*** dsariel has quit IRC | 16:27 | |
*** fragatina has quit IRC | 16:29 | |
*** fragatina has joined #openstack-containers | 16:30 | |
*** vijaykc4 has joined #openstack-containers | 16:31 | |
*** salmankhan has quit IRC | 16:35 | |
*** dimtruck is now known as zz_dimtruck | 16:35 | |
*** sdake_ has joined #openstack-containers | 16:36 | |
*** salmankhan has joined #openstack-containers | 16:37 | |
*** sdake has quit IRC | 16:38 | |
strigazi | I agree with that ^^ | 16:38 |
*** rcernin has quit IRC | 16:39 | |
*** vijaykc4 has quit IRC | 16:45 | |
*** mjura has quit IRC | 16:47 | |
*** salmankhan has quit IRC | 16:49 | |
*** vijaykc4 has joined #openstack-containers | 16:49 | |
*** ricolin has quit IRC | 16:50 | |
*** prameswar has quit IRC | 16:50 | |
*** sacharya has quit IRC | 16:54 | |
*** sacharya has joined #openstack-containers | 16:54 | |
*** tonanhngo has joined #openstack-containers | 16:56 | |
*** tonanhngo has quit IRC | 16:56 | |
*** EricGonczer_ has joined #openstack-containers | 16:59 | |
openstackgerrit | Merged openstack/magnum-ui master: Remove Xstatic packages from requirements https://review.openstack.org/430941 | 16:59 |
*** zz_dimtruck is now known as dimtruck | 17:07 | |
*** hishh has quit IRC | 17:10 | |
*** chhavi has joined #openstack-containers | 17:10 | |
*** salmankhan has joined #openstack-containers | 17:16 | |
*** salmankhan has quit IRC | 17:23 | |
openstackgerrit | Jason Dunsmore proposed openstack/magnum master: Allow deletion of clusters with unsupported driver https://review.openstack.org/428437 | 17:23 |
*** chhavi has quit IRC | 17:26 | |
*** vijaykc4 has quit IRC | 17:27 | |
*** EricGonczer_ has quit IRC | 17:28 | |
*** vijaykc4 has joined #openstack-containers | 17:30 | |
*** adrian_otto1 has joined #openstack-containers | 17:39 | |
*** adrian_otto has quit IRC | 17:42 | |
*** swatson has joined #openstack-containers | 17:44 | |
*** salmankhan has joined #openstack-containers | 17:50 | |
*** adrian_otto1 has quit IRC | 17:51 | |
*** adrian_otto has joined #openstack-containers | 17:53 | |
*** zenirc369 has quit IRC | 18:02 | |
*** vijendar has quit IRC | 18:17 | |
*** EricGonczer_ has joined #openstack-containers | 18:26 | |
*** jberkus has joined #openstack-containers | 18:26 | |
*** robcresswell has quit IRC | 18:35 | |
*** amit213 has quit IRC | 18:35 | |
*** nikhil has quit IRC | 18:35 | |
*** janonymous has quit IRC | 18:35 | |
*** vijendar has joined #openstack-containers | 18:42 | |
*** serverascode has quit IRC | 18:45 | |
*** etoews has quit IRC | 18:45 | |
*** hogepodge has quit IRC | 18:45 | |
*** tonanhngo has joined #openstack-containers | 18:45 | |
*** tonanhngo has quit IRC | 18:47 | |
*** tonanhngo has joined #openstack-containers | 18:48 | |
*** vijendar has quit IRC | 18:58 | |
*** vijendar has joined #openstack-containers | 18:58 | |
*** vijendar1 has joined #openstack-containers | 19:00 | |
*** vijendar has quit IRC | 19:00 | |
*** vijendar has joined #openstack-containers | 19:01 | |
*** vijendar1 has quit IRC | 19:01 | |
*** vijendar1 has joined #openstack-containers | 19:02 | |
*** vijendar has quit IRC | 19:02 | |
*** Drago1 has quit IRC | 19:07 | |
*** faizy has quit IRC | 19:08 | |
*** jasond has quit IRC | 19:18 | |
*** vijendar1 has quit IRC | 19:18 | |
*** jasond has joined #openstack-containers | 19:18 | |
*** vijendar1 has joined #openstack-containers | 19:18 | |
*** vijendar1 has quit IRC | 19:22 | |
*** vijendar has joined #openstack-containers | 19:23 | |
*** etoews has joined #openstack-containers | 19:26 | |
*** jasond has quit IRC | 19:27 | |
*** jasond has joined #openstack-containers | 19:27 | |
*** salmankhan has quit IRC | 19:27 | |
*** dimtruck is now known as zz_dimtruck | 19:30 | |
*** serverascode has joined #openstack-containers | 19:31 | |
*** vijaykc4 has quit IRC | 19:33 | |
openstackgerrit | Vijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas https://review.openstack.org/426981 | 19:36 |
*** fragatina has quit IRC | 19:37 | |
*** fragatina has joined #openstack-containers | 19:37 | |
*** code34 has joined #openstack-containers | 19:38 | |
*** juggler has joined #openstack-containers | 19:39 | |
openstackgerrit | Vijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas https://review.openstack.org/426981 | 19:43 |
*** EricGonczer_ has quit IRC | 19:44 | |
*** EricGonczer_ has joined #openstack-containers | 19:45 | |
*** salmankhan has joined #openstack-containers | 19:47 | |
*** sacharya has quit IRC | 19:47 | |
*** sacharya has joined #openstack-containers | 19:48 | |
*** tonanhngo has quit IRC | 19:54 | |
*** robcresswell has joined #openstack-containers | 19:55 | |
openstackgerrit | Vijendar Komalla proposed openstack/python-magnumclient master: Add magnum client support for resource quotas https://review.openstack.org/426981 | 19:55 |
*** sacharya_ has joined #openstack-containers | 19:56 | |
*** sacharya has quit IRC | 19:57 | |
*** nikhil has joined #openstack-containers | 20:03 | |
*** tonanhngo has joined #openstack-containers | 20:08 | |
*** salmankhan1 has joined #openstack-containers | 20:09 | |
*** vijendar has quit IRC | 20:09 | |
*** salmankhan has quit IRC | 20:09 | |
*** salmankhan1 is now known as salmankhan | 20:09 | |
*** vijendar has joined #openstack-containers | 20:10 | |
*** amit213 has joined #openstack-containers | 20:11 | |
*** janonymous has joined #openstack-containers | 20:14 | |
*** hogepodge has joined #openstack-containers | 20:19 | |
*** salmankhan has quit IRC | 20:20 | |
*** fragatina has quit IRC | 20:27 | |
*** vijendar has quit IRC | 20:29 | |
*** vijendar1 has joined #openstack-containers | 20:29 | |
*** salmankhan has joined #openstack-containers | 20:34 | |
*** vijendar1 has quit IRC | 20:34 | |
*** salmankhan has quit IRC | 20:38 | |
*** pcaruana has quit IRC | 20:43 | |
*** vijendar1 has joined #openstack-containers | 20:48 | |
*** sdake has joined #openstack-containers | 20:54 | |
openstackgerrit | Vijendar Komalla proposed openstack/magnum master: Add micro version and release notes for quotas API https://review.openstack.org/431160 | 20:55 |
*** EricGonczer_ has quit IRC | 20:57 | |
*** sdake_ has quit IRC | 20:58 | |
*** EricGonczer_ has joined #openstack-containers | 21:00 | |
*** sacharya_ has quit IRC | 21:05 | |
*** sacharya has joined #openstack-containers | 21:06 | |
*** Drago1 has joined #openstack-containers | 21:06 | |
*** vijendar1 has quit IRC | 21:10 | |
*** askb has joined #openstack-containers | 21:15 | |
*** zz_dimtruck is now known as dimtruck | 21:18 | |
*** dave-mccowan has quit IRC | 21:26 | |
*** sacharya_ has joined #openstack-containers | 21:29 | |
*** adrian_otto has quit IRC | 21:29 | |
*** sacharya has quit IRC | 21:29 | |
*** vijendar1 has joined #openstack-containers | 21:32 | |
*** Jeffrey4l has quit IRC | 21:34 | |
*** Jeffrey4l has joined #openstack-containers | 21:34 | |
*** dave-mccowan has joined #openstack-containers | 21:46 | |
*** adrian_otto has joined #openstack-containers | 21:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum-ui master: Imported Translations from Zanata https://review.openstack.org/430073 | 22:01 |
*** sdake has quit IRC | 22:02 | |
*** vijendar1 has quit IRC | 22:02 | |
openstackgerrit | Vijendar Komalla proposed openstack/magnum master: Add micro version and release notes for quotas API https://review.openstack.org/431160 | 22:02 |
*** sdake has joined #openstack-containers | 22:02 | |
*** jmckind has quit IRC | 22:03 | |
*** vijendar has joined #openstack-containers | 22:03 | |
*** vijendar has quit IRC | 22:05 | |
*** vijendar1 has joined #openstack-containers | 22:05 | |
*** yamamoto has joined #openstack-containers | 22:10 | |
jasond | jvgrant: ping | 22:15 |
jvgrant | jasond: hi | 22:16 |
jasond | jvgrant: hey, i was thinking about our microversions discussion the other day after seeing vijendar1's patch https://review.openstack.org/#/c/431160/ | 22:17 |
jasond | jvgrant: i found a couple of examples of a new Nova API with a enforced microversion https://github.com/openstack/nova/commit/fa002925460e70d988d1b4dd1ea594c680a43740#diff-a44099b611598e3071e3a44b04424e7fR138 https://github.com/openstack/nova/commit/c9091d0871948377685feca0eb2e41d8ad38228a#diff-a44099b611598e3071e3a44b04424e7fR37 | 22:17 |
jasond | jvgrant: so i'm just wondering if we should be doing it like that | 22:18 |
jvgrant | jasond: the problem is pecan which nova doesn't use | 22:19 |
jvgrant | jasond: i think i might have found a possible fix though. i'm trying out a few things | 22:19 |
jasond | jvgrant: and if we should be documenting new apis as if they were microversioned | 22:20 |
jasond | jvgrant: ok, cool | 22:20 |
jvgrant | jasond: i really want it to work the same way as nova because i agree that we should document them as if they were microversioned | 22:20 |
vijendar1 | jvgrant jasond so, are we going to enforce micro-version like nova? | 22:21 |
jvgrant | jasond: just trying to figure out how to handle that first call per controller where pecan goes through and enumerates all the methods. | 22:21 |
jasond | jvgrant: well, if https://review.openstack.org/#/c/427907/ merges, then we are documenting the rotate ca-cert api as if it were microversioned when it's not | 22:21 |
jvgrant | jasond: that pecan enumeration should always be "latest" but it uses whatever is sent with the first call | 22:21 |
jasond | jvgrant: same with https://review.openstack.org/#/c/431160/ | 22:22 |
jasond | jvgrant: i see | 22:22 |
jvgrant | jvgrant: it still is in documentation form, but it is not enforced after that patch | 22:22 |
jasond | vijendar1: i think we need to fix a bug with pecan before we can do that | 22:23 |
jvgrant | vijendar1: yeah, until that is fixed a new api should not have the header or the header should be 1.1 | 22:24 |
vijendar1 | jvgrant jasond what is the point in enforcing micro-version? | 22:24 |
vijendar1 | jvgrant jasond documenting is ok | 22:24 |
jasond | vijendar1: https://specs.openstack.org/openstack/nova-specs/specs/kilo/implemented/api-microversions.html | 22:24 |
vijendar1 | jvgrant jasond but I am still trying to understand if there is any issue if we don't enforce version | 22:24 |
vijendar1 | jasond: will take a look | 22:25 |
jasond | vijendar1: it's for backwards incompatible api changes | 22:25 |
jvgrant | jasond, vijendar1: it helps with backwards compatibility. it allows an API that is changed to still be supported | 22:25 |
jasond | vijendar1: there isn't, but should we even bump the microversion at all? | 22:25 |
jasond | jvgrant: ^? | 22:25 |
jvgrant | jasond, vijendar1: but in the case of a new api which has no different version.... no there really isn't much gained by enforcing micro-versioning | 22:25 |
jvgrant | the micro-version documentation bump is nice because it provides a history of overall api changes | 22:26 |
jvgrant | micro-versions are accomplishing 2 goals: 1) provide backwards compatibility for changes, 2) provide a scheme for documenting api changes | 22:27 |
jvgrant | we are still providing 2) even when we don't enforce it | 22:27 |
jvgrant | before enforcing micorversions there are plenty of examples of still documenting API changes in the code as X.Y | 22:28 |
jasond | jvgrant: ok, that's what i was wondering | 22:29 |
jasond | jvgrant: thanks for clarifying | 22:29 |
jvgrant | jasond, vijendar1: that said I really do want the mirco-version header to work for all cases so I'm going to continue to work on a fix | 22:29 |
*** fragatina has joined #openstack-containers | 22:30 | |
jvgrant | for now though, we will just enforce with the header when there is an actual existing API change | 22:30 |
jasond | jvgrant: cool, we can add those headers back after that fix is in | 22:30 |
*** EricGonczer_ has quit IRC | 22:30 | |
jvgrant | jasond: yes. If I find a fix I'll probably go ahead and add headers to all the APIs just so that is very clear across them all what micro-versions each method supports | 22:30 |
jasond | jvgrant: sounds good | 22:31 |
*** dave-mccowan has quit IRC | 22:31 | |
*** sdake_ has joined #openstack-containers | 22:32 | |
vijendar1 | jvgrant jasond I am still wondering if I should remove enforcement from this patch or not https://review.openstack.org/#/c/391301/ | 22:34 |
jasond | vijendar1: i think so | 22:34 |
jasond | same issue as https://review.openstack.org/#/c/427907/ | 22:34 |
vijendar1 | jasond: if I don't remove, first call would fail…right? | 22:34 |
vijendar1 | jasond: ok | 22:35 |
vijendar1 | jasond: will submit my patch now | 22:35 |
jasond | vijendar1: yeah, see the example in https://bugs.launchpad.net/magnum/+bug/1659431 | 22:35 |
openstack | Launchpad bug 1659431 in Magnum "Unexpected response from microversioned API" [Medium,In progress] - Assigned to Jason Dunsmore (jasondunsmore) | 22:35 |
*** sdake has quit IRC | 22:36 | |
vijendar1 | jasond: ok..got it. | 22:36 |
jvgrant | vijendar1: you will see it if you make the call without using "latest" header | 22:36 |
jvgrant | vijendar1: if you send even 1 call with "latest" to that controller then it will work fine and you won't see the error | 22:37 |
vijendar1 | jvgrant: got it | 22:37 |
vijendar1 | thanks jvgrant jasond | 22:37 |
jasond | vijendar1: np | 22:37 |
openstackgerrit | Vijendar Komalla proposed openstack/magnum master: Don't enforce microversion for stats API https://review.openstack.org/431210 | 22:38 |
jvgrant | vijendar1: the CLI client always sends the header so if you use that you will never see the bug | 22:38 |
vijendar1 | jvgrant: that's why I didn't encounter this bug when I tested (I believe) | 22:39 |
jvgrant | vijedar1: correct. Also if you send the correct version header the first call everything works fine as well from then on. You would have had to send a < 1.4 header on the very first call to see the bug | 22:44 |
*** vijendar1 has quit IRC | 22:50 | |
*** huzhengchuan has joined #openstack-containers | 22:52 | |
*** jasond has quit IRC | 23:01 | |
*** chris_hultin is now known as chris_hultin|AWA | 23:03 | |
*** swatson has quit IRC | 23:04 | |
*** tonanhngo has quit IRC | 23:12 | |
*** catintheroof has quit IRC | 23:25 | |
*** huzhengchuan has quit IRC | 23:26 | |
*** fragatina has quit IRC | 23:29 | |
*** fragatina has joined #openstack-containers | 23:30 | |
*** dimtruck is now known as zz_dimtruck | 23:35 | |
*** code34 has quit IRC | 23:35 | |
*** Drago1 has quit IRC | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!