*** dardelean_ has joined #openstack-containers | 00:00 | |
*** kbyrne has quit IRC | 00:38 | |
*** kbyrne has joined #openstack-containers | 00:41 | |
*** jmlowe has joined #openstack-containers | 00:41 | |
*** dardelean_ has quit IRC | 00:42 | |
openstackgerrit | Jim Bach proposed openstack/magnum master: Allow multimaster lb with no floating ip option https://review.openstack.org/574476 | 00:55 |
---|---|---|
*** dardelean_ has joined #openstack-containers | 01:05 | |
*** dardelean_ has quit IRC | 01:10 | |
*** mdnadeem has joined #openstack-containers | 01:13 | |
*** mdnadeem has quit IRC | 01:20 | |
*** dave-mccowan has quit IRC | 01:30 | |
*** mdnadeem has joined #openstack-containers | 01:33 | |
*** pengdake has joined #openstack-containers | 01:36 | |
*** hongbin has joined #openstack-containers | 02:02 | |
*** ricolin__ has joined #openstack-containers | 02:06 | |
*** rcernin is now known as rcernin|lunch | 02:35 | |
openstackgerrit | qingszhao proposed openstack/magnum-tempest-plugin master: fix tox python3 overrides https://review.openstack.org/574511 | 02:43 |
*** chhagarw has joined #openstack-containers | 02:46 | |
*** dave-mccowan has joined #openstack-containers | 02:52 | |
*** mdnadeem has quit IRC | 02:53 | |
*** sheel has joined #openstack-containers | 03:07 | |
*** Nel1x has quit IRC | 03:19 | |
*** hongbin has quit IRC | 03:26 | |
openstackgerrit | Feilong Wang proposed openstack/magnum master: Make etcd loadbalancer optional https://review.openstack.org/574540 | 03:49 |
*** ianychoi has joined #openstack-containers | 03:51 | |
*** udesale has joined #openstack-containers | 03:52 | |
*** mdnadeem has joined #openstack-containers | 03:59 | |
*** mdnadeem has quit IRC | 04:00 | |
*** mdnadeem has joined #openstack-containers | 04:00 | |
*** dave-mccowan has quit IRC | 04:05 | |
*** yamamoto has joined #openstack-containers | 04:08 | |
*** mdnadeem has quit IRC | 04:08 | |
*** ykarel|away has joined #openstack-containers | 04:09 | |
*** jmlowe has quit IRC | 04:10 | |
*** ramishra has joined #openstack-containers | 04:10 | |
*** mdnadeem has joined #openstack-containers | 04:11 | |
*** ykarel_ has joined #openstack-containers | 04:21 | |
*** ricolin__ has quit IRC | 04:21 | |
*** pengdake has quit IRC | 04:21 | |
*** ricolin has joined #openstack-containers | 04:22 | |
*** ykarel|away has quit IRC | 04:23 | |
*** flwang1 has quit IRC | 04:52 | |
*** mdnadeem has quit IRC | 04:57 | |
*** mdnadeem has joined #openstack-containers | 04:58 | |
*** yasemin has quit IRC | 05:02 | |
*** yasemin_ has quit IRC | 05:02 | |
*** yasemin has joined #openstack-containers | 05:05 | |
*** pengdake has joined #openstack-containers | 05:20 | |
*** zhubingbing has joined #openstack-containers | 05:23 | |
*** pcaruana has quit IRC | 05:24 | |
*** zhubingbing has quit IRC | 05:28 | |
*** AlexeyAbashkin has joined #openstack-containers | 05:39 | |
*** pengdake has quit IRC | 05:39 | |
*** Alexey_Abashkin has joined #openstack-containers | 05:42 | |
*** Alexey_Abashkin has quit IRC | 05:42 | |
*** Alexey_Abashkin has joined #openstack-containers | 05:42 | |
*** AlexeyAbashkin has quit IRC | 05:43 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 05:43 | |
*** AlexeyAbashkin has quit IRC | 05:45 | |
*** pengdake has joined #openstack-containers | 05:54 | |
*** mjura has joined #openstack-containers | 06:09 | |
*** iranzo has joined #openstack-containers | 06:11 | |
*** iranzo has joined #openstack-containers | 06:11 | |
*** udesale has quit IRC | 06:18 | |
*** udesale has joined #openstack-containers | 06:18 | |
*** pcaruana has joined #openstack-containers | 06:27 | |
*** dardelean_ has joined #openstack-containers | 06:35 | |
*** gsimondon has joined #openstack-containers | 06:39 | |
*** dardelean_ has quit IRC | 06:40 | |
*** pengdake has quit IRC | 06:41 | |
*** AlexeyAbashkin has joined #openstack-containers | 06:42 | |
openstackgerrit | XiaojueGuan proposed openstack/python-magnumclient master: Update links in README https://review.openstack.org/574583 | 06:45 |
*** pengdake has joined #openstack-containers | 07:03 | |
*** AlexeyAbashkin has quit IRC | 07:04 | |
*** vabada has joined #openstack-containers | 07:07 | |
*** AlexeyAbashkin has joined #openstack-containers | 07:10 | |
*** rcernin|lunch has quit IRC | 07:13 | |
*** vabada has quit IRC | 07:13 | |
*** mago_ has joined #openstack-containers | 07:14 | |
*** ykarel_ is now known as ykarel | 07:15 | |
*** zhubingbing has joined #openstack-containers | 07:25 | |
*** zhubingbing has quit IRC | 07:29 | |
*** pcaruana has quit IRC | 07:34 | |
*** serlex has joined #openstack-containers | 07:40 | |
*** b_bezak has joined #openstack-containers | 07:42 | |
*** pcaruana has joined #openstack-containers | 07:49 | |
*** ktibi has joined #openstack-containers | 07:51 | |
*** janki has joined #openstack-containers | 07:57 | |
*** pcaruana has quit IRC | 07:59 | |
*** b_bezak has quit IRC | 08:03 | |
*** pcaruana has joined #openstack-containers | 08:15 | |
*** ykarel_ has joined #openstack-containers | 08:21 | |
*** ykarel has quit IRC | 08:23 | |
*** ykarel_ is now known as ykarel | 08:28 | |
*** dardelean_ has joined #openstack-containers | 08:41 | |
*** vabada has joined #openstack-containers | 08:51 | |
*** AlexeyAbashkin has quit IRC | 08:54 | |
*** AlexeyAbashkin has joined #openstack-containers | 08:58 | |
*** salmankhan has joined #openstack-containers | 08:59 | |
*** ktibi_ has joined #openstack-containers | 09:08 | |
openstackgerrit | Merged openstack/magnum master: fix tox python3 overrides https://review.openstack.org/572964 | 09:08 |
*** skyscraper has quit IRC | 09:10 | |
*** skyscraper has joined #openstack-containers | 09:10 | |
*** ktibi has quit IRC | 09:10 | |
vabada | NAMES | 09:12 |
*** zhubingbing has joined #openstack-containers | 09:26 | |
*** flwang1 has joined #openstack-containers | 09:30 | |
flwang1 | strigazi: do we have meeting in 30 mins? | 09:31 |
*** zhubingbing has quit IRC | 09:31 | |
strigazi | flwang1: yes | 09:32 |
flwang1 | cool | 09:33 |
openstackgerrit | Spyros Trigazis proposed openstack/magnum master: WIP: Add cluster upgrade to the API https://review.openstack.org/514959 | 09:34 |
flwang1 | strigazi: did you ever see this issue https://scanner.heptio.com/95e0e1f080fe77c2a860cff8b2866f83/diagnostics/ ? | 09:34 |
strigazi | never | 09:35 |
flwang1 | hmm... ok | 09:35 |
strigazi | I had an error on Sonobuoy only once | 09:35 |
flwang1 | did you run it recently? | 09:35 |
strigazi | but it was a single error | 09:35 |
strigazi | not very | 09:36 |
strigazi | I'll create a cluster and run it | 09:36 |
flwang1 | cool, thanks | 09:36 |
flwang1 | and i have a question about lb | 09:36 |
strigazi | shoot | 09:37 |
flwang1 | if user just create a one master cluster with lb | 09:37 |
flwang1 | then he/she want to scale up to 3 masters | 09:37 |
flwang1 | can the 2 new master nodes be automatically added into the existing lb? | 09:37 |
strigazi | It doesn't work, but it a very much desired thing to | 09:37 |
strigazi | It doesn't work, but it a very much desired thing to do | 09:37 |
strigazi | yes | 09:37 |
flwang1 | yes for what? | 09:38 |
strigazi | infra wise, the nodes will be added to the lb | 09:38 |
strigazi | config-wise etcd won't work | 09:38 |
flwang1 | because some users may start with a testing/dev cluster but want to keep the possibility to migrate/upgrade to a prod | 09:38 |
strigazi | got it, makes sense | 09:39 |
*** Alexey_Abashkin has joined #openstack-containers | 09:40 | |
*** AlexeyAbashkin has quit IRC | 09:40 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 09:40 | |
flwang1 | ok, i will create a story to track it anyway | 09:40 |
strigazi | flwang1: I'm not sure if the discovery url can help on adding nodes | 09:41 |
flwang1 | strigazi: we may need a better way for ectd discovery | 09:41 |
strigazi | flwang1: etcd docs don't mention it for changing the cluster | 09:41 |
flwang1 | i will dig | 09:41 |
strigazi | flwang1: in magnum you can use your own, --discovery-url | 09:42 |
flwang1 | yes, i know that | 09:44 |
strigazi | flwang1: I'm also up for multi master without lB | 09:46 |
strigazi | flwang1: I'm also up for multi master without LB | 09:46 |
flwang1 | ok | 09:46 |
strigazi | flwang1: does that use case interest you? | 09:47 |
flwang1 | yes, i think it's useful | 09:47 |
flwang1 | but it's not on our MVP now | 09:47 |
flwang1 | the only feature missing now on our MVP list is the cluster upgrade | 09:48 |
flwang1 | but it won't block our beta release | 09:48 |
flwang1 | strigazi: did you see my patch for optional etcd lb https://review.openstack.org/#/c/574540/1/magnum/drivers/common/templates/environments/with_etcd_lb.yaml ? do you think it works? | 09:50 |
flwang1 | i haven't tested | 09:50 |
strigazi | flwang1: it should | 09:52 |
strigazi | flwang1: but, I'm not sure that we need one | 09:52 |
strigazi | flwang1: the apiserver and flannel allow you to define all etcd endpoints | 09:53 |
strigazi | flwang1: I'm not against it of course | 09:53 |
strigazi | flwang1: But I'm not sure if it is worth it | 09:53 |
flwang1 | ok, i will test it tomorrow | 09:54 |
strigazi | flwang1: even with the separate RG you were discussing, we can manage without an LB, but | 09:54 |
strigazi | flwang1: if you think is easier to manage and it is a desired feature for you +1 from me | 09:55 |
flwang1 | sorry, a little bit confusing, you mean the optional etcd lb patch or the multi master race condition patch? | 09:56 |
strigazi | I'm talking about the etcd lb patch | 09:56 |
flwang1 | cool, yep, it would be nice if we can make etcd lb optional | 09:57 |
strigazi | optional vs none at all? | 09:57 |
flwang1 | for public cloud, it means the cost of one k8s cluster could be lower | 09:57 |
*** ricolin has quit IRC | 09:57 | |
flwang1 | True mean you will get lb for etcd, False means no LB for etcd | 09:58 |
*** ricolin has joined #openstack-containers | 09:58 | |
strigazi | flwang1: for private clouds, LBs mean cores so it also expensive for us | 09:58 |
flwang1 | exactly | 09:58 |
flwang1 | then let's get it done in Rocky | 09:58 |
strigazi | #startmeeting containers | 09:58 |
openstack | Meeting started Tue Jun 12 09:58:58 2018 UTC and is due to finish in 60 minutes. The chair is strigazi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:58 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:59 |
*** openstack changes topic to " (Meeting topic: containers)" | 09:59 | |
openstack | The meeting name has been set to 'containers' | 09:59 |
strigazi | #topic Roll Call | 09:59 |
*** openstack changes topic to "Roll Call (Meeting topic: containers)" | 09:59 | |
strigazi | o/ | 09:59 |
brtknr | o/ | 09:59 |
flwang1 | o/ | 09:59 |
strigazi | Thanks for joining the meeting brtknr flwang1 :) | 10:00 |
strigazi | #topic Announcements | 10:00 |
*** openstack changes topic to "Announcements (Meeting topic: containers)" | 10:00 | |
ricolin | 0/ | 10:01 |
strigazi | Magnum is on storyboard \m/ | 10:01 |
ricolin | Yay | 10:01 |
brtknr | strigazi: Hurrah! Including blueprints> | 10:01 |
brtknr | s/>/? | 10:01 |
strigazi | I also moved the bps. Need to reset some statuses | 10:01 |
*** iranzo has quit IRC | 10:02 | |
strigazi | eg, this was a BP https://storyboard.openstack.org/#!/story/2002210 | 10:02 |
ricolin | That way we can setup cross project task cross Heat and magnum | 10:02 |
strigazi | brtknr: the problem is that what did was: | 10:02 |
strigazi | bp_status -> story_status -> task_status | 10:03 |
strigazi | but story_status is implicit and the status info got lost in the way | 10:03 |
ricolin | Here is an Etherpad I build for Heat most information also apply in magnum as well | 10:03 |
ricolin | https://etherpad.openstack.org/p/Heat-StoryBoard-Migration-Info | 10:03 |
strigazi | stotyboards client is pretty sweet so I'm scripting it again | 10:04 |
strigazi | thanks ricolin | 10:04 |
strigazi | questions about story board? | 10:04 |
strigazi | #topic Blueprints/Bugs/Ideas | 10:05 |
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)" | 10:05 | |
strigazi | I pushed a patch for uprgades, you can have a a look in the story above | 10:06 |
strigazi | oh, it is not there, I didn't add the task, but here it is: | 10:07 |
flwang1 | strigazi: thanks, but i can see the new api to list the valid versions can be upgraded to | 10:07 |
strigazi | #topic Blueprints/Bugs/Ideas | 10:07 |
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)" | 10:07 | |
strigazi | #topic Blueprints/Bugs/Ideas | 10:07 |
*** openstack changes topic to "Blueprints/Bugs/Ideas (Meeting topic: containers)" | 10:07 | |
strigazi | https://review.openstack.org/514959 | 10:07 |
strigazi | flwang1: which api? list versions? | 10:08 |
flwang1 | strigazi: yes | 10:08 |
strigazi | We don't have such thing in the spec, users can see versions in cluster templates | 10:09 |
flwang1 | ok, we can discuss it offline | 10:10 |
strigazi | ok, this is the api side | 10:10 |
strigazi | on the driver side, | 10:10 |
strigazi | I have some issues when replacing nodes | 10:11 |
strigazi | We are setting the node name so: | 10:11 |
strigazi | 1. the k8s cloud provider complains that it sees many nodes with the same name | 10:12 |
strigazi | 2. in clouds that the nova name matche dns name, vm creation won't work | 10:12 |
strigazi | does these two make sense? | 10:12 |
strigazi | s/does/do | 10:13 |
brtknr | yes | 10:13 |
flwang1 | strigazi: do we have to use the same name? | 10:14 |
strigazi | So, we need to change the name if we want heat to do the rolling replacement magic | 10:14 |
strigazi | flwang1: we don't but right now we do | 10:15 |
flwang1 | ok | 10:15 |
strigazi | flwang1: and it is more user friendly | 10:15 |
flwang1 | i don't really think it's user friendly | 10:15 |
*** salmankhan has quit IRC | 10:15 | |
ricolin | Is that the same thing that we talk about easier? | 10:15 |
flwang1 | it could be confusing | 10:15 |
strigazi | for users to see <cluster-name>-some-ids | 10:15 |
strigazi | ricolin: yes | 10:15 |
*** salmankhan has joined #openstack-containers | 10:15 | |
strigazi | flwang1: you this name is better ku-jamh4gh6zb-0-uwgdrnyx3azd-kube-master-vnzxh43pokl4 than | 10:17 |
ricolin | I’m thinking maybe we can have a Pre-action before update replace forSD | 10:17 |
strigazi | this one strkube-scanner-ne7at5fdzfhy-master-0 | 10:17 |
strigazi | my cluster is named strkube-scanner | 10:17 |
flwang1 | no, i mean only change the random id part | 10:18 |
flwang1 | we should still use the cluster name as the prefix | 10:18 |
strigazi | we need something random | 10:18 |
flwang1 | we can discuss offline | 10:18 |
strigazi | ricolin: there are two things | 10:18 |
strigazi | ricolin: one is the name issue the other is the SD dependency which I think it is not a problem in the end, I think it was an issue because of the nameing bug | 10:19 |
strigazi | I'll propose something in the storyboard we can take it there | 10:20 |
strigazi | This is it from me, last week was upgrades and storyboard | 10:21 |
* ricolin using my phone so can’t really type fast:) | 10:21 | |
strigazi | flwang1: go next? | 10:21 |
flwang1 | sure | 10:21 |
flwang1 | i'm working on many things recently | 10:21 |
strigazi | I saw, that is awesome | 10:22 |
strigazi | thanks :) | 10:22 |
flwang1 | 1. the keystone k8s integration, lingxian has done a great job to support configmap for k8s-keystone-auth | 10:22 |
flwang1 | with that case, we could be more easier to integrate it, i will add more patch sets later | 10:23 |
flwang1 | 2. I'm still working on the FEK stuff, to support logging, but i may hold it a bit due to limited bandwidth recently | 10:23 |
flwang1 | 3. the health_status and health_status_reason attributes | 10:24 |
flwang1 | it's going well, and Ricardo left some great questoins | 10:24 |
flwang1 | i will discuss it with strigazi and ricardo | 10:24 |
strigazi | #link https://review.openstack.org/#/c/570818/ | 10:25 |
flwang1 | 4. deprecate the send_cluster_metrics, it's ready for review | 10:25 |
*** ricolin has quit IRC | 10:25 | |
flwang1 | 5. fix the race condition issue when creating multi masters https://review.openstack.org/573639 | 10:25 |
flwang1 | it's ready for review, i have tested it locally, it works fine | 10:26 |
flwang1 | 6. make the etcd lb optional, see https://review.openstack.org/574540 it's still working in progress | 10:26 |
flwang1 | that's all from my side, thanks | 10:26 |
strigazi | thanks flwang1 | 10:27 |
strigazi | brtknr: want to bring up something about cgroups/ docker-ce? | 10:27 |
*** AlexeyAbashkin has quit IRC | 10:28 | |
strigazi | let's move to open discussion then | 10:29 |
strigazi | #topic Open Discussion | 10:29 |
*** openstack changes topic to "Open Discussion (Meeting topic: containers)" | 10:29 | |
strigazi | Again, the meeting time | 10:29 |
*** pengdake has quit IRC | 10:30 | |
flwang1 | i'd like to discuss the naming convention of those lovely scripts https://review.openstack.org/562454 | 10:31 |
strigazi | Recently a US company showed some interest and started to contrubute and they try to get involved, should we alternate bi-weekly? | 10:31 |
brtknr | Sorry I was AFK briefly | 10:31 |
flwang1 | strigazi: i would prefer to avoid bi-weekly alt | 10:31 |
flwang1 | because based on my experience, it doesn't work well | 10:32 |
strigazi | how can we get them though? Two weekly meetings? | 10:32 |
flwang1 | people are always confused | 10:32 |
*** ricolin has joined #openstack-containers | 10:32 | |
flwang1 | they can popup anytime actually | 10:32 |
flwang1 | it's an IRC channel | 10:32 |
flwang1 | what's their time based on our current meeting time? | 10:33 |
strigazi | yes, but we are not always online :) | 10:33 |
flwang1 | do you know their tz? | 10:33 |
strigazi | california | 10:33 |
brtknr | strigazi: 3:33 am in california right now | 10:33 |
flwang1 | ok, for that case, we can try bi-weekly alt | 10:34 |
strigazi | or two meetings? | 10:35 |
flwang1 | i don't mind 2 meetings actually | 10:35 |
brtknr | i dont mind 2 meetings either, im probably only going to come to one appropriate to my timezone | 10:35 |
strigazi | with two meetings, no one will show up and there won't be a meeting | 10:35 |
strigazi | we can 1600 ot 1700 UTC for them | 10:36 |
strigazi | we can do 1600 or 1700 UTC for them | 10:36 |
brtknr | flwang1: where are you now? | 10:36 |
flwang1 | brtknr: NZ | 10:36 |
strigazi | even 1800 UTC | 10:36 |
brtknr | so its 10pm there? | 10:37 |
flwang1 | 10:37PM | 10:37 |
brtknr | wow true dedication! | 10:37 |
brtknr | +1 to 1700 UTC | 10:37 |
flwang1 | brtknr: no worries, strigazi will buy me a beer | 10:38 |
strigazi | flwang1: or many | 10:38 |
strigazi | on berloin | 10:38 |
strigazi | on berlin | 10:38 |
flwang1 | strigazi: ok, logged | 10:38 |
ricolin | Berlin!!! | 10:38 |
strigazi | flwang1: 1700 utc for you? | 10:38 |
flwang1 | strigazi: that works for me | 10:38 |
brtknr | flwang1: thats 5am! | 10:39 |
brtknr | how about sunday? | 10:39 |
flwang1 | brtknr: it's true, i generally start up at 5 am | 10:39 |
strigazi | Ok. I can send an email and ask them | 10:39 |
brtknr | whats the company called? | 10:39 |
strigazi | in the ML | 10:39 |
strigazi | Blizzard | 10:40 |
flwang1 | brtknr: it doesn't work haha, i need to have time with kids | 10:40 |
flwang1 | strigazi: ah, Blizzard | 10:40 |
brtknr | wow! cool! world of worldcraft blizzard? | 10:40 |
flwang1 | wow | 10:40 |
flwang1 | brtknr: yes, they are using openstack a lot | 10:40 |
ricolin | Yes | 10:41 |
brtknr | i was joking about sunday | 10:41 |
flwang1 | brtknr: i know, no worries | 10:41 |
brtknr | maybe friday 5am is best? | 10:42 |
flwang1 | Friday sounds good | 10:42 |
strigazi | we can do thursday, friday for flwang1 | 10:42 |
brtknr | end of week, enough gap from tuesday | 10:42 |
*** mago_ has quit IRC | 10:42 | |
flwang1 | yep | 10:42 |
strigazi | let's see, I'll send an email | 10:43 |
strigazi | brtknr: want to discuss anything? | 10:43 |
brtknr | i'm still waiting for review | 10:43 |
brtknr | on the two things | 10:43 |
brtknr | thanks for the earlier comments | 10:44 |
flwang1 | brtknr: your patches on my list, but i need to find a time slot, sorry for that | 10:44 |
strigazi | flwang1: regarding the script name I'll check the patch, standards are good. We can make them SD as well | 10:44 |
strigazi | flwang1: since we touch them | 10:44 |
strigazi | brtknr Do you have time to add docker-ce? is it in your lsit? | 10:45 |
brtknr | strigazi: docker-ce is on my list | 10:45 |
strigazi | brtknr: we can do containerd too | 10:45 |
*** ricolin has quit IRC | 10:45 | |
brtknr | i'll read up on containerd | 10:46 |
strigazi | brtknr: What we need is to setup builds for the containers | 10:46 |
flwang1 | strigazi: thanks, pls see my comments in the renaming patch when you have time | 10:46 |
brtknr | at creation? | 10:46 |
brtknr | rather than pull image from a source? | 10:46 |
strigazi | brtknr: no, just a CI | 10:46 |
strigazi | brtknr: to populate the source | 10:46 |
brtknr | strigazi: who will host the source? | 10:47 |
strigazi | I'll see with the infra team how to setup | 10:47 |
*** ricolin has joined #openstack-containers | 10:47 | |
brtknr | strigazi: cern? docker.io? | 10:47 |
strigazi | brtknr: now we have docke.io | 10:47 |
flwang1 | strigazi: is cern using a private registry? | 10:47 |
strigazi | we can also use quay.io push to both | 10:47 |
strigazi | flwang1: yes | 10:47 |
flwang1 | what's it? | 10:48 |
strigazi | gitlan | 10:48 |
strigazi | gitlab | 10:48 |
strigazi | it implement docker registry v2 | 10:48 |
brtknr | cern's registry is super fast compared to docker.io | 10:48 |
strigazi | it implements docker registry v2 | 10:48 |
strigazi | brtknr: yes but we can't rely on it as a an OS project | 10:49 |
flwang1 | we're going to use Harbour | 10:49 |
brtknr | strigazi: i was making an observation! | 10:49 |
flwang1 | from vmware | 10:49 |
strigazi | brtknr: let's setup the ci and we can push anywhere we want | 10:49 |
brtknr | sounds good | 10:50 |
strigazi | flwang1: is it docker registry v2? | 10:50 |
flwang1 | IIRC, yes | 10:51 |
flwang1 | i will double check | 10:51 |
*** mdnadeem has quit IRC | 10:51 | |
strigazi | ok, last thing about the registry, should we have a repo for container image builds? | 10:51 |
brtknr | i'm probably going to be learning as i go along so i'll have lots of questions probably | 10:52 |
strigazi | flwang1: you think it is complicated? | 10:52 |
brtknr | could you elaborate the question? | 10:52 |
flwang1 | strigazi: it would be nice to have a repo | 10:52 |
strigazi | brtknr: have a new repo | 10:52 |
flwang1 | or we can hold it magnum repo initially | 10:52 |
strigazi | opestack/magnum-containers | 10:52 |
flwang1 | strigazi: it's not complicated | 10:53 |
strigazi | cool | 10:53 |
brtknr | oh okay i see what you mean | 10:53 |
strigazi | let's start in o/m and we see | 10:53 |
ricolin | You can build a periodic job to build it | 10:53 |
flwang1 | it would be nice if we can have a CI to public images automatically | 10:53 |
strigazi | flwang1: that is the goal | 10:53 |
brtknr | yeah dont see any immediate need to separate repos | 10:53 |
strigazi | brtknr: +1 | 10:54 |
brtknr | strigazi: although i was wondering if fedora atomic elements are still necessary | 10:54 |
brtknr | strigazi: for diskimagebuilder | 10:54 |
brtknr | strigazi: since the image works out of the box now | 10:54 |
strigazi | brtknr: they are not | 10:54 |
brtknr | strigazi: should we drop them? | 10:55 |
strigazi | brtknr: sure | 10:56 |
strigazi | we can add them back if someone needs them | 10:56 |
brtknr | when i got started with magnum, it was quite a distraction as I started building fa27 image using the elements then later realised it wasn't required at all | 10:57 |
strigazi | anyhting else for the meeting? | 10:57 |
strigazi | brtknr: I have spent quite some time with it | 10:57 |
strigazi | brtknr: it wasn't funny | 10:57 |
flwang1 | are you talking about this https://github.com/openstack/magnum/tree/master/magnum/drivers/common/image ? | 10:57 |
strigazi | flwang1: yes /fedora-atomic not the agent | 10:58 |
flwang1 | ok, got | 10:58 |
flwang1 | we don't need it | 10:58 |
*** mago_ has joined #openstack-containers | 10:58 | |
flwang1 | we may need better tagging for the heat-container-agent btw | 10:58 |
flwang1 | nothing from my side | 10:59 |
brtknr | okay great | 10:59 |
strigazi | flwang1: we can iterate when we have builds | 11:00 |
flwang1 | strigazi: cool | 11:00 |
strigazi | cool, thanks guys | 11:00 |
strigazi | #endmeeting | 11:00 |
*** openstack changes topic to "OpenStack Containers Team" | 11:00 | |
openstack | Meeting ended Tue Jun 12 11:00:32 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 11:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.html | 11:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.txt | 11:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/containers/2018/containers.2018-06-12-09.58.log.html | 11:00 |
brtknr | Btw, what is the convention for filing patches now? We first post a story and then reference story in the patch? | 11:01 |
strigazi | brtknr: yes, story and tasj | 11:01 |
strigazi | brtknr: yes, story and task | 11:01 |
*** ricolin has quit IRC | 11:03 | |
*** kaiokmo has quit IRC | 11:04 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element https://review.openstack.org/574695 | 11:14 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element https://review.openstack.org/574695 | 11:16 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Remove fedora-atomic diskimage-builder element https://review.openstack.org/574695 | 11:17 |
*** pengdake has joined #openstack-containers | 11:18 | |
brtknr | That was hard work | 11:18 |
*** markguz_ has joined #openstack-containers | 11:19 | |
*** zhubingbing has joined #openstack-containers | 11:28 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Add option to specify Cgroup driver for Kubelet https://review.openstack.org/571583 | 11:31 |
*** zhubingbing has quit IRC | 11:33 | |
*** mago_ has quit IRC | 11:39 | |
*** mago_ has joined #openstack-containers | 11:43 | |
*** AlexeyAbashkin has joined #openstack-containers | 11:45 | |
brtknr | I don't understand this error: 'Please write more unit tests, we must maintain our test coverage :(' | 11:46 |
*** Alexey_Abashkin has joined #openstack-containers | 11:48 | |
*** AlexeyAbashkin has quit IRC | 11:50 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 11:50 | |
*** AlexeyAbashkin has quit IRC | 11:52 | |
*** AlexeyAbashkin has joined #openstack-containers | 11:53 | |
strigazi | brtknr: where? | 11:58 |
*** markguz_ has quit IRC | 11:59 | |
*** vijaykc4 has joined #openstack-containers | 12:00 | |
*** dave-mccowan has joined #openstack-containers | 12:04 | |
brtknr | strigazi: when i run tox -e cover | 12:16 |
*** salmankhan has quit IRC | 12:21 | |
*** ykarel_ has joined #openstack-containers | 12:21 | |
*** ykarel has quit IRC | 12:24 | |
*** ykarel_ is now known as ykarel | 12:26 | |
*** ktibi_ is now known as ktibi | 12:29 | |
strigazi | brtknr: it says which line is missing UTs | 12:30 |
*** salmankhan has joined #openstack-containers | 12:37 | |
*** kaiokmo has joined #openstack-containers | 12:43 | |
*** pengdake has quit IRC | 12:46 | |
*** pengdake has joined #openstack-containers | 12:46 | |
*** olivenwk has joined #openstack-containers | 13:00 | |
*** pcaruana has quit IRC | 13:00 | |
*** AlexeyAbashkin has quit IRC | 13:24 | |
brtknr | strigazi: magnum/tests/unit/drivers/test_template_definition.py#L639 why is a swarm test muddled with k8s test? | 13:24 |
brtknr | https://github.com/openstack/magnum/blob/master/magnum/tests/unit/drivers/test_template_definition.py#L639 | 13:26 |
*** pengdake has quit IRC | 13:26 | |
brtknr | Also https://github.com/openstack/magnum/blob/master/magnum/tests/unit/drivers/test_template_definition.py#L665 | 13:26 |
brtknr | They're both inside "class AtomicK8sTemplateDefinitionTestCase" | 13:27 |
strigazi | brtknr: this is not good :( | 13:27 |
*** mdnadeem has joined #openstack-containers | 13:28 | |
*** zhubingbing has joined #openstack-containers | 13:29 | |
*** AlexeyAbashkin has joined #openstack-containers | 13:32 | |
*** zhubingbing has quit IRC | 13:34 | |
*** salmankhan has quit IRC | 13:36 | |
*** yamamoto has quit IRC | 13:36 | |
*** yamamoto has joined #openstack-containers | 13:37 | |
*** salmankhan has joined #openstack-containers | 13:38 | |
*** vabada has quit IRC | 13:40 | |
*** vabada has joined #openstack-containers | 13:40 | |
brtknr | strigazi: looks like swarm_fedora_atomic_v2 doesnt have many tests | 13:41 |
brtknr | if any | 13:42 |
*** pcaruana has joined #openstack-containers | 13:46 | |
brtknr | do we want to support both swarm and swarm-mode tests? | 13:46 |
*** sheel has quit IRC | 13:47 | |
strigazi | swarm-mode is far more important | 13:47 |
brtknr | yes, swarm-mode doesnt seem to have any tests | 13:51 |
*** vabada has quit IRC | 13:53 | |
*** vabada has joined #openstack-containers | 13:53 | |
strigazi | brtknr: it has functional though | 13:55 |
*** vijaykc4 has quit IRC | 14:09 | |
*** vijaykc4 has joined #openstack-containers | 14:12 | |
brtknr | strigazi: i don't understand... you mean swarm-mode is currently functional without any tests? | 14:13 |
strigazi | brtknr: No, I mean that magnum has functional tests, but not unit tests. Functional tests are more important but we need UT too | 14:15 |
*** zhubingbing has joined #openstack-containers | 14:16 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Support disabling floating IPs in swarm mode https://review.openstack.org/571200 | 14:25 |
brtknr | I have made a start on some unit tests | 14:27 |
brtknr | I am not entirely clear on what these outputs mean: | 14:29 |
brtknr | Name Stmts Miss Branch BrPart Cover | 14:29 |
brtknr | @@ -204 +204 @@ | 14:29 |
brtknr | -magnum/drivers/heat/swarm_mode_template_def.py 61 14 14 7 64% | 14:29 |
brtknr | +magnum/drivers/heat/swarm_mode_template_def.py 77 36 14 0 45% | 14:29 |
brtknr | @@ -254 +254 @@ | 14:29 |
brtknr | -TOTAL 7703 676 1264 103 90% | 14:29 |
brtknr | +TOTAL 7719 698 1264 96 90%y | 14:29 |
strigazi | you have (36 - 14) lines without UTs in -magnum/drivers/heat/swarm_mode_template_def.py | 14:30 |
strigazi | 22 lines | 14:30 |
*** ramishra has quit IRC | 14:32 | |
*** dave-mccowan has quit IRC | 14:35 | |
brtknr | how are the lines calculated? is it one test per function/class | 14:36 |
strigazi | it using "coverage" | 14:37 |
strigazi | in magnum/cover you have the report in html | 14:37 |
strigazi | you can see which lines are not covered | 14:37 |
*** hongbin has joined #openstack-containers | 14:43 | |
*** gsimondon has quit IRC | 14:49 | |
*** serlex has quit IRC | 14:49 | |
*** mdnadeem has quit IRC | 14:49 | |
*** olivenwk has quit IRC | 14:52 | |
*** mordred has quit IRC | 14:55 | |
*** jmlowe has joined #openstack-containers | 14:57 | |
*** markguz_ has joined #openstack-containers | 15:00 | |
*** mjura has quit IRC | 15:02 | |
*** dave-mccowan has joined #openstack-containers | 15:03 | |
*** markguz_ has quit IRC | 15:05 | |
*** mordred has joined #openstack-containers | 15:09 | |
*** dardelean_ has quit IRC | 15:15 | |
*** dardelean_ has joined #openstack-containers | 15:16 | |
*** dardelean_ has quit IRC | 15:21 | |
*** ykarel is now known as ykarel|away | 15:22 | |
*** vabada has quit IRC | 15:39 | |
*** yamamoto has quit IRC | 15:39 | |
*** yamamoto has joined #openstack-containers | 15:40 | |
*** yamamoto has quit IRC | 15:45 | |
brtknr | that is very useful, thanks | 15:46 |
*** mordred has quit IRC | 15:48 | |
*** ktibi has quit IRC | 15:50 | |
*** mordred has joined #openstack-containers | 15:52 | |
*** gsimondon has joined #openstack-containers | 15:52 | |
*** dardelean_ has joined #openstack-containers | 15:53 | |
*** zhubingbing has quit IRC | 15:54 | |
*** zhubingbing has joined #openstack-containers | 15:54 | |
*** zhubingbing has quit IRC | 15:55 | |
*** zhubingbing has joined #openstack-containers | 15:55 | |
*** zhubingbing has quit IRC | 15:56 | |
*** zhubingbing has joined #openstack-containers | 15:56 | |
*** zhubingbing has quit IRC | 15:56 | |
*** AlexeyAbashkin has quit IRC | 15:57 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Support disabling floating IPs in swarm mode https://review.openstack.org/571200 | 15:57 |
*** zhubingbing has joined #openstack-containers | 15:57 | |
brtknr | strigazi: could you have a look at the tests and point me towards why its failing? | 15:57 |
*** zhubingbing has quit IRC | 15:57 | |
strigazi | brtknr: UT? | 15:57 |
*** zhubingbing has joined #openstack-containers | 15:58 | |
*** dardelean_ has quit IRC | 15:58 | |
brtknr | yes | 15:58 |
brtknr | http://paste.openstack.org/show/723324/ | 15:58 |
*** zhubingbing has quit IRC | 15:58 | |
*** zhubingbing has joined #openstack-containers | 15:58 | |
brtknr | I have uploaded the most recent version for review | 15:58 |
*** zhubingbing has quit IRC | 15:59 | |
*** AlexeyAbashkin has joined #openstack-containers | 16:01 | |
*** mkrai has quit IRC | 16:08 | |
strigazi | brtknr: I couldn't spot it immediately, I'll have a closer look tmr, I have to go, thanks for going through the UTs | 16:09 |
brtknr | strigazi: thanks, enjoy your evening | 16:09 |
strigazi | brtknr: thanks, see you | 16:10 |
*** jmlowe has quit IRC | 16:13 | |
*** ykarel_ has joined #openstack-containers | 16:22 | |
*** dave-mccowan has quit IRC | 16:23 | |
*** ykarel|away has quit IRC | 16:24 | |
*** salmankhan has quit IRC | 16:33 | |
*** Alexey_Abashkin has joined #openstack-containers | 16:33 | |
*** Alexey_Abashkin has quit IRC | 16:35 | |
*** AlexeyAbashkin has quit IRC | 16:35 | |
*** salmankhan has joined #openstack-containers | 16:35 | |
*** vijaykc4 has quit IRC | 16:36 | |
*** mkrai has joined #openstack-containers | 16:36 | |
*** salmankhan has quit IRC | 16:42 | |
*** yamamoto has joined #openstack-containers | 16:42 | |
*** salmankhan has joined #openstack-containers | 16:46 | |
*** yamamoto has quit IRC | 16:49 | |
*** salmankhan has quit IRC | 16:53 | |
*** udesale has quit IRC | 16:55 | |
*** salmankhan has joined #openstack-containers | 16:56 | |
*** ykarel_ is now known as ykarel|away | 16:56 | |
*** flwang1 has quit IRC | 16:59 | |
*** gsimondon has quit IRC | 17:04 | |
*** ykarel|away has quit IRC | 17:05 | |
*** flwang1 has joined #openstack-containers | 17:06 | |
*** chhagarw has quit IRC | 17:30 | |
*** vijaykc4 has joined #openstack-containers | 17:36 | |
*** salmankhan has quit IRC | 17:38 | |
*** janki has quit IRC | 17:43 | |
*** gsimondon has joined #openstack-containers | 17:51 | |
*** dave-mccowan has joined #openstack-containers | 18:30 | |
*** dave-mccowan has quit IRC | 18:47 | |
*** yamamoto has joined #openstack-containers | 18:47 | |
*** vijaykc4 has quit IRC | 19:12 | |
*** vijaykc4 has joined #openstack-containers | 19:13 | |
*** flwang1 has quit IRC | 19:25 | |
*** salmankhan has joined #openstack-containers | 19:30 | |
*** salmankhan has quit IRC | 19:34 | |
*** vijaykc4 has quit IRC | 19:40 | |
*** vijaykc4 has joined #openstack-containers | 19:49 | |
*** dave-mccowan has joined #openstack-containers | 20:01 | |
*** zhubingbing has joined #openstack-containers | 20:01 | |
*** AlexeyAbashkin has joined #openstack-containers | 20:05 | |
*** zhubingbing has quit IRC | 20:06 | |
*** Alexey_Abashkin has joined #openstack-containers | 20:08 | |
*** AlexeyAbashkin has quit IRC | 20:09 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 20:09 | |
*** dave-mccowan has quit IRC | 20:10 | |
*** Alexey_Abashkin has joined #openstack-containers | 20:15 | |
*** dardelean_ has joined #openstack-containers | 20:16 | |
*** AlexeyAbashkin has quit IRC | 20:16 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 20:16 | |
*** dardelean_ has quit IRC | 20:19 | |
*** dardelea_ has joined #openstack-containers | 20:19 | |
*** yamamoto has quit IRC | 20:23 | |
*** dardelea_ has quit IRC | 20:28 | |
*** dardelean_ has joined #openstack-containers | 20:29 | |
*** vijaykc4 has quit IRC | 20:29 | |
*** gsimondon has quit IRC | 20:31 | |
*** dardelean_ has quit IRC | 20:33 | |
*** markguz_ has joined #openstack-containers | 20:41 | |
*** markguz_ has quit IRC | 20:45 | |
*** mkrai has quit IRC | 20:49 | |
*** markguz_ has joined #openstack-containers | 20:52 | |
*** AlexeyAbashkin has quit IRC | 20:52 | |
*** linkmark has joined #openstack-containers | 20:58 | |
*** pcaruana has quit IRC | 21:04 | |
*** flwang1 has joined #openstack-containers | 21:07 | |
*** mkrai has joined #openstack-containers | 21:10 | |
*** yamamoto has joined #openstack-containers | 21:24 | |
*** yamamoto has quit IRC | 21:39 | |
*** dtruong has quit IRC | 21:41 | |
*** dtruong has joined #openstack-containers | 21:47 | |
*** dave-mccowan has joined #openstack-containers | 22:00 | |
*** zhubingbing has joined #openstack-containers | 22:03 | |
*** zhubingbing has quit IRC | 22:07 | |
*** vijaykc4 has joined #openstack-containers | 22:08 | |
*** vijaykc4 has quit IRC | 22:23 | |
*** dardelean_ has joined #openstack-containers | 22:28 | |
*** IAMB3NW has quit IRC | 22:42 | |
*** rcernin has joined #openstack-containers | 22:44 | |
*** jmlowe has joined #openstack-containers | 22:55 | |
*** markguz_ has quit IRC | 23:04 | |
*** markguz_ has joined #openstack-containers | 23:05 | |
*** hongbin has quit IRC | 23:15 | |
*** mkrai has quit IRC | 23:15 | |
*** jmlowe has quit IRC | 23:17 | |
*** jmlowe has joined #openstack-containers | 23:18 | |
*** markguz_ has quit IRC | 23:23 | |
*** jmlowe has quit IRC | 23:31 | |
*** jmlowe has joined #openstack-containers | 23:35 | |
*** threestrands has joined #openstack-containers | 23:36 | |
*** mkrai has joined #openstack-containers | 23:36 | |
*** dardelean_ has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!