| *** hongbin has joined #openstack-containers | 00:18 | |
| *** livelace has joined #openstack-containers | 00:38 | |
| *** livelace has quit IRC | 00:46 | |
| jakeyip | @eandersson: I've looked at your review. Most of it is ok. There's one thing I'm not sure - why did the docs say to replace json.dumps() with jsonutils.dump_as_bytes() ? | 01:00 |
|---|---|---|
| eandersson | So dump_as_bytes will just do as it says, return the dump as bytes | 01:01 |
| jakeyip | @eandersson: json.dump() converts to a str, but jsonutils.dump_as_bytes() converts to a byte. The equivlant is jsonutils.dumps() | 01:01 |
| eandersson | e.g. https://review.openstack.org/#/c/631331/9/magnum/api/http_error.py | 01:02 |
| eandersson | for things like https://review.openstack.org/#/c/631331/9/magnum/db/sqlalchemy/models.py | 01:02 |
| eandersson | I wasn't sure tbh | 01:02 |
| jakeyip | I'm looking at https://review.openstack.org/#/c/631331/9/magnum/tests/functional/api/v1/models/baypatch_model.py | 01:02 |
| eandersson | I felt like it should have been bytes originally | 01:02 |
| eandersson | but I might be wrong | 01:02 |
| eandersson | Yea - same goes for those | 01:03 |
| jakeyip | previous one is oK | 01:03 |
| jakeyip | hmm wait, the second part of https://review.openstack.org/#/c/631331/9/magnum/api/http_error.py might not be ok too. | 01:04 |
| eandersson | Yea - they do the same thing | 01:04 |
| eandersson | [six.b(json.dumps(err))] vs [jsonutils.dump_as_bytes(err)] | 01:04 |
| jakeyip | reading https://six.readthedocs.io/#six.b, in py2 it returns a str. | 01:04 |
| eandersson | notice the six.b(..) | 01:04 |
| eandersson | yea bytes is not really a thing in py2 | 01:05 |
| eandersson | it's just the baseclass | 01:05 |
| jakeyip | I need to read more. Question is - if we have six handling it already, do we need to do more? (are things breaking that we need to fix that?) | 01:06 |
| eandersson | It's better practice | 01:06 |
| eandersson | but no not breaking anything | 01:06 |
| eandersson | documentation does encourage it's use thou | 01:07 |
| eandersson | > [with oslo.serialization 1.10 or newer] Replace json.dumps(obj) with oslo_serialization.jsonutils.dump_as_bytes(obj) | 01:07 |
| jakeyip | yeah I'm curious about this. why not .dumps() | 01:08 |
| eandersson | as far as I know bytes is what should be used, unless it needs to be humanly readable | 01:09 |
| eandersson | (faster etc) | 01:09 |
| eandersson | so ideally strings should be in byte format until it needs to be rendered (e.g. config file, logs etc) | 01:10 |
| jakeyip | will changing dumps() to dump_as_bytes() break anything that's using these functions expecting a str ? | 01:12 |
| eandersson | it could potentially, but only if the code isn't already handling it properly | 01:13 |
| eandersson | e.g. https://github.com/openstack/magnum/blob/54bea06b5a5f35e25fcc80353d7b9617df22ebdd/magnum/common/x509/operations.py#L108 | 01:13 |
| eandersson | the above would handle this | 01:14 |
| eandersson | but there is a risk for sure, but I would argue that if there are areas of the code that does not handle this, it should be fixed | 01:15 |
| eandersson | more "future" proof | 01:15 |
| jakeyip | hmm yeah. looking at https://github.com/openstack/oslo.serialization/commit/92f2111b26d21a30e3dda62a942aa7f28ae41537 | 01:15 |
| eandersson | I am fine with playing this safer thou, and just changing it in the place where it makes sense | 01:16 |
| eandersson | because the current patch would need a lot of manual testing to make sure we aren't missing unit-tests or functional tests | 01:17 |
| eandersson | I am also not an expert yet on Python 3, still stuck in the world of Python 2 :p | 01:17 |
| *** jaewook_oh has joined #openstack-containers | 01:19 | |
| jakeyip | I was also thinking we might need to take it in 2 passes. | 01:20 |
| eandersson | Feel free to add comments on the sections you would like reverted from dump_as_bytes to dumps | 01:21 |
| jakeyip | first pass to make it work in py3. second pass for all the 'efficiency' changes, i.e. just dumping as bytes directly and making sure everything that calls that function is handling it properly downstream. | 01:21 |
| eandersson | sure | 01:21 |
| jakeyip | ok, I'll look through that review and give comments. thanks! :) | 01:22 |
| eandersson | sounds good =] | 01:31 |
| eandersson | thanks | 01:31 |
| *** hongbin has quit IRC | 01:39 | |
| *** jaewook_oh has quit IRC | 01:40 | |
| *** hongbin has joined #openstack-containers | 01:41 | |
| *** hongbin_ has joined #openstack-containers | 01:45 | |
| *** hongbin has quit IRC | 01:45 | |
| *** jaewook_oh has joined #openstack-containers | 01:51 | |
| *** sapd1_x has joined #openstack-containers | 02:11 | |
| *** mkuf_ has quit IRC | 02:40 | |
| *** ykarel has joined #openstack-containers | 03:01 | |
| *** Bhujay has joined #openstack-containers | 03:30 | |
| *** Bhujay has quit IRC | 03:35 | |
| *** sapd1_x has quit IRC | 03:38 | |
| *** ramishra has joined #openstack-containers | 03:41 | |
| *** sapd1_x has joined #openstack-containers | 03:56 | |
| *** udesale has joined #openstack-containers | 04:00 | |
| *** udesale has quit IRC | 04:00 | |
| *** udesale has joined #openstack-containers | 04:01 | |
| *** lpetrut has joined #openstack-containers | 04:42 | |
| *** Bhujay has joined #openstack-containers | 04:43 | |
| *** ramishra has quit IRC | 04:59 | |
| *** lpetrut has quit IRC | 05:05 | |
| *** ramishra has joined #openstack-containers | 05:07 | |
| *** ykarel has quit IRC | 05:19 | |
| *** spsurya has joined #openstack-containers | 05:41 | |
| *** ykarel has joined #openstack-containers | 05:47 | |
| *** ramishra_ has joined #openstack-containers | 05:48 | |
| *** ramishra has quit IRC | 05:51 | |
| *** lpetrut has joined #openstack-containers | 06:10 | |
| *** hongbin has joined #openstack-containers | 06:25 | |
| *** hongbin has quit IRC | 06:25 | |
| *** hongbin_ has quit IRC | 06:27 | |
| *** adrianreza has quit IRC | 06:42 | |
| *** corvus has quit IRC | 06:42 | |
| *** adrianreza has joined #openstack-containers | 06:43 | |
| *** mkuf_ has joined #openstack-containers | 06:47 | |
| *** ramishra_ has quit IRC | 06:50 | |
| *** rado_ has joined #openstack-containers | 06:55 | |
| *** mkuf_ has quit IRC | 06:55 | |
| *** mkuf has joined #openstack-containers | 06:55 | |
| *** rado__ has joined #openstack-containers | 06:58 | |
| *** ramishra has joined #openstack-containers | 06:59 | |
| *** rcernin has quit IRC | 07:00 | |
| *** rado_ has quit IRC | 07:01 | |
| *** Dobroslaw has joined #openstack-containers | 07:16 | |
| *** sapd1_x has quit IRC | 07:47 | |
| *** sapd__x has joined #openstack-containers | 07:47 | |
| *** lpetrut has quit IRC | 07:58 | |
| *** ykarel is now known as ykarel|lunch | 07:58 | |
| *** ramishra has quit IRC | 08:03 | |
| *** ignaziocassano1 has joined #openstack-containers | 08:05 | |
| *** Bhujay has quit IRC | 08:09 | |
| *** ramishra has joined #openstack-containers | 08:09 | |
| *** sapd__x has quit IRC | 08:30 | |
| *** sapd__x has joined #openstack-containers | 08:30 | |
| *** ykarel|lunch is now known as ykarel | 08:32 | |
| *** Bhujay has joined #openstack-containers | 08:53 | |
| *** Bhujay has quit IRC | 08:53 | |
| *** Bhujay has joined #openstack-containers | 08:54 | |
| *** Bhujay has quit IRC | 08:55 | |
| *** Bhujay has joined #openstack-containers | 08:56 | |
| *** sapd__x has quit IRC | 09:18 | |
| *** salmankhan has joined #openstack-containers | 09:21 | |
| *** salmankhan1 has joined #openstack-containers | 09:30 | |
| *** salmankhan has quit IRC | 09:30 | |
| *** salmankhan1 is now known as salmankhan | 09:30 | |
| *** sapd__x has joined #openstack-containers | 09:30 | |
| *** ramishra has quit IRC | 09:38 | |
| *** ramishra has joined #openstack-containers | 09:40 | |
| *** salmankhan has quit IRC | 09:44 | |
| *** salmankhan has joined #openstack-containers | 09:47 | |
| *** salmankhan1 has joined #openstack-containers | 09:51 | |
| *** salmankhan has quit IRC | 09:52 | |
| *** salmankhan1 is now known as salmankhan | 09:52 | |
| *** ArchiFleKs has quit IRC | 10:07 | |
| *** ArchiFleKs has joined #openstack-containers | 10:10 | |
| *** openstackgerrit has quit IRC | 10:21 | |
| *** ramishra has quit IRC | 10:41 | |
| *** ramishra has joined #openstack-containers | 10:41 | |
| *** openstackgerrit has joined #openstack-containers | 10:44 | |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Enable metrics-server access to apiserver https://review.openstack.org/632065 | 10:44 |
| *** livelace has joined #openstack-containers | 10:46 | |
| *** udesale has quit IRC | 11:20 | |
| ignaziocassano1 | I am trying patches you just released for magnum | 11:35 |
| ignaziocassano1 | I got same issues on proxy. In the old version I modified with the help of spyros the scripts under /usr/lib/python2.7/dist-packages/magnum/drivers/common/templates/kubernetes/fragments | 11:35 |
| ignaziocassano1 | because PROXY variables are not inherited | 11:35 |
| ignaziocassano1 | in /etc/sysconfig/heat-params PROXY E NO PROXY variables are present but we must modify configure-kubernetes-master.sh to force them | 11:35 |
| ignaziocassano1 | . /etc/sysconfig/heat-params | 11:35 |
| ignaziocassano1 | echo "configuring kubernetes (master)" | 11:35 |
| ignaziocassano1 | _prefix=${CONTAINER_INFRA_PREFIX:-docker.io/openstackmagnum/} | 11:35 |
| ignaziocassano1 | export HTTP_PROXY=${HTTP_PROXY} | 11:35 |
| ignaziocassano1 | export HTTPS_PROXY=${HTTPS_PROXY} | 11:35 |
| ignaziocassano1 | export NO_PROXY=${NO_PROXY} | 11:35 |
| ignaziocassano1 | echo "HTTP_PROXY IS ${HTTP_PROXY}" | 11:35 |
| ignaziocassano1 | exporting the above variables when external network has a proxy, the master is installed but stack hangs creating kube master Resource Group | 11:35 |
| *** lpetrut has joined #openstack-containers | 11:47 | |
| *** sapd__x has quit IRC | 11:53 | |
| *** ArchiFleKs has quit IRC | 12:06 | |
| *** ArchiFleKs has joined #openstack-containers | 12:25 | |
| *** udesale has joined #openstack-containers | 12:26 | |
| *** jaewook_oh has quit IRC | 12:57 | |
| *** ykarel is now known as ykarel|away | 13:59 | |
| *** udesale has quit IRC | 14:05 | |
| *** udesale has joined #openstack-containers | 14:06 | |
| *** ykarel|away has quit IRC | 14:08 | |
| *** ignaziocassano1 has quit IRC | 14:09 | |
| *** sapd__x has joined #openstack-containers | 14:21 | |
| *** yahrens has joined #openstack-containers | 14:34 | |
| yahrens | hey! I was looking into magnum and I was wondering about the state of kubernetes cluster federations. All I could find was specs and API endpoints but not actual drivers or implementation. Did I miss something? | 14:35 |
| *** Bhujay has quit IRC | 14:43 | |
| *** rado__ has quit IRC | 14:44 | |
| *** dave-mccowan has joined #openstack-containers | 14:55 | |
| *** dave-mccowan has quit IRC | 15:12 | |
| *** Bhujay has joined #openstack-containers | 15:21 | |
| *** ykarel|away has joined #openstack-containers | 15:22 | |
| *** ykarel|away is now known as ykarel | 15:25 | |
| *** Bhujay has quit IRC | 15:43 | |
| *** munimeha1 has joined #openstack-containers | 15:52 | |
| *** ricolin has joined #openstack-containers | 15:55 | |
| *** udesale has quit IRC | 16:01 | |
| *** ricolin has quit IRC | 16:02 | |
| *** hongbin has joined #openstack-containers | 16:18 | |
| *** ramishra has quit IRC | 16:24 | |
| *** sapd__x has quit IRC | 16:25 | |
| *** yahrens has quit IRC | 16:47 | |
| *** salmankhan has quit IRC | 17:32 | |
| *** salmankhan has joined #openstack-containers | 17:35 | |
| *** fragatina has joined #openstack-containers | 17:43 | |
| *** salmankhan has quit IRC | 17:43 | |
| *** fragatina has quit IRC | 17:44 | |
| *** salmankhan has joined #openstack-containers | 17:44 | |
| *** fragatina has joined #openstack-containers | 17:44 | |
| *** fragatina has quit IRC | 17:52 | |
| *** logan- has quit IRC | 17:52 | |
| *** fragatina has joined #openstack-containers | 17:52 | |
| *** logan_ has joined #openstack-containers | 17:53 | |
| *** logan_ is now known as logan- | 17:53 | |
| *** fragatina has quit IRC | 17:55 | |
| *** fragatina has joined #openstack-containers | 17:56 | |
| *** fragatina has quit IRC | 17:58 | |
| *** fragatina has joined #openstack-containers | 17:58 | |
| *** fragatina has quit IRC | 18:03 | |
| *** fragatina has joined #openstack-containers | 18:03 | |
| *** fragatina has quit IRC | 18:05 | |
| *** fragatina has joined #openstack-containers | 18:05 | |
| *** lpetrut has quit IRC | 18:06 | |
| *** openstackgerrit has quit IRC | 18:07 | |
| *** fragatina has quit IRC | 18:07 | |
| *** fragatina has joined #openstack-containers | 18:08 | |
| *** fragatina has quit IRC | 18:08 | |
| *** fragatina has joined #openstack-containers | 18:09 | |
| *** fragatina has quit IRC | 18:09 | |
| *** fragatina has joined #openstack-containers | 18:10 | |
| *** fragatina has quit IRC | 18:11 | |
| *** fragatina has joined #openstack-containers | 18:12 | |
| *** fragatina has quit IRC | 18:13 | |
| *** fragatina has joined #openstack-containers | 18:14 | |
| *** fragatina has quit IRC | 18:15 | |
| *** fragatina has joined #openstack-containers | 18:16 | |
| *** _fragatina_ has joined #openstack-containers | 18:17 | |
| *** fragatina has quit IRC | 18:22 | |
| *** _fragatina_ has quit IRC | 18:40 | |
| *** fragatina has joined #openstack-containers | 18:41 | |
| *** fragatina has quit IRC | 18:47 | |
| *** fragatina has joined #openstack-containers | 18:47 | |
| *** fragatina has quit IRC | 18:47 | |
| *** fragatina has joined #openstack-containers | 18:48 | |
| *** ykarel has quit IRC | 18:53 | |
| *** fragatina has quit IRC | 18:56 | |
| *** fragatina has joined #openstack-containers | 18:56 | |
| *** fragatina has quit IRC | 18:57 | |
| *** fragatina has joined #openstack-containers | 18:58 | |
| *** fragatina has quit IRC | 19:03 | |
| *** fragatina has joined #openstack-containers | 19:04 | |
| *** fragatina has quit IRC | 19:07 | |
| *** fragatina has joined #openstack-containers | 19:07 | |
| -openstackstatus- NOTICE: The error causing post failures on jobs has been corrected. It is safe to recheck these jobs. | 19:16 | |
| *** fragatina has quit IRC | 19:28 | |
| *** fragatina has joined #openstack-containers | 19:29 | |
| *** fragatina has quit IRC | 19:39 | |
| *** fragatina has joined #openstack-containers | 19:39 | |
| *** fragatina has quit IRC | 19:42 | |
| *** fragatina has joined #openstack-containers | 19:43 | |
| *** fragatina has quit IRC | 20:20 | |
| *** fragatina has joined #openstack-containers | 20:21 | |
| lxkong | yankcrime: i don't think there is any ongoing work in magnum to support federation. | 20:51 |
| *** rcernin has joined #openstack-containers | 21:54 | |
| lxkong | strigazi: hi, could you please review this patch https://review.openstack.org/#/c/630820/? It's for removing the fip associated with the octavia lbs. | 22:00 |
| *** fragatina has quit IRC | 22:04 | |
| *** fragatina has joined #openstack-containers | 22:04 | |
| *** spsurya has quit IRC | 22:09 | |
| *** fragatina has quit IRC | 22:11 | |
| *** fragatina has joined #openstack-containers | 22:12 | |
| *** fragatina has quit IRC | 22:18 | |
| *** fragatina has joined #openstack-containers | 22:19 | |
| *** fragatina has quit IRC | 22:39 | |
| *** fragatina has joined #openstack-containers | 22:40 | |
| *** fragatina has quit IRC | 22:40 | |
| *** fragatina has joined #openstack-containers | 22:40 | |
| *** fragatina has quit IRC | 22:41 | |
| *** fragatina has joined #openstack-containers | 22:42 | |
| *** fragatina has quit IRC | 22:44 | |
| *** fragatina has joined #openstack-containers | 22:45 | |
| *** fragatina has quit IRC | 22:51 | |
| *** fragatina has joined #openstack-containers | 22:52 | |
| *** fragatina has quit IRC | 23:07 | |
| *** fragatina has joined #openstack-containers | 23:08 | |
| *** livelace has quit IRC | 23:15 | |
| *** livelace has joined #openstack-containers | 23:33 | |
| *** hongbin has quit IRC | 23:42 | |
| *** livelace has quit IRC | 23:42 | |
| *** munimeha1 has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!