| *** goldyfruit_ has joined #openstack-containers | 00:05 | |
| *** ricolin has joined #openstack-containers | 01:57 | |
| *** spsurya has joined #openstack-containers | 01:59 | |
| *** ykarel has joined #openstack-containers | 02:50 | |
| *** dave-mccowan has quit IRC | 02:56 | |
| *** ramishra has joined #openstack-containers | 04:06 | |
| *** pcaruana has joined #openstack-containers | 04:37 | |
| *** pcaruana has quit IRC | 05:14 | |
| *** lpetrut has joined #openstack-containers | 05:21 | |
| *** lpetrut has quit IRC | 05:26 | |
| *** udesale has joined #openstack-containers | 05:44 | |
| *** pcaruana has joined #openstack-containers | 06:13 | |
| *** jmlowe has quit IRC | 06:38 | |
| *** jmlowe has joined #openstack-containers | 07:17 | |
| *** ivve has joined #openstack-containers | 07:19 | |
| *** trident has quit IRC | 07:27 | |
| *** trident has joined #openstack-containers | 07:31 | |
| *** ykarel is now known as ykarel|lunch | 07:42 | |
| *** reddreamster has joined #openstack-containers | 07:50 | |
| *** ttsiouts has joined #openstack-containers | 07:57 | |
| *** openstackgerrit has joined #openstack-containers | 07:58 | |
| openstackgerrit | Spyros Trigazis proposed openstack/magnum master: update api-ref for clustertemplate https://review.opendev.org/679624 | 07:58 |
|---|---|---|
| openstackgerrit | Spyros Trigazis proposed openstack/magnum master: Build cluster autoscaler container images https://review.opendev.org/688648 | 08:05 |
| openstackgerrit | Spyros Trigazis proposed openstack/python-magnumclient stable/train: Add nodegroup CRUD commands https://review.opendev.org/688873 | 08:08 |
| *** lpetrut has joined #openstack-containers | 08:12 | |
| *** ykarel|lunch is now known as ykarel | 08:21 | |
| openstackgerrit | Merged openstack/magnum master: update api-ref for clustertemplate https://review.opendev.org/679624 | 08:22 |
| strigazi | brtknr: are you here? meeting in 33mins? | 08:27 |
| brtknr | yep 👍🏽 | 08:28 |
| brtknr | Strigazi, off topic, how do you install gpu drivers via containers? | 08:40 |
| strigazi | brtknr: https://gitlab.cern.ch/kosamara/nvidia-system-container/tree/a24f93cedc4d110216b8cb07e1ef1122fb198d30 | 08:42 |
| *** ramishra has quit IRC | 08:43 | |
| *** flwang1 has joined #openstack-containers | 08:46 | |
| *** ykarel is now known as ykarel|away | 08:47 | |
| flwang1 | hi team, meeting in 3 mins | 08:57 |
| strigazi | flwang1: +1 | 09:00 |
| brtknr | hi both | 09:00 |
| flwang1 | #startmeeting magnum | 09:00 |
| openstack | Meeting started Wed Oct 16 09:00:41 2019 UTC and is due to finish in 60 minutes. The chair is flwang1. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:00 |
| strigazi | brtknr: we can build this container in the ci | 09:00 |
| *** openstack changes topic to " (Meeting topic: magnum)" | 09:00 | |
| openstack | The meeting name has been set to 'magnum' | 09:00 |
| flwang1 | #topic roll call | 09:00 |
| *** openstack changes topic to "roll call (Meeting topic: magnum)" | 09:00 | |
| strigazi | o/ | 09:00 |
| *** ramishra has joined #openstack-containers | 09:00 | |
| flwang1 | o/ | 09:00 |
| brtknr | \o/ | 09:00 |
| flwang1 | i think just us? | 09:01 |
| flwang1 | let's go through the topics | 09:01 |
| flwang1 | #topic fcos driver | 09:01 |
| *** openstack changes topic to "fcos driver (Meeting topic: magnum)" | 09:01 | |
| flwang1 | strigazi: mic is on your hand now | 09:02 |
| * brtknr needs to work on that plugin to notify active users | 09:02 | |
| jakeyip | o/ sorry | 09:03 |
| strigazi | yeap, I think everything is ready | 09:03 |
| flwang1 | strigazi: see my latest comment? | 09:03 |
| flwang1 | we may need to mount /dev to get cinder work | 09:04 |
| strigazi | nothing else to do. I run e2e for calico and flannel | 09:04 |
| strigazi | flwang1: does cinder still work? | 09:04 |
| strigazi | flwang1: anyway, I'll try with an old k8s verison | 09:05 |
| flwang1 | strigazi: TBH, it's tested by one of our consumer, i haven't confirmed it | 09:06 |
| flwang1 | he used k8s v1.15.4 | 09:06 |
| strigazi | ok | 09:06 |
| brtknr | strigazi: hmm i still can see pod logs | 09:06 |
| *** ykarel|away has quit IRC | 09:06 | |
| strigazi | brtknr: context? | 09:06 |
| brtknr | for coreos containers | 09:07 |
| flwang1 | brtknr: can or can't? | 09:07 |
| brtknr | "can't" sorry | 09:08 |
| strigazi | brtknr: I don't understand. which command doesn't work? | 09:08 |
| brtknr | kubectl logs coredns-7584bf494f-vhp4d -n kube-system | 09:08 |
| brtknr | eventually times out | 09:08 |
| brtknr | Error from server: Get https://[fd13:6667:48e0:0:f816:3eff:fe55:8372]:10250/containerLogs/kube-system/coredns-7584bf494f-vhp4d/coredns: dial tcp [fd13:6667:48e0:0:f816:3eff:fe55:8372]:10250: i/o timeout | 09:08 |
| strigazi | brtknr: ipv6 | 09:08 |
| brtknr | do you disable it in config? | 09:09 |
| *** ttsiouts has quit IRC | 09:09 | |
| strigazi | brtknr: I don't have it | 09:09 |
| *** ttsiouts has joined #openstack-containers | 09:09 | |
| strigazi | ipv6 will never work with flannel anyway | 09:10 |
| brtknr | devstack automatically creates it though | 09:10 |
| strigazi | and dual stack is added as alpha in 1.16 | 09:10 |
| strigazi | I don't think we should waste time with ipv6 at this point | 09:10 |
| strigazi | I have IP_VERSION=4 in my local.conf | 09:11 |
| strigazi | brtknr: maybe with calico works | 09:11 |
| strigazi | but let's focus on ipv4? | 09:11 |
| ttsiouts | o/ | 09:11 |
| brtknr | strigazi: im happy with just ipv4 | 09:12 |
| brtknr | i wonder if this is a bug | 09:12 |
| brtknr | when a network has both ipv4 and ipv6 subnet, magnum seems to attach both to the instance | 09:12 |
| brtknr | rathar than only the one specified in the cluster template | 09:12 |
| brtknr | strigazi: no it doesnt work with calico either | 09:14 |
| strigazi | brtknr: what do you want to do? what is the use case? | 09:15 |
| brtknr | i was just going by the default devstack behaviour when you dont specify IP_VERSION=4 | 09:16 |
| brtknr | when i specify on the cluster template i want private-subnet and not ipv6-private-subnet in the cluster template, why does it use both? | 09:16 |
| brtknr | doesnt seem like an expected behaviour | 09:17 |
| strigazi | brtknr: flwang1 I don't know what to say about ipv6 | 09:18 |
| flwang1 | strigazi: personally, i don't think ipv6 is a high priority at this moment | 09:19 |
| strigazi | I can investigate altough it is a waste of time | 09:19 |
| flwang1 | we can take it as a TODO and revisit it in U release | 09:19 |
| flwang1 | and i don't think k8s support ipv6 | 09:19 |
| brtknr | its not ipv6 specifically i am expressing concerned about but i noticed that instances that get created get both ipv4 and ipv6 interfaces.... instead of just the one asked for | 09:20 |
| flwang1 | then i would say that's another separate issue | 09:21 |
| brtknr | i can ask in the #openstack-neutron channel, dont worry | 09:21 |
| flwang1 | not releated to the fcos driver, right? | 09:21 |
| brtknr | no dont think so but its only been a problem with fcos driver | 09:21 |
| flwang1 | then we can take it as a known issue and keep an eye | 09:22 |
| brtknr | my instances were being given ipv6 addresses all the time | 09:22 |
| brtknr | lets move to the next topic | 09:23 |
| flwang1 | i have raised my comments in the fcos patch | 09:24 |
| strigazi | give me a moment to check | 09:24 |
| flwang1 | 1. i have seen timeout of the heat container agent service, which has been addressed in the latest ps | 09:24 |
| flwang1 | 2. i have seen pod restart | 09:25 |
| flwang1 | 3. the cinder support needs the /dev mount | 09:25 |
| flwang1 | strigazi: could you pls try the #3? i will test it as well | 09:25 |
| strigazi | 1. i have seen pod restart, this probably happens due to slow environment | 09:26 |
| strigazi | sorry 1. | 09:26 |
| strigazi | sorry 2. | 09:26 |
| strigazi | for 3. , which version you think work? | 09:26 |
| strigazi | flwang1: if we don't add csi-cinder your clients won't be able to use cinder and new k8s versions. | 09:27 |
| flwang1 | strigazi: i understand that, we need to support csi in U release and i would say ASAP :( | 09:27 |
| strigazi | flwang1: to unblock focs, which k8s version you want to work with cinder? | 09:28 |
| flwang1 | AFAIK, the build-in cinder support code will be totally removed in v1.17.x | 09:29 |
| strigazi | ok | 09:29 |
| strigazi | so it exists in 1.16? | 09:29 |
| flwang1 | yes | 09:29 |
| flwang1 | #action /me will check when built-in cinder code will be removed from k8s | 09:30 |
| strigazi | anything else on fcos? | 09:31 |
| strigazi | we still don't have a list on what needs to be working | 09:31 |
| strigazi | apart from conformance | 09:31 |
| flwang1 | cinder support | 09:32 |
| strigazi | it needs to be written. | 09:32 |
| strigazi | maybe a functional test? | 09:33 |
| strigazi | anyway, we wasted too much time with fcos | 09:33 |
| brtknr | strigazi: i am rerunning e2e test now with ipv6 turned off | 09:33 |
| strigazi | brtknr: I'm running them too now | 09:33 |
| flwang1 | strigazi: if we can have a functional test for fcos, it would be great | 09:33 |
| flwang1 | but i don't mind adding it later | 09:33 |
| flwang1 | since i know you have already put a lot of effort on this and i do really appreciate that | 09:34 |
| strigazi | flwang1: I need everyone to provide requiements though | 09:34 |
| strigazi | let's move on | 09:34 |
| flwang1 | #topic ng | 09:34 |
| *** openstack changes topic to "ng (Meeting topic: magnum)" | 09:35 | |
| flwang1 | ttsiouts: brtknr: ? | 09:35 |
| brtknr | I tested the ng upgrades, and all looking good now | 09:35 |
| brtknr | I'm happy to merge | 09:35 |
| strigazi | \o/ | 09:35 |
| ttsiouts | flwang1: apart from the ng-10/13 series we need to take the bugs I added in the agenda | 09:36 |
| ttsiouts | brtknr: thanks again on your input! | 09:37 |
| ttsiouts | do you want me to tell you more about these? | 09:38 |
| brtknr | ttsiouts: thanks for your hard work, i just playing with toys you build :) | 09:38 |
| ttsiouts | brtknr: :) | 09:38 |
| strigazi | flwang1: brtknr any more comments on NGs? | 09:40 |
| flwang1 | cool, thank you for you guys good work, i will help review as well | 09:40 |
| brtknr | i tested the api_address patch which seems to do the job | 09:40 |
| strigazi | we take them for train? | 09:40 |
| flwang1 | strigazi: i'm ok with that | 09:40 |
| brtknr | i am not sure how to test the Failed ng state | 09:40 |
| brtknr | but Ive checked the login and it seems sensible | 09:41 |
| brtknr | but Ive checked the logic and it seems sensible | 09:41 |
| brtknr | Havent looked at the Docker volume size yet | 09:41 |
| brtknr | but also seems reasonable | 09:41 |
| strigazi | cool | 09:42 |
| ttsiouts | brtknr: to test the failed state you have to force the default ngs to go to UPDATE_FAILED. Quota can help you here | 09:42 |
| ttsiouts | brtknr: without the patch, the cluster goes to UPDATE_COMPLETE. with the patch the cluster reports UPDATE_FAILED as it should | 09:43 |
| brtknr | ttsiouts: ok cool I'll try that thanks | 09:43 |
| ttsiouts | brtknr: an easier way to force the UPDATE_FAILED would be to upgrade using a CT that does not have the kube_tag label | 09:44 |
| openstackgerrit | Spyros Trigazis proposed openstack/magnum master: Support Fedora CoreOS 30 https://review.opendev.org/678458 | 09:44 |
| ttsiouts | brtknr: scratch the upgrade test. conductor will make the cluster go to UPDATE_FAILED directly | 09:45 |
| ttsiouts | brtknr: quota is the way to go.. | 09:45 |
| brtknr | #action /me to test Failed ng state | 09:46 |
| ttsiouts | brtknr: thanks again! | 09:46 |
| strigazi | brtknr: flwang1 are you happy with fcos now so that we can take it with NGs? | 09:47 |
| flwang1 | strigazi: as long as you added the /dev mount, i'm happy with the current fcos driver status | 09:48 |
| flwang1 | we can fix small issues later | 09:48 |
| strigazi | flwang1: dev and tabs vs spaces and order in the unit, all done | 09:48 |
| flwang1 | strigazi: fantastic | 09:49 |
| flwang1 | thank you, my friend | 09:49 |
| strigazi | flwang1: cinder works with 1.14.7, just tested it | 09:49 |
| brtknr | yep /dev is there | 09:49 |
| strigazi | both dynamic provisioning and static | 09:49 |
| flwang1 | i'm going to +2 now ;) | 09:50 |
| flwang1 | next topic? | 09:50 |
| strigazi | yes | 09:51 |
| flwang1 | #topic ignition issue in heat | 09:51 |
| *** openstack changes topic to "ignition issue in heat (Meeting topic: magnum)" | 09:51 | |
| flwang1 | i have found the root cause of why the local-data doesn't work | 09:51 |
| flwang1 | i think there is a bug in os-apply-config, which will overwrite the deployments when doing config merging | 09:51 |
| flwang1 | https://review.opendev.org/688317 | 09:52 |
| flwang1 | here is the patch i proposed in os-apply-config | 09:52 |
| strigazi | cool | 09:52 |
| flwang1 | but until it's accepted, we may have to push heat team to accept this https://review.opendev.org/688322 | 09:52 |
| strigazi | +1 | 09:53 |
| flwang1 | i mean before the os-apply-config patch accepted | 09:53 |
| flwang1 | now i'm pushing heat team to review it | 09:53 |
| flwang1 | i will let you guys know when there is progress | 09:53 |
| flwang1 | next topic? we only have 6 mins | 09:54 |
| strigazi | yes | 09:54 |
| flwang1 | #topic the autoscaler image | 09:54 |
| strigazi | build autoscaler in the ci | 09:54 |
| *** openstack changes topic to "the autoscaler image (Meeting topic: magnum)" | 09:54 | |
| flwang1 | i'm ok to have it in our ci | 09:54 |
| strigazi | I +1 already | 09:54 |
| strigazi | I +2 already | 09:54 |
| *** rcernin has quit IRC | 09:54 | |
| flwang1 | approved | 09:55 |
| flwang1 | #topic heat-container-agent:train-stable? | 09:55 |
| *** openstack changes topic to "heat-container-agent:train-stable? (Meeting topic: magnum)" | 09:55 | |
| flwang1 | strigazi: can you please tag a train-stable version for heat-container-agent? | 09:55 |
| strigazi | +1 | 09:56 |
| strigazi | I'll do it | 09:56 |
| flwang1 | thank you | 09:56 |
| flwang1 | i will send an email to openstack community to announce that we will have fcos support in Train | 09:56 |
| flwang1 | that's a tremendous achievement by the team | 09:57 |
| flwang1 | we should be proud of it | 09:57 |
| flwang1 | anything else? | 09:58 |
| strigazi | you can mention NGs too, which is much bigger | 09:58 |
| flwang1 | sure, i will | 09:58 |
| flwang1 | those are the 2 things on my PTL nomination email | 09:58 |
| flwang1 | and i'm happy to see we did it | 09:59 |
| strigazi | :) | 09:59 |
| flwang1 | i really appreciate for the great work you guys done | 09:59 |
| flwang1 | THANK YOU | 09:59 |
| flwang1 | i have to go, after day light saving, now it's 11:00PM in NZ | 10:00 |
| strigazi | sleep well | 10:00 |
| strigazi | cheers | 10:00 |
| brtknr | good night flwang1 :) | 10:00 |
| flwang1 | thank you for joining | 10:00 |
| flwang1 | #endmeeting | 10:00 |
| *** openstack changes topic to "OpenStack Containers Team | Meeting: every Wednesday @ 9AM UTC | Agenda: https://etherpad.openstack.org/p/magnum-weekly-meeting" | 10:00 | |
| openstack | Meeting ended Wed Oct 16 10:00:37 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 10:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/magnum/2019/magnum.2019-10-16-09.00.html | 10:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/magnum/2019/magnum.2019-10-16-09.00.txt | 10:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/magnum/2019/magnum.2019-10-16-09.00.log.html | 10:00 |
| flwang1 | o/ | 10:00 |
| brtknr | hahadont think our #actions worked properly :) | 10:01 |
| brtknr | haha dont think our #actions worked properly :) | 10:01 |
| brtknr | oh no wait it did | 10:01 |
| *** ttsiouts has quit IRC | 10:20 | |
| *** ttsiouts has joined #openstack-containers | 10:21 | |
| *** ttsiouts has quit IRC | 10:26 | |
| openstackgerrit | Merged openstack/magnum master: Build cluster autoscaler container images https://review.opendev.org/688648 | 10:46 |
| *** ttsiouts has joined #openstack-containers | 10:53 | |
| *** ttsiouts has quit IRC | 10:58 | |
| *** gokhani has joined #openstack-containers | 11:08 | |
| *** ttsiouts has joined #openstack-containers | 11:25 | |
| *** ttsiouts has quit IRC | 11:26 | |
| *** ttsiouts has joined #openstack-containers | 11:26 | |
| *** rcernin has joined #openstack-containers | 11:31 | |
| strigazi | brtknr: do you want to push the gpu container in our repom to have it built there? | 11:38 |
| strigazi | brtknr: https://review.opendev.org/#/c/688873/1 | 11:39 |
| *** dave-mccowan has joined #openstack-containers | 11:49 | |
| openstackgerrit | Merged openstack/magnum master: Support Fedora CoreOS 30 https://review.opendev.org/678458 | 11:50 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum master: ng-10: Fix cluster template conditions https://review.opendev.org/685620 | 11:57 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum master: ng-11: API microversion 1.9 https://review.opendev.org/686089 | 11:57 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum master: ng-12: Label nodegroup nodes https://review.opendev.org/686362 | 11:57 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum master: ng-13: Support nodegroup upgrade https://review.opendev.org/686733 | 11:57 |
| ttsiouts | brtknr: strigazi: rebased on master ^ | 11:58 |
| *** sapd1 has joined #openstack-containers | 12:00 | |
| *** ivve has quit IRC | 12:03 | |
| openstackgerrit | Spyros Trigazis proposed openstack/magnum stable/train: zuul: drop secret from stable branch https://review.opendev.org/688912 | 12:06 |
| *** sapd1 has quit IRC | 12:12 | |
| *** ivve has joined #openstack-containers | 12:18 | |
| strigazi | brtknr: cluster creation is broken without passing a subnet | 12:26 |
| strigazi | can you revisit your patch? | 12:26 |
| brtknr | strigazi: hmm i dont understand how that is possible but will take a look | 12:47 |
| brtknr | strigazi: yes, gpu container is a good idea | 12:48 |
| brtknr | strigazi: e2e test still doesnt complete but it doesnt fail either | 12:49 |
| brtknr | https://seashells.io/p/gpj4xqVr | 12:49 |
| brtknr | here's my log | 12:49 |
| strigazi | sonobuoy retrive ? | 12:50 |
| strigazi | brtknr: http://paste.openstack.org/show/784099/ | 12:51 |
| strigazi | brtknr: feilong's patch above is also kinf of wrong | 12:56 |
| brtknr | strigazi: do you think the same would work even if network was missing? | 12:56 |
| strigazi | brtknr: we have hard coded names that are epxected to exist | 12:57 |
| strigazi | brtknr: the default in heat are to create the resources with that name | 12:57 |
| strigazi | brtknr: the defaults in heat are to create the resources with that name | 12:57 |
| openstackgerrit | Merged openstack/python-magnumclient stable/train: Add nodegroup CRUD commands https://review.opendev.org/688873 | 13:00 |
| brtknr | which patch specifically? | 13:00 |
| brtknr | context? | 13:00 |
| brtknr | https://seashells.io/v/XTUsJb8h | 13:03 |
| brtknr | but i also get this afterwards: ERRO[0000] could not process archive: 201910160931_sonobuoy_13e1df8f-d524-4d2f-a954-eef3772d66ca.tar.gz: failed to find file "plugins/e2e/sonobuoy_results.yaml" in archive | 13:03 |
| strigazi | https://review.opendev.org/#/c/629514/14/magnum/drivers/heat/k8s_template_def.py subnet patch | 13:06 |
| strigazi | brtknr this was with ipv6 on? | 13:07 |
| *** lxkong has joined #openstack-containers | 13:07 | |
| brtknr | strigazi: this was with ipv6 off | 13:07 |
| brtknr | i had to delete the ipv6 subnet | 13:07 |
| strigazi | brtknr: I don't have the issue, I can't think why it doesn't work for you | 13:08 |
| brtknr | strigazi: which version of sonobuoy are you using? | 13:08 |
| strigazi | sonobuoy_0.16.1_linux_amd64 | 13:09 |
| brtknr | hmm me too | 13:11 |
| strigazi | brtknr: if the user hasn't provided a net work or subnet, we shouldn't try to find the uuid for the 'private' network nor 'private-subnet' | 13:16 |
| strigazi | brtknr: if the user hasn't provided a net work or subnet, we shouldn't try to find the uuid for the 'private' network nor 'private' subnet | 13:16 |
| brtknr | strigazi: yes I agree | 13:18 |
| brtknr | strigazi: is this created by heat? | 13:18 |
| strigazi | brtknr: yes | 13:18 |
| brtknr | in which case how do we get uuid later? | 13:18 |
| brtknr | strigazi: | 13:18 |
| strigazi | https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/network.yaml#L66 | 13:19 |
| strigazi | I want to change all that with heat conditiones | 13:19 |
| strigazi | I want to change all that with heat conditions | 13:19 |
| strigazi | Magnum::NetworkSwitcher hides some magic | 13:20 |
| strigazi | nasty heat teamplate magic | 13:20 |
| brtknr | what about name in some cases | 13:21 |
| brtknr | instead of ID | 13:21 |
| brtknr | strigazi: also does fixed_network and fixed_subnet need to be defined at all in template_def? | 13:22 |
| brtknr | since these are default values in heat template | 13:22 |
| brtknr | same for external_network | 13:22 |
| strigazi | what is required by occm is the name to id change | 13:22 |
| brtknr | strigazi: it needs fixed_network_name and subnet uuid | 13:23 |
| brtknr | strigazi: i can see a private_network_name | 13:25 |
| strigazi | brtknr: where? | 13:26 |
| brtknr | https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/network.yaml#L66 | 13:26 |
| strigazi | brtknr: I think the issue is clear no? | 13:26 |
| brtknr | https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/network.yaml#L37 | 13:26 |
| brtknr | strigazi: the final piece missing is if heat creates the network and the subnet, how do we make sure the fixed_network_name is defined | 13:27 |
| strigazi | when heat creates the resources everything is there | 13:27 |
| strigazi | https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/network.yaml will always return the subnet and the network | 13:29 |
| strigazi | my devstack is broken, again, libvirt can't create vms... | 13:31 |
| brtknr | strigazi: but fixed_network_name is not one of the outputs at present | 13:32 |
| strigazi | where is it used? fixed_network_name ? | 13:34 |
| strigazi | come one | 13:34 |
| strigazi | this is easy | 13:34 |
| strigazi | let me walk you through our heat nightmare | 13:34 |
| strigazi | fixed_network_name is passed here https://github.com/openstack/magnum/blob/3674b3617a770bd71d09e23137ff96f90eb1241a/magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml#L747 | 13:35 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Ensure cluster creation proceeds when fixed subnet is not defined https://review.opendev.org/688928 | 13:35 |
| strigazi | then network.yaml returns it as fixed_network https://github.com/openstack/magnum/blob/3674b3617a770bd71d09e23137ff96f90eb1241a/magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml#L973 | 13:35 |
| brtknr | fixed network name is defined here: https://github.com/openstack/magnum/blob/3674b3617a770bd71d09e23137ff96f90eb1241a/magnum/drivers/k8s_fedora_atomic_v1/templates/kubecluster.yaml#L974 | 13:36 |
| strigazi | this is wrong, what is it doing here? fixed_network_name: {get_param: fixed_network_name} | 13:36 |
| brtknr | this is what im trying to get at | 13:36 |
| strigazi | why we need it? | 13:37 |
| *** udesale has quit IRC | 13:37 | |
| strigazi | what on earth is going on with the occm? | 13:37 |
| *** udesale has joined #openstack-containers | 13:37 | |
| strigazi | brtknr: it needs names or ids? | 13:37 |
| strigazi | can we just use uuid? | 13:37 |
| brtknr | it sometimes needs names, other times id | 13:37 |
| brtknr | lol | 13:37 |
| brtknr | its a mess, i know | 13:38 |
| strigazi | this is wrong, everything should come from the network.yaml when passed to the resoruces groupsfixed_network_name: {get_param: fixed_network_name}1;5D | 13:38 |
| strigazi | brtknr: do you know where is it defined in the occm? | 13:39 |
| brtknr | in /etc/kubernetes/cloud-config-occm | 13:40 |
| strigazi | in not our code | 13:41 |
| strigazi | not our code | 13:41 |
| brtknr | internal-network-name=private | 13:41 |
| brtknr | i have no idea what uses fixed_network uuid itself | 13:42 |
| brtknr | but fixed_network_name is used there | 13:42 |
| strigazi | https://github.com/kubernetes/cloud-provider-openstack/blame/52ba230135c8834daaf8bcf7aec295251ec736d4/pkg/cloudprovider/providers/openstack/openstack.go#L150 | 13:42 |
| strigazi | this is wrong too PublicNetworkName string `gcfg:"public-network-name"` | 13:42 |
| brtknr | strigazi: well, yes | 13:43 |
| strigazi | brtknr: your patch for internal-network name needs to change so that the name comes from network.yaml. | 13:44 |
| strigazi | we also needs some sanity and have id supported everywhere in the occm | 13:44 |
| strigazi | we also need some sanity and have id supported everywhere in 1;5Dthe occm | 13:44 |
| brtknr | strigazi: +2, i dont understand why they opted for name as the default | 13:45 |
| strigazi | Can you do our side of the patches? | 13:46 |
| brtknr | i can try, this seems to create the cluster for me: https://review.opendev.org/688928 | 13:47 |
| brtknr | without specifying private subnet | 13:47 |
| strigazi | by devstack has two subnets named private-subnet | 13:48 |
| strigazi | brtknr: I guess you have subnet named private | 13:50 |
| brtknr | yep | 13:51 |
| strigazi | I don't | 13:51 |
| brtknr | i have subnet named private-subnet | 13:51 |
| brtknr | not private | 13:52 |
| brtknr | i can see a new subnet has been created | 13:52 |
| brtknr | by heat | 13:52 |
| strigazi | in any case it is wrong | 13:52 |
| strigazi | what? | 13:52 |
| brtknr | k8s-flannel-fedora-atomic-46whwk5uaba4-network-3sepekxnsi4l-private_subnet-sfhgwfs4cicx | 13:52 |
| *** reddreamster has quit IRC | 13:53 | |
| strigazi | openstack stack show | grep "fixed_network\" | 13:53 |
| strigazi | openstack stack show | grep "fixed_network\|fixed_subnet" | 13:53 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Ensure cluster can be created when fixed subnet is undefined https://review.opendev.org/688928 | 13:54 |
| strigazi | brtknr: openstack stack show | grep "fixed_network\|fixed_subnet" | 13:55 |
| brtknr | you mean openstack stack list --nested? | 13:56 |
| strigazi | no, I want to see the parameted | 13:56 |
| strigazi | no, I want to see the parameters | 13:56 |
| *** rcernin has quit IRC | 13:57 | |
| brtknr | ubuntu@devstack-master:/opt/stack/magnum$ openstack stack show k8s-flannel-fedora-atomic-46whwk5uaba4 | grep fixed | 13:58 |
| brtknr | | | fixed_network: '' | 13:58 |
| brtknr | | | 13:59 |
| brtknr | | | fixed_network_cidr: 10.0.0.0/24 | 13:59 |
| brtknr | | | 13:59 |
| brtknr | | | fixed_network_name: private | 13:59 |
| brtknr | | | 13:59 |
| brtknr | | | fixed_subnet: '' | 13:59 |
| strigazi | and what is the network name now? | 14:00 |
| brtknr | its "private" but im pretty sure thats coming from template_def rather than heat | 14:02 |
| strigazi | https://github.com/openstack/magnum/commit/e84cc4c9759a3b52a04efa93fe0ddb230ffb6c23#diff-a3910005320a5793077536c97689f2eeL693 | 14:06 |
| strigazi | I was still there | 14:06 |
| strigazi | I don't know | 14:06 |
| strigazi | let's leave it like this, I can't think anymore about uuids | 14:06 |
| strigazi | it might break some people, but I admit I have lost track with this | 14:07 |
| strigazi | we pass the same thing twice | 14:07 |
| strigazi | for me, it broke my devstack setup, but I can always pass a network and a subnet, not an issue | 14:08 |
| strigazi | but changing the default behavior always bites. | 14:09 |
| brtknr | strigazi: fine, do you think this is reasonable for now until occm starts accepting uuid? https://review.opendev.org/#/c/688928 | 14:12 |
| *** mgoddard has quit IRC | 14:28 | |
| *** mgoddard has joined #openstack-containers | 14:30 | |
| brtknr | strigazi: also i dont understand how this patch broke your devstack lol | 14:39 |
| strigazi | brtknr: devstack, I guess recently, started to create the default subnet as private-subnet | 14:40 |
| brtknr | strigazi: should we change the heat template accordingly? | 14:40 |
| strigazi | we don't need to since we create the resourcves | 14:41 |
| *** primeministerp has quit IRC | 14:44 | |
| strigazi | with 688928 it works | 14:53 |
| *** munimeha1 has joined #openstack-containers | 14:59 | |
| brtknr | strigazi: cool | 15:00 |
| *** ivve has quit IRC | 15:05 | |
| *** trident has quit IRC | 15:13 | |
| *** trident has joined #openstack-containers | 15:17 | |
| *** lxkong has quit IRC | 15:39 | |
| *** ttsiouts has quit IRC | 15:39 | |
| *** ttsiouts has joined #openstack-containers | 15:40 | |
| *** ttsiouts has quit IRC | 15:44 | |
| openstackgerrit | Merged openstack/magnum master: ng-10: Fix cluster template conditions https://review.opendev.org/685620 | 15:54 |
| openstackgerrit | Merged openstack/magnum master: ng-11: API microversion 1.9 https://review.opendev.org/686089 | 16:00 |
| *** lpetrut has quit IRC | 16:04 | |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Ensure cluster can be created when fixed subnet is undefined https://review.opendev.org/688928 | 16:09 |
| openstackgerrit | Merged openstack/magnum master: ng-12: Label nodegroup nodes https://review.opendev.org/686362 | 16:10 |
| openstackgerrit | Merged openstack/magnum master: ng-13: Support nodegroup upgrade https://review.opendev.org/686733 | 16:10 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum master: Ensure cluster can be created without fixed subnet https://review.opendev.org/688928 | 16:13 |
| *** sapd1 has joined #openstack-containers | 16:16 | |
| *** ramishra has quit IRC | 16:34 | |
| *** udesale has quit IRC | 16:40 | |
| *** goldyfruit has joined #openstack-containers | 17:03 | |
| *** goldyfruit_ has quit IRC | 17:05 | |
| *** munimeha1 has quit IRC | 17:18 | |
| *** sapd1 has quit IRC | 17:27 | |
| *** ricolin has quit IRC | 17:36 | |
| *** spsurya has quit IRC | 17:58 | |
| *** lbragsta_ has joined #openstack-containers | 19:48 | |
| *** flwang1 has quit IRC | 19:59 | |
| *** pcaruana has quit IRC | 20:28 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: Release k8s v1.13.12, v1.14.8, v1.15.5, v1.16.2 https://review.opendev.org/689042 | 20:57 |
| *** lbragsta_ has quit IRC | 22:26 | |
| *** lbragsta_ has joined #openstack-containers | 23:35 | |
| *** lbragsta_ has quit IRC | 23:45 | |
| *** flwang has joined #openstack-containers | 23:58 | |
| flwang | brtknr: around? | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!