*** sapd1 has joined #openstack-containers | 01:09 | |
*** sapd1 has quit IRC | 01:39 | |
*** sapd1 has joined #openstack-containers | 02:37 | |
*** jerryz has quit IRC | 02:45 | |
*** ricolin_ has joined #openstack-containers | 02:51 | |
*** razorfishsl has joined #openstack-containers | 02:58 | |
*** sapd1 has quit IRC | 03:06 | |
*** razorfishsl has quit IRC | 03:10 | |
*** trungnv has joined #openstack-containers | 03:12 | |
*** trungnv has joined #openstack-containers | 03:13 | |
*** dave-mccowan has quit IRC | 03:21 | |
*** goldyfruit has quit IRC | 03:46 | |
*** ykarel|away has joined #openstack-containers | 04:00 | |
*** ykarel|away is now known as ykarel | 04:00 | |
*** Qiwei has quit IRC | 04:23 | |
*** trungnv has quit IRC | 05:00 | |
*** ykarel is now known as ykarel|afk | 05:23 | |
*** ykarel|afk is now known as ykarel | 06:08 | |
*** trungnv has joined #openstack-containers | 06:40 | |
*** sapd1 has joined #openstack-containers | 06:50 | |
*** trident has quit IRC | 07:00 | |
*** ramishra has joined #openstack-containers | 07:01 | |
*** trident has joined #openstack-containers | 07:04 | |
strigazi | flwang: here? | 07:05 |
---|---|---|
*** lpetrut has joined #openstack-containers | 07:05 | |
strigazi | did you have time to look at the backports? | 07:06 |
*** udesale has joined #openstack-containers | 07:08 | |
*** pcaruana has joined #openstack-containers | 07:26 | |
*** ricolin_ is now known as ricolin | 07:30 | |
brtknr | flwang: also this: https://review.opendev.org/688928 | 07:43 |
openstackgerrit | Merged openstack/magnum stable/train: Fixing typos and spelling errors in driver template files https://review.opendev.org/689197 | 08:10 |
openstackgerrit | Merged openstack/magnum stable/train: Convert fixed_subnet name to uuid for OCCM https://review.opendev.org/689198 | 08:10 |
openstackgerrit | Merged openstack/magnum stable/train: update api-ref for clustertemplate https://review.opendev.org/689199 | 08:10 |
openstackgerrit | Merged openstack/magnum stable/train: Support Fedora CoreOS 30 https://review.opendev.org/689200 | 08:10 |
openstackgerrit | Merged openstack/magnum stable/train: ng-10: Fix cluster template conditions https://review.opendev.org/689201 | 08:15 |
openstackgerrit | Merged openstack/magnum stable/train: ng-11: API microversion 1.9 https://review.opendev.org/689202 | 08:15 |
openstackgerrit | Merged openstack/magnum stable/train: ng-12: Label nodegroup nodes https://review.opendev.org/689203 | 08:20 |
openstackgerrit | Merged openstack/magnum stable/train: ng-13: Support nodegroup upgrade https://review.opendev.org/689204 | 08:20 |
*** ttsiouts has joined #openstack-containers | 08:23 | |
brtknr | strigazi: do you know where I can find reference to ostree_commit and ostree_remote? | 08:44 |
*** ykarel is now known as ykarel|lunch | 08:46 | |
strigazi | brtknr: I don't remember, I'll have to check. | 08:55 |
*** sapd1 has quit IRC | 09:01 | |
brtknr | strigazi: dont worry, I found it, its rpm-ostree upgrade --check | 09:10 |
brtknr | although there must be an easier way | 09:15 |
*** ykarel|lunch is now known as ykarel | 09:39 | |
strigazi | brtknr: we don't need this for long | 09:40 |
strigazi | brtknr: I guess | 09:40 |
*** ttsiouts has quit IRC | 09:51 | |
*** ttsiouts has joined #openstack-containers | 09:51 | |
*** sapd1 has joined #openstack-containers | 09:53 | |
*** ttsiouts has quit IRC | 09:56 | |
*** ramishra has quit IRC | 09:59 | |
*** ykarel is now known as ykarel|afk | 10:07 | |
*** ramishra has joined #openstack-containers | 10:27 | |
*** ykarel|afk is now known as ykarel | 10:43 | |
*** zigo has quit IRC | 10:54 | |
*** ttsiouts has joined #openstack-containers | 10:59 | |
brtknr | strigazi: is OS upgrade really supported by specifying a new image_name? | 11:01 |
brtknr | Not what I see in the code | 11:02 |
*** zigo has joined #openstack-containers | 11:03 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [fedora-atomic][k8s] Support operating system upgrade https://review.opendev.org/669593 | 11:11 |
brtknr | strigazi: I tested the above for OS upgrade and it works :) | 11:11 |
brtknr | although it doesnt appear to be working for kube tags | 11:22 |
brtknr | cc ttsiouts | 11:22 |
brtknr | any thoughts why? | 11:22 |
*** trungnv has quit IRC | 11:30 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [fedora-atomic][k8s] Support operating system upgrade https://review.opendev.org/669593 | 11:46 |
*** mgariepy has joined #openstack-containers | 12:07 | |
*** ramishra has quit IRC | 12:12 | |
*** udesale has quit IRC | 12:13 | |
*** udesale has joined #openstack-containers | 12:16 | |
ttsiouts | brtknr: I'll try to reproduce now. | 12:18 |
ttsiouts | I reviewed the code and left some comments. | 12:18 |
ttsiouts | brtknr: I'm -1 cause update_max_batch_size is ignored if kube_tag is set. | 12:19 |
ttsiouts | brtknr: kube_tag seems to be working for me.. | 12:42 |
ttsiouts | brtknr: kube_tag upgrade seems to be working for me on 669593.. | 12:42 |
*** ttsiouts has quit IRC | 12:53 | |
*** ttsiouts has joined #openstack-containers | 12:54 | |
*** ttsiouts has quit IRC | 12:58 | |
*** mgariepy has quit IRC | 13:00 | |
*** ttsiouts has joined #openstack-containers | 13:10 | |
brtknr | ttsiouts: thank you :) | 13:11 |
ttsiouts | brtknr: http://paste.openstack.org/show/784719/ | 13:15 |
ttsiouts | brtknr: next test is to upgrade both kube_tag and ostree commit in one go | 13:15 |
brtknr | ttsiouts: i was about to try that! | 13:16 |
ttsiouts | brtknr: I'll let you know how it goes | 13:16 |
brtknr | ttsiouts: i dont understand if we need to specify both ostree_commit and ostree_remote or its either or | 13:16 |
brtknr | looking at the code, it seems to be either ostree_commit or ostree_remote | 13:17 |
*** goldyfruit has joined #openstack-containers | 13:28 | |
*** ykarel is now known as ykarel|afk | 13:36 | |
ttsiouts | brtknr: from the code it seems that if you give both of them only ostree_commit is used | 13:36 |
brtknr | ttsiouts: yes, should it use both | 13:37 |
ttsiouts | brtknr: s/both/ostree_commit and ostree_remote/ | 13:37 |
ttsiouts | brtknr: not sure. | 13:37 |
*** ykarel|afk is now known as ykarel | 13:37 | |
ttsiouts | brtknr: https://review.opendev.org/#/c/669593/17/magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh@91 | 13:38 |
ttsiouts | brtknr: according to this I think that it's either or | 13:38 |
ttsiouts | brtknr: flwang's note I mean | 13:39 |
brtknr | hmm | 13:40 |
*** rcernin has quit IRC | 13:40 | |
*** ricolin has quit IRC | 13:43 | |
*** mgariepy has joined #openstack-containers | 13:46 | |
*** dave-mccowan has joined #openstack-containers | 13:46 | |
ttsiouts | brtknr: if the cluster template has one of them (ostree_commit and ostree_remote) nothing will pass heat | 13:48 |
ttsiouts | brtknr: https://review.opendev.org/#/c/669593/17/magnum/drivers/heat/driver.py@384 | 13:48 |
ttsiouts | brtknr: which means that with the current implementation both are needed but only one is used. | 13:50 |
ttsiouts | brtknr: it's a bit weird. | 13:51 |
*** pcaruana has quit IRC | 13:53 | |
*** dave-mccowan has quit IRC | 13:56 | |
*** munimeha1 has joined #openstack-containers | 13:57 | |
brtknr | just fixing the logic | 14:15 |
brtknr | i will make it accept args in the same order as the bash script | 14:16 |
brtknr | best thing to do is to document it | 14:16 |
ttsiouts | brtknr: everything got upgraded for me. both os and kube_tag | 14:25 |
ttsiouts | brtknr: my only problem is this | 14:25 |
ttsiouts | kube-oz6lyl4vtlqf-master-0 Ready,SchedulingDisabled master 17m v1.14.7 | 14:25 |
brtknr | it worked? | 14:25 |
ttsiouts | brtknr: yeap | 14:25 |
brtknr | what is the problem? | 14:25 |
brtknr | master didn't uncordon? | 14:26 |
ttsiouts | yeap | 14:26 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [fedora-atomic][k8s] Support operating system upgrade https://review.opendev.org/669593 | 14:26 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [fedora-atomic][k8s] Support operating system upgrade https://review.opendev.org/669593 | 14:44 |
*** sapd1 has quit IRC | 14:47 | |
*** sapd1 has joined #openstack-containers | 14:52 | |
*** FlorianFa has quit IRC | 15:01 | |
*** ttsiouts has quit IRC | 15:03 | |
*** mgariepy has quit IRC | 15:03 | |
*** ttsiouts has joined #openstack-containers | 15:03 | |
*** sapd1 has quit IRC | 15:08 | |
*** ttsiouts has quit IRC | 15:08 | |
*** udesale has quit IRC | 15:10 | |
*** udesale has joined #openstack-containers | 15:11 | |
*** mgariepy has joined #openstack-containers | 15:16 | |
*** ykarel is now known as ykarel|afk | 15:55 | |
*** ykarel|afk is now known as ykarel | 15:55 | |
*** lpetrut has quit IRC | 17:09 | |
*** ykarel is now known as ykarel|away | 17:44 | |
*** jerryz has joined #openstack-containers | 17:46 | |
*** udesale has quit IRC | 17:56 | |
*** ykarel|away has quit IRC | 17:59 | |
*** trident has quit IRC | 18:57 | |
*** trident has joined #openstack-containers | 19:00 | |
*** dave-mccowan has joined #openstack-containers | 19:10 | |
*** mgariepy has quit IRC | 19:47 | |
*** jerryz has quit IRC | 19:58 | |
*** jerryz has joined #openstack-containers | 20:22 | |
*** Qiwei has joined #openstack-containers | 20:58 | |
*** lpetrut has joined #openstack-containers | 21:06 | |
*** goldyfruit has quit IRC | 21:10 | |
*** lpetrut has quit IRC | 21:13 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!