| *** goldyfruit_ has quit IRC | 00:20 | |
| *** goldyfruit_ has joined #openstack-containers | 01:05 | |
| *** ricolin has joined #openstack-containers | 01:46 | |
| *** ricolin has quit IRC | 03:03 | |
| *** hongbin has joined #openstack-containers | 04:00 | |
| *** ricolin has joined #openstack-containers | 04:08 | |
| *** udesale has joined #openstack-containers | 04:14 | |
| *** ykarel has joined #openstack-containers | 04:19 | |
| *** ricolin has quit IRC | 04:29 | |
| openstackgerrit | Merged openstack/magnum-ui master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/694534 | 04:40 |
|---|---|---|
| *** hongbin has quit IRC | 06:18 | |
| *** sapd1 has joined #openstack-containers | 06:28 | |
| *** pcaruana has joined #openstack-containers | 06:32 | |
| *** udesale has quit IRC | 06:40 | |
| *** udesale has joined #openstack-containers | 06:41 | |
| *** namrata has joined #openstack-containers | 06:46 | |
| *** elenalindq has joined #openstack-containers | 06:47 | |
| *** sapd1 has quit IRC | 06:57 | |
| brtknr | Hi flwang not yet | 06:57 |
| *** udesale has quit IRC | 07:34 | |
| *** udesale has joined #openstack-containers | 07:35 | |
| *** dim79 has joined #openstack-containers | 08:29 | |
| brtknr | flwang: Yes we’re using stable train and stein 8.2.0 rc | 09:13 |
| *** dim79 has quit IRC | 09:31 | |
| *** ykarel is now known as ykarel|lunch | 09:42 | |
| dioguerra | brtknr: Morning... | 09:51 |
| andrein | good morning! | 09:52 |
| dioguerra | Would you consider having the nginx controller as Burstable QoS? | 09:52 |
| *** dim79 has joined #openstack-containers | 10:07 | |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Scrape prometheus metrics from nginx https://review.opendev.org/695681 | 10:15 |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Fix nginx getting OOM killed https://review.opendev.org/696053 | 10:15 |
| *** dim79 has quit IRC | 10:19 | |
| *** ykarel|lunch is now known as ykarel | 10:28 | |
| *** ivve has joined #openstack-containers | 10:35 | |
| *** lpetrut has joined #openstack-containers | 10:52 | |
| *** udesale has quit IRC | 10:58 | |
| brtknr | dioguerra: that’s an exciting concept? Can you explain how that would work? | 11:19 |
| *** rcernin has quit IRC | 11:40 | |
| andrein | hello everyone, I've upgraded to train yesterday and I can't modify cluster templates from horizon anymore. It works fine from the CLI. Any ideas? https://www.irccloud.com/pastebin/TQ1bAz6A/ | 11:50 |
| brtknr | andrein: i dont think anyone has brought the magnum-ui in line with the changes to other bits | 11:58 |
| andrein | but the hidden attribute was non-removable in stein also, according to git history | 12:15 |
| andrein | and yes, there were almost no changes in magnum-ui for train | 12:15 |
| andrein | so why is this failing now? | 12:15 |
| *** udesale has joined #openstack-containers | 12:21 | |
| brtknr | andrein: it doesnt seem to exist as an attibute in the cluster template | 12:50 |
| brtknr | and its mandatory | 12:50 |
| brtknr | on the magnum-ui | 12:50 |
| andrein | I think adding a hidden field there for the 'hidden' attribute would fix this | 12:51 |
| andrein | I was just about to give it a shot | 12:52 |
| brtknr | andrein: thats right, Happy to review any patches | 13:01 |
| brtknr | I am not that familiar with django | 13:01 |
| andrein | brtknr: AttributeError: module 'novaclient.v2' has no attribute 'list_extensions' I'm trying to start horizon locally | 13:01 |
| andrein | any ideas? | 13:02 |
| brtknr | if you enable magnum-ui plugin on devstack, it should add automatically | 13:02 |
| andrein | I still haven't got around to setting up my devstack server yet... | 13:03 |
| andrein | was list_extensions removed in python-novaclient? | 13:04 |
| andrein | https://docs.openstack.org/python-novaclient/train/reference/api/novaclient.v2.html vs https://docs.openstack.org/python-novaclient/latest/reference/api/novaclient.v2.html | 13:04 |
| dioguerra | brtknr: How what works exaclty? | 13:07 |
| dioguerra | The QoS??? https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/ | 13:08 |
| dioguerra | It is based on the pods, resources.requests and resources.limits | 13:08 |
| *** goldyfruit_ has quit IRC | 13:08 | |
| brtknr | dioguerra: ah makes snese | 14:14 |
| brtknr | andrein: not sure where novaclient comes in | 14:14 |
| brtknr | andrein: At the very least, if you file a bug, we can investigate this later | 14:14 |
| andrein | brtknr: I've added the hidden field to the form, it fixes the issue for me | 14:17 |
| brtknr | andrein: nice! do you might pushing the code? | 14:17 |
| brtknr | andrein: nice! do you mind pushing the code? | 14:18 |
| brtknr | or sharing the diff? | 14:18 |
| andrein | yes, I'll post a review shortly | 14:18 |
| brtknr | andrein: thanks | 14:18 |
| andrein | just trying to see what it breaks first | 14:18 |
| brtknr | looks like it tries to remove the hidden field which is not allowed | 14:18 |
| brtknr | I am not quite sure why | 14:18 |
| brtknr | andrein: | 14:19 |
| brtknr | I am keen to see how you added the field because I've been trying to do the same but havent managed! | 14:20 |
| andrein | brtknr: it's trying to remove it because the get request for the cluster template gives it the hidden field, but the form doesn't have it so it discards it. then, there's some code that diffs the old vs new values and generates the magnum patch request (forgot where exactly, but I can find it), which says that the hidden field should be removed | 14:20 |
| brtknr | andrein: yes that makes sense | 14:21 |
| brtknr | I was worried it was a problem with the API | 14:22 |
| andrein | looks like my dev server is no longer serving the right js/css assets when I run tox -e runserver | 14:23 |
| andrein | not sure if I broke it or not | 14:23 |
| *** namrata has quit IRC | 14:31 | |
| brtknr | andrein: sorry cant help there but happy to try and replicate the issue if you upload the code | 14:33 |
| openstackgerrit | Andrei Nistor proposed openstack/magnum-ui master: WIP Fix cluster template update bug https://review.opendev.org/696099 | 14:35 |
| andrein | brtknr: ^^ | 14:36 |
| *** goldyfruit has joined #openstack-containers | 14:36 | |
| andrein | I don't particularly like this solution, since if a user accidentally checks the hidden flag, his cluster template would just disappear (maybe? that's what I was testing when I broke my dev server :) ) | 14:37 |
| brtknr | andrein: i did exactly the same, but didnt work for me | 14:37 |
| *** goldyfruit_ has joined #openstack-containers | 14:38 | |
| andrein | brtknr: that's odd :-? | 14:39 |
| brtknr | on devstack | 14:40 |
| brtknr | i dotn thknk i figured out how toio install the plugin correctly | 14:40 |
| brtknr | do you know how? | 14:40 |
| andrein | I followed the readme | 14:41 |
| *** goldyfruit has quit IRC | 14:41 | |
| andrein | pip install -e ../magnum-ui/ | 14:42 |
| andrein | https://www.irccloud.com/pastebin/yCYb5c14/ | 14:42 |
| andrein | you also need a local_settings.py | 14:45 |
| brtknr | andrein: do you neef to restart horizon? | 14:45 |
| andrein | I think so, I was running it with tox -e runserver which looks like it automatically reloads on changes | 15:07 |
| *** ykarel is now known as ykarel|pto | 15:14 | |
| andrein | brtknr: did you get it working? | 15:21 |
| brtknr | andrein: :( | 15:23 |
| brtknr | tox -e runserver doesnt seem to be working as expected | 15:23 |
| brtknr | im going to restack my devstack | 15:23 |
| andrein | I cleared /static on my server and it fixed the js/css error i was getting earlier. I've tested again and I can edit the templates now | 15:26 |
| andrein | but the hidden flag I added doesn't do anything, which is probably normal because it's not checked anywhere | 15:27 |
| brtknr | andrein: its not something i use often so not sure how its used | 15:33 |
| brtknr | andrein: but you're right, we've used this in stein and havent encountered issues | 15:40 |
| openstackgerrit | Andrei Nistor proposed openstack/magnum-ui master: WIP Fix cluster template update bug https://review.opendev.org/696099 | 15:51 |
| andrein | fixed the whitespace stuff | 15:52 |
| *** ivve has quit IRC | 16:02 | |
| brtknr | andrein: I am getting close | 16:47 |
| brtknr | :D | 16:47 |
| *** ivve has joined #openstack-containers | 17:06 | |
| *** udesale has quit IRC | 17:09 | |
| brtknr | hmm | 17:30 |
| brtknr | andrein: actually no luck | 17:30 |
| brtknr | andrein: how did you generate your local_settings.py? | 17:31 |
| *** ykarel|pto has quit IRC | 17:34 | |
| andrein | I just copied the sample file and set the OPENSTACK_HOST, along with the custom domain stuff that shouldn't matter if you're on devstack | 17:39 |
| andrein | brtknr: also, installed and started memcached, complained at some point about sessions going away | 17:39 |
| andrein | otherwise, it was smooth sailing for me | 17:42 |
| andrein | but, I'm not using devstack (yet) | 17:43 |
| *** openstackgerrit has quit IRC | 17:49 | |
| *** goldyfruit___ has joined #openstack-containers | 18:41 | |
| *** goldyfruit_ has quit IRC | 18:43 | |
| *** goldyfruit_ has joined #openstack-containers | 18:51 | |
| *** colin- has quit IRC | 18:52 | |
| *** goldyfruit___ has quit IRC | 18:54 | |
| *** goldyfruit_ has quit IRC | 19:07 | |
| *** lpetrut has quit IRC | 19:08 | |
| *** goldyfruit has joined #openstack-containers | 19:09 | |
| *** goldyfruit_ has joined #openstack-containers | 19:19 | |
| *** goldyfruit has quit IRC | 19:22 | |
| brtknr | andrein: argh why isnt it working for me! :( | 19:29 |
| andrein | hmmmm, you can try checking out the code for horizon and magnum-ui | 19:29 |
| andrein | like I did | 19:29 |
| andrein | the instructions in the readme, are pretty acurate (although they reference some scripts that no longer exist) | 19:30 |
| brtknr | andrein: okay its working | 19:59 |
| brtknr | the trick was to do `python manage.py compress` on the horizon folder | 20:00 |
| brtknr | its working with my existing horizon UI | 20:00 |
| brtknr | andrein: although ive found another problem | 20:00 |
| brtknr | i cant create a cluster template without setting docker_volume_size > 0 | 20:01 |
| andrein | hmmm, I've never tried that | 20:01 |
| brtknr | andrein: also could you tidy up your PR, remove the WIP and create a storyboard bug | 20:01 |
| brtknr | andrein: try creating a cluster template | 20:02 |
| andrein | brtknr: I'll create the SB bug and tidy up tomorrow morning | 20:03 |
| andrein | I'll also try to reproduce the docker volume size bug | 20:03 |
| brtknr | andrein: I've created a story: https://storyboard.openstack.org/#!/story/2006953 | 20:10 |
| *** goldyfruit___ has joined #openstack-containers | 20:17 | |
| brtknr | andrein: actually, it only matters if the docker_volume_driver is devicemapper | 20:19 |
| *** goldyfruit_ has quit IRC | 20:20 | |
| *** goldyfruit_ has joined #openstack-containers | 20:21 | |
| *** goldyfruit___ has quit IRC | 20:24 | |
| *** openstackgerrit has joined #openstack-containers | 20:40 | |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum-ui master: Add missing hidden option to cluster template https://review.opendev.org/696099 | 20:40 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum-ui master: Set empty default value for docker_storage_driver https://review.opendev.org/696179 | 20:40 |
| brtknr | andrein: ^ | 20:42 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum-ui master: Add missing hidden option to cluster template https://review.opendev.org/696099 | 20:47 |
| openstackgerrit | Bharat Kunwar proposed openstack/magnum-ui master: Set empty default value for docker_storage_driver https://review.opendev.org/696179 | 20:47 |
| brtknr | are you happy with the commit message andrein ? | 20:59 |
| andrein | brtknr: looks good to me! | 21:20 |
| andrein | can we backport this to train? | 21:21 |
| *** threestrands has joined #openstack-containers | 21:27 | |
| *** ioni has joined #openstack-containers | 21:36 | |
| ioni | hi guys | 21:36 |
| ioni | i was wondering if i can use magnum train release on openstack stein | 21:36 |
| flwang | ioni: totally OK | 21:40 |
| flwang | brtknr: around? | 21:40 |
| brtknr | flwang: hiii | 21:42 |
| brtknr | andrein: yep, as soon as this gets merged | 21:43 |
| flwang | brtknr: i'm testing the rolling upgrade https://github.com/openstack/magnum/blame/master/magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh | 21:43 |
| brtknr | ioni: we are using this on train, there is an issue with magnum-ui on train but other than that, all good | 21:44 |
| flwang | i think there is a problem with the kubectl command | 21:44 |
| brtknr | ioni: also podman will not work without train heat | 21:44 |
| brtknr | flwang: is this on your stein branch? | 21:45 |
| flwang | brtknr: i think this line https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh#L79 should be replace with until ${kubecontrol} uncordon ${INSTANCE_NAME} | 21:45 |
| flwang | brtknr: no, master branch has the same issue | 21:45 |
| flwang | and this line https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh#L69 should be dropped | 21:46 |
| flwang | since it's duplicated with line 79- 85 | 21:46 |
| flwang | and this "if" is not correct https://github.com/openstack/magnum/blob/master/magnum/drivers/common/templates/kubernetes/fragments/upgrade-kubernetes.sh#L8 | 21:49 |
| flwang | when use_podman is true, the kubecontrol should be not set with the kubectl path for atomic system | 21:49 |
| flwang | anyway, i will propose a patch | 21:54 |
| brtknr | flwang: sounds good to me | 21:55 |
| brtknr | flwang: are you happy with this btw: https://review.opendev.org/696099 | 21:55 |
| *** elenalindq has quit IRC | 21:56 | |
| flwang | brtknr: sure, will +2 | 22:00 |
| *** rcernin has joined #openstack-containers | 22:04 | |
| brtknr | flwang: thanks, also thanks andrein for proposing the fix | 22:07 |
| openstackgerrit | Merged openstack/magnum-ui master: Add missing hidden option to cluster template https://review.opendev.org/696099 | 22:15 |
| *** pcaruana has quit IRC | 22:16 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [k8s] Fix rolling upgrade with podman https://review.opendev.org/696204 | 22:59 |
| brtknr | flwang: | 23:12 |
| brtknr | do you know when in-tree cinder will be deprecated? | 23:12 |
| *** strobert1 has joined #openstack-containers | 23:13 | |
| *** goldyfruit___ has joined #openstack-containers | 23:13 | |
| *** goldyfruit_ has quit IRC | 23:16 | |
| *** goldyfruit_ has joined #openstack-containers | 23:17 | |
| *** goldyfruit___ has quit IRC | 23:20 | |
| *** goldyfruit_ has quit IRC | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!