| *** k_mouza has joined #openstack-containers | 00:21 | |
| *** ttsiouts has joined #openstack-containers | 01:17 | |
| *** k_mouza has quit IRC | 01:36 | |
| *** ttsiouts has quit IRC | 01:51 | |
| brtknr | flwang1: hi | 02:27 |
|---|---|---|
| flwang1 | brtknr: did you see my comments? | 02:28 |
| flwang1 | i'm happy to discuss if it's not clear for you | 02:28 |
| brtknr | not trying to get you to change again but if you are claiming any third party app can make an update and it’s not magnum auto healer, is is also going to compete with the internal poller | 02:30 |
| brtknr | either say only magnum auto healer can do this or anything can when this new label is set | 02:31 |
| brtknr | this patch has less value if internal poller is going to override external update | 02:32 |
| brtknr | do you get my point? | 02:32 |
| brtknr | flwang1: | 02:33 |
| flwang1 | no, not the case | 02:34 |
| flwang1 | if the cluster is really a private cluster, i can't see any compete | 02:34 |
| flwang1 | brtknr: ^ | 02:34 |
| flwang1 | if the cluster is really a private cluster, with your latest fix, we can make sure the internal polling will stop | 02:35 |
| brtknr | Internal poller overrides api update to UNKNOWN every 10 secs | 02:35 |
| flwang1 | as a result, there is no compete/overwrite coming from the external side | 02:35 |
| brtknr | Even when it’s a private cluster | 02:36 |
| brtknr | My fix was only to detect private cluster, it does not change the logic of internal polling | 02:37 |
| flwang1 | brtknr: i can see your point now | 02:38 |
| brtknr | flwang1: really? :) | 02:39 |
| flwang1 | yes | 02:39 |
| flwang1 | i'm sure :) | 02:39 |
| brtknr | so what do you propose? | 02:39 |
| brtknr | extra label or limit claim to magnum auto healer? | 02:40 |
| flwang1 | i don't really want to introduce a new label for this | 02:40 |
| flwang1 | i'd like to limit to claim it for magnum auto healer, until we can see other requirements for this | 02:40 |
| flwang1 | not because i'm lazy | 02:41 |
| flwang1 | just because i don't want to introduce more workload for us until we're not very clear for the future | 02:41 |
| flwang1 | skip the "not" | 02:41 |
| brtknr | That’s fine! | 02:41 |
| brtknr | Happy either way | 02:42 |
| flwang1 | thanks, I will submit new patchset for the document to explain that | 02:42 |
| flwang1 | thank you for the good question, my brain was mess | 02:42 |
| brtknr | what about the check during api update? | 02:43 |
| brtknr | so client sees error if magnum auto healer is disabled? | 02:43 |
| brtknr | I’m just doing my job as a reviewer | 02:44 |
| flwang1 | hmm... we can do that at the api level, but comparing with that, i even prefer adding the new label :) | 02:48 |
| *** ttsiouts has joined #openstack-containers | 02:49 | |
| flwang1 | let's take the magnum-auto-healer as the 'external_health_status_update_enabled' label now, we never logic at the api level depending a label so far | 02:50 |
| flwang1 | i'd like to keep the api simple and clean, and let the engine to handle the real work | 02:51 |
| flwang1 | brtknr: ^ | 02:51 |
| brtknr | flwang1: I am not pushing for a new label | 02:52 |
| brtknr | flwang1: i am ok without the api check | 02:53 |
| brtknr | Also I think external health status update enabled is too long lol | 02:54 |
| flwang1 | sorry, i'm being relcuctant, just because i can't be convinced with a new proposal so far | 02:54 |
| flwang1 | :D | 02:54 |
| *** ttsiouts has quit IRC | 03:23 | |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [k8s] Support updating k8s cluster health status https://review.opendev.org/710384 | 03:32 |
| *** k_mouza has joined #openstack-containers | 03:37 | |
| *** k_mouza has quit IRC | 03:41 | |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Expose traefik metrics. https://review.opendev.org/697044 | 03:42 |
| *** ykarel|away is now known as ykarel | 03:54 | |
| *** dioguerra has joined #openstack-containers | 04:05 | |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Expose traefik metrics. https://review.opendev.org/697044 | 04:16 |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Expose traefik metrics. https://review.opendev.org/697044 | 04:19 |
| dioguerra | ^^ Can someone have a look on my comment here? | 04:20 |
| *** ttsiouts has joined #openstack-containers | 05:20 | |
| *** ttsiouts has quit IRC | 05:53 | |
| *** udesale has joined #openstack-containers | 05:55 | |
| *** dioguerra has quit IRC | 06:17 | |
| *** ttsiouts has joined #openstack-containers | 07:09 | |
| *** ykarel is now known as ykarel|afk | 07:21 | |
| brtknr | flwang1: still there? | 07:31 |
| *** ykarel|afk is now known as ykarel | 07:37 | |
| flwang1 | brtknr: yes | 07:40 |
| openstackgerrit | Feilong Wang proposed openstack/magnum master: [k8s] Support updating k8s cluster health status https://review.opendev.org/710384 | 07:45 |
| *** ykarel is now known as ykarel|afk | 07:55 | |
| openstackgerrit | Merged openstack/magnum-specs master: ci: Fix and address all tox -e docs warnings https://review.opendev.org/716923 | 08:05 |
| *** ykarel|afk is now known as ykarel|lunch | 08:09 | |
| openstackgerrit | Diogo Guerra proposed openstack/magnum master: Traefik prometheus metrics are now being exposed https://review.opendev.org/697044 | 08:44 |
| *** rmart04 has joined #openstack-containers | 08:48 | |
| *** k_mouza has joined #openstack-containers | 08:59 | |
| brtknr | flwang1: I've replied | 09:00 |
| *** ykarel|lunch is now known as ykarel | 09:26 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum-specs master: Magnum Labels Override https://review.opendev.org/716571 | 09:57 |
| ttsiouts | strigazi, brtknr: Thanks a lot for the comments. The spec is updated ^ | 09:59 |
| brtknr | ttsiouts: thanks I am mostly happy with it... just added couple more comments | 10:06 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum-specs master: Magnum Labels Override https://review.opendev.org/716571 | 10:08 |
| ttsiouts | brtknr: interesting scenario the one you mentioned in your comment. | 10:13 |
| ttsiouts | brtknr: I think yes. labels at the nodegroup level will have priority over the override labels at cluster level. | 10:13 |
| ttsiouts | brtknr: this is what we want though right? to support the current functionality | 10:14 |
| brtknr | ttsiouts: i think so | 10:14 |
| ttsiouts | brtknr: cool | 10:15 |
| ttsiouts | brtknr: again thanks a lot for your comments! | 10:15 |
| brtknr | funny thing is, --labels works like --override-labels and --override-labels works like --labels | 10:15 |
| brtknr | unfortunately --labels is already taken | 10:15 |
| ttsiouts | brtknr: ha, true | 10:16 |
| ttsiouts | brtknr: I'm happy with override-labels though | 10:16 |
| brtknr | i think we should make the above point clear in the spec | 10:16 |
| ttsiouts | can you add a comment in gerrit please? | 10:17 |
| brtknr | that providing --labels will replace both --labels and --override-labels from the scope above | 10:17 |
| brtknr | i already added the comment | 10:17 |
| ttsiouts | brtknr: ah. this note here tries to address that: https://review.opendev.org/#/c/716571/5/specs/ussuri/labels-override.rst@139 | 10:19 |
| ttsiouts | brtknr: do you want me to rephrase that? | 10:19 |
| brtknr | if thats | 10:20 |
| brtknr | if thats ok | 10:20 |
| ttsiouts | brtknr: sure I can add something more verbose | 10:20 |
| *** rcernin has quit IRC | 10:29 | |
| brtknr | ttsiouts: cheers | 10:38 |
| *** udesale_ has joined #openstack-containers | 10:43 | |
| *** udesale has quit IRC | 10:46 | |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum-specs master: Magnum Labels Override https://review.opendev.org/716571 | 10:58 |
| ttsiouts | brtknr: https://review.opendev.org/#/c/716571/6/specs/ussuri/labels-override.rst@97 | 11:01 |
| ttsiouts | brtknr: I changed the scenario to show that labels at nodegroup level have priority over the override labels at cluster level | 11:02 |
| brtknr | ttsiouts: i love the verbose example, thank you! | 11:03 |
| ttsiouts | brtknr: great! Thanks again! | 11:05 |
| openstackgerrit | Theodoros Tsioutsias proposed openstack/magnum-specs master: Magnum Labels Override https://review.opendev.org/716571 | 12:20 |
| ttsiouts | strigazi, brtknr: I think I addressed all your comments. ^^ | 12:23 |
| ttsiouts | strigazi, brtknr: thanks again! | 12:23 |
| *** zigo has quit IRC | 12:48 | |
| *** zigo has joined #openstack-containers | 12:50 | |
| *** k_mouza has quit IRC | 13:26 | |
| *** ykarel is now known as ykarel|away | 14:52 | |
| *** yoctozepto has quit IRC | 15:17 | |
| *** yoctozepto8 has joined #openstack-containers | 15:18 | |
| *** k_mouza has joined #openstack-containers | 15:27 | |
| *** k_mouza has quit IRC | 15:31 | |
| *** k_mouza has joined #openstack-containers | 15:34 | |
| *** udesale_ has quit IRC | 15:50 | |
| *** ioni is now known as wonder | 16:27 | |
| *** wonder is now known as ioni | 16:27 | |
| *** pcaruana has quit IRC | 16:37 | |
| *** yoctozepto8 is now known as yoctozepto | 16:43 | |
| *** k_mouza has quit IRC | 17:40 | |
| *** rmart04 has quit IRC | 18:38 | |
| guilhermesp | flwang1: good news | 18:53 |
| guilhermesp | https://www.irccloud.com/pastebin/WMCuVmAr/ | 18:53 |
| guilhermesp | time to run conformance | 18:53 |
| guilhermesp | pretty clear | 18:54 |
| guilhermesp | https://www.irccloud.com/pastebin/IDYMDdVw/ | 18:54 |
| guilhermesp | btw not sure if you guys noticed but sonobuoy v0.18.0 is out https://github.com/vmware-tanzu/sonobuoy/releases/tag/v0.18.0 | 18:57 |
| guilhermesp | when I get success with v1.17 i will try that out | 18:57 |
| cosmicsound | good one guilhermesp | 18:58 |
| cosmicsound | is this with new coreos images? | 18:58 |
| guilhermesp | cosmicsound: im using that one https://github.com/stackhpc/magnum-terraform/blob/master/upload-coreos.sh | 18:59 |
| guilhermesp | you need jq btw to be able to run it | 18:59 |
| *** k_mouza has joined #openstack-containers | 19:06 | |
| guilhermesp | https://www.irccloud.com/pastebin/NdMbyPB7/ | 19:10 |
| guilhermesp | v1.17 passing conformance | 19:10 |
| *** ttsiouts has quit IRC | 19:12 | |
| *** k_mouza has quit IRC | 19:21 | |
| *** ttsiouts has joined #openstack-containers | 19:32 | |
| *** ttsiouts has quit IRC | 19:37 | |
| cosmicsound | jq? | 20:01 |
| cosmicsound | what is jq guilhermesp | 20:01 |
| cosmicsound | btw when i use that script simply my image is not visible on creating a template | 20:01 |
| guilhermesp | cosmicsound: https://stedolan.github.io/jq/ | 20:02 |
| guilhermesp | i installed through apt though | 20:02 |
| cosmicsound | the issue is that magnum does not see the image to allow me to use it | 20:03 |
| cosmicsound | so its either wrong tag not sure | 20:03 |
| *** ttsiouts has joined #openstack-containers | 20:04 | |
| *** ttsiouts has quit IRC | 20:09 | |
| cosmicsound | this is the most i managed to reach | 20:47 |
| cosmicsound | https://mdb.uhlhost.net/uploads/ff125af145013c2c/image.png | 20:47 |
| cosmicsound | now if this one does not fails | 20:47 |
| cosmicsound | its perfect | 20:47 |
| guilhermesp | wait you upload a fedora-coreos but magnum cant see it through the cluster template? | 21:03 |
| guilhermesp | i just created both single master and multimaster with v1.17.4 + fedora-coreos and both passed on conformance tests | 21:04 |
| guilhermesp | https://www.irccloud.com/pastebin/L5YdjXPc/ | 21:04 |
| cosmicsound | yes guilhermesp thats correct | 21:11 |
| cosmicsound | my image is not visible then tagged fedora-coreos | 21:11 |
| cosmicsound | only whenn tagged coreos in past was working | 21:11 |
| *** KeithMnemonic has quit IRC | 21:34 | |
| cosmicsound | brtknr , any idea why the image is visible in horizon dashboard only when tagged with coreos, not when tagged with fedora-coreos ? | 21:37 |
| cosmicsound | when creating new k8s template | 21:38 |
| *** flwang1 has quit IRC | 21:41 | |
| *** k_mouza has joined #openstack-containers | 21:43 | |
| *** k_mouza has quit IRC | 21:47 | |
| *** k_mouza has joined #openstack-containers | 21:48 | |
| *** ttsiouts has joined #openstack-containers | 22:28 | |
| *** ttsiouts has quit IRC | 22:32 | |
| *** ttsiouts has joined #openstack-containers | 23:05 | |
| *** ttsiouts has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
