*** hongbin has quit IRC | 00:22 | |
openstackgerrit | Feilong Wang proposed openstack/magnum master: [k8s] Fix docker storage of Fedora CoreOS https://review.opendev.org/718296 | 00:25 |
---|---|---|
*** hongbin has joined #openstack-containers | 00:29 | |
*** ttsiouts has joined #openstack-containers | 00:30 | |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [DNM] Re-enable functional k8s https://review.opendev.org/720216 | 00:50 |
*** ttsiouts has quit IRC | 01:04 | |
*** ricolin has joined #openstack-containers | 01:32 | |
*** ttsiouts has joined #openstack-containers | 02:15 | |
*** sapd1 has joined #openstack-containers | 02:28 | |
*** ttsiouts has quit IRC | 02:49 | |
*** hongbin has quit IRC | 02:50 | |
*** ttsiouts has joined #openstack-containers | 03:23 | |
*** ttsiouts has quit IRC | 03:28 | |
*** threestrands has joined #openstack-containers | 03:29 | |
*** ttsiouts has joined #openstack-containers | 04:03 | |
*** ykarel|away is now known as ykarel | 04:28 | |
*** ttsiouts has quit IRC | 04:37 | |
*** udesale has joined #openstack-containers | 04:43 | |
*** vishalmanchanda has joined #openstack-containers | 05:01 | |
*** ttsiouts has joined #openstack-containers | 05:41 | |
*** ttsiouts has quit IRC | 05:46 | |
*** ttsiouts has joined #openstack-containers | 06:17 | |
*** ttsiouts has quit IRC | 06:22 | |
*** pcaruana has joined #openstack-containers | 06:24 | |
*** pcaruana has quit IRC | 06:41 | |
*** pcaruana has joined #openstack-containers | 06:51 | |
*** ttsiouts has joined #openstack-containers | 06:56 | |
brtknr | flwang: ping | 07:01 |
*** pcaruana has quit IRC | 07:07 | |
openstackgerrit | Merged openstack/magnum stable/train: fcos: Disable zincati auto-updates https://review.opendev.org/717428 | 07:08 |
*** yolanda has quit IRC | 07:08 | |
*** yolanda has joined #openstack-containers | 07:09 | |
*** ttsiouts has quit IRC | 07:09 | |
*** ttsiouts has joined #openstack-containers | 07:09 | |
cosmicsound | good day | 07:11 |
*** pcaruana has joined #openstack-containers | 07:20 | |
*** ykarel is now known as ykarel|lunch | 07:43 | |
*** ttsiouts has quit IRC | 07:47 | |
*** ttsiouts has joined #openstack-containers | 07:55 | |
openstackgerrit | Feilong Wang proposed openstack/magnum stable/train: [k8s] Improve the taint of master node kubelet https://review.opendev.org/717450 | 08:03 |
openstackgerrit | Merged openstack/python-magnumclient master: Update to hacking 3.0 https://review.opendev.org/715985 | 08:14 |
openstackgerrit | Merged openstack/python-magnumclient master: Check response type in _extract_error_json https://review.opendev.org/718356 | 08:22 |
*** threestrands has quit IRC | 08:45 | |
openstackgerrit | Merged openstack/magnum master: Build new autoscaler containers https://review.opendev.org/714986 | 09:00 |
*** ykarel|lunch is now known as ykarel | 09:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/magnum-ui master: Imported Translations from Zanata https://review.opendev.org/720410 | 09:31 |
*** k_mouza has joined #openstack-containers | 09:36 | |
*** born2bake has joined #openstack-containers | 09:51 | |
openstackgerrit | Merged openstack/magnum stable/train: [k8s] Improve the taint of master node kubelet https://review.opendev.org/717450 | 09:55 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: fedora-coreos: Bump up default versions to v1.18.x https://review.opendev.org/720425 | 10:18 |
*** xinliang has joined #openstack-containers | 10:23 | |
*** yolanda has quit IRC | 10:26 | |
*** ttsiouts has quit IRC | 10:28 | |
*** xinliang has quit IRC | 10:33 | |
*** yolanda has joined #openstack-containers | 10:38 | |
*** ttsiouts has joined #openstack-containers | 10:38 | |
ttsiouts | brtknr: Hi! Did you have a chance to review the code? | 10:39 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [DNM] Re-enable functional k8s https://review.opendev.org/720216 | 10:40 |
brtknr | ttsiouts: Not yet, I am still not sure how it works but will try it now | 10:40 |
ttsiouts | brtknr: you can check it out on an existing environment and see it in action with already existing clusters | 10:40 |
ttsiouts | brtknr: since there are no DB changes you just have to restart the services | 10:40 |
ttsiouts | brtknr: Thanks!! | 10:41 |
openstackgerrit | Bharat Kunwar proposed openstack/magnum master: [DNM] ci: Migrate to Zuul v3 https://review.opendev.org/720216 | 11:05 |
*** xinliang has joined #openstack-containers | 12:20 | |
*** xinliang has quit IRC | 12:30 | |
*** udesale_ has joined #openstack-containers | 12:31 | |
*** udesale has quit IRC | 12:34 | |
brtknr | ttsiouts: just tried it | 12:36 |
brtknr | i like the concept | 12:36 |
brtknr | much like calculating a diff | 12:36 |
ttsiouts | brtknr: cool. exactly | 12:36 |
brtknr | but making the changes at apply time | 12:36 |
brtknr | have you received feedback from strigazi ? | 12:37 |
ttsiouts | brtknr: this way we don't even have to change the conductor | 12:37 |
ttsiouts | brtknr: labels will continue being used as they were | 12:37 |
ttsiouts | brtknr: not yet. let's take this in gerrit so that we make sure everyone is aware of the chagnes | 12:38 |
ttsiouts | brtknr: thanks a lot for testing! | 12:38 |
brtknr | i will add more details in gerrit but it would be nice to break down the labels_overriden field to labels_skipped, labels_not_in_parent if that makes sense | 12:40 |
ttsiouts | brtknr: yes, I was thinking about that too. | 12:41 |
ttsiouts | I agree it would make more sense | 12:41 |
brtknr | ttsiouts: also would make it easier to see all the label fields together | 12:42 |
brtknr | one after another i mean | 12:42 |
ttsiouts | brtknr: +1 | 12:42 |
brtknr | ttsiouts: i agree this is a much nicer solution than adding a new db field | 12:43 |
brtknr | in the end, the effect of the boolean is captured in the computed labels | 12:44 |
brtknr | so the boolean is redundant | 12:44 |
brtknr | so the boolean is redundant information | 12:44 |
ttsiouts | brtknr: I was thinking that we would need to change the code everywhere the labels were being used | 12:45 |
ttsiouts | brtknr: this way we don't have to | 12:45 |
ttsiouts | brtknr: and we are also solving the issue with older clients requesting the "latest" microversion | 12:46 |
ttsiouts | brtknr: meaning that we are not changing the meaning of existing fields | 12:46 |
brtknr | ttsiouts: i like it, keeping it simple is good :) | 12:46 |
ttsiouts | brtknr: :) | 12:47 |
brtknr | ultimately this is for operators to track what users changed | 12:47 |
ttsiouts | exactly | 12:47 |
brtknr | this interface enabled that | 12:48 |
ttsiouts | and users can benefit from the new functionality also | 12:48 |
brtknr | will you be able to make appropriate changes to the magnum-ui as well | 12:48 |
*** vishalmanchanda has quit IRC | 12:50 | |
brtknr | ttsiouts: when these changes go through of course | 12:51 |
ttsiouts | brtknr: sure | 12:52 |
*** yolanda has quit IRC | 12:55 | |
*** yolanda has joined #openstack-containers | 12:55 | |
brtknr | ttsiouts: do you think the in label_overridden: X (was Y), do you think showing the value of X adds value because it is already shown in labels: field | 13:08 |
ttsiouts | brtknr: I just wanted something to denote the difference with the parent's labels. | 13:09 |
ttsiouts | brtknr: no need to keep it | 13:09 |
ttsiouts | brtknr: we could only show the parent value | 13:10 |
brtknr | ttsiouts: It would be cleaner I think | 13:12 |
brtknr | lets see what the others have to say | 13:12 |
brtknr | ttsiouts: if not we should have a single field which three keys | 13:15 |
ttsiouts | brtknr: sure | 13:16 |
brtknr | e.g. labels_diff: {new: {}, overridden: {}, skipped: {}} | 13:17 |
*** ykarel is now known as ykarel|afk | 13:32 | |
ttsiouts | brtknr: I think three fields would be much cleaner. | 13:35 |
brtknr | ttsiouts: up to you :) | 13:35 |
*** k_mouza has quit IRC | 13:47 | |
*** kevinz has quit IRC | 13:51 | |
*** k_mouza has joined #openstack-containers | 14:01 | |
*** ttsiouts has quit IRC | 14:43 | |
*** ykarel|afk is now known as ykarel | 14:45 | |
*** ttsiouts has joined #openstack-containers | 14:46 | |
*** ttsiouts has quit IRC | 14:51 | |
*** ttsiouts has joined #openstack-containers | 14:55 | |
*** ttsiouts has quit IRC | 14:59 | |
*** ttsiouts has joined #openstack-containers | 14:59 | |
*** ttsiouts_ has joined #openstack-containers | 15:31 | |
*** ttsiouts has quit IRC | 15:34 | |
*** ykarel is now known as ykarel|away | 15:35 | |
*** ttsiouts_ has quit IRC | 15:47 | |
*** ttsiouts has joined #openstack-containers | 16:04 | |
*** mgariepy has quit IRC | 16:29 | |
*** udesale_ has quit IRC | 16:35 | |
*** ttsiouts has quit IRC | 16:42 | |
*** ttsiouts has joined #openstack-containers | 16:42 | |
*** ricolin has quit IRC | 16:48 | |
*** mgariepy has joined #openstack-containers | 17:22 | |
*** k_mouza has quit IRC | 17:31 | |
*** rcernin has quit IRC | 17:37 | |
*** k_mouza has joined #openstack-containers | 17:39 | |
*** k_mouza has quit IRC | 17:41 | |
*** yolanda has quit IRC | 18:14 | |
*** k_mouza has joined #openstack-containers | 18:25 | |
*** k_mouza has quit IRC | 18:27 | |
*** yolanda has joined #openstack-containers | 18:28 | |
*** mgariepy has quit IRC | 19:44 | |
*** ttsiouts has quit IRC | 21:24 | |
*** ttsiouts has joined #openstack-containers | 21:27 | |
*** ttsiouts has quit IRC | 21:28 | |
*** ttsiouts has joined #openstack-containers | 21:28 | |
*** ramishra has quit IRC | 21:37 | |
*** ttsiouts has quit IRC | 21:44 | |
*** ttsiouts has joined #openstack-containers | 21:45 | |
brtknr | Flwang | 22:10 |
brtknr | u there? | 22:10 |
brtknr | there are no more 1.15.x releases | 22:10 |
brtknr | nor 1.14 | 22:10 |
brtknr | 1.18.x is out | 22:10 |
brtknr | so only 1.16 and 1.17 will have further minor releases | 22:11 |
brtknr | Correct me if I am wrong but this is my understanding | 22:18 |
brtknr | flwang1: ^ | 22:19 |
*** k_mouza has joined #openstack-containers | 22:27 | |
*** k_mouza has quit IRC | 22:32 | |
*** rcernin has joined #openstack-containers | 22:39 | |
*** threestrands has joined #openstack-containers | 23:14 | |
*** threestrands has quit IRC | 23:15 | |
*** threestrands has joined #openstack-containers | 23:15 | |
*** born2bake has quit IRC | 23:26 | |
*** sapd1 has quit IRC | 23:39 | |
flwang1 | brtknr: i understand that, but given the ussuri will be released soon, so i'm not sure if we should remove those code now, i prefer wait a bit until we have a ussuri stable branch | 23:42 |
flwang1 | brtknr: did you see my comments on https://review.opendev.org/#/c/718296/ ? does that make sense for you? | 23:46 |
*** sapd1 has joined #openstack-containers | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!