| jakeyip | I'm here if someone needs me | 08:55 |
|---|---|---|
| mnasiadka | Are there any important changes to review? | 09:00 |
| jakeyip | hi mnasiadka good to see you. Hope to drop bay / baymodel https://review.opendev.org/c/openstack/magnum/+/803780 | 09:02 |
| jakeyip | what about you? | 09:03 |
| mnasiadka | seems tests are passing, let's merge it - I did double check and it seems all of bay stuff is gone after this change | 09:04 |
| jakeyip | yeah might rebase rico's change to simplify it | 09:04 |
| mnasiadka | surely | 09:05 |
| mnasiadka | I don't have anything, need to tie some loose ends on kolla side so we can do Antelope release, once that's done I intend to spend more time on Magnum | 09:05 |
| jakeyip | cool. I think magnum will probably release a working antelope version after these patches | 09:06 |
| mnasiadka | now it doesn't work? ;-) | 09:08 |
| jakeyip | nope, we missed getting the barbicanclient patch in :D | 09:09 |
| mnasiadka | haha | 09:10 |
| jakeyip | I'm still working on a few things | 09:11 |
| jakeyip | 1) deprecate k8s ironic - I don't even know how to test for this | 09:12 |
| jakeyip | 2) remove podsecuritypolicy - I think if removing doesn't break current clustertemplates, it should be fine, but I have to test it. there seems to be a lot of interest in this because it is preventing us moving forward | 09:13 |
| jakeyip | 3) secure rbac | 09:15 |
| jakeyip | 4) tidy up docs | 09:15 |
| jakeyip | how goes testing mnasiadka ? | 09:16 |
| mnasiadka | k8s ironic? hmm, wonder how that is different than the normal one | 09:19 |
| mnasiadka | testing - will continue after I fix last issue in Kolla | 09:23 |
| jakeyip | cool | 09:23 |
| jakeyip | re: ironic, it uses a fedora OS https://github.com/openstack/magnum/blob/master/magnum/drivers/k8s_fedora_ironic_v1/driver.py#L24-L26 https://opendev.org/openstack/magnum/src/branch/master/magnum/drivers/k8s_fedora_ironic_v1/image/kubernetes | 09:24 |
| jakeyip | I don't have the ability to test for this; basically unmaintained AFAICT | 09:24 |
| jakeyip | the docs says "Currently Ironic is not fully supported yet, therefore more details will be provided when this driver has been fully tested. | 09:25 |
| jakeyip | oh I realised this hasn't been reviewed https://review.opendev.org/c/openstack/magnum/+/878817 . this is a bug we encounter in our cloud as we are using flannel. | 09:53 |
| jakeyip | I think the other providers are using calico | 09:53 |
| opendevreview | Merged openstack/magnum master: Drop bay and baymodel from magnum https://review.opendev.org/c/openstack/magnum/+/803780 | 09:54 |
| mnasiadka | looks ok and touches only flannel, so fine by me ;) | 09:56 |
| opendevreview | Jake Yip proposed openstack/magnum master: Deprecate k8s fedora ironic driver https://review.opendev.org/c/openstack/magnum/+/882812 | 09:58 |
| jakeyip | thanks :) | 09:58 |
| jakeyip | re-testing it one last time before I merge; been a while | 09:59 |
| jakeyip | ah a calico review for you mnasiadka https://review.opendev.org/c/openstack/magnum/+/870475 | 10:02 |
| jakeyip | mnasiadka dalees what do you do with the Zanata reviews? https://review.opendev.org/c/openstack/magnum/+/882629 | 10:03 |
| mnasiadka | seems pretty straightforward | 10:04 |
| jakeyip | should I just +2 +1 workflow for Zanata (as long as nothing is obviously corrupted, etc?) | 10:05 |
| jakeyip | I dont' know how it keeps picking up those things, it seems to be super old | 10:06 |
| jakeyip | going to head off now, thanks for the reviews mnasiadka, we did well today :) | 10:11 |
| mnasiadka | let's merge Zanata, if there are more of these - probably we should have a look | 10:12 |
| jakeyip | +1 | 10:12 |
| opendevreview | Merged openstack/magnum master: Support k8s 1.25 in Calico Manifest https://review.opendev.org/c/openstack/magnum/+/870475 | 10:52 |
| opendevreview | Merged openstack/magnum master: Fix pods unable to send traffic to ClusterIP https://review.opendev.org/c/openstack/magnum/+/878817 | 10:52 |
| opendevreview | Merged openstack/magnum master: Imported Translations from Zanata https://review.opendev.org/c/openstack/magnum/+/882629 | 10:52 |
| jakeyip | mnasiadka: let me know how you feel about https://review.opendev.org/c/openstack/magnum/+/874092 | 11:36 |
| jakeyip | tested it with current clusters, work | 11:36 |
| mnasiadka | jakeyip: hmm, maybe we could have a script to remove podsecuritypolicy on existing clusters? Just in case we fix upgrades somewhere in future? ;-) | 11:59 |
| jakeyip | mnasiadka: I feel like upgrades will be handled by th CAPI driver, and I don't think think we can move from k8s_fcos -> capi | 12:27 |
| mnasiadka | we still in theory expose the option to do the upgrade, it just doesn't work | 12:31 |
| jakeyip | o yeah we restrict that call in our cloud with policy | 12:47 |
| jakeyip | mnasiadka: just to clarify, do you mean a script to remove PodSecurityPolicy from admission_control_list, or more, like ClusterRole, etc? | 13:11 |
| mnasiadka | jakeyip: just a script to have it handy - can be a followup (I think we already have one script to change something on existing clusters just in case we fix upgrades in the future, but we don't call it anywhere) ;-) | 13:12 |
| jakeyip | mnasiadka: an existing clusters may have installed more podsecuritypolicies from other helm charts, etc, the script won't be able to handl those | 13:13 |
| mnasiadka | oh boy, fantastic | 13:14 |
| mnasiadka | so maybe let's leave it as is | 13:14 |
| jakeyip | :D | 13:14 |
| jakeyip | ok I'll workflow +1 so we can unblock the other things that needs v1.25 | 13:15 |
| jakeyip | we will think about how to handle exisitng clusters later | 13:16 |
| opendevreview | Merged openstack/magnum master: Remove PodSecurityPolicy https://review.opendev.org/c/openstack/magnum/+/874092 | 13:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!