| dalees | jakeyip: mnasiadka: With regard to creating a Magnum-owned repo for CAPI Helm charts - how do we go about getting this set up? I'm happy to help make the requests. https://review.opendev.org/c/openstack/magnum/+/881453/15/magnum/conf/capi_driver.py#43 | 00:06 |
|---|---|---|
| opendevreview | Rico Lin proposed openstack/magnum master: Add releasenote for Trust token scope fix https://review.opendev.org/c/openstack/magnum/+/892845 | 04:02 |
| ricolin | jakeyip: releasenote added ^^^ | 04:03 |
| ricolin | I mean the patch | 04:03 |
| opendevreview | Dale Smith proposed openstack/magnum master: Update autoscaler clusterrole permissions to support 1.22 https://review.opendev.org/c/openstack/magnum/+/892846 | 04:04 |
| jakeyip | dalees: I was about to bring this up next meeting; I've got access to the original openstack magnum dockerhub repo from previous PTLs. https://hub.docker.com/orgs/openstackmagnum/repositories . we may be able to host it there . | 06:49 |
| jakeyip | ricolin: thanks! let me help fix a few trivial spelling and I'll merge that. | 06:51 |
| jakeyip | ricolin: will you help with removing the redundant trustee user policy from certificate api calls? Sorry, I know it's a big ask. we can discuss or split it up, feel free to DM me. | 06:54 |
| opendevreview | Jake Yip proposed openstack/magnum master: Add releasenote for Trust token scope fix https://review.opendev.org/c/openstack/magnum/+/892845 | 06:59 |
| opendevreview | Jake Yip proposed openstack/magnum master: Propose driver name as k8s_capi_v1 https://review.opendev.org/c/openstack/magnum/+/892854 | 07:16 |
| opendevreview | Jake Yip proposed openstack/magnum master: Propose driver name as k8s_capi_v1 https://review.opendev.org/c/openstack/magnum/+/892854 | 07:25 |
| jakeyip | hey all re: CAPI, there's one thing which is probably the hardest - naming :) . Please see the proposal. I'll willing to do the refactoring if this is acceptable by all. Thanks! | 07:26 |
| jakeyip | ^ | 07:26 |
| mnasiadka | dalees: we need a repository first, here's a list of similar patches we did for ansible-collection-kolla back in the days: https://review.opendev.org/c/openstack/project-config/+/819326 https://review.opendev.org/c/openstack/governance/+/819331 https://review.opendev.org/c/openstack/releases/+/824032 | 07:35 |
| mnasiadka | and then we should have a publish job in the repo to publish helm chart in artifact hub - happy to help if needed :) | 07:40 |
| opendevreview | Jake Yip proposed openstack/magnum master: Add releasenote for Trust token scope fix https://review.opendev.org/c/openstack/magnum/+/892845 | 07:40 |
| mnasiadka | jakeyip: dockerhub repo is not for helm charts - do we need to host any images for CAPI/CAPO? | 07:41 |
| mnasiadka | (not counting that docker hub and it's pull limits are insane) | 07:51 |
| jakeyip | mnasiadka: I haven't tried it yet, but I was under the impression docker hub can host helm charts (OCI) https://docs.docker.com/docker-hub/oci-artifacts/ | 07:52 |
| jakeyip | (we have our own registry) | 07:53 |
| mnasiadka | jakeyip: magnum helm chart is hosted in artficathub | 07:53 |
| mnasiadka | https://artifacthub.io/packages/helm/openstack-helm/magnum | 07:53 |
| mnasiadka | ah, it's openstack-helm | 07:53 |
| mnasiadka | not magnum | 07:53 |
| mnasiadka | lol | 07:53 |
| mnasiadka | whatever, I think this is the default helm chart location nowadays | 07:53 |
| mnasiadka | and I would not rely on docker hub | 07:54 |
| jakeyip | yeah, I was wondering where openstack-helm hosts their charts. and if openstack goverance has some guidelines | 07:54 |
| jakeyip | mnasiadka: I was thinking it's not that critical, just a default place for the reference helm chart. I'm pretty sure most deployments will host it on their registry. I think the last vPTG most of us have our own registries. | 07:58 |
| mnasiadka | jakeyip: for container images for sure, for helm charts - I have no clue, we don't mirror helm charts ;-) | 07:59 |
| jakeyip | yeah we'll probably have to with CAPI. | 08:11 |
| jakeyip | mnasiadka: if you have a moment can you take a look at the naming change https://review.opendev.org/c/openstack/magnum/+/892854 ? it includes some of your suggestions in your review. if you and dalees are ok with this, I can go ahead and change + rebase everything | 08:12 |
| jakeyip | I don't think we need to -1 and bother john/matt to change this, they done a great job already | 08:13 |
| mnasiadka | jakeyip: once you fix pep8 it's fine :) | 08:24 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Propose driver name as k8s_capi_v1 https://review.opendev.org/c/openstack/magnum/+/892854 | 09:45 |
| jakeyip | :) | 11:36 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Propose driver name as k8s_capi_v1 https://review.opendev.org/c/openstack/magnum/+/892854 | 13:15 |
| dalees | mnasiadka: We found recently that Helm charts can be hosted in an OCI registry[1] also. This makes use of existing internal infra that may already exist in many companies, without requiring another mirror location for published Helm charts. [1] https://helm.sh/docs/topics/registries/ | 21:05 |
| dalees | we should also publish to the standard artifact hub, as the reference implementation if this is the norm. | 21:07 |
| dalees | jakeyip: yep, naming is hard :) Yours looks good, and I'll review fully soon - thanks for moving things forward. The only question I have is if we want to leave room for alternative CAPI implementations such as those from Vexxhost (not utilising Helm, but pykube). Maybe that can fit under `k8s_capi_v2`, if it wants to merge into Magnum codebase? | 22:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!