| dalees | apologies, I won't make the meeting this evening. | 08:15 |
|---|---|---|
| opendevreview | Jake Yip proposed openstack/magnum master: Improve driver discovery https://review.opendev.org/c/openstack/magnum/+/907297 | 08:24 |
| jakeyip | that's ok :) | 08:44 |
| jakeyip | ping mnasiadka, available to meet? | 08:58 |
| mnasiadka | I'm here | 08:59 |
| jakeyip | #startmeeting magnum | 09:00 |
| opendevmeet | Meeting started Wed Jan 31 09:00:36 2024 UTC and is due to finish in 60 minutes. The chair is jakeyip. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:00 |
| opendevmeet | The meeting name has been set to 'magnum' | 09:00 |
| jakeyip | Agenda: | 09:00 |
| jakeyip | #link https://etherpad.opendev.org/p/magnum-weekly-meeting | 09:00 |
| jakeyip | #topic Roll Call | 09:00 |
| jakeyip | o/ | 09:00 |
| mnasiadka | o/ | 09:01 |
| jakeyip | #topic Reviews for discussion | 09:02 |
| jakeyip | mnasiadka: dalees has a spec for control plane resize up at https://review.opendev.org/c/openstack/magnum-specs/+/905281 | 09:03 |
| jakeyip | also have a change too | 09:03 |
| jakeyip | I think spec is pretty reasonable, can you give it a once over and merge it if you don't have any objections? | 09:04 |
| jakeyip | for the change, there are some things to work on, so that can continue | 09:04 |
| mnasiadka | For me it's ok, just the Implementation section is empty and looks weird :) | 09:04 |
| mnasiadka | but I guess nobody reads those | 09:05 |
| jakeyip | hm yeah the formatting is off | 09:05 |
| mnasiadka | I just +w'ed, dalees can follow up | 09:06 |
| jakeyip | I'll see if dalees is ok with updating formatting | 09:07 |
| jakeyip | ok next | 09:08 |
| jakeyip | improve driver discovery implementation | 09:08 |
| jakeyip | #link https://review.opendev.org/c/openstack/magnum/+/907297 | 09:08 |
| jakeyip | finally got some code up. not totally happy with it, there are a few edge cases I can think of | 09:09 |
| jakeyip | but will be grateful if you can take a look | 09:10 |
| opendevreview | Merged openstack/magnum-specs master: Propose control plane resize feature. https://review.opendev.org/c/openstack/magnum-specs/+/905281 | 09:11 |
| mnasiadka | will do after the meeting | 09:11 |
| jakeyip | thanks | 09:11 |
| jakeyip | #topic ClusterAPI | 09:13 |
| jakeyip | so CAPI driver will happen after the improve driver discovery implementation is merged | 09:13 |
| jakeyip | see ^^^ | 09:13 |
| jakeyip | tagging for easy search | 09:13 |
| jakeyip | sorry this took so long. and this will be priority for feature freeze. | 09:15 |
| jakeyip | I don't think I have much to add... you have any question mnasiadka ? | 09:15 |
| mnasiadka | No, first day after winter holiday, my brain is not online yet :) | 09:22 |
| jakeyip | there's also a couple of reviews for cilium which touches validation which the driver change will impact, I will take a look at those and have a think about it | 09:22 |
| jakeyip | cool, I don't want to stress you too much, just one more thing I need to catch up on :P | 09:23 |
| jakeyip | #topic Testing | 09:23 |
| opendevreview | Merged openstack/magnum master: Fix flakey validation tests. https://review.opendev.org/c/openstack/magnum/+/905636 | 09:23 |
| opendevreview | Merged openstack/magnum master: Drop Swarm support https://review.opendev.org/c/openstack/magnum/+/894395 | 09:23 |
| opendevreview | Merged openstack/magnum master: Drop dependency on pytz https://review.opendev.org/c/openstack/magnum/+/906949 | 09:23 |
| opendevreview | Merged openstack/magnum master: Move the chmod function before the write and flush functions to prevent sensitive information leakage. https://review.opendev.org/c/openstack/magnum/+/906108 | 09:23 |
| jakeyip | oh yay ^ | 09:23 |
| jakeyip | mnasiadka: anything that needs help re: testing? | 09:24 |
| mnasiadka | I need to solve dalees comments on the patch that polls failed heat stack state and updates node_addresses | 09:24 |
| mnasiadka | https://review.opendev.org/c/openstack/magnum/+/905357 | 09:25 |
| mnasiadka | that one | 09:25 |
| mnasiadka | #link https://review.opendev.org/c/openstack/magnum/+/905357 | 09:25 |
| mnasiadka | So, Swarm support drop is merged, I'll have a look at the rest of the drivers | 09:26 |
| mnasiadka | Since we only have Kubernetes now | 09:27 |
| jakeyip | oh yeah I had a brief look at that too | 09:27 |
| jakeyip | am not sure, one thing was, should we limit it to CREATE_FAILED (and make sure the timeout we set will be < CI timeout, so it will always fail before CI kills it?) | 09:28 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_coreos_v1 driver https://review.opendev.org/c/openstack/magnum/+/907300 | 09:40 |
| *** zigo_ is now known as zigo | 09:43 | |
| jakeyip | anyway let's end the meeting | 09:48 |
| jakeyip | #endmeeting | 09:48 |
| opendevmeet | Meeting ended Wed Jan 31 09:48:05 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:48 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-01-31-09.00.html | 09:48 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-01-31-09.00.txt | 09:48 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-01-31-09.00.log.html | 09:48 |
| opendevreview | Jake Yip proposed openstack/magnum stable/2023.2: Move the chmod function before the write and flush functions to prevent sensitive information leakage. https://review.opendev.org/c/openstack/magnum/+/907302 | 10:31 |
| opendevreview | Jake Yip proposed openstack/magnum stable/2023.1: Move the chmod function before the write and flush functions to prevent sensitive information leakage. https://review.opendev.org/c/openstack/magnum/+/907303 | 10:31 |
| opendevreview | Jake Yip proposed openstack/magnum stable/zed: Move the chmod function before the write and flush functions to prevent sensitive information leakage. https://review.opendev.org/c/openstack/magnum/+/907304 | 10:33 |
| opendevreview | Jake Yip proposed openstack/magnum stable/yoga: Move the chmod function before the write and flush functions to prevent sensitive information leakage. https://review.opendev.org/c/openstack/magnum/+/907305 | 10:33 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: heat: Update addresses on CREATE_FAILED https://review.opendev.org/c/openstack/magnum/+/905357 | 11:07 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Add kubernetes fedora coreos v1 jobs https://review.opendev.org/c/openstack/magnum/+/896244 | 11:57 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Add kubernetes fedora coreos v1 jobs https://review.opendev.org/c/openstack/magnum/+/896244 | 11:57 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_coreos_v1 driver https://review.opendev.org/c/openstack/magnum/+/907300 | 13:10 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_fedora_ironic_v1 driver https://review.opendev.org/c/openstack/magnum/+/907319 | 13:15 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_coreos_v1 driver https://review.opendev.org/c/openstack/magnum/+/907300 | 14:03 |
| opendevreview | Dale Smith proposed openstack/magnum master: Change network driver test to use non-default driver. https://review.opendev.org/c/openstack/magnum/+/905632 | 14:53 |
| mnasiadka | jakeyip, dalees: Are we fine with bumping down coverage requirements from 90 to 85 for the time of dumping old drivers and then fixing it back when we only have k8s_fedora_coreos_v1 ? | 15:13 |
| mnasiadka | because it got down to 89 in k8s_coreos_v1 removal | 15:14 |
| mnasiadka | which is a bit funny because I haven't removed any tests | 15:15 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_fedora_ironic_v1 driver https://review.opendev.org/c/openstack/magnum/+/907319 | 16:21 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Drop k8s_fedora_ironic_v1 driver https://review.opendev.org/c/openstack/magnum/+/907319 | 16:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!