| jakeyip | hi all, meeting in ~5 mins. mnasiadka / dalees around? | 08:55 |
|---|---|---|
| dalees | hello jakeyip | 08:55 |
| jakeyip | hi dalees | 08:56 |
| jakeyip | dalees: hm did you update the agenda under last week's date? | 08:59 |
| dalees | not today | 09:00 |
| jakeyip | hmm, weird, I don't remember so many reviews previously | 09:00 |
| jakeyip | give me another 2 mins to tidy it up | 09:01 |
| jakeyip | #startmeeting magnum | 09:03 |
| opendevmeet | Meeting started Wed May 15 09:03:30 2024 UTC and is due to finish in 60 minutes. The chair is jakeyip. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:03 |
| opendevmeet | The meeting name has been set to 'magnum' | 09:03 |
| jakeyip | #link https://etherpad.opendev.org/p/magnum-weekly-meeting | 09:03 |
| jakeyip | #topic Roll Call | 09:03 |
| dalees | o/ | 09:03 |
| jakeyip | o/ | 09:03 |
| mkjpryor | o/ | 09:03 |
| jakeyip | hi mkjpryor, nice of you to join :) | 09:04 |
| mkjpryor | Been a busy couple of weeks ;-) | 09:04 |
| jakeyip | I'm not sure if mnasiadka is here today, we might start without him | 09:04 |
| jakeyip | mkjpryor: if you have topics please put them into the agenda | 09:05 |
| jakeyip | #topic Reviews | 09:05 |
| jakeyip | Workflow updates https://review.opendev.org/c/openstack/magnum-ui/+/917915 | 09:05 |
| jakeyip | dalees: this is yours | 09:05 |
| jakeyip | I saw your comment. I tried out `required: true` in devstack, the form was submittable without modifying. was your experience different? | 09:06 |
| dalees | no, that is my experience | 09:06 |
| dalees | and also why the tab shouldn't be required. You don't need to visit it. | 09:06 |
| jakeyip | ah ok I see what you mean. the JS doesn't prevent you from submitting, but you want to update the UX that it's not shown as a * (required) anymore | 09:07 |
| dalees | indeed, it's just the * and it indicates there's something that needs attention in the tab | 09:08 |
| jakeyip | all good | 09:08 |
| jakeyip | anotherwas the !isNewNetwork, I am not sure what the change does. | 09:09 |
| jakeyip | the behaviour doesn't seem to change regardless | 09:09 |
| dalees | hmm, i'll retest that. | 09:10 |
| jakeyip | ok let me know. it's good otherwise. thanks | 09:10 |
| dalees | the idea is, if you select 'create new network' it'll reset those two options back to their defaults. But perhaps that change isn't what I think it is. | 09:11 |
| jakeyip | ah I see. is there a bug that can be triggered now when you de-selected, change the fixed_network & fixed_subnet, and reselect 'create new network' ? | 09:12 |
| dalees | yeah, but i'll revisit and ensure the model is consistent with the selected items. | 09:15 |
| jakeyip | hmm, I'm not sure if my network is being a bit wonky today or opendev.org being slow. | 09:15 |
| dalees | now i'm looking at it, the original logic seems correct. | 09:15 |
| jakeyip | hm, ok I'll review if you want to send up a change after | 09:17 |
| jakeyip | shall we go on? | 09:17 |
| dalees | sure | 09:17 |
| jakeyip | Floating IP - https://review.opendev.org/c/openstack/magnum-ui/+/919449/ | 09:18 |
| jakeyip | I think it's a good change, the other option doesn't make sense | 09:18 |
| jakeyip | not sure if someone needs the other one, but I guess we can add it back later if someone misses it? | 09:18 |
| dalees | hmm, perhaps the other is useful if you don't have an LB in front of a single master? | 09:19 |
| dalees | but we never do that. | 09:19 |
| jakeyip | yeah for people who don't have LBaaS | 09:20 |
| jakeyip | but there's so many things you can't do without octavia right, like what will ingress run on | 09:21 |
| jakeyip | I will review that too | 09:22 |
| mkjpryor | dalees I could never get the rolling control plane upgrade to work without an LB, so we always use one even with single master | 09:22 |
| mkjpryor | It might be better now - the last time I tried was a while ago (maybe a year or more) | 09:23 |
| jakeyip | mkjpryor: good point too | 09:23 |
| dalees | mkjpryor: yeah, i don't know how you would without passing a VIP around? | 09:23 |
| mkjpryor | There is a project called kube-vip that might be able to jelp | 09:23 |
| mkjpryor | *help | 09:23 |
| mkjpryor | Not sure how it would integrate with a FIP though | 09:24 |
| mkjpryor | :shrugs: | 09:24 |
| jakeyip | can ingress work without octavia? | 09:24 |
| mnasiadka | with multi master you need something that will manage the VIP | 09:24 |
| mkjpryor | The OCCM implementation of LB services relies on Octavia, for sure | 09:24 |
| jakeyip | dalees: there are few more to go thru, are there any priority ones you want to get thru first? | 09:24 |
| mnasiadka | unless you go DNS | 09:24 |
| mnasiadka | o/ | 09:25 |
| jakeyip | hi mnasiadka | 09:25 |
| dalees | probably can do ingress if you use NodePort and point some LB appliance at all the nodes? but not a use case i'm too interested in ;) | 09:25 |
| mkjpryor | Or give all your nodes a public IP and use round robin DNS :vomit: | 09:26 |
| dalees | jakeyip: yeah let's also highlight https://review.opendev.org/c/openstack/magnum-ui/+/917913 - downloading kubeconfig | 09:26 |
| dalees | otherwise the others are just life improvements for users. | 09:26 |
| jakeyip | dalees: I will take a look at that to give comments too | 09:27 |
| jakeyip | let's get on to the other reviews first, we can come back to the other magnum-ui reviews later. I am concern of the time, not sure if mkjpryor have things to discuss too | 09:28 |
| mkjpryor | I don't have anything in particular | 09:28 |
| dalees | sure, no worries; thanks | 09:28 |
| jakeyip | py3 - https://review.opendev.org/c/openstack/python-magnumclient/+/918507 https://review.opendev.org/c/openstack/magnum/+/918506 | 09:28 |
| jakeyip | mnasiadka: let with this I think should be fine | 09:28 |
| mkjpryor | mnasiadka has made good progress towards getting a first release of the opendev magnum-capi-helm driver out | 09:29 |
| jakeyip | mkjpryor: I will set a topic for that, can you fill up https://etherpad.opendev.org/p/magnum-weekly-meeting ? | 09:29 |
| jakeyip | SSL - we need to update with py312. there are two different approaches, will people help take a look and give comments? | 09:30 |
| jakeyip | https://review.opendev.org/c/openstack/python-magnumclient/+/903748 and https://review.opendev.org/c/openstack/python-magnumclient/+/905869 | 09:30 |
| dalees | jakeyip: i saw those, glad it's mentioned. either look functional, not sure how to give preference to either. 905869 made sense to me. | 09:31 |
| jakeyip | ok vote on that :P | 09:34 |
| opendevreview | James Page proposed openstack/python-magnumclient master: Update VerifiedHTTPSConnection for Python >= 3.12 https://review.opendev.org/c/openstack/python-magnumclient/+/905869 | 09:34 |
| jakeyip | oh hahahah ^ | 09:34 |
| dalees | I rebased it | 09:34 |
| jakeyip | pl | 09:35 |
| jakeyip | ok | 09:35 |
| dalees | so the new python3.12 tests run in zuul | 09:35 |
| jakeyip | yeah | 09:35 |
| jakeyip | I may have tested it locally but I can't remember... anyway. | 09:36 |
| jakeyip | let's go on | 09:36 |
| jakeyip | magnum-ui tests failures - https://review.opendev.org/c/openstack/magnum-ui/+/909518 https://review.opendev.org/c/openstack/magnum-ui/+/909519 | 09:36 |
| jakeyip | I had a brief look but didn't manage to fix them. not sure if anyone is keen to give it a go | 09:37 |
| jakeyip | please help if you can | 09:40 |
| jakeyip | I might go on ... | 09:41 |
| jakeyip | kubernetes v1.28.9 tests - https://review.opendev.org/c/openstack/magnum/+/919560 | 09:41 |
| jakeyip | oh need a fix | 09:42 |
| jakeyip | anyway I got k8s v1.28.9 working with heat for our conformance :D we also going to support 1.28.9 so I sent that up | 09:43 |
| jakeyip | mnasiadka: you may be interested cos you were working on magnum-tempest-plugin side... | 09:44 |
| dalees | nice | 09:44 |
| dalees | fcos40 is stable now, the catch-up never ends :) | 09:45 |
| opendevreview | Jake Yip proposed openstack/magnum master: Add tests for Kubernetes v1.28.9 https://review.opendev.org/c/openstack/magnum/+/919560 | 09:45 |
| jakeyip | yeah CAPI will save us allo | 09:45 |
| mnasiadka | yeah, now that Kolla/Kolla-Ansible Caracal is out, I might have more time for Magnum Tempest ;) | 09:45 |
| dalees | well, it'll move the work somewhere else ;) | 09:45 |
| jakeyip | :D | 09:45 |
| jakeyip | ok let's talk CAPI then. what's up for CAPi | 09:46 |
| mkjpryor | We are quite close to a first release on the magnum-capi-helm opendev repo | 09:47 |
| mkjpryor | mnasiadka probably has more context than me there as he has been driving the work | 09:47 |
| mkjpryor | But my understanding is there are a couple of small fixes + release notes to do | 09:48 |
| mnasiadka | Yes, we need those damn renos, where our colleague Scott promised to work on them, if not I'll do it myself next week - and file up a release patch | 09:48 |
| jakeyip | > Couple of outstanding reviews - mkjpryor are you able to help on the open ones? https://review.opendev.org/q/project:openstack/magnum-capi-helm+status:open | 09:48 |
| mkjpryor | I can take a look | 09:49 |
| jakeyip | mnasiadka: good to hear that, can't wait, we are also concentrating on this now | 09:49 |
| jakeyip | ping me if you want quick reviews. | 09:51 |
| jakeyip | mnasiadka: what about tests? I am unsure how to do it | 09:51 |
| mnasiadka | tests for magnum-capi-helm? | 09:51 |
| jakeyip | integration test with magnum? | 09:51 |
| mnasiadka | we need some other job for it, that would stand up a mini CAPI cluster - in tempest plugin repo | 09:52 |
| mnasiadka | and then reference it in Magnum and in magnum-capi-helm repos | 09:52 |
| mnasiadka | I'll try to work on this next week | 09:52 |
| jakeyip | the devstack script that stackhpc sent up worked pretty good. I used it previously; I may take a look again | 09:52 |
| opendevreview | Merged openstack/python-magnumclient master: Update Python runtime for 2024.2 https://review.opendev.org/c/openstack/python-magnumclient/+/918507 | 09:53 |
| jakeyip | I'll try find it if you don't know what I'm talking about mnasiadka | 09:55 |
| jakeyip | that's all on the agenda | 09:57 |
| jakeyip | #topic Open Discussion | 09:57 |
| mnasiadka | jakeyip: yeah, I'll reuse it, no worries | 09:58 |
| mnasiadka | Open discussion - I have a question | 09:58 |
| mnasiadka | How bad are we affected by eventlet drama? | 09:58 |
| mnasiadka | (apologies if that has been discussed already) | 09:58 |
| jakeyip | I was following it a while back, but I forgot the thoughts I had in my head since then | 10:00 |
| jakeyip | apologies, I will re-read the thread and discuss next meetinG? | 10:01 |
| dalees | +1 agenda for next meeting. We appear to use eventlet, but I've not looked any more than that yet! | 10:01 |
| mnasiadka | good idea | 10:03 |
| mnasiadka | jakeyip: https://review.opendev.org/c/openstack/magnum-capi-helm/+/915473 - can you re-review since you had some comments last time? | 10:03 |
| jakeyip | I've added eventlet to next weeks agenda | 10:03 |
| jakeyip | mnasiadka: ok for https://review.opendev.org/c/openstack/magnum-capi-helm/+/915473 | 10:03 |
| jakeyip | anything else? | 10:05 |
| dalees | nothing more from me | 10:06 |
| jakeyip | mnasiadka / mkjpryor ? | 10:07 |
| mnasiadka | nope | 10:07 |
| mkjpryor | Nothing from me | 10:07 |
| jakeyip | ok thanks for coming! | 10:07 |
| jakeyip | #endmeeting | 10:07 |
| opendevmeet | Meeting ended Wed May 15 10:07:59 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 10:07 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-15-09.03.html | 10:07 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-15-09.03.txt | 10:07 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-15-09.03.log.html | 10:07 |
| opendevreview | Merged openstack/magnum master: Update Python runtime for 2024.2 https://review.opendev.org/c/openstack/magnum/+/918506 | 10:25 |
| opendevreview | Merged openstack/magnum-capi-helm master: Allow additional load balancer customisation https://review.opendev.org/c/openstack/magnum-capi-helm/+/915473 | 10:25 |
| opendevreview | OpenStack Release Bot proposed openstack/magnum-ui master: reno: Update master for unmaintained/zed https://review.opendev.org/c/openstack/magnum-ui/+/917397 | 10:35 |
| opendevreview | Dale Smith proposed openstack/magnum-ui master: Workflow updates for Create Cluster https://review.opendev.org/c/openstack/magnum-ui/+/917915 | 23:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!