| opendevreview | Dale Smith proposed openstack/magnum master: Implement control plane resizing with driver. https://review.opendev.org/c/openstack/magnum/+/906086 | 02:26 |
|---|---|---|
| jakeyip | hi all, meeting in ~15 mins. dalees / mnasiadka around? | 08:46 |
| mnasiadka | I'm around, but might be not fully responsive (on a bunch of other calls, sorry) | 08:46 |
| jakeyip | that's ok, let me know if there's something you want us to discuss | 08:50 |
| jakeyip | dalees: are you around? | 08:55 |
| dalees | jakeyip: hello! | 08:56 |
| jakeyip | hi! :) | 08:56 |
| jakeyip | can dump your reviews into the agenda please :) | 08:58 |
| dalees | haha, okay I'll find a few to discuss | 08:58 |
| jakeyip | let's start | 09:03 |
| jakeyip | #startmeeting magnum | 09:03 |
| opendevmeet | Meeting started Wed May 29 09:03:54 2024 UTC and is due to finish in 60 minutes. The chair is jakeyip. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:03 |
| opendevmeet | The meeting name has been set to 'magnum' | 09:03 |
| jakeyip | #link https://etherpad.opendev.org/p/magnum-weekly-meeting | 09:03 |
| jakeyip | Please put your topics into to Agenda | 09:04 |
| jakeyip | #topic Roll Call | 09:04 |
| jakeyip | o/ | 09:04 |
| dalees | o/ | 09:04 |
| jakeyip | let's wait a couple of mins | 09:04 |
| opendevreview | Natz cheng proposed openstack/magnum-tempest-plugin master: Use py3 as the default runtime for tox https://review.opendev.org/c/openstack/magnum-tempest-plugin/+/895531 | 09:05 |
| jakeyip | #topic Review Action Items | 09:06 |
| jakeyip | Cluster actions: kubeconfig download and reorder | 09:07 |
| jakeyip | #link https://review.opendev.org/c/openstack/magnum-ui/+/917913 | 09:07 |
| jakeyip | dalees: this is generally OK, I do have a comment. keystone_auth_enabled defaults to True, but your patch checks for the label explicitly. do you have a reason for this? | 09:08 |
| dalees | yeah, I think we're specifying it explicitly in our Cluster Templates so I made the wrong assumption about the default. I'll re-check this and make the change so it accounts for the default | 09:09 |
| dalees | thanks for catching that | 09:09 |
| jakeyip | I guess you can flip the logic and it'll work, i.e. check for False :) | 09:10 |
| opendevreview | Merged openstack/python-magnumclient master: Remove extraneous quote in non-TLS kubeconfig https://review.opendev.org/c/openstack/python-magnumclient/+/918950 | 09:10 |
| dalees | yep, I'll test the defaults too though. The CAPI driver (or helm charts) might have a different default, but I hope not and I hope I just got it wrong. | 09:11 |
| jakeyip | ah I see. ok I'll wait for your response. thanks! that is good work | 09:12 |
| dalees | It's quite nice to download a kubeconfig file and **just use it** without any openstack CLI auth :) | 09:13 |
| dalees | kudos to ricolin for the first version of that feature | 09:13 |
| jakeyip | do you have it in use for your production clusters? | 09:15 |
| dalees | Yes, I even updated our quickstart screenshots with all these changes in place :) https://docs.catalystcloud.nz/kubernetes/quickstart.html#creating-a-kubernetes-cluster | 09:16 |
| jakeyip | actually I thought we need another patch at https://opendev.org/openstack/python-magnumclient/src/branch/master/magnumclient/common/utils.py#L251 | 09:18 |
| jakeyip | that line is still using v1beta1, another one at ln 243 | 09:19 |
| dalees | ah, maybe we do. I recall updating it from `v1alpha1` in https://opendev.org/openstack/python-magnumclient/commit/de11f40d0c632ff839e5838ed650d1821c87d8a8 | 09:21 |
| jakeyip | dalees: maybe I am wrong. I couldn't get it to work in devstack (using OS_CLOUDS=devstack) | 09:22 |
| jakeyip | let me try again and comment. good that it is working for you | 09:22 |
| jakeyip | I haven't review the rest of magnum-ui changes, I will get to them | 09:24 |
| dalees | it looks like `client.authentication.k8s.io/v1` is what it should be, even if it continues to work with my `kubectl` version. But I'll need to dig up the version it was introduced, removed and deprecated to make sure I understand the timeline. https://v1-29.docs.kubernetes.io/docs/reference/config-api/client-authentication.v1/ | 09:24 |
| jakeyip | possibly both are still supported at this point in time and I was facing another different error. I'll update when I find out more | 09:27 |
| dalees | In my quick search, I can't find signs of `ExecCredential`s v1beta1 being removed yet... | 09:28 |
| dalees | yep - ping me if you have issues and error messages. Maybe I can also reproduce on my side or help investigate. | 09:29 |
| jakeyip | ok | 09:30 |
| jakeyip | I don't have much to discuss, just want to bring to attention that I haven't got CI passing for v1.28 with Heat driver | 09:31 |
| jakeyip | #link https://review.opendev.org/c/openstack/magnum/+/919560 | 09:31 |
| jakeyip | it passes locally in my devstack but I don't know what's wrong in Zuul. I might play around that patch to cut down number of tests etc to try | 09:32 |
| dalees | reading zuul logs i notice "0/1 nodes are available: 1 node(s) had untolerated taint {node-role.kubernetes.io/control-plane: }" | 09:34 |
| jakeyip | hm that's wrong | 09:34 |
| dalees | and "0/1 nodes are available: 1 node(s) had untolerated taint {node.cloudprovider.kubernetes.io/uninitialized: true}". | 09:35 |
| dalees | So not sure which is the most relevant to the failure | 09:35 |
| jakeyip | I was hoping for a `kubectl get nodes` but that output is in json and my eyes went x_x | 09:36 |
| jakeyip | oh yah I remember another place I got stuck | 09:39 |
| jakeyip | https://zuul.opendev.org/t/openstack/build/bb7a0c2d39ba46feaba68b28093f7dc1/logs occm logs at https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bb7/919560/3/check/magnum-tempest-plugin-tests-cluster-k8s_fcos_v1-1.28-flannel/bb7a0c2/controller/logs/magnum-nodes/kubernetes/pods/kube-system/openstack-cloud-controller-manager-dhn7p | 09:40 |
| jakeyip | E0520 09:19:36.923645 1 node_controller.go:240] error syncing 'tempest-cluster-308782461-3hjtwkyajabv-node-0': failed to get instance metadata for node tempest-cluster-308782461-3hjtwkyajabv-node-0: Get "https://199.204.45.177:9696/networking/v2.0/ports?device_id=f26c7b4a-0747-4eb2-8508-1108cf160821": dial tcp 199.204.45.177:9696: connect: no route to host, | 09:40 |
| jakeyip | requeuing | 09:40 |
| jakeyip | it looked like the networking is broken, but I couldn't tell why | 09:40 |
| dalees | hmm, failed trying to talk from the cluster to the openstack neutron serivce. | 09:41 |
| jakeyip | yeah. for both calico and flannel, so it's not a cni issue | 09:42 |
| opendevreview | Merged openstack/magnum master: Change network driver test to use non-default driver. https://review.opendev.org/c/openstack/magnum/+/905632 | 09:43 |
| dalees | not sure if that's a magnum problem or the VM generally can't reach openstack | 09:43 |
| jakeyip | well the 1.27 clusters in same PS worked. just broken for 1.28 clusters | 09:43 |
| dalees | but other tests pass for 1.27? so it must be isolated to 1.28 | 09:43 |
| jakeyip | maybe I play around with occm, try the 1.27 occm with the 1.28 cluster | 09:44 |
| dalees | yeah good plan | 09:44 |
| jakeyip | what versions do you use? | 09:44 |
| dalees | we didn't run 1.28 in Heat | 09:45 |
| jakeyip | ok | 09:47 |
| opendevreview | Jake Yip proposed openstack/magnum master: DNM: Test CI for v1.28.9 https://review.opendev.org/c/openstack/magnum/+/920725 | 09:47 |
| jakeyip | anything else? | 09:47 |
| dalees | that's all from me, thanks again for the effort on reviews | 09:49 |
| jakeyip | no worries. thanks for staying late (again) :) | 09:50 |
| jakeyip | let's end the meeting | 09:50 |
| jakeyip | #endmeeting | 09:51 |
| opendevmeet | Meeting ended Wed May 29 09:51:09 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:51 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-29-09.03.html | 09:51 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-29-09.03.txt | 09:51 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/magnum/2024/magnum.2024-05-29-09.03.log.html | 09:51 |
| opendevreview | Jake Yip proposed openstack/magnum master: DNM: Test CI for v1.28.9 https://review.opendev.org/c/openstack/magnum/+/920725 | 12:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!