| jakeyip | hi anyone wants to meet? | 09:01 |
|---|---|---|
| jakeyip | mnasiadka: ok I will look at that patch | 09:02 |
| mnasiadka | I'm here | 09:07 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Fix sqlalchemy with osprofiler https://review.opendev.org/c/openstack/magnum/+/936751 | 09:08 |
| mnasiadka | updated the commit message with more information when it started breaking | 09:08 |
| jakeyip | I actually don't quite understand how the patch broke it yet | 09:15 |
| mnasiadka | magnum-capi-helm does not import the whole CONF struct from Magnum - it just uses it's own version of CONF - where there's only a couple of configuration variables - excluding osprofiler | 09:24 |
| mnasiadka | (at least in unit testing) | 09:24 |
| mnasiadka | but it worked before that patch | 09:24 |
| jakeyip | ah got it now it's in here https://review.opendev.org/c/openstack/magnum/+/935986/1/magnum/db/sqlalchemy/api.py#b51 | 09:26 |
| jakeyip | there was a guard for checking if osprofiler is there. isn't as good as your patch | 09:28 |
| mnasiadka | right, thanks | 09:35 |
| mnasiadka | so now we need Dale to review :) | 09:35 |
| jakeyip | it's trivial happy to +w if Zuul says yes :) | 09:38 |
| mnasiadka | well, it failed on copy_pod_logs timeout - I've seen that multiple times, will try to fix that in tempest-plugin over christmas period | 10:47 |
| jakeyip | mnasiadka: can you have a look at https://review.opendev.org/c/openstack/magnum/+/935456 ? I think it's ok, referencing https://docs.openstack.org/devstack/latest/zuul_ci_jobs_migration.html#devstack-gate-flags . wonder if you have any idea if we need to fix up the other DEVSTACK_GATE_* vars | 11:35 |
| mnasiadka | I'll have a look - I think we would need to think about the future of those image build jobs | 11:39 |
| mnasiadka | and maybe deprecating the Heat driver | 11:39 |
| jakeyip | yeah the heat driver jobs are taking so long. capi will be much quicker | 11:40 |
| mnasiadka | I doubt anybody wants to work on Heat driver - so it would be best to deprecate it for future removal | 11:46 |
| opendevreview | Merged openstack/magnum master: Fix sqlalchemy with osprofiler https://review.opendev.org/c/openstack/magnum/+/936751 | 12:18 |
| opendevreview | Michal Nasiadka proposed openstack/magnum-capi-helm master: CI: Stop running py38, add py312 https://review.opendev.org/c/openstack/magnum-capi-helm/+/933703 | 16:19 |
| opendevreview | Michal Nasiadka proposed openstack/magnum-capi-helm master: CI: Stop running py38, add py312 https://review.opendev.org/c/openstack/magnum-capi-helm/+/933703 | 16:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!