| opendevreview | Michal Nasiadka proposed openstack/magnum master: grenade: Compare collation sets for all tables https://review.opendev.org/c/openstack/magnum/+/1010460 | 06:18 |
|---|---|---|
| opendevreview | Michal Nasiadka proposed openstack/magnum master: grenade: Compare collation sets for all tables https://review.opendev.org/c/openstack/magnum/+/1010460 | 06:18 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Align charset on tables missing explicit declaration https://review.opendev.org/c/openstack/magnum/+/1008413 | 06:19 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Align charset on tables missing explicit declaration https://review.opendev.org/c/openstack/magnum/+/1008413 | 06:19 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: CI: Add grenade slurp job https://review.opendev.org/c/openstack/magnum/+/1010143 | 06:19 |
| M[m] | mnasiadka: wondering if you can offer some guidance on the novaclient issue i’m hitting on https://review.opendev.org/c/openstack/magnum-capi-helm/+/1007740 | 06:31 |
| M[m] | I’ve removed as requested but its failing now for tox tests. What would the correct way forward be now? | 06:31 |
| mnasiadka | M[m]: ah, it’s failing because magnum removed novaclient usage - let me fix that | 06:42 |
| M[m] | Thank you | 06:43 |
| opendevreview | Michal Nasiadka proposed openstack/magnum-capi-helm master: Fix unit tests that used novaclient https://review.opendev.org/c/openstack/magnum-capi-helm/+/1010600 | 06:52 |
| mnasiadka | darmach: ^^ if you can have a look M[m] would be grateful ;-) | 07:01 |
| opendevreview | Matt Verran proposed openstack/magnum-capi-helm master: fix: workaround helm 4.2.1 onwards https://review.opendev.org/c/openstack/magnum-capi-helm/+/1007740 | 07:11 |
| M[m] | While thats going through - is there anything else you can see i need to resolve or does it seem like its in the right place now? | 07:20 |
| mnasiadka | Added some cosmetic comments, so it looks like it should | 07:35 |
| M[m] | Ok, will get those in after $DAYJOB later today. | 07:56 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: grenade: Compare collation sets for all tables https://review.opendev.org/c/openstack/magnum/+/1010460 | 13:49 |
| opendevreview | Michal Nasiadka proposed openstack/magnum master: Align charset on tables missing explicit declaration https://review.opendev.org/c/openstack/magnum/+/1008413 | 13:50 |
| mgrzybek | I’m working on the addons-management spec. I think that this one should be implemented before the hosted control plane feature. In fact, HCP clusters do need an addon manager to install the basics (CNI, CCM…). | 14:16 |
| opendevreview | Matt Verran proposed openstack/magnum-capi-helm master: fix: workaround helm 4.2.1 onwards https://review.opendev.org/c/openstack/magnum-capi-helm/+/1007740 | 21:58 |
| M[m] | Hopefully good to go mnasiadka once your change with darmach goes through. Appreciate the guidance. | 22:06 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!