| sputnik13 | vipul: hey, how do you run the coverage report? I tried downloading the review for cue https://review.openstack.org/#/c/171016/1 and I ran `coverage run` from the cue project directory | 00:02 |
|---|---|---|
| sputnik13 | and nothing happens | 00:02 |
| sputnik13 | coverage says "Nothing to do" | 00:02 |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Broker image selection https://review.openstack.org/169437 | 00:03 |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Updating database models to fix time stamp errors https://review.openstack.org/169128 | 00:03 |
| openstackgerrit | Davide Agnello proposed stackforge/cue: Updating database models to fix time stamp errors https://review.openstack.org/169128 | 00:22 |
| *** sputnik13 has quit IRC | 00:23 | |
| *** davideagnello has quit IRC | 00:24 | |
| *** abitha has quit IRC | 01:12 | |
| *** danielallegood has quit IRC | 01:25 | |
| *** davideagnello has joined #openstack-cue | 02:10 | |
| *** davideagnello has quit IRC | 02:41 | |
| *** harlowja is now known as harlowja_away | 03:58 | |
| *** davideagnello has joined #openstack-cue | 04:29 | |
| *** davideagnello has quit IRC | 04:34 | |
| *** abitha has joined #openstack-cue | 04:41 | |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Broker image selection https://review.openstack.org/169437 | 05:03 |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Updating database models to fix time stamp errors https://review.openstack.org/169128 | 05:03 |
| *** abitha_ has joined #openstack-cue | 05:08 | |
| *** abitha has quit IRC | 05:10 | |
| *** abitha_ has quit IRC | 05:43 | |
| *** abitha has joined #openstack-cue | 05:45 | |
| *** abitha has quit IRC | 05:46 | |
| *** harlowja_away has quit IRC | 10:02 | |
| *** davideagnello has joined #openstack-cue | 11:44 | |
| *** davideagnello has quit IRC | 11:49 | |
| *** miqui has joined #openstack-cue | 13:20 | |
| *** danielallegood has joined #openstack-cue | 16:44 | |
| *** harlowja has joined #openstack-cue | 16:59 | |
| *** abitha has joined #openstack-cue | 17:05 | |
| *** davideagnello has joined #openstack-cue | 17:06 | |
| *** abitha has quit IRC | 17:18 | |
| *** abitha has joined #openstack-cue | 17:20 | |
| *** abitha has quit IRC | 17:21 | |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Unit test wsme objects https://review.openstack.org/172253 | 17:50 |
| *** sputnik13 has joined #openstack-cue | 17:51 | |
| esmute | d | 18:01 |
| esmute | vipul, sputnik13: Is there a cue meeting today? | 18:01 |
| sputnik13 | there's supposed to be | 18:02 |
| esmute | sputnik13: Do you want to lead it? Looks like vipul is not available. Here are the commands for meetbot https://wiki.debian.org/MeetBot | 18:03 |
| sputnik13 | already on it | 18:03 |
| sputnik13 | come to #openstack-meeting-alt | 18:04 |
| *** abitha has joined #openstack-cue | 18:10 | |
| *** abitha has quit IRC | 19:18 | |
| *** abitha has joined #openstack-cue | 20:00 | |
| openstackgerrit | Steve Leon proposed stackforge/cue: Refactor tests. https://review.openstack.org/173509 | 20:33 |
| vipul | davideagnello: just looking at this patch around the SoftDeleteMixin | 20:38 |
| vipul | davideagnello: you mentioned that we already have db api tests that exercise soft-delete? https://github.com/stackforge/cue/blob/master/cue/tests/db/test_api.py | 20:39 |
| vipul | i don't see any of those tests there | 20:39 |
| vipul | or here https://github.com/stackforge/cue/blob/master/cue/tests/db/test_models.py | 20:39 |
| davideagnello | vipul: I said we have tests that create cluster objects from DB layer and objects layer not just API through post | 20:40 |
| davideagnello | Soft delete is being tested indirectly through the API test that I have added in that patch | 20:40 |
| davideagnello | through issuing a delete in the api | 20:40 |
| davideagnello | which then makes use of softdelete functionality | 20:41 |
| davideagnello | timestamps are being checked for relative time compared to created_at and updated_at | 20:41 |
| vipul | davideagnello: right.. that makes sense. It would be nice to have these things verified from the dbapi directly | 20:41 |
| davideagnello | vipul: yes it would, I noticed that we don't have tests for any of our mixin db classes at all yet. | 20:42 |
| davideagnello | I can add some tests directly at the db api level as part of this patch or can we add them as part of QA (will create work item to capture this coverage) | 20:43 |
| vipul | Yea how do you want to handle it.. we gotta get to these sooner or later | 20:43 |
| sputnik13 | well, additional tests can be a new patch, we just need the action captured in Jira or launchpad | 20:47 |
| sputnik13 | the patch as it is looks ok if we capture the action to create these additional tests, then we can plan that in to the next sprint | 20:48 |
| vipul | i'm fine with that.. let's capture it then | 20:48 |
| davideagnello | ok | 20:48 |
| davideagnello | filed in launchpad: https://bugs.launchpad.net/cue/+bug/1444140 | 20:51 |
| openstack | Launchpad bug 1444140 in Cue "Add unit/function tests for DB Mixin classes" [Undecided,New] | 20:51 |
| openstackgerrit | Merged stackforge/cue: Adding .coveragerc to exclude tests and oslo modules https://review.openstack.org/171016 | 20:52 |
| sputnik13 | davideagnello thanks for filing that, I added the above conversation as a comment to provide some context | 20:52 |
| vipul | cool thanks davideagnello, sputnik13 | 20:53 |
| openstackgerrit | Merged stackforge/cue: Updating database models to fix time stamp errors https://review.openstack.org/169128 | 20:53 |
| sputnik13 | yay, 2 reviews closed today :-) | 20:54 |
| sputnik13 | the fix for the taskflow/flow tests raised coverage to 63% | 20:56 |
| davideagnello | awesome! | 20:57 |
| vipul | nice! that's almost a free 97 | 20:58 |
| vipul | 7% | 20:58 |
| sputnik13 | yeah :) | 20:58 |
| openstackgerrit | Min Pae proposed stackforge/cue: adding coverage tempfiles to gitignore https://review.openstack.org/173518 | 21:00 |
| openstackgerrit | Min Pae proposed stackforge/python-cueclient: Add .coveragerc to better control coverage outputs https://review.openstack.org/171289 | 21:05 |
| *** miqui has quit IRC | 21:11 | |
| *** abitha has quit IRC | 21:14 | |
| *** abitha has joined #openstack-cue | 21:20 | |
| sputnik13 | vipul just added the same coverage tempfile stuff to gitignore ^ | 21:30 |
| openstackgerrit | Merged stackforge/cue: adding coverage tempfiles to gitignore https://review.openstack.org/173518 | 21:36 |
| openstackgerrit | Steve Leon proposed stackforge/cue: Refactor tests https://review.openstack.org/173509 | 21:38 |
| openstackgerrit | Steve Leon proposed stackforge/cue: Refactor tests https://review.openstack.org/173509 | 21:40 |
| *** abitha has quit IRC | 22:06 | |
| *** abitha has joined #openstack-cue | 22:25 | |
| openstackgerrit | Abitha Palaniappan proposed stackforge/cue: Change network_id argument to list type https://review.openstack.org/169065 | 22:41 |
| sputnik13 | esmute: added a comment to https://review.openstack.org/#/c/173509/ | 23:25 |
| esmute | sputnik13: Ok. | 23:31 |
| openstackgerrit | Steve Leon proposed stackforge/cue: Refactor tests https://review.openstack.org/173509 | 23:37 |
| esmute | sputnik13 ^ :) | 23:37 |
| sputnik13 | esmute thx | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!