openstackgerrit | Li Liu proposed openstack/cyborg master: Added Glance Client for Image downloading https://review.openstack.org/609906 | 02:44 |
---|---|---|
*** zhipeng has joined #openstack-cyborg | 07:07 | |
*** helenafm has joined #openstack-cyborg | 07:20 | |
*** dims has quit IRC | 13:40 | |
*** munimeha1 has joined #openstack-cyborg | 13:48 | |
*** Sundar has joined #openstack-cyborg | 13:57 | |
*** wangzhh has joined #openstack-cyborg | 14:01 | |
*** Li_Liu has joined #openstack-cyborg | 14:01 | |
sum12 | meeting ? | 14:03 |
*** dims has joined #openstack-cyborg | 14:03 | |
Li_Liu | yup | 14:05 |
Li_Liu | let's wait for few more min | 14:05 |
Li_Liu | #startmeeting openstack-cyborg | 14:06 |
openstack | Meeting started Wed Oct 17 14:06:18 2018 UTC and is due to finish in 60 minutes. The chair is Li_Liu. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:06 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:06 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 14:06 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 14:06 |
Li_Liu | #topic Roll Call | 14:06 |
*** openstack changes topic to "Roll Call (Meeting topic: openstack-cyborg)" | 14:06 | |
Sundar | #info Sundar | 14:06 |
Li_Liu | #info Li_Liu | 14:06 |
wangzhh | #info wangzhh | 14:06 |
Li_Liu | Let's wait for shaohe | 14:07 |
Sundar | What is the agenda? | 14:08 |
Li_Liu | We will go over all the pending patches and tasks. and discuss the demo plan for the summit | 14:08 |
Sundar | I'd like to bring up the need to get reviews for: https://review.openstack.org/#/q/status:open+project:openstack/cyborg-specs | 14:08 |
*** xinran has joined #openstack-cyborg | 14:08 | |
Sundar | Next week is Stein-1 milestone | 14:09 |
Li_Liu | yes | 14:09 |
Li_Liu | we should get the pending one merged as much as we could | 14:09 |
Li_Liu | ok, let's get started first | 14:11 |
Li_Liu | #topic Pending patches | 14:11 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 14:11 | |
Li_Liu | https://review.openstack.org/#/q/status:open%20project:openstack/cyborg | 14:11 |
Sundar | May be we can start with wangzhh's patch on drivers | 14:11 |
Sundar | https://review.openstack.org/#/c/596691/ ? | 14:12 |
Li_Liu | Added Glance Client for Image downloading --- Please help review this so that we can merge. The summit demo needs this one | 14:12 |
wangzhh | Of course. My patch is based on ovo now. | 14:12 |
wangzhh | And Sundar, I have sent an email about your questions. Did u get it? | 14:13 |
Sundar | wangzhh: Sorry, don't remember seeing it. When was it sent? | 14:14 |
*** shaohe_feng has joined #openstack-cyborg | 14:14 | |
*** Li_Liu_ has joined #openstack-cyborg | 14:14 | |
Li_Liu_ | I am back | 14:15 |
shaohe_feng | #info shaohe_feng_ | 14:15 |
Li_Liu_ | did I miss anything? | 14:15 |
Li_Liu_ | Hi shaohe | 14:15 |
shaohe_feng | morning Li_Liu_ | 14:15 |
wangzhh | SundarMaybe this morning for you. | 14:15 |
xinran | #info xinran | 14:16 |
xinran | Hi all | 14:16 |
*** dims has quit IRC | 14:16 | |
Sundar | wangzhh: OK. I haven't got it yet. I see your new patch set and responses. Thanks. | 14:16 |
wangzhh | Hi, xinran shaohe. | 14:16 |
*** Li_Liu has quit IRC | 14:16 | |
*** shaohe_feng has quit IRC | 14:17 | |
*** Li_Liu has joined #openstack-cyborg | 14:18 | |
Li_Liu | back again.. | 14:18 |
Li_Liu | are we gonna merge Xinran's spec? | 14:18 |
Li_Liu | does it still depend on anything? | 14:18 |
Sundar | Li_Liu: Re. Glance client, I gave some reviews. Wondering why can't we just call Glance client directly? Do we need a wrapper? | 14:18 |
Sundar | Li_Liu: which spec? | 14:19 |
xinran | Li_Liu: | 14:19 |
Li_Liu | https://review.openstack.org/#/c/597991/ | 14:19 |
*** Li_Liu_ has quit IRC | 14:19 | |
*** dims has joined #openstack-cyborg | 14:19 | |
xinran | Li_Liu: I have discussed with Sundar offline, the current solution after PTG is different with this one. | 14:20 |
Li_Liu | Sundar, of course, but I just wanna do it similar to Nova --> created a wrapper API for it | 14:20 |
Li_Liu | xinran: any plan on updating it? | 14:20 |
Li_Liu | did I drop? | 14:22 |
Li_Liu | ah.. i am good :) | 14:22 |
xinran | Sundar has a new spec https://review.openstack.org/#/c/603955/ in nova community | 14:22 |
Li_Liu | xinran, so that one will replace yours right? | 14:22 |
*** shaohe_feng has joined #openstack-cyborg | 14:22 | |
shaohe_feng | hi wangzhh | 14:23 |
xinran | yes in the future | 14:23 |
wangzhh | Didn't get the review email about this patch... | 14:23 |
shaohe_feng | seems I miss something | 14:24 |
shaohe_feng | something wrong with my net. | 14:24 |
shaohe_feng | no any message on the screen for a long time. | 14:24 |
*** Li_Liu_ has joined #openstack-cyborg | 14:24 | |
Sundar | Thanks, Xinran. All, please review https://review.openstack.org/608624 . That is the proposed implementation (high-level design) of Cyborg APIs for Nova | 14:25 |
xinran | but you guys can use https://review.openstack.org/#/c/596187/ this API if it's urgent. It can works with nova, but of course need change code on nova side. | 14:25 |
*** Li_Liu__ has joined #openstack-cyborg | 14:26 | |
Li_Liu__ | Sundar, could you help me run the meeting for now... my connection is so bad | 14:26 |
Li_Liu__ | I am going through all the patches in https://review.openstack.org/#/q/status:open%20project:openstack/cyborg | 14:26 |
wangzhh | xinran: So this patch should be abandoned? https://review.openstack.org/#/c/597991/ | 14:26 |
*** shaohe_feng has quit IRC | 14:27 | |
Sundar | Li_Liu: Sure. NP. | 14:27 |
*** Li_Liu has quit IRC | 14:27 | |
Sundar | Xinran: On https://review.openstack.org/#/c/601150/, this patch tries to create RP trees from the agent, IIUC. It is better to do it from the conductor | 14:29 |
Sundar | for the reasons we have discussed in the past | 14:29 |
*** Li_Liu_ has quit IRC | 14:29 | |
Sundar | Also, it is desirable to have all db access from the conductor (and not from the agent) | 14:29 |
*** shaohe_feng has joined #openstack-cyborg | 14:29 | |
xinran | Hmmm, Sundar do you wanna continue work on this spec https://review.openstack.org/#/c/597991/ or you prefer to create a new one? | 14:29 |
Sundar | Xinran, I think this spec should be dropped -- that is a better use of your time and energy :) | 14:30 |
shaohe_feng | why dropped? | 14:31 |
Sundar | Shaohe: I already explained in the reviews. Basically, this is not in line with the Nova flow at all | 14:31 |
shaohe_feng | A patch is not perfect, every reviewers should give his comments and let the auther to improve it. | 14:32 |
shaohe_feng | that's the rule | 14:32 |
*** Li_Liu_ has joined #openstack-cyborg | 14:32 | |
Sundar | I gave my comments | 14:32 |
Sundar | Think about how this even relates to the Nova spec | 14:33 |
*** Li_Liu__ has quit IRC | 14:33 | |
shaohe_feng | so the summary of new cyborg design: | 14:34 |
shaohe_feng | 1. split the nova flavor to device profile | 14:34 |
shaohe_feng | 2. change the accelerator api to var api. | 14:34 |
xinran | Sundar: I can modify this spec according to your nova spec if you want once your spec is merged. | 14:34 |
shaohe_feng | right? | 14:35 |
xinran | Sundar: or you prefer to write a new one by yourself? | 14:35 |
Sundar | Xinran, Shaohe: we need to start with the Cyborg API signatures proposed for Nova, and work downwards into the details. That is what we do in https://review.openstack.org/#/c/608624/ | 14:36 |
*** openstackgerrit has quit IRC | 14:36 | |
*** Li_Liu_ has quit IRC | 14:36 | |
shaohe_feng | what is signatures? | 14:36 |
*** shaohe_feng has quit IRC | 14:37 | |
Sundar | Shaohe: API parameters, responses, HTTP return codes | 14:37 |
Sundar | Shahe: re. your question about 2 parts, the device profiles are an important part. So is the whole flow about creating VARs in an unbound state, then binding them, then attaching. | 14:38 |
*** Li_Liu_ has joined #openstack-cyborg | 14:40 | |
*** shaohe_feng has joined #openstack-cyborg | 14:40 | |
Sundar | Aso, the device model where we map deployables to RPs, as we discussed last week | 14:40 |
shaohe_feng | I do not care you name is var or accelerator. | 14:41 |
Sundar | A VAR is not an accelerator. | 14:41 |
shaohe_feng | but as user var is puzzle, like vport. | 14:41 |
Sundar | "var is puzzle" -- what does that mean? | 14:42 |
shaohe_feng | var is used for a choose a device to bind to a VM. | 14:42 |
Sundar | A VAR is a Virtual Accelerator Request. It abstracts the state of the request, starting from user requirements, moving on to the Nova's selection of an alloc cand with device RPs, and then Cyborg bindings | 14:43 |
shaohe_feng | any project, you seen they expose a var object to user? | 14:43 |
Sundar | This is conceptually different from what we had before the PTG | 14:43 |
shaohe_feng | vport, vvolume? | 14:44 |
Li_Liu_ | shaohe, are you more concern with the naming or the concept? | 14:44 |
shaohe_feng | the initial design, is Request a Accelerator to VM. | 14:44 |
shaohe_feng | but we does not name it virtual accelerator, we just named it accelerator | 14:45 |
shaohe_feng | no need to use virtual | 14:45 |
Sundar | Shaohe: is this about names, or concepts? | 14:45 |
shaohe_feng | no need to emphasize virtual | 14:46 |
shaohe_feng | you can discuss with Li_Liu_ about the accelerator history | 14:46 |
shaohe_feng | about the name | 14:46 |
Li_Liu_ | I think "virtual" word indeed confuses a bit | 14:46 |
wangzhh | Shaohe: Accelerator is not same as VAR. Maybe u confusion about them? | 14:47 |
*** shaohe_feng has quit IRC | 14:47 | |
Li_Liu_ | but I agree it's different from concept of accelerator | 14:47 |
Sundar | Neutron has something called a VIF -- virtual interface. The word 'virtual' is used in many contexts. I don't understand the issue. | 14:48 |
*** munimeha1 has quit IRC | 14:49 | |
Li_Liu_ | I guess when you put all of these virtual accelerator / accelerator request / virtual accelerator request together. that's where the confusion starts | 14:50 |
Li_Liu_ | Sundar, does nova needs to care if a accelerator is virtual or not? | 14:51 |
Sundar | Li_Liu: We have accelerators and we have VARs. Former is a resource represented in Placement. VAR, as you said, is different -- it is a request for an accelerator -- not known to Placement. There are only 2 things | 14:51 |
wangzhh | I think it's better to have a clear definition of VAR. In the doc, for other developer or users. | 14:52 |
wangzhh | Sundar: Agree. | 14:52 |
Sundar | Li_Liu: Accelerators are resource class inventories -- they are not physical hardware, even in the previous Rocky proposal | 14:52 |
Sundar | Li_Liu: AFAIK, we never used the term 'virtual accelerator' to refer to an accelerator. | 14:53 |
Li_Liu_ | I know, I think Cyborg maybe should hide physical/virtual accelerator concept from nova. | 14:54 |
*** shaohe_feng has joined #openstack-cyborg | 14:54 | |
Li_Liu_ | or can we rename it to Accelerator Virtual Request | 14:54 |
Li_Liu_ | as, according to you, the request is virtual but not the accelerator? | 14:55 |
shaohe_feng | accelerator is OK. | 14:55 |
shaohe_feng | and Request is verb | 14:55 |
Li_Liu_ | shaohe_feng, we do have accelerator, but sunder needs something different to work with placement | 14:56 |
Sundar | Li_Liu: yes, the request is virtual. If we just call it an Accelerator Request, say ARQ or something, are you ok with that? | 14:56 |
shaohe_feng | Request and be apply to a noun accelerator | 14:56 |
shaohe_feng | Request can be apply to a noun accelerator | 14:56 |
shaohe_feng | this is not conflict with RESTFUL style. | 14:57 |
Sundar | Li_Liu: "hide physical/virtual accelerator" Please note that the term 'accelerator' never refers to any physical entity :) | 14:57 |
Sundar | In Placement, an accelerator type is a resource class (e.g. CUSTOM_ACCELERATOR_FPGA). There are number of resources of one RC in a single RP | 14:58 |
Li_Liu_ | ARQ is kinda cool to me | 14:58 |
wangzhh | Sundar, could u explain the differences between Acc and VAR? I just know parts of them. I think shaohe is confused about them. | 14:58 |
Sundar | So, it is just a number that Placement is counting as RC inventory | 14:59 |
shaohe_feng | generally, for a REST, a resource belong to a collection, and the the resource can support different verb action | 14:59 |
Li_Liu_ | btw shaohe, Request cal also be a noun | 15:01 |
shaohe_feng | so request is a resource | 15:01 |
Sundar | wangzhh: OK. Placement has the notion of Resource providers (RPs) and Resource Classes (RC). We model each accelerator type as an RC. An accelerator is a unit of offload that can be assigned individually (to a VM, container, ...) | 15:01 |
shaohe_feng | bind is verb to this request resource | 15:01 |
Li_Liu_ | shaohe_feng, I think that's Sundar's idea, is it? Sundar | 15:02 |
shaohe_feng | OK, seldom see this rest style. | 15:03 |
Sundar | VARs are indeed resources in the REST API. We apply HTTP operations like GET, POST etc. to that resource. | 15:03 |
Sundar | Shaohe: have you reviewed the Nova spec? | 15:03 |
shaohe_feng | have a look at https://review.openstack.org/#/c/608624/2/specs/stein/approved/cyborg-api-wflows-for-instance-ops.rst | 15:04 |
wangzhh | Sundar, Yes. So is there any differences on data structure? | 15:04 |
shaohe_feng | any way, virtual Accelerator Requests is puzzle me. | 15:04 |
wangzhh | Between VAR and Acc. | 15:05 |
shaohe_feng | so VARs is a collection, and var is resource. | 15:05 |
shaohe_feng | VARs means multi requests. | 15:05 |
Sundar | wangzhh: Getting back to your question :) Yes, a VAR is an OVO that is stored in Cyborg db. An accelerator is not a data structure per se: it is the inventory of a resource provider maintained by Placement n its db | 15:05 |
shaohe_feng | var is one request | 15:05 |
shaohe_feng | right? | 15:06 |
shaohe_feng | and why we need var? just for consistency? | 15:07 |
Sundar | Yes, VAR is singular, VARs is plural. The Nova spec 603955 defines APIs on the collection VARs, so that we can do batch operations | 15:07 |
*** Li_Liu has joined #openstack-cyborg | 15:09 | |
*** Li_Liu_ has quit IRC | 15:09 | |
shaohe_feng | anyway, here you define the VAR is same to the accelerator concept in our initial design | 15:10 |
Sundar | No | 15:10 |
Sundar | Accelerator != VAR | 15:10 |
shaohe_feng | anyway, here you define the VAR is same to the accelerator concept in my initial design | 15:11 |
Sundar | The concept of accelerator as a RC existed from Rocky cycle | 15:11 |
wangzhh | So, when cyborg-agent started, It collects which one? I think It is acc. And VAR will be created when user want accs to attach? | 15:11 |
Sundar | VAR is new from Stein PTG | 15:11 |
shaohe_feng | and your Accelerator is same to the allocation unit in my initial design :) | 15:11 |
shaohe_feng | other's no different | 15:13 |
shaohe_feng | just name is different | 15:13 |
Sundar | wangzhh: Cyborg agent collects device (physical hardware) and accelerator info from the driver. Please see the driver report structure in https://docs.google.com/presentation/d/1Anud3Qbcb0P3G245HpHduHhslx1MJljGD6wqPDy7o9E/edit#slide=id.g44d3e3519f_4_134 | 15:13 |
shaohe_feng | OK, let go ahead for others. | 15:13 |
Sundar | I am 15 minutes into my next meeting, and it is a bit difficult to flip back and forth. I need to drop out now. | 15:15 |
Sundar | Shaohe: I am open to discussion at other times or meetings. | 15:15 |
shaohe_feng | Sundar: OK. we can also discuss it off line. | 15:15 |
shaohe_feng | Sundar: have a good day. bye. | 15:16 |
*** Li_Liu_ has joined #openstack-cyborg | 15:16 | |
*** Li_Liu has quit IRC | 15:18 | |
*** Li_Liu has joined #openstack-cyborg | 15:19 | |
Li_Liu | ping | 15:20 |
Li_Liu | you guys still there? | 15:20 |
Li_Liu | anyone? | 15:22 |
*** Li_Liu_ has quit IRC | 15:22 | |
*** Li_Liu has quit IRC | 15:25 | |
*** Li_Liu has joined #openstack-cyborg | 15:25 | |
Li_Liu | if no one is here, I will end the meeting for today | 15:26 |
Li_Liu | we can carry on the discussion offline | 15:26 |
Li_Liu | #endmeeting | 15:26 |
*** openstack changes topic to "A zuul config error slipped through and caused a pile of job failures with retry_limit - a fix is being applied and should be back up in a few minutes" | 15:26 | |
openstack | Meeting ended Wed Oct 17 15:26:25 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:26 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2018/openstack_cyborg.2018-10-17-14.06.html | 15:26 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2018/openstack_cyborg.2018-10-17-14.06.txt | 15:26 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2018/openstack_cyborg.2018-10-17-14.06.log.html | 15:26 |
*** Li_Liu has quit IRC | 15:27 | |
*** shaohe_feng has quit IRC | 15:29 | |
*** munimeha1 has joined #openstack-cyborg | 15:37 | |
*** card.freenode.net changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 15:37 | |
*** openstackgerrit has joined #openstack-cyborg | 15:47 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cyborg master: Add cyborg-status upgrade check command framework https://review.openstack.org/611368 | 15:47 |
openstackgerrit | Merged openstack/cyborg master: Added Glance Client for Image downloading https://review.openstack.org/609906 | 15:47 |
*** efried is now known as efried_pto | 16:09 | |
*** Sundar has quit IRC | 16:21 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cyborg master: Add cyborg-status upgrade check command framework https://review.openstack.org/611368 | 16:34 |
*** helenafm has quit IRC | 16:35 | |
*** persia has left #openstack-cyborg | 16:52 | |
*** wangzhh has quit IRC | 17:15 | |
*** xinran has quit IRC | 21:36 | |
*** munimeha1 has quit IRC | 22:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!