| *** Sundar has joined #openstack-cyborg | 00:29 | |
| Sundar | @all, There is a discussion about whether we should use asserts in https://review.opendev.org/#/c/626057/10/cyborg/accelerator/drivers/fpga/intel/driver.py | 00:44 |
|---|---|---|
| Sundar | First, raising an exception is appropriate f something is wrong with the user input or other subsystem's behavior, but asserts are good to catch internal program logic, invariants that should always ok, etc. Using asserts for these will prevent proliferation of exceptions. | 00:45 |
| Sundar | Second, there are many precedents for using exceptions. E.g. | 00:46 |
| Sundar | [1] https://github.com/openstack/nova/blob/master/nova/rpc.py#L97 | 00:46 |
| Sundar | [2] https://github.com/openstack/nova/blob/master/nova/virt/disk/mount/api.py#L187 | 00:46 |
| Sundar | [3] https://github.com/openstack/nova/blob/master/nova/objects/aggregate.py#L441 | 00:46 |
| *** wangzhh has joined #openstack-cyborg | 00:48 | |
| Sundar | @wangzhh I don't understand your response in https://review.opendev.org/#/c/659014/1/cyborg/tests/unit/db/utils.py Line 106 | 01:09 |
| Sundar | The other comment referred to using the lspci command. | 01:10 |
| *** Sundar has quit IRC | 01:14 | |
| wangzhh | For we use string as cpid_info, if we split it an convert to json, {"device": "2", "bus": "00", "function": "01"} is not enough. | 01:15 |
| wangzhh | It should looks like {"device": "2", "bus": "00", "function": "01", "domain": "0000"} | 01:15 |
| *** Coco_gao has joined #openstack-cyborg | 01:17 | |
| wangzhh | Am I clear? | 01:17 |
| wangzhh | The cpid_info looks like 0000:00:02.0. The json_str in this patch lost domain. | 01:19 |
| Coco_gao | yes, if cpid_info is a json string, what about the attach_info? | 01:20 |
| wangzhh | I think it is the same. | 01:22 |
| Coco_gao | And cpid_info is used to identify some of the devices, if its a json_str, then it will be hard to identify, because it' s hard to compare json_str. | 01:24 |
| Coco_gao | what do you think? | 01:25 |
| Coco_gao | @Sundar | 01:25 |
| wangzhh | Sundar said he'll BRB in 30 min. | 01:27 |
| Coco_gao | so will I | 01:31 |
| *** Sundar has joined #openstack-cyborg | 02:05 | |
| Sundar | @Coco_gao @wangzhh Yes, domain should be included. attach_id also should be fixed in the same way: I'll do that. All good? | 02:08 |
| Sundar | @Coco_gao: "if its a json_str, then it will be hard to identify, because it' s hard to compare json_str" Are you saying that we can store it as individual PCI BDF fields (domain, bus, etc.) in the db? That would not work for PowerVM, which represents PCI devices differently. | 02:12 |
| wangzhh | Fine. Sundar. | 02:14 |
| wangzhh | And do u install znc which xinran mentioned? I don't find windows version. | 02:16 |
| Sundar | wangzhh: znc is linux only | 02:17 |
| wangzhh | OK. Thx. | 02:18 |
| *** minmin has joined #openstack-cyborg | 02:23 | |
| Sundar | @yikun, @wangzhh, @Coco_gao and all, please respond to http://eavesdrop.openstack.org/irclogs/%23openstack-cyborg/%23openstack-cyborg.2019-05-31.log.html#t2019-05-31T00:45:51 | 02:43 |
| *** Sundar has quit IRC | 03:19 | |
| *** Coco_gao has quit IRC | 03:55 | |
| *** links has joined #openstack-cyborg | 04:14 | |
| *** Coco_gao has joined #openstack-cyborg | 05:50 | |
| wangzhh | @yikun Is generic driver ready? New GPU driver depends on it. Or u just responsible for spec, I'm not sure. | 07:29 |
| *** openstack has joined #openstack-cyborg | 12:29 | |
| *** ChanServ sets mode: +o openstack | 12:29 | |
| *** links has quit IRC | 13:04 | |
| *** openstackstatus has joined #openstack-cyborg | 14:30 | |
| *** ChanServ sets mode: +v openstackstatus | 14:30 | |
| -openstackstatus- NOTICE: The Gerrit service at https://review.opendev.org/ will be offline briefly for maintenance starting at 15:00 UTC (roughly 30 minutes from now); for details see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006684.html | 14:31 | |
| -openstackstatus- NOTICE: Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running. | 15:05 | |
| *** ChanServ changes topic to "Gerrit is now entering its maintenance window. Expect Gerrit outages in the near future. We will notify when it is back up and running." | 15:05 | |
| *** ChanServ changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 15:58 | |
| -openstackstatus- NOTICE: Gerrit is back up and running again. Thank you for your patience and sorry for the delay in this notification (we thought the statusbot was still busy updating channel topics). | 16:46 | |
| *** minmin has quit IRC | 18:28 | |
| *** minmin has joined #openstack-cyborg | 18:29 | |
| *** wangzhh has quit IRC | 18:58 | |
| *** openstackgerrit has quit IRC | 19:01 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!