*** s_shogo has joined #openstack-cyborg | 02:14 | |
*** tetsuro has quit IRC | 02:36 | |
*** Yumeng has joined #openstack-cyborg | 02:41 | |
*** chenke has joined #openstack-cyborg | 02:41 | |
*** tetsuro has joined #openstack-cyborg | 02:45 | |
*** xinranwang has joined #openstack-cyborg | 02:57 | |
*** Sundar has joined #openstack-cyborg | 02:58 | |
Sundar | #startmeeting openstack-cyborg | 03:01 |
---|---|---|
openstack | Meeting started Thu Oct 10 03:01:45 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:01 |
*** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:01 | |
openstack | The meeting name has been set to 'openstack_cyborg' | 03:01 |
Sundar | #topic Who's here | 03:01 |
*** openstack changes topic to "Who's here (Meeting topic: openstack-cyborg)" | 03:01 | |
chenke | \0 | 03:02 |
Yumeng | #info Yumeng | 03:02 |
chenke | #info chenke | 03:02 |
s_shogo | #info s_shogo | 03:02 |
xinranwang | #info xinranwang | 03:02 |
Sundar | Hi all, hope you had a good holiday last week. | 03:02 |
Sundar | #topic Status | 03:03 |
*** openstack changes topic to "Status (Meeting topic: openstack-cyborg)" | 03:03 | |
Sundar | Nothing much changed substantially last week. We got some doc patches into good shape. | 03:03 |
Sundar | Please see: https://review.opendev.org/686423, https://review.opendev.org/686518 | 03:04 |
Sundar | The async bind patch got merged. Whew, finally | 03:04 |
Sundar | 'Install OPAE tools': https://review.opendev.org/684456 <-- this is specific to one driver but please do review it. Maybe you can look at the structure and style | 03:06 |
Sundar | 'Remove useless glance api_servers define': https://review.opendev.org/685542 Unfortunately, I always see failures with this patch. I provided the logs and my cyborg.conf in that patch. | 03:07 |
Sundar | Plus some generic patches like https://review.opendev.org/670973. | 03:07 |
chenke | yes. This patch in analysis. | 03:07 |
Sundar | Do any of you have any comments or questions? | 03:08 |
chenke | I guess this error is because the previous issues. | 03:08 |
chenke | endpoint = utils.get_endpoint(ksa_adap) | 03:08 |
chenke | The actually error is pointing here: File "/opt/stack/cyborg/cyborg/image/glance.py", line 117, in get_api_servers\n endpoint = utils.get_endpoint(ksa_adap)\n', u' File "/opt/stack/cyborg/cyborg/common/utils.py", line 208, in get_endpoint\n "interfaces: %s" % interfaces)\n | 03:09 |
Sundar | chenke: Could you tell us what the previous issues are? | 03:10 |
chenke | This code has not been executed | 03:10 |
chenke | https://github.com/openstack/cyborg/blob/master/cyborg/image/glance.py#L116 | 03:11 |
chenke | Sundar pls see this if condition | 03:11 |
Sundar | Yes. So, the api_servers config seems necessary, right? | 03:11 |
chenke | no | 03:11 |
chenke | The api_servers hide the else condition. | 03:12 |
chenke | now when I delete this api_servers, the else condition raise error because "/opt/stack/cyborg/cyborg/common/utils.py", line 208, in get_endpoint" | 03:13 |
chenke | What I want to say is that this problem was hidden before. | 03:13 |
Sundar | Got it. So, the api_servers is mor elike a hack or workaround to hide the error in the 'else' clause | 03:14 |
chenke | Right. | 03:14 |
chenke | After our meeting, I will find why the get_endpoint raise error. | 03:15 |
Sundar | Then the questions are: A. Do we have time to find the issue in the get_endpoint()? B. Is it worth fixing -- may be we should go straight to openstacksdk in U? | 03:15 |
chenke | maybe we could use openstacksdk. | 03:16 |
chenke | need to have a try. I am not sure now. But eric suggest glance to use openstacksdk before. | 03:16 |
Sundar | Yes, I believe we tried that approach and gave up because of a bug there. The opestacksdk patch which was suggested as a fix has since been abandoned. | 03:17 |
Sundar | Anyway, I agree this is a U-release conversation. Perhaps we should get started soon so that we can shoot for a resolution in November, early in the U cycle | 03:18 |
chenke | agree. | 03:18 |
Sundar | Cool, thanks Chenke | 03:20 |
Sundar | All, please review the documentation patches. We need to close them for the next RC. | 03:21 |
Sundar | Also, like I said, please review: https://review.opendev.org/684456 | 03:21 |
Sundar | #topic PTG prep | 03:22 |
*** openstack changes topic to "PTG prep (Meeting topic: openstack-cyborg)" | 03:22 | |
Sundar | I will create an etherpad and share with you. Please indicate who among you plan to attend. | 03:23 |
xinranwang | next RC is this week or 18 Oct | 03:23 |
Sundar | xinranwang: The final RC is due this week. But I haven't seen a RC patch proposed yet. | 03:24 |
Sundar | 18 Oct is the release itself | 03:24 |
xinranwang | Sundar: Ok, I will review it by this week. | 03:25 |
Sundar | Yumeng: we need to work together for the project update. | 03:25 |
Yumeng | sundar: yes, I was about to ask. | 03:26 |
Yumeng | do you have any plans about the structure? | 03:26 |
Sundar | Just curious, who among you plan to attend the PTG (after the Summit)? | 03:26 |
Sundar | Yumeng: kind of. Can you access Google slides? | 03:27 |
xinranwang | I will attend Summit and PTG, and I am preparing a demo at Intel booth during the Summit which show qat use case in cyborg and performance improvement. | 03:27 |
*** shaohe_feng has joined #openstack-cyborg | 03:27 | |
shaohe_feng | hi all. | 03:27 |
shaohe_feng | sorry for late | 03:27 |
Sundar | Cool | 03:27 |
shaohe_feng | something wrong with my pc. | 03:28 |
Sundar | shaohe_feng: welcome, np | 03:28 |
chenke | hi shaohe. | 03:28 |
shaohe_feng | morning chenke | 03:29 |
Yumeng | Sundar: google doc not always available. It will be appreciate if u can send me the file directly! | 03:29 |
Sundar | DO any of you have specific ideas for U release? Such as new drivers, or improvements to Cyborg? (Apart from nova integ, which IMO is most important.) | 03:29 |
s_shogo | I'll attend the Summit and PTG (all day). | 03:29 |
Sundar | Yumeng: got it, will do | 03:29 |
Yumeng | I will attend Summit and PTG too | 03:29 |
Sundar | Great, s_shogo and Yumeng | 03:30 |
Sundar | Hope we'll get to meet chenke and zhurong too ;) | 03:30 |
xinranwang | Sundar: from Intel side, there are HDDL and QAT driver. We can do it in U release. | 03:30 |
chenke | I will attend Summit and PTG too. | 03:31 |
Sundar | Great | 03:31 |
shaohe_feng | Yes, HDDL and QAT | 03:31 |
Sundar | #topic AoB | 03:31 |
*** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 03:31 | |
Sundar | Anything else to bring up today? | 03:31 |
shaohe_feng | for FPGA, should we support alias for function_id? | 03:31 |
shaohe_feng | such as in DP: | 03:32 |
zhurong | Sundar hope to see you too | 03:32 |
Sundar | shaohe: Yes, that would be a good addition. After nova integ. | 03:32 |
xinranwang | Yes, as shaohe said. it remains many TODOs and improvement in Cyborg, we can discuss during PTG. | 03:32 |
Sundar | zhurong: Yes, I plan to be there | 03:32 |
Sundar | My first trip to China :) | 03:33 |
chenke | Sundar welcome to china. | 03:33 |
shaohe_feng | "accel:function_id": "123_456_789_333", this is not friendly to user. | 03:33 |
*** licanwei has joined #openstack-cyborg | 03:33 | |
shaohe_feng | Sundar welcome to china | 03:33 |
Sundar | Thanks | 03:34 |
xinranwang | welcome to China :) | 03:34 |
shaohe_feng | maybe "accel:function_alias": "SmartNic_V1" | 03:34 |
shaohe_feng | or other describe it. | 03:34 |
Sundar | Yes, let's brainstorm on the function_id stuff. Perhaps I should create an etherpad for that. | 03:35 |
xinranwang | Sundar: can you create a etherpad that we can add the idea on it. | 03:35 |
Sundar | Sure | 03:35 |
shaohe_feng | yes. | 03:35 |
shaohe_feng | a etherpad is good. | 03:35 |
Sundar | Cool. Anything else, folks? | 03:35 |
shaohe_feng | another things, now the async job is in API. | 03:35 |
xinranwang | And we can discuss them during the meeting | 03:35 |
shaohe_feng | we have issue, should be support async job in conductor or agent | 03:36 |
shaohe_feng | pros and cons? | 03:36 |
Sundar | IMHO it should be in the conductor | 03:36 |
shaohe_feng | OK, we can discuss and improve it. also put in etherpad | 03:37 |
Sundar | ok | 03:37 |
*** licanwei has quit IRC | 03:37 | |
Sundar | From the next meeting, we can start focusing more on the PTG. | 03:38 |
shaohe_feng | also another thing, a mini improve for factory. | 03:38 |
shaohe_feng | https://stackoverflow.com/questions/3464061/cast-base-class-to-derived-class-python-or-more-pythonic-way-of-extending-class | 03:38 |
shaohe_feng | ^ #info link | 03:39 |
Sundar | Details like this are probably better discussed as a patch proposal, rather than in etherpad, I think | 03:39 |
shaohe_feng | this is no in etherpad. | 03:39 |
shaohe_feng | just discuss it here | 03:39 |
shaohe_feng | mini performance improvement | 03:40 |
shaohe_feng | now when I found it is a FPGA ARQ, I create a FPGA ARQ | 03:40 |
shaohe_feng | that means I access a DB again. | 03:40 |
shaohe_feng | we can cast base ARQ to FPGA ARQ to avoid the DB access | 03:41 |
Sundar | shaohe_feng: Ok. Please feel free to propose a patch with your ideas. | 03:41 |
shaohe_feng | do you think is it worth to do it? | 03:42 |
shaohe_feng | ^ Sundar | 03:42 |
Sundar | shaohe_feng: Yes. Not terribly sure about the casting across parent and child classes, though. That can be tricky. | 03:42 |
Sundar | Trying to avoid an extra db access makes sense. | 03:43 |
shaohe_feng | just a mini performance improvement. and mini patch. | 03:43 |
shaohe_feng | you can see this example in the link | 03:43 |
shaohe_feng | https://stackoverflow.com/questions/3464061/cast-base-class-to-derived-class-python-or-more-pythonic-way-of-extending-class | 03:44 |
shaohe_feng | from math import pi | 03:44 |
shaohe_feng | print repr(c) | 03:44 |
shaohe_feng | only one line change: | 03:44 |
shaohe_feng | c.__class__ = CirclePlus | 03:44 |
Sundar | Perhaps it is better to focus on more basic stuff, heading into U. We really need to focus on nova integ. One consistent feedback i hear is that CYborg code and patches tend to lack UT | 03:44 |
Sundar | We completely lack functional testing with gabbi. These are not jazzy items but will help convince other developers and end users (operators) that we have good quality | 03:45 |
shaohe_feng | In cyborg: we just change one line the, arqobj.__class__ = FPAGExaARQ | 03:45 |
shaohe_feng | also, we should list a task for testcase in the etherpad | 03:46 |
shaohe_feng | too many testcase should be added | 03:46 |
shaohe_feng | it is a huge task | 03:46 |
shaohe_feng | Hopeful everyone can take some testcase task. | 03:47 |
Sundar | shaohe_feng: I like that. We should certainly spread the UT. | 03:48 |
Sundar | What do others think? Yumeng, chenke, zhurong, xinranwang | 03:48 |
Sundar | We can split it into API, objects and db layer. By specific APIs (like device profile create), specific objects (e.g. ARQs, device profiles) and specific features (cross-service connections, etc.) | 03:50 |
Yumeng | yes agree, it is urgent to improve UT and tempest case. | 03:51 |
Sundar | Cool. We can follow up in the etherpad. Anything else today? Will wait for 30 seconds ... | 03:52 |
chenke | nova integ and UT improve are the important things in U. | 03:52 |
Sundar | Agreed, along with the /v2/device,deployables API for listing inventory and programming | 03:53 |
Sundar | Thanks everybody. Have a good week! Bye. | 03:54 |
Sundar | #endmeeting | 03:54 |
*** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 03:54 | |
openstack | Meeting ended Thu Oct 10 03:54:43 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 03:54 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-10-10-03.01.html | 03:54 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-10-10-03.01.txt | 03:54 |
openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-10-10-03.01.log.html | 03:54 |
chenke | bye | 03:54 |
Yumeng | bye | 03:55 |
s_shogo | bye | 03:55 |
Sundar | Ah, forgot to mention another priority: Cyborg client. :) | 03:55 |
Sundar | Bye | 03:55 |
*** Sundar has quit IRC | 03:56 | |
s_shogo | Thanks, I'll continue the work for client and sdk in U release :) | 03:58 |
*** s_shogo has quit IRC | 03:58 | |
*** shaohe_feng has quit IRC | 05:01 | |
*** links has joined #openstack-cyborg | 05:47 | |
*** chenke has quit IRC | 06:19 | |
*** xinranwang has quit IRC | 07:07 | |
*** FlorianFa has quit IRC | 07:24 | |
*** Florian has joined #openstack-cyborg | 07:25 | |
*** Florian has quit IRC | 09:19 | |
*** FlorianFa has joined #openstack-cyborg | 09:19 | |
*** Yumeng has quit IRC | 10:19 | |
*** luyao has joined #openstack-cyborg | 11:07 | |
*** openstackgerrit has joined #openstack-cyborg | 12:59 | |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 1. https://review.opendev.org/687889 | 12:59 |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 2. https://review.opendev.org/687890 | 12:59 |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 3. https://review.opendev.org/687891 | 12:59 |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 1. https://review.opendev.org/687894 | 13:16 |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 2. https://review.opendev.org/687895 | 13:16 |
openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Update docs: Part 3. https://review.opendev.org/687896 | 13:16 |
*** TxGirlGeek has joined #openstack-cyborg | 14:14 | |
*** TxGirlGeek has quit IRC | 14:53 | |
*** TxGirlGeek has joined #openstack-cyborg | 15:18 | |
*** TxGirlGeek has quit IRC | 15:26 | |
*** TxGirlGeek has joined #openstack-cyborg | 15:30 | |
*** links has quit IRC | 16:01 | |
*** efried is now known as efried_pto | 18:16 | |
*** FlorianFa has quit IRC | 20:49 | |
*** FlorianFa has joined #openstack-cyborg | 21:01 | |
*** FlorianFa has quit IRC | 21:08 | |
*** FlorianFa has joined #openstack-cyborg | 21:21 | |
openstackgerrit | Merged openstack/cyborg master: Update master for stable/train https://review.opendev.org/685250 | 22:02 |
openstackgerrit | Merged openstack/cyborg master: Update driver section. https://review.opendev.org/686423 | 22:02 |
openstackgerrit | Merged openstack/cyborg master: API documentation update. https://review.opendev.org/686518 | 22:02 |
*** TxGirlGeek has quit IRC | 22:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!