| *** chenke has joined #openstack-cyborg | 02:47 | |
| *** wangzhh has joined #openstack-cyborg | 02:48 | |
| *** igordc has quit IRC | 02:54 | |
| *** Yumeng has joined #openstack-cyborg | 02:59 | |
| *** s_shogo has joined #openstack-cyborg | 03:02 | |
| chenke | Hi | 03:03 |
|---|---|---|
| chenke | seems many friends still doesn't arrive. | 03:04 |
| Li_Liu | Hi | 03:05 |
| Li_Liu | lol, ya | 03:05 |
| s_shogo | Hi | 03:05 |
| chenke | hi li shu and s_shogo. | 03:06 |
| Li_Liu | >_< | 03:06 |
| chenke | If you have free time, pls help review my patches. | 03:08 |
| *** Sundar has joined #openstack-cyborg | 03:10 | |
| Sundar | Hello | 03:10 |
| Sundar | #startmeeting openstack-cyborg | 03:10 |
| openstack | Meeting started Thu Dec 5 03:10:31 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 03:10 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 03:10 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 03:10 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 03:10 |
| Sundar | Sorry for joining late | 03:10 |
| Sundar | Anybody here? | 03:11 |
| chenke | #info chenke | 03:11 |
| chenke | hi sundar. | 03:11 |
| Li_Liu | #info Li_Liu | 03:11 |
| Yumeng | #info Yumeng | 03:11 |
| Li_Liu | Hi Sundar | 03:11 |
| Yumeng | Hi Li_Liu and Sundar | 03:11 |
| Sundar | Hi all | 03:11 |
| s_shogo | #info s_shogo | 03:12 |
| Sundar | Sorry, I haven't posted the agenda for today | 03:12 |
| Sundar | Could we start with functional testing, Li_Liu? | 03:12 |
| Li_Liu | ok, as I discussed last week | 03:13 |
| Li_Liu | https://etherpad.openstack.org/p/cyborg-ussuri-functional-test-plan | 03:13 |
| Li_Liu | the test plan is posted here. and prob needs more inputs | 03:13 |
| Li_Liu | it's welcome to provide comments and inputs in the etherpad | 03:13 |
| Sundar | Great. Are there any considerations to mock the db interface? | 03:14 |
| Li_Liu | I think we will need that | 03:14 |
| Li_Liu | Let me do some research for it | 03:15 |
| Sundar | Yea, cool | 03:15 |
| Li_Liu | I think we are doing similar mocking in unit tests | 03:15 |
| Sundar | Yea. The db mocking could be a fixture. | 03:16 |
| Sundar | Like https://review.opendev.org/gitweb?p=openstack/nova.git;f=nova/tests/fixtures.py;hb=refs/changes/35/673735/20#l2463 | 03:16 |
| Sundar | Is Shaohe here? | 03:17 |
| Sundar | Multinode is another important area. | 03:18 |
| Sundar | Hi s_shogo, I know the client patch is waiting for review. | 03:18 |
| *** shaohe_feng has joined #openstack-cyborg | 03:19 | |
| Sundar | Did you get any comments from outside Cyborg? | 03:19 |
| Sundar | On openstacksdk, etc.? | 03:19 |
| s_shogo | Hi Sundar, Thanks for your adding reviewers. | 03:19 |
| s_shogo | No comments,yet. | 03:20 |
| Sundar | Ok. Is it better to ask for outside reviews now, or after we add /v2/devices etc. in the client? | 03:21 |
| Sundar | s_shogo: ^ | 03:23 |
| s_shogo | IMO, adding of Device doesn't effect openstack sdk ,significantly. Thus, I would like to ask review now. | 03:24 |
| Sundar | Ok, I'll try to find somebody. | 03:24 |
| Sundar | Hi shaohe_feng | 03:24 |
| Sundar | Thanks for the patch on fake driver | 03:24 |
| s_shogo | Thank you Sundar ! I also try to send e-mail and notify someone, after that. | 03:24 |
| Sundar | Welcome, s_shogo | 03:25 |
| Sundar | shaohe_feng: What else do you need for the multinode? Are you getting reviews for the config table? | 03:26 |
| Sundar | Not sure if he is here -- I saw his join message. | 03:28 |
| chenke | s_shogo I have put some comments in your client patch. | 03:28 |
| s_shogo | Thank you cheke ! I'll check it. | 03:29 |
| Sundar | chenke: Do you mean https://review.opendev.org/681391 ? | 03:29 |
| chenke | Ye. | 03:29 |
| s_shogo | s/cheke/chenke/ | 03:30 |
| Sundar | Cool. chenke, what is the next step for https://review.opendev.org/#/c/691549/ ? | 03:30 |
| chenke | his job should be done in Phase-2: milestone-1 -> milestone-2 | 03:31 |
| Sundar | Ah I see. Sure. | 03:31 |
| chenke | ok. | 03:32 |
| Sundar | Next week, we should go through Storyboard, cyborg client patches and tempest plugin patches. We don't look much at those. | 03:32 |
| Sundar | Anything else for today? | 03:32 |
| chenke | seems lot of cyborg patch need to be review. | 03:34 |
| Sundar | Yea. I've been focusing on the Nova patches, because we have the reviewer attention now and will lose it in week, as people head for holidays. | 03:34 |
| Sundar | *in 1 week | 03:34 |
| chenke | oh. that should be high priority. | 03:35 |
| Sundar | Please review the patches we have, and I'll catch up in the last 2 weeks of Dec | 03:35 |
| chenke | will do it. | 03:36 |
| Sundar | Thanks. Anything else for today? | 03:36 |
| Yumeng | About RBAC policy. | 03:36 |
| Yumeng | I've read most of the materials provided on this page: https://wiki.openstack.org/wiki/Consistent_and_Secure_Default_Policies_Popup_Team | 03:36 |
| shaohe_feng | Sundar config table is create by me | 03:36 |
| Yumeng | We need to reassess each operation and associate which scope, or scopes, are appropriate. Mybe just like this: https://wiki.openstack.org/wiki/Barbican/Policy | 03:36 |
| shaohe_feng | I need all of you review it | 03:37 |
| Yumeng | then it will need all your comments. | 03:37 |
| Sundar | Yumeng: Sounds good. Would you be creating that wiki? Do you need any help? | 03:38 |
| *** chenke has quit IRC | 03:38 | |
| Yumeng | yep. wiki is good. I will do that. | 03:38 |
| Yumeng | I will try first. | 03:38 |
| Sundar | Great. I'll add this to the agenda for next week. | 03:38 |
| shaohe_feng | now any others have comment on the config table? | 03:39 |
| shaohe_feng | Any suggestion on how to improve the program enable on agent? | 03:41 |
| Sundar | shaohe_feng: Please post the etherpad link again here, to ask for review | 03:42 |
| shaohe_feng | #linkinfo https://etherpad.openstack.org/p/cyborg-ptg-ussuri | 03:44 |
| Sundar | shaohe_feng and all, let's wait 1 more week for review. We'll take that as as the final table. Ok? | 03:45 |
| shaohe_feng | OK | 03:45 |
| shaohe_feng | so let's focus on agent program | 03:46 |
| shaohe_feng | any comments? | 03:46 |
| Sundar | You mean the patch? | 03:46 |
| Sundar | If so, we should get the comments there | 03:47 |
| shaohe_feng | Sundar s_shogo yikun, Yumeng, wangzhh, chenke | 03:47 |
| shaohe_feng | yes, we have discussed them yesterday. | 03:47 |
| shaohe_feng | on wechat | 03:47 |
| shaohe_feng | no agent just support fpga program | 03:48 |
| shaohe_feng | how should agent support fake driver program? | 03:48 |
| Sundar | BTW, in terms of holiday planning, we should probably cancel the meetings on Dec 25/26 and Jan 1/2. Probably keep the meeting on Dec 18/19? | 03:48 |
| shaohe_feng | OK. | 03:50 |
| Sundar | s_shogo Yumeng chenke Li_Liu: ^ | 03:51 |
| s_shogo | NP > schedule | 03:51 |
| shaohe_feng | let's load all drivers in agant manager init? | 03:51 |
| shaohe_feng | if it is configure in setup.cfg | 03:51 |
| Sundar | shaohe_feng: Are we not doing that today? | 03:52 |
| shaohe_feng | and choose the right one | 03:52 |
| shaohe_feng | yes, I have paste a picture in wechat | 03:52 |
| shaohe_feng | for program we just support fpga | 03:52 |
| shaohe_feng | let me show you the code. | 03:53 |
| Sundar | shaohe_feng: agent manager init calls into resource tracker and loads drivers: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/resource_tracker.py#L47 | 03:53 |
| shaohe_feng | no this code | 03:53 |
| Sundar | We call program API only on fpga driver today | 03:54 |
| Sundar | We should expand that to fake driver also | 03:54 |
| shaohe_feng | you show the resource tracker code | 03:54 |
| shaohe_feng | https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L41 | 03:55 |
| Sundar | shaohe_feng: We get the driver name in fpga_program_v2 API: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L64 | 03:55 |
| shaohe_feng | here we init the self.fpga_driver | 03:56 |
| Sundar | We can use that to call the right driver. No need to hardcode self.fpga_driver. | 03:56 |
| shaohe_feng | https://opendev.org/openstack/cyborg/src/branch/master/cyborg/agent/manager.py#L70 | 03:56 |
| shaohe_feng | so here we just let fpga do program | 03:56 |
| Sundar | shaohe_feng: ^ | 03:57 |
| shaohe_feng | OK, let's cancel the self.fpga_driver init | 03:57 |
| shaohe_feng | add self.drivers in AgentManager | 03:57 |
| shaohe_feng | all drivers if implement program method | 03:58 |
| shaohe_feng | let's do it. | 03:58 |
| shaohe_feng | no matter it is fpga | 03:58 |
| Sundar | We already have the list of drivers in self._rt.acc_drivers | 03:59 |
| Sundar | The program_v2 shold check if the driver implements the program() API and then call it. | 03:59 |
| Sundar | Do others have any thoughts, comments, objections, .... ? | 04:00 |
| Sundar | OK, let's review it in patch changes. | 04:01 |
| Sundar | Anything else, folks? | 04:01 |
| Sundar | #topic AoB | 04:02 |
| *** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 04:02 | |
| Sundar | If nothing else, we can call it a day. | 04:02 |
| Sundar | Tanks, everybody. Have a good day! | 04:03 |
| Sundar | *Thanks | 04:03 |
| Sundar | #endmeeting | 04:03 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 04:03 | |
| openstack | Meeting ended Thu Dec 5 04:03:29 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 04:03 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.html | 04:03 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.txt | 04:03 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-12-05-03.10.log.html | 04:03 |
| *** shaohe_feng has quit IRC | 04:03 | |
| *** tetsuro_ has quit IRC | 04:06 | |
| *** tetsuro has joined #openstack-cyborg | 04:06 | |
| *** shaohe_feng has joined #openstack-cyborg | 04:13 | |
| shaohe_feng | sorry something wrong with irc | 04:13 |
| shaohe_feng | Sundar are here? | 04:13 |
| shaohe_feng | so everyone agree all the drivers can support program? | 04:14 |
| shaohe_feng | right? | 04:14 |
| Sundar | shaohe_feng: I am fine with that. As I said, program_v2 should check if the driver implements the program() API and then call it. That way, it can be generic and Pythonic | 04:20 |
| shaohe_feng | Add an abstract class for all acc drivers? | 04:22 |
| shaohe_feng | it just define the interfaces? | 04:22 |
| shaohe_feng | Sundar | 04:22 |
| Sundar | shaohe_feng: The generic driver is the ABC for drivers today | 04:23 |
| shaohe_feng | Sundar but you can seeļ¼ not every drivers inherit it. | 04:25 |
| shaohe_feng | https://opendev.org/openstack/cyborg/src/branch/master/cyborg/accelerator/drivers/gpu/base.py#L29 | 04:26 |
| shaohe_feng | here is the example? | 04:26 |
| *** s_shogo has quit IRC | 04:48 | |
| *** Sundar has quit IRC | 04:55 | |
| *** links has joined #openstack-cyborg | 05:23 | |
| openstackgerrit | zhurong proposed openstack/cyborg master: Add 5 placeholder db migration scripts for Train https://review.opendev.org/697031 | 05:54 |
| *** Yumeng has quit IRC | 06:04 | |
| *** wangzhh has quit IRC | 06:08 | |
| openstackgerrit | Xinran WANG proposed openstack/cyborg-specs master: Re-propose specification for Cyborg APIs Version 2 https://review.opendev.org/695840 | 07:21 |
| openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add cyborg quickstart reference in devstack https://review.opendev.org/697419 | 07:51 |
| *** yikun has quit IRC | 08:21 | |
| *** shaohe_feng has quit IRC | 09:54 | |
| *** donnyd has quit IRC | 09:54 | |
| *** Li_Liu has quit IRC | 09:54 | |
| *** masayukig has quit IRC | 09:54 | |
| *** openstackgerrit has quit IRC | 09:54 | |
| *** ildikov has quit IRC | 09:54 | |
| *** links has quit IRC | 09:54 | |
| *** tetsuro has quit IRC | 09:54 | |
| *** irclogbot_0 has quit IRC | 09:55 | |
| *** efried has quit IRC | 09:55 | |
| *** stephenfin has quit IRC | 09:55 | |
| *** persia has quit IRC | 09:55 | |
| *** gmann has quit IRC | 09:55 | |
| *** dustinc has quit IRC | 09:55 | |
| *** luyao has quit IRC | 09:55 | |
| *** ChanServ has quit IRC | 09:55 | |
| *** masayukig has joined #openstack-cyborg | 10:04 | |
| *** Li_Liu has joined #openstack-cyborg | 10:04 | |
| *** donnyd has joined #openstack-cyborg | 10:04 | |
| *** openstackgerrit has joined #openstack-cyborg | 10:04 | |
| *** links has joined #openstack-cyborg | 10:04 | |
| *** tetsuro has joined #openstack-cyborg | 10:04 | |
| *** persia has joined #openstack-cyborg | 10:04 | |
| *** luyao has joined #openstack-cyborg | 10:04 | |
| *** irclogbot_0 has joined #openstack-cyborg | 10:04 | |
| *** efried has joined #openstack-cyborg | 10:04 | |
| *** stephenfin has joined #openstack-cyborg | 10:04 | |
| *** gmann has joined #openstack-cyborg | 10:04 | |
| *** dustinc has joined #openstack-cyborg | 10:04 | |
| *** ChanServ has joined #openstack-cyborg | 10:04 | |
| *** orwell.freenode.net sets mode: +o ChanServ | 10:04 | |
| *** shaohe_feng has joined #openstack-cyborg | 10:04 | |
| *** ildikov has joined #openstack-cyborg | 10:04 | |
| *** shaohe_feng has quit IRC | 11:35 | |
| *** chenke has joined #openstack-cyborg | 11:36 | |
| *** chenke has left #openstack-cyborg | 11:36 | |
| *** chenke has joined #openstack-cyborg | 11:37 | |
| *** chenke has quit IRC | 11:52 | |
| *** jraju__ has joined #openstack-cyborg | 11:53 | |
| *** links has quit IRC | 11:53 | |
| *** jraju__ has quit IRC | 15:08 | |
| *** igordc has joined #openstack-cyborg | 16:27 | |
| *** openstackgerrit has quit IRC | 16:42 | |
| *** igordc has quit IRC | 20:05 | |
| *** persia has quit IRC | 21:43 | |
| *** persia has joined #openstack-cyborg | 21:45 | |
| *** stephenfin has quit IRC | 21:50 | |
| *** stephenfin has joined #openstack-cyborg | 21:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!