| *** chenke has joined #openstack-cyborg | 01:58 | |
| *** swp20 has joined #openstack-cyborg | 01:59 | |
| *** xinranwang has joined #openstack-cyborg | 02:01 | |
| xinranwang | Hi all | 02:02 |
|---|---|---|
| swp20 | hi all | 02:03 |
| xinranwang | hi swp20 | 02:03 |
| chenke | hi all | 02:04 |
| swp20 | hi xinranwang chenke | 02:04 |
| xinranwang | hi chenke | 02:05 |
| xinranwang | is brinzhang_ around? | 02:05 |
| brinzhang_ | \o ^^ | 02:05 |
| brinzhang_ | hi all | 02:05 |
| xinranwang | hi brinzhang_ | 02:06 |
| *** brinzhang_ is now known as brinzhang | 02:06 | |
| xinranwang | cool, let's start the meeting | 02:06 |
| xinranwang | #startmeeting openstack-cyborg | 02:06 |
| openstack | Meeting started Thu Apr 8 02:06:26 2021 UTC and is due to finish in 60 minutes. The chair is xinranwang. Information about MeetBot at http://wiki.debian.org/MeetBot. | 02:06 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 02:06 |
| *** openstack changes topic to " (Meeting topic: openstack-cyborg)" | 02:06 | |
| openstack | The meeting name has been set to 'openstack_cyborg' | 02:06 |
| xinranwang | #topic roll call | 02:06 |
| *** openstack changes topic to "roll call (Meeting topic: openstack-cyborg)" | 02:06 | |
| xinranwang | #info xinranwang | 02:06 |
| brinzhang | #info brinzhang | 02:07 |
| xinranwang | I'd like to discuss with you about vgpu status | 02:07 |
| xinranwang | #topic vgpu status | 02:07 |
| *** openstack changes topic to "vgpu status (Meeting topic: openstack-cyborg)" | 02:07 | |
| xinranwang | do we have a spec for vgpu support? | 02:07 |
| swp20 | # info swp20 | 02:08 |
| brinzhang | xinranwang: yeah, I would like to ask swp20 re-propose the vgpu spec | 02:08 |
| swp20 | xinranwang: i have reproposed the vgpu support | 02:08 |
| xinranwang | cool, please add me as the reviewer | 02:09 |
| swp20 | https://review.opendev.org/c/openstack/cyborg-specs/+/783785 | 02:09 |
| brinzhang | https://review.opendev.org/q/topic:%22bp%252Fcyborg-vgpu-support%22+(status:open%20OR%20status:merged) | 02:09 |
| swp20 | done | 02:09 |
| xinranwang | do we need a spec for nova? | 02:09 |
| swp20 | yeah | 02:10 |
| brinzhang | and there are some details need to be cleayly in old spec, you can review and +1 for it if it's ok | 02:10 |
| swp20 | i see someone have moved the spec to xena, we need to modify some nits. | 02:10 |
| xinranwang | please add me as the reviewer in nova spec as well, thanks | 02:11 |
| openstackgerrit | Merged openstack/cyborg master: Add backup and snapshot support matrix https://review.opendev.org/c/openstack/cyborg/+/785086 | 02:11 |
| brinzhang | swp20: why we need to move the specs/xena/approved/support-vGPU-nova-cyborg-interaction.rst to xena? | 02:12 |
| brinzhang | in the fix mirror things patch? | 02:12 |
| swp20 | ack xinranwang | 02:12 |
| brinzhang | spw20: you should move specs/xena/approved/support-vGPU-nova-cyborg-interaction.rst from this commit, and submit a new commit to re-propose it | 02:14 |
| swp20 | brinzhang: i donnot know, i need to find the commit. | 02:14 |
| brinzhang | so please split them | 02:15 |
| brinzhang | and make them clear | 02:15 |
| xinranwang | I didn't follow you, why we need move the spec location? | 02:15 |
| swp20 | https://review.opendev.org/c/openstack/nova-specs/+/784369 | 02:16 |
| brinzhang | xinranwang: no, we dont move it, just need to re-propose it in xena(move it to xena dir) and keep the old one in wallay/approved dir | 02:17 |
| xinranwang | ok got it | 02:17 |
| xinranwang | do we already re propose the spec in nova? | 02:17 |
| brinzhang | in https://review.opendev.org/c/openstack/nova-specs/+/780443 patch, we just need to modify the inconsistent content | 02:17 |
| swp20 | i think sean make a mistake. | 02:17 |
| swp20 | i have reproposed: https://review.opendev.org/c/openstack/nova-specs/+/780452 | 02:18 |
| openstackgerrit | chenker proposed openstack/cyborg master: Fix wrong usage about set which introduced during nova-cyborg interaction https://review.opendev.org/c/openstack/cyborg/+/784021 | 02:19 |
| xinranwang | ok, so we need fix nits in w spec, and continue call for review for the xena's one | 02:19 |
| brinzhang | swp20: sean didnot update your patch, just renamed it | 02:20 |
| brinzhang | you can rebase to master | 02:20 |
| swp20 | xinranwang: i will fix nits in x spec. | 02:21 |
| swp20 | brinzhang: ok | 02:21 |
| xinranwang | swp20: ok, got it. | 02:21 |
| xinranwang | we need call for nova guys to review it, if there's some opens cannot be nailed down and need more discussion, we'd better start it early before ptg. | 02:24 |
| swp20 | ack. | 02:24 |
| brinzhang | agree, but dont worry | 02:25 |
| xinranwang | ok | 02:27 |
| xinranwang | #topic AoB | 02:27 |
| *** openstack changes topic to "AoB (Meeting topic: openstack-cyborg)" | 02:27 | |
| xinranwang | the smartnic spec in reproposed in nova, please review it if you got time. thansk | 02:28 |
| brinzhang | ack | 02:28 |
| xinranwang | https://review.opendev.org/q/topic:%22bp%252Fsriov-smartnic-support%22+(status:open%20OR%20status:merged) | 02:28 |
| swp20 | cool | 02:29 |
| xinranwang | also the implementation | 02:29 |
| xinranwang | :0 | 02:29 |
| xinranwang | do you have other things be bring up here? | 02:29 |
| brinzhang | we fixed the device profile's api excetption and revert the removed temest case https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/785142 | 02:29 |
| brinzhang | the backport patch to stable/victoria to check the pep8 https://review.opendev.org/c/openstack/cyborg/+/785318 | 02:30 |
| brinzhang | there patches need to review and allow them go, I think | 02:30 |
| xinranwang | ok, you plan to revert it after the dependency land, right? | 02:30 |
| brinzhang | there is no dependency with these patches | 02:31 |
| swp20 | good works. | 02:31 |
| brinzhang | the releted patch has already fixed, see bug 1922183 | 02:31 |
| openstack | bug 1922183 in Cyborg (OpenStack) wabllaby "tempest failed with test_get_and_delete_device_profile" [Undecided,New] https://launchpad.net/bugs/1922183 | 02:31 |
| xinranwang | this is already the roll back patch, right? | 02:32 |
| brinzhang | xinranwang: do we need to switch to use launchpad now? there is no related with the commit and the bug now | 02:32 |
| brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784207 | 02:32 |
| brinzhang | xinranwang: yes, you can see the fixed patch here https://review.opendev.org/q/topic:%22bug%252F1922183%22+(status:open%20OR%20status:merged) | 02:33 |
| xinranwang | ok, cool | 02:33 |
| xinranwang | i have no objection to switch to laundpad | 02:34 |
| brinzhang | we just need to backport that fix until wallaby, it's enough | 02:34 |
| brinzhang | ok, let's review and merge the switch patch, ok? | 02:34 |
| swp20 | yes, the tempest test case is introduced from wallaby. | 02:35 |
| openstackgerrit | Brin Zhang proposed openstack/cyborg master: Switch using Launchpad instead of Storyboard https://review.opendev.org/c/openstack/cyborg/+/784207 | 02:35 |
| brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784207 | 02:35 |
| xinranwang | ok, cool | 02:36 |
| brinzhang | xinranwang, swp20: thanks | 02:36 |
| swp20 | cool | 02:36 |
| xinranwang | and please review chenke's patch https://review.opendev.org/c/openstack/cyborg/+/784021 | 02:36 |
| xinranwang | any other things? | 02:37 |
| chenke | i will review the switch launchpad story | 02:38 |
| brinzhang | I left commit, this is need to re wrods the commit title, it looks blurry | 02:38 |
| xinranwang | I think he has resubmit another one | 02:38 |
| brinzhang | I mean chenke's patch | 02:38 |
| chenke | brinzhang xinranwang already update. | 02:38 |
| chenke | that's sundar's patch Leftover problems. | 02:39 |
| brinzhang | chenke: I think we just to say "using List instead of xxx ", how about? | 02:39 |
| brinzhang | chenke: yeah, I just want to know what was happened when I see the commit tittle | 02:39 |
| openstackgerrit | Merged openstack/cyborg-tempest-plugin master: Add device profiles test case for device_profile APIs https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/785142 | 02:39 |
| chenke | brinzhang. Agree your idea. What do you think the new title? | 02:40 |
| swp20 | 'set' object is not subscriptable | 02:41 |
| swp20 | i test in py3 env | 02:42 |
| xinranwang | uncompatibility of data type? | 02:42 |
| chenke | swp20 yes. | 02:42 |
| chenke | maybe sundar didn't test this else switch. actually this is a very python problem. | 02:42 |
| brinzhang | Using List to avoid uncompatibility data type | 02:42 |
| brinzhang | How do you think? | 02:43 |
| xinranwang | Using List to avoid incompatible data type | 02:43 |
| swp20 | we can use pop | 02:43 |
| brinzhang | nice | 02:44 |
| brinzhang | Agree swp20 | 02:45 |
| chenke | OK | 02:45 |
| brinzhang | may we will reduce one data change | 02:45 |
| chenke | Using List to avoid incompatible data type | 02:45 |
| xinranwang | ok, cool | 02:45 |
| brinzhang | xinranwang, chenke: what do you think swp20's advice? | 02:46 |
| brinzhang | "we can use pop" | 02:46 |
| xinranwang | good advice | 02:47 |
| xinranwang | +1 for that | 02:47 |
| xinranwang | since the length is 1 | 02:47 |
| chenke | msg = msg % {'code': list(event_codes)[0], | 02:47 |
| chenke | 'inst': events[0]["server_uuid"]} | 02:47 |
| chenke | pop will change the data. I think just list transfer it is enough. | 02:48 |
| brinzhang | yes, using pop we will have a better efficiency than list | 02:48 |
| xinranwang | if the var"event_codes" is not used somewhere after, we can use pop | 02:49 |
| brinzhang | xinranwang: yes | 02:49 |
| xinranwang | otherwise we'd better keep it no changable | 02:49 |
| brinzhang | https://review.opendev.org/c/openstack/cyborg/+/784021 | 02:49 |
| brinzhang | after enent_codes, there is not used somewhere, we directly raised and end of the interface | 02:50 |
| chenke | yes. | 02:50 |
| brinzhang | so, let's use pop instead of list, is it ok? chenke | 02:52 |
| xinranwang | what do you think chenke | 02:52 |
| chenke | ye | 02:52 |
| openstackgerrit | chenker proposed openstack/cyborg master: Using pop method to avoid incompatible data type https://review.opendev.org/c/openstack/cyborg/+/784021 | 02:52 |
| chenke | please see the update patch | 02:52 |
| brinzhang | cool, I have nothing else | 02:52 |
| xinranwang | cool | 02:52 |
| xinranwang | thanks for the quick update | 02:53 |
| xinranwang | anything else? | 02:53 |
| swp20 | cool | 02:53 |
| swp20 | nothing from myside | 02:53 |
| chenke | haha | 02:53 |
| chenke | me too. | 02:53 |
| xinranwang | if nothing else, let's wrap up the meeting | 02:53 |
| xinranwang | #endmeeting | 02:54 |
| *** openstack changes topic to "Pending patches (Meeting topic: openstack-cyborg)" | 02:54 | |
| openstack | Meeting ended Thu Apr 8 02:54:20 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 02:54 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.html | 02:54 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.txt | 02:54 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2021/openstack_cyborg.2021-04-08-02.06.log.html | 02:54 |
| xinranwang | thanks guys | 02:54 |
| xinranwang | have a good day! | 02:54 |
| swp20 | bye | 02:56 |
| chenke | bye guys. | 02:57 |
| *** chenke has quit IRC | 03:14 | |
| *** xinranwang has quit IRC | 05:31 | |
| openstackgerrit | Merged openstack/cyborg master: Using pop method to avoid incompatible data type https://review.opendev.org/c/openstack/cyborg/+/784021 | 07:11 |
| openstackgerrit | Merged openstack/cyborg master: Switch using Launchpad instead of Storyboard https://review.opendev.org/c/openstack/cyborg/+/784207 | 07:11 |
| openstackgerrit | Brin Zhang proposed openstack/cyborg master: Remove personal name in the docs https://review.opendev.org/c/openstack/cyborg/+/785314 | 07:12 |
| openstackgerrit | Brin Zhang proposed openstack/cyborg master: Remove personal name in the docs https://review.opendev.org/c/openstack/cyborg/+/785314 | 07:17 |
| openstackgerrit | Wenping Song proposed openstack/cyborg master: Remove TODO tag https://review.opendev.org/c/openstack/cyborg/+/785315 | 07:35 |
| *** brinzhang has quit IRC | 07:35 | |
| *** brinzhang has joined #openstack-cyborg | 07:35 | |
| openstackgerrit | Wenping Song proposed openstack/cyborg master: Add ut for nova returns HTTP 207 with event code other than 422 https://review.opendev.org/c/openstack/cyborg/+/785336 | 08:05 |
| openstackgerrit | Wenping Song proposed openstack/cyborg master: Add ut for placement API https://review.opendev.org/c/openstack/cyborg/+/785340 | 08:22 |
| *** brinzhang_ has joined #openstack-cyborg | 18:21 | |
| *** brinzhang has quit IRC | 18:24 | |
| *** swp20 has quit IRC | 18:24 | |
| *** Underknowledge1 has joined #openstack-cyborg | 20:22 | |
| *** Underknowledge has quit IRC | 20:26 | |
| *** Underknowledge1 is now known as Underknowledge | 20:27 | |
| *** Underknowledge has quit IRC | 22:13 | |
| *** Underknowledge2 has joined #openstack-cyborg | 22:13 | |
| *** Underknowledge2 is now known as Underknowledge | 22:14 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!