| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup documentation for Cyborg development https://review.opendev.org/c/openstack/cyborg/+/983964 | 06:51 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup documentation for Cyborg development https://review.opendev.org/c/openstack/cyborg/+/983964 | 06:52 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add Cyborg NVMe driver development environment documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 06:52 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add Cyborg NVMe driver development environment documentation https://review.opendev.org/c/openstack/cyborg/+/982711 | 08:15 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add user guide for creating instances with accelerators https://review.opendev.org/c/openstack/cyborg/+/983027 | 08:17 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add doc around cyborg tempest test and grenade testing https://review.opendev.org/c/openstack/cyborg/+/983030 | 08:17 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add doc around cyborg tempest test and grenade testing https://review.opendev.org/c/openstack/cyborg/+/983030 | 08:21 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add VM setup documentation for Cyborg development https://review.opendev.org/c/openstack/cyborg/+/983964 | 10:03 |
| chandankumar | Cyborg IRC meeting in another 2 hours. Feel free to add your agenda here: https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L45 thank you! | 12:01 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci: Fix missing OWNER_CYBORG trait in PCI devices https://review.opendev.org/c/openstack/cyborg/+/986536 | 13:46 |
| chandankumar | Hello all, who all are around for meeting | 14:03 |
| chandankumar | #startmeeting cyborg | 14:03 |
| opendevmeet | Meeting started Tue Apr 28 14:03:47 2026 UTC and is due to finish in 60 minutes. The chair is chandankumar. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:03 |
| opendevmeet | The meeting name has been set to 'cyborg' | 14:03 |
| chandankumar | o/ | 14:03 |
| sean-k-mooney | o/ | 14:03 |
| jgilaber | o/ | 14:04 |
| morenod | o/ | 14:04 |
| chandankumar | #courtesy ping bogdando[m] rlandy amoralej | 14:04 |
| amoralej | o/ | 14:04 |
| chandankumar | In the mean time, feel free to add your agenda https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L45 | 14:04 |
| chandankumar | Let me get started with the first topic | 14:05 |
| chandankumar | #topic 2026.2 hibiscus ptg summary | 14:05 |
| chandankumar | I have added this topic | 14:05 |
| chandankumar | Thank you sean-k-mooney for sending the ptg summary to mailing list | 14:06 |
| chandankumar | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/MBE5DX4IQTD4SQOTSWNTDBBHTN5BSCPE/ | 14:06 |
| sean-k-mooney | if there are any corrections please respond or let me know | 14:06 |
| rlandy | o/ | 14:07 |
| jgilaber | I looked at the email this morning, everything looked right to me | 14:07 |
| chandankumar | sure, will do that. | 14:08 |
| chandankumar | If there is no question on above topic, let me move to the next section as there is no other topic | 14:08 |
| chandankumar | #topic reviews | 14:08 |
| chandankumar | #link https://review.opendev.org/q/topic:%22cyborg-dev-doc%22 | 14:09 |
| chandankumar | I was working on improving the contributor doc. | 14:09 |
| chandankumar | Thank you everyone for all the feedback on the patch series. I have addressed them. Feel free to take a look. | 14:09 |
| chandankumar | Moving to next one | 14:10 |
| chandankumar | #link https://review.opendev.org/c/openstack/cyborg/+/984508: Add placement client config for devstack multinode | 14:11 |
| chandankumar | this one fixes the devstack plugin for multinode job and add a new multinode | 14:11 |
| chandankumar | devstack job. | 14:12 |
| chandankumar | Please add it to your review list. | 14:12 |
| chandankumar | Do we have any more reviews anyone wants to highlight? | 14:13 |
| chandankumar | moving to the next section | 14:14 |
| chandankumar | #topic bugs | 14:14 |
| chandankumar | #link PCI devices does not have OWNER_CYBORG traits https://bugs.launchpad.net/openstack-cyborg/+bug/2150557 | 14:15 |
| chandankumar | During 2026.2 ptg, under driver development discussion, we talked about traits and pci devices does not OWNER_CYBORG | 14:15 |
| sean-k-mooney | ack review might be a bit slow this week but ill try to pick back up next week | 14:16 |
| chandankumar | for that one, I have opened the bug | 14:16 |
| chandankumar | https://review.opendev.org/c/openstack/cyborg/+/986536 it fixes the same. | 14:16 |
| sean-k-mooney | ok that may be a suitable bug | 14:16 |
| chandankumar | Since it changes the output in openstack accelerator device attribute list | 14:16 |
| sean-k-mooney | the upgrade impact of that shoudl be effectivly 0 | 14:16 |
| chandankumar | will it need a release notes? and test coverage? | 14:17 |
| sean-k-mooney | i default to yes in both cases | 14:17 |
| chandankumar | ok good | 14:17 |
| sean-k-mooney | it need at least unit test coverage | 14:17 |
| chandankumar | PCI device lacks unit tests. | 14:18 |
| sean-k-mooney | ... | 14:18 |
| jgilaber | should we add that trait to all drivers? A quick search shows that other drivers seem to be missing it | 14:18 |
| chandankumar | I need to take a look how much we have coverage | 14:18 |
| jgilaber | https://github.com/search?q=repo%3Aopenstack%2Fcyborg%20traits&type=code | 14:18 |
| chandankumar | yes, | 14:18 |
| sean-k-mooney | jgilaber: yes so i wonder if we want to track this as more then a bug | 14:18 |
| chandankumar | it is currently available in FGPA, PCI, GPU only | 14:18 |
| jgilaber | yes a specless blueprint might be a good fit I think | 14:18 |
| sean-k-mooney | this is part of the "how do we model devices in placment" topic | 14:18 |
| jgilaber | particularly if the testing needs significant work | 14:19 |
| chandankumar | I will take a look at how much test coverage we have there for device spec and whitelist there is no coverage | 14:19 |
| sean-k-mooney | i added some test when i fixed eliaer bugs in the pci driver by the way | 14:19 |
| sean-k-mooney | as in unit tests | 14:20 |
| sean-k-mooney | we will want to have tempest test for this later too | 14:20 |
| chandankumar | https://github.com/openstack/cyborg/tree/master/cyborg/tests/unit/accelerator/drivers/pci/pci | 14:20 |
| chandankumar | https://github.com/openstack/cyborg/blob/master/cyborg/tests/unit/accelerator/drivers/pci/pci/test_sysinfo.py | 14:20 |
| sean-k-mooney | https://github.com/openstack/cyborg/blob/master/cyborg/tests/unit/accelerator/drivers/pci/pci/test_sysinfo.py | 14:20 |
| chandankumar | it will the test voverage | 14:20 |
| sean-k-mooney | ya so we have driver specific test although perhpas not where you expect them | 14:21 |
| sean-k-mooney | so at the very lease we need unit test cover for this in the future functional and tempest test too | 14:21 |
| chandankumar | regarding traits, there is some code duplication about constant names, May be I can clean it in the same patch | 14:22 |
| sean-k-mooney | in general that better to do in a sperate patch | 14:22 |
| chandankumar | ok | 14:22 |
| sean-k-mooney | but it kind fo depends | 14:22 |
| sean-k-mooney | on if we woudl abckprot this or not | 14:22 |
| chandankumar | will do a follow up patch then | 14:22 |
| sean-k-mooney | in my mind this is maser only | 14:22 |
| sean-k-mooney | as a general rule you shoudl do code cleanup in a sepreate patch form bug or feature work | 14:23 |
| chandankumar | as you said there is no upgrade impact, i think it is ok to backport | 14:23 |
| sean-k-mooney | well there is | 14:23 |
| sean-k-mooney | but its mitigated by how old that specific trait is | 14:23 |
| chandankumar | https://github.com/openstack/cyborg/commit/5f896d2931d1a02e4beaf2cb4109a8a3e384b155 unifies pci management | 14:24 |
| sean-k-mooney | if this trait was new this cycle we coudl nto backprot it to an older relase as an example | 14:24 |
| sean-k-mooney | that not what you need to check in this case | 14:25 |
| sean-k-mooney | its https://github.com/openstack/os-traits/blob/master/os_traits/owner/__init__.py | 14:25 |
| sean-k-mooney | that was added 4 years ago | 14:25 |
| sean-k-mooney | if it was new in 2026.2 you woudl have to check fi the standard trait exsitns in placment before reporting it | 14:25 |
| sean-k-mooney | as we have to assuem placment could be at least 2 release older then cyborg | 14:26 |
| sean-k-mooney | we also need to acont for the fact the cybrog compute agent can be up to 1 slrup older | 14:26 |
| sean-k-mooney | in thei case we cant assume its newer then 2026.1 and we cant assume it has this backport | 14:27 |
| chandankumar | ah in that case, I keep this to master only. | 14:27 |
| sean-k-mooney | so when we translate teh device spec into a placment request group | 14:27 |
| sean-k-mooney | we cant unconditonly assume its updated | 14:28 |
| chandankumar | I did not consider these assumption | 14:28 |
| sean-k-mooney | so this will need more work to make sure we dont break upgrades | 14:28 |
| sean-k-mooney | the reporting of the triat is fine | 14:28 |
| sean-k-mooney | the requesting of it need to check the compute-agent verion and gate it on the min version | 14:28 |
| sean-k-mooney | or a config option | 14:29 |
| sean-k-mooney | given we are not reprotign it today we must not be requesting it either | 14:29 |
| sean-k-mooney | lets loop bakc to that in more detail on teh review or outside the meeting | 14:29 |
| chandankumar | sure | 14:29 |
| chandankumar | thank you sean-k-mooney! | 14:30 |
| chandankumar | Since there is no more bugs, moving to open discussion | 14:30 |
| chandankumar | #topic Open Discussion | 14:30 |
| chandankumar | Feel free to bring topic here | 14:31 |
| sean-k-mooney | i guess now is as good a time as any to say | 14:32 |
| sean-k-mooney | i will be on pto friday and monday and im thinking of also taking next tuesday | 14:32 |
| sean-k-mooney | so i may not be be here next week for the meeting | 14:33 |
| chandankumar | sure, enjoy your time off! | 14:33 |
| chandankumar | Moving to last one | 14:33 |
| chandankumar | #topic volunteer to chair for next meeting | 14:34 |
| chandankumar | Any volunteer up for chairing the next meeting? | 14:34 |
| jgilaber | I can do it | 14:34 |
| chandankumar | thank you jgilaber ! | 14:34 |
| chandankumar | Now closing the meeting early, thank you all for attending! | 14:35 |
| chandankumar | #endmeeting cyborg | 14:35 |
| opendevmeet | Meeting ended Tue Apr 28 14:35:18 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:35 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-04-28-14.03.html | 14:35 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-04-28-14.03.txt | 14:35 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-04-28-14.03.log.html | 14:35 |
| sean-k-mooney | chandankumar: jgilaber i dont know if we want to continue to discuss the upgrade condieration or not right now or if ye want to reflect on my comments | 14:36 |
| sean-k-mooney | i think before we proceed with reproting the owner triat (that shoudl be safe) we need to do a deeper review of how that currently interact with t hegeenrat request groups in the arq | 14:37 |
| sean-k-mooney | and look at the exact mechanis when we have up to n-2 compute-agent runnign with a fully upgraded api/conductor | 14:38 |
| chandankumar | +1 to do a deep review on interaction with placement and cyborg on owner traits | 14:38 |
| chandankumar | We might discover more bugs in that. | 14:39 |
| sean-k-mooney | openstack --os-cloud devstack-admin resource provider trait list 45593a00-c178-3159-9687-6d7efa55f64d | 14:39 |
| sean-k-mooney | +----------------------------+ | 14:39 |
| sean-k-mooney | | name | | 14:39 |
| sean-k-mooney | +----------------------------+ | 14:39 |
| sean-k-mooney | | CUSTOM_PCI_INTEL | | 14:39 |
| chandankumar | and then revisit this again in another meeting. | 14:39 |
| sean-k-mooney | | CUSTOM_PCI_PRODUCT_ID_154C | | 14:39 |
| sean-k-mooney | +----------------------------+ | 14:39 |
| sean-k-mooney | i can confirm that the trait is indeed missing | 14:39 |
| sean-k-mooney | so its not stricly a bug | 14:40 |
| sean-k-mooney | the suprpot for this was part of a new spec | 14:40 |
| sean-k-mooney | that was not fully impmented | 14:40 |
| sean-k-mooney | i.e. owner traits were only intoduced a long time after cybrog was creted | 14:40 |
| sean-k-mooney | as part fo a feature that spaned nova and cybrog that was never impmented on teh nova side | 14:41 |
| sean-k-mooney | and only partly doen in cyborg | 14:41 |
| sean-k-mooney | so im wondering if this shoudl really be a bug at all given it was orgially a feature qruieding a spec | 14:41 |
| chandankumar | https://github.com/search?q=repo%3Aopenstack%2Fnova-specs%20OWNER_CYBORG&type=code there are two specs | 14:41 |
| sean-k-mooney | and given the nvova part was never done (its part of the nova spec for vgpus) | 14:41 |
| chandankumar | this one https://github.com/openstack/nova-specs/blob/e53cb185c680e479a44a94ef0cfb7e1f52c762d6/specs/wallaby/approved/cyborg-vgpu-support.rst#L125 ? | 14:42 |
| sean-k-mooney | yep both are appvoed not implemtned | 14:42 |
| sean-k-mooney | so the nvida driver was partly updated in cybrog because of this | 14:42 |
| sean-k-mooney | but it was never completed and the canges for the other cybrog driver were not done | 14:42 |
| sean-k-mooney | https://github.com/openstack/cyborg-specs/blob/master/specs/wallaby/approved/vgpu-driver-proposal.rst | 14:43 |
| sean-k-mooney | was the cyborg spec for this | 14:44 |
| sean-k-mooney | that was finally implemtned in 2023.1 https://github.com/openstack/cyborg-specs/blob/master/specs/2023.1/implemented/vgpu-driver-proposal.rst | 14:45 |
| sean-k-mooney | without the nova half and without updatign the other drivers to also use the cybrog owner trait | 14:45 |
| chandankumar | when you say nova half, how much work is still left to implement to make it work properly? | 14:47 |
| chandankumar | https://review.opendev.org/q/topic:%22bp/cyborg-vgpu-support%22 | 14:47 |
| chandankumar | https://review.opendev.org/c/openstack/nova/+/812247: vGPU support by Cyborg is an open patch | 14:47 |
| sean-k-mooney | none of the nova change merged | 14:47 |
| sean-k-mooney | so on the nova side there are 2 related parts | 14:48 |
| sean-k-mooney | first nova need to report all its resouce provider with OWNER_COMPUTE or OWNER_NOVA i dont recall | 14:48 |
| sean-k-mooney | it thne need to have a prefilter to include that for its device requests that are not cyborg related | 14:49 |
| chandankumar | Since it is not properly implemented. | 14:51 |
| chandankumar | How do you suggest here next course of action? | 14:52 |
| chandankumar | I am going to do a deep review of how placement nova and cyborg works on traits | 14:52 |
| chandankumar | or we want to table this discussion for some other day? | 14:52 |
| jgilaber | once we implement the owner trait in nova, after upgrading will the trait be added to an already existing resource class or does the operator need to do some action? | 14:53 |
| sean-k-mooney | nova shoudl do it | 14:55 |
| sean-k-mooney | for its resouce classes | 14:55 |
| sean-k-mooney | but the requesting of it need to be gated by a min compute service version check | 14:55 |
| chandankumar | can you share one example of min service version check? | 14:56 |
| chandankumar | from other project | 14:56 |
| sean-k-mooney | sure but i need to check if cybrog has the same concpet today | 14:58 |
| sean-k-mooney | so in the service object | 14:58 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/service.py#L40 | 14:58 |
| sean-k-mooney | we have an integer constant that we increment when we add specific feautres | 14:59 |
| sean-k-mooney | eacg compute serivce looks at there local constant and report that value to the db | 14:59 |
| sean-k-mooney | nova maintian a history of what those are https://github.com/openstack/nova/blob/master/nova/objects/service.py#L65 | 14:59 |
| sean-k-mooney | we use them both for feature discoverya and detecting nodes that are tooo old | 15:00 |
| sean-k-mooney | in the compute api among other places we can then check the compute service version and block actions | 15:01 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L373-L394 | 15:01 |
| sean-k-mooney | so operation that dont work with cybrog are decorated with block_accelerators | 15:01 |
| sean-k-mooney | which acppate a verion | 15:01 |
| sean-k-mooney | if the min version fo any compute agent cant supprot it | 15:02 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/service.py#L621-L686 | 15:02 |
| sean-k-mooney | we block teh request | 15:02 |
| sean-k-mooney | we also have other hleper https://github.com/openstack/nova/blob/master/nova/objects/service.py#L495-L518 | 15:03 |
| sean-k-mooney | but the simple version of it is nova will refuse to starte some serices if a compute agent is older then it can supprot | 15:04 |
| sean-k-mooney | nova/cyborg or any service with a distibuted compont officlaly only supprot the current release the prior release and the prior slup release | 15:05 |
| sean-k-mooney | so at most 2 relases back | 15:06 |
| chandankumar | I was aware about block_accelerators usage regarding controlling instance actions | 15:09 |
| chandankumar | ah, thank you for explaining, Now i understand service version history | 15:11 |
| chandankumar | I just looked into the cyborg codebase, there is no such mapping | 15:11 |
| chandankumar | We need to implement similar minimum version check for cyborg that we can use it during upgrade. | 15:14 |
| sean-k-mooney | its actully more invaidve then that because we do not currently track compute-agent isntace in the db at all | 15:21 |
| sean-k-mooney | so for cybrog we need to isntead have a lot of infra before we coudl do this automaticly so we woudl have to gate this behind a config option i think | 15:22 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!