| rlandy | doodle created | 04:45 |
|---|---|---|
| chandankumar | sean-k-mooney: Hello, feel free to merge https://review.opendev.org/q/topic:%22pci-sim%22, it looks from my end. | 12:37 |
| sean-k-mooney | i was just posting a repsoce and basiclly asking if we were ok to investiage the things you noted once the inital patch was merged | 12:39 |
| sean-k-mooney | so ok im not imitdaly seeign the reason the second pf didnt have vfs in your env | 12:40 |
| sean-k-mooney | but its someitng ill do more testing with when i starte trying to use this in tempest | 12:40 |
| sean-k-mooney | i have not really done baremental testing with this yet so there may be quirks that need to be worked out such as investiatign if we can supprot a mix of fake and realy device passhtough at the same time | 12:41 |
| chandankumar | sounds good to investigate further on that | 12:41 |
| chandankumar | But let;s get this series merge, it is too big to carry | 12:42 |
| sean-k-mooney | the other thing that im condierign is addign a few debuging script to the devstack jobs, basically running lspci or virsh nodedev list as a post run playbook to collect soem extra host info for debugging later | 12:43 |
| chandankumar | good idea, I will give a try with mix and see how it looks | 12:43 |
| chandankumar | +1 | 12:43 |
| sean-k-mooney | so with intel_iommu=off sriov and normal pci passhtough wont work | 12:44 |
| sean-k-mooney | but if you set it to intel_iommu=on and iommu=pt | 12:44 |
| sean-k-mooney | it might | 12:44 |
| sean-k-mooney | https://github.com/torvalds/linux/blob/master/Documentation/admin-guide/kernel-parameters.txt#L2533 | 12:45 |
| sean-k-mooney | ther is also noforce or soft we could explre fore the mixed case | 12:46 |
| chandankumar | ah thank you for the link, it has so many options | 12:47 |
| sean-k-mooney | ya, iommu=pt is what we use for dpdk and sriov on the same host | 12:47 |
| sean-k-mooney | so i dont knwo if that woudl make it work | 12:47 |
| sean-k-mooney | its somethign we can investigate in any case | 12:47 |
| sean-k-mooney | for first party ci we wont have the mixed case so this is more for local dev | 12:48 |
| sean-k-mooney | oh looks like intremap defualt ot on if the intel_iommu=on | 12:49 |
| sean-k-mooney | if we figure out a combinaiton that works we can docuement it | 12:50 |
| chandankumar | sure | 12:52 |
| sean-k-mooney | https://paste.opendev.org/show/bYiLthWNUfK7OclB7HqW/ | 12:54 |
| sean-k-mooney | that what nova is seing in ci by the way | 12:54 |
| sean-k-mooney | so it is seeing the VFs on boht pfs | 12:55 |
| sean-k-mooney | so im wonderinf if the is a short widnwos where tha tcan race or if it was somehtign local on your system form a prior run | 12:55 |
| sean-k-mooney | one thin i tmay be is that i have not test with only cyborg enabeld and multiple pfs | 12:55 |
| sean-k-mooney | so that the first time im goign to investigate | 12:56 |
| sean-k-mooney | i have been testign with the pfs split between nova and cyborg | 12:56 |
| sean-k-mooney | were you only allcoating them to cybrog locally. | 12:56 |
| chandankumar | ENABLE_PCI_SIM=True | 12:57 |
| chandankumar | # pci-sim topology: 2 fake PFs, 4 VFs each. | 12:57 |
| chandankumar | # With both integrations enabled, PF0 VFs go to Nova and PF1 VFs to Cyborg. | 12:57 |
| chandankumar | PCI_SIM_NUM_PFS=2 | 12:57 |
| chandankumar | PCI_SIM_NUM_VFS=4 | 12:57 |
| chandankumar | PCI_SIM_CONFIGURE_NOVA_PCI=True | 12:57 |
| chandankumar | PCI_SIM_CONFIGURE_CYBORG_PCI=True | 12:57 |
| chandankumar | PCI_SIM_ALLOW_UNSAFE_INTERRUPTS=True | 12:57 |
| sean-k-mooney | ok that what i ws testing with as well | 12:58 |
| sean-k-mooney | still i can build out some test cases for the diffent option adn see what breaks | 12:58 |
| chandankumar | The error I hit earier while enabling cyborg then I hit while enabling both nova and cyborg | 12:59 |
| sean-k-mooney | chandankumar: so my current todo list for that moduel was add the ablity to create mdevs, add the ablity to emulate an e1000 nic adn then possibel add the ablity to emulate an nvme device | 13:05 |
| sean-k-mooney | the secodn two are more asperationall but i think ti woudl be possibel to do by reusing some of the nvmevirt work | 13:05 |
| sean-k-mooney | but im not currently willing to commit to the latter in a short itme frame becasue that is very non tirival | 13:06 |
| sean-k-mooney | addign the ablity for the PFs to supprot mdpy mdevs shoudl be realitivly simple | 13:07 |
| sean-k-mooney | emulating a nic that works enough for neturon sriov testing is somewhere in between | 13:07 |
| sean-k-mooney | we dont stricly need that but it is simpler then pretending to be a nvme device | 13:07 |
| chandankumar | nmvevirt has no iommu group support On which I am kind of blocked to see nvme with in the guest . From pci-sim work, I think i can reuse some of your work to add the support there | 13:31 |
| chandankumar | or I can do opposite, take some of the work from nvmevirt and add it into pci-sim | 13:32 |
| chandankumar | But I need to think on that | 13:32 |
| chandankumar | on another note, I was writting some tests to validate cyborg placemnt workflow with pci scenario test https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992210 it might be useful | 13:33 |
| chandankumar | I will update my above review with pci-sim work for the tempest tests | 13:33 |
| chandankumar | brb | 13:33 |
| sean-k-mooney | oh cool | 13:46 |
| sean-k-mooney | ya i was plannign to focus on scenairo test to validate the vm lifecycle | 13:47 |
| sean-k-mooney | so the placmeent reporting tests will complement that | 13:47 |
| opendevreview | Merged openstack/cyborg master: devstack: add pci-sim fake SR-IOV PCI passthrough test fixture https://review.opendev.org/c/openstack/cyborg/+/989470 | 14:02 |
| opendevreview | Merged openstack/cyborg master: Add pci-sim developer guide https://review.opendev.org/c/openstack/cyborg/+/991177 | 14:02 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Rename devstack CYBORG_CONF_FILE to CYBORG_CONF for consistency https://review.opendev.org/c/openstack/cyborg/+/979805 | 14:55 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add NVMeVirt emulated NVMe device support for devstack https://review.opendev.org/c/openstack/cyborg/+/977083 | 14:55 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add NVMeVirt emulated NVMe device support for devstack https://review.opendev.org/c/openstack/cyborg/+/977083 | 14:57 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Rename devstack CYBORG_CONF_FILE to CYBORG_CONF for consistency https://review.opendev.org/c/openstack/cyborg/+/979805 | 15:30 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Add NVMeVirt emulated NVMe device support for devstack https://review.opendev.org/c/openstack/cyborg/+/977083 | 15:30 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!