| opendevreview | sean mooney proposed openstack/cyborg master: Use request context as policy target https://review.opendev.org/c/openstack/cyborg/+/992722 | 11:06 |
|---|---|---|
| opendevreview | sean mooney proposed openstack/cyborg master: Add SRBAC base rules and enforce_new_defaults override https://review.opendev.org/c/openstack/cyborg/+/992292 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Migrate ARQ policies to DocumentedRuleDefault https://review.opendev.org/c/openstack/cyborg/+/992293 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Migrate device policies to DocumentedRuleDefault https://review.opendev.org/c/openstack/cyborg/+/992294 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Migrate deployable policies to DocumentedRuleDefault https://review.opendev.org/c/openstack/cyborg/+/992295 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Migrate attribute policies to DocumentedRuleDefault https://review.opendev.org/c/openstack/cyborg/+/992296 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Add SRBAC policy concepts documentation https://review.opendev.org/c/openstack/cyborg/+/992297 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Add cyborg-tempest-srbac Zuul job https://review.opendev.org/c/openstack/cyborg/+/992332 | 11:06 |
| opendevreview | sean mooney proposed openstack/cyborg master: Remove no-op deprecated policy bridges https://review.opendev.org/c/openstack/cyborg/+/995462 | 11:06 |
| opendevreview | Merged openstack/cyborg master: Fix incorrect set syntax in placement client logging https://review.opendev.org/c/openstack/cyborg/+/994851 | 12:03 |
| opendevreview | Merged openstack/cyborg master: Rename devstack CYBORG_CONF_FILE to CYBORG_CONF for consistency https://review.opendev.org/c/openstack/cyborg/+/979805 | 12:03 |
| chandankumar | sean-k-mooney: Hello, can you take a look at https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992330 and https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992328/ in your free time, not super urgent, thank you! | 12:12 |
| sean-k-mooney | ill update https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992330/3 a little later today | 12:29 |
| sean-k-mooney | i would liek to merge the srbac serives this week assuming there are no outstandign issues. after that i plan ot adress teh ruff/per-commit changes next on the tempest plugin side but ill update https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992347/1 to cover all ai agents first | 12:31 |
| chandankumar | no all good from my side | 12:32 |
| chandankumar | I will take a look at docs tomorrow | 12:32 |
| sean-k-mooney | chandankumar: do you have any patch for teh tempest plugin you think woudl be good to land sooner rather then later? | 12:32 |
| sean-k-mooney | i need to swap to spec review soon and hopefully we can move forward whith those today | 12:33 |
| sean-k-mooney | so that next on my list | 12:33 |
| chandankumar | sean-k-mooney: I think I can drop https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/992210 in favor of your pci scenario tests. | 12:34 |
| chandankumar | No other patch from my side on cyborg-tempest-plugin | 12:34 |
| sean-k-mooney | oh the placement ones | 12:34 |
| sean-k-mooney | those are not nessisarly reduntance but they are also not actully secnairo tests in the normal sense | 12:35 |
| chandankumar | yes, but it is alos more than api tests | 12:35 |
| sean-k-mooney | ya so i think we done really need to have placement assert the provier toplogy | 12:36 |
| sean-k-mooney | but its up to you. | 12:36 |
| sean-k-mooney | they add soem addtion coverage but not a lot | 12:36 |
| chandankumar | Ok I will fine that patch and move it to api test | 12:36 |
| sean-k-mooney | have you tested those with the pci-sim? | 12:37 |
| chandankumar | I tested it with pci-sim | 12:37 |
| sean-k-mooney | ack so ya if you move them to api i think that woudl be fien. we could keep them in secario to as you said its somewhere in between | 12:37 |
| chandankumar | sorry let me double check | 12:38 |
| sean-k-mooney | i think it shoudl work as long as you set the correct adreses | 12:38 |
| chandankumar | tested here: https://review.opendev.org/c/openstack/cyborg/+/977083/51/.zuul.yaml | 12:38 |
| chandankumar | nvmevirt patch | 12:38 |
| chandankumar | https://123b844dd0bc940cd071-d2975a8f065f970ca29e743c021b8a36.ssl.cf1.rackcdn.com/openstack/5f698c9d53e44e52bbd22509f59b8b25/testr_results.html | 12:39 |
| chandankumar | test_pci_device_discovery[id-b3d5e7f9-1a2c-4e6f-8b0d-2c4e6f8b0d2e] | 12:39 |
| sean-k-mooney | whats the plan for that by the way | 12:39 |
| sean-k-mooney | are we goign to abandon the nvmevirt patches in favor of your new nvme pci-sim series | 12:39 |
| chandankumar | yes correct | 12:40 |
| chandankumar | drop nvmevirt patches | 12:40 |
| chandankumar | since we can achieve almost everyhting in first party CI | 12:40 |
| chandankumar | sean-k-mooney: I am not sure you saw this message https://review.opendev.org/c/openstack/cyborg/+/995079/6#message-fd9b5227f7e11e2defeda4a79e4b1b19d0f3c0b2 | 12:41 |
| chandankumar | we can see nvme block in lsblk output in guest vm but we need a ubuntu image | 12:41 |
| sean-k-mooney | well i guess it just need an image with the kernel nvme driver | 12:42 |
| chandankumar | yes | 12:42 |
| sean-k-mooney | i might add that to the list of cirrors changes i have in flight | 12:42 |
| chandankumar | cool, that would be awesome | 12:42 |
| sean-k-mooney | we coudl use lspci without the driver by the way | 12:42 |
| sean-k-mooney | as an inital test | 12:43 |
| sean-k-mooney | we just wont be able to run the lsblk part | 12:43 |
| chandankumar | yup, in cirros we can see nvme in lspci output | 12:43 |
| sean-k-mooney | i dont realy have an issue with using a alternitive guest image for this test but ya we coudl make that part optional. | 12:43 |
| chandankumar | that also sounds good | 12:44 |
| sean-k-mooney | did you see my comment about needing to be abel to have 1 job with both nvme and uart pci-sim pfs | 12:44 |
| chandankumar | yes, will work on that | 12:44 |
| sean-k-mooney | cool, my hope is when we add mdev supprot to pci-sim | 12:44 |
| sean-k-mooney | we will be able to validate teh 3 generic driver in one job | 12:45 |
| sean-k-mooney | that will require makign the devstack pluging a little smarter but i think its quite doable | 12:45 |
| sean-k-mooney | also i dont know if you read the review guide i created. i need to actully do a deepre review myslef but im goign to go look at the spec shortly before the irc meeting | 12:46 |
| chandankumar | paste.opendev.org/show/bDXSGmjCs9TH0NRXcVaK/ not yet, it is in my list. | 12:49 |
| opendevreview | chandan kumar proposed openstack/cyborg-specs master: Add generic NVMe driver spec with secure cleanup https://review.opendev.org/c/openstack/cyborg-specs/+/985349 | 12:50 |
| chandankumar | sean-k-mooney: two more reviews good to merge https://review.opendev.org/c/openstack/cyborg/+/994816 and https://review.opendev.org/c/openstack/cyborg/+/994830 from Melanie. | 12:53 |
| sean-k-mooney | ah the api sample tests and api refe set ya i skimmed them breifly but ill try and review those later in the week | 12:58 |
| chandankumar | sure | 12:58 |
| jgilaber | Hi all! IRC meeting will start in ~ 1 hour, add your topics to the agenda https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L48 | 13:00 |
| opendevreview | chandan kumar proposed openstack/cyborg-specs master: Add generic NVMe driver spec with secure cleanup https://review.opendev.org/c/openstack/cyborg-specs/+/985349 | 13:37 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Refactor RequestContext https://review.opendev.org/c/openstack/cyborg/+/995195 | 13:48 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused context properties https://review.opendev.org/c/openstack/cyborg/+/995205 | 13:52 |
| jgilaber | #startmeeting cyborg | 14:00 |
| opendevmeet | Meeting started Tue Jun 30 14:00:33 2026 UTC and is due to finish in 60 minutes. The chair is jgilaber. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cyborg' | 14:00 |
| sean-k-mooney | o/ | 14:00 |
| jgilaber | Hello! Who is around today? | 14:00 |
| chandankumar | o/ | 14:00 |
| jgilaber | While we gather, feel free to add topics to the agenda https://etherpad.opendev.org/p/openstack-cyborg-irc-meeting#L48 | 14:01 |
| rlandy | o/ | 14:01 |
| jgilaber | courtesy ping: amoralej bogdando | 14:01 |
| morenod | o/ | 14:01 |
| amoralej | o/ | 14:01 |
| jgilaber | let's give folks a minute and we'll start with the first topic | 14:01 |
| jgilaber | #topic Reminder: Spec freeze on July 2 | 14:02 |
| jgilaber | we have two specs open | 14:02 |
| jgilaber | #link https://review.opendev.org/c/openstack/cyborg-specs/+/982276 | 14:02 |
| jgilaber | #link https://review.opendev.org/c/openstack/cyborg-specs/+/985349 | 14:02 |
| melwitt | o/ | 14:03 |
| jgilaber | I'll do another pass of the nvme spec after the meeting but I think that one is good to go | 14:03 |
| chandankumar | I will take a look at mdev spec tomorrow | 14:03 |
| sean-k-mooney | jgilaber: i just left comments on yours +1 with minor change im happy to merge it | 14:03 |
| sean-k-mooney | chandankumar: yours is next on my list | 14:04 |
| sean-k-mooney | for after the meeting | 14:04 |
| jgilaber | ack thanks sean-k-mooney I'll look after the meeting | 14:04 |
| chandankumar | thank you! | 14:04 |
| jgilaber | looks like we're in good shape, anything else on this topic? | 14:04 |
| jgilaber | ok, next topic | 14:05 |
| jgilaber | #topic Freezing python-cyborgclient improvements | 14:05 |
| jgilaber | this one if from rlandy I believe | 14:05 |
| jgilaber | #link https://review.opendev.org/c/openstack/python-cyborgclient/+/994696 | 14:05 |
| rlandy | yes... | 14:05 |
| rlandy | this change started with bug: https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 | 14:06 |
| rlandy | which requires removing the old v1 API | 14:06 |
| rlandy | from cyborgclient | 14:06 |
| rlandy | but there is also the piece of sdk accelerator v2 support | 14:07 |
| rlandy | looking at the description, the bug now contains many parts | 14:07 |
| rlandy | and we need to rethink the approach here | 14:08 |
| rlandy | as initially the plan was the keep using the openstacksdk | 14:08 |
| rlandy | so chandankumar and I are bringing this to the team to establish a direction | 14:08 |
| rlandy | because this is probably bigger than one bug | 14:08 |
| rlandy | and we need to decide what should be addressed immediately vs taking a longer design | 14:09 |
| jgilaber | problem 3 in the bug report seems backwards to me | 14:09 |
| jgilaber | I don't think we want to move the accelerator proxy to the client | 14:09 |
| chandankumar | yes, that needs to be fixed | 14:10 |
| sean-k-mooney | rlandy: so the python-cybrogclient | 14:10 |
| sean-k-mooney | alrady uses the sdk | 14:10 |
| sean-k-mooney | for v2 | 14:10 |
| sean-k-mooney | so this was orgianly intened to track only the v1 removal | 14:10 |
| melwitt | yeah what's in the description there looks like specless blueprint material | 14:10 |
| rlandy | ok - so that is possibly the right direction - to make the bug just cover v1 removal | 14:11 |
| sean-k-mooney | yes | 14:11 |
| rlandy | and move the rest to some spec/blueprint etc. | 14:11 |
| sean-k-mooney | we did dicss this in the ptg | 14:11 |
| sean-k-mooney | so the propsoal was to remove v1 this cycle and deprecate teh shell | 14:11 |
| rlandy | so I would propose to abandon this change - and it complicates things | 14:12 |
| rlandy | and just start over with the v1 removal | 14:12 |
| sean-k-mooney | by shell i mean cybrog command | 14:12 |
| rlandy | taking the rest to PTG? | 14:12 |
| sean-k-mooney | sure we can do that | 14:12 |
| rlandy | ok - chandankumar - you in agreement here? | 14:12 |
| sean-k-mooney | my hope was to deprecate the python-cybrogclient repo next cycle entirly if we end up upstreamign ti to osc | 14:12 |
| chandankumar | But for this release, Do we want to fix existing interface and not add any coverage there | 14:13 |
| sean-k-mooney | and if not resuding it down to only the osc plugin in 2027.2 | 14:13 |
| chandankumar | with v1 removal | 14:13 |
| rlandy | the issue is there is a lot in common | 14:13 |
| sean-k-mooney | chandankumar: which interface? | 14:13 |
| chandankumar | I mean device enable /disable interface | 14:13 |
| sean-k-mooney | oh that is a sperate bug | 14:14 |
| chandankumar | https://bugs.launchpad.net/python-cyborgclient/+bug/2151792 | 14:14 |
| sean-k-mooney | we shoudl fix that but not as part of this | 14:14 |
| sean-k-mooney | we shoudl fix htat by preposoing the sdk change | 14:14 |
| jgilaber | it looks to me that with the v1 removal https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 should be done | 14:15 |
| chandankumar | ok | 14:15 |
| sean-k-mooney | so proeblem 1 and 2 are really the scope of this i think | 14:16 |
| sean-k-mooney | "Problem 3: Migrate accelerator proxy from openstacksdk into cyborgclient" wans never intended to be done | 14:16 |
| chandankumar | sounds good to me drop v1 from cyborgclient and rest of enahncement/fixes goes to sdk change | 14:16 |
| sean-k-mooney | so i think that where the confustion came form | 14:16 |
| jgilaber | +1 sean-k-mooney | 14:16 |
| chandankumar | srry that is Add support from accelerator proxy from openstacksdk into cyborgclient | 14:17 |
| sean-k-mooney | yes | 14:17 |
| sean-k-mooney | we do not want to "Migrate the SDK accelerator proxy into cyborgclient" | 14:17 |
| chandankumar | yup | 14:18 |
| sean-k-mooney | so are folk ok if i update teh bug to just remove problem 3 | 14:18 |
| chandankumar | I will drop that section from the bug and keep it to v1 removal to clear confson | 14:18 |
| sean-k-mooney | then i htink we are good | 14:18 |
| sean-k-mooney | ack | 14:18 |
| sean-k-mooney | works for me | 14:18 |
| rlandy | ok- thank you | 14:18 |
| rlandy | I will submit a new change for the 1 and 2 and abandon the current change | 14:19 |
| rlandy | jgilaber, thank you - I think we are ok here | 14:19 |
| jgilaber | ack, thanks | 14:19 |
| jgilaber | #topics Reviews | 14:19 |
| jgilaber | we don't have anything listed | 14:19 |
| jgilaber | is there any patch that anyone wants to call out? | 14:19 |
| melwitt | think you need #topic without a s (sorry) | 14:20 |
| jgilaber | oh right, thanks melwitt | 14:20 |
| jgilaber | #topic Reviews | 14:20 |
| jgilaber | anything? otherwise we can move to bug triage | 14:20 |
| melwitt | I wanted to mention about, I have a API test samples patch I tried out here if anyone wants to take a look and see what they think https://review.opendev.org/c/openstack/cyborg/+/994830 | 14:21 |
| sean-k-mooney | nothing urgent just an fyi takashi has proposed some cleanup of nova code in cybrog https://review.opendev.org/c/openstack/cyborg/+/995195/4 | 14:21 |
| sean-k-mooney | melwitt: oh you removed the WIP :) | 14:21 |
| melwitt | yeah just now :) seems ... pretty ok so ready for some scrutiny | 14:21 |
| chandankumar | will take a look at those this week. | 14:22 |
| sean-k-mooney | i approved the irrelevent files change this morning https://review.opendev.org/c/openstack/cyborg/+/994816/1 | 14:22 |
| melwitt | ah thanks | 14:22 |
| jgilaber | thanks, I'll add them to my review list as well | 14:23 |
| jgilaber | let's move on | 14:23 |
| jgilaber | #topic Bugs | 14:23 |
| jgilaber | I saw we have two untriaged | 14:23 |
| jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2158058 | 14:23 |
| chandankumar | we discussed about this one in last meeting | 14:24 |
| chandankumar | [cyborg-tempest-plugin][fake driver]Improve the scenario test coverage for instance operation in fake driver | 14:24 |
| chandankumar | sean-k-mooney proposed https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 pci driver based instance lifecycle test | 14:25 |
| chandankumar | we will reuse the same format | 14:25 |
| chandankumar | for this one, can we mark them as a wishlist? | 14:25 |
| jgilaber | does that patch completely address the bug report or will we need more? | 14:25 |
| chandankumar | nono, we need to duplicate the same tests for fake driver based on above patch | 14:26 |
| jgilaber | ah ok, I see | 14:26 |
| jgilaber | wishlist/medium seems good to me | 14:27 |
| sean-k-mooney | so it kind of superceed it | 14:27 |
| sean-k-mooney | i actully think there is very littel point in useing the fake driver for the majoryit of the lifecycle operations | 14:27 |
| sean-k-mooney | because the only thing that tests is the arq creation | 14:27 |
| sean-k-mooney | on the nova side we entirly drop the arq info | 14:28 |
| melwitt | yeah I kind of wondered about that ... how helpful is the fake driver for lifecycle testing | 14:28 |
| sean-k-mooney | so i woudl prefer to only test program and create with the fake driver | 14:28 |
| sean-k-mooney | and test the rest with pci/mdev/nvme drivers | 14:28 |
| chandankumar | for program I have awip patch https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 | 14:29 |
| sean-k-mooney | chandankumar: so we have a exsitng boot test with the fake driver | 14:29 |
| sean-k-mooney | once we merge your program tests | 14:29 |
| sean-k-mooney | i woudl close https://bugs.launchpad.net/openstack-cyborg/+bug/2158058 | 14:29 |
| jgilaber | close after the patch merges or close it now? | 14:29 |
| sean-k-mooney | well i guess it depend on if we add Close-Bug to oen of them :) | 14:30 |
| sean-k-mooney | or related bug | 14:30 |
| chandankumar | I can add closes -bug , then it will automatically closes | 14:30 |
| sean-k-mooney | cool those that work for others? | 14:30 |
| melwitt | probably want to add a comment to it about not doing lifecycle tests as part of it. or edit the description | 14:31 |
| jgilaber | ack, so in the meantime we set it as wishlist and low/medium? | 14:31 |
| chandankumar | I will add a comment to the bug | 14:32 |
| chandankumar | low/medium +1 | 14:32 |
| chandankumar | low | 14:32 |
| jgilaber | ack set then | 14:33 |
| jgilaber | next one | 14:33 |
| opendevreview | Merged openstack/cyborg master: Add api-ref/ to irrelevant-files in Zuul config https://review.opendev.org/c/openstack/cyborg/+/994816 | 14:33 |
| jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2158147 | 14:33 |
| melwitt | oh, that's the one in flight patch approved from earlier | 14:34 |
| melwitt | so it will get closed when the patch merges | 14:34 |
| jgilaber | ok, so that seems valid and is in progress, only missing the importnace | 14:34 |
| jgilaber | medium? | 14:34 |
| sean-k-mooney | ya it has no end user impact directly | 14:35 |
| melwitt | oh wait sorry. I misread that it's after the api-ref thing | 14:35 |
| sean-k-mooney | but melwitt has already fixed some incorrect examples | 14:35 |
| melwitt | anyway. yeah not high importance | 14:35 |
| jgilaber | ack thanks melwitt | 14:35 |
| jgilaber | that was the last one | 14:35 |
| jgilaber | #topic Open discussion | 14:36 |
| jgilaber | any last minute topic to raise? | 14:36 |
| sean-k-mooney | maybe we coudl chat abouy https://github.com/adamchainz/flake8-logging/pull/187 quickly | 14:36 |
| jgilaber | looking | 14:36 |
| sean-k-mooney | melwitt: so we have moved away form using flake8 in general to using ruff for linting | 14:37 |
| sean-k-mooney | we coudl run that check via the hacking env | 14:37 |
| sean-k-mooney | since it uses flake internally | 14:37 |
| melwitt | ok that's good to know | 14:37 |
| sean-k-mooney | but woudl it be better to just have a local hacking check instead | 14:37 |
| melwitt | I don't know a lot about it so I wasn't aware we could make local checks. if that's an option then seems like a nice idea? | 14:38 |
| sean-k-mooney | so there are 2 ways we coudl do this | 14:39 |
| melwitt | I'm skeptical my PR will go anywhere but I tried it anyway | 14:39 |
| sean-k-mooney | a pre-commit hook or a local hackign check | 14:39 |
| sean-k-mooney | the later is proably simpler | 14:39 |
| sean-k-mooney | this might be genericlly usefully enough to put in hacking propper as well | 14:39 |
| melwitt | ok, I will look into that then, thanks | 14:40 |
| sean-k-mooney | ah right | 14:41 |
| sean-k-mooney | https://github.com/openstack/cyborg/commit/8eb3a5a4b2a8fa0fc969290ceace9f574715d027 | 14:41 |
| sean-k-mooney | i delete our hacking plugin | 14:42 |
| sean-k-mooney | but we can add one back | 14:42 |
| melwitt | :) | 14:42 |
| sean-k-mooney | i deleted it because i didnt like the preior rules it used in general | 14:42 |
| sean-k-mooney | well or the were duplicats of other checks | 14:43 |
| melwitt | oh ok | 14:43 |
| sean-k-mooney | nova has a bunch of hackign plugin examples too for what its worth | 14:43 |
| sean-k-mooney | anyway i think we can chat about that outside the meeting | 14:44 |
| sean-k-mooney | any other topics or questions on this topic? | 14:44 |
| melwitt | sure. I will put something together. thanks for the info | 14:44 |
| sean-k-mooney | ... https://github.com/openstack/cyborg/blob/master/cyborg/__init__.py sorry got distracted | 14:45 |
| sean-k-mooney | we need to fix ^ | 14:45 |
| sean-k-mooney | i nocied that lookign at the old commit | 14:45 |
| sean-k-mooney | but we have been asked to remove any runtim usage of pbr by the pbr maintianers | 14:45 |
| melwitt | ok good to know | 14:46 |
| sean-k-mooney | ill file a bug for that later | 14:46 |
| sean-k-mooney | we are emnt to use import lib metadta or soemthign instead | 14:46 |
| sean-k-mooney | or just stop providing __version__ | 14:46 |
| sean-k-mooney | there was a mail thread about it a month ago or there abouts | 14:46 |
| jgilaber | ack thanks sean-k-mooney we can look at the bug in the next meeting | 14:47 |
| jgilaber | I think I missed this email | 14:47 |
| sean-k-mooney | https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/V7JFTBRA3CHHIWCZM5CM2LE27ESDJHO7/#V7JFTBRA3CHHIWCZM5CM2LE27ESDJHO7 | 14:47 |
| sean-k-mooney | https://review.opendev.org/c/openstack/python-openstackclient/+/987782/2/openstackclient/__init__.py | 14:48 |
| sean-k-mooney | so that the exampel fo what we shoudl do instead | 14:48 |
| jgilaber | seems simple enough | 14:48 |
| sean-k-mooney | ok ill file a bug for that and create a patch later | 14:48 |
| sean-k-mooney | ya pretty much | 14:49 |
| sean-k-mooney | they just would prefer to keep pbr as a build time only tool going forward to limit the maintance | 14:49 |
| jgilaber | thanks for bringing it up sean-k-mooney, anything else on this topic or any other? | 14:51 |
| jgilaber | last thing for today | 14:53 |
| jgilaber | #topic Volunteers to chair next meeting | 14:53 |
| jgilaber | any volunteer? | 14:53 |
| rlandy | I can do it | 14:53 |
| jgilaber | thanks rlandy | 14:54 |
| jgilaber | that is all for today, thanks everyone! | 14:54 |
| jgilaber | #endmeeting | 14:54 |
| opendevmeet | Meeting ended Tue Jun 30 14:54:19 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:54 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.html | 14:54 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.txt | 14:54 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.log.html | 14:54 |
| morenod | thanks!! | 14:54 |
| rlandy | jgilaber++ thank you | 14:54 |
| melwitt | sean-k-mooney: a primer for the API samples testing patch ... I used claude and gave a goal for something much lighter weight than the usual .tpl model. if you hate it let me know and I can try something else | 15:11 |
| sean-k-mooney | i hate our normal model so im sure ill like it :) | 15:12 |
| melwitt | haha well, I have left the hate door open if you need it :) | 15:13 |
| sean-k-mooney | so long term (in like 6-12 months time) i woudl love to not need this because we fully impleitne the OPENAPI schema goal for cybrog | 15:13 |
| melwitt | next in the "plan" is gabbi API tests | 15:14 |
| melwitt | yeah, good point, that takes some of the pressure off | 15:14 |
| sean-k-mooney | i.e. it woudl be nice if the schmea was validate speratly form the sampels which jsut woudl help with docuemtion | 15:14 |
| sean-k-mooney | i need ot start a wider converation on evovling the api | 15:15 |
| melwitt | so openapi does both request and response schemas right? | 15:15 |
| sean-k-mooney | yes | 15:15 |
| sean-k-mooney | if you implemnt both of course | 15:15 |
| melwitt | I mean, should I instead be starting with that? | 15:15 |
| sean-k-mooney | no i think this is low haning fruit | 15:16 |
| sean-k-mooney | and its good to get this in place to have any coverage | 15:16 |
| melwitt | ok cool | 15:16 |
| melwitt | yeah. it found some minor errors | 15:16 |
| sean-k-mooney | but if you wanted to start on that after sure. we should ahve that converstaion about the other api issues that i was hopign to look at next cycle | 15:16 |
| melwitt | well, I guess define "minor" but some parameters that should not have been in the samples and some missing | 15:16 |
| melwitt | nah just wanted to make sure I stay aligned with the wanted plans | 15:17 |
| sean-k-mooney | nope your totally aligned now worries on that front | 15:17 |
| sean-k-mooney | so tempst ahas only ever had scemeas for nova and cindier i belive | 15:17 |
| sean-k-mooney | i woudl perfer to avodi addig them for cybrog and jsut do the openapi feature isntead | 15:17 |
| melwitt | the tempest schemas are so painful in my experience | 15:18 |
| sean-k-mooney | espcially since cybnorg api is small | 15:18 |
| sean-k-mooney | by the way i think one fo the api routes is missing form the api ref | 15:18 |
| melwitt | oh hm | 15:19 |
| sean-k-mooney | https://docs.openstack.org/api-ref/accelerator/#deployables or https://docs.openstack.org/api-ref/accelerator/#devices | 15:19 |
| sean-k-mooney | has a update/program endpoint | 15:19 |
| sean-k-mooney | for programign fpgas | 15:19 |
| sean-k-mooney | i belive it sdeployables via a patch or put | 15:19 |
| melwitt | ok I'll check on it | 15:20 |
| sean-k-mooney | looking at my srbac serise its deployables https://review.opendev.org/c/openstack/cyborg/+/992295/5/cyborg/policies/deployables.py#41 | 15:21 |
| sean-k-mooney | ah and yes PATCH | 15:21 |
| sean-k-mooney | chandan has a chagne up to test that with the fake driver via tempest | 15:22 |
| sean-k-mooney | long term im not conviced that api shoudl exsit but that a sperate matter | 15:23 |
| melwitt | so speaking of the tempest test stuff ... is your pci kernel module thing what we can use to do proper lifecycle coverage? | 15:23 |
| sean-k-mooney | yep | 15:23 |
| melwitt | ok great | 15:23 |
| sean-k-mooney | the emulated device can be passed to the qemu isntance and actully work | 15:23 |
| melwitt | super | 15:23 |
| sean-k-mooney | so the uart is a simple loop back | 15:23 |
| sean-k-mooney | chandan has extened it to emulate nvme ssds | 15:24 |
| sean-k-mooney | i plan ot add nic emualtion evnutlly adn supprot for mdevs | 15:24 |
| sean-k-mooney | so we will be able to emulate all of the devices we manage via the 3 generici driver and in the future htat will allow us to do sriov testing in nova as well if/whewn we want too | 15:25 |
| melwitt | awesome | 15:25 |
| sean-k-mooney | melwitt: i have been holding of adding that to the nova jobs until we are happy with the current feature set and the stableity | 15:25 |
| melwitt | ++ I think that is wise | 15:25 |
| sean-k-mooney | but im thinking of adding it to the new nova-whitebox job | 15:25 |
| melwitt | speaking of that, we need your re-review on https://review.opendev.org/c/openstack/nova/+/898100 to land it | 15:27 |
| sean-k-mooney | its pretty stable form what i can tell and compiling it is fast but i was goign to give it a month or two before goign town that route | 15:27 |
| sean-k-mooney | oh yes cool ill look at that shortly | 15:27 |
| melwitt | yeah ++ for adequate bake time | 15:27 |
| sean-k-mooney | it also currently need debian 13 or ubuntu 26.04 which i dont think that whiteboxc job uses | 15:28 |
| melwitt | oh right | 15:29 |
| sean-k-mooney | so i want to get the whitebox tests running on the cybrog job first | 15:29 |
| sean-k-mooney | and only look at updatign the nova oen after we have all the kinks worked out | 15:29 |
| melwitt | ++ | 15:29 |
| sean-k-mooney | one of the optimisation we need to do for whitebox is use the serial decorator | 15:29 |
| sean-k-mooney | instead of --concurancy=1 | 15:29 |
| sean-k-mooney | i think gmann was consideritng doign that refactor but if not i woudl like to do that before integrating pci-sim into it | 15:30 |
| melwitt | ok so about that | 15:30 |
| melwitt | there is one test in whitebox, a vtpm test, that restarts libvirtd. this is what messes up all ability to use parallel. we need to separate out that test for it to run on its own | 15:31 |
| melwitt | I could work on that actually, I just didn't think about it at the time | 15:32 |
| melwitt | I guess there might be other similar tests in whitebox too. if so, just all of those need to go in their own serial/ directory and run after everything else like normal tempest does | 15:32 |
| gmaan | i have that in my list but I think I will not be able to start that for next 2 weeks, feel free to do it if you can before that | 15:32 |
| melwitt | ah cool :) | 15:33 |
| gmaan | sean-k-mooney: melwitt I was thinking to add it in meeting but missed. as you both are here, please check/test the enforce_scope removal for cyborg, I have proposed the example changes for other projects, melwitt has reviewed the nova/placement one already. https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/436HHMRVNUY3OSXE4ULPQ4P4DSHQEMES/ | 15:35 |
| melwitt | ok cool yes I will look | 15:36 |
| gmaan | thanks | 15:36 |
| gmaan | i can see only a few reference of that but you can add testing change with oslo.policy change and test if anything else other than those few test changes is needed https://github.com/search?q=repo%3Aopenstack%2Fcyborg%20enforce_scope&type=code | 15:38 |
| melwitt | oh yikes the deadline is july 3 | 15:38 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused context properties https://review.opendev.org/c/openstack/cyborg/+/995205 | 15:44 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused context properties https://review.opendev.org/c/openstack/cyborg/+/995205 | 15:46 |
| opendevreview | melanie witt proposed openstack/cyborg master: Fix api-ref inaccuracies and add missing program endpoint https://review.opendev.org/c/openstack/cyborg/+/995533 | 16:02 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused _extract_attributes_v2 https://review.opendev.org/c/openstack/cyborg/+/995534 | 16:02 |
| sean-k-mooney | gmaan: yes i have been folowing that form afar | 16:02 |
| sean-k-mooney | gmaan: basiclly waitign for you and stephen to figure out the way forward | 16:03 |
| gmaan | sean-k-mooney: ack, thanks | 16:03 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused method for image v1 API https://review.opendev.org/c/openstack/cyborg/+/995534 | 16:03 |
| sean-k-mooney | gmaan: so i need to remove my overried where i explicly default that to true | 16:03 |
| sean-k-mooney | but i wrote teh securigy bug fixes assuming the enfoce scope | 16:04 |
| gmaan | yes, true or false, basically all usage of enforce_scope | 16:04 |
| sean-k-mooney | and that whaat my srbac serise is built around as well | 16:04 |
| gmaan | enforce_new_defaults stay same to toggle the old/new defaults but not the scope | 16:04 |
| sean-k-mooney | yep | 16:04 |
| sean-k-mooney | ill tack a patch on the end of my srbac serise to drop our usage | 16:05 |
| sean-k-mooney | gmaan: im hopign to merge that this week as well | 16:05 |
| gmaan | ++ | 16:06 |
| sean-k-mooney | melwitt: sorry was on a call | 16:06 |
| sean-k-mooney | melwitt: so there are a couple of whitebox tests that restart the agent | 16:06 |
| sean-k-mooney | melwitt: we used ot have test that reconfigre the nova.conf setting to test spefic feature that were mutally exclivie | 16:07 |
| sean-k-mooney | so for vtpm ya there is one that need special handleing but the test for offliniing cpus and some fo the pining test used to restart agents too | 16:07 |
| melwitt | yeah | 16:08 |
| sean-k-mooney | so if you have time to work on making whitebox work with the serial decorator that woudl be cool | 16:08 |
| sean-k-mooney | but no pressure either way | 16:08 |
| sean-k-mooney | my current plan is wrap up srbac this week. then finish the pci-mangege mode work in then 1-2 weeks and then loook at addign whitebox tests | 16:09 |
| sean-k-mooney | so if you get to it before the end fo the month the cool | 16:09 |
| sean-k-mooney | if not ill look at it in august | 16:10 |
| sean-k-mooney | *end of the month being july | 16:10 |
| sean-k-mooney | im happy with the simple lifecyle test i have that ssh into the vm and run lspci are enouch for the pci driver testing im using right now. but i want to add a whitebox test that will check the xml actuly has manged=no later | 16:11 |
| sean-k-mooney | i also verifyed it on real hardware. turns out if managed mode is not set with an l4 booting a vm will hard reboot the host which was fun to debug | 16:12 |
| sean-k-mooney | so nvidia still have not fixed that kernel bug :) | 16:12 |
| sean-k-mooney | the pci-sim wont crash the same way | 16:13 |
| melwitt | oh wow hah | 16:17 |
| sean-k-mooney | we have a note about that in the nova docs | 16:25 |
| sean-k-mooney | it really really shoudl not happen | 16:26 |
| sean-k-mooney | but ya i was like why is my ssh conenction droping when i boot a vm | 16:26 |
| sean-k-mooney | host reboot will do that :) | 16:26 |
| melwitt | crazy haha | 16:38 |
| opendevreview | melanie witt proposed openstack/cyborg master: Fix api-ref inaccuracies and add missing program endpoint https://review.opendev.org/c/openstack/cyborg/+/995533 | 16:46 |
| opendevreview | Takashi Kajinami proposed openstack/cyborg master: Remove unused context properties https://review.opendev.org/c/openstack/cyborg/+/995205 | 17:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg-specs master: Add generic mdev driver spec for 2026.2 https://review.opendev.org/c/openstack/cyborg-specs/+/982276 | 17:28 |
| opendevreview | melanie witt proposed openstack/cyborg master: Add C300 hacking check for set literal in logging calls https://review.opendev.org/c/openstack/cyborg/+/995561 | 18:15 |
| opendevreview | melanie witt proposed openstack/cyborg master: Add C300 hacking check for set literal in logging calls https://review.opendev.org/c/openstack/cyborg/+/995561 | 18:38 |
| sean-k-mooney | melwitt: i goign to cal lit a day but i jsut re reviewd the hackign check and i was incorrect about removig pycodestyle | 20:52 |
| sean-k-mooney | just pushed updated comemnts | 20:52 |
| melwitt | sean-k-mooney: ok cool thanks. I was just having the same confusion :) | 20:54 |
| sean-k-mooney | i didnt realsie you were using it in the unit test | 20:55 |
| sean-k-mooney | so its a driect depency of the unit tests so you were right | 20:56 |
| sean-k-mooney | and ya i have not seen teim recommend addign teh liscen here to the __init__.py | 20:56 |
| sean-k-mooney | im not sure if that is becaue i just updated the model | 20:56 |
| sean-k-mooney | or if its a chagne i hacking | 20:56 |
| sean-k-mooney | but ya with the current hackign setting that is an error ill correct that | 20:56 |
| sean-k-mooney | teim-ci will read HACKING.rst or AGENTS.md if they are present | 20:57 |
| melwitt | ah ok | 20:57 |
| sean-k-mooney | so i can add a note in HACKING.rst about that | 20:58 |
| sean-k-mooney | or tweak its prompt for this edgecase | 20:58 |
| sean-k-mooney | ok chat to you tomorrow o/ | 20:58 |
| melwitt | cool thanks, seeya tomorrow o/ | 20:59 |
| opendevreview | melanie witt proposed openstack/cyborg master: Add C300 hacking check for set literal in logging calls https://review.opendev.org/c/openstack/cyborg/+/995561 | 21:42 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!