| opendevreview | chandan kumar proposed openstack/cyborg master: Fix microversion header parsing for service type prefix https://review.opendev.org/c/openstack/cyborg/+/994574 | 09:09 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/cyborg-tempest-plugin master: Add Cyborg PCI driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 | 09:17 |
| opendevreview | Joan Gilabert proposed openstack/cyborg-tempest-plugin master: Add Cyborg MDEV driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997352 | 10:08 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 10:41 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Enable pci lifecycle test in cyborg tempest job https://review.opendev.org/c/openstack/cyborg/+/997365 | 10:45 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 10:48 |
| opendevreview | Joan Gilabert proposed openstack/cyborg-tempest-plugin master: Add Cyborg MDEV driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997352 | 11:20 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 11:21 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 12:02 |
| opendevreview | chandan kumar proposed openstack/cyborg-tempest-plugin master: Add Cyborg PCI driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 | 12:57 |
| chandankumar | jgilaber: Hello, on pci life cycle test, I rewrote the get_headers method https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580/6/cyborg_tempest_plugin/services/cyborg_rest_client.py after https://github.com/openstack/cyborg-tempest-plugin/commit/0722965e6755d9c28f530d3d1a4b5e0d97e39c91 got merged | 12:58 |
| chandankumar | Now tempest tests will work | 12:58 |
| jgilaber | ack thanks chandankumar will take a look | 13:07 |
| opendevreview | Joan Gilabert proposed openstack/cyborg-tempest-plugin master: Add Cyborg MDEV driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997352 | 13:10 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 13:12 |
| sean-k-mooney | chandankumar: i have not looked but i would not be surprised if tempest base client had native supprot for microverions | 13:57 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 14:42 |
| chandankumar | sean-k-mooney: I checked the tempest repo and each of the service client have their own microversion implementation | 14:46 |
| chandankumar | https://github.com/openstack/tempest/blob/48141b5d7a1377cc4bd5e779c6e6355663fe816d/tempest/lib/services/compute/base_compute_client.py#L39 | 14:46 |
| chandankumar | https://github.com/openstack/tempest/blob/48141b5d7a1377cc4bd5e779c6e6355663fe816d/tempest/lib/services/placement/base_placement_client.py#L26 | 14:46 |
| chandankumar | yes and you are correct | 14:48 |
| sean-k-mooney | ok cool so what your propsoing is effectivly the same | 15:00 |
| sean-k-mooney | or at least very similar | 15:00 |
| sean-k-mooney | its directly adding the header when needed rather then passign it as a parmater to the cleints post or get method ectra | 15:01 |
| sean-k-mooney | hum | 15:05 |
| sean-k-mooney | but they do not have good exampel of using diffent microverion fo ra specific call | 15:05 |
| sean-k-mooney | they are mearly setting the min version at the class level | 15:05 |
| sean-k-mooney | so that not ideal | 15:05 |
| opendevreview | chandan kumar proposed openstack/cyborg-tempest-plugin master: Add Cyborg PCI driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 | 15:25 |
| opendevreview | chandan kumar proposed openstack/cyborg master: Enable pci lifecycle test in cyborg tempest job https://review.opendev.org/c/openstack/cyborg/+/997365 | 15:26 |
| chandankumar | I have updated the tempest plugin review with cyborg_pci config section | 15:26 |
| chandankumar | will check results tomorrow o/ | 15:28 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 16:05 |
| opendevreview | Merged openstack/cyborg master: Remove unused image utilities https://review.opendev.org/c/openstack/cyborg/+/995534 | 17:01 |
| opendevreview | Merged openstack/cyborg master: Fix microversion header parsing for service type prefix https://review.opendev.org/c/openstack/cyborg/+/994574 | 18:19 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!