| opendevreview | Joan Gilabert proposed openstack/cyborg-tempest-plugin master: Add Cyborg MDEV driver lifecycle scenario tests https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997352 | 06:44 |
|---|---|---|
| opendevreview | Joan Gilabert proposed openstack/cyborg-tempest-plugin master: Prefer lspci over sysfs for PCI device detection https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997684 | 06:44 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Configure pci lifecycle tempest settings via devstack plugin https://review.opendev.org/c/openstack/cyborg/+/997365 | 06:45 |
| *** jgilaber_ is now known as jgilaber | 10:02 | |
| jgilaber | sean-k-mooney Hi! I've pushed a patch to change how we check for pci devices in guest vms https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/997684 to prefer using lspci | 10:03 |
| jgilaber | I've tested the change in https://review.opendev.org/c/openstack/cyborg/+/997364 and https://review.opendev.org/c/openstack/cyborg/+/997365 multiple times and seems to work well | 10:03 |
| sean-k-mooney | cool | 10:04 |
| sean-k-mooney | were you able ot replciate the failure locally? | 10:04 |
| jgilaber | I've run the tests at lest 8 times between yesterday and today | 10:04 |
| jgilaber | no I have not tested that | 10:04 |
| sean-k-mooney | well im more askign did you see it fail | 10:04 |
| jgilaber | only on ci | 10:04 |
| sean-k-mooney | i have not seen the older verion fail locally either | 10:05 |
| sean-k-mooney | ack ok well we can recheck it a few times | 10:05 |
| jgilaber | yes, we can recheck it a few times more today and check back towards eod or next week | 10:05 |
| jgilaber | I will try it locally as well | 10:05 |
| sean-k-mooney | cool the change looks good | 10:06 |
| sean-k-mooney | out of inteest did we looks at how we do this in whitebox | 10:06 |
| sean-k-mooney | https://opendev.org/openstack/whitebox-tempest-plugin/src/commit/a464d48e5e517ac8e4d04ca72b25042067abcb31/whitebox_tempest_plugin/api/compute/test_sriov.py#L862 | 10:07 |
| sean-k-mooney | so ya def _check_device_in_guest(self, linux_client, vendor_id, product_id): | 10:08 |
| sean-k-mooney | is doing cmd = "lspci -nn | grep {0}:{1} | wc -l".format( | 10:08 |
| sean-k-mooney | vendor_id, product_id) | 10:08 |
| sean-k-mooney | we may wantt to condier just porting that function as this has been sabel but its usign lspci as well | 10:08 |
| sean-k-mooney | so thats good at least | 10:09 |
| jgilaber | very similar | 10:09 |
| sean-k-mooney | so we dont technially need the fall back | 10:09 |
| sean-k-mooney | well | 10:09 |
| jgilaber | I've left the current approach as fallback but we could remove it to simplify maybe | 10:09 |
| sean-k-mooney | lspci is expected to be installled in the ci image | 10:09 |
| sean-k-mooney | for now i think we can keep it but we might simplfy this in a followup | 10:10 |
| sean-k-mooney | i kind of like that _check_device_in_guest is doing the filstering on the vm rather then copying back all the data | 10:10 |
| jgilaber | sounds good to me | 10:11 |
| jgilaber | I've been running the version of the tests in master which failed yesterday but could not reproduce the problem either | 11:38 |
| jgilaber | I've run them 6 or 7 time nows, it's quite weird that it seemed so consistent yesterday | 11:38 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!