| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add per-PF vf_personality sysfs interface https://review.opendev.org/c/openstack/cyborg/+/998603 | 10:36 |
|---|---|---|
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Enable database migration tests with mysql https://review.opendev.org/c/openstack/cyborg/+/997979 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add MDEV and PCI device type constants https://review.opendev.org/c/openstack/cyborg/+/997047 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add MdevBusManager for mdev bus discovery https://review.opendev.org/c/openstack/cyborg/+/997048 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add [mdev] configuration section https://review.opendev.org/c/openstack/cyborg/+/997049 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add generic mdev driver https://review.opendev.org/c/openstack/cyborg/+/997050 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add duplicate device warning in conductor https://review.opendev.org/c/openstack/cyborg/+/997051 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Refactor GPU driver to use MdevBusManager https://review.opendev.org/c/openstack/cyborg/+/997052 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add generic mdev driver documentation https://review.opendev.org/c/openstack/cyborg/+/997053 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim kernel module https://review.opendev.org/c/openstack/cyborg/+/997054 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim DevStack plugin https://review.opendev.org/c/openstack/cyborg/+/997055 | 10:36 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 10:36 |
| rlandy | sean-k-mooney: hello - finally starting on the documentation ... starting with the drivers support: https://github.com/openstack/cyborg/blob/master/doc/source/reference/driver-table.rst unless you suggest another area to begin | 11:58 |
| sean-k-mooney | rlandy: no thats as good a place as any | 12:02 |
| rlandy | ack | 12:02 |
| sean-k-mooney | for now all driver expcpt fake and pci shoudl go to experimental, we now have tempest tests and some docs for the pci driver so we can consirite supported | 12:02 |
| sean-k-mooney | some of the deriver we may deciedn to make depercated but we can discuss that in the review | 12:03 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: add NVMe 1.4 controller emulation with host visibility https://review.opendev.org/c/openstack/cyborg/+/995079 | 13:06 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: add NVMe 1.4 controller emulation with host visibility https://review.opendev.org/c/openstack/cyborg/+/995079 | 13:07 |
| opendevreview | Ronelle Landy proposed openstack/cyborg master: Inline driver table into support-matrix.rst https://review.opendev.org/c/openstack/cyborg/+/999116 | 13:36 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: introduce personality ops-table dispatch for VF device types https://review.opendev.org/c/openstack/cyborg/+/999125 | 14:01 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: add NVMe 1.4 controller ops-table personality https://review.opendev.org/c/openstack/cyborg/+/999126 | 14:01 |
| opendevreview | Gihong Lee proposed openstack/cyborg master: Add shared lspci helpers to common utils https://review.opendev.org/c/openstack/cyborg/+/998726 | 14:31 |
| opendevreview | Gihong Lee proposed openstack/cyborg master: Migrate accelerator drivers to shared lspci helpers https://review.opendev.org/c/openstack/cyborg/+/998817 | 14:31 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: add NVMe 1.4 controller emulation with host visibility https://review.opendev.org/c/openstack/cyborg/+/995079 | 14:36 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: introduce personality ops-table dispatch for VF device types https://review.opendev.org/c/openstack/cyborg/+/999125 | 15:07 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: add NVMe 1.4 controller ops-table personality https://review.opendev.org/c/openstack/cyborg/+/999126 | 15:07 |
| chandankumar | jgilaber: sean-k-mooney Hello, Based on https://gistpreview.github.io/?9cf18df5754db0948330f0cc5110c652 using static ops table , I have also pushed the poc with nvme https://review.opendev.org/q/topic:%22opstable%22 | 15:09 |
| chandankumar | jgilaber: I have also updated my existing nvme implementation based on your vf personality https://review.opendev.org/c/openstack/cyborg/+/995079 | 15:10 |
| chandankumar | Feel free to take a look, which ever we decide, I will update the change based on that | 15:11 |
| chandankumar | for opstable approach, I have only refactored the existing code and update the previous nvme implementation to that | 15:12 |
| jgilaber | thanks chandankumar I'll take a look at the static ops table patch | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add per-PF vf_personality sysfs interface https://review.opendev.org/c/openstack/cyborg/+/998603 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Enable database migration tests with mysql https://review.opendev.org/c/openstack/cyborg/+/997979 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add MDEV and PCI device type constants https://review.opendev.org/c/openstack/cyborg/+/997047 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add MdevBusManager for mdev bus discovery https://review.opendev.org/c/openstack/cyborg/+/997048 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add [mdev] configuration section https://review.opendev.org/c/openstack/cyborg/+/997049 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add generic mdev driver https://review.opendev.org/c/openstack/cyborg/+/997050 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add duplicate device warning in conductor https://review.opendev.org/c/openstack/cyborg/+/997051 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Refactor GPU driver to use MdevBusManager https://review.opendev.org/c/openstack/cyborg/+/997052 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add generic mdev driver documentation https://review.opendev.org/c/openstack/cyborg/+/997053 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim kernel module https://review.opendev.org/c/openstack/cyborg/+/997054 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim DevStack plugin https://review.opendev.org/c/openstack/cyborg/+/997055 | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 15:19 |
| jgilaber | chandankumar, IIUC your patch https://review.opendev.org/c/openstack/cyborg/+/999125 is building an abstraction for the persionality that my patch introduces, correct? | 15:32 |
| chandankumar | jgilaber: yes correct | 15:38 |
| chandankumar | let me fix the chain to make it clear | 15:38 |
| sean-k-mooney | ya so i had planed ot work on this all next cycle, but because we had to pivot on the testign stragy for both the nvme and mdev driver we now hve 2.5 competing desings for htis although we are converging | 16:07 |
| sean-k-mooney | jgilaber: you have start on the sysfs part and chandan has started on the abstraction layer which is good | 16:07 |
| sean-k-mooney | the uart/serial was intened to be just one of many device the similator supproted | 16:08 |
| sean-k-mooney | so seperatign that out into pci-sim/fake_pci_sriov_uart.c is inlien with that vission | 16:09 |
| sean-k-mooney | althought he same feedback still aplies i woudl prefer to avoid a defautl personality | 16:11 |
| sean-k-mooney | or default to a sential that you have to update before you can allocate the vfs | 16:11 |
| sean-k-mooney | the uart was my strating pont to prove the concept not the end goal so we shoudl not make it a special default type | 16:12 |
| jgilaber | I see, it took me a bit, just wanted to make sure I got it right, reading C is a bit harder than python :) | 16:13 |
| sean-k-mooney | i have only skimed it so im not sure it has the right shape yet | 16:14 |
| jgilaber | in my patch I moved the default to a 'unset', so that should carry into chandas patch once he rebases on top of mine | 16:14 |
| sean-k-mooney | yep | 16:14 |
| sean-k-mooney | i had orgianlly planend ot spend a month or so workign on this my self for what it worth after FF | 16:15 |
| sean-k-mooney | i did the iniall high levle planign fo rhow tot evolve the framework but defered it to keep scope small for v1 | 16:16 |
| sean-k-mooney | so we havenet really had time to talk about that or spec it out | 16:16 |
| sean-k-mooney | if we had not change our testing plan | 16:17 |
| sean-k-mooney | this was going to be somethign i teed up for the next ptg | 16:17 |
| jgilaber | yes a PTG session would have been quite useful | 16:18 |
| jgilaber | I realize there are a few things that I assumed worked in some way and was wrong | 16:18 |
| sean-k-mooney | i think we can actully just do some one off desing session on this as open to everyone calls | 16:19 |
| jgilaber | that might be helpful, yes | 16:19 |
| sean-k-mooney | but what also going to impornat is making sure we docudment the desgin and rational in the contibutor docs | 16:19 |
| sean-k-mooney | one thing im also thinking about | 16:22 |
| sean-k-mooney | is the bash scritp testing i initally didn was jsut to have some testing | 16:23 |
| sean-k-mooney | i want to eventually replace that with pyton based test in a new validation or other named test suite | 16:23 |
| sean-k-mooney | pubally still under the pci-sim folder | 16:24 |
| sean-k-mooney | but long term i want to move awasy form jsut bash script to something more maintianable | 16:25 |
| sean-k-mooney | i havent really tought oo much abotu that but im remineid fo it when i start seeign lots of similar code in one of script files | 16:26 |
| sean-k-mooney | so even if we keep it in bash woudl liek to move more toward devstack style bash with shared resuabel fucntions but ya i have nto really said that outload before | 16:26 |
| sean-k-mooney | im glad you and chandan have start contibuting ot extending the pci-sim i just was not expecting ye too this cycle so i tought i woudl have time to do that cleanup before then | 16:28 |
| jgilaber | yes, most of the code in those scripts is duplicated | 16:28 |
| jgilaber | it's great to have it to test, but I found it a lot harder to work on | 16:29 |
| jgilaber | AI has been really useful for this | 16:29 |
| sean-k-mooney | yep, it will get eaiser once alot of the strucre is put in palce and more of the context on how it was intedned to work and be extened is wirten down | 16:29 |
| jgilaber | although I'm less confident on its output since I have a harder time reviewing | 16:30 |
| sean-k-mooney | but i agree ai has been makign building this type of test infra much more practical | 16:30 |
| jgilaber | at least it seems functional | 16:30 |
| sean-k-mooney | im undecieded if i still want to eventually look at upstreamign this to the linux kernel | 16:31 |
| sean-k-mooney | im sure they woudl have lots of clear and valudable feedback | 16:32 |
| jgilaber | it would probably quite a bit of work as well I guess | 16:32 |
| jgilaber | depending on how we've diverged from the kernel style | 16:32 |
| sean-k-mooney | ya its nto a discieon to make lightly or one we have to make in the near term | 16:33 |
| sean-k-mooney | for me i think the cost of upstream is not warrented until we have something stable that we have provien to work for the usecase we intent to test | 16:34 |
| sean-k-mooney | if in a cycle or two we find we do not need to extend it much and its stable we could start that conversation | 16:34 |
| sean-k-mooney | its much easier to start a conversation by "hey we built this thing that we find useful and would like to share it to see if its useful to the kernel comunity too" | 16:36 |
| jgilaber | I imagine it would be useful for many people | 16:38 |
| jgilaber | since there does not seem to be many solutions out there | 16:38 |
| jgilaber | or very limited ones like the mtty module | 16:38 |
| opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: introduce personality ops-table dispatch for VF device types https://review.opendev.org/c/openstack/cyborg/+/999125 | 17:23 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim kernel module https://review.opendev.org/c/openstack/cyborg/+/997054 | 17:35 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: Add mdev support to pci-sim DevStack plugin https://review.opendev.org/c/openstack/cyborg/+/997055 | 17:35 |
| opendevreview | Joan Gilabert proposed openstack/cyborg master: [WIP] Configure mdev driver lifecycle tests https://review.opendev.org/c/openstack/cyborg/+/997364 | 17:35 |
| opendevreview | melanie witt proposed openstack/cyborg master: Enable port_device_profile ML2 extension driver for NIC drivers https://review.opendev.org/c/openstack/cyborg/+/998055 | 18:56 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!