| *** bsza has joined #openstack-dev | 00:01 | |
| vishy | jeblair: ping | 00:11 |
|---|---|---|
| jeblair | vishy: pong | 00:11 |
| vishy | hey so odd question | 00:11 |
| vishy | say i have two reviews where one depends on another | 00:11 |
| vishy | and they are two separate commits | 00:12 |
| vishy | if i amend the first commit to address review stuff | 00:12 |
| vishy | will i have to redo the second review via cherry-pick for it to merge properly? | 00:12 |
| vishy | jeblair: ^^ | 00:13 |
| jeblair | i _believe_ that you would at least want to re-base the second onto the first | 00:13 |
| openstackgerrit | Verification of a change to openstack/horizon failed: Added sanity checks and environment versioning to run_tests.sh. https://review.openstack.org/1475 | 00:14 |
| vishy | jeblair: that is what i though | 00:14 |
| vishy | jeblair: but i wasn't sure | 00:14 |
| Kiall | Heya - QQ re VLAN networking, I've noticed that once a floating IP is assigned to an instance, it can no longer talk to other nodes on its VLAN via their private IPs.. Is this normal? | 00:14 |
| mtaylor | jeblair, vishy: I think you will need to cherry pick rather than rebase | 00:14 |
| jeblair | i _assume_ that if you didn't then the dependency would never be satisfied | 00:14 |
| *** nati2 has quit IRC | 00:14 | |
| jeblair | mtaylor: why? | 00:14 |
| vishy | Kiall: hmm i haven't noticed that | 00:14 |
| mtaylor | because the history of the second commit will still have the prior version of the first commit, so it'll try to rebase _both_ commits on to the new first commit | 00:15 |
| mtaylor | which is not what is wanted | 00:15 |
| vishy | mtaylor: i was cherry-picking but i thought rebase does the same thing? | 00:15 |
| Kiall | vishy, it was the other day when I was testing .. Not actually sure it happens when both instances are on the same node.. | 00:15 |
| vishy | mtaylor: interesting | 00:15 |
| openstackgerrit | Verification of a change to openstack/horizon failed: Added sanity checks and environment versioning to run_tests.sh. https://review.openstack.org/1475 | 00:15 |
| vishy | Kiall: i have noticed that you can't necessarily use the public ip from other instances | 00:15 |
| *** nati2 has joined #openstack-dev | 00:15 | |
| vishy | Kiall: but afaik the private should still work | 00:15 |
| mtaylor | vishy: it's close - but the history story would be slightly different in this case, since you're creating a new commit out from under the old one, which means that you need to surgically remove the parent of the second commit | 00:15 |
| openstackgerrit | Verification of a change to openstack/horizon failed: Added sanity checks and environment versioning to run_tests.sh. https://review.openstack.org/1475 | 00:16 |
| Kiall | vishy, really? The public IPs worked fine for me -_- | 00:16 |
| vishy | Kiall: i know the issue | 00:16 |
| vishy | Kiall: it depends on whether you have set dmz_cidr to include the private range or not | 00:16 |
| vishy | if it includes the private range than privates should work, but publics probably won't | 00:17 |
| *** bsza-I has joined #openstack-dev | 00:17 | |
| vishy | otherwise the reverse | 00:17 |
| Kiall | Ah okay.. Kind of a pain then ;) | 00:17 |
| *** Guest79151 is now known as med_out | 00:18 | |
| *** med_out has joined #openstack-dev | 00:18 | |
| *** bsza has quit IRC | 00:20 | |
| *** novas0x2a|laptop has quit IRC | 00:25 | |
| *** dtroyer has quit IRC | 00:25 | |
| *** astinus has joined #openstack-dev | 00:31 | |
| *** astinus has left #openstack-dev | 00:31 | |
| openstackgerrit | Gabriel Hurley proposed a change to openstack/horizon: Added sanity checks and environment versioning to run_tests.sh. https://review.openstack.org/1475 | 00:34 |
| *** zns1 has quit IRC | 00:35 | |
| *** novas0x2a|laptop has joined #openstack-dev | 00:36 | |
| *** dragondm has quit IRC | 00:38 | |
| *** novas0x2a|laptop has quit IRC | 00:38 | |
| *** mszilagyi has quit IRC | 00:40 | |
| *** mwhooker_ has joined #openstack-dev | 00:40 | |
| *** mwhooker_ has quit IRC | 00:40 | |
| *** adjohn has joined #openstack-dev | 00:43 | |
| *** mwhooker has quit IRC | 00:44 | |
| *** jakedahn has quit IRC | 00:47 | |
| *** negronjl has quit IRC | 00:48 | |
| *** statik has joined #openstack-dev | 01:14 | |
| *** novas0x2a|laptop has joined #openstack-dev | 01:21 | |
| *** lorin1 has quit IRC | 01:22 | |
| *** lorin1 has joined #openstack-dev | 01:22 | |
| *** lorin1 has left #openstack-dev | 01:23 | |
| *** bsza-I has quit IRC | 01:24 | |
| *** lorin1 has joined #openstack-dev | 01:26 | |
| *** sleepsontheflo-1 has joined #openstack-dev | 01:29 | |
| *** reed has quit IRC | 01:40 | |
| *** dwalleck has joined #openstack-dev | 01:42 | |
| openstackgerrit | Dan Prince proposed a change to openstack/glance: Update 'glance show' to print a valid URI. Fixes bug #888370. https://review.openstack.org/1485 | 01:48 |
| uvirtbot | Launchpad bug 888370 in glance "glance show prints invalid URI" [Low,In progress] https://launchpad.net/bugs/888370 | 01:48 |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Gracefully handle image_cache_dir being undefined https://review.openstack.org/1486 | 01:49 |
| *** jakedahn has joined #openstack-dev | 01:55 | |
| *** bhall has quit IRC | 02:04 | |
| *** jdurgin has quit IRC | 02:17 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Adding tests to check 'glance show <ID>' format https://review.openstack.org/1487 | 02:17 |
| openstackgerrit | Brian Waldon proposed a change to openstack/openstack-chef: Changing image_cache_datadir to image_cache_dir https://review.openstack.org/1488 | 02:20 |
| openstackgerrit | Brian Waldon proposed a change to openstack/openstack-chef: Updating OSAPI module paths for Admin API split https://review.openstack.org/1126 | 02:20 |
| *** novas0x2a|laptop has quit IRC | 02:21 | |
| *** rods has quit IRC | 02:26 | |
| *** vladimir3p has quit IRC | 02:27 | |
| *** novas0x2a|laptop has joined #openstack-dev | 02:29 | |
| *** gyee has quit IRC | 02:32 | |
| *** novas0x2a|laptop has quit IRC | 02:32 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/openstack-chef: Updating Nova paste config with lazy serialization https://review.openstack.org/1125 | 02:41 |
| *** bsza has joined #openstack-dev | 03:15 | |
| *** nati2_ has joined #openstack-dev | 03:29 | |
| *** nati2 has quit IRC | 03:32 | |
| *** stuntmachine has joined #openstack-dev | 03:33 | |
| *** bsza has quit IRC | 03:37 | |
| *** bsza has joined #openstack-dev | 03:37 | |
| *** lorin1 has quit IRC | 03:56 | |
| openstackgerrit | Joe Gordon proposed a change to openstack/nova: More spelling fixes inside of nova https://review.openstack.org/1477 | 03:57 |
| *** jog0 has quit IRC | 04:01 | |
| openstackjenkins | Project nova-docs build #1,610: SUCCESS in 2 min 13 sec: https://jenkins.openstack.org/job/nova-docs/1610/ | 04:03 |
| openstackjenkins | Rick Harris: Adding Chuck Short to .mailmap | 04:03 |
| *** mmetheny has quit IRC | 04:08 | |
| openstackjenkins | Project nova-docs build #1,611: SUCCESS in 2 min 13 sec: https://jenkins.openstack.org/job/nova-docs/1611/ | 04:08 |
| openstackjenkins | Kevin L. Mitchell: Get MAC addresses from Melange. | 04:08 |
| *** mmetheny has joined #openstack-dev | 04:09 | |
| openstackgerrit | A change to openstack/nova has been rejected: Udpate the email contact in Author file. https://review.openstack.org/1457 | 04:12 |
| openstackjenkins | Project nova-docs build #1,612: SUCCESS in 2 min 17 sec: https://jenkins.openstack.org/job/nova-docs/1612/ | 04:18 |
| openstackjenkins | Derek Higgins: Undefine libvirt saved instances | 04:18 |
| openstackjenkins | Project nova-docs build #1,613: SUCCESS in 2 min 16 sec: https://jenkins.openstack.org/job/nova-docs/1613/ | 04:23 |
| openstackjenkins | Chuck Short: Replace socat with netcat. | 04:23 |
| *** nati2 has joined #openstack-dev | 04:24 | |
| *** nati2_ has quit IRC | 04:24 | |
| *** rohitk has joined #openstack-dev | 04:27 | |
| *** stuntmachine has quit IRC | 04:31 | |
| openstackjenkins | Project nova-docs build #1,614: SUCCESS in 2 min 21 sec: https://jenkins.openstack.org/job/nova-docs/1614/ | 04:33 |
| openstackjenkins | jogo: More spelling fixes inside of nova | 04:33 |
| *** rohit-karajgi has joined #openstack-dev | 04:33 | |
| openstackgerrit | Brian Lamar proposed a change to openstack/nova: Refactoring/cleanup of some view builders. https://review.openstack.org/1324 | 04:34 |
| *** rohitk has quit IRC | 04:34 | |
| *** rohit-karajgi has quit IRC | 04:42 | |
| *** rohitk has joined #openstack-dev | 04:43 | |
| *** bsza-I has joined #openstack-dev | 04:49 | |
| *** bsza has quit IRC | 04:50 | |
| *** bsza-I has quit IRC | 05:01 | |
| *** bhall has joined #openstack-dev | 05:07 | |
| *** bhall has joined #openstack-dev | 05:07 | |
| *** blamar has quit IRC | 05:11 | |
| *** bsza has joined #openstack-dev | 05:14 | |
| *** AlanClark has quit IRC | 05:16 | |
| *** rohit-karajgi has joined #openstack-dev | 05:34 | |
| *** bsza has quit IRC | 05:35 | |
| *** rohitk has quit IRC | 05:35 | |
| *** dwalleck has quit IRC | 05:54 | |
| *** dwalleck has joined #openstack-dev | 05:55 | |
| *** zaitcev has quit IRC | 05:56 | |
| *** zedas has quit IRC | 05:56 | |
| *** zedas has joined #openstack-dev | 06:00 | |
| *** chmouel_ has joined #openstack-dev | 06:02 | |
| *** statik has quit IRC | 06:02 | |
| *** jeffjapan has quit IRC | 06:02 | |
| *** chmouel has quit IRC | 06:02 | |
| *** n0ano has quit IRC | 06:02 | |
| *** n0ano has joined #openstack-dev | 06:02 | |
| *** jeffjapan has joined #openstack-dev | 06:02 | |
| *** pvo has quit IRC | 06:02 | |
| *** pvo has joined #openstack-dev | 06:03 | |
| *** markmc has joined #openstack-dev | 06:07 | |
| *** dwalleck has quit IRC | 06:09 | |
| openstackjenkins | Project nova-docs build #1,615: SUCCESS in 2 min 16 sec: https://jenkins.openstack.org/job/nova-docs/1615/ | 06:18 |
| openstackjenkins | yorik.sar: Fix exception reraising in volume manager. | 06:18 |
| openstackgerrit | Neil Johnston proposed a change to openstack/horizon: blueprint: improve-user-experience Bug #884453 Ensured branding is contained and can't escape sidebar space/break layout by adding a CSS style #main_nav h1. This bounds the branding area and disables overflow. Additionally padding ot the right is adjueste https://review.openstack.org/1489 | 06:21 |
| uvirtbot | Launchpad bug 884453 in horizon "UX Improvements: Sidebar - Ensure branding is contained (can't escape sidebar space/break layout)" [Low,Confirmed] https://launchpad.net/bugs/884453 | 06:21 |
| openstackjenkins | Project nova-docs build #1,616: SUCCESS in 2 min 19 sec: https://jenkins.openstack.org/job/nova-docs/1616/ | 06:58 |
| openstackjenkins | Jason K?lker: Fixes LP878319 | 06:58 |
| *** johan_-_ has quit IRC | 07:00 | |
| *** Rajaram has joined #openstack-dev | 07:09 | |
| *** bhall has quit IRC | 07:14 | |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: nova-manage: exit with status 1 if an image registration fails https://review.openstack.org/1490 | 07:26 |
| *** nati2_ has joined #openstack-dev | 07:27 | |
| *** nati2 has quit IRC | 07:30 | |
| *** adjohn has quit IRC | 07:38 | |
| *** jeffjapan has quit IRC | 07:41 | |
| *** adjohn has joined #openstack-dev | 07:46 | |
| ttx | vishy: pong | 07:51 |
| *** adjohn has quit IRC | 08:06 | |
| *** mnour has joined #openstack-dev | 08:24 | |
| *** reidrac has joined #openstack-dev | 08:28 | |
| *** pixelbeat has joined #openstack-dev | 09:01 | |
| *** jakedahn has quit IRC | 09:06 | |
| *** sleepsontheflo-1 has quit IRC | 09:19 | |
| *** jakedahn has joined #openstack-dev | 09:23 | |
| *** darraghb has joined #openstack-dev | 09:43 | |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend fake image service to let it hold image data https://review.openstack.org/1491 | 09:49 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend test_virt_driver to also test libvirt driver. https://review.openstack.org/1043 | 09:49 |
| *** ABK has joined #openstack-dev | 09:53 | |
| *** statik has joined #openstack-dev | 10:02 | |
| *** statik has joined #openstack-dev | 10:02 | |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Verify security group parameters https://review.openstack.org/815 | 10:06 |
| soren | markmc: Are you around? | 10:09 |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Verify security group parameters https://review.openstack.org/1492 | 10:10 |
| soren | markmc: I'm reading that e-mail of yours. I don't really understand the last bit where you talk about making sure tests pass at each individual commit. | 10:12 |
| soren | markmc: There seems to be a setup step missing. | 10:12 |
| soren | markmc: Are you perhaps running "rebase -i" and then setting each commit to "edit"? | 10:12 |
| soren | markmc: Otherwise I don't see how "rebase --continue" won't just apply the rest of the patches. | 10:13 |
| soren | test_spawn_with_network_info OK 217.43 | 10:20 |
| soren | *stab* | 10:20 |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Verify security group parameters https://review.openstack.org/815 | 10:23 |
| soren | Oh, my goodness. | 10:38 |
| soren | So you can actually spend a lot of time and care making sure your patch works great.. then you run "git review" which rebases your patch, potentially completely breaking it, and push it to gerrit making you look like a complete arse. *ggrrrrr* | 10:40 |
| *** nati2_ has quit IRC | 10:43 | |
| zykes- | soren: can one make live changes to a security group and it will be applied asap ? | 10:46 |
| *** jakedahn_ has joined #openstack-dev | 11:03 | |
| soren | zykes-: yES. | 11:03 |
| soren | Yes, even. | 11:04 |
| openstackgerrit | Thierry Carrez proposed a change to openstack/openstack-ci-puppet: Only master merges set bugs to FixCommitted https://review.openstack.org/1493 | 11:05 |
| *** jakedahn has quit IRC | 11:05 | |
| *** jakedahn_ is now known as jakedahn | 11:05 | |
| markmc | soren, ah yeah, need to run rebase -i and s/pick /edit / | 11:21 |
| markmc | soren, and yeah, agree on git-review auto-rebasing | 11:22 |
| markmc | soren, you should rebase before submitting and then test | 11:23 |
| markmc | soren, but that done, you don't want a further rebase automatically happening | 11:23 |
| *** cmagina has quit IRC | 11:33 | |
| *** cmagina has joined #openstack-dev | 11:34 | |
| soren | markmc: WEll, you're screwed either way, because gerrit will rebase your change on top of HEAD. | 11:38 |
| soren | This is probably my biggest gripe with git. | 11:38 |
| markmc | soren, no, it'll merge it - end result is the same, but you can prove your commit actually worked :) | 11:38 |
| soren | Oh, it doesn't rebase? | 11:39 |
| soren | WEll, that's at least something. | 11:39 |
| markmc | no, it merges | 11:39 |
| markmc | or is it actually jenkins doing the merging? | 11:40 |
| markmc | either way, what you push to jenkins gets merged into master | 11:40 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Replace libvirt driver's use of libxml2 with ElementTree https://review.openstack.org/1494 | 11:44 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: foo https://review.openstack.org/1495 | 11:44 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend test_virt_driver to also test libvirt driver. https://review.openstack.org/1043 | 11:44 |
| soren | Gah. | 11:44 |
| markmc | you know, I almost pushed accidentally pushed a patch to gerrit yesterday too | 11:46 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend test_virt_driver to also test libvirt driver. https://review.openstack.org/1043 | 11:46 |
| markmc | coincidentally, the commit message also was "foo" | 11:46 |
| soren | That's almost always how I amend an existing patch. I hack on the code, do "git commit -a -m 'foo'" and then squash it back into the previous commit using "git rebase -i master" | 11:47 |
| soren | It's a miracle I haven't screwed it up this way before now :) | 11:47 |
| markmc | you don't just do --amend ? | 11:48 |
| markmc | git commit --amend -a | 11:48 |
| soren | I though that would only let me change the commit message. | 11:48 |
| soren | Didn't try it with -a. I guess that's the trick. | 11:49 |
| markmc | no, -a will add all changes in the working directory | 11:49 |
| markmc | yeah | 11:49 |
| soren | markmc: Cool. Thanks. That'll save me a bunch of time :) | 11:49 |
| markmc | also, if you screw it up and want to go back to the previous version of the commit | 11:49 |
| markmc | take a look at 'git reflog show' | 11:49 |
| markmc | e.g. you can do git reset --hard HEAD@{1} | 11:49 |
| markmc | it's a history of the HEAD reference | 11:49 |
| * soren lunches | 11:55 | |
| *** rkukura has quit IRC | 12:12 | |
| *** rods has joined #openstack-dev | 12:17 | |
| *** reidrac has quit IRC | 12:18 | |
| *** reidrac has joined #openstack-dev | 12:21 | |
| soren | Does anyone know how Gerrit guesses dependencies (and how I can tell it that it got it wrong)? | 12:25 |
| *** mattstep has quit IRC | 12:27 | |
| Kiall | soren: i think its just the standard git history? | 12:27 |
| markmc | soren, just from the Change-Id:, I assume | 12:27 |
| markmc | soren, example of it getting it wrong? | 12:27 |
| soren | Hm... Perhaps this is a UI problem. https://review.openstack.org/#change,1491 and https://review.openstack.org/#change,1494 both say they're depended on by https://review.openstack.org/#change,1043 | 12:28 |
| soren | but https://review.openstack.org/#change,1043 only mentions a dependency on https://review.openstack.org/#change,1494 | 12:28 |
| * markmc re-reads that a few times | 12:28 | |
| Kiall | lol | 12:29 |
| soren | markmc: Try opening all three, expand the Dependencies field, and I think it'll be reasonably obvious that something doesn't add up. | 12:29 |
| Kiall | soren: something is wrong there.. they show conflicting information | 12:29 |
| soren | Kiall: Excatly. | 12:29 |
| soren | Exactly, even. | 12:29 |
| soren | I wonder if it's a UI error. | 12:29 |
| soren | The reverse dependencies are actually accurate. 1043 *does* depend on both. | 12:30 |
| soren | ...but 1494 doesn't depend on 1491. | 12:30 |
| markmc | soren, a previous version of 1043 depended on 1491, maybe? | 12:30 |
| soren | markmc: Dunno. | 12:31 |
| markmc | soren, patch set 2, I think : https://review.openstack.org/gitweb?p=openstack/nova.git;a=log;h=25a5b8b9e0cb545711e7348cc8abed241f3b0dc8 | 12:32 |
| markmc | soren, that depends on Change-Id: I2d07baf24cab544e19521b9486feee3272d0407e | 12:32 |
| markmc | soren, which is 1491 | 12:32 |
| soren | Yeah. | 12:32 |
| markmc | you just want to abandon 1491? | 12:33 |
| soren | At any rate, there are three patches. I don't understand why they're not considered a sequence of dependencies. | 12:33 |
| soren | markmc: Uh.. No. Why would I want to do that? | 12:33 |
| markmc | oh, I see | 12:34 |
| markmc | 1494 should depend on 1491 | 12:34 |
| markmc | soren, try making an arbitrary change to the patch in 1491 and re-pushing | 12:34 |
| soren | "should" is such a strong word. 1494 depending on 1491 is what I expected, yes. | 12:34 |
| markmc | soren, even just rebasing it or whatever | 12:35 |
| soren | Rebasing without making any changes is a no-op. | 12:35 |
| markmc | soren, that way 1491 will get a patch set 2 | 12:35 |
| markmc | soren, and it'll probably work out the new dependency | 12:35 |
| markmc | soren, ok, just change the commit message | 12:35 |
| soren | Doing so :) | 12:35 |
| markmc | soren, as an experiment ... | 12:35 |
| markmc | cool | 12:35 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Replace libvirt driver's use of libxml2 with ElementTree https://review.openstack.org/1494 | 12:36 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend fake image service to let it hold image data https://review.openstack.org/1491 | 12:36 |
| openstackgerrit | Soren Hansen proposed a change to openstack/nova: Extend test_virt_driver to also test libvirt driver. https://review.openstack.org/1043 | 12:36 |
| markmc | that looks right now | 12:36 |
| soren | Yup. | 12:36 |
| soren | That did the trick. | 12:36 |
| soren | Werid. | 12:36 |
| soren | Weird, even. | 12:36 |
| markmc | so, just gerrit dumbness | 12:36 |
| markmc | it records the dependencies when you submit, clearly | 12:36 |
| soren | Yeah. | 12:36 |
| soren | And 1494 didn't exist last time 1491 was pushed. | 12:37 |
| wwkeyboard | so the dependency is through the branch? | 12:37 |
| *** GheRivero has quit IRC | 12:37 | |
| markmc | git format-patch --stdout origin/master | sed '/Date: /d' > t.mbox | 12:37 |
| wwkeyboard | i.e. if they are all checked into the same branch they depend on each other? | 12:37 |
| markmc | git reset --hard origin/master | 12:37 |
| markmc | git am t.mbox | 12:37 |
| markmc | soren, that's what I would have done, resets the dates on the commits | 12:37 |
| soren | wwkeyboard: If I have a series of patches in a branch, and I submit them for review, gerrit daisy chains the dependencies according to the ordering of the patches in my branch. | 12:37 |
| wwkeyboard | Thats what I thought | 12:38 |
| soren | markmc: Erk. | 12:38 |
| markmc | soren, :) | 12:38 |
| wwkeyboard | But then if the first patch in that list gets rejected, can you amend that specific commit? I didn't thin git would let you do that. | 12:38 |
| markmc | wwkeyboard, take a look at 'git rebase -i' | 12:39 |
| soren | markmc: I've wanted to do that so many times, but haven't found a good way. It looks really, really weird to my eye that they're dated backwards (and that the big patch there is dated in September, but accomodates a bunch of changes made in the month and half since then. | 12:39 |
| markmc | soren, right, I often reset dates for similar reasons | 12:39 |
| markmc | soren, don't know of a better way than that | 12:39 |
| markmc | soren, oh, look 'git commit --amend --date=...' | 12:40 |
| soren | Yeah. | 12:40 |
| markmc | soren, git keeps getting new features :) | 12:40 |
| soren | ...but I don't want to specify it manually. I just want it reset. | 12:40 |
| soren | --date=`date -R` :) | 12:40 |
| markmc | git commit --amend --date=$(date) ? | 12:40 |
| markmc | ah | 12:41 |
| soren | snap | 12:41 |
| soren | :) | 12:41 |
| markmc | cool | 12:41 |
| soren | I guess that should work. | 12:41 |
| markmc | no, just need a nice loop to do that for all patches in a series | 12:41 |
| markmc | really want a non-interactive mode for interactive rebasing | 12:41 |
| soren | batch rebasing. | 12:42 |
| markmc | right | 12:42 |
| *** bsza has joined #openstack-dev | 12:46 | |
| *** lorin1 has joined #openstack-dev | 12:54 | |
| *** popux has joined #openstack-dev | 12:57 | |
| *** Rajaram has quit IRC | 12:58 | |
| markmc | soren, head=$(git rev-parse HEAD); git reset --hard $(git merge-base origin/master $head); git rev-list --reverse --oneline origin/master..$head | while read shortsha1 rest; do git cherry-pick $shortsha1; git commit --amend --date="$(date -R)"; done | 12:59 |
| * markmc curses soren for distracting him | 12:59 | |
| *** lts has joined #openstack-dev | 13:00 | |
| *** lorin1 has quit IRC | 13:04 | |
| soren | IRC - Where productivity goes to die | 13:06 |
| *** ABK has quit IRC | 13:07 | |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Verify security group parameters https://review.openstack.org/815 | 13:10 |
| *** Rajaram has joined #openstack-dev | 13:15 | |
| *** bsza has quit IRC | 13:21 | |
| *** Rajaram_ has joined #openstack-dev | 13:22 | |
| *** Rajaram has quit IRC | 13:24 | |
| *** Rajaram has joined #openstack-dev | 13:24 | |
| *** Rajaram_ has quit IRC | 13:26 | |
| zykes- | soren: are you a member of the netstack team ? | 13:30 |
| soren | No | 13:30 |
| zykes- | ok, i tried sending an e-mail to the list but noone's bothered to answer | 13:31 |
| *** pringles_ has quit IRC | 13:32 | |
| *** pringles_ has joined #openstack-dev | 13:32 | |
| *** AlanClark has joined #openstack-dev | 13:35 | |
| *** sandywalsh has quit IRC | 13:41 | |
| *** chemikadze has joined #openstack-dev | 13:50 | |
| *** zul has quit IRC | 13:50 | |
| *** mnour has quit IRC | 13:53 | |
| *** zul has joined #openstack-dev | 13:53 | |
| *** kbringard has joined #openstack-dev | 13:55 | |
| openstackgerrit | Alvaro Lopez proposed a change to openstack/nova: Fixes bug 871877 https://review.openstack.org/1453 | 14:00 |
| uvirtbot | Launchpad bug 871877 in nova "Diablo fails to run a VPN" [High,In progress] https://launchpad.net/bugs/871877 | 14:00 |
| zykes- | soren: you know who's the dnsaas folks in rs ? | 14:01 |
| soren | zykes-: Sorry, no. | 14:01 |
| *** misheska has joined #openstack-dev | 14:08 | |
| *** bsza has joined #openstack-dev | 14:12 | |
| *** mdomsch has joined #openstack-dev | 14:13 | |
| *** sandywalsh_ has joined #openstack-dev | 14:13 | |
| *** dprince has joined #openstack-dev | 14:17 | |
| *** zul has quit IRC | 14:17 | |
| *** zul has joined #openstack-dev | 14:19 | |
| *** zul has quit IRC | 14:19 | |
| *** chuck__ has joined #openstack-dev | 14:20 | |
| *** chuck__ is now known as zul | 14:20 | |
| *** rkukura has joined #openstack-dev | 14:20 | |
| *** bcwaldon has joined #openstack-dev | 14:22 | |
| *** stuntmachine has joined #openstack-dev | 14:26 | |
| *** stuntmachine has quit IRC | 14:31 | |
| openstackgerrit | Dan Prince proposed a change to openstack/openstack-chef: Glance updates to support MySQL, Postgres and caching. https://review.openstack.org/1496 | 14:33 |
| *** stuntmachine has joined #openstack-dev | 14:38 | |
| openstackgerrit | Dan Prince proposed a change to openstack/openstack-chef: Add XML serialization middleware to the keystone pipeline. https://review.openstack.org/1497 | 14:45 |
| *** zns has joined #openstack-dev | 14:46 | |
| *** joesavak has joined #openstack-dev | 14:52 | |
| dprince | mtaylor: around? | 14:52 |
| *** jsavak has joined #openstack-dev | 14:53 | |
| dprince | jeblair: there? | 14:53 |
| openstackgerrit | Tyler Smith proposed a change to openstack/quantum: Fixing Cisco plugin after update_* change https://review.openstack.org/1480 | 14:53 |
| *** joesavak has quit IRC | 14:57 | |
| *** crobinso has joined #openstack-dev | 14:57 | |
| *** deshantm_laptop has joined #openstack-dev | 14:59 | |
| jeblair | dprince: hi | 15:01 |
| *** bsza has quit IRC | 15:01 | |
| dprince | jeblair: good morning! Hey. Could I put in a request to get 3 titan guys added to the group who can commit to openstack-chef. | 15:03 |
| dprince | jeblair: I'd like bcwaldon, markwash, and blamar to all have commit access. | 15:03 |
| jeblair | dprince: done | 15:04 |
| dprince | jeblair: thanks man. | 15:05 |
| jeblair | np | 15:05 |
| *** lorin1 has joined #openstack-dev | 15:05 | |
| *** Rajaram has quit IRC | 15:08 | |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Add missing methods to limit controller https://review.openstack.org/812 | 15:13 |
| *** dtroyer has joined #openstack-dev | 15:15 | |
| Kiall | Humm .. both myself and stevegjacobs have had the same kernel panic on our OS nodes, anyone able to read these things? http://dl.dropbox.com/u/1400487/panic/IMG_20111026_040053.jpg | 15:16 |
| *** Rajaram has joined #openstack-dev | 15:17 | |
| markmc | Kiall, it's an oops down in netfilter when qemu is writing to a tap device | 15:18 |
| Kiall | markmc: yea, I can see mentions of NF, NAT, bridging and tap .. but the cause is a mystery to me | 15:19 |
| markmc | Kiall, looks something like https://lkml.org/lkml/2011/6/1/754 | 15:21 |
| Kiall | It does, I've actually already had a quick read though that thread without luck | 15:22 |
| soren | Kiall: Which kernel version? | 15:24 |
| Kiall | soren: 3.0.0-13-server on oneirc.. | 15:25 |
| Kiall | not sure about the version stevegjacobs is running.. | 15:25 |
| markmc | ubuntu? there's your problem right there | 15:25 |
| * markmc ducks and runs | 15:25 | |
| soren | How do you spell /KICK again?... | 15:25 |
| soren | :) | 15:25 |
| Kiall | markmc: lol | 15:25 |
| markmc | heh | 15:25 |
| soren | Kiall: Can you reliably trigger it? | 15:26 |
| Kiall | soren: I'm afraid not | 15:26 |
| Kiall | Standard traffic seems to trigger it, rather than instance startup/shutdown etc | 15:27 |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Correcting image cleanupd in sqlite cache driver https://review.openstack.org/1498 | 15:33 |
| openstackjenkins | Project nova-docs build #1,617: SUCCESS in 2 min 11 sec: https://jenkins.openstack.org/job/nova-docs/1617/ | 15:38 |
| openstackjenkins | Soren Hansen: Extend fake image service to let it hold image data | 15:38 |
| *** hugokuo has joined #openstack-dev | 15:38 | |
| *** dwalleck has joined #openstack-dev | 15:39 | |
| *** joesavak has joined #openstack-dev | 15:41 | |
| *** blamar has joined #openstack-dev | 15:42 | |
| *** jsavak has quit IRC | 15:42 | |
| openstackgerrit | Mark Washenberger proposed a change to openstack/nova: Add more error handling to glance xenapi plugin https://review.openstack.org/1499 | 15:43 |
| openstackjenkins | Project nova-docs build #1,618: SUCCESS in 2 min 17 sec: https://jenkins.openstack.org/job/nova-docs/1618/ | 15:43 |
| openstackjenkins | Soren Hansen: Replace libvirt driver's use of libxml2 with ElementTree | 15:43 |
| soren | W00t. | 15:44 |
| soren | jkoelker, blamar: Thanks for reviewing that libvirt test branch. It's been sitting there forever. | 15:46 |
| *** jeremy has joined #openstack-dev | 15:46 | |
| jkoelker | np | 15:46 |
| * ttx prepares to release essex-1. | 15:47 | |
| ttx | shout will you still can. | 15:47 |
| ttx | while* | 15:47 |
| ttx | zns: keystone ok to go ? | 15:48 |
| ttx | jaypipes: glance ok to go ? | 15:48 |
| ttx | vishy: nova ok to go ? | 15:48 |
| zns | ttx: yes | 15:49 |
| joesavak | ttx: keystone good | 15:49 |
| *** dolphm has joined #openstack-dev | 15:50 | |
| zns | ttx: hold on. There's a review that I thought went in that isn't. When are you cutting? | 15:52 |
| ttx | zns: asap | 15:52 |
| blamar | soren: np, I'm not a big fan of huge fakes like that (I made a long winded comment when you had it in Launchpad) but it's gotta be a pain for you to have that merge up for review for so long :) I feel that pain | 15:52 |
| dolphm | zns: which review? | 15:52 |
| zns | TENANT_ID | 15:52 |
| ttx | zns: note that the fix will have to be in milestone-proposed. | 15:53 |
| ttx | zns: (in addition to master) | 15:53 |
| zns | https://review.openstack.org/#change,1386 | 15:53 |
| Daviey | wow, essex-1 has come around fast | 15:53 |
| *** Rajaram has quit IRC | 15:53 | |
| soren | blamar: It's way, way easier to maintain than half a bajillion stubs scattered across as many unit tests. | 15:53 |
| mtaylor | dprince: morning! | 15:53 |
| *** rnirmal has joined #openstack-dev | 15:53 | |
| zns | dolphm: That was vish's originally. I think he's expeting it in, isn't he? | 15:54 |
| dolphm | zns: i assume so | 15:54 |
| mtaylor | dprince: don't know if you've chatted with them, but the folks at HP are apparently using chef for their deploys as well. I believe their plan is to collaborate with you on openstack-chef. | 15:54 |
| ttx | zns: I have a TENANT_ID thing in https://github.com/openstack/keystone/commits/milestone-proposed | 15:54 |
| dolphm | zns: he also made a comment in https://review.openstack.org/#change,1375 | 15:54 |
| soren | blamar: The unit tests for the fake itself should offer some confidence that it's in good shape. | 15:54 |
| dprince | mtaylor: sounds good. I'll look for some merge props then. | 15:55 |
| blamar | soren: I'd agree with that against the current code base...but ideally we shouldn't have to stub so much out, lots of programming design patterns to help that | 15:55 |
| blamar | soren: yeah, I like that, but it's also a red flag for me when you have to write unit tests for your unit tests | 15:55 |
| soren | blamar: Do you have better suggestions for how to thoroughly test the libvirt driver? | 15:55 |
| *** misheska has quit IRC | 15:56 | |
| zns | ttx: that's the same one, but I updated it. I was worried that the way it was listed now would break a number of apps. | 15:56 |
| *** ayoung has quit IRC | 15:57 | |
| soren | blamar: It's a pattern I've come to enjoy quite a bit actually. I have some code that needs to interact with something. I add a fake version of the something and add tests to make sure the something acts like the real thing. | 15:57 |
| blamar | soren: one suggestion, but it's a massive refactoring of the code to de-couple the actual interaction between us and libvirt | 15:57 |
| soren | blamar: ..but then how would you test that? | 15:58 |
| soren | blamar: The thing that actually talks to libvirt? | 15:58 |
| blamar | soren: there are some things you don't test | 15:58 |
| zns | dolphm: can you review my submission into master? Then we can get it into milestopne. | 15:58 |
| blamar | I liken this to mocking out a filesystem because you have a lot of open() calls in your code | 15:58 |
| soren | blamar: Yeah, I don't really buy that. If it was something simple that we knew noone would ever change, no problem. | 15:58 |
| *** adjohn has joined #openstack-dev | 15:59 | |
| dolphm | zns: the middleware.rst isn't actually rst syntax | 15:59 |
| soren | blamar: But this interaction is delicate, and libvirt has lots of knobs, handles and levers. | 15:59 |
| mtaylor | jaypipes: hey buddy. any reason you have sqlalchemy<0.7 marked in glance pip-requires? | 16:00 |
| soren | blamar: I don't trust anyone (including myself) to do so reliably. Having a fake (with tests) gives me confidence that we're speaking correctly to libvirt. | 16:00 |
| blamar | s/libvirt/our custom fake libvirt/ | 16:00 |
| soren | The tests are meant to ensure that that is the same thing. | 16:01 |
| soren | When we learn that is not the case, we have somewhere to fix that and ensure we never make the same mistake again. | 16:01 |
| mtaylor | notmyname: if we were going to make a python-swiftclient, do you think we should start with the rackspace cloud files client thing? or something else? or should I just butt out? | 16:01 |
| notmyname | mtaylor: (only because you said it first) the best thing now is to butt out :-) | 16:02 |
| notmyname | mtaylor: the rax packages aren't a good base | 16:02 |
| *** ayoung has joined #openstack-dev | 16:02 | |
| mtaylor | notmyname: ok :) | 16:02 |
| notmyname | mtaylor: but the swift/common/client.py is | 16:02 |
| soren | blamar: When "the thing" is sufficiently complicated, it's impossible to write code that interacts with it that is "obviously correct". | 16:02 |
| notmyname | mtaylor: and we're currently in a (long) process of updating the rackspace bindings (all of them) to be much more like client.py | 16:02 |
| mtaylor | notmyname: cool. I'm poking at good plane hacking tasks, so I was poking around at glance/glanceclient and noticed that glance was depending on swift | 16:03 |
| mtaylor | so I thought I'd ask | 16:03 |
| blamar | soren: I really don't understand that statement :\ | 16:03 |
| notmyname | mtaylor: I expect to use client.py (or something similar derived from client.py). I also expect it to be ready around essex and not too much sooner | 16:03 |
| soren | blamar: I wrote a fake libxenstore at some point because I had to write some code that needed to talk to the Xen store, but I didn't want to run Xen. To make sure I didn't screw it up, I wrote tests for my libxenstore to ensure it acted like the real one did. | 16:03 |
| notmyname | mtaylor: good thought, though | 16:03 |
| blamar | is the fake libvirt going to support a specific version of libvirt? or all versions? | 16:03 |
| mtaylor | notmyname: yeah - it's not pressing so far | 16:04 |
| *** code_franco has joined #openstack-dev | 16:04 | |
| soren | blamar: If such a difference makes a difference for us, sure. | 16:04 |
| *** dragondm has joined #openstack-dev | 16:04 | |
| soren | blamar: Like if a new API call is added in version X, but we claim to support versions <X, then fakelibvirt should know how to act like it supports it and not. | 16:05 |
| soren | If we bump our required libvirt version to X, then I don't see any reason to do so. | 16:05 |
| soren | blamar: Ok, so to explain that statement.. | 16:06 |
| soren | blamar: (from further up) | 16:06 |
| blamar | k | 16:06 |
| *** crobinso has quit IRC | 16:06 | |
| soren | blamar: If the API I was faking only had a couple of different calls, it'd be easy to verify that an abstraction layer that talks to it is doing the right thing. | 16:07 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Use TENANT_ID if it exists, but still support X_TENANT. https://review.openstack.org/1386 | 16:07 |
| soren | blamar: When it's more complicated than that, it's really handy to have a fake that ensures you've done the proper setup, that you're calling the right things, that you're cleaning up properly after yourself, that you're not trying to perform operations on objects whose state doesn't support said operation... | 16:08 |
| soren | blamar: There's no way I'm going to accept that as something "you just don't test". | 16:08 |
| blamar | soren: completely mis-spoke that. it really should read: there are some things you just don't unit test | 16:09 |
| *** mmetheny has quit IRC | 16:09 | |
| *** mmetheny_ has joined #openstack-dev | 16:09 | |
| *** reidrac has quit IRC | 16:09 | |
| soren | blamar: I dont' want to depend on libvirt. Just like I don't want to depend on hyperv. | 16:09 |
| blamar | which is why we have integration tests and acceptance tests and whatever else the names are for them | 16:10 |
| soren | blamar: I want to be free to change things in the general interface, make adjustments in all the hypervisor drivers, including hyperv, and have the unit tests tell me if I screwed it up. | 16:10 |
| blamar | but they *don't* they tell you if you screwed up the fake | 16:10 |
| soren | Yes... | 16:10 |
| soren | And I have tests to try to make sure that that is the same thing. | 16:10 |
| soren | The integration tests can tell me when I got *that* wrong. | 16:11 |
| soren | ...and I can fix the fake (and its tests). | 16:11 |
| soren | Integration tests will (hopefully) catch everything, but before things make it that far, unit tests should have caught as much as possible. This is certainly within the realm of what is possible. | 16:13 |
| blamar | unit test inception, going another level deep for limited benefit IMO, whatever benefit it provides it just gets taken away by adding the chance that the fake is wrong | 16:13 |
| soren | We can't expect random developers to run any amount of integration tests. We can tell tehm to run unit tests. | 16:13 |
| soren | If the fake is wrong, the difference will be caught in integration tests, and then we can fix the fake. | 16:14 |
| soren | Without the fake, we'll be sure to make the same mistake again. With the fake, we only make the same mistake once. | 16:14 |
| blamar | soren: but we can expect us to gate trunk based on integration tests | 16:14 |
| openstackgerrit | Chmouel Boudjnah proposed a change to openstack/keystone: Add a new swift auth middleware. https://review.openstack.org/1500 | 16:14 |
| soren | blamar: This is a slippery slope that leads to not doing unit testing at all. | 16:15 |
| *** markmc has quit IRC | 16:15 | |
| blamar | good thing it's a fallacy then? | 16:15 |
| soren | blamar: How do you figure that? | 16:15 |
| blamar | http://en.wikipedia.org/wiki/Slippery_slope#The_slippery_slope_as_fallacy | 16:16 |
| soren | You're saying this is pointless because these things will be caught in intergration tests. | 16:16 |
| soren | ...just like everything else. | 16:16 |
| soren | So, since we'll catch every problem in integration tests, unit tests have little purpose. | 16:16 |
| soren | I really have to go to dinner now :) | 16:17 |
| soren | I'd love to discuss this more. | 16:17 |
| soren | Later. | 16:17 |
| soren | o/ | 16:17 |
| blamar | see ya! | 16:18 |
| *** sannes has quit IRC | 16:18 | |
| *** cp16net has joined #openstack-dev | 16:19 | |
| *** crobinso has joined #openstack-dev | 16:19 | |
| *** dwalleck_ has joined #openstack-dev | 16:20 | |
| openstackgerrit | Chmouel Boudjnah proposed a change to openstack/swift: Fix permissions when creating files/permissions. https://review.openstack.org/1206 | 16:22 |
| *** dwalleck has quit IRC | 16:22 | |
| *** markmc has joined #openstack-dev | 16:22 | |
| zns | ttx: the code is in. Keystone is ready. | 16:24 |
| ttx | zns: ok | 16:25 |
| ttx | I need to wait for a tarball to be generated from the last change | 16:25 |
| ttx | and then we can go | 16:25 |
| *** chmouel_ is now known as chmouel | 16:27 | |
| *** bsza has joined #openstack-dev | 16:27 | |
| *** vladimir3p has joined #openstack-dev | 16:28 | |
| vishy | zns: hey there is something weird happening with one of my proposals into stable/diablo | 16:28 |
| *** gyee has joined #openstack-dev | 16:29 | |
| zns | vishy: which one? I know I stomped (by mistake) over your TENANT_ID proposal. We got it into master and E1 just now. I'll work on getting it into stable/diablo. Is that the one you are referring to? | 16:30 |
| *** dolphm has quit IRC | 16:30 | |
| vishy | yeah | 16:30 |
| vishy | that one | 16:30 |
| *** dolphm has joined #openstack-dev | 16:30 | |
| vishy | zns: cool, I just want to make sure that everything is using the id. We still need to redo the conversion scripts | 16:31 |
| ttx | vishy: is https://github.com/openstack/nova/commits/milestone-proposed looking good for you ? | 16:31 |
| ttx | (for essex-1 immediate release) | 16:31 |
| *** dwalleck_ has quit IRC | 16:31 | |
| vishy | ttx: yeah. I wish we had the integration tests going | 16:32 |
| vishy | ttx: they are close :( | 16:32 |
| ttx | vishy: no shit :) | 16:32 |
| ttx | how close ? | 16:32 |
| vishy | not close enough to delay | 16:32 |
| ttx | ack | 16:33 |
| ttx | jaypipes: around ? | 16:33 |
| vishy | I have not been able to consistently reproduce the rabbit bug i was looking at | 16:33 |
| jaypipes | ttx: yep | 16:33 |
| vishy | so that has no fix yet either | 16:33 |
| vishy | it is a heisenbug | 16:33 |
| ttx | jaypipes: glance milestone-proposed ok to go ? | 16:33 |
| zns | vishy: which conversion scripts? | 16:34 |
| *** dolphm_ has joined #openstack-dev | 16:35 | |
| *** dolphm has quit IRC | 16:35 | |
| *** pin15 has joined #openstack-dev | 16:35 | |
| vishy | zns: the ones that convert users and projects from nova into keystone | 16:36 |
| jaypipes | ttx: yes | 16:36 |
| ttx | cool, I just miss horizon then | 16:36 |
| *** yogirackspace has joined #openstack-dev | 16:36 | |
| ttx | anyone from horizon-core who could confirm ? | 16:37 |
| zns | vishy: I heard about it but never saw it! Would love to take a look at it. Where is it? | 16:37 |
| *** mattstep has joined #openstack-dev | 16:37 | |
| zns | vishy: I know some Cactus deployments are having heartburn over moving to Keystone. Does the script handle changing name/id in Nova as well? | 16:37 |
| *** sandywalsh has joined #openstack-dev | 16:39 | |
| ttx | doing keystone/essex-1 | 16:40 |
| *** cp16net has quit IRC | 16:41 | |
| *** cp16net has joined #openstack-dev | 16:41 | |
| *** dwalleck has joined #openstack-dev | 16:42 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Correcting image cleanupd in sqlite cache driver https://review.openstack.org/1498 | 16:42 |
| ttx | doing glance/essex-1 | 16:45 |
| *** crobinso has quit IRC | 16:45 | |
| ttx | doing nova/essex-1 | 16:48 |
| *** joesavak has quit IRC | 16:48 | |
| zns | Anyone know how to preview what is about to get pushed up in a 'git review'? Something like a 'git review preview'? | 16:51 |
| *** ayoung has quit IRC | 16:51 | |
| viraptor | zns: if you're sure it's only one, current commit, then `git show` | 16:53 |
| viraptor | to make sure it's only one single commit, `gitk` might be helpful | 16:54 |
| *** popux has quit IRC | 16:55 | |
| mtaylor | jaypipes: did you see my ? about sqlalchemy versions in glance? | 16:56 |
| *** jog0 has joined #openstack-dev | 16:56 | |
| jaypipes | mtaylor: on IRC? or email? | 16:57 |
| *** jog0 has quit IRC | 16:57 | |
| dolphm_ | viraptor: that's the issue - how do you know you're only about to push a single change? | 16:57 |
| *** jog0 has joined #openstack-dev | 16:57 | |
| mtaylor | jaypipes: here. is there a reason for the <0.7 on the sqlalchemy line in the pip-requires? | 16:57 |
| *** reed_ has joined #openstack-dev | 16:57 | |
| mtaylor | jaypipes: nova bumped up to allowing 0.7 | 16:57 |
| *** negronjl has joined #openstack-dev | 16:57 | |
| viraptor | dolphm_: if you're rebased on master, then your commit will de displayed on top and the next one will have the "master" tag on the right | 16:57 |
| jaypipes | mtaylor: had to do with sqlalchemy.migrate. | 16:57 |
| mtaylor | lovely | 16:58 |
| jaypipes | mtaylor: basically 0.7.0 is bad, but 0.7.1 is fine. | 16:58 |
| *** reed_ is now known as reed | 16:58 | |
| mtaylor | jaypipes: ah! so can we change that to >0.7.0 then? (want to make sure we don't get a set of weird cross-project depends going) | 16:58 |
| jaypipes | mtaylor: I believe so, yes | 16:59 |
| viraptor | dolphm_: or run `git log master --not remotes/origin/master` and you should get only the difference between upsteam and your tree (which should be a single commit) | 16:59 |
| dolphm_ | zns: ^^^ | 17:00 |
| dolphm_ | viraptor: that looks like exactly what i was thinking | 17:01 |
| openstackgerrit | Monty Taylor proposed a change to openstack/nova: Removed some old cruft. https://review.openstack.org/1502 | 17:02 |
| zns | viraptor: excellent! Thanks. | 17:03 |
| *** dolphm_ has quit IRC | 17:04 | |
| *** dolphm has joined #openstack-dev | 17:05 | |
| zns | viraptor: git show works, but as dolphm points out how do we know we're only pushing one review? 'git log master --not remotes/origin/master' does nothing for me - no output. | 17:07 |
| openstackgerrit | andrea-rosa-m proposed a change to openstack/nova: Exception handler for kombu connnection https://review.openstack.org/1503 | 17:07 |
| mtaylor | zns: thanks for reminding me ... I've been meaning to add a confirmation step to git-review that will warn if you're about to submit more than one patch | 17:08 |
| viraptor | zns: then you don't have new commits at all - no idea how you did that :P | 17:09 |
| zns | mtaylor: cool. Any plans to add somehting like 'git review milestone-proposed'? | 17:09 |
| viraptor | gitk should help you look around | 17:09 |
| mtaylor | zns: yes. already exists | 17:10 |
| *** dolphm has quit IRC | 17:10 | |
| mtaylor | zns: you need to use the new git-review tool | 17:10 |
| mtaylor | zns: pip install git-review | 17:10 |
| zns | mtaylor: didn't you guys make all that magically come down with the code pulls? | 17:10 |
| mtaylor | zns: originally we did, but we're replacing the thing in the tree with a tool that you install - because it can do more, and also that way we don't have to maintain 16 copies of a script :) | 17:11 |
| zns | mtaylor: Ah. pip installing. | 17:11 |
| mtaylor | zns: so git-review is the up and coming hotness. basic things work as before - "git review" and you're good | 17:11 |
| mtaylor | zns: but there are several new things it can do, including submitting to non-master branches | 17:12 |
| *** dtroyer has quit IRC | 17:12 | |
| *** pin15 has left #openstack-dev | 17:12 | |
| mtaylor | zns: git review --help should give you an overview | 17:12 |
| zns | viraptor: found the problem. I'm not on master, I'm working on stable/diablo. So 'git log master --not remotes/origin/stable/diablo' works! Thank you. | 17:13 |
| zns | mtaylor: git review --help | 17:14 |
| zns | No manual entry for git-review | 17:14 |
| zns | :-( | 17:14 |
| mtaylor | :( | 17:14 |
| *** dprince has quit IRC | 17:14 | |
| mtaylor | zns: well, there's also a readme file on http://github.com/openstack-ci/git-review | 17:14 |
| mtaylor | zns: what os are you on? that's a bug that you don't get that manpage and I'd like to track it down :) | 17:15 |
| *** sleepsontheflo-1 has joined #openstack-dev | 17:15 | |
| openstackgerrit | Monty Taylor proposed a change to openstack/openstack-ci: Run sdist in the venv. https://review.openstack.org/1504 | 17:15 |
| zns | Mac | 17:15 |
| mtaylor | zns: awesome. thanks | 17:15 |
| *** hugokuo has quit IRC | 17:16 | |
| viraptor | zns: if you're working on diablo/stable, then it should probably be 'git log stable/diablo --not remotes/origin/stable/diablo' - otherwise you might submit the whole master ;) | 17:17 |
| openstackjenkins | Project nova-docs build #1,619: SUCCESS in 2 min 14 sec: https://jenkins.openstack.org/job/nova-docs/1619/ | 17:18 |
| openstackjenkins | Alvaro: Fixes bug 871877 | 17:18 |
| uvirtbot | Launchpad bug 871877 in nova "Diablo fails to run a VPN" [High,Fix committed] https://launchpad.net/bugs/871877 | 17:18 |
| zns | zns: exactly what we're trying to avoid! Thanks | 17:18 |
| * mtaylor is adding that check to git-review right now | 17:18 | |
| zns | viraptor, not zns! | 17:18 |
| *** deshantm_laptop has quit IRC | 17:24 | |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Capture exceptions happening in API layer https://review.openstack.org/802 | 17:26 |
| *** Rajaram has joined #openstack-dev | 17:27 | |
| *** crobinso has joined #openstack-dev | 17:31 | |
| *** bsza has quit IRC | 17:34 | |
| *** bsza has joined #openstack-dev | 17:34 | |
| openstackgerrit | Ahmad Hassan proposed a change to openstack/nova: Capture exceptions happening in API layer https://review.openstack.org/802 | 17:35 |
| openstackgerrit | Tyler Smith proposed a change to openstack/quantum: Fixing Cisco plugin after update_* change https://review.openstack.org/1480 | 17:39 |
| *** negronjl has quit IRC | 17:39 | |
| *** jakedahn has quit IRC | 17:40 | |
| *** johan_-_ has joined #openstack-dev | 17:40 | |
| *** devcamcar has joined #openstack-dev | 17:42 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-ci/git-review: Check to ensure that only one change is submitted. https://review.openstack.org/1505 | 17:42 |
| *** nati2 has joined #openstack-dev | 17:47 | |
| *** jaypipes has quit IRC | 17:49 | |
| *** jdg has joined #openstack-dev | 17:50 | |
| *** dprince has joined #openstack-dev | 17:51 | |
| *** ayoung has joined #openstack-dev | 17:52 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-ci/git-review: Check to ensure that only one change is submitted. https://review.openstack.org/1505 | 17:54 |
| ttx | devcamcar: is horizon milestone-proposed ready to go ? | 17:55 |
| ttx | devcamcar: I included the latest commit from master, since you targeted that fix for essex-1 | 17:55 |
| ttx | devcamcar: please doublecheck and let me know | 17:55 |
| * ttx disappears momentarily to have dinner | 17:56 | |
| devcamcar | ttx: we have one backport to do | 17:58 |
| *** bcwaldon_ has joined #openstack-dev | 17:58 | |
| *** bcwaldon has quit IRC | 17:58 | |
| *** jdurgin has joined #openstack-dev | 17:59 | |
| devcamcar | mtaylor: around? i've been noticing that gerrit hasn't been sending notifications when i receive merge proposals | 18:01 |
| devcamcar | i was wondering why things were so quiet ... | 18:01 |
| devcamcar | i did actually click the checkboxes too :) | 18:01 |
| *** bcwaldon_ has quit IRC | 18:02 | |
| *** blamar has quit IRC | 18:02 | |
| *** blamar has joined #openstack-dev | 18:02 | |
| *** joesavak has joined #openstack-dev | 18:03 | |
| *** bcwaldon has joined #openstack-dev | 18:03 | |
| *** pixelbeat has quit IRC | 18:03 | |
| *** ayoung has quit IRC | 18:03 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Correcting image cleanup in cache drivers https://review.openstack.org/1498 | 18:05 |
| *** jsavak has joined #openstack-dev | 18:08 | |
| *** lorin11 has joined #openstack-dev | 18:10 | |
| *** lorin11 has quit IRC | 18:10 | |
| *** joesavak has quit IRC | 18:12 | |
| *** dwalleck has quit IRC | 18:12 | |
| *** lorin1 has quit IRC | 18:12 | |
| *** jaypipes has joined #openstack-dev | 18:13 | |
| openstackgerrit | andrea-rosa-m proposed a change to openstack/nova: Exception handler for kombu connnection https://review.openstack.org/1503 | 18:17 |
| *** novas0x2a|laptop has joined #openstack-dev | 18:18 | |
| johan_-_ | PING 1320949227 | 18:20 |
| *** dwalleck has joined #openstack-dev | 18:23 | |
| *** med_out has quit IRC | 18:23 | |
| *** dwalleck has quit IRC | 18:23 | |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Converting delete to use instance objects https://review.openstack.org/1506 | 18:24 |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Converting delete to use instance objects https://review.openstack.org/1506 | 18:25 |
| *** mszilagyi has joined #openstack-dev | 18:27 | |
| *** dtroyer has joined #openstack-dev | 18:29 | |
| *** Rajaram has quit IRC | 18:30 | |
| openstackjenkins | Project nova-docs build #1,620: SUCCESS in 2 min 13 sec: https://jenkins.openstack.org/job/nova-docs/1620/ | 18:33 |
| openstackjenkins | mark.washenberger: Add more error handling to glance xenapi plugin | 18:33 |
| *** jakedahn has joined #openstack-dev | 18:34 | |
| *** zaitcev has joined #openstack-dev | 18:42 | |
| ttx | devcamcar: what backport ? Note that I did push one extra commit to it earlier today (the one you targeted to essex-1 yesterday) | 18:51 |
| *** jakedahn has quit IRC | 18:53 | |
| *** nati2 has quit IRC | 18:53 | |
| *** bsza has quit IRC | 18:53 | |
| devcamcar | ttx: that's probably the one i was referring to | 18:54 |
| devcamcar | let me loo | 18:54 |
| devcamcar | k | 18:54 |
| *** nati2 has joined #openstack-dev | 18:55 | |
| *** jsavak has quit IRC | 18:55 | |
| ttx | devcamcar: Check https://github.com/openstack/horizon/commits/milestone-proposed | 18:57 |
| ttx | devcamcar: basically it's check behind master by one commit now | 18:57 |
| ttx | s/check/just/ | 18:57 |
| *** reed has quit IRC | 18:58 | |
| devcamcar | ttx: great, we are good to go | 18:59 |
| devcamcar | thanks! | 18:59 |
| *** jdg has quit IRC | 19:00 | |
| soren | blamar: Where were we? | 19:00 |
| soren | blamar: Oh, right. | 19:00 |
| soren | blamar: So, you argue that doing this is bad, because it's hard to get right, and any issues would be better caught by integration tests. Is that accurate? | 19:01 |
| *** jsavak has joined #openstack-dev | 19:05 | |
| *** lorin1 has joined #openstack-dev | 19:06 | |
| vishy | soren: he was arguing against your fake? | 19:08 |
| *** mgius has joined #openstack-dev | 19:09 | |
| soren | vishy: Yes. | 19:09 |
| *** reed has joined #openstack-dev | 19:10 | |
| vishy | soren, blamar: i think the utility is inversely proportional to the complexity of the fake. If the fake gets too complex, the overhead of maintaining outweighs its value | 19:10 |
| *** bsza has joined #openstack-dev | 19:10 | |
| soren | vishy: Depends. | 19:10 |
| vishy | soren, blamar: I think the fakerabbit implementation was very useful for example, but it did create some pain a few times | 19:10 |
| *** dtroyer has quit IRC | 19:10 | |
| vishy | soren, blamar: same with fakeldap | 19:10 |
| soren | vishy: If the thing it's faking is equally complex, that changes things. | 19:10 |
| *** dtroyer has joined #openstack-dev | 19:11 | |
| vishy | the ldap code would probably not work without the fakeldap | 19:11 |
| soren | Yeah. | 19:11 |
| vishy | soren: so I think as long as we don't get too crazy with the fake, it is still useful | 19:11 |
| soren | I think the libvirt fake is quite maintainable. | 19:11 |
| soren | ..and as long as the fake itself has tests, it shouldn't be a problem. | 19:12 |
| soren | "Ever". | 19:12 |
| ttx | devcamcar: ok, releasing now then | 19:12 |
| devcamcar | ttx: awesome | 19:12 |
| vishy | soren: as long as we don't consider it a replacement for integration tests, I don't have a problem with it. I'd like to hear more about blamar's concerns though | 19:13 |
| *** jakedahn has joined #openstack-dev | 19:14 | |
| soren | vishy: To be honest, I'd much rather have unit tests replace integration tests than the other way around, but no, noone is suggesting not doing integration tests. | 19:15 |
| crobinso | soren: where is this fake libvirt code? | 19:16 |
| soren | crobinso: https://review.openstack.org/#change,1043 | 19:16 |
| soren | crobinso: It implements the subset of libvirt python API that we use. | 19:17 |
| soren | crobinso: ..and tries to maintain the state that we care about. | 19:17 |
| crobinso | soren: I heard you mention problems with test:/// driver to markmc yesterday, what exactly are those problems? | 19:18 |
| soren | crobinso: Basically that it exposes it's own semantics that are different from any/all of kvm, qemu, uml, Xen.. | 19:18 |
| soren | crobinso: I'd like for this one to expose all the idiosyncracies of kvm/Xen/UML/QEmu/whatever. | 19:19 |
| soren | crobinso: And, I'd like to not depend on libvirt. | 19:19 |
| soren | crobinso: The latter in part because that's what I asked of the people who developed the HyperV driver. | 19:19 |
| *** negronjl has joined #openstack-dev | 19:22 | |
| crobinso | soren: hmm. well the test:/// driver doesn't have a big dep, since it doesn't require libvirt to be running or even exist | 19:22 |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Converting start and stop to use instance objects https://review.openstack.org/1507 | 19:22 |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Converting delete to use instance objects https://review.openstack.org/1506 | 19:22 |
| soren | crobinso: No, but it still requires libvirt. | 19:23 |
| crobinso | soren: I wonder if it might be better to just use monkey patching to mimic the idiosyncrasies. that's basically what I do for virtinst which has a very extensive test suite hitting libvirt | 19:23 |
| soren | crobinso: Which can be awkward for a number of reasons (not being on pypi, for instance). | 19:23 |
| *** bsza has quit IRC | 19:24 | |
| *** bsza has joined #openstack-dev | 19:24 | |
| *** ayoung has joined #openstack-dev | 19:28 | |
| ttx | essex-1 available now. | 19:28 |
| soren | ttx: sexy | 19:28 |
| *** dwalleck has joined #openstack-dev | 19:29 | |
| ttx | MLs and archives are sooo slow that I can't really reference my email in the tweet. | 19:29 |
| zykes- | :p | 19:30 |
| crobinso | soren: the main benefit of the test:/// driver is that it does actually exercise a lot of code that actual drivers like qemu, xen, etc do use, like XML validation | 19:30 |
| *** gyee has quit IRC | 19:31 | |
| *** bsza has quit IRC | 19:31 | |
| soren | crobinso: A number of things seem to be completely absent, though. | 19:33 |
| soren | crobinso: Like attaching devices. | 19:33 |
| soren | crobinso: Migration. | 19:33 |
| soren | crobinso: CPU feature comparison. | 19:33 |
| soren | crobinso: All things we need. | 19:34 |
| *** bsza has joined #openstack-dev | 19:34 | |
| *** gyee has joined #openstack-dev | 19:34 | |
| *** jakedahn has quit IRC | 19:34 | |
| crobinso | soren: no doubt, but those are the things that can be monkey patched into the python bindings (or actually implemented in the libvirt test driver, would be easy for 1 and 3 at least) | 19:35 |
| *** dwalleck has quit IRC | 19:35 | |
| soren | crobinso: Yeah. I just kind of need this, like, a year ago :) | 19:36 |
| soren | crobinso: If the test driver did all of this, I might have argued stronger for doing that in the first place (my first experiment involed just pointing the libvirt driver at test:/// instead of qemu:///system), but I needed to duplicate too much state. | 19:38 |
| soren | crobinso: So, if I were to support the attachDevice by way of monkeypatching, I'd need to maintain state about block device and network interfaces from the domain's defined XML to make sure I properly reject attempts to attach a device that already exists. | 19:40 |
| soren | crobinso: This just felt like less work, and it solved the problem of the libvirt dependency, as well as served as an example of how one could do this for other hypervisors. Notably, HyperV. | 19:40 |
| Kiall | crobinso: how stable should the milestone releases be considered? | 19:41 |
| soren | Kiall: What, of libvirt? | 19:41 |
| Kiall | sorry, essex-1 | 19:41 |
| Kiall | (Just got his ML email) | 19:41 |
| soren | Kiall: And you mean to ask crobinso about that? | 19:42 |
| soren | Oh. | 19:42 |
| soren | Ok. | 19:42 |
| Kiall | oh - crap wasnt him who sent it ;) | 19:42 |
| Kiall | why did I think he sent it -_- | 19:42 |
| crobinso | soren: I hear ya, your code exists now and is useful, so all good. but finding a way to utilize the test driver will give better validation and likely less custom openstack code, so worth keeping in mind | 19:43 |
| crobinso | soren: at least for medium term | 19:44 |
| *** novas0x2a|laptop has quit IRC | 19:44 | |
| *** novas0x2a|laptop has joined #openstack-dev | 19:44 | |
| *** bsza has quit IRC | 19:44 | |
| *** adjohn has quit IRC | 19:45 | |
| *** mszilagyi_ has joined #openstack-dev | 19:47 | |
| *** ayoung has quit IRC | 19:47 | |
| *** mszilagyi has quit IRC | 19:48 | |
| *** mszilagyi_ is now known as mszilagyi | 19:48 | |
| *** dwalleck has joined #openstack-dev | 19:50 | |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Initial. https://review.openstack.org/1508 | 19:50 |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Bug-888448: - Changes to allow validate token call return user name as per contract. https://review.openstack.org/1509 | 19:50 |
| *** ayoung has joined #openstack-dev | 19:52 | |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Bug-888448: - Changes to allow validate token call return user name as per contract. https://review.openstack.org/1509 | 19:55 |
| vishy | Kiall: not that stable | 19:56 |
| vishy | Kiall: tech preview only | 19:56 |
| rmk | How does nova determine the state of a compute worker? | 19:57 |
| Kiall | Sure - Thats what I figured.. Just wanted to check though :) | 19:57 |
| rmk | I'm seeing flapping constantly. | 19:57 |
| *** dtroyer has quit IRC | 19:57 | |
| *** dprince has quit IRC | 19:58 | |
| vishy | rmk: install ntp | 19:59 |
| rmk | ugh really, time drift? | 19:59 |
| vishy | rmk: aye | 19:59 |
| rmk | I have a 1 sec skew at the moment between my "master" and compute nodes | 19:59 |
| rmk | would that be enough delta to cause it? | 20:00 |
| Kiall | rmk: i'd hope not ;) | 20:00 |
| *** lorin1 has left #openstack-dev | 20:00 | |
| *** lorin1 has joined #openstack-dev | 20:01 | |
| Kiall | but .. there is this: https://bugs.launchpad.net/nova/+bug/867674 | 20:01 |
| uvirtbot | Launchpad bug 867674 in nova "Make service liveness checks more consistent / correct" [Wishlist,Fix committed] | 20:01 |
| rmk | I've got 50 VMs on each of my two compute nodes in my lab. | 20:01 |
| rmk | So I was looking at various tuning options for libvirtd. | 20:01 |
| rmk | As well as rabbit and nova-compute workers itself. | 20:01 |
| rmk | Kiall: Hmm I may have to pull that patch and try it. | 20:02 |
| vishy | rmk: yes | 20:02 |
| vishy | rmk if the head node is ahead | 20:02 |
| vishy | * behind | 20:02 |
| rmk | yeah it's behind | 20:03 |
| vishy | there has been arguments about what should be done with negative values | 20:04 |
| rmk | Well at least this is easy enough to sort out with ntp. | 20:04 |
| vishy | but as Kiall pointed out | 20:04 |
| vishy | it now supports negative times ok | 20:04 |
| vishy | in any case, you should have ntp | 20:05 |
| rmk | Agreed. | 20:05 |
| *** n0ano has quit IRC | 20:07 | |
| openstackjenkins | Project nova-docs build #1,621: SUCCESS in 2 min 12 sec: https://jenkins.openstack.org/job/nova-docs/1621/ | 20:08 |
| openstackjenkins | alex.meade: Converting delete to use instance objects | 20:08 |
| *** dtroyer has joined #openstack-dev | 20:09 | |
| *** dolphm has joined #openstack-dev | 20:09 | |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: Bug #888719: openvswitch-nova runs after firstboot scripts https://review.openstack.org/1510 | 20:13 |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: nova-manage: exit with status 1 if an image registration fails https://review.openstack.org/1490 | 20:13 |
| *** dtroyer has quit IRC | 20:13 | |
| uvirtbot | Launchpad bug 888719 in nova "openvswitch-nova runs after firstboot scripts" [Undecided,In progress] https://launchpad.net/bugs/888719 | 20:13 |
| *** dtroyer has joined #openstack-dev | 20:14 | |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Bug-888448: - Changes to allow validate token call return user name as per contract. https://review.openstack.org/1509 | 20:16 |
| *** bcwaldon has quit IRC | 20:17 | |
| *** dolphm has quit IRC | 20:17 | |
| *** dolphm has joined #openstack-dev | 20:18 | |
| *** darraghb has quit IRC | 20:18 | |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Bug-888448: - Changes to allow validate token call return user name as per contract. - Additional test asserttions to test the same. https://review.openstack.org/1509 | 20:20 |
| *** dtroyer has quit IRC | 20:21 | |
| *** dtroyer has joined #openstack-dev | 20:22 | |
| *** dwalleck has quit IRC | 20:22 | |
| *** dolphm_ has joined #openstack-dev | 20:23 | |
| *** dolphm has quit IRC | 20:23 | |
| openstackgerrit | A change to openstack/keystone has been rejected: Test for service catalog with unscoped token https://review.openstack.org/1418 | 20:23 |
| openstackgerrit | Dan Prince proposed a change to openstack/openstack-chef: Add 'auth-context' to the glance keystone pipeline. https://review.openstack.org/1511 | 20:24 |
| *** dwalleck has joined #openstack-dev | 20:26 | |
| openstackgerrit | Dan Prince proposed a change to openstack/openstack-chef: Update the glance::load_images recipe to source openstackrc if it exists. https://review.openstack.org/1512 | 20:27 |
| *** jsavak has quit IRC | 20:28 | |
| *** nati2 has quit IRC | 20:28 | |
| blamar | soren, vishy: sorry, meetings and such | 20:29 |
| *** joesavak has joined #openstack-dev | 20:29 | |
| blamar | soren: wasn't trying to *really* argue against, just not in favor of :) I think it should go in I just won't push the button if that makes sense | 20:30 |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: Bug #888730: vmwareapi suds debug logging very verbose https://review.openstack.org/1513 | 20:30 |
| uvirtbot | Launchpad bug 888730 in nova "vmwareapi suds debug logging very verbose" [Undecided,In progress] https://launchpad.net/bugs/888730 | 20:30 |
| blamar | soren: you make a fine point in that it does help the stability of the code as it is today, if I can help refactor it to rely less on the fake in the future than thats on me | 20:30 |
| *** jeblair has quit IRC | 20:37 | |
| dolphm_ | ttx: what are your thoughts on a "release" process for our stable/diablo branch? I believe all the patches we want in that branch are there, and I've put together some release notes for what's there | 20:38 |
| openstackgerrit | Kevin L. Mitchell proposed a change to openstack/nova: Fix a notification bug when creating instances https://review.openstack.org/1514 | 20:40 |
| *** jeblair has joined #openstack-dev | 20:42 | |
| openstackgerrit | Daryl Walleck proposed a change to openstack/openstack-integration-tests: Added server details tests. Also re-added several files that somehow missed the initial commit https://review.openstack.org/1515 | 20:47 |
| *** dtroyer has quit IRC | 20:47 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/glance: Removing assertGreaterEqual https://review.openstack.org/1516 | 20:48 |
| *** dtroyer has joined #openstack-dev | 20:49 | |
| *** crobinso has quit IRC | 20:49 | |
| *** statik has quit IRC | 20:52 | |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Convert pause/unpause, sus/res to use instance obj https://review.openstack.org/1517 | 20:56 |
| *** mnour has joined #openstack-dev | 20:56 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting metadata calls to use instance objects https://review.openstack.org/1518 | 21:00 |
| *** ayoung has quit IRC | 21:01 | |
| *** dwalleck has quit IRC | 21:09 | |
| soren | blamar: I would love to see a different pattern that would yield similar results. I've used this on in the past to great effect. There's some overhead involved in building the fake to begin with, but expanding on it as needs arise isn't much of a problem, and the benefit reaped by not depending on the real thing is well worth it, IME. | 21:10 |
| soren | blamar: But if you're not comfortable +2'ing, that's cool. I don't mind extra eyes on there before it lands :) | 21:11 |
| soren | blamar: I'm positive there are places where this strategy isn't going to work out, though. No doubt about that. | 21:12 |
| soren | blamar: Or even bad implementations for the exact same scenario. :) | 21:12 |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Convert pause/unpause, sus/res to use instance obj https://review.openstack.org/1519 | 21:17 |
| *** dwalleck has joined #openstack-dev | 21:18 | |
| *** ayoung has joined #openstack-dev | 21:18 | |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Convert pause/unpause, sus/res to use instance obj https://review.openstack.org/1519 | 21:19 |
| *** mattstep has quit IRC | 21:21 | |
| *** ayoung has quit IRC | 21:25 | |
| *** joesavak has quit IRC | 21:26 | |
| *** joesavak has joined #openstack-dev | 21:32 | |
| *** mattstep has joined #openstack-dev | 21:32 | |
| *** jakedahn has joined #openstack-dev | 21:33 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting set password to use instance objects https://review.openstack.org/1520 | 21:35 |
| *** dolphm_ has quit IRC | 21:39 | |
| *** lorin1 has quit IRC | 21:41 | |
| openstackgerrit | Brian Lamar proposed a change to openstack/nova: Follow hostname RFCs https://review.openstack.org/1484 | 21:44 |
| *** dwalleck_ has joined #openstack-dev | 21:47 | |
| *** dwalleck has quit IRC | 21:47 | |
| *** dolphm has joined #openstack-dev | 21:47 | |
| openstackgerrit | Alex Meade proposed a change to openstack/nova: Convert pause/unpause, sus/res to use instance obj https://review.openstack.org/1521 | 21:49 |
| *** dwalleck_ has quit IRC | 21:49 | |
| *** rods has quit IRC | 21:51 | |
| *** joesavak has quit IRC | 21:52 | |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: Bug #888730: vmwareapi suds debug logging very verbose https://review.openstack.org/1513 | 21:53 |
| uvirtbot | Launchpad bug 888730 in nova "vmwareapi suds debug logging very verbose" [Undecided,In progress] https://launchpad.net/bugs/888730 | 21:53 |
| *** nati2 has joined #openstack-dev | 21:54 | |
| *** negronjl has quit IRC | 21:56 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting inject_file to use instance objects https://review.openstack.org/1522 | 21:57 |
| openstackgerrit | Ewan Mellor proposed a change to openstack/nova: Bug #888719: openvswitch-nova runs after firstboot scripts https://review.openstack.org/1510 | 21:58 |
| uvirtbot | Launchpad bug 888719 in nova "openvswitch-nova runs after firstboot scripts" [Undecided,In progress] https://launchpad.net/bugs/888719 | 21:58 |
| *** AlanClark has quit IRC | 21:59 | |
| *** dolphm has quit IRC | 22:02 | |
| *** stuntmachine has quit IRC | 22:03 | |
| *** dolphm has joined #openstack-dev | 22:03 | |
| *** rkukura has quit IRC | 22:04 | |
| *** rods has joined #openstack-dev | 22:05 | |
| *** dolphm has quit IRC | 22:07 | |
| openstackjenkins | Project nova-docs build #1,622: SUCCESS in 2 min 17 sec: https://jenkins.openstack.org/job/nova-docs/1622/ | 22:08 |
| openstackjenkins | alex.meade: Converting start and stop to use instance objects | 22:08 |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting inject_file to use instance objects https://review.openstack.org/1522 | 22:16 |
| *** negronjl has joined #openstack-dev | 22:19 | |
| *** Rajaram has joined #openstack-dev | 22:22 | |
| *** dwalleck has joined #openstack-dev | 22:26 | |
| *** bcwaldon has joined #openstack-dev | 22:26 | |
| *** sandywalsh_ has quit IRC | 22:28 | |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting rescue/unrescue to use instance objects https://review.openstack.org/1523 | 22:29 |
| openstackgerrit | Dean Troyer proposed a change to openstack/openstack-integration-tests: Fix rabbitmq login https://review.openstack.org/1524 | 22:29 |
| *** bcwaldon has quit IRC | 22:37 | |
| *** negronjl has quit IRC | 22:39 | |
| *** jog0 has quit IRC | 22:39 | |
| openstackgerrit | Daryl Walleck proposed a change to openstack/openstack-integration-tests: Added server details tests. Also re-added several files that somehow missed the initial commit https://review.openstack.org/1515 | 22:40 |
| *** jog0 has joined #openstack-dev | 22:43 | |
| *** jog0 has left #openstack-dev | 22:44 | |
| openstackgerrit | Kevin L. Mitchell proposed a change to openstack/nova: Fix a notification bug when creating instances https://review.openstack.org/1514 | 22:47 |
| *** negronjl has joined #openstack-dev | 22:55 | |
| *** jakedahn has quit IRC | 22:55 | |
| *** jakedahn has joined #openstack-dev | 22:56 | |
| *** Vek has quit IRC | 22:59 | |
| *** mdomsch has quit IRC | 23:01 | |
| *** rnirmal has quit IRC | 23:01 | |
| *** mdomsch has joined #openstack-dev | 23:07 | |
| *** sleepsontheflo-1 has quit IRC | 23:08 | |
| *** kbringard has left #openstack-dev | 23:08 | |
| *** mgius has quit IRC | 23:09 | |
| *** jakedahn has quit IRC | 23:10 | |
| *** lts has quit IRC | 23:14 | |
| *** code_franco has quit IRC | 23:17 | |
| openstackjenkins | Project nova-docs build #1,623: SUCCESS in 2 min 13 sec: https://jenkins.openstack.org/job/nova-docs/1623/ | 23:18 |
| openstackjenkins | ewan.mellor: nova-manage: exit with status 1 if an image registration fails | 23:18 |
| *** dwalleck has quit IRC | 23:19 | |
| *** dwalleck has joined #openstack-dev | 23:20 | |
| openstackgerrit | Rick Harris proposed a change to openstack/glance: Adding admin_token to image-cache config. https://review.openstack.org/1525 | 23:23 |
| *** mnour has quit IRC | 23:25 | |
| *** dwalleck has quit IRC | 23:25 | |
| tr3buchet | vishy: can you set drafter on these to nova-network | 23:32 |
| tr3buchet | vishy: https://blueprints.launchpad.net/nova/+spec/melange-api | 23:32 |
| tr3buchet | vishy: https://blueprints.launchpad.net/nova/+spec/melange-ipam | 23:32 |
| tr3buchet | vishy: https://blueprints.launchpad.net/nova/+spec/security-group-rule-icmp | 23:32 |
| openstackgerrit | Rick Harris proposed a change to openstack/glance: Using Keystone's new port number 35357. https://review.openstack.org/1526 | 23:33 |
| openstackgerrit | Kevin L. Mitchell proposed a change to openstack/nova: Fix a notification bug when creating instances https://review.openstack.org/1514 | 23:35 |
| openstackjenkins | Project nova-docs build #1,624: SUCCESS in 2 min 20 sec: https://jenkins.openstack.org/job/nova-docs/1624/ | 23:38 |
| openstackjenkins | ahmad.hassan: Capture exceptions happening in API layer | 23:38 |
| vishy | tr3buchet: done, although I think all of those can be abandoned | 23:43 |
| tr3buchet | vishy: yeah chances are | 23:44 |
| *** rods has quit IRC | 23:44 | |
| tr3buchet | i just want to get them all on the list so i can send out an email asking for statuses on everything | 23:44 |
| openstackgerrit | Brian Waldon proposed a change to openstack/nova: Converting rescue/unrescue to use instance objects https://review.openstack.org/1523 | 23:48 |
| openstackgerrit | Yogeshwar Srikrishnan proposed a change to openstack/keystone: Bug 888448: - Changes to allow validate token call return user name as per contract. - Additional test assertions to test the same. https://review.openstack.org/1509 | 23:50 |
| uvirtbot | Launchpad bug 888448 in keystone "auth_token.py of keystone error when I use glance" [Critical,Confirmed] https://launchpad.net/bugs/888448 | 23:50 |
| *** yogirackspace has left #openstack-dev | 23:54 | |
| *** rods has joined #openstack-dev | 23:56 | |
| *** jeffjapan has joined #openstack-dev | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
