openstackgerrit | Rohit Karajgi proposed a change to openstack/tempest: Handle 404 Not found variations https://review.openstack.org/2126 | 00:00 |
---|---|---|
*** markvoelker has quit IRC | 00:02 | |
openstackgerrit | Verification of a change to openstack/keystone failed: Split version code into its own file. https://review.openstack.org/2117 | 00:13 |
openstackgerrit | Verification of a change to openstack/keystone failed: Split version code into its own file. https://review.openstack.org/2117 | 00:13 |
*** zul has joined #openstack-dev | 00:15 | |
*** rnirmal has quit IRC | 00:17 | |
*** hugokuo has quit IRC | 00:25 | |
*** jakedahn has quit IRC | 00:26 | |
*** dragondm has quit IRC | 00:27 | |
*** sleepsonthefloo has quit IRC | 00:29 | |
jeblair | mtaylor, zns: https://jenkins.openstack.org/view/Glance/job/glance-venv/36/console | 00:29 |
jeblair | keystone/__init__.py imports keystone.common.config which imports paste | 00:30 |
mtaylor | so from keystone import version _still_ runs __init__.py? | 00:30 |
* mtaylor cries | 00:30 | |
jeblair | yeah, you have to be careful what you put in __init__ | 00:31 |
mtaylor | what about import keystone.version ? | 00:31 |
*** AlanClark has quit IRC | 00:31 | |
jkoelker | it will still run init in keystone since __init__.py is the keystone namespace that version gets added to | 00:32 |
mtaylor | yeah. good point | 00:32 |
mtaylor | bother | 00:32 |
mtaylor | so the answer here is that we need to remove that code from keystone/__init__.py in general | 00:32 |
jeblair | personally, i'd say we should remove _a lot_ of code from __init__.py | 00:33 |
jeblair | compare it to nova or glance, both have very short __init__.py's. keystone has code in there. | 00:34 |
mtaylor | it's the server class | 00:34 |
jeblair | it's the top level namespace doing double duty as the server class | 00:34 |
*** anotherjesse has quit IRC | 00:38 | |
jeblair | bug 901018 | 00:41 |
uvirtbot | Launchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [Undecided,New] https://launchpad.net/bugs/901018 | 00:41 |
openstackgerrit | Monty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py. https://review.openstack.org/2127 | 00:46 |
openstackgerrit | Monty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py. https://review.openstack.org/2127 | 00:47 |
mtaylor | oops. pep8. fixed | 00:47 |
mtaylor | jeblair: ^^ | 00:47 |
*** rods has joined #openstack-dev | 00:48 | |
*** rods has quit IRC | 00:49 | |
*** rods has joined #openstack-dev | 00:49 | |
*** rods has quit IRC | 00:52 | |
*** rods has joined #openstack-dev | 00:52 | |
*** gyee has quit IRC | 00:54 | |
jeblair | mtaylor: reviewed | 00:54 |
*** ayoung has joined #openstack-dev | 00:54 | |
*** reed has joined #openstack-dev | 00:55 | |
*** negronjl has quit IRC | 00:59 | |
openstackgerrit | Monty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py. https://review.openstack.org/2127 | 00:59 |
mtaylor | jeblair: k. all good points. fixed | 00:59 |
*** adjohn has joined #openstack-dev | 01:01 | |
openstackgerrit | Monty Taylor proposed a change to openstack/keystone: Removed Server class from __init__.py. https://review.openstack.org/2127 | 01:01 |
*** rods has quit IRC | 01:05 | |
*** ohnoimdead has quit IRC | 01:13 | |
*** spiffxp has quit IRC | 01:13 | |
*** jmckenty has quit IRC | 01:13 | |
*** _adjohn has joined #openstack-dev | 01:14 | |
*** adjohn has quit IRC | 01:14 | |
*** _adjohn is now known as adjohn | 01:14 | |
*** beekhof_ has quit IRC | 01:19 | |
*** lloydde has quit IRC | 01:22 | |
openstackgerrit | andrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint InstanceAndFloatingIPDNSForNova. https://review.openstack.org/1910 | 01:31 |
*** zns has joined #openstack-dev | 01:31 | |
openstackgerrit | andrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint blueprint public-and-private-dns https://review.openstack.org/1910 | 01:32 |
*** spiffxp has joined #openstack-dev | 01:33 | |
*** rohitk has quit IRC | 01:33 | |
*** Mandell_ has joined #openstack-dev | 01:38 | |
*** Mandell has quit IRC | 01:38 | |
*** rohitk has joined #openstack-dev | 01:39 | |
*** vladimir3p has quit IRC | 01:47 | |
*** mwhooker has quit IRC | 01:47 | |
openstackgerrit | Lorin Hochstein proposed a change to openstack-ci/git-review: Fix bug 901030 https://review.openstack.org/2129 | 01:51 |
uvirtbot | Launchpad bug 901030 in git-review "git review -d fails if topic is blank" [Undecided,New] https://launchpad.net/bugs/901030 | 01:51 |
*** novas0x2a|laptop has quit IRC | 01:58 | |
*** beekhof_ has joined #openstack-dev | 01:58 | |
*** rsampaio has joined #openstack-dev | 02:13 | |
*** jog0 has quit IRC | 02:22 | |
*** maplebed has quit IRC | 02:29 | |
openstackjenkins | Project nova-docs build #1,729: SUCCESS in 3 min 23 sec: https://jenkins.openstack.org/job/nova-docs/1729/ | 02:34 |
openstackjenkins | jogo: Remove bzr related code in tests/test_misc | 02:34 |
*** spiffxp has quit IRC | 02:40 | |
*** negronjl has joined #openstack-dev | 02:44 | |
*** winston-d has quit IRC | 02:46 | |
*** andrewbogott has quit IRC | 02:48 | |
openstackjenkins | Project nova-docs build #1,730: SUCCESS in 3 min 0 sec: https://jenkins.openstack.org/job/nova-docs/1730/ | 02:48 |
openstackjenkins | mark.washenberger: vm_state:=error on driver exceptions during resize | 02:48 |
*** ben_duyujie has joined #openstack-dev | 02:54 | |
*** rsampaio has quit IRC | 02:57 | |
*** rohitk has quit IRC | 03:07 | |
*** rsampaio has joined #openstack-dev | 03:09 | |
openstackgerrit | Gaurav Gupta proposed a change to openstack/nova: Added support for creating nova volume snapshots using OS API. https://review.openstack.org/1202 | 03:10 |
*** bcwaldon has joined #openstack-dev | 03:11 | |
*** jog0_ has joined #openstack-dev | 03:18 | |
*** novas0x2a|laptop has joined #openstack-dev | 03:21 | |
*** adjohn has quit IRC | 03:28 | |
*** mikeyp has left #openstack-dev | 03:32 | |
*** CampbellM has joined #openstack-dev | 03:32 | |
*** CampbellM has quit IRC | 03:36 | |
*** rsampaio has quit IRC | 03:38 | |
*** adjohn has joined #openstack-dev | 03:40 | |
*** spiffxp has joined #openstack-dev | 03:43 | |
*** nati2 has quit IRC | 03:46 | |
*** nati2 has joined #openstack-dev | 03:47 | |
openstackgerrit | Dan Prince proposed a change to openstack/keystone: Fix auth_token middleware: make _verify_claims not static. Fixes bug #901049. https://review.openstack.org/2130 | 03:49 |
*** rohitk has joined #openstack-dev | 03:49 | |
uvirtbot | Launchpad bug 901049 in keystone "auth_token middleware: global name 'self' is not defined" [Undecided,In progress] https://launchpad.net/bugs/901049 | 03:49 |
*** dprince has joined #openstack-dev | 03:50 | |
dprince | keystone devs: https://review.openstack.org/#change,2130 | 03:50 |
*** rnirmal has joined #openstack-dev | 03:50 | |
dprince | send this ^^^ | 03:50 |
*** dprince has quit IRC | 03:51 | |
zns | dprince: approved | 03:52 |
*** jeremy has quit IRC | 03:52 | |
*** jeremy has joined #openstack-dev | 03:54 | |
*** jeremy has joined #openstack-dev | 03:54 | |
*** CampbellM has joined #openstack-dev | 03:54 | |
*** CampbellM has quit IRC | 03:55 | |
*** lts has quit IRC | 03:58 | |
*** Rajaram has joined #openstack-dev | 03:59 | |
*** nati2 has quit IRC | 04:00 | |
*** anotherjesse has joined #openstack-dev | 04:02 | |
*** nati2 has joined #openstack-dev | 04:02 | |
*** lloydde has joined #openstack-dev | 04:03 | |
*** adjohn has quit IRC | 04:04 | |
*** bcwaldon has quit IRC | 04:05 | |
*** jeremy has quit IRC | 04:06 | |
*** jeremy has joined #openstack-dev | 04:08 | |
*** jeremy has joined #openstack-dev | 04:08 | |
*** anotherjesse has quit IRC | 04:11 | |
*** troytoman-away has quit IRC | 04:13 | |
*** troytoman-away has joined #openstack-dev | 04:17 | |
openstackjenkins | Project nova-docs build #1,731: SUCCESS in 3 min 3 sec: https://jenkins.openstack.org/job/nova-docs/1731/ | 04:18 |
openstackjenkins | alex.meade: Change cloudServersFault to computeFault | 04:18 |
*** nati2 has quit IRC | 04:25 | |
*** nati2 has joined #openstack-dev | 04:26 | |
*** bencherian has quit IRC | 04:31 | |
*** jog0_ has quit IRC | 04:43 | |
*** jog0 has joined #openstack-dev | 04:52 | |
*** scottjg has joined #openstack-dev | 04:55 | |
rmk | Are there any docs around VSA? | 04:58 |
rmk | Aside from the blueprints and presentations | 04:58 |
annegentle | rmk: I've asked for docs and I don't think it's fully implemented... looking... | 04:59 |
rmk | great, thanks | 04:59 |
*** adjohn has joined #openstack-dev | 05:00 | |
*** chemikadze has quit IRC | 05:05 | |
*** nati2_ has joined #openstack-dev | 05:13 | |
*** dolphm has joined #openstack-dev | 05:15 | |
*** nati2 has quit IRC | 05:17 | |
*** _adjohn has joined #openstack-dev | 05:19 | |
*** adjohn has quit IRC | 05:20 | |
*** _adjohn is now known as adjohn | 05:20 | |
*** rnirmal has quit IRC | 05:21 | |
*** hugokuo has joined #openstack-dev | 05:23 | |
*** novas0x2a|laptop has quit IRC | 05:25 | |
*** novas0x2a|laptop has joined #openstack-dev | 05:28 | |
*** bencherian has joined #openstack-dev | 05:41 | |
*** nati2_ has quit IRC | 05:52 | |
*** mjfork has quit IRC | 05:55 | |
*** bencherian has quit IRC | 06:06 | |
*** lloydde has quit IRC | 06:08 | |
*** lloydde has joined #openstack-dev | 06:08 | |
*** lloydde has quit IRC | 06:08 | |
*** markmc has joined #openstack-dev | 06:12 | |
*** spiffxp has quit IRC | 06:16 | |
*** jog0_ has joined #openstack-dev | 06:16 | |
*** jog0 has quit IRC | 06:18 | |
*** jog0_ is now known as jog0 | 06:18 | |
*** dolphm has quit IRC | 06:23 | |
*** zaitcev has quit IRC | 06:23 | |
*** jog0 has quit IRC | 06:28 | |
*** jog0 has joined #openstack-dev | 06:29 | |
*** scottjg has quit IRC | 06:42 | |
*** reed has quit IRC | 06:54 | |
*** jog0 has quit IRC | 06:56 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted. https://review.openstack.org/2131 | 07:00 |
*** Mandell_ has quit IRC | 07:29 | |
*** GheRivero_ has joined #openstack-dev | 07:54 | |
*** jeremy has quit IRC | 07:57 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator. https://review.openstack.org/2132 | 07:59 |
openstackgerrit | Craig Vyvial proposed a change to openstack/nova: allowing custom notification log file to be created it desired https://review.openstack.org/2133 | 08:00 |
*** jeremy has joined #openstack-dev | 08:01 | |
*** jeremy has joined #openstack-dev | 08:01 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/nova: added Craig Vyvial to Authors https://review.openstack.org/2134 | 08:03 |
*** GheRivero_ has quit IRC | 08:15 | |
*** reidrac has joined #openstack-dev | 08:16 | |
*** apevec has joined #openstack-dev | 08:32 | |
openstackgerrit | A change to openstack/nova has been rejected: added Craig Vyvial to Authors https://review.openstack.org/2134 | 08:33 |
*** jeffjapan has quit IRC | 08:41 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Adds runing_deleted_instance reaper task. https://review.openstack.org/2135 | 08:43 |
*** pixelbeat has joined #openstack-dev | 08:57 | |
openstackgerrit | Ziad Sawalha proposed a change to openstack/keystone: D5 Compatibility Support https://review.openstack.org/2136 | 08:59 |
*** zns has quit IRC | 09:04 | |
*** adjohn has quit IRC | 09:07 | |
*** adjohn has joined #openstack-dev | 09:11 | |
*** novas0x2a|laptop has quit IRC | 09:19 | |
*** ben_duyujie has left #openstack-dev | 09:22 | |
*** novas0x2a|laptop has joined #openstack-dev | 09:23 | |
*** novas0x2a|laptop has quit IRC | 09:34 | |
*** novas0x2a|laptop has joined #openstack-dev | 09:35 | |
*** darraghb has joined #openstack-dev | 09:56 | |
*** yamahata has joined #openstack-dev | 10:07 | |
*** adjohn has quit IRC | 10:12 | |
*** Diaoer has joined #openstack-dev | 10:27 | |
*** Diaoer has quit IRC | 10:28 | |
*** Diaoer has joined #openstack-dev | 10:29 | |
*** Diaoer has quit IRC | 10:32 | |
*** Diaoer has joined #openstack-dev | 10:33 | |
*** aryan has joined #openstack-dev | 10:39 | |
*** novas0x2a|laptop has quit IRC | 10:46 | |
*** novas0x2a|laptop has joined #openstack-dev | 10:47 | |
*** reidrac has quit IRC | 11:23 | |
*** hugokuo has quit IRC | 11:24 | |
*** reidrac has joined #openstack-dev | 11:24 | |
*** novas0x2a|laptop has quit IRC | 11:33 | |
*** reidrac has quit IRC | 11:34 | |
*** novas0x2a|laptop has joined #openstack-dev | 11:34 | |
*** rkukura has quit IRC | 11:45 | |
*** lts has joined #openstack-dev | 11:53 | |
*** bourke_ is now known as bourke | 11:54 | |
*** reidrac has joined #openstack-dev | 12:02 | |
openstackgerrit | Gavin Brebner proposed a change to openstack/tempest: removed extra whitespace. Updated fix for bug 893845 https://review.openstack.org/2137 | 12:24 |
openstackgerrit | Gavin Brebner proposed a change to openstack/tempest: Added test_create_server_metadata_key_too_long to address https://bugs.launchpad.net/tempest/+bug/893845 https://review.openstack.org/2034 | 12:24 |
uvirtbot | Launchpad bug 893845 in tempest "Server metadata key exceeds 255 bytes" [Medium,In progress] https://launchpad.net/bugs/893845 | 12:24 |
uvirtbot | Launchpad bug 893845 in tempest "Server metadata key exceeds 255 bytes" [Medium,In progress] | 12:24 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/keystone: Fix some issues with new version module https://review.openstack.org/2138 | 12:27 |
*** reidrac has quit IRC | 12:32 | |
*** stuntmachine has joined #openstack-dev | 12:36 | |
*** stuntmachine has quit IRC | 12:38 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/glance: Add generic PasteDeploy app and filter factories https://review.openstack.org/2139 | 12:43 |
*** markvoelker has joined #openstack-dev | 12:47 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/glance: Rename 'options' variables to 'conf' https://review.openstack.org/2140 | 12:48 |
*** hugokuo has joined #openstack-dev | 12:50 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/glance: Add new cfg module https://review.openstack.org/2141 | 12:53 |
*** novas0x2a|laptop has quit IRC | 12:57 | |
*** reidrac has joined #openstack-dev | 12:57 | |
*** novas0x2a|laptop has joined #openstack-dev | 12:59 | |
*** reidrac has quit IRC | 13:07 | |
*** bsza has joined #openstack-dev | 13:09 | |
*** Shrews has joined #openstack-dev | 13:12 | |
*** rods has joined #openstack-dev | 13:16 | |
*** zns has joined #openstack-dev | 13:18 | |
*** reidrac has joined #openstack-dev | 13:20 | |
*** zns has quit IRC | 13:26 | |
*** rods has quit IRC | 13:36 | |
*** mjfork has joined #openstack-dev | 13:37 | |
*** dolphm has joined #openstack-dev | 13:39 | |
*** reidrac has quit IRC | 13:43 | |
*** dolphm has quit IRC | 13:44 | |
*** smoser has quit IRC | 13:44 | |
*** reidrac has joined #openstack-dev | 13:44 | |
*** Rajaram has quit IRC | 13:45 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/glance: Convert glance to use the new cfg module https://review.openstack.org/2142 | 13:53 |
*** zns has joined #openstack-dev | 13:56 | |
*** lloydde has joined #openstack-dev | 14:09 | |
openstackgerrit | Thierry Carrez proposed a change to openstack/nova: A more secure root-wrapper alternative https://review.openstack.org/2101 | 14:10 |
*** reidrac has quit IRC | 14:12 | |
*** gavri has quit IRC | 14:12 | |
*** ben_duyujie has joined #openstack-dev | 14:13 | |
*** Adri2000 has quit IRC | 14:14 | |
*** kbringard has joined #openstack-dev | 14:15 | |
*** rkukura has joined #openstack-dev | 14:19 | |
*** Adri2000 has joined #openstack-dev | 14:24 | |
openstackgerrit | Dan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes #901018. https://review.openstack.org/2143 | 14:24 |
openstackgerrit | Dan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes #901018. https://review.openstack.org/2143 | 14:26 |
zns | dprince: we fixed the Glance issue; this among other fixes - https://review.openstack.org/#change,2117 | 14:27 |
zns | dprince: don't we need keystone in glance? | 14:27 |
*** troytoman-away is now known as troytoman | 14:27 | |
*** reidrac has joined #openstack-dev | 14:29 | |
*** rkukura has quit IRC | 14:36 | |
*** gavri has joined #openstack-dev | 14:41 | |
markmc | zns, glance's install_venv.py still doesn't work, though | 14:42 |
markmc | zns, I definitely saw keystone's setup.py trying to import PasteDeploy before it had been installed | 14:43 |
zns | Do you have a failed build in Jenkins I can look at? | 14:43 |
markmc | zns, when I did get it installed into the venv, glance's tests were failing because of this: https://review.openstack.org/2138 | 14:44 |
markmc | zns, this looks like it: https://jenkins.openstack.org/view/Glance/job/glance-venv/36/console | 14:44 |
*** bcwaldon has joined #openstack-dev | 14:47 | |
*** mattray has joined #openstack-dev | 14:49 | |
zns | markmc, dprince: might need to get this in and retry: https://review.openstack.org/#change,2127 | 14:51 |
*** mdomsch has joined #openstack-dev | 14:55 | |
openstackgerrit | Ziad Sawalha proposed a change to openstack/keystone: Removed Server class from __init__.py. https://review.openstack.org/2127 | 14:59 |
*** lloydde has quit IRC | 15:02 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/keystone: Fix some issues with new version module https://review.openstack.org/2138 | 15:08 |
*** dolphm has joined #openstack-dev | 15:08 | |
*** zns1 has joined #openstack-dev | 15:08 | |
*** hub_cap has joined #openstack-dev | 15:08 | |
*** zns has quit IRC | 15:11 | |
kbringard | do we know if source security groups is working in the latest essex drops? | 15:19 |
kbringard | http://paste.openstack.org/show/3676/ | 15:19 |
kbringard | that's using, what I believe is the latest diablo backport | 15:20 |
*** jmckenty has joined #openstack-dev | 15:24 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Remove extra_context support in Flags https://review.openstack.org/2145 | 15:26 |
*** dolphm has quit IRC | 15:26 | |
*** rsampaio has joined #openstack-dev | 15:26 | |
*** novas0x2a|laptop has quit IRC | 15:28 | |
*** novas0x2a|laptop has joined #openstack-dev | 15:29 | |
openstackgerrit | A change to openstack/glance has been rejected: Remove keystone from pip-requires. Fixes bug #901018. https://review.openstack.org/2143 | 15:30 |
uvirtbot | Launchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/901018 | 15:30 |
openstackgerrit | Dan Prince proposed a change to openstack/glance: Remove keystone from pip-requires. Fixes bug #901018. https://review.openstack.org/2143 | 15:32 |
uvirtbot | Launchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/901018 | 15:32 |
*** Rajaram has joined #openstack-dev | 15:33 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Add new cfg module https://review.openstack.org/2146 | 15:33 |
*** lloydde has joined #openstack-dev | 15:36 | |
*** bencherian has joined #openstack-dev | 15:39 | |
*** dubsquared has joined #openstack-dev | 15:40 | |
*** zns1 has quit IRC | 15:40 | |
*** dolphm has joined #openstack-dev | 15:42 | |
*** vladimir3p has joined #openstack-dev | 15:45 | |
*** reed has joined #openstack-dev | 15:49 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/nova: Port nova.flags to cfg https://review.openstack.org/2147 | 15:52 |
*** jaypipes has quit IRC | 15:53 | |
*** code_franco has joined #openstack-dev | 15:55 | |
*** rnirmal has joined #openstack-dev | 15:58 | |
zul | ttx: so for the rootwrapper if someone adds a command that needs root they have to modify the rootwrapper? | 16:02 |
*** adjohn has joined #openstack-dev | 16:03 | |
ttx | zul: they have to modify the corresponsing list of filters, yes | 16:03 |
*** cp16net has joined #openstack-dev | 16:04 | |
openstackgerrit | Andrea Rosa proposed a change to openstack/nova: Exception handler for kombu connnection https://review.openstack.org/1503 | 16:05 |
*** hugokuo has left #openstack-dev | 16:11 | |
*** lloydde has quit IRC | 16:11 | |
*** reidrac has quit IRC | 16:14 | |
openstackgerrit | Brian Waldon proposed a change to openstack/python-novaclient: Clean up image-list cli command https://review.openstack.org/2148 | 16:15 |
*** ben_duyujie has quit IRC | 16:17 | |
*** spiffxp has joined #openstack-dev | 16:17 | |
*** jaypipes has joined #openstack-dev | 16:17 | |
*** rkukura has joined #openstack-dev | 16:19 | |
*** mdomsch has quit IRC | 16:19 | |
jaypipes | bcwaldon: heyo, could you ping dprince this morning when he gets in... let him know I'm available on IRC to chat about the functional integration tests stuff... | 16:25 |
bcwaldon | yeah | 16:25 |
jaypipes | bcwaldon: thx! | 16:25 |
bcwaldon | he's working on getting on irc | 16:25 |
jaypipes | bcwaldon: coolio. :) | 16:25 |
bcwaldon | too many people on the network here on freenode | 16:26 |
jaypipes | bcwaldon: seriously? wow... | 16:26 |
jaypipes | bcwaldon: I'm the only one in my office ;) | 16:27 |
bcwaldon | Yep, I have to get on VPN to get on IRC | 16:27 |
bcwaldon | lucky | 16:27 |
openstackgerrit | A change to openstack/glance has been rejected: Comment out keystone from pip-requires. Fixes bug #901018. https://review.openstack.org/2143 | 16:28 |
uvirtbot | Launchpad bug 901018 in keystone "setup.py imports keystone before dependencies are satisfied" [High,In progress] https://launchpad.net/bugs/901018 | 16:28 |
jaypipes | Vek: ping | 16:29 |
*** zaitcev has joined #openstack-dev | 16:29 | |
jaypipes | FYI, 30 minutes until QA team meeting on #openstack-meeting | 16:30 |
bcwaldon | jaypipes: thanks for the reminder | 16:31 |
Shrews | jaypipes: yo man. long time no chat | 16:32 |
jaypipes | Shrews: holy crap! :) how are ya? | 16:32 |
Shrews | jaypipes: good. i heard the cool kids were hanging out here now. thought i'd check it out. | 16:33 |
jaypipes | Shrews: :) | 16:33 |
*** bencherian has quit IRC | 16:35 | |
openstackgerrit | Brian Waldon proposed a change to openstack/python-novaclient: Clean up image-show https://review.openstack.org/2149 | 16:41 |
*** cp16net has left #openstack-dev | 16:43 | |
*** cp16net has joined #openstack-dev | 16:43 | |
*** novas0x2a|laptop has quit IRC | 16:47 | |
cp16net | if you submit something to gerrit for review there is no button to say hey i really didnt mean to is there? | 16:48 |
jeblair | cp16net: "Abandon change" | 16:48 |
cp16net | oh :) i guess i could have used that last night... thx | 16:49 |
*** lorin1 has joined #openstack-dev | 16:51 | |
*** zns has joined #openstack-dev | 16:57 | |
*** maplebed has joined #openstack-dev | 16:59 | |
*** jmckenty has quit IRC | 17:00 | |
openstackgerrit | Brian Waldon proposed a change to openstack/nova: Clean up snapshot metadata https://review.openstack.org/2150 | 17:01 |
*** lloydde has joined #openstack-dev | 17:01 | |
*** Diaoer has quit IRC | 17:03 | |
openstackjenkins | Project nova-docs build #1,732: SUCCESS in 3 min 37 sec: https://jenkins.openstack.org/job/nova-docs/1732/ | 17:04 |
openstackjenkins | Mark McLoughlin: Remove extra_context support in Flags | 17:04 |
*** code_franco has quit IRC | 17:09 | |
*** code_franco_ has joined #openstack-dev | 17:09 | |
*** code_franco_ is now known as code_franco | 17:09 | |
*** sleepsonthefloo has joined #openstack-dev | 17:10 | |
zns | markmc: Glance build went through: https://jenkins.openstack.org/view/Glance/job/glance-venv/38/. Was that the fix we did in Keystone or did you guys change anything? | 17:10 |
markmc | zns, not 100% sure, but your moving Server out of keystone/__init__.py looked like a plausible fix for it | 17:11 |
markmc | zns, without this https://review.openstack.org/#change,2138 glance's functional tests will still fail, though | 17:12 |
markmc | zns, I hope you're ready for glance folks hunting you down everytime something breaks in keystone ? :) | 17:12 |
zns | markmc: It will keep the momentum and pressure on us to get where nothing breaks in Keystone ;-) | 17:14 |
*** dspano has joined #openstack-dev | 17:14 | |
* markmc kicks off a glance build in jenkins for giggles | 17:15 | |
*** bencherian has joined #openstack-dev | 17:16 | |
markmc | jeblair, any idea on this? https://jenkins.openstack.org/view/Glance/job/glance/89371/console | 17:16 |
markmc | jeblair, also, should venv rebuilds kick off any jobs that use the venv? | 17:16 |
*** f-yang has quit IRC | 17:17 | |
zns | Vek: can you re-approve https://review.openstack.org/#change,1825? | 17:18 |
jeblair | markmc: that job is only meant to run from a gerrit trigger | 17:18 |
jeblair | markmc: you can re-trigger a previous run, or trigger by searching for a change | 17:19 |
openstackgerrit | Brian Waldon proposed a change to openstack/nova: Clean up snapshot metadata https://review.openstack.org/2150 | 17:19 |
markmc | jeblair, oh, interesting | 17:19 |
jeblair | markmc: what's your overall intent? | 17:19 |
* markmc plays around | 17:19 | |
*** rods has joined #openstack-dev | 17:19 | |
markmc | jeblair, to prove that glance tests are failing with latest keystone | 17:19 |
* markmc retriggers | 17:20 | |
openstackgerrit | Verification of a change to openstack/glance failed: Rename .glance-venv to .venv. https://review.openstack.org/2079 | 17:20 |
jeblair | oh, we can build the venv now, that's something. | 17:20 |
jeblair | markmc: 1 sec, there's a bunch of things going on here. :) | 17:21 |
zns | markmc: aren't we renaming all venv's to venv? | 17:21 |
zns | jeblair: yes, I built the venv after the Keystone change. | 17:21 |
markmc | jeblair, my favourite quote from the week so far is "Everything is fucked. I hate computers". Appropriate here? | 17:22 |
jeblair | so i had a "mv" command in the copy-venv job because we couldn't build the venv so it had the wrong name | 17:22 |
markmc | cool | 17:22 |
jeblair | i've removed the mv command, now that we have an appropriate venv | 17:22 |
* markmc retriggers again | 17:22 | |
*** adjohn has quit IRC | 17:24 | |
openstackgerrit | Verification of a change to openstack/glance failed: Rename .glance-venv to .venv. https://review.openstack.org/2079 | 17:25 |
markmc | ah, there we go | 17:25 |
markmc | zns, AttributeError: 'module' object has no attribute 'version' | 17:25 |
* markmc wanders off | 17:25 | |
*** Rajaram has quit IRC | 17:25 | |
*** nati2 has joined #openstack-dev | 17:28 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted. https://review.openstack.org/2131 | 17:29 |
*** Mandell has joined #openstack-dev | 17:30 | |
*** nati2 has quit IRC | 17:30 | |
*** nati2 has joined #openstack-dev | 17:31 | |
*** dwalleck has joined #openstack-dev | 17:41 | |
*** zns has quit IRC | 17:44 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator. https://review.openstack.org/2132 | 17:45 |
*** spiffxp has quit IRC | 17:45 | |
*** dolphm_ has joined #openstack-dev | 17:47 | |
*** adjohn has joined #openstack-dev | 17:47 | |
*** dolphm has quit IRC | 17:48 | |
*** adjohn has quit IRC | 17:50 | |
*** jog0 has joined #openstack-dev | 17:54 | |
*** reed has quit IRC | 17:55 | |
*** andrewbogott has joined #openstack-dev | 17:56 | |
*** spiffxp has joined #openstack-dev | 17:57 | |
jeblair | lorin1: https://review.openstack.org/#change,1879 | 17:59 |
lorin1 | jeblair: Hey, it's working! | 17:59 |
jeblair | lorin1: jenkins verified it, but it needs a +2 to merge now | 17:59 |
jeblair | lorin1: sorry about that, it was due to the venv caching we do on jenkins (full details in the bug) | 18:00 |
lorin1 | jeblair: It turns out I may have pre-emptively +2'd it in the first place, though. I'll +1 it for now, hopefully another nova-core can +2 it. | 18:02 |
*** gyee has joined #openstack-dev | 18:02 | |
jeblair | ok :) | 18:02 |
lorin1 | jeblair: Jenkins catching it wasn't a bug, it was a feature! | 18:02 |
*** dolphm has joined #openstack-dev | 18:02 | |
jeblair | right, it was just our bug, not duncan's. :) | 18:03 |
*** dolphm_ has quit IRC | 18:05 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Refactors periodic tasks to use a decorator. https://review.openstack.org/2132 | 18:07 |
andrewbogott | In a review, kevin mitchell writes: "There are also a couple of assignments that use '\' as well—is there any way we can get rid of that, maybe by using a temporary variable if the lines would be longer than 79 characters?" | 18:13 |
andrewbogott | I'm wondering -- is it really worth obfuscating code in order to keep the line length down? Is there some consequence to line length that I'm missing? | 18:13 |
*** nati2 has quit IRC | 18:15 | |
*** lorin1 has quit IRC | 18:15 | |
vishy | andrewbogott: the consequence is the code won't merge | 18:16 |
*** bencherian has quit IRC | 18:16 | |
vishy | :) | 18:16 |
andrewbogott | Um... because git doesn't like \'s, or because reviewers don't? | 18:17 |
andrewbogott | I mean, I can get rid of the continuation by doing this: | 18:17 |
andrewbogott | foo = utils.import_object(FLAGS.instance_dns_manager) | 18:17 |
andrewbogott | self.instance_dns_manager = foo | 18:17 |
andrewbogott | But that seems like madness! | 18:17 |
vishy | general python style is to avoid \ if at all possible | 18:17 |
vishy | so most python devs prefer other methods | 18:18 |
*** vladimir3p has quit IRC | 18:18 | |
andrewbogott | e.g. inscrutable variable names :( | 18:18 |
*** rkukura has quit IRC | 18:19 | |
vishy | well not usually :) | 18:19 |
vishy | you don't have to use foo! | 18:19 |
openstackjenkins | Project nova-docs build #1,733: SUCCESS in 4 min 3 sec: https://jenkins.openstack.org/job/nova-docs/1733/ | 18:19 |
openstackjenkins | duncan: First steps towards consolidating testing infrastructure | 18:19 |
andrewbogott | I would use 'arbitraryvariabletoavoidlinecontinuation' but that would be too long and cause a line continuation. | 18:20 |
andrewbogott | But, anyway -- I will resubmit :) | 18:21 |
vishy | andrewbogott: I think there are times when a \ is fine | 18:22 |
openstackgerrit | Johannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI list_instances https://review.openstack.org/2151 | 18:22 |
openstackgerrit | Brian Waldon proposed a change to openstack/python-novaclient: Clean up image-show https://review.openstack.org/2149 | 18:22 |
*** dwalleck has quit IRC | 18:23 | |
*** rkukura has joined #openstack-dev | 18:24 | |
*** lorin1 has joined #openstack-dev | 18:25 | |
*** lorin1 has quit IRC | 18:25 | |
*** darraghb has quit IRC | 18:28 | |
*** reidrac has joined #openstack-dev | 18:28 | |
*** lorin1 has joined #openstack-dev | 18:29 | |
*** lorin1 has quit IRC | 18:31 | |
*** lorin1 has joined #openstack-dev | 18:31 | |
*** jmckenty has joined #openstack-dev | 18:31 | |
*** novas0x2a|laptop has joined #openstack-dev | 18:32 | |
*** lorin11 has joined #openstack-dev | 18:33 | |
openstackjenkins | Project nova-docs build #1,734: SUCCESS in 3 min 32 sec: https://jenkins.openstack.org/job/nova-docs/1734/ | 18:34 |
openstackjenkins | * alex.meade: Update associate_floating_ip to use instance objs | 18:34 |
openstackjenkins | * Rick Harris: Refactors periodic tasks to use a decorator. | 18:34 |
*** lorin1 has quit IRC | 18:35 | |
mtaylor | andrewbogott: some times it gets odd, but the 99% case is that strict pep8 compliance makes the codebase easier to read | 18:38 |
*** dolphm has quit IRC | 18:38 | |
mtaylor | andrewbogott: there are, of course, cases where compliance makes you want to kill bunnies | 18:38 |
andrewbogott | Sure, I'm for short lines in the abstract. Just sad about this particular case where I need to obfuscate my code. | 18:39 |
mtaylor | agree | 18:39 |
*** adjohn has joined #openstack-dev | 18:39 | |
*** reed has joined #openstack-dev | 18:39 | |
andrewbogott | esp. since the long variable names are from a blueprint; not really up for debate. | 18:40 |
*** mdomsch has joined #openstack-dev | 18:44 | |
*** vladimir3p has joined #openstack-dev | 18:45 | |
mtaylor | troytoman: ping | 18:46 |
troytoman | mtaylor: yes? | 18:47 |
*** rohitk has quit IRC | 18:48 | |
mtaylor | troytoman: are you a good person to bug about a cloud servers ticket we've got open with no resolution? | 18:48 |
troytoman | mtaylor: i'm a good place to start. | 18:49 |
mtaylor | troytoman: ticket #258127 | 18:49 |
mtaylor | troytoman: we have a script which deletes a named image and then makes a new one | 18:49 |
mtaylor | troytoman: and we' | 18:49 |
*** lorin1 has joined #openstack-dev | 18:49 | |
mtaylor | troytoman: and we're getting errors that the image of that name already exists | 18:49 |
mtaylor | troytoman: (this is in support of openstack integration testing) | 18:50 |
troytoman | mtaylor: let me look into it | 18:50 |
mtaylor | troytoman: thank you! | 18:50 |
*** lorin11 has quit IRC | 18:52 | |
*** dolphm has joined #openstack-dev | 18:53 | |
*** dolphm has quit IRC | 18:56 | |
openstackgerrit | andrewbogott proposed a change to openstack/nova: Handle the 'instance' half of blueprint public-and-private-dns https://review.openstack.org/1910 | 18:57 |
*** lorin1 has quit IRC | 18:59 | |
*** bencherian has joined #openstack-dev | 19:00 | |
*** lorin1 has joined #openstack-dev | 19:03 | |
*** nickon has joined #openstack-dev | 19:06 | |
troytoman | mtaylor: apparently the image showed deleted in one place but not another. we've fixed it and you should be OK | 19:10 |
troytoman | mtaylor: still investigating how that happened in the first place | 19:10 |
*** dolphm has joined #openstack-dev | 19:11 | |
*** nickon has quit IRC | 19:14 | |
mtaylor | troytoman: awesome. you are a wonderful human. | 19:16 |
mtaylor | troytoman: and just for that, I'll make sure your client repo gets taken care of today :) | 19:17 |
troytoman | mtaylor: :) | 19:17 |
openstackgerrit | Brian Waldon proposed a change to openstack/python-novaclient: Clean up image-list cli command https://review.openstack.org/2148 | 19:18 |
openstackgerrit | Jake Dahn proposed a change to openstack/horizon: Merging Instances and Volumes into a single panel. https://review.openstack.org/2152 | 19:22 |
openstackgerrit | Jake Dahn proposed a change to openstack/horizon: Merging Instances and Volumes into a single panel. https://review.openstack.org/2152 | 19:25 |
*** dolphm has quit IRC | 19:28 | |
johan_-_ | is jenkins wedged? i have an approved review that's been stuck for an hour | 19:30 |
*** _adjohn has joined #openstack-dev | 19:30 | |
*** sleepsonthefloo_ has joined #openstack-dev | 19:31 | |
mtaylor | johan_-_: link/ | 19:31 |
mtaylor | ? | 19:31 |
*** reed_ has joined #openstack-dev | 19:31 | |
johan_-_ | https://review.openstack.org/#change,2151 | 19:31 |
*** sleepsonthefloo has quit IRC | 19:32 | |
*** sleepsonthefloo_ is now known as sleepsonthefloo | 19:32 | |
*** adjohn has quit IRC | 19:32 | |
*** _adjohn is now known as adjohn | 19:32 | |
*** reed has quit IRC | 19:32 | |
mtaylor | johan_-_: weird. thanks. should be running now | 19:33 |
openstackgerrit | Verification of a change to openstack/nova failed: Fix race condition in XenAPI list_instances https://review.openstack.org/2151 | 19:34 |
sandywalsh | ./run_tests.sh -N doesn't work any more | 19:37 |
sandywalsh | just returns | 19:37 |
openstackgerrit | Brian Waldon proposed a change to openstack/python-novaclient: Fixing all remaining pep8 errors https://review.openstack.org/2153 | 19:37 |
*** dwalleck has joined #openstack-dev | 19:38 | |
*** novas0x2a|laptop has quit IRC | 19:39 | |
*** novas0x2a|laptop has joined #openstack-dev | 19:40 | |
*** zns has joined #openstack-dev | 19:40 | |
*** bcwaldon has quit IRC | 19:40 | |
*** bcwaldon has joined #openstack-dev | 19:40 | |
*** dwalleck has quit IRC | 19:44 | |
sandywalsh | oubiwann (Duncan McGreggor) in the room? | 19:46 |
*** smoser has joined #openstack-dev | 19:46 | |
sandywalsh | (or whatever his nick is?) | 19:46 |
smoser | hey... i'm sure i'm missing something | 19:46 |
smoser | but looking at devstack, it has: glance add -A $SERVICE_TOKEN name="$IMAGE_NAME" is_public=true container_format=ami disk_format=ami kernel_id=$KERNEL_ID | 19:46 |
mtaylor | sandywalsh: run_tests.sh spits errors into a run_tests.log | 19:46 |
mtaylor | sandywalsh: so when it just returns like that, look in the log file | 19:47 |
smoser | that is run (i think) as normal user. SERVICE_TOKEN is basically a password. how does glance know which user is doing this ? | 19:47 |
smoser | jaypipes, ^ | 19:47 |
sandywalsh | mtaylor, thanks | 19:47 |
*** GheRivero_ has joined #openstack-dev | 19:47 | |
tr3buchet | markmc: https://review.openstack.org/#change,2028 | 19:47 |
jaypipes | smoser: the value of OS_AUTH_USER env variable. | 19:49 |
smoser | ah. ok. is there a way to specify that on command line ? | 19:49 |
jaypipes | smoser: one sec | 19:49 |
jaypipes | smoser: no, there is not apparently. | 19:52 |
jaypipes | smoser: should be though... | 19:52 |
smoser | maybe it also respects NOVA_USERNAME ? | 19:52 |
*** jakedahn has joined #openstack-dev | 19:53 | |
smoser | as devstack does not set OS_AUTH_USER afaik | 19:53 |
*** AlanClark has joined #openstack-dev | 19:54 | |
openstackgerrit | Brian Waldon proposed a change to openstack/nova: Clean up snapshot metadata https://review.openstack.org/2150 | 19:54 |
*** _adjohn has joined #openstack-dev | 19:56 | |
jaypipes | smoser: there is a tools/nova_to_os_env.sh script in Glance that copies the NOVA_XX env vars. anotherjesse and I were talking about simplifying things: http://wiki.openstack.org/CLIAuth | 19:56 |
smoser | it appears it will just magically respond | 19:56 |
*** adjohn has quit IRC | 19:57 | |
*** _adjohn is now known as adjohn | 19:57 | |
openstackgerrit | Dan Prince proposed a change to openstack/openstack-chef: Update glance::load_images to use /var/lib/glance/chef_images_loaded. https://review.openstack.org/2154 | 19:57 |
smoser | http://paste.ubuntu.com/763090/ | 19:58 |
*** adjohn has quit IRC | 19:59 | |
smoser | jaypipes, ^ . there, 'golfing' is a valid password, but i dont knwo how glance knows which user to pair that with. maybe if there is only one user, but that would seem not right anyway. | 20:01 |
jaypipes | smoser: that token must be for a specific tenant then? | 20:04 |
smoser | jaypipes, i'm extremely ignorant luser here... | 20:04 |
jaypipes | smoser: so when the auth plugin does a lookup into keystone for that token, it returns a tenantId? | 20:04 |
smoser | just using devstack and reading what it does | 20:04 |
jaypipes | smoser: hehe, no worries, so am I. :) | 20:04 |
jaypipes | smoser: devstack adds a special token for an admin user. perhaps you are using that? | 20:05 |
smoser | i'm just hoping that nothing is doing a query against all users for a password if there is no user given. | 20:05 |
smoser | how would it be using that? maybe request coming from localhost or something ? | 20:05 |
jaypipes | smoser: I have to run out for a sec :( perhaps zns could help on the question of an "admin token" and how it might determine a tenant from a token. | 20:05 |
smoser | basically... run stack.sh... . openrc ... glance add | 20:06 |
jaypipes | smoser: yes, devstack sets up keystone on localhost:5001 (and 35357 or something like that), which glance will default to I believe... | 20:06 |
andrewbogott | Has anyone run the python-novaclient tests recently? I'd expect them to work out of the box, but apparently I need something else in my environment... | 20:07 |
andrewbogott | specifically, it can't find a lot of python libs that are otherwise available to python. | 20:07 |
zns | smoser, jaypipes: GET /v2.0/tokens/:id returns the data (on the admin service, usually 35357 - I think 5001 in older configs before IANA assigned us 35357). It depends on what you are looking for. Are you looking for the tenant that the user specified when they asked for the token or are you looking to see what tenants they have access to? | 20:09 |
openstackgerrit | Gabriel Hurley proposed a change to openstack/horizon: Updated docs for the Dashboard.panels attribute to be clearer. https://review.openstack.org/2155 | 20:11 |
smoser | zns, i was just confused. i run 'env -i glance -A golfing index' | 20:11 |
smoser | so glance isn't picking up anything from environment | 20:11 |
smoser | and i get a list | 20:11 |
smoser | which i guess means it is hitting the admin port. so i guess essentially the admin password in my case is 'golfing' and glance is just essentially using 'admin' as the user ? | 20:12 |
smoser | feel free to tell me bug off... keystone is new to me. | 20:13 |
zaitcev | I'm still having that 404 problem with Swift. | 20:17 |
zaitcev | "HEAD /vdb/18239/AUTH_1" 404 - "-" "-" "-" 0.0010 "" | 20:18 |
zns | smoser: sorry, stepped away for a bit. Not sure, but you can add a debug filter to Keystone to see incoming requests (header and body) and responses (headers,body as well) and that might help figure out what Glance is sending. | 20:18 |
zns | The way to do that is add the debug middleware in your config: | 20:18 |
zns | [pipeline:admin] | 20:18 |
zns | pipeline = | 20:18 |
zns | urlrewritefilter | 20:18 |
zns | debug | 20:18 |
zns | admin_api | 20:18 |
zns | You need (and should already have) this in the config as well: | 20:19 |
zns | [filter:debug] | 20:19 |
zns | paste.filter_factory = keystone.common.wsgi:debug_filter_factory | 20:19 |
zns | vladimir3p: here's the D5 compatibility piece I promised yesterday: https://review.openstack.org/#change,2136 | 20:20 |
smoser | it looks like that is it. | 20:20 |
smoser | {"access": {"token": {"expires": "2015-02-05T00:00:00", "id": "golfing", "tenant": {"id": "1", "name": "admin"}}, "user": {"username": "admin", "id": "1", "roles": [{"tenantId": "1", "id": "1", "name": "Admin"}, {"id": "1", "name": "Admin"}, {"id": "3", "name": "KeystoneAdmin"}, {"id": "4", "name": "KeystoneServiceAdmin"}]}}} | 20:20 |
zns | So 'golfing' is your token id! Usually a UUID-looking string. | 20:22 |
*** adjohn has joined #openstack-dev | 20:23 | |
zns | And the token looks like it has all admin roles (Admin, KeystoneAdmin, KeystoneServiceAdmin) [these names are configurable in the conf file, so I can't guarantee the names, but looks like it... | 20:24 |
zns | smoser: so, correction to your note ^^, 'golfing' is your token id (I don't think it is the password - though it could also be that if you set it up so) | 20:25 |
*** hub_cap has quit IRC | 20:26 | |
smoser | you're right. | 20:26 |
smoser | thanks zns | 20:26 |
zns | sure thing :-) | 20:27 |
*** dolphm has joined #openstack-dev | 20:27 | |
*** dolphm_ has joined #openstack-dev | 20:29 | |
*** nickon has joined #openstack-dev | 20:29 | |
*** Abd4llA has joined #openstack-dev | 20:31 | |
*** dolphm has quit IRC | 20:31 | |
zaitcev | Do we know anyone who knows Swift and shows up on IRC? | 20:33 |
zaitcev | (and willing to spend time educating me, I should add) | 20:34 |
*** dwalleck has joined #openstack-dev | 20:34 | |
openstackgerrit | Johannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI list_instances https://review.openstack.org/2151 | 20:36 |
*** jmckenty has quit IRC | 20:41 | |
*** jmckenty has joined #openstack-dev | 20:42 | |
jaypipes | zaitcev: notmyname is a good bet | 20:42 |
jaypipes | zaitcev: and chmouel | 20:42 |
zaitcev | jaypipes: Thank you | 20:43 |
jaypipes | welcome | 20:43 |
*** dolphm_ has quit IRC | 20:43 | |
dubsquared | jaypipes: you win. | 20:46 |
*** mdomsch_ has joined #openstack-dev | 20:48 | |
*** bcwaldon has quit IRC | 20:48 | |
kbringard | hey soren, you about? | 20:55 |
*** Shrews has quit IRC | 20:55 | |
soren | kbringard: Kinda. | 20:56 |
kbringard | http://paste.openstack.org/show/3676/ | 20:56 |
kbringard | think there may be a quick monkeypatch to fix that? or is it going to be something more involved | 20:56 |
soren | kbringard: Current trunk? | 20:56 |
kbringard | diablo backports | 20:56 |
soren | hang on | 20:56 |
kbringard | it happens when you launch an instance in a security group that has a -o to another group | 20:57 |
soren | iirc, https://review.openstack.org/#change,815 fixes it. | 20:57 |
kbringard | my gut reaction was that it was because there are no ports in the source-group stuff | 20:57 |
soren | Yeah. | 20:57 |
openstackgerrit | A change to openstack/nova has been rejected: Adds network model and network info cache. https://review.openstack.org/2028 | 20:58 |
soren | IIRC, https://review.openstack.org/#change,815 will at least ensure it doesn't happen again. I forget if it solves it for existing rules. | 20:58 |
kbringard | yea, this is a new setup, I don't care about existing rules | 20:58 |
soren | Cool. | 20:58 |
kbringard | so, probably a stupid question, but what is (or is there) a way to make that into a patch that I can apply to my system :-D | 20:59 |
soren | git fetch https://review.openstack.org/p/openstack/nova refs/changes/15/815/5 && git format-patch -1 --stdout FETCH_HEAD | 20:59 |
soren | kbringard: Right above the two diff buttons, there's a table of information. | 21:00 |
kbringard | ah, yoda man | 21:00 |
soren | kbringard: If you click the patch option, it shows you the command you need to run. That's what I just copied. | 21:00 |
soren | I have no clue how it works, so if it doesn't work, ask someone else :) | 21:00 |
kbringard | ah, super easy | 21:00 |
kbringard | haha | 21:00 |
kbringard | I'll give it a try and let you know :-D | 21:00 |
kbringard | now to check and see if this is marked to go into the backports | 21:01 |
soren | If you're working from a git checkout, this will cherry-pick it instead: https://review.openstack.org/#change,815 | 21:01 |
soren | err.. | 21:01 |
soren | whoops. | 21:01 |
soren | If you're working from a git checkout, this will cherry-pick it instead: git fetch https://review.openstack.org/p/openstack/nova refs/changes/15/815/5 && git cherry-pick FETCH_HEAD | 21:01 |
kbringard | I'm not… that's where it gets compricated | 21:01 |
kbringard | it's the RS CloudBuilders package | 21:01 |
kbringard | so I may not be able to do it, since this particular change may rely on other changes that aren't there yet | 21:02 |
*** dolphm has joined #openstack-dev | 21:02 | |
kbringard | markmc: do you happen to know if this patch is in backports, or queued to be? | 21:03 |
kbringard | looks like the last commit to the to your nova branch was from Oct 26 | 21:04 |
*** ayoung has quit IRC | 21:04 | |
*** ayoung has joined #openstack-dev | 21:05 | |
markmc | kbringard, no, looks like it's not there yet | 21:11 |
markmc | kbringard, I've reviewed as far as 2826e862d73d | 21:11 |
markmc | kbringard, Nov 8 | 21:11 |
* markmc hadn't realized he was a full month behind | 21:11 | |
kbringard | ah, it's probably worth taking a look… if you you try to launch a VM in a security group that has a source group set, it'll fail to launch the VM | 21:12 |
*** zns1 has joined #openstack-dev | 21:14 | |
markmc | kbringard, noted :) https://github.com/markmc/nova/commit/1b48384ecbbf9e86d21511767058c2eb1b32426c | 21:16 |
kbringard | thank you, sir | 21:17 |
*** zns has quit IRC | 21:17 | |
*** zaitcev has quit IRC | 21:19 | |
*** zns has joined #openstack-dev | 21:19 | |
openstackjenkins | Project nova-docs build #1,735: SUCCESS in 3 min 48 sec: https://jenkins.openstack.org/job/nova-docs/1735/ | 21:19 |
openstackjenkins | brian.waldon: Clean up snapshot metadata | 21:19 |
*** zns1 has quit IRC | 21:22 | |
*** dolphm has quit IRC | 21:24 | |
openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Implemented bp portable-identifiers for tenants https://review.openstack.org/2156 | 21:25 |
openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Exposes tenant UID's (bp portable-identifiers) https://review.openstack.org/2157 | 21:25 |
openstackgerrit | Gabriel Hurley proposed a change to openstack/horizon: Cleanup of splash page error messages and keystone error handling. https://review.openstack.org/2158 | 21:26 |
markmc | jeblair, you know this error gerrit gives you if you try and propose someone else's patch ? | 21:27 |
markmc | jeblair, and the check doesn't apply to core members | 21:27 |
openstackgerrit | Johannes Erdfelt proposed a change to openstack/nova: Fix race condition in XenAPI when using <object>.get_all https://review.openstack.org/2151 | 21:27 |
markmc | jeblair, can we remove that restriction from the stable branch? | 21:27 |
markmc | jeblair, I'd like to encourage folks to cherry pick and propose other people's patches from master | 21:28 |
*** zns has quit IRC | 21:30 | |
*** zns has joined #openstack-dev | 21:31 | |
*** jmckenty has quit IRC | 21:31 | |
*** dwalleck has quit IRC | 21:32 | |
*** zns1 has joined #openstack-dev | 21:33 | |
*** reed_ is now known as reed | 21:34 | |
*** zns has quit IRC | 21:35 | |
jeblair | markmc: i think so, but let me think about the ramifications for a bit. | 21:36 |
markmc | jeblair, thinking is not allowed! | 21:37 |
markmc | jeblair, but ok, if you insist :) | 21:37 |
openstackgerrit | Dan Prince proposed a change to openstack/nova: Set instance['host'] to the original host value on revert resize. Fixes bug #901445 https://review.openstack.org/2159 | 21:37 |
uvirtbot | Launchpad bug 901445 in nova "instance['host'] is not reverted on revert-resize" [Medium,In progress] https://launchpad.net/bugs/901445 | 21:37 |
*** lorin1 has quit IRC | 21:38 | |
openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Implemented bp portable-identifiers for tenants https://review.openstack.org/2156 | 21:42 |
*** dwalleck has joined #openstack-dev | 21:51 | |
*** dwalleck has quit IRC | 21:52 | |
*** dwalleck has joined #openstack-dev | 21:53 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted. https://review.openstack.org/2131 | 21:54 |
*** lloydde has quit IRC | 21:56 | |
*** mdomsch has quit IRC | 21:57 | |
openstackgerrit | Brian Waldon proposed a change to openstack/nova: Set instance['host'] to the original host value on revert resize. Fixes bug #901445 https://review.openstack.org/2159 | 21:59 |
uvirtbot | Launchpad bug 901445 in nova "instance['host'] is not reverted on revert-resize" [Medium,In progress] https://launchpad.net/bugs/901445 | 21:59 |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted. https://review.openstack.org/2131 | 21:59 |
*** lts has quit IRC | 22:01 | |
openstackgerrit | Trey Morris proposed a change to openstack/nova: Adds network model and network info cache. https://review.openstack.org/2028 | 22:01 |
*** jmckenty has joined #openstack-dev | 22:03 | |
*** rkukura has quit IRC | 22:06 | |
*** markvoelker has quit IRC | 22:09 | |
openstackgerrit | Rick Harris proposed a change to openstack/nova: Add model_query helper to handle context.read_deleted. https://review.openstack.org/2131 | 22:10 |
*** dragondm has joined #openstack-dev | 22:10 | |
vishy | s1rp_ : commented on the bug | 22:17 |
*** dwalleck has quit IRC | 22:18 | |
vishy | s1rp_: In general I'm concerned about using read_deleted too much, because I'm not sure we can depend on it working with all potential db backends | 22:18 |
openstackjenkins | Project nova-docs build #1,736: SUCCESS in 3 min 10 sec: https://jenkins.openstack.org/job/nova-docs/1736/ | 22:19 |
openstackjenkins | Johannes Erdfelt: Fix race condition in XenAPI when using <object>.get_all | 22:19 |
smoser | it seems something in devstack is pulling in boto-1.9b, and thats screwing up euca2ools | 22:19 |
smoser | as they need 2.x | 22:19 |
smoser | carrot maybe | 22:19 |
*** lloydde has joined #openstack-dev | 22:21 | |
*** GheRivero_ has quit IRC | 22:21 | |
s1rp_ | vishy: yeah, i agree, in the long-run we should completely rethink how read_deleted is being used; perhaps ax'ing it entirely. the proposal is really a short/medium term patch that gives us the functionality we need (for cleanup scripts that need to see both deleted and live records) with minimal risk to existing code | 22:23 |
vishy | aren't you just saving 1 db call though? | 22:23 |
vishy | is it worth changing to save that extra call? | 22:23 |
s1rp_ | it's not that simple, AFAICT... | 22:24 |
s1rp_ | most of our core logic passes around this context, and since the calls are deeply nested, we really can't "inject" new logic to add in delted records somewhere in the process | 22:25 |
s1rp_ | we really need to, at the top level, set read_deleted='yes' in order to accomplish that | 22:25 |
*** apevec has quit IRC | 22:25 | |
s1rp_ | the example that bit me was getting deleted instances, and then having all of the related-object code (ips, networks) refuse to return 'live' records since my context had read_deleted=True... | 22:29 |
*** rnirmal has quit IRC | 22:29 | |
*** lloydde has quit IRC | 22:30 | |
vishy | ah interesting | 22:31 |
*** nickon has quit IRC | 22:32 | |
vishy | that is odd | 22:32 |
vishy | s1rp_: the read_deleted filter is usually just on the top query | 22:32 |
vishy | so you can't just set read_deleted on the one db call where you need it? | 22:33 |
openstackjenkins | Project nova-docs build #1,737: SUCCESS in 3 min 38 sec: https://jenkins.openstack.org/job/nova-docs/1737/ | 22:34 |
openstackjenkins | brian.waldon: Set instance['host'] to the original host value on revert resize. | 22:34 |
s1rp_ | vishy: i tried that as a quick hack, but it was a no-go.... can't remember the exact details at the moment. just remember seeing chained calls using the context, and thinking the only way to handle this was to adjust read_deleted to handle this 3rd case | 22:35 |
*** rohitk has joined #openstack-dev | 22:35 | |
vishy | hmm | 22:35 |
*** dspano has quit IRC | 22:36 | |
*** cp16net has quit IRC | 22:37 | |
*** markmc has quit IRC | 22:40 | |
vishy | s1rp_: i don't really get it | 22:42 |
vishy | it seems like you should just be able to use read_deleted=True | 22:42 |
vishy | for this one call: self.db.instance_get_all_by_host(context, self.host) | 22:42 |
vishy | and set it back to false after | 22:43 |
*** rsampaio has quit IRC | 22:45 | |
*** bsza has quit IRC | 22:45 | |
vishy | s1rp_: I really don't know that we "need" to read both ever | 22:46 |
s1rp_ | vishy: yup, that works for that case (wrote something called temporary_mutation to do that for me)... however... | 22:46 |
vishy | s1rp_: there are only two cases where we use read_deleted currently | 22:46 |
vishy | 1) tests | 22:46 |
vishy | 2) nova-manage | 22:46 |
s1rp_ | when you call _shutdown_instance, you pass a context, that in turn, passes the context to get_nw_info, which will then fail to return the network information, because the IPs and networks are live | 22:46 |
vishy | sure, but why would you call shutdown_instance with that context? | 22:47 |
s1rp_ | well, shutdown_instance needs to see both... "deleted" instances, and "live" ips | 22:47 |
vishy | can't you just undelete the instance with the read_deleted context? | 22:48 |
vishy | then call shutdown_instance? | 22:48 |
s1rp_ | well, in one case, we want to keep the instance deleted | 22:48 |
vishy | I want to minimize the depth of calls that are accessing deleted instances | 22:48 |
s1rp_ | we're trying to sweep it.... in another scenario, per your suggestion, we may try to undelete the instance | 22:48 |
vishy | In most cases, deleted should be actually deleted. | 22:49 |
vishy | i understand there are a few cases where we have to see deleted stuff | 22:49 |
*** danishman has joined #openstack-dev | 22:49 | |
s1rp_ | yeah, though that's going to make cleanup scripts really tough to write, since we won't be able to use any of the current convenience code | 22:49 |
vishy | but optimizing the code to allow for calls that pull everything seems odd, since I consider that to be a big edge case. | 22:50 |
s1rp_ | i don't really think it's going to be an edge case as we move to production systems... | 22:50 |
s1rp_ | we'll need plenty of cleanup scripts to keep things humming along (until we root out all of the bugs :-) | 22:50 |
vishy | i guess that is true | 22:50 |
vishy | I was really hoping to keep deleted semantics in the db layer | 22:51 |
vishy | now we're forcing a particular implementation of how stuff is deleted. | 22:51 |
vishy | still seems ugly to me, but I don't suppose it is any uglier than our current stuff | 22:51 |
s1rp_ | we're really only enforcing that deleted stuff isn't truly deleted until 'purged'... but those semantics seem pretty in-grained in the system, so that doesn't worry too much | 22:52 |
s1rp_ | yeah i'd agree it's ugly, but on the plus side, there are some nice clean ups in that patch too. focus on those! :) | 22:53 |
s1rp_ | i view this as a sort-of, hold-you-nose, merge this, and worry about The Right Way, down the line | 22:54 |
*** dubsquared has quit IRC | 23:00 | |
*** jmckenty_ has joined #openstack-dev | 23:00 | |
*** jmckenty has quit IRC | 23:00 | |
*** lloydde has joined #openstack-dev | 23:01 | |
*** troytoman is now known as troytoman-away | 23:02 | |
*** kbringard has quit IRC | 23:04 | |
openstackgerrit | Gabriel Hurley proposed a change to openstack/horizon: Cleanup of splash page error messages and keystone error handling. https://review.openstack.org/2158 | 23:12 |
*** danishman has quit IRC | 23:13 | |
*** lloydde has quit IRC | 23:15 | |
*** dolphm has joined #openstack-dev | 23:16 | |
*** lloydde has joined #openstack-dev | 23:18 | |
*** bencherian has quit IRC | 23:24 | |
openstackgerrit | Duncan McGreggor proposed a change to openstack/nova: Updated the test runner module with a sys.path insert so that tests run in and outside a virtual environment. https://review.openstack.org/2160 | 23:25 |
*** code_franco has quit IRC | 23:30 | |
*** mattray has quit IRC | 23:33 | |
openstackgerrit | Brad Hall proposed a change to openstack/nova: Fix for bug 901459 https://review.openstack.org/2161 | 23:35 |
uvirtbot | Launchpad bug 901459 in nova "QuantumManager#get_all_networks uninitalized variable" [Undecided,New] https://launchpad.net/bugs/901459 | 23:35 |
*** nati2 has joined #openstack-dev | 23:35 | |
*** AlanClark has quit IRC | 23:39 | |
*** heckj has joined #openstack-dev | 23:41 | |
openstackgerrit | Brad Hall proposed a change to openstack/nova: Fix for bug 901459 https://review.openstack.org/2161 | 23:42 |
uvirtbot | Launchpad bug 901459 in nova "QuantumManager#get_all_networks uninitalized variable" [Undecided,New] https://launchpad.net/bugs/901459 | 23:42 |
*** rods has quit IRC | 23:46 | |
*** dolphm has quit IRC | 23:50 | |
*** rbasak has quit IRC | 23:54 | |
*** zns1 has quit IRC | 23:56 | |
*** dragondm_ has joined #openstack-dev | 23:58 | |
*** jakedahn has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!