*** nati_uen_ has joined #openstack-dev | 00:00 | |
*** chenxu has quit IRC | 00:02 | |
*** nati_ueno has quit IRC | 00:03 | |
mtaylor | bcwaldon: nope. priority cues :) | 00:05 |
---|---|---|
*** bhuvan has quit IRC | 00:06 | |
*** ncode has quit IRC | 00:11 | |
*** steveb_ has quit IRC | 00:13 | |
*** littleidea has quit IRC | 00:13 | |
*** steveb_ has joined #openstack-dev | 00:14 | |
*** dubsquared has joined #openstack-dev | 00:16 | |
mtaylor | s/cues/queues/ | 00:17 |
bcwaldon | no no, I got it | 00:17 |
*** jdg has quit IRC | 00:21 | |
mtaylor | bcwaldon: you're always so clairvoyant | 00:21 |
zul | vishy: ping | 00:21 |
*** segfault923 has quit IRC | 00:21 | |
*** ayoung has joined #openstack-dev | 00:23 | |
*** ayoung has quit IRC | 00:26 | |
*** zykes- has joined #openstack-dev | 00:28 | |
*** sniperd has quit IRC | 00:28 | |
*** littleidea has joined #openstack-dev | 00:30 | |
vishy | zul: sup? | 00:36 |
zul | vishy: so checking the availability zone for volume creating should it be done in the csheduler or volume ? | 00:36 |
*** dubsquared has quit IRC | 00:36 | |
*** kindaopsdevy has quit IRC | 00:37 | |
vishy | zul: the scheduler should update to error state like it does for instances | 00:37 |
zul | vishy: right ok just double checking | 00:38 |
vishy | zul: heading home for the day, gl | 00:39 |
zul | vishy: k thanks | 00:39 |
*** torgomatic_ has joined #openstack-dev | 00:41 | |
*** torgomatic has quit IRC | 00:42 | |
*** torgomatic_ is now known as torgomatic | 00:42 | |
*** markvoelker has joined #openstack-dev | 00:42 | |
*** torgomatic has quit IRC | 00:42 | |
*** spiffxp has quit IRC | 00:42 | |
*** anderstj has joined #openstack-dev | 00:44 | |
*** sniperd has joined #openstack-dev | 00:46 | |
*** andrewsben_is_a_ is now known as andrewsben | 00:48 | |
*** andrewbogott has joined #openstack-dev | 00:49 | |
*** matwood has joined #openstack-dev | 00:50 | |
*** rkukura has joined #openstack-dev | 00:51 | |
andrewbogott | Does anyone know what the story is with Jenkins vs. openstack-common? | 00:53 |
andrewbogott | It seems to be ignoring all common patches, best I can tell. | 00:54 |
clarkb | andrewbogott: correct Jenkins currently doesn't do anything for openstack-common | 00:54 |
clarkb | however that will change soon | 00:54 |
andrewbogott | Ah, ok. So that means that reviewers should not wait for Verification, huh? | 00:54 |
clarkb | actually it may have changed | 00:55 |
*** dolphm has joined #openstack-dev | 00:55 | |
clarkb | nevermind was looking at the wrong queue. once https://review.openstack.org/#/c/8957/ lands then Jenkins will verify for you | 00:55 |
*** dubsquared has joined #openstack-dev | 00:56 | |
andrewbogott | But, in the meantime... | 00:56 |
* andrewbogott is puzzled that his patch has two +1s and a +2 and a checkmark but is not yet 'approved' | 00:57 | |
andrewbogott | I guess I can't blame Jenkins :( | 00:57 |
*** s0mik has quit IRC | 01:00 | |
*** s0mik has joined #openstack-dev | 01:02 | |
*** markvoelker has left #openstack-dev | 01:03 | |
*** Aaton is now known as Aaton_off | 01:11 | |
*** rbasak has quit IRC | 01:13 | |
*** issackelly has quit IRC | 01:13 | |
*** andrewbogott has quit IRC | 01:14 | |
*** rbasak has joined #openstack-dev | 01:15 | |
*** jog0 has quit IRC | 01:16 | |
*** asalkeld has quit IRC | 01:18 | |
*** asalkeld has joined #openstack-dev | 01:18 | |
*** andrewbogott has joined #openstack-dev | 01:19 | |
*** andrewsben is now known as andrewsben_is_a_ | 01:21 | |
*** s0mik has quit IRC | 01:22 | |
*** kindaopsdevy has joined #openstack-dev | 01:24 | |
*** rnirmal has quit IRC | 01:29 | |
*** reed has quit IRC | 01:30 | |
*** PotHix has quit IRC | 01:33 | |
*** littleidea has quit IRC | 01:33 | |
*** iccha has quit IRC | 01:34 | |
*** primeministerp has quit IRC | 01:36 | |
*** shang has quit IRC | 01:38 | |
*** nati_uen_ has quit IRC | 01:40 | |
*** salgado-afk has quit IRC | 01:46 | |
*** ywu has quit IRC | 01:50 | |
*** adalbas has quit IRC | 01:57 | |
*** steveb_ has quit IRC | 01:58 | |
*** vanchester has joined #openstack-dev | 02:00 | |
*** shang has joined #openstack-dev | 02:02 | |
*** kindaopsdevy has quit IRC | 02:04 | |
*** harlowja has quit IRC | 02:04 | |
*** novas0x2a|laptop has quit IRC | 02:06 | |
*** dolphm has quit IRC | 02:06 | |
*** dolphm has joined #openstack-dev | 02:09 | |
*** danwent has quit IRC | 02:12 | |
*** roge has quit IRC | 02:12 | |
*** matwood has quit IRC | 02:15 | |
comstud | vishy: more good stuff for you pushed up | 02:16 |
*** Ryan_Lane1 has joined #openstack-dev | 02:18 | |
*** Ryan_Lane has quit IRC | 02:19 | |
*** nati_ueno has joined #openstack-dev | 02:19 | |
*** edygarcia has joined #openstack-dev | 02:37 | |
*** eglynn_ has joined #openstack-dev | 02:42 | |
*** davidha has joined #openstack-dev | 02:44 | |
*** eglynn has quit IRC | 02:46 | |
*** timjr has joined #openstack-dev | 02:53 | |
*** timjr has left #openstack-dev | 02:53 | |
*** dtroyer_zzz is now known as dtroyer | 02:53 | |
*** timjr has joined #openstack-dev | 02:53 | |
timjr | howdy :) | 02:53 |
timjr | I'm a newbie trying to contribute my first patch... err, code review request | 02:53 |
timjr | kinda stuck though | 02:54 |
timjr | I changed my username on launchpad | 02:54 |
timjr | it seems the change is not propagating to gerrit | 02:54 |
mtaylor | timjr: there is a delay | 02:54 |
mtaylor | timjr: how long ago did you change you username on launchpad? | 02:55 |
timjr | about an hour | 02:55 |
timjr | the old username was a crazy thing, ww3ib0sg9wt9-tim-8aw3u04umos2 | 02:55 |
timjr | new one is easier to pronounce -- timjr | 02:56 |
timjr | hm. wonder if I lost my team membership when I changed it | 02:57 |
timjr | yep, looks like I may have | 03:00 |
timjr | woohoo, ssh keys made it | 03:01 |
timjr | I wonder if it's an hourly cron job or something -- it's 8:01 here | 03:01 |
*** dolphm has quit IRC | 03:04 | |
timjr | well, I guess I'll go commute. if anybody's around that could approve my openstack-cla team membership, I'd be much obliged. :) | 03:04 |
*** timjr has quit IRC | 03:04 | |
*** nati_ueno has quit IRC | 03:12 | |
*** davidha has quit IRC | 03:13 | |
*** edygarcia has quit IRC | 03:14 | |
*** seats has quit IRC | 03:29 | |
*** seats has joined #openstack-dev | 03:30 | |
*** timello has quit IRC | 03:31 | |
*** dtroyer is now known as dtroyer_zzz | 03:32 | |
*** sandywalsh has quit IRC | 03:36 | |
*** andrewsmedina has quit IRC | 03:38 | |
*** dolphm has joined #openstack-dev | 03:44 | |
*** kindaopsdevy has joined #openstack-dev | 03:46 | |
*** seats has quit IRC | 03:46 | |
*** Gordonz has joined #openstack-dev | 03:47 | |
*** Gordonz has quit IRC | 03:47 | |
*** seats has joined #openstack-dev | 03:47 | |
*** seats has quit IRC | 03:47 | |
*** seats has joined #openstack-dev | 03:47 | |
*** dolphm has quit IRC | 03:48 | |
*** timjr has joined #openstack-dev | 03:51 | |
*** timjr has quit IRC | 03:52 | |
*** dubsquared has quit IRC | 03:52 | |
*** adjohn has quit IRC | 03:53 | |
*** matwood has joined #openstack-dev | 03:54 | |
*** adjohn has joined #openstack-dev | 03:58 | |
*** dolphm has joined #openstack-dev | 04:04 | |
*** dubsquared has joined #openstack-dev | 04:05 | |
*** markmcclain has quit IRC | 04:26 | |
*** pmyers has quit IRC | 04:26 | |
*** zigo has joined #openstack-dev | 04:29 | |
*** kindaopsdevy has quit IRC | 04:31 | |
*** Ryan_Lane1 has quit IRC | 04:33 | |
*** matwood has quit IRC | 04:34 | |
*** nunosantos has quit IRC | 04:34 | |
*** nunosantos_ has quit IRC | 04:35 | |
*** matwood has joined #openstack-dev | 04:35 | |
*** matwood has quit IRC | 04:36 | |
*** matwood has joined #openstack-dev | 04:38 | |
*** garyk has quit IRC | 04:41 | |
*** kindaopsdevy has joined #openstack-dev | 04:46 | |
*** andrewbogott has quit IRC | 04:50 | |
*** adjohn has quit IRC | 05:03 | |
*** steveb_ has joined #openstack-dev | 05:06 | |
*** mnaser has joined #openstack-dev | 05:06 | |
*** kindaopsdevy has quit IRC | 05:08 | |
*** maoy has quit IRC | 05:11 | |
*** dolphm has quit IRC | 05:23 | |
*** adjohn has joined #openstack-dev | 05:25 | |
*** adjohn has quit IRC | 05:28 | |
*** edygarcia has joined #openstack-dev | 05:29 | |
*** steveb_ has quit IRC | 05:29 | |
*** edygarcia has quit IRC | 05:32 | |
*** adjohn has joined #openstack-dev | 05:38 | |
*** sleepsonzzz is now known as sleepsonthefloor | 05:56 | |
*** dachary has joined #openstack-dev | 05:58 | |
*** Mandell has joined #openstack-dev | 06:02 | |
*** garyk has joined #openstack-dev | 06:07 | |
*** pmyers has joined #openstack-dev | 06:07 | |
*** matwood has quit IRC | 06:08 | |
*** sdake has quit IRC | 06:10 | |
*** dachary has quit IRC | 06:10 | |
*** jakedahn is now known as jakedahn_zz | 06:11 | |
*** sdake has joined #openstack-dev | 06:11 | |
*** mnaser has quit IRC | 06:17 | |
*** sleepsonthefloor is now known as sleepsonzzz | 06:20 | |
*** Mandell has quit IRC | 06:20 | |
*** mrunge has joined #openstack-dev | 06:24 | |
garyk | ping gongys | 06:29 |
*** adjohn has joined #openstack-dev | 06:31 | |
*** erikzaadi has joined #openstack-dev | 06:39 | |
*** anderstj has quit IRC | 06:41 | |
*** erikzaadi has quit IRC | 06:42 | |
*** sdake has quit IRC | 06:43 | |
*** littleidea has joined #openstack-dev | 06:44 | |
*** sieutruc has joined #openstack-dev | 06:50 | |
*** sdake has joined #openstack-dev | 06:55 | |
*** adjohn has quit IRC | 07:03 | |
*** mgz has joined #openstack-dev | 07:04 | |
*** davidha has joined #openstack-dev | 07:07 | |
*** dachary has joined #openstack-dev | 07:11 | |
*** reidrac has joined #openstack-dev | 07:13 | |
ttx | annegentle: no, that's a new file in Folsom. | 07:14 |
*** huats_ has joined #openstack-dev | 07:18 | |
*** camm_ has joined #openstack-dev | 07:18 | |
*** ahale_ has joined #openstack-dev | 07:18 | |
*** jeremydei_ has joined #openstack-dev | 07:19 | |
*** dayou has joined #openstack-dev | 07:19 | |
*** ahale has quit IRC | 07:19 | |
*** camm has quit IRC | 07:19 | |
*** jeremydei has quit IRC | 07:19 | |
*** Aaton_off has quit IRC | 07:19 | |
*** huats has quit IRC | 07:19 | |
*** Aatong has joined #openstack-dev | 07:19 | |
*** Aatong is now known as Aaton | 07:19 | |
*** adjohn has joined #openstack-dev | 07:25 | |
*** glenc_ has quit IRC | 07:26 | |
*** erikzaadi has joined #openstack-dev | 07:26 | |
*** glenc has joined #openstack-dev | 07:28 | |
*** justinsb_ has joined #openstack-dev | 07:31 | |
*** vuntz_ has joined #openstack-dev | 07:31 | |
*** BLZbubba_ has joined #openstack-dev | 07:32 | |
*** mindpixel has joined #openstack-dev | 07:32 | |
*** smoser` has joined #openstack-dev | 07:35 | |
*** BLZbubba has quit IRC | 07:36 | |
*** vuntz has quit IRC | 07:36 | |
*** smoser has quit IRC | 07:36 | |
*** justinsb has quit IRC | 07:36 | |
*** akscram has quit IRC | 07:36 | |
*** haleyb has quit IRC | 07:36 | |
*** vuntz_ is now known as vuntz | 07:47 | |
*** ohnoimdead has quit IRC | 07:54 | |
*** smoser` is now known as smoser | 08:03 | |
*** littleidea has quit IRC | 08:03 | |
*** littleidea has joined #openstack-dev | 08:04 | |
*** haleyb has joined #openstack-dev | 08:04 | |
*** akscram has joined #openstack-dev | 08:09 | |
*** darraghb has joined #openstack-dev | 08:16 | |
*** pixelbeat has joined #openstack-dev | 08:17 | |
*** littleidea has quit IRC | 08:37 | |
*** zigo-_- has joined #openstack-dev | 08:37 | |
*** zigo has quit IRC | 08:38 | |
*** danpb has joined #openstack-dev | 08:46 | |
*** akscram has quit IRC | 08:59 | |
*** akscram has joined #openstack-dev | 09:00 | |
*** eglynn__ has joined #openstack-dev | 09:16 | |
*** eglynn_ has quit IRC | 09:18 | |
*** rods has joined #openstack-dev | 09:20 | |
*** johngarbutt has joined #openstack-dev | 09:24 | |
*** _val__ has joined #openstack-dev | 09:25 | |
*** _val_ has quit IRC | 09:26 | |
*** eglynn has joined #openstack-dev | 09:28 | |
*** eglynn__ has quit IRC | 09:29 | |
*** eglynn_ has joined #openstack-dev | 09:32 | |
*** eglynn has quit IRC | 09:35 | |
*** markmcclain has joined #openstack-dev | 10:01 | |
*** eglynn__ has joined #openstack-dev | 10:02 | |
*** eglynn_ has quit IRC | 10:05 | |
vanchester | anyone of keystone ldap backend devs here? | 10:08 |
*** Leander_ has joined #openstack-dev | 10:10 | |
*** zigo-_- has quit IRC | 10:11 | |
Leander_ | hello all | 10:11 |
Leander_ | i'm having a problem with the tests | 10:11 |
Leander_ | i've created a custom branch | 10:12 |
Leander_ | and added one file to nova and modified the connection.py from libvirt | 10:12 |
Leander_ | now, none of the tests run | 10:12 |
Leander_ | i've tried applying the same changes to the master branch | 10:12 |
Leander_ | and as soon as the changes are made i somehow lose all the tests | 10:12 |
Leander_ | any ideas why this is happening? | 10:13 |
*** apevec has joined #openstack-dev | 10:23 | |
*** dayou has quit IRC | 10:29 | |
* danpb discovers the --no-merges flag to 'git log' which makes browsing openstack GIT history orders of magnitude more pleasant | 10:40 | |
Leander_ | hello all,i'm having a problem with the tests | 10:42 |
Leander_ | i've created a custom branch and added one file to nova and modified the connection.py from libvirt. | 10:42 |
Leander_ | However, none of the tests run. I've tried applying the same changes to the master branch and as soon as the changes are made i somehow lose all the tests. | 10:42 |
Leander_ | any ideas why this is happening? | 10:42 |
vanchester | still have the question: how does models are used in keystone ldap backend? | 10:44 |
vanchester | aha, there is the code | 10:47 |
*** alaski has joined #openstack-dev | 10:55 | |
*** e1mer has quit IRC | 11:02 | |
*** sandywalsh has joined #openstack-dev | 11:03 | |
*** mgz has quit IRC | 11:11 | |
*** markvoelker has joined #openstack-dev | 11:15 | |
*** erikzaadi has quit IRC | 11:19 | |
*** erikzaadi has joined #openstack-dev | 11:21 | |
zykes- | jk0: ping | 11:22 |
*** asalkeld has left #openstack-dev | 11:22 | |
*** mrunge has quit IRC | 11:24 | |
*** Leander_ has quit IRC | 11:30 | |
*** zigo has joined #openstack-dev | 11:30 | |
*** wiliam has joined #openstack-dev | 11:31 | |
*** e1mer has joined #openstack-dev | 11:37 | |
*** e1mer has joined #openstack-dev | 11:37 | |
*** e1mer has quit IRC | 11:41 | |
*** e1mer has joined #openstack-dev | 11:41 | |
*** maoy has joined #openstack-dev | 11:41 | |
*** RoboticCheese has quit IRC | 11:50 | |
*** RoboticCheese has joined #openstack-dev | 11:50 | |
*** salgado has joined #openstack-dev | 12:00 | |
*** salgado has joined #openstack-dev | 12:00 | |
*** vanchester has quit IRC | 12:03 | |
*** darraghb has quit IRC | 12:05 | |
*** vanchester has joined #openstack-dev | 12:10 | |
*** sieutruc has quit IRC | 12:12 | |
zykes- | soren: ping | 12:18 |
*** segfault923 has joined #openstack-dev | 12:24 | |
*** mgz has joined #openstack-dev | 12:26 | |
*** pmyers has quit IRC | 12:29 | |
*** Leander_ has joined #openstack-dev | 12:29 | |
*** pmyers has joined #openstack-dev | 12:29 | |
*** sandywalsh_ has joined #openstack-dev | 12:29 | |
Leander_ | hello all,i'm having a problem with the tests | 12:30 |
Leander_ | i've created a custom branch and added one file to nova and modified the connection.py from libvirt | 12:30 |
Leander_ | However, none of the tests run. I've tried applying the same changes to the master branch and as soon as the changes are made i somehow lose all the tests. | 12:30 |
Leander_ | any ideas why this is happening? | 12:30 |
*** sandywalsh has quit IRC | 12:30 | |
*** markmcclain has quit IRC | 12:40 | |
*** lts has joined #openstack-dev | 12:42 | |
*** apevec has quit IRC | 12:45 | |
davidkranz | vishy: I did multiple runs with and without the fix to suppress variance and there was no real difference after all. Oh well. | 12:45 |
*** vanchester has quit IRC | 12:46 | |
*** chenxu has joined #openstack-dev | 12:47 | |
*** Ryan_Lane has joined #openstack-dev | 12:48 | |
*** japage has joined #openstack-dev | 12:54 | |
*** maoy has quit IRC | 12:55 | |
*** Dr_Who has joined #openstack-dev | 12:55 | |
*** Dr_Who has quit IRC | 12:55 | |
*** Dr_Who has joined #openstack-dev | 12:55 | |
*** johngarbutt has quit IRC | 12:59 | |
*** wiliam has quit IRC | 13:02 | |
*** matwood has joined #openstack-dev | 13:06 | |
*** matwood has quit IRC | 13:08 | |
*** apevec has joined #openstack-dev | 13:09 | |
*** mcolombo has quit IRC | 13:10 | |
*** iccha has joined #openstack-dev | 13:10 | |
*** dtroyer_zzz is now known as dtroyer | 13:11 | |
*** timello has joined #openstack-dev | 13:16 | |
*** edygarcia has joined #openstack-dev | 13:17 | |
*** wiliam has joined #openstack-dev | 13:18 | |
*** adalbas has joined #openstack-dev | 13:20 | |
*** mnaser has joined #openstack-dev | 13:21 | |
*** edygarcia has quit IRC | 13:23 | |
*** dprince has joined #openstack-dev | 13:30 | |
*** mnaser has quit IRC | 13:30 | |
*** roge has joined #openstack-dev | 13:33 | |
*** openstackjenkins has quit IRC | 13:34 | |
*** openstackjenkins has joined #openstack-dev | 13:35 | |
*** andrewsmedina has joined #openstack-dev | 13:36 | |
*** dhellmann_ has joined #openstack-dev | 13:36 | |
*** eglynn has joined #openstack-dev | 13:36 | |
*** kbringard has joined #openstack-dev | 13:37 | |
*** salv-orlando has joined #openstack-dev | 13:38 | |
*** matwood has joined #openstack-dev | 13:39 | |
*** eglynn__ has quit IRC | 13:39 | |
*** dhellmann has quit IRC | 13:40 | |
*** markmcclain has joined #openstack-dev | 13:40 | |
*** dhellmann_ has quit IRC | 13:41 | |
*** krtaylor has joined #openstack-dev | 13:42 | |
*** ncode has joined #openstack-dev | 13:43 | |
*** ncode has quit IRC | 13:43 | |
*** ncode has joined #openstack-dev | 13:43 | |
*** matwood has quit IRC | 13:45 | |
*** openstackjenkins has quit IRC | 13:47 | |
*** Ryan_Lane has quit IRC | 13:48 | |
*** Ryan_Lane has joined #openstack-dev | 13:48 | |
*** openstackjenkins has joined #openstack-dev | 13:48 | |
*** sieutruc has joined #openstack-dev | 13:51 | |
*** maoy has joined #openstack-dev | 13:52 | |
*** iryoung has joined #openstack-dev | 13:53 | |
*** mnaser has joined #openstack-dev | 13:54 | |
*** dolphm has joined #openstack-dev | 13:58 | |
*** edygarcia has joined #openstack-dev | 13:59 | |
danpb | ttx: is there a place to submit bug reports about OpenStack Gerrit service mis-behaviour ? | 14:01 |
mtaylor | danpb: yes. | 14:03 |
mtaylor | danpb: bugs on the openstack-ci project in launchpad | 14:03 |
mtaylor | danpb: so, http://bugs.launchpad.net/openstack-ci ... | 14:03 |
ttx | danpb: what Monty says ^ | 14:03 |
mtaylor | danpb: or you can just ping us in #openstack-infra if it might be a quick thing - what's up? | 14:03 |
danpb | no its not a quick thing | 14:04 |
mtaylor | danpb: ok. cool. then please do submit a bug! :) | 14:04 |
danpb | someone just pointed out to me that if you submit a patch series for a bug fix, then gerrit will mark the bug as fixed the moment 1 single patch is committed | 14:04 |
danpb | ignoring the fact that other patches in the series are also required in order to complete the fix | 14:05 |
mtaylor | danpb: ah. interesting | 14:05 |
mtaylor | danpb: we've discussed splitting some of the verbs before for blueprints ... | 14:05 |
danpb | will file a BZ about it since there's probably many different ways to discuss resolving it | 14:05 |
mtaylor | danpb: like "bug #blah" would associate it with a bug, but "closes #blah" would trigger the finalization ... | 14:06 |
mtaylor | danpb: yeah, definitely - it's a good thing to discuss on the bug | 14:06 |
danpb | yeah that's one idea i came up with too | 14:06 |
*** jaustinpage has joined #openstack-dev | 14:07 | |
*** japage has quit IRC | 14:09 | |
jaypipes | mtaylor: mornin. | 14:12 |
*** dtroyer is now known as dtroyer_zzz | 14:15 | |
Leander_ | hello all,i'm having a problem with the tests | 14:16 |
Leander_ | i've created a custom branch and added one file to nova and modified the connection.py from libvirt | 14:16 |
Leander_ | However, none of the tests run. I've tried applying the same changes to the master branch and as soon as the changes are made i somehow lose all the tests. | 14:16 |
Leander_ | any ideas why this is happening? | 14:16 |
*** mnaser has quit IRC | 14:16 | |
mtaylor | morning jaypipes ! | 14:16 |
*** danwent has joined #openstack-dev | 14:16 | |
mtaylor | jaypipes: you know, if you wanted to approve https://review.openstack.org/#/c/8926/ I wouldn't hate you | 14:17 |
jaypipes | Leander_: if you do git status, are you on a branch at all, or are you in the middle of a rebase? | 14:18 |
maoy | jaypipes: do you know which services is dependent on nova-cert? | 14:18 |
jaypipes | mtaylor: done. well, +2d | 14:19 |
jaypipes | maoy: I *think* the nova EC2 API controller... but you might want to get a second op :) | 14:19 |
*** mcolombo has joined #openstack-dev | 14:20 | |
jaypipes | danpb: lol. "style you managed to inflict on mailman" | 14:21 |
maoy | jaypipes: all right. i didn't see anything related to certificate when i went through the ec2 code though. | 14:22 |
*** martines has joined #openstack-dev | 14:22 | |
jaypipes | maoy: one sec, lemme dig a little then. | 14:22 |
*** andrewbogott has joined #openstack-dev | 14:22 | |
*** andrewbogott has joined #openstack-dev | 14:22 | |
mtaylor | jaypipes: you are a magical bunny rabbit | 14:22 |
* mtaylor warns the channel that he's going to be bugging people about merging the client lib version branches today | 14:23 | |
jaypipes | mtaylor: you are an evil unicorn. | 14:23 |
*** danwent has quit IRC | 14:25 | |
*** mnewby has joined #openstack-dev | 14:27 | |
*** primeministerp has joined #openstack-dev | 14:27 | |
ameade | building a venv in nova right now seems to be busted | 14:28 |
danpb | jaypipes: anyone who manages to get mailman UI to be even slightly better deserves a medal for their hard work ;-) | 14:29 |
jaypipes | indeed, danpb | 14:29 |
Leander_ | jaypipes: # On branch diagnostics_libvirt | 14:30 |
jaypipes | danpb: I feel the same way about Nagios. | 14:30 |
Leander_ | that's the ouput from git | 14:30 |
jaypipes | Leander_: k, just wanted to make sure you weren't in the middle of a rebase... and how are you running tests? | 14:30 |
Leander_ | jaypipes: ./run_tests.sh | 14:30 |
jaypipes | Leander_: You might want to: rm -rf .venv && ./run_tests.sh -V | 14:31 |
jaypipes | Leander_: perhaps you've got a half-installed venv... | 14:32 |
*** ewindisch has joined #openstack-dev | 14:32 | |
Leander_ | jaypipes: the output is always | 14:33 |
Leander_ | ---------------------------------------------------------------------- | 14:33 |
Leander_ | Ran 0 tests in 0.000s | 14:33 |
Leander_ | OK | 14:33 |
Leander_ | Running PEP8 and HACKING compliance check... | 14:33 |
Leander_ | 4 imports missing in this test environment | 14:33 |
Leander_ | i will try to reinstall the venv | 14:34 |
mtaylor | that's really weird | 14:34 |
*** dolphm has quit IRC | 14:34 | |
mtaylor | Leander_: but it _does_ run tests properly on a clean master for you? | 14:34 |
Leander_ | mtaylor: it works fine on the master | 14:34 |
Leander_ | mtaylor: as soon as i add my code, however, i get the same output | 14:34 |
mtaylor | Leander_: can you push your change up to gerrit as a draft (git review -D) and then add me as a reviewer? I'd love to grab it and see what's happening | 14:34 |
jaypipes | Leander_: try running just nosetests -v nova | 14:35 |
jaypipes | Leander_: run_tests.sh and the openstack.nose_plugin tend to hide errors :( | 14:35 |
*** mnaser has joined #openstack-dev | 14:37 | |
*** jeff_ has joined #openstack-dev | 14:37 | |
Leander_ | jaypipes: currently reinstalling venv, please hold | 14:37 |
jaypipes | kk | 14:37 |
*** nunosantos has joined #openstack-dev | 14:39 | |
Leander_ | mtaylor: i think it did not get submitted as a draft | 14:40 |
*** mnaser has quit IRC | 14:40 | |
Leander_ | see https://review.openstack.org/#/c/8839/ | 14:40 |
Leander_ | i did use "git review -D" | 14:41 |
*** datsun180b has joined #openstack-dev | 14:43 | |
iccha | i did a git pull and tried reinstalling the virtual env, and its breaking. | 14:44 |
iccha | for nova | 14:44 |
*** jeff_ has quit IRC | 14:44 | |
Leander_ | jaypipes: only nosetests -v nova runs | 14:44 |
*** iccha_ has joined #openstack-dev | 14:46 | |
*** jgriffith1 has joined #openstack-dev | 14:47 | |
Leander_ | say, how do i comment on the review system | 14:47 |
Leander_ | it says that i submitted new code, but none of it showed up | 14:47 |
*** Ryan_Lane1 has joined #openstack-dev | 14:47 | |
Leander_ | and i can't find any way to inform the reviers | 14:48 |
Leander_ | :S | 14:48 |
jgriffith1 | Leander_: Gerrit should handle the email automatically for you (notification piece) | 14:48 |
jgriffith1 | Leander_: Not sure what you're seeing WRT "...none of it showed up" | 14:48 |
mtaylor | Leander_: I do not see that you have uploaded anything since June 22 | 14:48 |
mtaylor | oh, no, I'm sorry - I see "updated June 26" | 14:49 |
*** iccha has left #openstack-dev | 14:49 | |
Leander_ | mtaylor: yes, but none of the changes showed up :/ | 14:49 |
mtaylor | looking | 14:49 |
mtaylor | Leander_: I have not seen this before, we are investigating | 14:50 |
*** andrewbogott_ has joined #openstack-dev | 14:50 | |
*** andrewbogott_ has joined #openstack-dev | 14:50 | |
mtaylor | Leander_: you uploaded your updated change with -D yeah? | 14:51 |
*** Ryan_Lane has quit IRC | 14:51 | |
Leander_ | mtaylor: i did git commit -a -amend, then git review -D | 14:51 |
mtaylor | Leander_: could you try just plain git review? | 14:51 |
*** andrewbogott has quit IRC | 14:51 | |
*** andrewbogott_ is now known as andrewbogott | 14:51 | |
mtaylor | Leander_: this might be an interesting interaction of trying to push a draft change to an already published change | 14:51 |
mtaylor | Leander_: (which, if I'm right, should probably print an error)... | 14:52 |
mtaylor | ttx: could you help me wrangle client lib people to approve/merge the version code changes today? | 14:53 |
ttx | mtaylor: I can.. try | 14:54 |
mtaylor | ttx: :) | 14:54 |
mtaylor | jk0, bcwaldon: https://review.openstack.org/#/c/8427/ when you get a chance | 14:55 |
jk0 | on it | 14:55 |
*** rnirmal has joined #openstack-dev | 14:56 | |
mtaylor | chmouel, notmyname: https://review.openstack.org/#/c/8934/ if you please? | 14:56 |
*** matwood has joined #openstack-dev | 14:57 | |
notmyname | mtaylor: give me the tldr | 14:57 |
*** matwood has quit IRC | 14:58 | |
mtaylor | notmyname: versions for client libs based on git tags | 14:58 |
mtaylor | notmyname: so the vcsversion stuff we talked about ages ago | 14:58 |
notmyname | cool | 14:58 |
*** anderstj has joined #openstack-dev | 14:59 | |
Leander_ | mtaylor: submitted | 15:00 |
maoy | mtaylor: do you know how to disable the color stuff in devstack easily? | 15:00 |
mtaylor | maoy: I believe there is a config option ... cause I'm pretty sure we set nocolor in devstack gate ... one sec | 15:00 |
mtaylor | maoy: set LOG_COLOR=False | 15:01 |
maoy | mtaylor: cool. thx | 15:02 |
*** reidrac has quit IRC | 15:02 | |
*** anderstj has quit IRC | 15:06 | |
*** armaan has joined #openstack-dev | 15:07 | |
*** mindpixel has quit IRC | 15:07 | |
*** sdake has quit IRC | 15:08 | |
*** dolphm has joined #openstack-dev | 15:08 | |
*** sdake has joined #openstack-dev | 15:08 | |
Leander_ | mtaylor: i think i found the issue: | 15:10 |
Leander_ | File "<stdin>", line 1, in <module> | 15:10 |
Leander_ | File "connection.py", line 73, in <module> | 15:10 |
Leander_ | from nova.virt.libvirt import diagnostics | 15:10 |
Leander_ | ImportError: cannot import name diagnostics | 15:10 |
Leander_ | the file is in the same directory as connection.py | 15:11 |
Leander_ | however i can't seem to import it | 15:11 |
Leander_ | the other files import just fine | 15:11 |
Leander_ | :s | 15:11 |
mtaylor | Leander_: exciting! | 15:13 |
Leander_ | mtaylor i'm not sure how to fix it | 15:15 |
armaan | Anyone from openstack-qa ? | 15:16 |
mtaylor | Leander_: did you try doing a plain git review again yet? | 15:17 |
*** GheRivero_ has joined #openstack-dev | 15:17 | |
Leander_ | mtaylor: that's what you asked me right? | 15:17 |
mtaylor | yes | 15:17 |
Leander_ | i hope i don't end up spamming the review system with things that don't work :s | 15:17 |
*** katell2 has joined #openstack-dev | 15:17 | |
mtaylor | :) | 15:18 |
mtaylor | you'll be fine | 15:18 |
mtaylor | I see your new change | 15:18 |
*** mnaser has joined #openstack-dev | 15:21 | |
sdague | Leander_: does diagnostics have a bad import? | 15:21 |
Leander_ | sdague: diagnostics imports just fine | 15:22 |
*** ryant has joined #openstack-dev | 15:23 | |
Leander_ | sdague: it just fails to import in connection.py form libvirt if i run the interpreter inside the directory nova/virt/libvirt | 15:23 |
*** armaan has left #openstack-dev | 15:24 | |
ryant | any sqlalchemy gurus out there? wondering whether nova should really be running with autoflush=True on the sqlalchemy session | 15:25 |
*** danwent has joined #openstack-dev | 15:25 | |
mtaylor | devananda: ^^^ ? | 15:25 |
devananda | ryant: so, it basically doens't | 15:26 |
*** GheRivero has quit IRC | 15:26 | |
sdague | Leander_: I assume we're talking about this review - https://review.openstack.org/#/c/8839/ ? | 15:26 |
*** GheRivero_ is now known as GheRivero | 15:26 | |
Leander_ | sdague: yes | 15:27 |
GheRivero | morning people | 15:27 |
mtaylor | morning GheRivero | 15:27 |
devananda | ryant: in any case, what issue do you think autoflush=True presents? | 15:27 |
*** jaustinpage is now known as japage2 | 15:28 | |
ryant | devananda: it was my understanding that autoflush defaults to True, I'm not seeing where it is explicitly set to False | 15:28 |
sdague | so, is there a reason you have "import libvirt" in diagnostics.py? it doesn't seem like it uses it, and it might be confusing the namespace | 15:28 |
mtaylor | sdague: ++ | 15:28 |
devananda | ryant: look for "with session.begin():" | 15:28 |
bcwaldon | eglynn: could this be the cause of our registry port binding problem? | 15:28 |
*** japage2 has quit IRC | 15:29 | |
bcwaldon | eglynn: https://bugs.launchpad.net/glance/+bug/1013867 | 15:29 |
uvirtbot | Launchpad bug 1013867 in glance "glance-registry hard coded for port 9191" [Undecided,Incomplete] | 15:29 |
*** japage has joined #openstack-dev | 15:29 | |
* eglynn looking ... | 15:29 | |
ryant | devananda: I'm seeing where when running with auto_assign_floating_ip=true, records in the floating_ips table are not completely updated on instance termination | 15:29 |
mtaylor | bcwaldon: morning! you wanna do me a favor? | 15:30 |
devananda | ryant: how would that relate to autoflush? | 15:30 |
eglynn | bcwaldon: nope, the strace clearly indicates that its getting EADDRINUSE on the random port, not 9191 | 15:30 |
*** ohnoimdead has joined #openstack-dev | 15:30 | |
eglynn | bcwaldon: I'm working on service launch retry on a fresh port to get around the issue in the tests | 15:31 |
bcwaldon | mtaylor: sure | 15:32 |
bcwaldon | eglynn: ok | 15:32 |
ryant | devananda: I'm grapsing at straws here, but what I'm seeing is that 2 out of the 4 attributes that should be modified during deallocate_for_instance are not actually changing in the DB. the logic in the network manager code appears correct, the disconnect seems to be the mechanism committing changes to the DB | 15:33 |
ryant | devananda: the sqlalchemy docs also say that autoflush should be False when using autocommit | 15:33 |
mtaylor | bcwaldon: you would make me a happy unicorn if you approved: https://review.openstack.org/#/c/8427/ and https://review.openstack.org/#/c/8926/ | 15:34 |
devananda | ryant: can you reproduce this in devstack? if so, i can trace it locally and see what's going on | 15:34 |
Leander_ | sdague: need to import it in order to access the libvirt bindings | 15:34 |
ryant | devananda: I'm only seeing this when running in production with 8-12 compute nodes | 15:35 |
ryant | we don't see this in devstack | 15:35 |
Leander_ | sdague: could there be a conflict of some sorts? | 15:35 |
bcwaldon | mtaylor: le sigh | 15:35 |
bcwaldon | mtaylor: I have feedback :( | 15:35 |
mtaylor | bcwaldon: NOOOOOO | 15:35 |
bcwaldon | mtaylor: why did you make a write_versioninfo, but no read_versioninfo? | 15:36 |
devananda | ryant: hm, k. running trunk, by any chance? | 15:36 |
mtaylor | bcwaldon: uh. because I'm clearly stoopid | 15:36 |
bcwaldon | mtaylor: now I'm willing to overlook this, but I want you to know how I feel | 15:36 |
bcwaldon | mtaylor: since my feelings are important! | 15:36 |
ryant | devananda: essex-stable | 15:36 |
mtaylor | bcwaldon: how about if I follow up with a patch in a little bit that adds a read_versioninfo? | 15:36 |
bcwaldon | mtaylor: sure | 15:36 |
bcwaldon | mtaylor: I'll just ninja approve them | 15:37 |
*** heckj has joined #openstack-dev | 15:37 | |
mtaylor | bcwaldon: awesome. I would never want you to feel like I didn't value your feelings | 15:37 |
bcwaldon | mtaylor: and did this code get into openstack-common already? | 15:37 |
mtaylor | bcwaldon: yup | 15:37 |
mtaylor | jkoelker landed it yesterday | 15:37 |
bcwaldon | mtaylor: ok, so its now obvious that I need to be doing openstack-common reviews | 15:37 |
mtaylor | bcwaldon: I would love it if you would! | 15:37 |
bcwaldon | mtaylor: I havent in the past do to a lack of core memebership | 15:38 |
bcwaldon | mtaylor: but thats a silly reason not to do reviews | 15:38 |
*** rbasak has quit IRC | 15:38 | |
sdague | Leander_: where do you access the libvirt bindings in your file? | 15:38 |
sdague | because I don't see that | 15:38 |
bcwaldon | Leander_: how are you generating that traceback you posted to the ML? | 15:39 |
mtaylor | bcwaldon: well, if you wanted to start with https://review.openstack.org/#/c/8284/ ... :) | 15:39 |
bcwaldon | mtaylor: looking | 15:39 |
*** rbasak has joined #openstack-dev | 15:39 | |
*** rbasak has quit IRC | 15:40 | |
bcwaldon | mtaylor: added a 'd' to 'an' in your bug report | 15:40 |
ryant | devananda: these incomplete mods of floating ip records don't happen on every termination, just ~90% of time at non-trivial scale | 15:40 |
bcwaldon | mtaylor: tsk tsk | 15:40 |
devananda | ryant: see PM | 15:40 |
bcwaldon | mtaylor: can you sell me on the bug report? | 15:40 |
*** jgriffith1 has quit IRC | 15:40 | |
Leander_ | bcwaldon: i run nosetest instead of ./run_tests.sh | 15:40 |
bcwaldon | mtaylor: because my immediate reaction is 'I don't want openstack-common handling my deps' | 15:40 |
bcwaldon | mtaylor: because updating from it is a pain | 15:40 |
*** dhellmann has joined #openstack-dev | 15:41 | |
bcwaldon | Leander_: ok, I wanted to make sure you didnt cd into nova/virt/libvirt and run 'python connection.py' or something silly | 15:41 |
mtaylor | bcwaldon: well... one of the things that people told us they wanted at the ODS was a single global dependency list | 15:41 |
Leander_ | sdague: the "domain" var is a libvirt class passed from connection.py | 15:41 |
bcwaldon | mtaylor: which I can sort of get behind, but I dont know if openstack-common is the place to house it | 15:41 |
bcwaldon | mtaylor: to me, openstack-common is for common code | 15:42 |
bcwaldon | mtaylor: not common dep management | 15:42 |
mtaylor | bcwaldon: we looked at a whole bunch of convoluted ways to do that, including weirdness with sub-repos and stuff, and it seems like cpoying was simpler | 15:42 |
sdague | Leander_: you don't need to import libvirt to access that | 15:42 |
mtaylor | bcwaldon: oh, ok | 15:42 |
bcwaldon | mtaylor: and how will this work once we use openstack-common as an actual library | 15:42 |
bcwaldon | mtaylor: and we dont manually copy it in | 15:42 |
mtaylor | bcwaldon: so perhaps an openstack-deps repo with those deps list and the code that does the copy? | 15:42 |
mtaylor | bcwaldon: good point | 15:42 |
bcwaldon | mtaylor: what's in our deps list? | 15:42 |
*** rbasak has joined #openstack-dev | 15:42 | |
Leander_ | sdague: removing that import fix it | 15:43 |
Leander_ | what sorcery is this?! | 15:43 |
mtaylor | bcwaldon: there's two files in there - global-pip-requires and global-test-requires - which are the concatenation/de-dupped lists of what everything currently depends on | 15:43 |
bcwaldon | yeah, I'm just now looking at the code | 15:44 |
bcwaldon | mtaylor: had to get through the bug report first | 15:44 |
mtaylor | gotcha | 15:44 |
bcwaldon | mtaylor: I *really* like the common deps for versioning porpoises | 15:44 |
mtaylor | yeah. I think it'll be killer handy once we get the freight-train moving | 15:44 |
Leander_ | can anyone tell me how i can add a comment to the review i submitted? | 15:45 |
sdague | Leander_: it's just the way python works. I'm not a proper enough pythonista to give you the perfect explanation, but just realize that you only need to import namespaces if you need to access an object or definition in that namespace directly. Like libvirt.foo | 15:45 |
mtaylor | it'll also help us aggressively cache in our mirror better, fwiw | 15:45 |
sdague | Leander_: just hit the "r" key | 15:45 |
sdague | you can add your own comments to the review | 15:45 |
bcwaldon | mtaylor: yeah, I realy like the goal | 15:45 |
mtaylor | since you shouldn't be adding a depend to a project without landing it in the global list - and the global list can drive what's in the mirror | 15:45 |
bcwaldon | mtaylor: but I don't buy doing it here | 15:45 |
mtaylor | bcwaldon: awesome. let em re-approach it with similar mechanics but a different repo | 15:45 |
mtaylor | bcwaldon: I think that's a good feedback | 15:46 |
bcwaldon | okie | 15:46 |
mtaylor | bcwaldon: it also potentially solves one of the weirdnesses I had in there a little better | 15:46 |
mtaylor | bcwaldon: see, I like it when you review things | 15:46 |
bcwaldon | mtaylor: everybody does | 15:47 |
mtaylor | bcwaldon: well, not jaypipes - but that's because he's evil | 15:47 |
bcwaldon | mtaylor: or anybody working on the bittorrent stuff :) | 15:47 |
jaypipes | lol | 15:47 |
Leander_ | sdague: nothing is happing and i can't see any place to add a comment | 15:48 |
mtaylor | bcwaldon: anywhoo -- if you ninja approve those client lib changes, there'll be less folks I have to hassle today. and thanks! | 15:49 |
*** erikzaadi has quit IRC | 15:49 | |
bcwaldon | mtaylor: did you push to them? | 15:49 |
mtaylor | bcwaldon: no? | 15:50 |
bcwaldon | mtaylor: why would I ninja approve them! | 15:50 |
bcwaldon | mtaylor: we talked about this! | 15:50 |
mtaylor | bcwaldon: oh! you want me to add that function before you land them? | 15:50 |
bcwaldon | mtaylor: were you not going to do the read_versioninfo thing | 15:50 |
bcwaldon | mtaylor: I thought thats what we agreed on | 15:50 |
bcwaldon | mtaylor: at least thats what *I* agreed to | 15:50 |
mtaylor | I was going to follow up with that - since I'll need to land that in openstack-common first | 15:51 |
mtaylor | but I can do it now if needed | 15:51 |
bcwaldon | mtaylor: ok | 15:51 |
bcwaldon | mtaylor: done | 15:51 |
bcwaldon | well | 15:51 |
bcwaldon | not done done | 15:51 |
bcwaldon | mtaylor: why is versioninfo within glanceclient/ ? | 15:51 |
bcwaldon | mtaylor: I also want to be able to call 'import glanceclient; glanceclient.__version__' | 15:52 |
mtaylor | so that it gets installed as part of the package_data and is accessible via pkg_resources | 15:52 |
bcwaldon | mtaylor: is my request doable ^ | 15:52 |
mtaylor | bcwaldon: it is, although not currently implemented because it wasn't there before | 15:52 |
bcwaldon | okay | 15:52 |
bcwaldon | write that down | 15:52 |
mtaylor | that's actually one of the reasons for the versioninfo in glanceclient - is so that we can support that properly | 15:53 |
mtaylor | bcwaldon: written down | 15:53 |
bcwaldon | yes, when I ask questions, i sometimes already have a partial answer :) | 15:53 |
bcwaldon | that being one of them | 15:53 |
*** dhellmann has quit IRC | 15:53 | |
*** markmcclain has quit IRC | 15:53 | |
mtaylor | tricky tricky | 15:53 |
bcwaldon | mtaylor: and its not 100% clear what these versions look like | 15:53 |
mtaylor | I believe that's known as leading the witness | 15:53 |
bcwaldon | mtaylor: X.Y.Z? | 15:53 |
mtaylor | depends on the latest tag | 15:54 |
sdague | Leander_: go here - https://review.openstack.org/#/c/8839/ and either type the letter r on the page, or look for the review button on your last patch | 15:54 |
sdague | either should take you to the review interface | 15:54 |
sdague | make sure you are signed in | 15:54 |
mtaylor | bcwaldon: if the latest tag is X.Y, then the version will be X.Y.Z - if the latest tag is X.Y.Z, it'll be X.Y.Z.A | 15:54 |
bcwaldon | mtaylor: and where do the trailing bits come from? | 15:55 |
mtaylor | bcwaldon: technically from git describe --tags ... but the trailing bits is number of revisions since the last tag | 15:55 |
Leander_ | sdague: there is no review button for me :/ | 15:55 |
Leander_ | also the help does not list the 'r' command | 15:56 |
*** jgriffith_ has joined #openstack-dev | 15:56 | |
mtaylor | we won't be publishing/uploading those to pypi, so they're less important - but we will be shoving tarballs on tarballs.o.o - so we want them to at least be version comparable | 15:56 |
bcwaldon | tarball owls? | 15:56 |
bcwaldon | tarballs. o.O | 15:56 |
sdague | Leander_: are you logged in? | 15:56 |
mtaylor | bcwaldon: damn straight | 15:57 |
* mtaylor reminds self - needs to set up tarballs.o.o | 15:57 | |
mtaylor | LinuxJedi: ^^ remember that for me | 15:57 |
Leander_ | sdague: apparently not, i feel stupid right now -.- | 15:57 |
LinuxJedi | mtaylor: noted | 15:57 |
*** littleidea has joined #openstack-dev | 15:58 | |
bcwaldon | mtaylor: :( | 15:59 |
bcwaldon | mtaylor: https://review.openstack.org/#/c/8427/ | 15:59 |
bcwaldon | mtaylor: sorry broski | 15:59 |
apevec | mtaylor, LinuxJedi - where is the code adding comments in launchpad bugs like "OpenStack Hudson (hudson-openstack) wrote on 2012-06-08: Fix merged to keystone (master)" ? | 15:59 |
apevec | does it trigger on simply any "bug xxxxxx" ? | 16:00 |
*** e1mer has quit IRC | 16:00 | |
mtaylor | LinuxJedi: http://dom.as/2012/06/26/memsql-rage/ | 16:01 |
LinuxJedi | apevec: it is in the openstack-ci-puppet repo in /modules/gerrit/files | 16:01 |
*** dubsquared has joined #openstack-dev | 16:01 | |
LinuxJedi | apevec: it does a regex match | 16:01 |
mtaylor | bcwaldon: sad bunny rabbit - but yes | 16:01 |
LinuxJedi | mtaylor: I saw that :) | 16:01 |
*** littleidea has quit IRC | 16:01 | |
*** littleidea has joined #openstack-dev | 16:01 | |
apevec | LinuxJedi, ah thanks, I was looking at github.com/openstack-ci/gerrit | 16:02 |
*** adalbas has quit IRC | 16:02 | |
LinuxJedi | mtaylor: I have days where I think about writing an RDBMS from scratch but I've usually shaken off that idea within minutes ;) | 16:02 |
*** japage is now known as japage_afk | 16:02 | |
LinuxJedi | apevec: ah yea, that is a dead repo now | 16:02 |
LinuxJedi | apevec: I think the one you are looking for is scripts/update_bug.py | 16:03 |
*** mnaser has quit IRC | 16:03 | |
*** sdake has quit IRC | 16:04 | |
bcwaldon | mtaylor: ping me when you push | 16:04 |
bcwaldon | mtaylor: I also can't seem to hit jenkins.openstack.org | 16:04 |
smoser | anyone see this : http://paste.openstack.org/show/18842/ | 16:04 |
LinuxJedi | mtaylor: and I'm very glad we didn't benchmark Drizzle against anything :) | 16:04 |
mtaylor | bcwaldon: novaclient updated | 16:05 |
bcwaldon | smoser: what version of pep8 | 16:05 |
mtaylor | bcwaldon: new patch with cleanup posted here: https://review.openstack.org/9003 | 16:05 |
smoser | pep8 1.2-1 | 16:05 |
smoser | i guess venv is 1.1 | 16:06 |
bcwaldon | smoser: I'm out of ideas | 16:06 |
*** spiffxp has joined #openstack-dev | 16:06 | |
*** armaan has joined #openstack-dev | 16:06 | |
*** sdake has joined #openstack-dev | 16:06 | |
smoser | well, your idea was right. i think my pep8 is newer than expected. | 16:07 |
mtaylor | smoser: perhaps pep8 changed an api as of 1.2? | 16:07 |
bcwaldon | smoser: given the history of pep8's releases, there was a high probability they broke something | 16:07 |
* mtaylor is NOT a fan of the pep8 extension mechanism | 16:07 | |
mtaylor | as in | 16:07 |
Daviey | 1.1 and 1.2 is VERY different | 16:07 |
* mtaylor thinks is a broken pile of monkey turds | 16:07 | |
mtaylor | Daviey: AWESOME | 16:07 |
bcwaldon | there's a reason I set a specific pep8 dep on our projects :) | 16:07 |
bcwaldon | I think we've had 3 days now where we have to put out pep8 fires | 16:08 |
bcwaldon | NO MORE, I TELL YOU | 16:08 |
mtaylor | well, I'm glad I haven't implemented that gate-on-hacking.py request yet | 16:08 |
*** rnirmal has quit IRC | 16:08 | |
bcwaldon | mtaylor, LinuxJedi: 502 from jenkins.openstack.org? | 16:08 |
LinuxJedi | bcwaldon: looking... | 16:09 |
LinuxJedi | or I would... not loading at all for me | 16:09 |
bcwaldon | LinuxJedi: http://stsh.me/2Nx after timing out | 16:09 |
bcwaldon | LinuxJedi: it takes a while | 16:09 |
LinuxJedi | bcwaldon: ah that would be the Apache proxy timing out connecting to Jenkins... | 16:10 |
LinuxJedi | mtaylor: restart? ^ | 16:10 |
*** datsun180b_ has joined #openstack-dev | 16:10 | |
mtaylor | LinuxJedi: sure? | 16:10 |
smoser | well, to be fair to pep8... that tools/hacking.py program is calling '_main'. they did put a '_' in it. | 16:10 |
LinuxJedi | on it... | 16:10 |
mtaylor | smoser: well, but that's how pep8 suggests one extend it | 16:11 |
Leander_ | well, thanks for help!! see you guys tomorrow | 16:11 |
smoser | touche! | 16:11 |
mtaylor | smoser: rather than, say, I dunno. using plugins or some sort | 16:11 |
*** openstackjenkins has quit IRC | 16:11 | |
*** Leander_ has left #openstack-dev | 16:11 | |
smoser | well, silly me thought the '_' meant "don't use this" | 16:11 |
bcwaldon | smoser: it does | 16:11 |
bcwaldon | smoser: its python's pseudo-private method syntax | 16:11 |
bcwaldon | smoser: s/syntax/convention/ | 16:12 |
*** openstackjenkins has joined #openstack-dev | 16:12 | |
smoser | right. but apparently not if you are pep8, per mtaylor | 16:12 |
bcwaldon | smoser: pep8 does whatever the hell they want | 16:12 |
smoser | that is so awesomely ironic. | 16:12 |
bcwaldon | smoser: unfortunately, yes | 16:12 |
mtaylor | bcwaldon: why would you write quality code if you're the code quality tool??? | 16:12 |
* mtaylor hits bcwaldon with clue bat | 16:12 | |
bcwaldon | mtaylor: DOES NOT COMPUTE | 16:12 |
*** datsun180b has quit IRC | 16:13 | |
*** datsun180b_ is now known as datsun180b | 16:13 | |
LinuxJedi | bcwaldon: Jenkins should be good now (if a little slow at the moment) | 16:13 |
bcwaldon | LinuxJedi: ok, thank you | 16:13 |
*** dubsquared has quit IRC | 16:14 | |
*** Mandell has joined #openstack-dev | 16:16 | |
*** sleepsonzzz is now known as sleepsonthefloor | 16:16 | |
*** kindaopsdevy has joined #openstack-dev | 16:18 | |
*** adalbas has joined #openstack-dev | 16:18 | |
*** Mandell has quit IRC | 16:19 | |
*** sandywalsh_ has quit IRC | 16:19 | |
*** armaan has left #openstack-dev | 16:20 | |
*** sandywalsh has joined #openstack-dev | 16:21 | |
*** mnaser has joined #openstack-dev | 16:22 | |
*** epim has joined #openstack-dev | 16:25 | |
*** mnewby has quit IRC | 16:27 | |
*** rnirmal has joined #openstack-dev | 16:29 | |
*** kindaopsdevy has quit IRC | 16:31 | |
*** mnewby has joined #openstack-dev | 16:31 | |
*** kindaopsdevy has joined #openstack-dev | 16:31 | |
*** datsun180b has quit IRC | 16:31 | |
*** mnewby has quit IRC | 16:32 | |
*** datsun180b has joined #openstack-dev | 16:32 | |
*** fc__ has quit IRC | 16:33 | |
*** mnewby has joined #openstack-dev | 16:33 | |
*** thingee has joined #openstack-dev | 16:34 | |
*** danpb has quit IRC | 16:35 | |
*** issackelly has joined #openstack-dev | 16:36 | |
bcwaldon | eglynn: do you have time to do some reviews? | 16:44 |
eglynn | bcwaldon: sure! | 16:45 |
bcwaldon | eglynn: https://review.openstack.org/#/c/8989/ | 16:45 |
bcwaldon | eglynn: https://review.openstack.org/#/c/8992/ | 16:45 |
* eglynn looking ... | 16:45 | |
bcwaldon | eglynn: I'm asking you since I know you're interested in the db cleanup stuff | 16:45 |
eglynn | cool | 16:45 |
*** ayoung has joined #openstack-dev | 16:47 | |
*** mgz has quit IRC | 16:48 | |
*** anderstj has joined #openstack-dev | 16:48 | |
*** gyee has joined #openstack-dev | 16:51 | |
*** edygarcia has quit IRC | 16:55 | |
andrewbogott | jkoelker or dhellmann, could one of you approve 8585? It has many +s already. | 16:55 |
*** edygarcia has joined #openstack-dev | 16:57 | |
vishy | maoy: ping | 16:59 |
maoy | vishy: yes | 16:59 |
vishy | maoy: https://bugs.launchpad.net/nova/+bug/1017418 | 16:59 |
uvirtbot | Launchpad bug 1017418 in nova "NoMoreFloatingIps: Zero floating ips available after repeatedly creating and destroying instances over time" [High,Confirmed] | 16:59 |
*** andrewsben_is_a_ is now known as andrewsben | 16:59 | |
vishy | maoy: so we have a race condition on ip allocation if an instance is destroyed before the spawn is finished. Just wanted to get your thoughts on how to handle it | 17:00 |
vishy | maoy: I think what is happening is the deallocate_for_instance is getting called before the allocate_for_instance | 17:00 |
maoy | vishy: i see. | 17:01 |
maoy | vishy: I will get back to you on this. running between meetings now. | 17:01 |
*** dtroyer_zzz is now known as dtroyer | 17:01 | |
vishy | maoy: no worries. I will think about some options too | 17:01 |
ryant | vishy: I'm seeing this issue as well, but I don't think this the only scenario in which it occurs | 17:02 |
vishy | ryant: we need to be more careful about our deleting of instances. Perhaps by waiting to deallocate stuff until the current task has finished or something | 17:02 |
ryant | vishy: what I've seen is that the DB is updated in an incomplete way | 17:03 |
*** jkelly has joined #openstack-dev | 17:03 | |
ryant | vishy: the floating_ips table doesn't always get updated correctly on instance termination, even when deleting long-lived instances | 17:04 |
vishy | ryant: I haven't seen that happen | 17:04 |
*** adalbas has quit IRC | 17:04 | |
vishy | ryant: do you have a repro with an error message? | 17:04 |
ryant | vishy: there is no error message, this happens silently until you "run out" of floating IP's | 17:05 |
*** reed has joined #openstack-dev | 17:05 | |
*** sdake has quit IRC | 17:05 | |
ryant | vishy: basically, project_id column and the auto_assigned columns don't get update completely. FYI we're running with auto_assign_floating_ip=true | 17:06 |
vishy | ryant: Yes I saw the bug report on that but I can't seem to reproduce. | 17:07 |
vishy | ryant: is it possible you have an old deleted network in your db? | 17:07 |
*** dachary has quit IRC | 17:07 | |
ryant | vishy: no, we don't | 17:08 |
*** sdake has joined #openstack-dev | 17:08 | |
vishy | ryant: darn, I was hoping maybe it was this bug: https://bugs.launchpad.net/nova/+bug/1017633 | 17:08 |
uvirtbot | Launchpad bug 1017633 in nova "deallocate_fixed_ip attempts to update an already deleted fixed_ip" [Medium,In progress] | 17:08 |
vishy | ryant: if you can get it to happen and find a traceback in the compute or network log, that would help | 17:08 |
ryant | vishy: we tend to see "leaked" floating IP's on larger deployments (10+) compute nodes | 17:09 |
vishy | ryant: I can't see anywhere in the code where it would obviously fail. | 17:09 |
ryant | vishy: me neither, the network manager code looks fine | 17:09 |
*** harlowja has joined #openstack-dev | 17:09 | |
vishy | ryant: is it possible one of the network workers was not responding? | 17:09 |
vishy | ryant: So that the message to deallocate the network got lost? | 17:10 |
ryant | vishy: no, we can still provision new instances through any network worker | 17:10 |
ryant | vishy: no, the deallocate is incomplete | 17:10 |
ryant | vishy: it makes the appropriate update the the fixed_ip_id & host columns | 17:11 |
*** torgomatic has joined #openstack-dev | 17:11 | |
ryant | vishy: the deallocate action fails to update the project_id & auto_assigned columns | 17:12 |
*** PotHix has joined #openstack-dev | 17:12 | |
vishy | ryant: interesting, that should be done by the source worker that made the call... | 17:12 |
*** dhellmann has joined #openstack-dev | 17:13 | |
*** markmcclain has joined #openstack-dev | 17:13 | |
*** jakedahn_zz is now known as jakedahn | 17:13 | |
vishy | ryant: and you get no traceback? | 17:14 |
vishy | ryant: keep in mind the traceback likely won't be on the network host of the vm | 17:14 |
ryant | vishy: no traceback, just an incomplete mod of the floating_ips table | 17:14 |
vishy | ryant: since deallocate is not rpcd to another host | 17:14 |
*** zigo-_- has joined #openstack-dev | 17:15 | |
vishy | ryant: so it will likely be on another network worker | 17:15 |
*** mnaser has quit IRC | 17:15 | |
*** zigo has quit IRC | 17:15 | |
ryant | vishy: good to know, but I have been able to reproduce sporadically with a single compute node and network worker | 17:16 |
ryant | :vishy: no tracebacks | 17:16 |
vishy | ryant: and still no traceback huh? | 17:16 |
vishy | ryant that is very odd | 17:16 |
*** dubsquared has joined #openstack-dev | 17:16 | |
ryant | vishy: I suspect DB performance | 17:17 |
bcwaldon | eglynn: this one, too! https://review.openstack.org/#/c/8978/ | 17:17 |
eglynn | bcwaldon: got it ... | 17:17 |
bcwaldon | eglynn: actually, I'll probably need to rebase it | 17:17 |
eglynn | k | 17:17 |
bcwaldon | eglynn: but a +2 wouldnt hurt | 17:17 |
*** mnaser has joined #openstack-dev | 17:17 | |
ryant | vishy: not sure how all this works, but it appears that the updates to floating_ips table are run as separate transactions in the DB, perhaps the mods we need are being rolled back in our deplyoment? | 17:18 |
vishy | They are separate commands | 17:18 |
vishy | ryant: but it is very odd that the second wouldn't be running without traceback | 17:19 |
*** s0mik has joined #openstack-dev | 17:19 | |
ayoung | heckj, I won't be able to be at today's meeting, but here is my status https://gist.github.com/2997212 | 17:20 |
*** dubsquared has quit IRC | 17:20 | |
*** adalbas has joined #openstack-dev | 17:20 | |
ryant | vishy: another tidbit, we have been seeing serious DB performance issues ie in a 12 node deployment we are running out of DB connections frequently | 17:21 |
vishy | ryant: how many connections are you allowing? | 17:21 |
heckj | ayoung: thanks | 17:21 |
ryant | vishy: 100, we may up that number | 17:22 |
*** Slower has quit IRC | 17:22 | |
*** rafaduran has joined #openstack-dev | 17:23 | |
vishy | ryant: yeah you will need a lot more than that | 17:24 |
*** dubsquared has joined #openstack-dev | 17:24 | |
vishy | every worker has a connection pool of 5 | 17:24 |
*** GheRivero has quit IRC | 17:24 | |
ryant | vishy: ah, that's good to know | 17:25 |
vishy | 12 * 3 (compute, network, metadata) * 5 = 180 connections potentially | 17:25 |
ryant | vishy: + keystone + glance | 17:25 |
vishy | ryant: right :) | 17:25 |
ryant | vishy: I think there may still be an issue since I can sporadically reproduce with a single compute node, but it seems more pronounced at scale | 17:26 |
vishy | ryant: If you can find me a traceback on one node that would be amazing | 17:27 |
vishy | or at least a repro + a bunch of logs | 17:27 |
*** Slower has joined #openstack-dev | 17:27 | |
ryant | vishy: I'll go scour my logs to see what I can find, but I'm pretty sure I was tailing my logs in real-time and saw no tracebacks. I'll spend some more time on this today | 17:28 |
vishy | ryant: cool, thanks | 17:28 |
ryant | vishy: thanks for the help | 17:29 |
*** garyk has quit IRC | 17:29 | |
vishy | ryant: no problem | 17:33 |
*** dachary has joined #openstack-dev | 17:37 | |
bcwaldon | mtaylor: | 17:38 |
bcwaldon | mtaylor: we have a problem | 17:38 |
bcwaldon | mtaylor: https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6225/consoleFull | 17:38 |
bcwaldon | mtaylor: please to the fix | 17:38 |
mtaylor | bcwaldon: ephemeral | 17:42 |
bcwaldon | mtaylor: you're ephemeral | 17:42 |
*** vanchester has joined #openstack-dev | 17:43 | |
mtaylor | bcwaldon: and we're (slowly) marching towards eliminating that ... it's sadly trickier than we'd like | 17:43 |
bcwaldon | mtaylor: can you splain what happened | 17:43 |
mtaylor | bcwaldon: so, what happened is that this require is listed in setup_requires | 17:44 |
mtaylor | which means our mirror doesn't see it, since it does pip downloads, which grab most of the things | 17:44 |
mtaylor | so this is getting attempted installed by distutils | 17:44 |
*** vanchester has left #openstack-dev | 17:44 | |
mtaylor | which doesn't use our mirror | 17:44 |
bcwaldon | okie dokie | 17:44 |
mtaylor | which means it's vulnerable to network suck | 17:44 |
mtaylor | bcwaldon: BUT - I have ideas... | 17:44 |
mtaylor | bcwaldon: actually, I have GREAT idea | 17:45 |
reed | there is a request to join the cla team from the NTT team ... https://launchpad.net/~openstack-cla/+editproposedmembers | 17:45 |
reed | i'm writing to them now explaining that we don't allow team membership to that team, only individuals. Correct? | 17:46 |
*** japage_afk is now known as japage | 17:47 | |
*** s0mik has quit IRC | 17:47 | |
*** adjohn has joined #openstack-dev | 17:49 | |
*** timjr has joined #openstack-dev | 17:52 | |
*** garyk has joined #openstack-dev | 17:56 | |
vishy | mtaylor: thoughts? https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6215/consoleFull | 17:58 |
vishy | mtaylor: do we not have python-glanceclient in our pypi cache? | 17:58 |
vishy | jeblair, LinuxJedi: ^^ | 18:02 |
LinuxJedi | vishy: that appears to be a missing file in python-glanceclient to me (unless I'm missing something) | 18:04 |
bcwaldon | LinuxJedi: mtaylor | 18:05 |
bcwaldon | LinuxJedi: he did it | 18:06 |
bcwaldon | LinuxJedi: and he just explained why this problem will go away | 18:06 |
bcwaldon | but it hasnt yet | 18:06 |
* LinuxJedi takes mtaylor's keyboard away from him :) | 18:06 | |
*** ryant has quit IRC | 18:07 | |
*** dprince has quit IRC | 18:07 | |
dtroyer | mtaylor, LinuxJedi , bcwaldon: we can also address that by movie the glance client install ahead of the horizon install, where it arguably should be anyway... | 18:11 |
bcwaldon | I'm curious how the glanceclient made it through the gate in the first place | 18:11 |
*** jaypipes has quit IRC | 18:15 | |
*** apevec has quit IRC | 18:19 | |
*** novas0x2a|laptop has joined #openstack-dev | 18:21 | |
*** mattray has joined #openstack-dev | 18:23 | |
*** mattray has quit IRC | 18:23 | |
vishy | tr3buchet: https://review.openstack.org/#/c/8859/ | 18:25 |
*** jaypipes has joined #openstack-dev | 18:25 | |
maoy | vishy: which bug is it again? sorry i lost the link.. | 18:30 |
*** jaypipes has quit IRC | 18:30 | |
vishy | maoy: https://bugs.launchpad.net/nova/+bug/1017418 | 18:31 |
uvirtbot | Launchpad bug 1017418 in nova "NoMoreFloatingIps: Zero floating ips available after repeatedly creating and destroying instances over time" [High,Confirmed] | 18:31 |
vishy | maoy: I'm going to lunch. Let me know if you have any thoughts | 18:31 |
maoy | vishy: sure. | 18:31 |
*** jaypipes has joined #openstack-dev | 18:33 | |
tr3buchet | vishy: on it | 18:33 |
*** mnaser has quit IRC | 18:34 | |
*** mnaser has joined #openstack-dev | 18:36 | |
vishy | comstud: https://review.openstack.org/#/c/8980/ posted some thoughts on how we might do it with a memoization approach | 18:36 |
vishy | comstud: might actually be a bit nicer | 18:36 |
*** ryan3 has joined #openstack-dev | 18:39 | |
*** jaypipes has quit IRC | 18:40 | |
*** dachary has quit IRC | 18:40 | |
vishy | comstud: Only drawback i see is that we would need to redo search_opts and limiting in the extensions to make sure that the call is the same as the one we memoized earlier and that seems fragile | 18:40 |
vishy | ewindisch: ^^ | 18:40 |
*** dachary has joined #openstack-dev | 18:40 | |
ewindisch | vishy: ? | 18:41 |
vishy | ewindisch: the memoization strategy i posted on the review above | 18:42 |
ewindisch | looking | 18:42 |
maoy | vishy: during disassociate_floating_ip, shouldn't we ignore FloatingIpNotAssociated exception to make it idempotent? | 18:42 |
*** mnaser has quit IRC | 18:42 | |
*** mnaser has joined #openstack-dev | 18:44 | |
mtaylor | bcwaldon: hrm. that's a different problem than the one I told you about before | 18:44 |
*** ryan3 has quit IRC | 18:44 | |
ewindisch | vishy: Unless we offload the caching into something like memcache, keeping the cache in the request is a good idea, because it gets collected frequently. We then eliminate a lot of complexity around expiry, etc. | 18:44 |
mtaylor | bcwaldon: and I agree with you - I don't understand how glanceclient made it through the gate if that error exists... | 18:44 |
vishy | ewindisch: i suppose but putting a wrapper for db calls into the request object seems strange to me | 18:44 |
*** jaypipes has joined #openstack-dev | 18:45 | |
ewindisch | but having it in the request works fine for webob, but not everywhere... | 18:45 |
vishy | maoy: well we could but I don't know if that really fixes the issue | 18:45 |
maoy | vishy: at least that's how delete instance is handled right now -- ignore instances that are there. | 18:45 |
maoy | vishy: of course. | 18:45 |
vishy | maoy: the exception does stop the disassociation so that may help | 18:46 |
mtaylor | heckj, dtroyer, bcwaldon: investigating | 18:46 |
vishy | maoy: i still think we may have out of order problems though | 18:46 |
*** ryan3 has joined #openstack-dev | 18:46 | |
ewindisch | vishy: it is strange. I don't really like it either. | 18:46 |
heckj | mtaylor: thxusir! | 18:46 |
*** johnpostlethwait has joined #openstack-dev | 18:47 | |
vishy | maoy: i mean it would allow us to disassociate and deallocate, but the later associate / allocate will still leave things broken | 18:47 |
maoy | vishy: in the design i have, a task may be preempted. it knows that by checking the current task_id to see if it matches. if it doesn't, then it will just stop executing (similar as being killed) | 18:47 |
maoy | vishy: but i'd like to reproduce that bug in my environment first to understand it better. | 18:47 |
*** mnaser has quit IRC | 18:48 | |
mtaylor | SOD IT | 18:49 |
mtaylor | GAH!!!!!!!!!!!!! | 18:49 |
mtaylor | stab stab stab stab stab | 18:49 |
maoy | vishy: this change would need a modification to the db models. so i haven't gone that far yet. | 18:49 |
mtaylor | bcwaldon: just so you know, I hate everyone in the universe | 18:49 |
* mtaylor will rant about the specific set of circumstances which caused this later ... goes about fixing | 18:50 | |
*** ryan3 has quit IRC | 18:50 | |
mtaylor | dtroyer: also, moving python glanceclient install before horizon will also fix this bit | 18:50 |
mtaylor | dtroyer: and honestly is probably more correct anyway | 18:50 |
mtaylor | but this is ALSO a bug | 18:51 |
*** mnaser has joined #openstack-dev | 18:51 | |
dtroyer | mtaylor: https://review.openstack.org/9018 when you're ready for it | 18:52 |
mtaylor | dtroyer: awesome | 18:52 |
*** ryan3 has joined #openstack-dev | 18:52 | |
*** ryan3 has left #openstack-dev | 18:54 | |
andrewbogott | jkoelker or dhellmann, could one of you please merge 8585? Each of you gave it a +2 but neither of you clicked the 'approve' button :( | 18:56 |
comstud | vishy: replied without seeing this here.. | 18:57 |
*** ryant has joined #openstack-dev | 18:57 | |
comstud | vishy: but yeah, that's my concern... with memoization, things are actually less efficient. | 18:58 |
dhellmann | oops, sorry, andrewbogott | 18:58 |
dhellmann | andrewbogott: approved | 18:59 |
andrewbogott | Thanks! | 18:59 |
comstud | vishy: If you do the same instance_get_all() a 2nd time... you have to loop thru all of the results of the 2nd query... store them in a lookup table... so that you can loop thru the original list of servers and pluck the data out you need from the 2nd query | 18:59 |
* andrewbogott is unblocked at last! For a few minutes at least. | 18:59 | |
comstud | vishy: My patch results in a single loop through the servers... as you already have the lookup table. | 19:00 |
*** datsun180b has quit IRC | 19:01 | |
mtaylor | bcwaldon, dtroyer, heckj: https://review.openstack.org/9020 | 19:01 |
comstud | vishy: memoization would still be an improvement...but this is better. The most efficient alternative to this is true caching in the DB layer... which is somewhat the same thing | 19:01 |
mtaylor | I'll get that applied to openstack-common and to the other libs in a few | 19:01 |
*** datsun180b has joined #openstack-dev | 19:03 | |
heckj | mtaylor: +1d https://review.openstack.org/#/c/9020/ | 19:03 |
mtaylor | heckj: awesome. I just re-uploaded. (/me learns to test BEFORE uploading) | 19:06 |
*** adalbas has quit IRC | 19:06 | |
*** lloydde has joined #openstack-dev | 19:07 | |
*** mnaser has quit IRC | 19:15 | |
*** mnaser has joined #openstack-dev | 19:17 | |
*** issackelly has quit IRC | 19:22 | |
*** gyee has quit IRC | 19:24 | |
*** s0mik has joined #openstack-dev | 19:24 | |
*** iccha has joined #openstack-dev | 19:24 | |
mtaylor | dtroyer: yeah - that patch of yours is going to need to go in before anything else | 19:25 |
maoy | vishy: do you know the status of this bp: https://blueprints.launchpad.net/nova/+spec/delete-in-any-state | 19:26 |
dtroyer | mtaylor: I pinged bcwaldon and sleepsonthefloor about it, they may be at lunch… is jeblair around? | 19:28 |
*** rafaduran has quit IRC | 19:28 | |
*** issackelly has joined #openstack-dev | 19:28 | |
mtaylor | dtroyer: he's not, he's at a conference | 19:29 |
notmyname | mtaylor: I've got something for you (when you are done with your meeting) | 19:29 |
mtaylor | dtroyer: I think we should ninja approve it - it's kind of a showstopper at the moment | 19:29 |
dtroyer | mtaylor: done | 19:30 |
mtaylor | dtroyer: awesome. | 19:30 |
* mtaylor sits and waits | 19:30 | |
mtaylor | notmyname: sup? | 19:30 |
ayoung | dolphm, or termie can you add additional weight to https://review.openstack.org/#/c/8932/ ? This is the start of a long slog... | 19:31 |
notmyname | mtaylor: soemthing I asked you about a couple of weeks ago: my LP login is @racklabs (but my racklabs email has been completely removed from LP). doesn't really cause me any issues, unless something using the LP SSO grabs that email | 19:31 |
mtaylor | notmyname: thanks for the reminder. I shall ping people... | 19:32 |
notmyname | mtaylor: so if it's a non-issue, I'm fine. it hasn't caused me any issues yet. but it seems like it /should/ be changed... | 19:32 |
mtaylor | notmyname: I think it should - it's not an issue for any of our systems either - whereas doing a new account then a merge (which is the consumer method of fixing this) will bork your account until we file a ticket to have them fix it in their db (don't even get me started) | 19:33 |
mtaylor | so lemme see if there's behind the scenes magic that can be done | 19:33 |
notmyname | mtaylor: cool | 19:33 |
notmyname | mtaylor: thanks | 19:33 |
mtaylor | notmyname: sure thing! | 19:35 |
*** littleidea has quit IRC | 19:36 | |
*** iryoung has quit IRC | 19:36 | |
*** mnaser has quit IRC | 19:39 | |
Shrews | i don't suppose any Mac users here runs devstack in a Parallels VM, do they? | 19:41 |
Shrews | jaypipes: ^^^^ i know you at least used to be a mac guy at one point... | 19:41 |
jaypipes | Shrews: nope. not me. | 19:41 |
Shrews | damn. can't get it to launch instances | 19:42 |
*** mnaser has joined #openstack-dev | 19:43 | |
*** lloydde has quit IRC | 19:44 | |
*** danwent has quit IRC | 19:48 | |
*** johnpostlethwait has quit IRC | 19:48 | |
maoy | vishy: i wonder if you've seen this before: http://paste.openstack.org/show/18852/ | 19:49 |
*** danwent has joined #openstack-dev | 19:49 | |
*** alaski has quit IRC | 19:51 | |
*** krtaylor has quit IRC | 19:54 | |
*** alaski has joined #openstack-dev | 19:54 | |
*** sdake has quit IRC | 19:54 | |
*** Shrews has quit IRC | 19:57 | |
*** sdake has joined #openstack-dev | 19:57 | |
*** Shrews has joined #openstack-dev | 19:59 | |
*** iccha1 has joined #openstack-dev | 20:00 | |
*** s0mik has quit IRC | 20:01 | |
*** iccha has quit IRC | 20:03 | |
sdague | hmmm... so is someone working to fix glance in the devstack gate? | 20:04 |
*** zigo-_- has quit IRC | 20:07 | |
maoy | sgague: i'm not sure but jenkins is passing jobs this morning | 20:07 |
vishy | tr3buchet: wow we have a big issue with ip deallocation | 20:08 |
vishy | tr3buchet: got a sec? | 20:08 |
vishy | maoy: haven't seen that one but i guess it doesn't work with secondary ips properly | 20:09 |
*** adalbas has joined #openstack-dev | 20:09 | |
*** jkelly has quit IRC | 20:10 | |
*** markmcclain has quit IRC | 20:10 | |
maoy | vishy: is there a job to periodically recycle floating IPs with missing instances? | 20:10 |
*** rods has quit IRC | 20:11 | |
*** dhellmann has quit IRC | 20:11 | |
*** rods has joined #openstack-dev | 20:11 | |
maoy | vishy: i'm also way behind quantum/melange progress. will floating IPs still be managed by Nova by the end of Folsom? | 20:11 |
sdague | maoy: it's not now. Looks like this change is needed to fix, but it got stomped by jenkins for other reasons - https://review.openstack.org/#/c/9018/ | 20:11 |
vishy | maoy: fixed | 20:12 |
*** wiliam has quit IRC | 20:12 | |
vishy | maoy: not floating | 20:12 |
sdague | dtroyer: maybe you want to reflush that change | 20:12 |
*** markmcclain has joined #openstack-dev | 20:12 | |
vishy | maoy: although I just discovered that the fixed is broken | 20:12 |
*** dhellmann has joined #openstack-dev | 20:13 | |
maoy | vishy: that link is for glance client, not fixed ip related.. | 20:15 |
*** timello has quit IRC | 20:16 | |
*** adalbas has quit IRC | 20:21 | |
*** anderstj has quit IRC | 20:23 | |
maoy | vishy: to "hard" delete a VM is easier since it's local resource and will never to reused. IP addresses are different. We can force to mark a floating IP as disassociated in the db, but without the confirmation of nova-network, it's unclear if it's safe to reuse the floating IP on another nova-network instance. so periodically recycle garbage is probably a better idea for IPs? | 20:24 |
vishy | maoy: sure but how should this recycle occur? | 20:25 |
vishy | maoy: assuming network and compute don't know anything about each other | 20:26 |
maoy | vishy: can n-net query a list of floating IPs that it is responsible for but has missing instances? | 20:27 |
*** mnaser has quit IRC | 20:27 | |
maoy | vishy: same for fixed ips.. | 20:27 |
vishy | maoy: it isn't supposed to know anything about instances | 20:29 |
vishy | maoy: so it "can" but it shouldn't | 20:29 |
maoy | vishy: does n-cpu know about those IPs? | 20:30 |
*** mnaser has joined #openstack-dev | 20:30 | |
*** sandywalsh has quit IRC | 20:31 | |
*** japage has quit IRC | 20:32 | |
*** iccha1 has left #openstack-dev | 20:32 | |
*** timjr has quit IRC | 20:33 | |
*** timjr has joined #openstack-dev | 20:33 | |
*** jog0 has joined #openstack-dev | 20:35 | |
*** timjr_ has joined #openstack-dev | 20:37 | |
vishy | tr3buchet: https://review.openstack.org/9026 | 20:38 |
*** timjr has quit IRC | 20:38 | |
*** timjr_ is now known as timjr | 20:38 | |
tr3buchet | vishy: thx | 20:38 |
*** littleidea has joined #openstack-dev | 20:39 | |
*** dolphm has quit IRC | 20:41 | |
*** krtaylor has joined #openstack-dev | 20:46 | |
vishy | tr3buchet: do you know anyone that is using nova-ipam with quantum to make sure that this doesn't break them? | 20:47 |
vishy | maoy: it tells network to deallocate the network | 20:47 |
vishy | maoy: which cleans up all ips for the instance | 20:48 |
Daviey | vishy: did you see my question in #openstack? | 20:48 |
vishy | Daviey: I did and i attempted to answer it but apparently I can't hit the return key properly | 20:49 |
Daviey | heh | 20:49 |
*** nunosantos has quit IRC | 20:52 | |
tr3buchet | vishy: i don't... | 20:53 |
maoy | vishy: is this right? if nova-network is not reachable, or somehow misbehave, the network will not be properly deallocated, and no one will try that again (unlike an instance which will be periodically retried) | 20:53 |
*** dprince has joined #openstack-dev | 20:57 | |
*** littleidea has quit IRC | 20:57 | |
vishy | maoy: correct | 21:02 |
*** adjohn has quit IRC | 21:02 | |
vishy | maoy: well it will throw an exception and the instance won't delete properly i believe | 21:03 |
*** dubsquared has quit IRC | 21:07 | |
*** dhellmann has quit IRC | 21:07 | |
*** littleidea has joined #openstack-dev | 21:07 | |
maoy | vishy: what's a more desirable behavior? | 21:08 |
comstud | vishy: did you happen to see my other points above? | 21:08 |
comstud | (saw your follow up to the review just now) | 21:08 |
comstud | just curious | 21:08 |
vishy | comstud: yeah I mean i think we could do it if we are careful about making the same call in all places | 21:09 |
comstud | ya.. my point is that's actually less efficient than my patch | 21:09 |
comstud | w/ extensions | 21:09 |
comstud | since if you 2 instance_get_alls | 21:09 |
comstud | you have to resolve all of the responses together | 21:10 |
vishy | (we should have all the information we need to build the same exact request, but if we are going to do that anyway, we risk breaking it also) | 21:10 |
comstud | it's probably a net-0 with 1 extension | 21:10 |
comstud | but is worse with 4 extensions | 21:10 |
mtaylor | jkoelker: https://review.openstack.org/#/c/9021/ when you get a moment | 21:10 |
vishy | comstud: I guess I don't follow exactly | 21:10 |
comstud | i tried to explain above.. | 21:10 |
comstud | but | 21:10 |
*** dubsquared has joined #openstack-dev | 21:10 | |
comstud | say core API does 'instance_get_all' | 21:10 |
vishy | each subsequent compute_api.get_all() should return the memoized list | 21:11 |
comstud | forms this list of servers for response | 21:11 |
comstud | yeah, extension come around.. if you had them do get_all() again... | 21:11 |
comstud | so you get the memoized list | 21:11 |
*** novas0x2a|laptop has quit IRC | 21:11 | |
comstud | you now have to convert that to a dictionary/lookup table | 21:11 |
comstud | so you can take the original response... | 21:11 |
comstud | and add things to it efficiently. | 21:11 |
vishy | comstud: ah gotcha | 21:11 |
comstud | with 3 extensions... it's really less efficient | 21:12 |
comstud | than having the lookup table up front | 21:12 |
comstud | build it once | 21:12 |
comstud | anyway.. just a minor point | 21:12 |
*** novas0x2a|laptop has joined #openstack-dev | 21:12 | |
comstud | saying that real DB caching would be the better solution | 21:12 |
vishy | comstud: yeah i just want it to suck less :) | 21:12 |
comstud | over memoization | 21:12 |
comstud | yeah :) | 21:12 |
*** steveb_ has joined #openstack-dev | 21:12 | |
comstud | i tend to want to make things as efficient as possible | 21:13 |
comstud | it can lead to complicated code sometimes | 21:13 |
comstud | in this case, it's fairly simple.. but it's specialized for API/extensions | 21:13 |
comstud | Waiting for a reply from Eric on his last suggestion.. | 21:14 |
vishy | comstud: yeah and it is specialized to just the instance record | 21:14 |
comstud | which is a good one, but we'd have to change the inheritence | 21:14 |
comstud | and I'm not sure of the side effects there | 21:14 |
comstud | his concern that the server would not be in the cache is not a concern to me | 21:15 |
comstud | if it's not in the cache.. your code would fail very quickly! | 21:15 |
comstud | and you'd know you screwed up | 21:15 |
*** markvoelker has quit IRC | 21:15 | |
comstud | the current tests for the extensions would fail, anyway | 21:16 |
*** alaski has quit IRC | 21:16 | |
comstud | anyway, cools.. if I had to implement something larger here, i'd probably have to punt it to someone else. | 21:17 |
comstud | not enough hours in a day | 21:17 |
*** mnaser has quit IRC | 21:18 | |
*** gabrielhurley has joined #openstack-dev | 21:18 | |
*** mnaser has joined #openstack-dev | 21:19 | |
ewindisch | My point was simply that get_db_instances(self) seems to be redundant, because the caller could simply call _get_servers() instead. | 21:19 |
vishy | comstud: yeah i think we go with this until someone does a better refactor | 21:19 |
ewindisch | it wouldn't be a big change, but would make the code more deterministic | 21:20 |
*** novas0x2a|laptop has quit IRC | 21:20 | |
ewindisch | (then _get_servers() could implement or call get_db_instances()) | 21:20 |
*** krtaylor has quit IRC | 21:21 | |
vishy | ewindisch: I'm moving https://blueprints.launchpad.net/nova/+spec/trusted-messaging to f-3 since it seems unlikely to be done in time for f-2 | 21:22 |
*** novas0x2a|laptop has joined #openstack-dev | 21:23 | |
bcwaldon | mtaylor: around? | 21:27 |
vishy | jgriffith_, sleepsonthefloor: can you link the 8073 review to this blueprint: https://blueprints.launchpad.net/nova/+spec/extract-nova-volumes | 21:27 |
soren | Can someone help me point out which bit of code makes sure I don't update anyone else's instances? I'm staring at the OSAPI code and I just don't see anything verifying that I have access to the server I'm trying to update. | 21:31 |
*** maoy has quit IRC | 21:31 | |
jgriffith_ | vishy: Yes... and I'm hoping to have that ready for review tonight | 21:32 |
*** littleidea has quit IRC | 21:32 | |
*** anderstj has joined #openstack-dev | 21:32 | |
vishy | soren: the tenant_id is in the url | 21:32 |
vishy | soren: the tenant_id has to match the auth_token you pass in or you will get a 403 | 21:33 |
soren | What if I put another tenant_id? | 21:33 |
soren | vishy: What if I put a tenant_id that matches my auth_token, but not the instance? | 21:33 |
vishy | soren: good question. in theory the require_project_context in the db should take care of that as well as the policy admin_or_owner check | 21:34 |
comstud | ewindisch: ya.. i agree.. but see comment about how they're different classes right now | 21:34 |
*** salgado is now known as salgado-afk | 21:34 | |
*** dachary has quit IRC | 21:34 | |
*** dachary has joined #openstack-dev | 21:35 | |
*** littleidea has joined #openstack-dev | 21:36 | |
comstud | ewindisch: and I dunno..if someone messes up in the meantime, it'll be immediately clear when the extension fails on first query... that and the extension tests would fail | 21:36 |
soren | vishy: Hm... Ok, thanks. Those are probably the hints I needed. | 21:36 |
vishy | soren: ideally it is done in wrap_check_policy | 21:37 |
vishy | soren: but there is still the backup in the db call (which I'd like to remove) | 21:37 |
*** segfault923 has quit IRC | 21:37 | |
steveb_ | hey, any chance I could get some merge love on this? https://review.openstack.org/#/c/8790/ | 21:40 |
*** jog0_ has joined #openstack-dev | 21:41 | |
*** jog0 has quit IRC | 21:42 | |
*** jog0_ is now known as jog0 | 21:42 | |
soren | vishy: Yes, thanks. That helped. | 21:43 |
*** johnpostlethwait has joined #openstack-dev | 21:44 | |
vishy | soren: cool | 21:44 |
*** dubsquared has quit IRC | 21:47 | |
*** jog0 has quit IRC | 21:49 | |
*** andrewbogott has quit IRC | 21:50 | |
*** ywu has joined #openstack-dev | 21:54 | |
ewindisch | vishy: that is fine. I haven't even /started/ that yet. | 21:57 |
*** adjohn has joined #openstack-dev | 21:59 | |
*** markmcclain has quit IRC | 21:59 | |
ryant | vishy: I have a traceback for you | 22:01 |
*** ayoung has quit IRC | 22:03 | |
*** rods has quit IRC | 22:04 | |
heckj | dolphm: looks like https://review.openstack.org/#/c/6875/ needs a rebase | 22:05 |
*** andrewbogott has joined #openstack-dev | 22:05 | |
*** andrewbogott has joined #openstack-dev | 22:05 | |
*** adjohn has quit IRC | 22:06 | |
*** datsun180b has quit IRC | 22:10 | |
*** asalkeld has joined #openstack-dev | 22:12 | |
*** Dr_Who has quit IRC | 22:14 | |
*** rods has joined #openstack-dev | 22:18 | |
*** kbringard has quit IRC | 22:21 | |
*** littleidea has quit IRC | 22:23 | |
vishy | ryant: give it to me! | 22:25 |
*** dtroyer is now known as dtroyer_zzz | 22:26 | |
ryant | vishy: how do you wan it? | 22:26 |
vishy | pastie it is fine | 22:26 |
ryant | https://bugs.launchpad.net/nova/+bug/1017418 | 22:26 |
uvirtbot | Launchpad bug 1017418 in nova "NoMoreFloatingIps: Zero floating ips available after repeatedly creating and destroying instances over time" [High,Confirmed] | 22:26 |
ryant | I posted the info on launchpad | 22:27 |
*** andrewsmedina has quit IRC | 22:27 | |
mtaylor | bcwaldon: sup? | 22:28 |
*** sieutruc has quit IRC | 22:29 | |
*** Ryan_Lane1 has quit IRC | 22:29 | |
bcwaldon | mtaylor: I dont remember | 22:30 |
*** asalkeld has left #openstack-dev | 22:31 | |
mtaylor | jaypipes: give a brother a hand? https://review.openstack.org/#/c/9021/ | 22:32 |
bcwaldon | mtaylor: whats the status of the gate? | 22:32 |
mtaylor | bcwaldon: dtroyer's patch should have fixed it | 22:32 |
bcwaldon | mtaylor: thats why I'm asking | 22:33 |
bcwaldon | mtaylor: so whats the status | 22:33 |
*** adjohn has joined #openstack-dev | 22:33 | |
mtaylor | bcwaldon: well, his patch merged, so I'd say it's fixed | 22:33 |
bcwaldon | ok | 22:33 |
bcwaldon | approve all the things! | 22:33 |
mtaylor | bcwaldon: I'm trying to! | 22:33 |
mtaylor | bcwaldon: but they want me to ask other peoples : | 22:33 |
bcwaldon | mtaylor: I'll hit some stuff | 22:33 |
mtaylor | :( | 22:33 |
bcwaldon | mtaylor: pre-approval tests are passing | 22:34 |
mtaylor | w00t! | 22:35 |
mtaylor | dprince: I've got a question for you on how smokestack runs some stuff... | 22:35 |
mtaylor | dprince: http://smokestack.openstack.org/?go=/jobs/23549 | 22:35 |
vishy | mikal: not sure why your thing insn't working | 22:36 |
vishy | have you tried running the command then reloading the table? | 22:36 |
mtaylor | dprince: I added a depend into test-requires in that patch that affects the running of setup.py | 22:36 |
mtaylor | dprince: which works in the venv/tox based workflow, but not in smokestack, so I wanted to understand what's different so I can take it in to account (the smokestack failure here probably means I didn't account properly for a legit workflow) | 22:37 |
*** lloydde has joined #openstack-dev | 22:37 | |
*** ewindisch has quit IRC | 22:38 | |
*** e1mer has joined #openstack-dev | 22:39 | |
*** negronjl has quit IRC | 22:41 | |
*** negronjl has joined #openstack-dev | 22:41 | |
*** jog0 has joined #openstack-dev | 22:41 | |
*** dtroyer_zzz is now known as dtroyer | 22:43 | |
mikal | vishy: I don't know a lot about sqlalchemy... How do I reload a table? I tried deleting and recreating the table object, is that what you mean? | 22:45 |
vishy | mikal: see the email. I mean just a repeat of the instances = line from the top | 22:46 |
mikal | Ok, I will look in a sec | 22:46 |
andrewbogott | jerdfelt: I have questions about a bit of your code in test_imagecache(). Specifically, the _intercept_log_messages bit. | 22:49 |
andrewbogott | You create a new logger and then hook that, rather than hooking the logger that's used elsewhere in the file... | 22:49 |
andrewbogott | It works! but I don't understand why it works. | 22:49 |
andrewbogott | (Probably because I don't quite understand what it means to have two different loggers with two different names.) | 22:51 |
*** ewindisch has joined #openstack-dev | 22:51 | |
*** krtaylor has joined #openstack-dev | 22:54 | |
mikal | vishy: so yeah, that's exactly what I tried and it didn't help. However, putting the foreign key in a separate migration worked, but felt clunky. | 22:54 |
vishy | mikal: that is weird | 22:54 |
*** Dr_Who has joined #openstack-dev | 22:54 | |
vishy | mikal: I guess we have to do separate migrations :( | 22:55 |
mikal | vishy: ok. I _think_ that means I need three so it will work in reverse too... One to remove the old FK, one to rename the column, and then another to add the FK back. Is that going to survive review? | 22:55 |
vishy | mikal: yes i think so | 22:55 |
vishy | mikal: just put a note about why there are three | 22:56 |
mikal | Ok. I will work on that today then. | 22:56 |
*** andrewsmedina has joined #openstack-dev | 22:56 | |
vishy | mikal: awesome, thanks | 22:56 |
*** dhellmann has joined #openstack-dev | 22:57 | |
*** pixelbeat has quit IRC | 22:58 | |
ryant | vishy: I've got a theory | 23:05 |
vishy | ryant: good. I'm looking at how that could have happened | 23:05 |
vishy | it looks like somehow it must get re-associated in between the disassocate and deallocate | 23:05 |
*** sandywalsh has joined #openstack-dev | 23:07 | |
ryant | vishy: disassociate_floating_ip will make an rpc cast when not on the host that has the floating IP | 23:08 |
ryant | I assume the case is asynchronous | 23:08 |
ryant | *cast | 23:08 |
vishy | ryant: wait, it isn't a call? | 23:09 |
ryant | nope, it's a cast | 23:09 |
vishy | ryant: I have to head out, but summarize what you think and I will look at it later tonight | 23:09 |
vishy | ryant: well that sounds like the problem right there. sigh | 23:09 |
ryant | let's catch up tomorrow | 23:09 |
*** kindaopsdevy has quit IRC | 23:10 | |
ryant | vishy: I think there's a race condition, but it's not related to how quickly you terminate an instance after requesting it | 23:11 |
*** rnirmal has quit IRC | 23:13 | |
*** heckj has quit IRC | 23:13 | |
*** lloydde has quit IRC | 23:17 | |
*** Dr_Who has quit IRC | 23:18 | |
*** rods has quit IRC | 23:21 | |
*** markmcclain has joined #openstack-dev | 23:22 | |
*** sleepsonthefloor is now known as sleepsonzzz | 23:22 | |
*** edygarcia has quit IRC | 23:24 | |
*** edygarcia has joined #openstack-dev | 23:25 | |
*** lloydde has joined #openstack-dev | 23:25 | |
*** edygarcia has quit IRC | 23:29 | |
*** salv-orlando has quit IRC | 23:33 | |
*** issackelly has quit IRC | 23:34 | |
*** littleidea has joined #openstack-dev | 23:35 | |
*** mnaser has quit IRC | 23:36 | |
*** lloydde has quit IRC | 23:38 | |
*** anderstj has quit IRC | 23:38 | |
*** mnaser has joined #openstack-dev | 23:39 | |
*** agonella has joined #openstack-dev | 23:42 | |
*** dachary has quit IRC | 23:43 | |
*** dachary has joined #openstack-dev | 23:44 | |
*** blamar has joined #openstack-dev | 23:47 | |
*** kindaopsdevy has joined #openstack-dev | 23:48 | |
*** epim has quit IRC | 23:48 | |
*** ayoung has joined #openstack-dev | 23:48 | |
*** ryant has quit IRC | 23:50 | |
*** Aaton is now known as Aaton_off | 23:54 | |
*** rkukura has quit IRC | 23:55 | |
*** rkukura has joined #openstack-dev | 23:55 | |
*** kindaopsdevy has quit IRC | 23:56 | |
*** jakedahn is now known as jakedahn_zz | 23:57 | |
*** ywu has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!