Friday, 2012-06-29

*** roge has quit IRC00:01
*** edygarcia has quit IRC00:01
*** dtroyer is now known as dtroyer_zzz00:02
*** edygarcia has joined #openstack-dev00:03
*** edygarcia_ has quit IRC00:03
*** spiffxp has quit IRC00:03
*** adjohn has quit IRC00:06
*** sniperd_ has joined #openstack-dev00:07
*** sniperd has quit IRC00:07
*** edygarcia has quit IRC00:08
*** edygarcia_ has joined #openstack-dev00:12
*** rods has quit IRC00:14
*** adjohn has joined #openstack-dev00:17
*** danwent has quit IRC00:26
*** torgomatic has quit IRC00:32
*** reed has quit IRC00:40
*** ewindisch has joined #openstack-dev00:48
*** andrewbogott has quit IRC00:51
*** mnaser has quit IRC00:55
*** dolphm has joined #openstack-dev00:56
*** spiffxp has joined #openstack-dev00:56
*** dtroyer_zzz is now known as dtroyer00:56
*** dolphm has quit IRC00:57
*** mnaser has joined #openstack-dev00:57
*** dolphm has joined #openstack-dev00:58
*** reed has joined #openstack-dev01:00
*** andrewbogott has joined #openstack-dev01:09
*** andrewbogott has joined #openstack-dev01:09
*** Aaton is now known as Aaton_off01:10
*** andrewbogott has quit IRC01:11
*** renier has quit IRC01:14
*** jog0 has quit IRC01:18
*** ewindisch has quit IRC01:19
*** andrewbogott has joined #openstack-dev01:23
*** timjr has quit IRC01:24
*** andrewsben_is_a_ is now known as andrewsben01:33
*** Gordonz has joined #openstack-dev01:33
*** hugokuo has joined #openstack-dev01:39
*** markmcclain has quit IRC01:41
*** _adjohn has joined #openstack-dev01:42
*** mattstep_ has joined #openstack-dev01:44
*** chenxu_ has joined #openstack-dev01:44
*** jeblair_ has joined #openstack-dev01:45
*** z_ has joined #openstack-dev01:45
*** reed has quit IRC01:45
*** vuntz_ has joined #openstack-dev01:45
*** Gordonz has quit IRC01:45
*** PotHix has quit IRC01:45
*** adjohn has quit IRC01:45
*** mattstep has quit IRC01:45
*** jeblair has quit IRC01:45
*** matiu has quit IRC01:45
*** z has quit IRC01:45
*** akscram has quit IRC01:45
*** vuntz has quit IRC01:45
*** huats has quit IRC01:45
*** chenxu has quit IRC01:45
*** smoser has quit IRC01:45
*** _adjohn is now known as adjohn01:46
*** smoser has joined #openstack-dev01:46
*** huats has joined #openstack-dev01:46
*** huats has quit IRC01:46
*** huats has joined #openstack-dev01:46
*** matiu has joined #openstack-dev01:46
*** matiu has quit IRC01:46
*** matiu has joined #openstack-dev01:46
*** akscram has joined #openstack-dev01:47
*** PotHix has joined #openstack-dev01:47
*** anderstj has joined #openstack-dev01:50
*** issackel_ has quit IRC01:50
*** sniperd_ has quit IRC01:55
*** sniperd has joined #openstack-dev01:55
*** steveb___ has joined #openstack-dev01:57
*** PotHix has quit IRC01:59
*** gyee has joined #openstack-dev02:07
*** anderstj has quit IRC02:09
*** anniec has quit IRC02:10
*** novas0x2a|laptop has quit IRC02:11
*** jeblair_ is now known as jeblair02:13
*** Ryan_Lane1 has joined #openstack-dev02:13
*** gyee has quit IRC02:16
*** Ryan_Lane has quit IRC02:16
*** jakedahn is now known as jakedahn_zz02:16
*** yjiang5_ has joined #openstack-dev02:25
*** dtroyer is now known as dtroyer_zzz02:25
*** mnaser has quit IRC02:32
*** anderstj has joined #openstack-dev02:36
*** tserong_ is now known as tserong02:38
*** epim has quit IRC02:44
*** anderstj has quit IRC02:45
*** dolphm has quit IRC02:47
*** mnaser has joined #openstack-dev02:57
*** ayoung has joined #openstack-dev03:01
*** andrewbogott has quit IRC03:06
*** e1mer has quit IRC03:10
*** mnaser has quit IRC03:13
*** dolphm has joined #openstack-dev03:16
*** e1mer has joined #openstack-dev03:25
*** anderstj has joined #openstack-dev03:27
*** dtroyer_zzz is now known as dtroyer03:29
*** adjohn has quit IRC03:33
*** _adjohn has joined #openstack-dev03:34
*** _adjohn is now known as adjohn03:34
*** adjohn has quit IRC03:34
*** thingee has quit IRC03:36
*** dubsquared has joined #openstack-dev03:37
*** mjfork has quit IRC03:42
*** harlowja has quit IRC03:44
*** e1mer has quit IRC03:49
*** dtroyer is now known as dtroyer_zzz03:54
*** anniec has joined #openstack-dev03:56
*** dtroyer_zzz is now known as dtroyer03:56
*** dtroyer is now known as dtroyer_zzz04:01
*** epim has joined #openstack-dev04:04
*** dubsquared has quit IRC04:11
*** danwent has joined #openstack-dev04:11
*** dubsquared has joined #openstack-dev04:12
*** sleepsonthefloor is now known as sleepsonzzz04:16
*** troytoman-away is now known as troytoman04:16
*** dubsquared1 has joined #openstack-dev04:22
*** dubsquared has quit IRC04:25
*** Ryan_Lane has joined #openstack-dev04:31
*** Ryan_Lane1 has quit IRC04:31
*** andrewsben is now known as andrewsben_is_a_04:48
*** anniec has quit IRC04:48
*** dubsquared1 has quit IRC04:48
*** mnaser has joined #openstack-dev04:50
*** steveb___ has quit IRC04:54
*** mnaser has quit IRC05:07
*** ryant has quit IRC05:12
garyksalv-orlando: hi, saw your comments - good catch. fixing...05:15
*** zaitcev has quit IRC05:16
*** spiffxp has quit IRC05:19
*** e1mer has joined #openstack-dev05:23
*** e1mer has joined #openstack-dev05:23
*** anderstj has quit IRC05:37
*** sniperd_ has joined #openstack-dev05:39
*** sniperd has quit IRC05:40
*** dolphm has quit IRC05:47
*** Ryan_Lane has quit IRC05:57
*** Ryan_Lane1 has joined #openstack-dev05:57
*** asalkeld has quit IRC05:57
*** rohitk has joined #openstack-dev05:58
*** dachary has joined #openstack-dev06:01
*** vuntz_ is now known as vuntz06:11
*** dachary has quit IRC06:13
*** epim_ has joined #openstack-dev06:20
*** epim__ has joined #openstack-dev06:21
*** epim has quit IRC06:22
*** epim__ is now known as epim06:22
*** epim_ has quit IRC06:24
*** mrunge has joined #openstack-dev06:26
*** Mandell has joined #openstack-dev06:40
*** danwent has quit IRC06:50
*** dolphm has joined #openstack-dev06:57
*** dolphm has quit IRC07:01
*** hazmat has joined #openstack-dev07:09
*** hazmat has quit IRC07:09
*** hazmat has joined #openstack-dev07:09
*** reidrac has joined #openstack-dev07:11
*** dachary has joined #openstack-dev07:15
*** sdake has quit IRC07:19
*** danwent has joined #openstack-dev07:22
*** mindpixel has joined #openstack-dev07:25
*** Mandell has quit IRC07:33
*** GheRivero has joined #openstack-dev07:34
*** eglynn has joined #openstack-dev07:34
*** ijw has quit IRC07:37
*** troytoman has quit IRC07:42
*** mancdaz has joined #openstack-dev07:53
*** mancdaz has quit IRC07:59
*** mancdaz_ has joined #openstack-dev07:59
*** mancdaz_ has quit IRC08:04
*** mancdaz has joined #openstack-dev08:05
*** mancdaz_ has joined #openstack-dev08:06
*** mancdaz has quit IRC08:06
*** mancdaz_ is now known as mancdaz08:06
*** mancdaz has quit IRC08:10
*** mancdaz has joined #openstack-dev08:11
*** ijw has joined #openstack-dev08:17
*** yjiang5_ has quit IRC08:22
*** pixelbeat has joined #openstack-dev08:37
*** ijw has quit IRC08:49
*** ijw has joined #openstack-dev08:50
*** danwent has quit IRC08:52
*** ijw has quit IRC08:54
*** danpb has joined #openstack-dev09:00
*** rods has joined #openstack-dev09:31
*** maploin has joined #openstack-dev09:42
*** maploin has quit IRC09:42
*** maploin has joined #openstack-dev09:42
*** eglynn_ has joined #openstack-dev09:43
*** eglynn has quit IRC09:43
*** GheRivero has quit IRC09:44
*** apevec has joined #openstack-dev09:59
*** asalkeld has joined #openstack-dev10:06
*** ijw has joined #openstack-dev10:09
*** ijw has quit IRC10:09
*** ijw has joined #openstack-dev10:10
*** ijw has quit IRC10:18
zykes-jk0: ping ?10:20
*** asalkeld has left #openstack-dev10:36
*** Leander_ has joined #openstack-dev10:37
Leander_Hello all10:38
Leander_i'm having this weird issue with the tests10:38
Leander_more precisely "run_tests.sh"10:38
Leander_see here for a more detailed description10:39
Leander_the tests won't run because on "import libvirt"10:39
Leander_of*10:39
Leander_How do i get around this? Taking into account that in order for the code to be validated that import needs to be present10:40
*** eglynn_ has quit IRC10:48
*** tserong has quit IRC10:55
*** stuntmachine has joined #openstack-dev11:18
*** eglynn has joined #openstack-dev11:20
*** Leander_ has quit IRC11:23
*** dachary has quit IRC11:25
*** dachary1 has joined #openstack-dev11:25
*** markvoelker has joined #openstack-dev11:29
*** dachary1 has quit IRC11:33
*** dtroyer_zzz is now known as dtroyer11:37
*** Gordonz has joined #openstack-dev11:39
*** sandywalsh_ has quit IRC11:42
*** mjfork has joined #openstack-dev11:42
*** tserong has joined #openstack-dev11:43
tseronge11:43
*** Ryan_Lane1 is now known as Ryan_Lane11:51
*** Ryan_Lane has joined #openstack-dev11:51
*** e1mer has quit IRC11:51
*** e1mer has joined #openstack-dev11:52
*** mrunge has quit IRC11:55
*** dayou has joined #openstack-dev11:58
*** salgado has joined #openstack-dev12:03
*** mrunge has joined #openstack-dev12:07
*** sandywalsh has joined #openstack-dev12:09
*** alaski has joined #openstack-dev12:10
*** salgado has quit IRC12:11
*** salgado has joined #openstack-dev12:12
*** salgado has joined #openstack-dev12:12
*** Leander_ has joined #openstack-dev12:12
*** simo_ has joined #openstack-dev12:12
*** stuntmachine has quit IRC12:13
*** markmcclain has joined #openstack-dev12:15
Leander_hello all12:20
*** z_ is now known as z12:20
Leander_i'm having an issues where the tests (run_tests.sh) fails because of "import libvirt", see here https://lists.launchpad.net/openstack/msg13621.html for more details12:21
*** z has quit IRC12:21
*** z has joined #openstack-dev12:21
Leander_the problem is that in order for the code to be submitted, that import is required12:21
Leander_does anyone know how to get around that?12:21
*** dachary has joined #openstack-dev12:23
*** sandywalsh has quit IRC12:26
*** mrunge has quit IRC12:27
*** sandywalsh has joined #openstack-dev12:27
*** simo_ has quit IRC12:34
*** simo_ has joined #openstack-dev12:35
*** shang has quit IRC12:39
Davieyttx: Can i clarify that client libraries are now totally decoupled from general releases?  Ie, there won12:39
Daviey't  be a Folsom novaclient, as such?12:39
ttxDaviey: rigth. There will be a current novaclient supporting everything "so far"12:41
Davieyttx: Okay.. thanks :)  (I don't like that, but appreciate the clarity)12:41
ttxDaviey: those will get releases, but not necessarily at the same time as openstack core stuff12:41
*** Shrews has joined #openstack-dev12:42
Davieyttx: Trying to work out if we should keep 2012* in the version string to prefix the new scheme, or simply bump the epoch12:43
ttxDaviey: bump the epoch, certainly.12:44
ttxI wish we could have kept the old way, but it simply wasn't working12:45
*** roge has joined #openstack-dev12:45
Davieyttx: yeah, thanks.12:50
*** sniperd has joined #openstack-dev12:52
*** sniperd_ has quit IRC12:52
*** simo_ is now known as simo\12:58
*** simo\ is now known as simo12:58
*** simo has joined #openstack-dev12:59
*** dayou has quit IRC13:02
*** dprince has joined #openstack-dev13:03
Leander_i'd be grateful if someone could help me with this issue regarding the unit_tests https://lists.launchpad.net/openstack/msg13878.html13:05
*** sandywalsh_ has joined #openstack-dev13:08
*** ijw has joined #openstack-dev13:08
*** sandywalsh has quit IRC13:09
*** markmcclain has quit IRC13:09
*** anniec has joined #openstack-dev13:09
*** japage has joined #openstack-dev13:10
*** anniec_ has joined #openstack-dev13:10
*** mnaser has joined #openstack-dev13:13
*** edygarcia has joined #openstack-dev13:14
*** anniec has quit IRC13:14
*** anniec_ is now known as anniec13:14
*** dolphm has joined #openstack-dev13:16
*** lts has joined #openstack-dev13:16
*** ayoung has quit IRC13:16
*** adalbas has joined #openstack-dev13:17
Ryan_Laneso, I'm looking at making a change to how floating IPs work. quantum doesn't seem to have that support yet. Should I add this to nova for now?13:18
jk0zykes-: believe it or not, I'm usually not awake between the hours of 1AM-7AM13:18
*** Gordonz has quit IRC13:18
zykes-jk0: didn't remember that you're in western us ;p13:19
*** dolphm has quit IRC13:20
zykes-jk0: seen something like this yet? http://t.co/rwGKATX913:21
*** dolphm has joined #openstack-dev13:21
*** dolphm has quit IRC13:22
jk0zykes-: I've not13:22
zykes-know what the reason can be ?13:22
*** arosen has quit IRC13:22
jk0zykes-: no, I don't. like I said, this is not my code. I followed the doc and it worked great. you may need to file a bug on the github repo so the developer is aware of the issue13:24
zykes-isn't possible to file bugs on branches13:26
jk0you'll need to take that up with the developer13:26
*** fc__ has quit IRC13:26
*** ayoung has joined #openstack-dev13:26
zykes-;p13:26
*** andrewsmedina has joined #openstack-dev13:30
*** ncode has joined #openstack-dev13:31
*** mnaser has quit IRC13:34
*** wiliam has joined #openstack-dev13:35
*** dansmith has quit IRC13:36
zykes-jk0: what work is it that piston is doing for CF ?13:36
*** mnaser has joined #openstack-dev13:37
jk0zykes-: we wrote a large part of the OS CPI13:37
zykes-ok :p13:37
*** fc__ has joined #openstack-dev13:37
jk0zykes-: what work is it that you do that requires you to ping me all hours of the day, every single day of the week?13:39
*** arosen has joined #openstack-dev13:41
*** arosen has quit IRC13:41
*** dansmith has joined #openstack-dev13:42
*** arosen has joined #openstack-dev13:43
*** rnirmal has joined #openstack-dev13:43
*** apevec has quit IRC13:47
zykes-jk0: trying to get it to work ;p13:48
zykes-but I guess i'll check with ferdy instead13:48
*** anderstj has joined #openstack-dev13:49
*** Dr_Who has joined #openstack-dev13:51
*** Dr_Who has quit IRC13:51
*** Dr_Who has joined #openstack-dev13:51
jk0zykes-: good call, since it's his code, that is what I would do too13:51
zykes-;p13:51
zykes-jk0: is there anyone I can ping to get access to piston os ?13:52
*** jgriffith_ has quit IRC13:52
mnasergrawr13:52
jk0zykes-: you can fill out this form: http://www.pistoncloud.com/contact/ and someone will get in touch with you13:52
mnaserxenserver + openstack deployment is so cryptic :p13:52
*** andrewbogott has joined #openstack-dev13:53
mnaseresp with vlan networking13:53
*** jgriffith_ has joined #openstack-dev13:54
andrewbogottmikal:  Does my response regarding import order on 8729 make sense, or are we talking past each other?13:54
*** sdake has joined #openstack-dev13:57
*** sdake has quit IRC13:57
*** dachary has quit IRC13:58
*** sdake has joined #openstack-dev13:58
*** timello has quit IRC13:58
*** jgriffith_ has quit IRC13:59
*** timello has joined #openstack-dev13:59
*** jgriffith_ has joined #openstack-dev13:59
VekI need another nova core +2 for https://review.openstack.org/#/c/8963/...any takers?14:00
andrewbogottHm... turns out if you write a patch that touches every single file in nova, you spend the rest of your life rebasing and resolving conflicts. Who would've thought?14:03
*** cryptographrix has quit IRC14:07
*** GheRivero has joined #openstack-dev14:09
*** cryptographrix has joined #openstack-dev14:09
*** sniperd has quit IRC14:09
*** sniperd has joined #openstack-dev14:10
Leander_i'd be grateful if someone could help me with this issue regarding the unit_tests https://lists.launchpad.net/openstack/msg13878.html14:11
*** jaypipes has quit IRC14:13
*** dtroyer is now known as dtroyer_zzz14:16
*** sniperd_ has joined #openstack-dev14:18
*** sniperd has quit IRC14:18
*** edygarcia has quit IRC14:20
*** sstent has joined #openstack-dev14:20
*** dolphm has joined #openstack-dev14:24
Leander_i'd be grateful if someone could help me with this issue regarding the unit_tests https://lists.launchpad.net/openstack/msg13878.html14:28
Leander_i can't get it to work14:29
*** simo has left #openstack-dev14:29
Leander_there aren't any errors to trace14:29
Leander_:S14:29
*** sdake has quit IRC14:31
*** sdake has joined #openstack-dev14:32
*** jaypipes has joined #openstack-dev14:32
*** sniperd_ has quit IRC14:34
*** sniperd has joined #openstack-dev14:34
*** nunosantos has joined #openstack-dev14:35
*** zigo has joined #openstack-dev14:36
*** dachary has joined #openstack-dev14:37
Leander_i'd be grateful if someone could help me with this issue regarding the unit_tests https://lists.launchpad.net/openstack/msg13878.html - i can only run the tests calling nosetest directly14:37
Leander_can anyone tell me why this is happening: http://paste.openstack.org/show/19041/ ?14:42
*** sandywalsh_ has quit IRC14:45
andrewbogottLeander_:  That means that scheduler_host_manager is getting defined in two different places... the cfg module hates that.14:47
andrewbogottLeander_:  Do you have a patch in progress that's producing that failure?14:47
Leander_andrewbogott: you can get the patch from here https://review.openstack.org/#/c/8839/7/nova/virt/libvirt/diagnostics.py, you just need to add "import livbvirt" to nova/virt/libvirt/diagnostics.py14:49
Leander_andrewbogott: the ouput is produced by running "tools/with_venv.sh nosetests"14:50
*** renier has joined #openstack-dev14:50
andrewbogottAre you declaring scheduler_host_manager in your test file?14:50
*** dtroyer_zzz is now known as dtroyer14:51
Leander_no14:51
andrewbogottok, give me a moment...14:51
*** salv-orlando has joined #openstack-dev14:51
*** spiffxp has joined #openstack-dev14:53
*** rkukura has joined #openstack-dev14:54
andrewbogottLeander_:  ./run_tests.sh test_virt_drivers fails for me even before I apply your patch.  Not true for you?14:56
*** Leander__ has joined #openstack-dev14:56
*** datsun180b has joined #openstack-dev14:56
Leander__andrewbogott: did i miss anything, connection dropped :s14:56
danpbandrewbogott: you need   ./run_tests.sh  tests.nova.test_virt_drivers14:56
mnaserThis is pretty silly.  If i can have only 1 network labeled 'public' and one network labeled 'private'.  Does that mean I cannot have more than one possible subnets for public IP addresses?  For example, if I add a /24 in network called public and I run out and I'd like to add more, do I have to create public-2 .. ?14:56
*** sdake has quit IRC14:57
mnaserAnd won't that create extra IPs for each instance created, so i'll start getting instances with an IP from private, public and public-2 ?14:57
andrewbogottLeander_:  same thing.14:57
andrewbogottI mean, 'that command is the same'14:57
*** edygarcia has joined #openstack-dev14:57
danpbopps, i mean   ./run_tests.sh  nova.tests.test_virt_drivers14:58
*** anderstj has quit IRC14:58
*** Leander_ has quit IRC14:58
Leander__andrewbogott: i can't get the "run_tests.sh" to work properly, i can only run it with calling nosetests14:58
Leander__danpb: i get this error: Failure: AttributeError ('module' object has no attribute 'test_virt_drivers')14:59
*** maploin has quit IRC15:00
andrewbogottdanpb:  When you use ./run_tests, the nova/tests directory is implicit.  Your command doesn't work because it looks for a test in nov/tests/nova/tests/etc.15:00
andrewbogottLeander__:  Please tell me what actual command you are running and where you are running it.15:00
Leander__andrewbogott: i was running "./run_tests.sh nova.tests.test_virt_drivers"15:01
danpbandrewbogott: not any more it isn't - with current nova git master, you need to fully qualify the python package for the test15:01
andrewbogott?15:01
andrewbogottI'm running git master and not seeing that.15:01
andrewbogottI mean, I trust you!  But my eyes lie.15:01
Leander__andrewboggott: now i ran "./run_tests.sh test_virt_drivers" and i got this15:01
Leander__http://paste.openstack.org/show/19043/15:02
Leander__it works fine on the master15:02
Leander__but i'm on my branch it does not15:02
mnasergit diff?15:02
andrewbogottLeander__:  I am confused by you asserting that you are only using 'nosetests' but then the commandlines you are pasting use 'run_tests'.15:04
*** drewlander has joined #openstack-dev15:04
Leander__andrewbogott: when i use run_tests.sh, nothing happens. it reports 0 tests ran. If call nosetests directly, every test runs15:05
andrewbogottIf nothing happens when you do run_tests, it most likely means that you're encountering an import error in one of the test files.  The best way to debug that is to run individual tests, in which case run_tests gives you better debugging info.15:05
Leander__mnaser: here's a diff http://paste.openstack.org/show/19046/15:06
Leander__andrewbogott: here's the diff http://paste.openstack.org/show/19046/ and the output from "./run_tests.sh test_virt_drivers" http://paste.openstack.org/show/19043/15:06
*** fitzdsl has joined #openstack-dev15:07
*** blamar has quit IRC15:07
andrewbogottLeander_:  What happens if you just do "python -c 'import libvirt'"?15:08
andrewbogottDoes that work?15:08
Leander__yes15:08
Leander__no problems15:08
Leander__if done that about a million times15:08
Leander__>.<15:08
andrewbogottDoes ./run_tests.sh test_virt_drivers work properly on a branch w/out your changes?15:08
Leander__everything runs fine on the master15:08
Leander__branch15:08
andrewbogottnot for me :(15:08
Leander__unless there have been certain updates recently15:09
Leander__:s15:09
andrewbogottI guess that means my system is useless for reproducing your problem :(15:09
*** sdake has joined #openstack-dev15:09
fitzdslHello, I would like to know if there is any documentation about how to create a new kind of hypervisors ? I would like that some of our dev evaluate time to support oVirt project on OpenStack15:09
fitzdslfor nova I mean15:10
Leander__andrewbogott: dam :(, i've been stuck here for the last two days. can't get the code to be accept without solving it15:10
Leander__the code runs just fine with the production code15:11
andrewbogottLeander__:  Sorry, this is another condescending question, but:  Is it possible there are changes local to your tree that aren't in the submitted patch?  Have you tried moving to a clean branch and cherry-picking your own patch?15:11
Leander__iv'e tested it wit devstack15:11
andrewbogottMaybe you're using devstack differently from me... when I run a devstack test it's still using my existing code tree.  So any cruft that's messing up my unit tests is present for devstack as wel.15:12
Leander__i have one nova-repo where it submitt my code15:13
Leander__from15:13
Leander__and i have a devstack installation elsewher15:13
Leander__where i put my changes15:13
Leander__everything works there15:14
andrewbogottah, ok.15:14
andrewbogott'everything works' but I presume the unit tests fail in the same way on the devstack box.15:14
Leander__i've only run the unittest from the other repo where i submitted the code from15:15
andrewbogottHm, I just completed a full 'run_tests' in a tree with your patch and the additional import, and everything passed.15:15
Leander__O.o15:16
andrewbogottWeird that the full suite passes but the individual tests don't15:16
Leander__did all the tests pass without errors?15:16
andrewbogottIf I do ./run_tests.sh test_virt_drivers then every single test errors out with 'No module named fake_imagebackend'15:16
andrewbogottYeah, with a complete 'run_tests' everything passed.  5 skips though, probably it's skipping your tests for some reason.15:17
*** epim has quit IRC15:17
Leander__usually i have 5 skips as well15:17
Leander__and it's not my test15:17
Leander__i've checked for that15:17
Leander__something about snapshots15:17
* andrewbogott shrugs broadly15:17
*** mnaser has quit IRC15:17
andrewbogottWhen I look at the code that's throwing 'No module named fake_imagebackend' there's an absolute import of a library in 'test' so it doesn't surprise me that it can't be found.15:18
Leander__well, i'm gonna submit the patch with the import and see if jenkins can run it15:18
andrewbogottWorth a try :)15:18
Leander__maybe it somehting on my end15:18
Leander__:s15:18
andrewbogottIf it does then I guess we know that both of our systems are broken in different, interesting ways :/15:19
Leander__i am getting desperate though >.<15:19
*** mnaser has joined #openstack-dev15:21
sdaguerussellb: are you working at landing the openstack-common rpc changes?15:23
Leander__andrewbogott: what's your setup btw?15:25
andrewbogottsdague:  As far as I can see, they've already landed... in nova at least.15:25
mnaserIs there a specific channel for Melange?15:25
*** blamar has joined #openstack-dev15:26
andrewbogottLeander__:  oneiric15:26
andrewbogottserver15:26
Leander__i'm running ubuntu 12.04 server15:26
sdagueandrewbogott: hmmm... if I do a common refresh to nova, a lot of content comes over15:27
sdagueand I just wanted to bring in the new import utils, as that's what I need15:27
andrewbogottsdague:  I'm in the midst of doing a bunch of migration, and conflicts are DRIVING ME CRAZY, so would appreciate if you can wait a day or two before submitting anything like that :)15:27
andrewbogottsdague:  This patch will probably do what you want, among other things:  https://review.openstack.org/#/c/9047/15:28
andrewbogott(which, btw, upvotes much appreciated!)15:28
sdagueandrewbogott: ok, well my +1 is on that15:31
sdagueI understand the rebase frustration, try changing something in the libvirt driver some time :)15:31
andrewbogottsdague:  Thanks!  The next patch in that chain (8728) touches every single file in nova.  Keeping it current is pretty much all I do now.15:32
*** e1mer has quit IRC15:33
*** mancdaz has left #openstack-dev15:33
*** sandywalsh has joined #openstack-dev15:34
sdagueandrewbogott: can you take it in chunks (like per directory?)15:34
sdaguethen at least pieces of it should land15:34
andrewbogottsdague:  Maybe.  So far I haven't gotten complaints about it being too big to review, so I'm still hoping that it'll just get pushed through in a hurry.15:35
andrewbogottIt seems 'proper' to do it in one patch since it requires new files from common and removes files from nova.15:35
*** salgado is now known as salgado-lunch15:37
*** ijw has quit IRC15:38
Leander__andrewbogott: jenkins failed :(  > https://jenkins.openstack.org/job/gate-nova-python26/1333/testReport/%3Cnose.suite/ContextSuite%20context=nova/tests__setup/15:38
andrewbogottsdague:  But, that's a good backup plan if I continue to be thwarted.15:38
sdagueandrewbogott: I don't see any reviews on it so far.15:38
*** _mancdaz has joined #openstack-dev15:38
andrewbogottsdague:  It was marked 'work in progress' until recently.15:38
sdagueI'm looking at the logging switch, why does it change a file in nova/openstack/common15:38
sdagueandrewbogott: gotcha15:38
andrewbogottsdague:  What do you mean, re: nova/openstack/common?15:39
sdaguehttps://review.openstack.org/#/c/8728/9/nova/openstack/common/log.py15:39
andrewbogottYou mean, why does it add it?15:39
sdagueyes15:39
sdaguewhy didn't that land with the previous patch that was the sync15:40
andrewbogottIf you look in the history of that patch, someone had an objection to adding log.py in a patch that doesn't explicitly use it.15:40
sdagueok15:40
andrewbogottUm... the history of the sync patch, I mean.15:40
andrewbogottSo, yes, originally my sync patch added all the new files I needed, but *shrug*15:40
andrewbogottjerdfelt:  Thank you for the review on 9047!  It would bring me great joy if you could also review 8728 and 8729 (even though they are enormous.)15:42
sdagueandrewbogott: so I think my landing of one file from openstack-common won't hurt you, because it will be the same change15:42
andrewbogotttrue.15:42
andrewbogottMy only worry is that if it causes a merge conflict, resolving that will cause me to lose my review history in the entire patch set, etc. etc.15:43
andrewbogottYou can just cherry-pick my pending patch and include it in your patchset, right?15:43
sdagueandrewbogott: you can rebase15:43
sdagueand git --amend15:43
*** markmcclain has joined #openstack-dev15:43
andrewbogottUm... isn't that what I just said? :)15:43
sdagueandrewbogott: right, but that doesn't loose the review history15:44
andrewbogottYou don't lose the history but you lose all your +points15:44
sdagueyes15:44
andrewbogottwhich delays the process, which increases the chances of new conflicts creeping in in the meantime15:44
sdaguebut if people +1 before, you can brow beat them into doing it again on just a rebase :)15:44
*** mnaser has quit IRC15:44
andrewbogottI am chronically surprised when git-review replaces an unchanged patch just because it's part of a patchset in which other patches changed.15:45
sdagueis that because the hash changes?15:45
sdaguea rebase will change the hash, regardless, because the parent changed15:46
andrewbogottPresumably... I haven't done a controlled test to see what's happening.15:46
andrewbogottIt probably has good reasons, but it still always surprises me.15:46
andrewbogottSure, but gerrit and/or git-review could be smart and see that the content of the patch is identical and not invalidate votes.... couldn't it?15:47
*** mnaser has joined #openstack-dev15:47
sdagueandrewbogott: maybe. worth filing a bug against them probably15:47
andrewbogottI guess I'll do that while I'm waiting for my patches to be invalidated.15:47
andrewbogottsdague:  Behold!  http://code.google.com/p/gerrit/issues/detail?id=71&q=identical&colspec=ID%20Type%20Stars%20Milestone%20Status%20Priority%20Owner%20Summary15:49
andrewbogottSomeone is ahead of me15:49
sdagueandrewbogott: cool15:51
*** jaypipes has quit IRC15:51
sdagueok, time for my own multi patch series, and see how it works in gerrit (been doing single patches previously)15:51
*** sniperd_ has joined #openstack-dev15:55
*** sniperd has quit IRC15:55
*** mnaser has quit IRC15:58
*** dachary has quit IRC15:58
*** kbringard has joined #openstack-dev16:00
*** mnaser has joined #openstack-dev16:00
*** ryant has joined #openstack-dev16:01
Leander__does anyone know how i am supposed to fix this?  https://jenkins.openstack.org/job/gate-nova-python26/1333/testReport/%3Cnose.suite/ContextSuite%20context=nova/tests__setup/16:02
*** sniperd_ has quit IRC16:03
*** sniperd has joined #openstack-dev16:04
*** mindpixel has quit IRC16:04
*** reidrac has quit IRC16:05
*** sleepsonzzz is now known as sleepsonthefloor16:07
trapnidoes OpenStack (w/ KVM) support vhost_net by default? i.e. it passes the vhost=on kvm parameter if the vhost_net hypervisor kernel module is loaded?16:08
*** mnaser has quit IRC16:09
trapnito answer the question myself, yes, it does. because it is the job of libvirt to actually do this (as it seems. just tested it)16:10
*** Leander__ has quit IRC16:10
*** mnaser has joined #openstack-dev16:12
danpbtrapni: libvirt will automatically enable it without needing to be told by OpenStack16:12
*** iccha has joined #openstack-dev16:12
*** dtroyer is now known as dtroyer_zzz16:12
*** sniperd has quit IRC16:13
jk0can I get one more core to look at https://review.openstack.org/#/c/9005/ ?16:15
*** iccha has left #openstack-dev16:15
*** mattray has joined #openstack-dev16:21
*** issackelly has joined #openstack-dev16:24
ryantvishy: what is the status of https://review.openstack.org/#/c/9041/ ?16:25
*** iccha1 has joined #openstack-dev16:25
*** iccha1 has left #openstack-dev16:26
*** issackelly has quit IRC16:26
*** reed has joined #openstack-dev16:28
*** mnaser has quit IRC16:28
*** Mandell has joined #openstack-dev16:29
*** rohitk has quit IRC16:29
*** AlanClark has joined #openstack-dev16:30
*** issackelly has joined #openstack-dev16:30
*** iccha has joined #openstack-dev16:30
*** mnaser has joined #openstack-dev16:31
*** dwalleck has joined #openstack-dev16:35
*** rnirmal has quit IRC16:36
*** sniperd has joined #openstack-dev16:37
*** dwalleck has quit IRC16:38
*** danwent has joined #openstack-dev16:39
*** japage has quit IRC16:39
*** japage has joined #openstack-dev16:39
*** Mandell has quit IRC16:40
*** danpb has quit IRC16:40
*** kindaopsdevy has joined #openstack-dev16:50
*** dwalleck has joined #openstack-dev16:51
*** mestery_ has joined #openstack-dev16:51
*** mestery has quit IRC16:53
*** iccha1 has joined #openstack-dev16:53
*** iccha has quit IRC16:54
*** Aaton_off is now known as Aaton16:55
*** mnaser has quit IRC16:56
eglynnvishy: this looks like a high-ish priority bug https://bugs.launchpad.net/nova/+bug/101933416:56
uvirtbotLaunchpad bug 1019334 in nova "boot-from-volume broken by foreign key constraints" [Undecided,New]16:56
eglynnvishy: simple fix though https://review.openstack.org/917716:56
eglynn(prolly an idea to get a quick turn-around on the review, as boot-from-vol completely broken AFAICS)16:57
*** andrewsben_is_a_ is now known as andrewsben16:59
*** mnaser has joined #openstack-dev16:59
*** dwalleck has quit IRC17:03
mnaserahem, one can only have 1 network per tenant/project...?17:04
*** anderstj has joined #openstack-dev17:06
*** issackelly has quit IRC17:06
*** harlowja has joined #openstack-dev17:07
*** fc__ has quit IRC17:07
*** issackelly has joined #openstack-dev17:07
*** dtroyer_zzz is now known as dtroyer17:08
*** epim has joined #openstack-dev17:08
*** sniperd_ has joined #openstack-dev17:09
*** apevec has joined #openstack-dev17:09
*** sniperd has quit IRC17:09
*** sniperd has joined #openstack-dev17:12
dansmith_0x44: around?17:12
*** harlowja has left #openstack-dev17:13
*** mnaser has quit IRC17:13
_0x44dansmith: Indeed.17:13
VekI need another nova core +2 for https://review.openstack.org/#/c/8963/...any takers?17:13
dansmith_0x44: I'm not seeing any other libvirt tests (other than fakelibvirt ones) that work with defined domains.. am I wrong?17:13
*** sniperd__ has joined #openstack-dev17:14
*** sleepsonthefloor is now known as sleepsonzzz17:14
*** sniperd_ has quit IRC17:15
_0x44Vek: Did so.17:15
*** sniperd_ has joined #openstack-dev17:15
*** mnaser has joined #openstack-dev17:16
_0x44dansmith: It looks like you're right, but that's a fix for a bug and therefore needs a test to ensure that there's not a future regression.17:17
*** andrewbogott has quit IRC17:17
*** sniperd has quit IRC17:17
dansmith_0x44: agreed, but isn't this a case of "open a bug for 'libvirt needs some real tests'" instead of gating a fix directly?17:17
dansmith'cause adding some defineXML tests are going to need to be careful about doing so based on list list of libvirt-supported connections on a given machine, etc17:18
dansmithwhich might end up being a little larger and more infrastructure than probably makes sense to attach to a small patch such as this (IMHO)17:18
*** sniperd__ has quit IRC17:19
_0x44dansmith: It doesn't have to be a unit-test, just add a functional test to tempest with a reference back to this commit.17:19
dansmithsince danpb isn't around, I could file said bug and assign it to him while he isn't looking :P17:19
*** torgomatic has joined #openstack-dev17:19
_0x44dansmith: I agree that making defineXML tests are larger scope17:19
*** harlowja has joined #openstack-dev17:19
dansmith_0x44: ah, okay17:20
dansmithguess I'll have to learn about tempest now, huh? :)17:20
_0x44Sorry, I'm a mean person.17:21
dansmithdamn you making me learn! :)17:22
dansmith...and on a friday too..17:22
_0x44Well you could do it on the weekend instead.17:22
dansmithmmm, or not :D17:24
*** salgado-lunch is now known as salgado17:24
*** ewindisch has joined #openstack-dev17:26
*** lts has quit IRC17:26
*** dtroyer is now known as dtroyer_zzz17:31
*** blufor has joined #openstack-dev17:33
*** Ryan_Lane has quit IRC17:34
*** Ryan_Lane1 has joined #openstack-dev17:35
*** aclark_ has joined #openstack-dev17:36
*** AlanClark has quit IRC17:36
*** jaypipes has joined #openstack-dev17:37
*** dtroyer_zzz is now known as dtroyer17:40
Ryan_Lane1I'm trying to add some extra flags to nova.conf in devstack, and am failing miserably17:40
Ryan_Lane1is there any documentation on doing so?17:40
*** Ryan_Lane1 is now known as Ryan_Lane17:40
*** Ryan_Lane has joined #openstack-dev17:40
Ryan_Lanescript says to add the flags via environment, but it isn't working for me: EXTRA_OPTS=(foo=true bar=2)17:41
dtroyerRyan_Lane: here's how I've been doing it:17:45
dtroyerEXTRA_OPTS=default_log_levels=sqlalchemy=WARN,boto=WARN,eventlet.wsgi.server=WARN17:45
Ryan_Lanewhat if you need to provide a value that's a list?17:46
dtroyerthat specific one is a list…  everything after EXTRA_OPTS= gets dropped into nova.conf as is17:48
Ryan_Lanewhat if you need to put in multiple options?17:48
Ryan_Laneuse \n?17:48
*** lcheng has quit IRC17:50
dtroyerlike the example in stack.sh, separate them by spaces17:50
Ryan_Lanethe example in stack.sh says it's an array17:50
*** andrewbogott has joined #openstack-dev17:51
Ryan_Laneusing a space doesn't seem to work, either17:51
Ryan_Laneit adds the first item and ignores the rest17:52
dtroyercan you show me the relevant section of stack.sh.log?17:52
Ryan_Lanesec17:53
*** GheRivero has quit IRC17:53
Ryan_Lanewhere does it write this log?17:55
andrewbogottcore nova devs, I have three patches (and one disagreement about17:55
andrewbogottalphabetizing) that need attention:  https://review.openstack.org/#/c/8728/ https://review.openstack.org/#/c/8729/ https://review.openstack.org/#/c/9047/17:55
*** PotHix has joined #openstack-dev17:55
dtroyerwherever you have LOGFILE set, otherwise just to the screen17:56
Ryan_Laneah ok17:56
Ryan_Lanedtroyer: http://pastebin.com/tqUXThf417:57
Ryan_Laneit indeed assumes an array17:58
dtroyerRyan_Lane: and the EXTRA_OPTS line?17:58
Ryan_LaneEXTRA_OPTS="use_bgp=True bgp_peer_addresses=192.168.178.1,192.168.178.2 bgp_local_as=56000 bgp_peer_as=56000" ./stack.sh17:58
dtroyeryou're missing the () around the EXTRA_OPTS value17:59
* Ryan_Lane nods17:59
Ryan_LaneI've tried that too17:59
Ryan_Lanelike so: EXTRA_OPTS=( use_bgp=True bgp_peer_addresses=192.168.178.1,192.168.178.2 bgp_local_as=56000 bgp_peer_as=56000 ) ./stack.sh17:59
Ryan_Lane?17:59
dtroyeryes, except I've never tried it on the command line…will need quotes18:00
Ryan_Laneneeds quotes in which way18:00
Ryan_Lane?18:00
Ryan_Lanethis is such a shitty way to add extra options :(18:00
dtroyerit would usually go into localrc18:00
*** danpb has joined #openstack-dev18:01
*** jtran has joined #openstack-dev18:01
*** danpb has quit IRC18:01
Ryan_Lanescrew it, I'm just hacking stack.sh18:01
dtroyeryeah, it doesn't work on the command line like that…put that in localrc and it will work18:03
*** rnirmal has joined #openstack-dev18:03
dolphmmtaylor: keystone master is pretty much pep8 1.3 compliant -- any reason to stick to 1.1?18:04
*** jog0 has joined #openstack-dev18:06
mtaylordolphm: nope18:06
mtaylordolphm: we've been letting projects pick which one they want to pin to because it's been changing so rapidly18:07
*** sniperd has joined #openstack-dev18:07
*** sniperd_ has quit IRC18:08
jaypipesdavidkranz: ping18:09
davidkranzjaypipes: Yo.18:09
jaypipesdavidkranz: got time for a quick videochat?18:10
jaypipesdavidkranz: it's about this: https://review.openstack.org/#/c/8801/2/tempest/tests/compute/test_security_groups.py18:10
jaypipesdavidkranz: driving me nutz.18:10
jaypipesdavidkranz: specifically that it adds four tests, creates four servers, and the whole thing could be done in a single test method and one server.18:10
jaypipesdavidkranz: but instead takes more than a minute to complete.18:10
jaypipesdavidkranz: and I don't quite know how to break it to them18:11
davidkranzjaypipes: Let me look...18:11
davidkranzjaypipes: I can chat but phone would be easier right now 339-222-275418:12
jaypipesdavidkranz: cool, calling.18:12
*** renier has quit IRC18:20
*** timjr has joined #openstack-dev18:21
*** eglynn_ has joined #openstack-dev18:21
*** eglynn has quit IRC18:22
*** mnaser has quit IRC18:23
*** lcheng has joined #openstack-dev18:25
*** thingee has joined #openstack-dev18:26
*** mnaser has joined #openstack-dev18:26
jog0vishy: ping18:27
vishyjog0: pong18:28
*** timjr has quit IRC18:29
jog0vishy: hoping to get some feedback on aggregates https://review.openstack.org/#/c/8732/  As I will be AFK all next week18:31
*** timjr has joined #openstack-dev18:37
*** mnaser has quit IRC18:38
*** mnaser has joined #openstack-dev18:41
*** apevec has quit IRC18:43
ayoungdolphm, so I think I answered the last of your questions...but then I realized something18:43
ayoungI was building paths using string concat18:43
ayoungand I should be doing os.path.join.  I'm going to resubmit it with that18:44
*** sniperd has quit IRC18:44
dolphmayoung: nice catch18:57
*** mnaser has quit IRC18:58
*** mnaser has joined #openstack-dev19:01
*** renier has joined #openstack-dev19:01
*** renier has quit IRC19:05
*** andrewsmedina has quit IRC19:08
*** renier has joined #openstack-dev19:10
*** matwood has joined #openstack-dev19:12
mnaservishy: are you familiar with openstack+xenserver setups?19:17
mnaserit seems like the iptables rules are not updated when using add-fixed-ip with essex (i noticed they run on startup and shutdown) but nothing seems to trigger it when new ips are added/removed19:19
ayoungdolphm, I missed a couple in the test, too.  Since I had the transient failuer,  I was looking for an excuse to upload a new patch.19:20
*** zaitcev has joined #openstack-dev19:22
jaypipesdavidkranz: http://paste.openstack.org/show/19061/19:23
davidkranzjaypipes: Heh :)19:23
davidkranzjaypipes: Sending you an email.19:24
jaypipesdavidkranz: email to QA list about the above sent.19:28
*** krtaylor has quit IRC19:33
*** dubsquared has joined #openstack-dev19:35
*** mnaser has quit IRC19:36
*** Ryan_Lane1 has joined #openstack-dev19:37
*** Ryan_Lane has quit IRC19:37
*** rpedde is now known as rpedde_away19:38
*** mnaser has joined #openstack-dev19:39
mtaylorbhuvan: hey! a) sorry about that mailmap regression, but b) we should really get mailmap parsing consistent everywhere :)19:40
*** Ryan_Lane1 is now known as Ryan_Lane19:41
*** Ryan_Lane has joined #openstack-dev19:41
andrewbogottCan someone retrigger this and/or tell me how to retrigger?  https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6893/consoleFull19:47
ayoungjaypipes, was that speed up due to SQLite on Ext4 vs in memory?19:49
Shrewsandrewbogott: just amend your commit message slightly and 'git review' again.19:51
andrewbogottShrews:  Isn't there a way to do it via the web console?  I fear that amending will nudge the whole patchset.19:51
Shrewsandrewbogott: i'm not aware of a way19:52
*** dachary has joined #openstack-dev19:53
*** rods has quit IRC19:54
mtaylorbcwaldon: WOOHOO!19:54
*** adjohn has joined #openstack-dev19:55
mtaylorbcwaldon: jenkins auto upload on client library tag works!19:55
andrewbogottShrews:  Some lucky devs have a 'retrigger' link on the web page.  I've never been clear on who or why.19:55
harlowjathe retriggering is a pain in the butt :-/19:56
andrewbogottharlowja:  Could you be more specific?19:56
harlowjawell i just don't think everyone has that link right19:56
mtaylorandrewbogott: nope. that link is all gone19:56
mtaylorif you want a retrigger, just re-approve the change19:57
andrewbogottOh, so now no one can retrigger?19:57
harlowjaya, dev friend has been like doing like comment changes just to get it to retrigger19:57
andrewbogottdamn.  OK.19:57
harlowjaah19:57
harlowjagood to know19:57
andrewbogottWhen you say 're-approve the change'19:57
andrewbogottI don't know what that means.  I don't have an 'approve' button not being a core dev in the project in question...19:58
mtaylorjust click "review" then make sure +1 approve is selected, then click "publish comments" - and it will re-generate the approval event19:58
mtaylorah - what's the change?19:58
andrewbogottmtaylor:  https://review.openstack.org/#/c/9047/19:58
sdaguemtaylor: this is the rackspace mirror fail on the devstack gate19:59
mtaylorandrewbogott: ah. pre-approval checks19:59
*** drewlander has quit IRC19:59
*** wiliam has quit IRC19:59
andrewbogottmtaylor:  Which, btw, if you wanted to go ahead and +2 that patch I wouldn't complain :)  It already had a +2 and a +1, which I invalidated to fix a single-letter typo in the commit comment.19:59
*** andrewsmedina has joined #openstack-dev20:00
andrewbogott(Which Jenkins rejected due to a Jenkins bug, which filled my heart with pain and regret)20:00
*** anderstj has quit IRC20:01
mtaylorwe're working on tooling for an easier way to re-trigger those ... for now, easiest way is to upload a modified patch20:05
mtaylorandrewbogott: lemme look...20:05
andrewbogottthx20:06
sdaguemtaylor: yeh, the problem there is that it invalidates the upvotes.20:07
*** markvoelker has quit IRC20:09
Ryan_Laneif I need to have an admin_context in a function that has a context passed in, how do I go about that?20:09
*** milner has quit IRC20:09
*** edygarcia has quit IRC20:09
davidkranzjaypipes: What is holding up getting the parallel submit in?20:12
*** anderstj has joined #openstack-dev20:12
*** japage has quit IRC20:12
andrewbogottRyan_Lane:  You mean you want to enforce that the request has admin privs?20:14
Ryan_Laneyeah. I figured it out though20:14
Ryan_Lanecontext.elevated()20:14
Ryan_LaneUnauthorized command: DAEMONIZE=true PID=/opt/stack/nova/networks/nova-bgp.pid exabgp /opt/stack/nova/networks/nova-bgp.conf :(20:16
Ryan_Lanestill not doing that correctly, it seems20:16
andrewbogottYou are trying to add admin privs, or just validate that they are present?20:17
*** troytoman-away has joined #openstack-dev20:17
Ryan_Lanea certain call needs admin privs20:17
Ryan_Lanedb.floating_ip_get_all_by_host(context, host)20:18
*** troytoman-away is now known as troytoman20:18
Ryan_LaneI have the context stuff down20:18
Ryan_Lanenow I just need to get root-wrap working20:18
Ryan_Laneah20:19
Ryan_LaneI need to write a custom filter20:19
mtaylorsdague: well... that's a feature, not a bug :)20:21
*** novas0x2a|laptop has joined #openstack-dev20:21
*** mnaser has quit IRC20:21
mtaylorsdague: but it does make re-uploading trivial punctuation fixes more onerous20:21
*** eglynn_ has quit IRC20:22
*** edygarcia has joined #openstack-dev20:22
*** eglynn_ has joined #openstack-dev20:22
*** mnaser has joined #openstack-dev20:23
andrewbogottmtaylor:  If you're working on a patchset, then upvotes are invalidated even if the patch has not changed /at all/.20:24
dansmithenabling tempest's ssh support gives me a KeyError here:20:24
dansmith addresses = server['addresses'][network]20:24
dansmith(a KeyError on 'addresses')20:24
dansmithany suggestions?20:24
dansmithI have network_for_ssh set to 'private' and the server has a reachable private IP, but server['addresses'] isn't there20:25
mtaylorandrewbogott: well, you can't upload a new patch if it hasn't changed at all - but you're right, a "patch" to gerrit is base rev + patch + commit message, so changes to any of them are treated as a new patch regardless of patch change itself.20:26
mtaylorandrewbogott: we have a bug open to investigate a backend hook for gerrit call the trivial rebase hook20:26
*** anderstj has quit IRC20:26
mtaylorandrewbogott: which attemps to detect trivial rebase changes - like, ones in which hte patch didn't really change or changed only as a result of a rebase20:27
mtaylorand in those cases re-apply the votes from the previous versoin20:27
mtaylorandrewbogott: all that to say 0- I feel your pain and we'd like to fix it20:27
andrewbogottmtaylor:  You're talking about this?  http://code.google.com/p/gerrit/issues/detail?id=7120:27
mtaylorandrewbogott: yup20:28
mtaylorandrewbogott: also, https://bugs.launchpad.net/openstack-ci/+bug/88118420:28
uvirtbotLaunchpad bug 881184 in openstack-ci "consider trivial rebase hook for gerrit" [Medium,Triaged]20:28
*** zigo has quit IRC20:28
andrewbogottThat would help, but there should also be a way to manually resubmit to Jenkins w/out having to modify a patch.  (I just changed the wording of a commit message in order to hack around a Jenkins failure... definitely the stupidest thing I've done so far today.)20:29
*** adalbas has quit IRC20:29
* andrewbogott fears that his patches may never drop, since (speed of new rebase conflicts + speed of jenkins failures) > speed of review :(20:31
*** dubsquared has quit IRC20:32
mtaylorandrewbogott: I agree with you20:35
mtaylorandrewbogott: and that is also in work20:35
mtaylorandrewbogott: we've been riding the fence on it a little bit, because easy re-submit allows people to ignore real bugs that show up as race conditions or intermittent bugs by just resubmitting until the race condition happens to pass20:36
mtaylorandrewbogott: BUT - when the failure is something like you hit, it's really f-ing annoying20:36
* andrewbogott nods20:37
andrewbogottmtaylor:  The real solution is, of course, Perfect Jenkins :)20:37
mtaylorandrewbogott: we're trying :)20:37
*** dprince has quit IRC20:38
*** dubsquared has joined #openstack-dev20:39
*** krtaylor has joined #openstack-dev20:45
*** torgomatic_ has joined #openstack-dev20:46
*** torgomatic has quit IRC20:47
*** torgomatic_ is now known as torgomatic20:47
sdaguemtaylor: well, would it be possible to have a group that could resubmit. Even if it wasn't everyone, it would be good to have a chunk of folks that could20:48
sdagueand anyone that abused it, could get locked from that priv20:48
*** LarsErikP has joined #openstack-dev20:50
sdaguemtaylor: actually, I don't see the concern at all, because it also has to get people reviewed. I think you should just trust that people won't abuse it. It's not like we don't know who they are if they do :)20:50
mtaylorsdague: sure. right now we just don't have a resubmit button at all20:55
mtaylorsdague: so we have to make one20:55
sdagueright, definitely understand. I just wanted to say lets believe in trust whenever that functionality gets created, because I think people will be respectful of using it the right way20:57
*** kindaopsdevy has quit IRC20:57
*** ewindisch has quit IRC20:58
*** kindaopsdevy has joined #openstack-dev20:58
*** mnewby has joined #openstack-dev20:58
mtaylorsdague: I'm willing to give that a shot - the only reason the old resubmit link was controlled was because jenkins didn't have a way to grant access to it without granting WAY too much access to a host of other things too20:59
*** dubsquared has quit IRC21:02
*** troytoman has quit IRC21:06
*** troytoman-away has joined #openstack-dev21:06
*** troytoman-away is now known as troytoman21:06
*** nunosantos has quit IRC21:07
*** torgomatic_ has joined #openstack-dev21:12
*** katell2 has quit IRC21:13
*** mattstep_ is now known as mattstep21:13
*** ewindisch has joined #openstack-dev21:14
*** torgomatic has quit IRC21:16
*** torgomatic_ is now known as torgomatic21:16
*** andrewsmedina has quit IRC21:19
*** dolphm has quit IRC21:20
*** timjr has quit IRC21:21
*** apevec has joined #openstack-dev21:22
*** sniperd has joined #openstack-dev21:23
*** edygarcia has quit IRC21:24
*** ewindisch has quit IRC21:25
*** alaski has quit IRC21:27
*** edygarcia has joined #openstack-dev21:29
*** timjr has joined #openstack-dev21:29
*** steveb___ has joined #openstack-dev21:36
*** dachary has quit IRC21:39
*** dachary has joined #openstack-dev21:39
*** kindaopsdevy has left #openstack-dev21:40
*** andrewbogott_ has joined #openstack-dev21:42
*** andrewbogott_ has joined #openstack-dev21:42
*** andrewbogott has quit IRC21:42
*** andrewbogott_ is now known as andrewbogott21:42
*** andrewsmedina has joined #openstack-dev21:43
*** kbringard has quit IRC21:50
*** Shrews has quit IRC21:54
*** andrewbogott has quit IRC21:55
*** krtaylor has quit IRC21:55
*** cmagina has joined #openstack-dev22:08
*** steveb___ has quit IRC22:08
*** sniperd_ has joined #openstack-dev22:09
*** sniperd has quit IRC22:09
*** mattray has quit IRC22:11
*** ewindisch has joined #openstack-dev22:13
dansmith_0x44: https://review.openstack.org/#/c/9190/22:13
_0x44Awesome.22:13
dansmithI'll save addressing danpb's comments on the libvirt change until monday22:14
dansmithnova falls over pretty bad with that test right now and does the right thing with my patch22:15
_0x44Ok, I'll +2 when danpb's comments are addressed.22:15
*** mnewby has quit IRC22:16
dansmith_0x44: I'll hold you to it :)22:18
*** mnewby has joined #openstack-dev22:20
*** eglynn_ has quit IRC22:20
*** eglynn_ has joined #openstack-dev22:22
mnaserdoes nova check the network priority at all?22:23
mnasermy private network is id 3, my public is 4 (two fixed ip networks) and its creating eth0 = private eth1 = public22:23
mnaseri set the priority of the public one to 1 and private to 1000 but didnt change anything22:23
*** datsun180b has quit IRC22:26
*** darkhorse has quit IRC22:32
*** dtroyer is now known as dtroyer_zzz22:39
*** jtran has quit IRC22:40
*** rnirmal has quit IRC22:46
*** edygarcia has quit IRC22:52
*** mnewby has quit IRC22:53
*** ncode has quit IRC22:55
*** salv-orlando has quit IRC22:59
*** mnewby has joined #openstack-dev23:00
eglynn_looks like a transient failure to pull down packages: https://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/6882/consoleFull23:01
eglynn_anyone up for re-sending https://review.openstack.org/9177 ?23:01
*** ohnoimdead has quit IRC23:02
*** mnewby has quit IRC23:04
VekCan I get eyes on https://review.openstack.org/#/c/9191/ and https://review.openstack.org/#/c/9192/ please?23:08
*** mnewby has joined #openstack-dev23:12
*** anderstj has joined #openstack-dev23:12
trapniVek: why do you need the hypervisor uptime? (I just want to understand why you want that feature)23:18
trapniI can think of plenty ways to retrieve it, however :)23:18
*** blamar has quit IRC23:20
*** sniperd has joined #openstack-dev23:21
*** sniperd_ has quit IRC23:21
vishyjgriffith_: https://review.openstack.org/#/c/8073/25/nova/compute/api.py23:31
*** sniperd has quit IRC23:31
*** sniperd has joined #openstack-dev23:31
vishylooks like a leftover comment in that file, also why the switch from == to is in the None check. Seems unrelated23:31
*** aclark_ has quit IRC23:32
vishyjgriffith_: in general it would be nice if the / removal and != vs None changes were in a different commit23:34
*** epim has quit IRC23:34
* jgriffith_ looking23:36
jgriffith_vishy: Yeah, leftover comment, I'll remove.  The switch from == to is:23:37
jgriffith_Unrelated, but I had a "newer" version of pep8 on my laptop and corrected these all over the place23:37
vishyjgriffith_: I'm going to remove the unrelated stuff23:37
jgriffith_vishy: Ok, my bad on that23:37
jgriffith_Do you want me to pull it back out this week-end since I put it all in there in the first place?23:38
*** nati_ueno has joined #openstack-dev23:39
jgriffith_vishy: I'll go ahead and pull those out as well as the comments23:41
vishyjgriffith_: just did it23:41
jgriffith_vishy: :)23:41
jgriffith_vishy: and there's the email23:41
jgriffith_vishy: Thanks!23:41
*** jakedahn_zz is now known as jakedahn23:42
*** rods has joined #openstack-dev23:42
jgriffith_vishy: I'm heading out for a bit, everything else looking ok with this?23:43
vishymissed one, got it23:43
*** ohnoimdead has joined #openstack-dev23:43
vishyjgriffith_: we probably also could have split this up into three patches23:45
bcwaldonLinuxJedi: oy23:46
vishy1) add service catalog to the context, 2) clean up the cloud usage of volume_api, 3) add cinder with tests23:46
bcwaldonLinuxJedi: row-level highlighting seems broken: http://stsh.me/2OU23:46
bcwaldonLinuxJedi: you can see the text is bold, but the backgroud color of reviews I havent voted on isn't different23:47
vishyjgriffith_: I'm wondering if I should do that now23:47
*** matwood has quit IRC23:48
*** mikal has quit IRC23:49
*** rods has quit IRC23:51
*** apevec has quit IRC23:54
*** jakedahn is now known as jakedahn_zz23:58
*** adjohn has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!