Wednesday, 2012-07-18

*** Aaton is now known as Aaton_off00:01
*** halfss has joined #openstack-dev00:03
ewindischLove to get a review on https://review.openstack.org/#/c/9805/ (os-common)00:03
*** spiffxp has quit IRC00:11
*** mnaser has quit IRC00:19
*** samkottler has joined #openstack-dev00:31
*** halfss has quit IRC00:32
*** PotHix has quit IRC00:32
*** rkukura has joined #openstack-dev00:32
*** sacharya has quit IRC00:32
*** dtroyer is now known as dtroyer_zzz00:35
*** mokas has quit IRC00:36
*** galstrom has joined #openstack-dev00:38
*** dtroyer_zzz is now known as dtroyer00:38
*** nati_uen_ has joined #openstack-dev00:45
*** nati_uen_ has quit IRC00:47
*** nati_uen_ has joined #openstack-dev00:48
*** nati_ueno has joined #openstack-dev00:50
*** nati_uen_ has quit IRC00:53
*** galstrom has quit IRC00:57
*** edygarcia has joined #openstack-dev00:57
*** mnewby has quit IRC00:58
*** halfss has joined #openstack-dev01:02
*** andrewbogott has quit IRC01:02
*** thingee_zz has joined #openstack-dev01:03
*** samkottler has quit IRC01:06
*** thingee has quit IRC01:07
*** littleidea has joined #openstack-dev01:08
*** Ryan_Lane has quit IRC01:10
*** galstrom has joined #openstack-dev01:12
*** epim has joined #openstack-dev01:13
*** andrewsmedina has joined #openstack-dev01:19
*** danwent has quit IRC01:23
*** thingee_zz is now known as thingee01:24
*** danwent has joined #openstack-dev01:24
*** novas0x2a|laptop has quit IRC01:25
*** danwent has quit IRC01:26
*** dachary has quit IRC01:29
*** dachary has joined #openstack-dev01:30
*** Ruetobas has quit IRC01:31
*** Aaton_off is now known as Aaton01:31
*** primeministerp has quit IRC01:32
*** jgriffith has quit IRC01:32
*** jgriffith has joined #openstack-dev01:32
*** jgriffith is now known as Guest2128301:32
*** zul has quit IRC01:33
*** primemin1sterp has joined #openstack-dev01:33
*** zul has joined #openstack-dev01:34
*** thingee has quit IRC01:34
*** cmagina has quit IRC01:36
*** BLZbubba has quit IRC01:36
*** justinsb_ has quit IRC01:37
*** cmagina has joined #openstack-dev01:37
*** justinsb has joined #openstack-dev01:38
*** Drakiz has quit IRC01:38
*** Drakiz_ has joined #openstack-dev01:38
*** uvirtbot has quit IRC01:39
*** uvirtbot has joined #openstack-dev01:40
*** Ruetobas has joined #openstack-dev01:40
*** Daviey has quit IRC01:41
*** akscram has quit IRC01:41
*** rturk has quit IRC01:41
*** _val_ has quit IRC01:41
*** _0x44 has quit IRC01:41
*** oneiroi has quit IRC01:41
*** errr has quit IRC01:41
*** Guest63158 has quit IRC01:41
*** jpeeler has quit IRC01:41
*** halfss has quit IRC01:41
bcwaldonjeblair: interesting failure to look into tomorrow https://jenkins.openstack.org/job/gate-python-glanceclient-merge/217/consoleFull01:41
*** BLZbubba has joined #openstack-dev01:42
*** dachary has quit IRC01:45
*** dolphm has joined #openstack-dev01:45
*** oneiroi has joined #openstack-dev01:45
*** Daviey has joined #openstack-dev01:45
*** akscram has joined #openstack-dev01:45
*** rturk has joined #openstack-dev01:45
*** _val_ has joined #openstack-dev01:45
*** _0x44 has joined #openstack-dev01:45
*** jpeeler has joined #openstack-dev01:45
*** errr has joined #openstack-dev01:45
*** Guest63158 has joined #openstack-dev01:45
*** dachary has joined #openstack-dev01:46
*** Daviey has quit IRC01:46
*** mokas has joined #openstack-dev01:48
*** salv-orlando has quit IRC01:53
*** Daviey has joined #openstack-dev01:57
*** jdurgin has quit IRC01:58
*** dolphm has quit IRC01:58
jeblairbcwaldon: turns out there's nothing to prevent you from configuring two slaves in jenkins that point to the same ip address.  precise9 and precise10 were actually both running on precise9.  sorry about that.02:00
*** primemin1sterp has quit IRC02:00
*** gongys has joined #openstack-dev02:01
*** primeministerp has joined #openstack-dev02:03
*** mokas has quit IRC02:04
*** primeministerp has quit IRC02:05
*** mokas has joined #openstack-dev02:06
*** pixelbeat has quit IRC02:07
*** primeministerp has joined #openstack-dev02:08
*** andrewbogott has joined #openstack-dev02:08
*** andrewbogott has joined #openstack-dev02:08
*** andrewbogott has quit IRC02:09
*** salv-orlando has joined #openstack-dev02:11
*** anniec has quit IRC02:12
*** tgall_foo has joined #openstack-dev02:18
*** tgall_foo has joined #openstack-dev02:18
*** Aaton is now known as Aaton_off02:23
*** galstrom has quit IRC02:24
*** rods has quit IRC02:35
*** galstrom has joined #openstack-dev02:38
*** salv-orlando has left #openstack-dev02:38
*** troytoman-away is now known as troytoman02:45
*** halfss has joined #openstack-dev02:57
*** edygarcia has quit IRC03:02
*** edygarcia has joined #openstack-dev03:03
*** edygarcia has quit IRC03:05
*** halfss has quit IRC03:08
*** Guest__ is now known as roge03:15
*** mjfork has quit IRC03:15
*** edygarcia has joined #openstack-dev03:17
*** littleidea has quit IRC03:19
*** edygarcia has quit IRC03:28
bcwaldonjeblair: no worries, just thought you might want to nail that down03:29
bcwaldonjeblair: thanks!03:29
*** gongys has quit IRC03:32
*** Adri2000 has quit IRC03:33
*** Adri2000 has joined #openstack-dev03:33
*** edygarcia has joined #openstack-dev03:42
*** Guest21283 has quit IRC03:53
*** edygarcia has quit IRC03:54
*** jgriffith has joined #openstack-dev04:00
*** nati_ueno has quit IRC04:01
*** edygarcia has joined #openstack-dev04:01
*** edygarcia has quit IRC04:05
*** halfss has joined #openstack-dev04:10
*** littleidea has joined #openstack-dev04:11
*** edygarcia has joined #openstack-dev04:12
*** tserong has quit IRC04:12
*** tserong has joined #openstack-dev04:13
*** tserong has joined #openstack-dev04:13
*** renier has quit IRC04:13
*** edygarcia has quit IRC04:13
*** steveb_ has quit IRC04:13
*** galstrom has quit IRC04:14
*** renier has joined #openstack-dev04:15
*** roge has quit IRC04:16
*** renier has quit IRC04:16
*** renier has joined #openstack-dev04:16
*** edygarcia has joined #openstack-dev04:16
*** edygarcia has quit IRC04:20
*** dtroyer is now known as dtroyer_zzz04:24
*** halfss has quit IRC04:24
*** jtran has joined #openstack-dev04:24
*** mokas has quit IRC04:28
*** halfss has joined #openstack-dev04:28
*** jtran has quit IRC04:29
*** tgall_foo has quit IRC04:29
*** steveb_ has joined #openstack-dev04:31
*** halfss has quit IRC04:38
*** jtran has joined #openstack-dev04:40
*** anniec has joined #openstack-dev04:46
*** Ryan_Lane has joined #openstack-dev04:46
*** sacharya has joined #openstack-dev04:51
*** anniec has quit IRC04:57
*** anniec has joined #openstack-dev04:57
*** nati_ueno has joined #openstack-dev04:57
*** mokas has joined #openstack-dev05:11
*** anderstj has joined #openstack-dev05:12
*** steveb_ has quit IRC05:15
*** jtran has quit IRC05:16
*** Aaton_off is now known as Aaton05:20
*** jtran has joined #openstack-dev05:24
*** troytoman is now known as troytoman-away05:25
*** davidha has quit IRC05:26
*** garyk has quit IRC05:27
*** nati_ueno has joined #openstack-dev05:31
*** sacharya has quit IRC05:47
*** nati_ueno has quit IRC05:49
*** nati_ueno has joined #openstack-dev05:50
*** jakedahn is now known as jakedahn_zz05:51
*** rohitk has joined #openstack-dev05:53
*** garyk has joined #openstack-dev06:05
*** anderstj has quit IRC06:07
*** GheRivero has joined #openstack-dev06:08
*** mindpixel has joined #openstack-dev06:10
*** armaan has joined #openstack-dev06:13
*** eglynn has joined #openstack-dev06:17
*** eafonichev has quit IRC06:22
*** mrunge has joined #openstack-dev06:30
*** littleidea has quit IRC06:37
*** nati_uen_ has joined #openstack-dev06:37
*** nati_uen_ has quit IRC06:38
*** nati_uen_ has joined #openstack-dev06:38
*** eafonichev has joined #openstack-dev06:40
*** nati_ueno has quit IRC06:41
*** dachary has quit IRC06:42
*** Aaton is now known as Aaton_off06:45
*** dachary has joined #openstack-dev06:45
*** armaan has quit IRC06:46
*** Aaton_off is now known as Aaton06:52
*** nati_uen_ has quit IRC06:54
*** davidha has joined #openstack-dev07:01
*** erikzaadi has joined #openstack-dev07:02
*** aswadrangnekar has joined #openstack-dev07:03
*** davidha has quit IRC07:19
*** davidha has joined #openstack-dev07:20
*** reidrac has joined #openstack-dev07:20
*** tserong has quit IRC07:32
*** pixelbeat has joined #openstack-dev07:35
*** winston-d has joined #openstack-dev07:38
winston-djgriffith, ping07:39
*** heyho has joined #openstack-dev07:45
GheRiveromorning peopel07:46
*** Mandell_ has joined #openstack-dev08:01
*** Mandell has quit IRC08:01
*** derekh has joined #openstack-dev08:02
*** Mandell_ has quit IRC08:05
*** jtran has quit IRC08:05
*** erikzaadi has joined #openstack-dev08:06
*** markmc has joined #openstack-dev08:07
*** dachary has quit IRC08:09
*** davidha1 has joined #openstack-dev08:10
*** davidha has quit IRC08:11
*** jakedahn_zz is now known as jakedahn08:21
*** darraghb has joined #openstack-dev08:26
*** Aaton is now known as Aaton_off08:32
*** Aaton_off is now known as Aaton08:34
*** davidha has joined #openstack-dev08:35
*** davidha1 has quit IRC08:35
*** sulochan has joined #openstack-dev08:52
*** tserong has joined #openstack-dev08:53
*** davidha1 has joined #openstack-dev08:53
*** davidha has quit IRC08:54
*** jakedahn is now known as jakedahn_zz09:04
*** hugokuo1 has quit IRC09:06
*** mokas has quit IRC09:06
*** Aaton is now known as Aaton_off09:09
*** hugokuo has joined #openstack-dev09:10
*** winston-d has quit IRC09:14
*** danpb has joined #openstack-dev09:15
zykes-why isn't paginate_query in use in glance ?09:20
zykes-nvm09:26
*** dolphm has joined #openstack-dev09:32
*** asalkeld has quit IRC09:36
*** maploin has joined #openstack-dev09:37
*** maploin has quit IRC09:37
*** maploin has joined #openstack-dev09:37
*** dolphm has quit IRC09:41
*** kpavel has joined #openstack-dev09:51
*** rohitk has quit IRC10:03
*** rods has joined #openstack-dev10:09
*** erikzaadi has quit IRC10:17
*** davidha has joined #openstack-dev10:23
*** davidha1 has quit IRC10:23
markmcdanpb, what's the canonical reference for your commit messages essay?10:29
*** dachary has joined #openstack-dev10:33
danpbmarkmc: the mailing list for now - still on my TODO to transfer it to the wiki10:40
markmcdanpb, ok, thanks10:40
markmcdanpb, you'll add a link in HACKING.rst too?10:40
danpbyeah eventually10:41
*** halfss has joined #openstack-dev10:42
*** dolphm has joined #openstack-dev10:53
*** vanchester has joined #openstack-dev11:00
*** hugokuo1 has joined #openstack-dev11:01
*** vanchester1 has joined #openstack-dev11:04
*** vanchester has quit IRC11:04
*** hugokuo has quit IRC11:04
*** dachary has quit IRC11:06
*** asalkeld has joined #openstack-dev11:08
*** davidha1 has joined #openstack-dev11:11
*** davidha has quit IRC11:12
*** halfss has quit IRC11:12
*** dolphm_ has joined #openstack-dev11:12
*** dolphm has quit IRC11:14
*** mjfork has joined #openstack-dev11:21
*** dolphm_ has quit IRC11:38
Davieymarkmc: some nice catches on 953411:44
*** aswadrangnekar has quit IRC12:02
*** aswadrangnekar has joined #openstack-dev12:04
*** markvoelker has joined #openstack-dev12:05
*** dolphm has joined #openstack-dev12:09
*** mrunge has quit IRC12:13
*** salgado has joined #openstack-dev12:17
*** sandywalsh has joined #openstack-dev12:17
*** littleidea has joined #openstack-dev12:22
*** heyho has quit IRC12:27
*** roge has joined #openstack-dev12:38
*** lts has joined #openstack-dev12:47
*** jaypipes has quit IRC12:48
*** andrewsmedina has quit IRC12:48
vanchester1Hello everyone. Where can i find identity API v1 docs?12:49
dolphmvanchester1: http://docs.rackspace.com/api/12:49
vanchester1dolphm, oh, thanks! Didn't thought about it.12:50
vanchester1so API v1.0 is tempauth, isn't it?12:53
*** matiu has quit IRC12:54
*** matiu has joined #openstack-dev12:54
*** dprince has joined #openstack-dev12:56
*** dachary has joined #openstack-dev12:59
*** chrisfer has joined #openstack-dev13:00
*** m4xmr has joined #openstack-dev13:01
*** rpedde is now known as rpedde_away13:02
*** rpedde_away is now known as rpedde13:02
*** halfss has joined #openstack-dev13:08
*** jaypipes has joined #openstack-dev13:16
*** tgall_foo has joined #openstack-dev13:18
*** tgall_foo has joined #openstack-dev13:18
*** heyho has joined #openstack-dev13:19
*** EmilienM has quit IRC13:21
*** andrewsmedina has joined #openstack-dev13:21
*** EmilienM has joined #openstack-dev13:22
*** eglynn_ has joined #openstack-dev13:26
*** eglynn has quit IRC13:29
*** GheRivero_ has joined #openstack-dev13:34
*** edygarcia has joined #openstack-dev13:39
*** sacharya has joined #openstack-dev13:40
*** markmcclain has joined #openstack-dev13:40
*** dtroyer_zzz is now known as dtroyer13:44
*** andrewbogott has joined #openstack-dev13:50
*** samkottler has joined #openstack-dev13:52
annegentlevanchester1: I don't think v1 Identity docs are published to docs.openstack.org any more, but you could look at http://github.com/identity-api and examine the history to see. It is not the same as tempauth, tempauth is a swift mechanism to make auth easy for testing and only works with swift.13:54
*** mnewby has joined #openstack-dev14:00
*** kbringard has joined #openstack-dev14:00
zykes-what's the use for glance to sort by created_at and then id when id isn't incremental ?14:02
*** davidha has joined #openstack-dev14:05
dprincezykes-: Glance used to use integer ID's. Those were replaced with UUID's eventually though.14:05
*** kpavel has quit IRC14:06
*** davidha1 has quit IRC14:06
dprincezykes-: sounds like we have some old logic in the codebase for that sort clause.14:06
dprincezykes-: where exactly are you looking?14:06
zykes-https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/api.py#L33314:07
zykes-dprince:14:08
zykes-how do you do pagination with uuid then ?14:08
*** armaan has joined #openstack-dev14:08
dprincezykes-: We are using markers.14:09
zykes-that works with uuid ?14:10
*** dtroyer is now known as dtroyer_zzz14:10
dolphmzykes-: a client sorting by uuid is pretty much meaningless, but pagination by markers lets the server take care of the actual sorting, if any14:13
*** maoy has joined #openstack-dev14:13
zykes-dolphm: hmm k14:13
zykes-but isn14:13
zykes-isn't it using a uuid for something ?14:14
dprincezykes-: I was missing some context though. I think ID is required because it is unique. The comments in that function explain it.14:14
zykes-ok :)14:14
zykes-so you pass the uuid of the previos image ?14:14
dprinceFor marker, yes.14:15
*** armaan has quit IRC14:15
*** armaan has joined #openstack-dev14:16
zykes-can it be numerical as wlel dprince ?14:17
*** davidha1 has joined #openstack-dev14:20
*** davidha has quit IRC14:20
*** thingee has joined #openstack-dev14:21
*** dtroyer_zzz is now known as dtroyer14:23
*** gongys has joined #openstack-dev14:24
*** armaan has quit IRC14:25
*** kpavel has joined #openstack-dev14:27
*** armaan has joined #openstack-dev14:28
markmceglynn_, there?14:29
markmceglynn_, seen e.g. #102173814:30
eglynn_markmc: yeap14:30
* eglynn_ looking ...14:30
markmceglynn_, #102173814:30
markmceglynn_, sorry, #102172114:30
*** mokas has joined #openstack-dev14:30
markmceglynn_, #102174814:31
*** cp16net is now known as cp16net|away14:32
eglynn_markmc: hmmm, so looks like duplication on the similar bugs I was recently fixing14:33
markmceglynn_, yeah, and e.g. b0da2c4 does different from what you did AFAIR14:33
markmceglynn_, i.e. raises a 413 webob exception rather than a NovaException14:33
eglynn_markmc: yep https://review.openstack.org/#/c/9738/ changes the underlying exception type as opposed to rely on the mapping to occur in the FaultWrapper14:34
*** mokas has quit IRC14:35
eglynn_markmc: from the stable/essex point of view, that wouldn't work as the NoMoreFloatingIps exception would be wrapped up in a RemoteError that could bubble all the ways up the FaultWrapper14:36
*** datsun180b has joined #openstack-dev14:37
*** rnirmal has joined #openstack-dev14:37
eglynn_markmc: (as the RPC exception deserialization logic post-dates stable/essex)14:37
markmceglynn_, I guess at this point I care more about everything on master doing things the same way14:37
markmceglynn_, no real opinion yet on what the more correct way is, though14:38
markmceglynn_, just thought I'd point them out14:38
eglynn_markmc: no cool, good spot, I'll link in the bugs appropriately ...14:38
Adri2000anyone knowing the nova (network) code could point me to the right direction for fixing bug #1013726 ? I've been trying different things for a few hours now without luck... https://bugs.launchpad.net/nova/+bug/101372614:39
uvirtbotLaunchpad bug 1013726 in nova "Essex upgrade doesn't ensure networks have uuid" [Medium,Confirmed]14:39
uvirtbotLaunchpad bug 1013726 in nova "Essex upgrade doesn't ensure networks have uuid" [Medium,Confirmed] https://launchpad.net/bugs/101372614:39
Adri2000basically the question is: where in the code could I add a check saying "if that/all network(s) doesn't/don't have an uuid, then generate one and add it to the database"14:40
markmceglynn_, ok, I'm filing a bug that the floating_ips extension should raise FloatingIpLimitExceeded14:41
markmceglynn_, oh, it does - but catches it14:42
eglynn_markmc: cool, assign it to me14:42
markmceglynn_, it should just avoid catching it then?14:42
eglynn_markmc: exactly14:42
markmceglynn_, cool14:42
*** armaan has left #openstack-dev14:43
*** sacharya has quit IRC14:49
*** gongys has quit IRC14:50
*** cp16net|away is now known as cp16net14:50
markmceglynn_, I've assigned bug #1021748 to you too since it's also in the security groups stuff you did:14:51
markmc    def raise_over_quota(msg):14:51
markmc        raise exc.HTTPBadRequest(explanation=msg)14:51
uvirtbotLaunchpad bug 1021748 in nova "Security Group Create and adding rule to it,  is not raising proper error code for overlimit" [Undecided,Confirmed] https://launchpad.net/bugs/102174814:51
eglynn_markmc: cool, I'll take care of that ...14:51
markmceglynn_, excellent14:52
*** Aaton_off is now known as Aaton14:52
*** davidha1 has quit IRC14:55
*** danwent has joined #openstack-dev14:59
*** salgado has quit IRC15:01
chmouelmarkmc: do you know if it's a known problem with openstack.common.log ? http://pastie.org/4278303 (openstack.common.log)15:01
bcwaldonmtaylor: pbr+glance15:01
bcwaldonmtaylor: you workinprogressed15:01
bcwaldonmtaylor: then pushed15:01
bcwaldonmtaylor: ready for review?15:01
*** salgado has joined #openstack-dev15:02
*** salgado has joined #openstack-dev15:02
*** datsun180b_ has joined #openstack-dev15:04
jgriffithwinstond: pong15:05
*** datsun180b_ has joined #openstack-dev15:05
andrewbogottchmouel:  I'm the one who moved logging and notifiers into common.  That failure is new to me.15:05
*** rbasak has quit IRC15:05
andrewbogottchmouel:  Is cinder using common notifier as well as common logging?15:06
*** datsun180b has quit IRC15:07
*** datsun180b_ is now known as datsun180b15:07
*** cdub_ has quit IRC15:08
markmcandrewbogott, see chmouel's draft here: https://review.openstack.org/#/c/9913/15:08
mtaylorbcwaldon: well, let's wait until it passes *@$%@ tests15:09
bcwaldonmtaylor: kk15:09
*** andrewbogott_ has joined #openstack-dev15:10
*** andrewbogott has quit IRC15:10
*** andrewbogott_ is now known as andrewbogott15:10
andrewbogottmarkmc:  Gerrit doesn't want me to see that page.15:10
markmcandrewbogott, wise gerrit15:11
*** cdub_ has joined #openstack-dev15:11
*** sstent has quit IRC15:11
*** mindpixel has quit IRC15:12
markmcandrewbogott, https://github.com/markmc/cinder/commits/chmouel-common-logging15:13
*** garyk has quit IRC15:14
zykes-anyone know if rackerjoe is on irc ?15:15
*** sstent has joined #openstack-dev15:16
andrewbogottgrrr, I hate how git regards a switch to common logging as a move+edit rather than as a remove and an add15:16
*** rbasak has joined #openstack-dev15:19
*** arosen has quit IRC15:19
andrewbogottWell, maybe this is an actual bug.  markmc, if I import 'notifier' and notifier is a directory with an __init__.py then I should be able to reference notifier.api later shouldn't I?15:20
andrewbogottI fear I'm making some horrible noob python mistake here15:20
bcwaldoneglynn_: ping15:20
eglynn_bcwaldon: hey15:20
bcwaldoneglynn_: do you have a sec to talk about the refactor-db-layer bp?15:21
eglynn_bcwaldon: sure15:21
bcwaldoneglynn_: I want to talk about what we want to get done within F-315:21
eglynn_bcwaldon: what's still un-done at this stage?15:21
bcwaldoneglynn_: https://blueprints.launchpad.net/glance/+spec/refactor-db-layer15:21
bcwaldoneglynn_: you noted some promotion to openstack-common15:21
bcwaldoneglynn_: and alighment with Nova15:21
andrewbogottchmouel:  Does something like this help?  http://pastebin.com/wiCRATbt15:22
bcwaldoneglynn_: but I'm not really sure that is necessary at this stage15:22
bcwaldoneglynn_: I would like to figure out our bootstrap process15:22
eglynn_bcwaldon: yep, I agree15:22
bcwaldoneglynn_: I think we should just copy whatever nova does w.r.t. spin up and db creation15:22
bcwaldoneglynn_: but we may already be doing that15:22
bcwaldoneglynn_: I just dont know15:22
bcwaldoneglynn_: would you agree that once that is done, the bp is done?15:23
eglynn_bcwaldon: I need to remind myself wrt. to the nova differences, I haven't looked at that code in a while15:23
bcwaldoneglynn_: maybe dprince knows offhand15:23
*** sacharya has joined #openstack-dev15:23
bcwaldoneglynn_: I know he's dealt with it in the past15:23
bcwaldoncalling dprince !15:23
eglynn_bcwaldon: but yes, that would be a reasonable endpoint for the bp15:23
vishymarkmc: nice job on the extensive cherry picks into cinder15:24
bcwaldoneglynn_: ok, I'll clean up the bp definition to reflect tha15:24
bcwaldont15:24
*** reidrac has quit IRC15:24
eglynn_bcwaldon: cool15:24
vishyjgriffith: are you there? I think we should get all the common sync patches proposed by mark in15:24
markmcvishy, thanks; there's plenty more, I was only looking at openstack-common related stuff15:24
jgriffithvishy: Agreed, I was going to give one day for folks to review before just approving all of them15:24
jgriffithvishy: That one day is up :)15:25
vishyI just went through them all and there isn't anything obviously wrong as far as I can tell.15:25
jgriffithvishy: Cool, I'll consider them all +1 form you then :)15:25
vishyjgriffith: already +2d them all :)15:25
*** aswadrangnekar has left #openstack-dev15:25
jgriffithvishy: Well, there ya have it :)15:26
jgriffithvishy: Thanks!!!15:26
vishyjgriffith: you still have to approve them though :)15:27
jgriffithvishy: Yep, doing it now15:27
jgriffithmarkmc: The only one that needs looked at is https://review.openstack.org/#/c/9904/215:28
chmouelandrewbogott: just catching up.. let me try15:28
*** sacharya1 has joined #openstack-dev15:29
markmcvishy, what needs doing with 9904?15:29
vishymarkmc, jgriffith: that looks like a suprious error to me15:29
*** sacharya has quit IRC15:30
markmcvishy, jgriffith, yeah a few of them failed like that15:30
vishyjust ran a reverify to check15:30
jgriffithvishy: markmc: Agreed, there's a couple others15:30
chmouelandrewbogott: needs a bit more digging that that15:30
vishymarkmc: don't know if you noticed while you were gone, but if you put a comment 'reverify' jenkins will check it again15:30
andrewbogottchmouel:  That results in the same failure?15:31
chmouelandrewbogott: http://pastie.org/427847715:31
chmouelandrewbogott: changed your import tho15:31
markmcvishy, oh, thanks for the tip15:31
andrewbogottchmouel:  OK, to start I think what we need is a test in common that traverses that code.  I thought there was one...15:32
bcwaldoneglynn_: so the db code is different, but glance does match the same default behavior now15:32
andrewbogottIf you don't get to it first, I'll work on that in an hour or so.15:32
bcwaldoneglynn_: I'm going to run through existing glance db bugs and see what we can do about those15:32
bcwaldoneglynn_: then I'll close that db15:32
bcwaldoneglynn_: close that bp*15:33
eglynn_bcwaldon: sounds reasonable!15:33
chmouelandrewbogott: yeah, let me do some digging more seems weird with the way python does the import15:33
andrewbogottMight just be that there's a circular import?15:34
*** spiffxp has joined #openstack-dev15:34
chmouelandrewbogott: i would expect python to bug us about it15:35
andrewbogottme too15:35
*** spiffxp has quit IRC15:36
*** arosen has joined #openstack-dev15:38
*** Aaton is now known as Aaton_off15:41
*** rkukura has quit IRC15:43
*** rkukura has joined #openstack-dev15:44
*** dachary has quit IRC15:44
*** halfss has quit IRC15:46
*** mokas has joined #openstack-dev15:47
*** Aaton_off is now known as Aaton15:50
*** salgado is now known as salgado-lunch15:51
*** anderstj has joined #openstack-dev15:53
*** spiffxp has joined #openstack-dev15:56
*** sacharya1 has quit IRC15:57
*** mokas has quit IRC15:58
*** e1mer has quit IRC15:59
*** anderstj has quit IRC15:59
*** armaan has joined #openstack-dev16:00
*** dachary has joined #openstack-dev16:02
*** sandywalsh has quit IRC16:03
*** sacharya has joined #openstack-dev16:04
*** armaan has quit IRC16:05
*** cp16net is now known as cp16net|away16:08
*** littleidea_ has joined #openstack-dev16:08
chmouelandrewbogott: it's maybe because there is still a cinder/notifier/ in there16:08
chmouelandrewbogott: but could not see where is the conflict16:09
andrewbogottchmouel:  I thought about that, but can't think why it would matter.16:09
andrewbogottYou should probably remove the cinder notifier as part of this patch anyway.16:09
chmouelwell I can do that but the patch is a bit big already16:09
chmoueland it's a bit of chicken and egg problem which one comes first :)16:09
*** garyk has joined #openstack-dev16:09
chmouelI guess i need to start removing the notifier16:10
*** edygarcia_ has joined #openstack-dev16:10
andrewbogottI think when I did this in nova I moved the logging first, and hand-edited the common logging files to point at nova notifier16:11
andrewbogottThen a second patch that moved the notifier and reverted the common logging file to their pristine state.16:11
*** cp16net|away is now known as cp16net16:11
chmouelyeah was going to go for that but not sure what was the policy for this if we are allow to handedit16:12
andrewbogottBut it may be that the same problem was present and there just wasn't a test that caught it.16:12
*** littleidea has quit IRC16:13
*** littleidea_ is now known as littleidea16:13
*** edygarcia has quit IRC16:14
*** edygarcia_ is now known as edygarcia16:14
*** Aaton is now known as Aaton_off16:15
*** Mandell has joined #openstack-dev16:17
*** mokas has joined #openstack-dev16:17
*** jdurgin has joined #openstack-dev16:18
*** nati_ueno has joined #openstack-dev16:19
*** nati_ueno has quit IRC16:21
*** nati_ueno has joined #openstack-dev16:22
*** andrewbogott has quit IRC16:22
*** jtran has joined #openstack-dev16:23
*** Aaton_off is now known as Aaton16:23
*** ayoung has quit IRC16:24
*** Aaton is now known as Aaton_off16:28
*** nati_ueno has quit IRC16:31
chmouelannegentle: so yeah will go for now using the cinder.notifer which make it pass and will see with removing it next16:35
*** anniec has quit IRC16:35
*** danpb has quit IRC16:41
*** dachary has quit IRC16:42
*** maploin has quit IRC16:43
*** issackelly has joined #openstack-dev16:45
*** matwood has joined #openstack-dev16:45
*** dachary has joined #openstack-dev16:48
*** sacharya has quit IRC16:49
*** dachary has quit IRC16:49
timellohey jaypipes! Thank you very much for the great review! Regarding your question... how possible is to have phased approach? I would like to get a point that even though the critical functions are not implemented... we can submit further patches in phases... My concern is to keep adding more code and make the review process slower and hard.16:50
jaypipestimello: right, which is why I asked :) just wondering about your thoughts on where to "divide" the work up into phases.16:51
timellojaypipes: does it sound possible?16:51
jaypipestimello: I think first phase should be completing work on the most basic ops16:51
jaypipestimello: for instance:16:51
jaypipesspawn, list instances, stop16:51
jaypipestimello: I think that's a good enough phase 1, no?16:51
timellojaypipes: yeah, I agree. Ok. For the next review, I'll add those!16:52
*** m4xmr has quit IRC16:52
jaypipestimello: reviewers are going to want to see your roadmap for completing the driver, which is why I bring this up. we've been burned in the past with folks dumping a driver into nova and not maintaining it, so it's important to see a plan.16:52
jaypipestimello: cool, sounds good! ping me if you have further questions on how to use stubout, BTW. it can be a bit obtuse when you start working with it.16:53
timellojaypipes: the roadmap could be described in the code itself, somewhere?16:53
jaypipestimello: a blueprint, please :)16:53
timelloOk.16:53
jaypipestimello: and then make sure you --amend you commit message to say "partially implements bp <BP_NAME>16:53
timellojaypipes: got it. Thanks!16:54
jaypipestimello: that way vishy can track your blueprint with inclusion into a milestone (likely in "Grizzly" release...)16:54
*** wdunn has quit IRC16:56
bcwaldonjaypipes: thoughts on https://review.openstack.org/#/c/9970/ ?16:56
*** sacharya has joined #openstack-dev16:56
timellojaypipes: Ok!16:57
*** andrewbogott has joined #openstack-dev16:57
*** Ryan_Lane has quit IRC16:58
jaypipesbcwaldon: approved.16:59
*** dachary has joined #openstack-dev16:59
*** galstrom has joined #openstack-dev17:00
*** galstrom has quit IRC17:00
bcwaldonjaypipes: awesome, thank you sir17:01
*** galstrom has joined #openstack-dev17:01
*** nati_ueno has joined #openstack-dev17:02
bcwaldonjeblair: seeing odd failures https://jenkins.openstack.org/job/gate-glance-merge/1354/consoleFull17:04
bcwaldonjeblair: that job came from this review https://review.openstack.org/#/c/9970/17:04
bcwaldonjeblair: see it was reported as failure17:04
bcwaldonon the review17:04
*** kpavel has quit IRC17:04
bcwaldonjeblair: seeing that kind of failure a lot17:05
jeblairbcwaldon: the vote is correct, the message it left for the merge job is wrong....17:05
bcwaldonjeblair: ok17:05
jeblairbcwaldon: i actually fixed the bug in the code about 40 minutes ago, but there are 92839487239842342 cinder changes in the queue right now, and i have to wait until they are done to restart.  :(17:05
bcwaldonok17:06
bcwaldonno problem17:06
bcwaldonI can reverify later17:06
bcwaldonif necessary17:06
jeblairnot necessary since the vote is correct17:06
bcwaldonkk, cool17:06
jeblair(there should be a gate job in the queue somewhere and assuming nothing has changed, that change should merge17:06
*** derekh has quit IRC17:08
*** armaan has joined #openstack-dev17:08
*** armaan has left #openstack-dev17:09
*** nati_uen_ has joined #openstack-dev17:09
*** mokas has quit IRC17:10
*** nati_ueno has quit IRC17:12
*** mokas has joined #openstack-dev17:14
*** littleidea_ has joined #openstack-dev17:15
*** littleidea has quit IRC17:16
*** littleidea_ is now known as littleidea17:16
jgriffithjeblair: You exagerate, it's only 92839487239842341 !17:16
*** littleidea has joined #openstack-dev17:16
eglynn_mtaylor, jeblair: looks like a /home/jenkins/workspace/gate-nova-merge/.git/refs/remotes/origin/master.lock file may need to be manually blown away on a Jenkins slave17:16
eglynn_mtaylor, jeblair: see https://jenkins.openstack.org/job/gate-nova-merge/4876/consoleFull17:16
*** lcheng has quit IRC17:17
jeblaireglynn_: looking17:18
*** PotHix has joined #openstack-dev17:19
*** dachary has quit IRC17:20
*** dachary has joined #openstack-dev17:20
*** primeministerp has quit IRC17:21
jeblaireglynn_: thanks.  it was a slave misconfiguration, i'll correct it as soon as the currently running job finishes17:21
eglynn_jeblair: cool, thanks!17:21
*** salgado-lunch is now known as salgado17:24
*** sandywalsh has joined #openstack-dev17:25
*** matwood has quit IRC17:26
*** zaitcev has joined #openstack-dev17:27
*** anderstj has joined #openstack-dev17:29
andrewbogottchmouel:  Just got your review request; were you able to hammer out that test failure?17:29
chmouelyeah17:30
andrewbogottGit makes it pretty hard to read the log.py part of the patch.  Is the notifier import the only part you edited?17:31
*** wdunn has joined #openstack-dev17:32
chmouelyeah that's it17:32
chmouelchanged the notify17:32
chmoueli.e removing None argument since the notifer from cinder doesn't have a context17:33
*** anniec has joined #openstack-dev17:33
chmouelstill the import problem we had is weird and that's just workaround17:34
chmouelmaybe that's what __path__ is useful for17:34
*** darraghb has quit IRC17:35
*** dachary has quit IRC17:36
*** ayoung has joined #openstack-dev17:37
*** jshepher has joined #openstack-dev17:38
*** dachary has joined #openstack-dev17:40
*** galstrom has quit IRC17:42
*** jshepher is now known as galstrom17:42
*** GheRivero has quit IRC17:42
*** GheRivero_ is now known as GheRivero17:42
*** dachary has quit IRC17:44
*** rafaduran has joined #openstack-dev17:45
*** Ryan_Lane has joined #openstack-dev17:50
*** vanchester1 has quit IRC17:50
*** salgado has quit IRC17:50
*** Mandell_ has joined #openstack-dev17:50
*** Mandell has quit IRC17:53
*** ayoung has quit IRC17:58
*** matwood has joined #openstack-dev18:00
*** anderstj has quit IRC18:00
*** anniec_ has joined #openstack-dev18:01
*** anniec_ has quit IRC18:02
*** anniec has quit IRC18:02
*** dachary has joined #openstack-dev18:02
*** otter2 has joined #openstack-dev18:02
*** anniec has joined #openstack-dev18:03
*** anniec has quit IRC18:04
*** otter1 has quit IRC18:04
*** anniec has joined #openstack-dev18:05
*** jakedahn_zz is now known as jakedahn18:06
*** dachary1 has joined #openstack-dev18:09
*** GheRivero has quit IRC18:09
*** dachary has quit IRC18:10
*** salgado has joined #openstack-dev18:12
*** salgado has joined #openstack-dev18:12
*** mdomsch has joined #openstack-dev18:16
dansmithvishy: how come we use context.elevated() in reboot_instance() but not, say, start_instance()?18:17
*** dachary1 has quit IRC18:22
*** dachary has joined #openstack-dev18:22
*** matwood has quit IRC18:23
*** galstrom has quit IRC18:25
*** galstrom has joined #openstack-dev18:25
*** mokas has quit IRC18:26
*** jshepher has joined #openstack-dev18:27
*** dachary has quit IRC18:27
*** eglynn__ has joined #openstack-dev18:29
*** eglynn_ has quit IRC18:30
*** galstrom has quit IRC18:31
*** jshepher is now known as galstrom18:31
*** jakedahn is now known as jakedahn_zz18:33
*** jakedahn_zz is now known as jakedahn18:39
*** davidha1 has joined #openstack-dev18:39
*** jakedahn is now known as jakedahn_zz18:44
*** gakott has joined #openstack-dev18:44
Ryan_Laneanyone have an idea why the api service may take 9-10 seconds to return a response?18:44
Ryan_Lanetoday, all of a sudden, all of my api requests are taking 10 seconds to return18:45
*** garyk has quit IRC18:45
*** jakedahn_zz is now known as jakedahn18:49
*** sacharya has quit IRC18:50
*** markmc has quit IRC18:53
*** zaitcev has quit IRC18:55
jaypipesdtroyer: ping18:56
dtroyerjaypipes: yo18:56
jaypipesdtroyer: I'm seeing this on a freshly-pulled devstack install... wondering if you've seen this? http://paste.openstack.org/show/19488/18:57
jaypipesdtroyer: seems like glance-manage db_sync is not being run?18:57
jaypipesdtroyer: wondering if something recently changed with glance db migrations?18:57
jaypipesbcwaldon: ^^ u too18:57
dtroyerI'm not aware of anything changing in devstack wrt glance lately.  is that from stack.sh?18:58
jaypipesdtroyer: yep.18:59
*** sacharya has joined #openstack-dev19:00
dtroyerjaypipes: I can't find a 'glance image-list' command in stack.sh…it is in a couple of exercises and they're running for me…but I have a basic minimal service config…no swift, etc19:04
*** anderstj has joined #openstack-dev19:05
Ryan_Lanewhere's the recommended place to get help? irc is like a ghost town19:06
jaypipesdtroyer: sorry, that's in configure_tempest.sh, but the same traceback occurs when the stack.sh does any glance command.19:06
jaypipesRyan_Lane: ML?19:06
Ryan_Lanefor diablo support?19:07
Ryan_Laneor is there a ML for support?19:07
jaypipesRyan_Lane: no, I was just suggesting posting to the general mailing list19:07
* Ryan_Lane nods19:07
*** danwent has quit IRC19:09
dtroyerjaypipes: I don't see it with swift enabled either...19:10
*** chrisfer has quit IRC19:11
jaypipesdtroyer: shouldn't have anything to do with swift...19:11
dtroyerjaypipes: ok19:12
dtroyerjaypipes: config_tempest.sh runs for me too...19:12
jaypipesdtroyer: found the issue...19:14
jaypipes+ /opt/stack/glance/bin/glance-manage db_sync19:14
jaypipes2012-07-18 14:49:36     INFO [glance.db.sqlalchemy.api] auto-creating glance registry DB19:14
jaypipes2012-07-18 14:49:36     INFO [glance.db.sqlalchemy.migration] Upgrading sqlite:///glance.sqlite to version latest19:14
*** chrisfer has joined #openstack-dev19:14
jaypipesdtroyer: the call to glance-manage db_sync is syncing a SQLite database, but the glance-registry.conf sets the DB connection to a MySQL database (as it should)19:15
jaypipesdtroyer: do you have /etc/glance/glance-*.conf files?19:17
*** danwent has joined #openstack-dev19:17
dtroyerjaypipes: yup and they have sql_connection set to mysql19:18
jaypipesdtroyer: ok, so that's the issue... need to pass --config-file to the glance-manage call. I'll submit a patch.19:18
*** dprince has quit IRC19:18
jaypipesdtroyer: gotta love hard-to-find default configuration settings ;)19:18
dtroyerjaypipes: so why don't I see that?19:19
jaypipesdtroyer: so... glance-manage looks for /etc/glance/glance-registry.conf if no --config-file=<FILE> option is given. and since you have that file (and I don't), it uses the mysql connection. In my case, I don't have that file and it used the default db_connection setting of a SQLite database.19:20
*** sulochan has quit IRC19:20
*** sulochan_ has joined #openstack-dev19:20
dtroyerjaypipes: ah, I didn't realize you didn't have them…makes sense to me now19:20
jaypipesdtroyer: just a simple matter of supplying the --config-file arg when calling glance-manage19:20
*** rpedde is now known as rpedde_away19:23
jaypipesdtroyer: yup, adding --config-file=$GLANCE_API_CONF fixed it up. patch coming soon.19:23
*** danwent_ has joined #openstack-dev19:25
*** dolphm_ has joined #openstack-dev19:25
*** davidkranz has joined #openstack-dev19:25
*** rnirmal_ has joined #openstack-dev19:26
*** anderstj has quit IRC19:27
*** danwent_ has quit IRC19:27
*** datsun180b_ has joined #openstack-dev19:27
*** danwent_ has joined #openstack-dev19:27
*** jakedahn_ has joined #openstack-dev19:27
*** seats_ has joined #openstack-dev19:28
*** armaan1 has joined #openstack-dev19:28
*** armaan1 has left #openstack-dev19:28
*** roge_ has joined #openstack-dev19:28
*** bhuvan_ has joined #openstack-dev19:29
*** Xtrapni has joined #openstack-dev19:29
*** anderstj has joined #openstack-dev19:29
*** giroro_ has joined #openstack-dev19:32
*** chmouel_ has joined #openstack-dev19:32
*** anniec has quit IRC19:33
*** pandemicsyn2 has joined #openstack-dev19:33
*** danwent has quit IRC19:34
*** gakott has quit IRC19:34
*** datsun180b has quit IRC19:34
*** rnirmal has quit IRC19:34
*** markmcclain has quit IRC19:34
*** matiu has quit IRC19:34
*** roge has quit IRC19:34
*** dolphm has quit IRC19:34
*** Daviey has quit IRC19:34
*** Ruetobas has quit IRC19:34
*** davidkranz_ has quit IRC19:34
*** bhuvan has quit IRC19:34
*** linmin has quit IRC19:34
*** seats has quit IRC19:34
*** pandemicsyn has quit IRC19:34
*** trapni has quit IRC19:34
*** cloudfly has quit IRC19:34
*** chmouel has quit IRC19:34
*** jakedahn has quit IRC19:34
*** datsun180b_ is now known as datsun180b19:34
*** danwent_ is now known as danwent19:34
*** rnirmal_ is now known as rnirmal19:34
*** seats_ is now known as seats19:34
*** anderstj has quit IRC19:38
*** Daviey has joined #openstack-dev19:39
*** matiu has joined #openstack-dev19:39
*** matiu has quit IRC19:39
*** matiu has joined #openstack-dev19:39
*** gakott has joined #openstack-dev19:40
*** linmin has joined #openstack-dev19:40
*** benner has quit IRC19:42
Ryan_Laneok. I generally don't bitch very much….19:43
Ryan_Lane(that's a lie)19:43
Ryan_Lanebut I just did a show full processlist to find out why why queries are taking so long for my metadata service19:44
*** novas0x2a|laptop has joined #openstack-dev19:44
Ryan_Laneand I swear I've just seen the worst query I've ever seen in my entire life19:44
dtroyerjaypipes: I'm confused…looking at the code to refresh my memory, how are you not getting files in /etc/glance?  Not only is it the default but it isn't configurable in localrc either.19:44
jaypipesdtroyer: actually, I also have /etc/glance/* installed by devstack. now trying to figure out what glance-manage thinks is the difference if I don'r supply --config-file to it :(19:46
Ryan_Laneplease. someone tell me why a query like this is ever necessary: http://pastebin.com/fNwxcaVh19:46
jaypipesdtroyer: sorry for jumping the gun.19:46
jaypipesRyan_Lane: welcome to ORMs.19:46
* Ryan_Lane sighs19:46
Ryan_Lanethis is why I don't use ORMs19:46
jaypipesRyan_Lane: ya, I know :(19:47
Ryan_Lanemy metadata requests are taking 10s19:47
Ryan_LaneI can't boot instances19:47
Ryan_LaneI can't create instances19:47
Ryan_Lanehow the hell am I supposed to debug a query like that?19:47
jaypipesRyan_Lane: is the request spent entirely in the database query?19:51
Ryan_Lanethose queries are taking 7 seconds19:52
*** rpedde_away is now known as rpedde19:55
jaypipesRyan_Lane: ugh.. :(19:56
jaypipesRyan_Lane: that query has absolutely no where condition on it :( it's reading all of the instances table joined with a dozen other tables... all table scans.19:57
jaypipesRyan_Lane: vishy refactored the metadata query code in essex. perhaps it's worth backporting to essex?19:58
jaypipessorry, backporting to diablo.19:58
*** mokas has joined #openstack-dev19:58
vishyjaypipes: I did?19:58
jaypipesvishy: yeah... you added a caching layer IIRC19:59
*** markmcclain has joined #openstack-dev19:59
*** andrewbogott has quit IRC20:01
vishyjaypipes: oh right, yes jesse and I added that20:02
vishyjaypipes: it is probably cherry-pickable20:02
vishyjaypipes: although stuff moved around so it will probably have to be done manually20:02
jaypipesvishy: git log --author=vish* --oneline | grep metadata20:02
jaypipesvishy: it's in there somewhere :)20:02
jtrananyone know if ceilometer gerrit doesn't allow draft reviews?20:03
jtranTo ssh://jtran@review.openstack.org:29418/stackforge/ceilometer.git20:03
jtran ! [remote rejected] HEAD -> refs/draft/master/bug/1004449 (can not create new references)20:03
jtranerror: failed to push some refs to 'ssh://jtran@review.openstack.org:29418/stackforge/ceilometer.git'20:03
jaypipesjtran: hop over to #openstack-infra and ask jeblair :)20:04
jtranok thx20:04
*** tgall_foo has quit IRC20:06
*** tgall_foo has joined #openstack-dev20:07
*** tgall_foo has joined #openstack-dev20:07
jaypipesRyan_Lane: ping. any chance you could paste the output of an EXPLAIN SELECT for that query above?20:09
*** edygarcia_ has joined #openstack-dev20:10
*** edygarcia has quit IRC20:13
*** edygarcia_ is now known as edygarcia20:13
*** eglynn has joined #openstack-dev20:15
*** eglynn__ has quit IRC20:15
*** cp16net is now known as cp16net|away20:15
*** cp16net|away is now known as cp16net20:15
*** anniec has joined #openstack-dev20:18
*** anniec_ has joined #openstack-dev20:19
*** andrewsmedina has left #openstack-dev20:20
*** pandemicsyn2 is now known as pandemicsyn20:20
*** ChanServ sets mode: +v pandemicsyn20:20
*** anniec has quit IRC20:22
*** anniec_ is now known as anniec20:22
Ryan_Laneso…. from the slow query log: # Query_time: 6.026755  Lock_time: 0.000607 Rows_sent: 18822  Rows_examined: 4214520:24
Ryan_Lanethat's for looking up the metadata for a single instance20:26
Ryan_Lanethat's crazy20:26
*** cp16net is now known as cp16net|away20:27
*** cp16net|away is now known as cp16net20:27
*** sacharya has quit IRC20:28
*** andrewbogott has joined #openstack-dev20:30
*** galstrom has left #openstack-dev20:30
*** vanchester has joined #openstack-dev20:31
*** chmouel_ is now known as chmouel20:31
*** benner has joined #openstack-dev20:34
*** dachary has joined #openstack-dev20:36
jaypipesRyan_Lane: can you EXPLAIN SELECT any of the queries for me?20:40
jaypipesdtroyer: I am an idiot... I had a glance-api.conf file lying around in my ~ directory that was being picked up. :(20:41
*** sacharya has joined #openstack-dev20:42
*** jog0 has joined #openstack-dev20:43
*** giroro_ has quit IRC20:43
dtroyerjaypipes: argh!   I HATE IT when that happens20:44
*** s0mik has joined #openstack-dev20:45
*** galstrom has joined #openstack-dev20:45
*** galstrom has joined #openstack-dev20:46
jaypipesdtroyer: :) abandoned the change in gerrit...20:46
*** jshepher has joined #openstack-dev20:47
mtaylorRyan_Lane: you should ping devananda about that too20:48
mtaylorRyan_Lane: I know he's been looking at database optimizations20:48
*** dachary has quit IRC20:50
*** galstrom has quit IRC20:51
*** jshepher is now known as galstrom20:51
*** Ruetobas has joined #openstack-dev20:52
*** Deva has joined #openstack-dev20:53
*** Deva is now known as devananda220:55
jgriffithdtroyer: I almost forgot, did you ever get a chance to look at the excercise.sh failures?20:55
devananda2mtaylor, ryan_lane, whats up?20:55
dtroyerjgriffith: you mean the boot_from_volume failure?20:56
jgriffithdtroyer: Yep20:56
jgriffithdtroyer: I'm still trying to figure out why the jenkins runs work and nothing else does :( Including the gat job changes20:57
jgriffithdtroyer: Well, not still... just came back to it this afternoon20:57
dtroyerjgriffith: not really.  boot_from_volume isn't run for gating20:57
*** timjr has joined #openstack-dev20:58
mtaylordevananda2: from earlier (don't know if you was here, Ryan_Lane said "so…. from the slow query log: # Query_time: 6.026755  Lock_time: 0.000607 Rows_sent: 18822  Rows_examined: 42145 ... that's for looking up the metadata for a single instance"20:58
jgriffithdtroyer: Well that explains that :)20:58
dtroyerjgriffith: I don't recall it ever working, that's why we disabled it20:58
*** s0mik has quit IRC20:59
devananda2mtaylor, nope, not at my comp now. thats an awesome query.20:59
*** s0mik has joined #openstack-dev20:59
mtaylordevananda2: yeah, right?21:00
devananda2ryan_lane, want to send a snippet of that query log, and i can look into it?21:01
jgriffithdtroyer: Oh... ok21:01
jgriffithdtroyer: So then I'm just down to the one failure for the gate changes21:02
jgriffithdtroyer: Sorry, I was confused21:02
dtroyerjgriffith: np21:03
*** Gordonz_ has quit IRC21:03
*** novas0x2a|laptop has quit IRC21:04
*** novas0x2a|laptop has joined #openstack-dev21:04
jgriffithdtroyer: Do you by chance know what I missed in this patch to get the gate changed over?  https://review.openstack.org/#/c/9746/21:04
dtroyerjgriffith: I don't see anything obvious but I'm not too familiar with the CI scripts21:06
* mtaylor lookie21:06
jgriffithdtroyer: Cool, thanks.  Wasn't sure if you were on that side of the devstack stuff too.21:06
jgriffithdtroyer: You've answered every other question I've asked so it was worth a shot :)21:06
mtaylorjgriffith: it looks like you did actually enable something cinder-wise21:07
jgriffithmtaylor: yeah, but something went awry and it failed.21:07
jgriffithmtaylor: I need to look at the screen output again I suppose21:08
*** s0mik has quit IRC21:08
mtaylorjgriffith: yeah - I mean, on VERY cursory look it seems like it mostly perhaps did what you asked?21:08
jgriffithmtaylor: Yeah, and what's annoying is it "looks" like it created the volume succesfully as well21:09
jgriffithmtaylor: That assert I believe is fomr the python threading bug that shows up all over the place21:10
*** anniec has quit IRC21:10
*** lts has quit IRC21:11
*** dolphm_ has quit IRC21:12
*** vanchester has quit IRC21:12
*** novas0x2a|laptop has quit IRC21:13
*** steveb_ has joined #openstack-dev21:14
*** zaitcev has joined #openstack-dev21:14
*** novas0x2a|laptop has joined #openstack-dev21:14
*** s0mik has joined #openstack-dev21:17
*** jog0 has quit IRC21:18
*** devananda2 has quit IRC21:21
*** cloudfly has joined #openstack-dev21:23
*** rnirmal has quit IRC21:25
zykes-Should my instance go offline when snapshotting ?21:25
zykes-Can't ping it when snapshotting :/21:26
*** sacharya has quit IRC21:27
Ryan_Lanejaypipes, devananda2: http://pastebin.com/REtVG8ch21:27
Ryan_Lanehere's the query: http://pastebin.com/fNwxcaVh21:27
Ryan_Laneso, deleted on all of these tables is unindexed21:28
Ryan_LaneI'm not sure if that's changed in newer versions of nova, but it's the case in diablo21:28
*** anniec has joined #openstack-dev21:29
*** Devananda2 has joined #openstack-dev21:30
*** gongys has joined #openstack-dev21:30
*** anniec_ has joined #openstack-dev21:31
Devananda2Ryan_Lane: can you send the actual query, and/or info on reproducing it in devstack? The explain doesn't help me find the code responsible for the query21:32
*** markvoelker has quit IRC21:32
Ryan_Laneit's in the pastebin21:32
Ryan_Lanehttp://pastebin.com/fNwxcaVh21:32
Ryan_Lanethis is a query to get metadata21:33
Devananda2Ah, thanks. On a bad connection, didn't see that paste before21:33
* Ryan_Lane nods21:33
*** anniec has quit IRC21:34
*** anniec_ is now known as anniec21:34
*** salgado has quit IRC21:36
*** ayoung has joined #openstack-dev21:36
zykes-or is it designed like that ?21:37
*** rafaduran has quit IRC21:39
*** danwent has quit IRC21:39
*** andrewbogott has quit IRC21:40
*** tgall_foo has quit IRC21:42
*** troytoman-away is now known as troytoman21:44
Ryan_Lanesooooo. what's that cherry-pick for caching this stuff?21:47
Ryan_LaneI really need a working system21:47
Ryan_Lanealso, another question: why are things marked as deleted in the database, rather than actually being deleted at some point?21:48
Ryan_Laneand is there some way for me to delete this old cruft, since every row is making the database increasingly slower21:48
jaypipesRyan_Lane: the ones I identified earlier were e607353 and 1a209e6 at least...21:49
jaypipesRyan_Lane: but of course, pretty sure it won't be an easy cherry-pick without conflict :(21:50
jaypipesRyan_Lane: and we mark deleted instead of deleting because of audit reasons.21:50
*** EmilienM has quit IRC21:51
*** littleidea_ has joined #openstack-dev21:51
Ryan_Laneheh. seems that query returns 391MB of data21:52
jaypipesRyan_Lane: looking into that now...21:52
Ryan_Lanewhich makes it understandable that it takes so long21:52
*** littleidea__ has joined #openstack-dev21:52
Ryan_Laneit's not the query, it's returning the data across the wire21:52
jaypipesRyan_Lane: would you mind doing something else for me? could you mysqldump the schema only, please?21:52
jaypipesRyan_Lane: I can identify indexes that will speed this up considerably for you -- at least get you past this existing perf issue.21:53
Ryan_Lanethis isn't an index problem anymore21:53
Ryan_Lanethe problem is that a query for a single instance is returning data for every single instance21:53
*** littleidea has quit IRC21:55
*** littleidea__ is now known as littleidea21:55
jaypipesRyan_Lane: well, i need to go back to a stable/diablo (or 2012.2?) branch and see why there isn't any where clause being put on this query :(21:55
Ryan_Laneyeah. I'm really hoping this has been fixed in essex+. heh21:55
* mtaylor blames jaypipes21:55
*** EmilienM has joined #openstack-dev21:55
*** samkottler has quit IRC21:55
*** littleidea_ has quit IRC21:56
jaypipesRyan_Lane: well, I'm not sure whether the underlying query has been fixed (that's what I'm currently investigating), but I do know for sure that vishy and anotherjesse_zz added caching to the metadata handler in Essex, which speeds stuff up considerably (it essentially memoizes requests for an address' metdata21:56
* jaypipes git checkout's stable/diablo...21:56
vishyRyan_Lane: It does a bunch of db requests21:57
vishyRyan_Lane: there is probably one in there that gets all of them, maybe it is because the filter by ip is not done at the db layer?21:58
*** anniec has quit IRC21:58
Ryan_Laneseems that way21:58
vishyRyan_Lane: it could also be the weird mpi code we added that gets a list of all instances in the same security group21:58
vishy(if your instances all belong to the same tenant)21:59
Ryan_Lanethey are all in different tenants21:59
*** preilly has joined #openstack-dev21:59
*** gongys has quit IRC22:00
Devananda2Ryan_Lane, you may want to create a cron to purge old deleted records. We have had to do that...22:00
Ryan_LaneI'm more than happy to delete the old data22:00
*** dolphm has joined #openstack-dev22:00
Ryan_Lanebut it would be quite nice to have it work without that too :)22:00
Ryan_LaneDevananda2: can you give me the cron you use?22:01
vishyRyan_Lane: I'm sure it wouldn't be very hard to fix that issue22:01
*** galstrom has quit IRC22:02
*** dolphm has quit IRC22:02
*** EmilienM has quit IRC22:02
jaypipesRyan_Lane: the database really isn't that big, from what I can tell... it's more a problem with the query the ORM is making IMO.22:03
Ryan_Lanethat one query returns 391MB of data22:03
jaypipesRyan_Lane: just making sure .. you on 2012.2?22:03
Ryan_Lanethat much data going across the wire is going to take a while22:03
Ryan_Lanejaypipes: I'm running what was in the ppa, which isn't stable22:04
jaypipesRyan_Lane: which PPA?22:04
Ryan_Lanewell, it was the stable ppa22:04
Ryan_Lanewhich is different from the stable repo (hooray)22:04
jaypipesgah22:04
* Ryan_Lane is looking forward to ubuntu handling this22:04
Devananda2Ryan_Lane, I will check when I get home. Should be OK ....22:05
Ryan_LaneDevananda2: thanks22:05
Devananda2Actually, I should probably submit it upstream...22:05
Ryan_Laneoh, and the ppa was deleted :D22:06
*** danwent has joined #openstack-dev22:06
jaypipesRyan_Lane: I'm going to go with 2012.2 then...22:06
Ryan_Lanelikely similar enough22:06
jaypipesRyan_Lane: which is the second point release on diablo22:06
*** anderstj has joined #openstack-dev22:06
*** galstrom has joined #openstack-dev22:06
Ryan_Laneyep22:07
*** anniec has joined #openstack-dev22:08
Devananda2Vishy, any thoughts on me adding a database event to purge old deleted records?22:08
jaypipesRyan_Lane: could something be requesting metadata without an address?22:09
*** dolphm has joined #openstack-dev22:09
Ryan_LaneI'm not seeing how22:09
*** anderstj has quit IRC22:10
zykes-vishy: can you give a clue on why snapshots fail ? Seems to be hanging on vgscan something22:10
*** anderstj has joined #openstack-dev22:10
*** gongys has joined #openstack-dev22:11
*** galstrom has quit IRC22:12
Ryan_Lanemy coworkers, going through the code, mention this is likely fixed in newer versions, so the cron job will get me through till we uograde22:12
Ryan_Lane*upgrade22:12
*** littleidea_ has joined #openstack-dev22:15
jaypipesRyan_Lane: holy shit, I just figured out the source of the bad query...22:17
Ryan_Laneoh?22:17
jaypipesRyan_Lane: https://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L130622:18
jaypipesRyan_Lane: fixed_ip is not listed in exact match filters, and so the entire set of instances + IP addresses for each is returned, then ...22:18
jaypipeshttps://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L122722:19
jaypipesThat ^^ is run against that whole set of records :(22:19
*** jtran has quit IRC22:19
jaypipesRyan_Lane: all so that (I think!) things like 127.0.* can be used in the query?22:19
*** Devananda2 has quit IRC22:20
*** maoy has quit IRC22:20
*** littleidea has quit IRC22:20
*** littleidea_ is now known as littleidea22:20
jaypipesRyan_Lane: if I submit a patch up to Gerrit stable/diablo, you think you can pull it and test it out?22:20
Ryan_Laneyep22:20
*** jakedahn_ is now known as jakedahn_zz22:21
jaypipesRyan_Lane: k, gimme about an hour. FYI, AT&T is dealing with this exact same slowdown right now and it's causing major headaches...22:21
Ryan_Lane:D22:21
Ryan_Lanegreat. thanks.22:21
jaypipesnp22:22
*** sulochan_ has quit IRC22:22
*** kbringard has quit IRC22:24
preillyjaypipes: what is your proposed patch?22:24
*** mnewby has quit IRC22:24
jaypipespreilly: I'm currently working on it.22:25
*** Ryan_Lane has quit IRC22:25
*** preilly_ has joined #openstack-dev22:25
*** preilly_ has joined #openstack-dev22:25
*** Ryan_Lane has joined #openstack-dev22:25
*** datsun180b has quit IRC22:28
*** sacharya has joined #openstack-dev22:28
*** preilly has quit IRC22:29
*** preilly_ is now known as preilly22:29
*** eglynn has quit IRC22:31
devanandajaypipes: if i'm reading this correctly, the same potential issue is present in trunk. Even though the instance_get_all_by_filters function has been refactored, ip still is not in exact_match_filter_names, soo....22:32
jaypipesdevananda: yes.22:32
jaypipesdevananda: I'm going to see if it works for Ryan_Lane and if it does propose to trunk22:33
devanandagreat22:33
*** mnewby has joined #openstack-dev22:40
*** blamar has quit IRC22:42
*** jakedahn_zz is now known as jakedahn22:42
*** dachary has joined #openstack-dev22:47
*** halfss has joined #openstack-dev22:47
*** markmcclain has quit IRC22:49
*** pixelbeat has quit IRC22:51
*** spiffxp has quit IRC22:58
preillyjaypipes: how's the patch coming along?22:58
* preilly wants to try it ASAP22:59
* preilly works with Ryan btw22:59
jaypipespreilly: about 70% done.22:59
preillyjaypipes: okay cool22:59
preillyjaypipes: thanks for the update22:59
Ryan_Lanewe're all walking through the code right now. heh22:59
*** dtroyer is now known as dtroyer_zzz23:00
*** mnewby has quit IRC23:02
*** mnewby has joined #openstack-dev23:02
*** jog0 has joined #openstack-dev23:03
*** jtran has joined #openstack-dev23:03
jog0vishy: ping23:03
vishyjog0: heyo23:03
*** jog0_ has joined #openstack-dev23:04
*** jog0 has quit IRC23:04
*** jog0_ is now known as jog023:04
*** edygarcia has quit IRC23:05
jog0how is the force_hosts an admin only option?23:05
*** mnewby has quit IRC23:06
vishyjog0: 474         if context.is_admin and forced_host:23:06
vishyjog0: also it circumvents filters, so it allows an admin to force a host that otherwise wouldn't pass filters23:06
*** kpavel has joined #openstack-dev23:07
jog0ahh I see.23:07
jog0I will abandon my patch.  I only proposed it because of your NOTE  on line 29823:08
jog0but there is nothing that can fully replace this ATM23:08
vishyjog0: thanks :) I think the forced host comment still applies23:12
vishyjog0: s/comment/code23:12
vishyjog0: it is just ugly to pull the parameter out of availability zone23:12
devanandavishy, jaypipes: for the archiving/purging of old records (what Ryan_Lane was asking about while I was at lunch), we've got an EVENT that does this23:13
devanandaright now, it archives instead of deletes, but it could just as well delete things23:13
*** kpavel has quit IRC23:13
*** jog0 has quit IRC23:14
Ryan_Lanearchives is fine too23:14
devanandahow do you guys feel about that, and what's the right place to create an EVENT from (ideally, somehwere that can interpret options such as the prune-age)?23:14
*** spiffxp has joined #openstack-dev23:16
*** jog0 has joined #openstack-dev23:17
*** jtran has quit IRC23:18
*** preilly has left #openstack-dev23:19
*** s0mik has quit IRC23:19
jaypipesRyan_Lane: OK: https://github.com/jaypipes/nova/commit/31667a8ecb6554e35edfab6ec93067cca5fc24ff23:20
*** jtran has joined #openstack-dev23:20
*** preilly has joined #openstack-dev23:20
jaypipesRyan_Lane: unfortunately, I haven't been able to run tests locally because run_tests.sh -N bombs on the damn database migrations for some reason in the stable/diablo checkout.23:20
Ryan_Laneheh23:20
jaypipesRyan_Lane: perhaps you could give the commit a look over and maybe patch it in and test?23:21
Ryan_Lanesure23:21
jaypipesRyan_Lane: really sorry about that :(23:21
Ryan_Laneit's cool. thanks for the patch23:21
jaypipesRyan_Lane: tried getting the tests to run but it was one thing after another with old dependencies needed23:21
*** dachary has quit IRC23:22
*** s0mik has joined #openstack-dev23:23
*** novas0x2a|laptop has quit IRC23:27
*** issackelly has quit IRC23:31
*** anniec has quit IRC23:32
*** anderstj has quit IRC23:34
preillyjaypipes: You're missing a closing parentheses in query = query.filter((models.VirtualInterface.address == address)23:35
jaypipespreilly: dang. thank you. one sec.23:35
*** dachary has joined #openstack-dev23:35
Ryan_Lanejaypipes: heh23:36
Ryan_Laneso....23:36
Ryan_LaneI think this is looking in the wrong spot23:36
jaypipesRyan_Lane: how so?23:36
*** nati_uen_ has left #openstack-dev23:37
*** dtroyer_zzz is now known as dtroyer23:37
Ryan_LaneWHERE virtual_interfaces.address = '10.4.0.35'23:38
jaypipesRyan_Lane: that is definitely what is producing that monster query with no WHERE clause...23:38
jaypipesRyan_Lane: ah, I see... so it's the wrong filter.23:38
*** anniec has joined #openstack-dev23:38
jaypipesRyan_Lane: needs to be on the floating and fixed ip address field?23:38
Ryan_Laneyep23:38
jaypipesRyan_Lane: k. thought that might be the case, but figured I'd go simple first...23:39
jaypipesRyan_Lane: k, will work further and push in a bit.23:39
Ryan_Laneok23:39
*** anniec_ has joined #openstack-dev23:40
*** anniec has quit IRC23:41
*** anniec_ is now known as anniec23:41
*** dolphm has quit IRC23:41
*** rkukura has quit IRC23:45
*** rkukura has joined #openstack-dev23:45
*** jakedahn is now known as jakedahn_zz23:47
vishythe vid address is a mac23:48
vishy* vif23:48
vishyyou need virtual_interfaces -> fixed_ips -> address23:48
vishyjaypipes, Ryan_Lane ^^23:49
* Ryan_Lane nods23:49
*** e1mer has joined #openstack-dev23:49
*** jog0 has quit IRC23:50
jaypipesvishy: yeah, figured that out :)23:50
*** mnewby has joined #openstack-dev23:51
vishyis the query still there in trunk? it does: 194     fixed_ip = network.API().get_fixed_ip_by_address(ctxt, address)23:51
vishyfollowed by: instance = db.instance_get(ctxt, fixed_ip['instance_id'])23:51
Ryan_Lanethat seems like a sane way of going about that23:51
vishyjaypipes, Ryan_Lane: or is it a later query that is doing it without the join?23:52
jaypipesvishy: it's because the IP is not used in the exact match filters... a regex is used across the entire crossjoin of instances + floating IPs + fixed IPs23:52
jaypipesvishy: what's wrong with just joining fixed_ips to instances directly via fixed_ips.instance_id?23:54
*** mnewby has quit IRC23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!