*** Aaton is now known as Aaton_off | 00:01 | |
*** halfss has joined #openstack-dev | 00:03 | |
ewindisch | Love to get a review on https://review.openstack.org/#/c/9805/ (os-common) | 00:03 |
---|---|---|
*** spiffxp has quit IRC | 00:11 | |
*** mnaser has quit IRC | 00:19 | |
*** samkottler has joined #openstack-dev | 00:31 | |
*** halfss has quit IRC | 00:32 | |
*** PotHix has quit IRC | 00:32 | |
*** rkukura has joined #openstack-dev | 00:32 | |
*** sacharya has quit IRC | 00:32 | |
*** dtroyer is now known as dtroyer_zzz | 00:35 | |
*** mokas has quit IRC | 00:36 | |
*** galstrom has joined #openstack-dev | 00:38 | |
*** dtroyer_zzz is now known as dtroyer | 00:38 | |
*** nati_uen_ has joined #openstack-dev | 00:45 | |
*** nati_uen_ has quit IRC | 00:47 | |
*** nati_uen_ has joined #openstack-dev | 00:48 | |
*** nati_ueno has joined #openstack-dev | 00:50 | |
*** nati_uen_ has quit IRC | 00:53 | |
*** galstrom has quit IRC | 00:57 | |
*** edygarcia has joined #openstack-dev | 00:57 | |
*** mnewby has quit IRC | 00:58 | |
*** halfss has joined #openstack-dev | 01:02 | |
*** andrewbogott has quit IRC | 01:02 | |
*** thingee_zz has joined #openstack-dev | 01:03 | |
*** samkottler has quit IRC | 01:06 | |
*** thingee has quit IRC | 01:07 | |
*** littleidea has joined #openstack-dev | 01:08 | |
*** Ryan_Lane has quit IRC | 01:10 | |
*** galstrom has joined #openstack-dev | 01:12 | |
*** epim has joined #openstack-dev | 01:13 | |
*** andrewsmedina has joined #openstack-dev | 01:19 | |
*** danwent has quit IRC | 01:23 | |
*** thingee_zz is now known as thingee | 01:24 | |
*** danwent has joined #openstack-dev | 01:24 | |
*** novas0x2a|laptop has quit IRC | 01:25 | |
*** danwent has quit IRC | 01:26 | |
*** dachary has quit IRC | 01:29 | |
*** dachary has joined #openstack-dev | 01:30 | |
*** Ruetobas has quit IRC | 01:31 | |
*** Aaton_off is now known as Aaton | 01:31 | |
*** primeministerp has quit IRC | 01:32 | |
*** jgriffith has quit IRC | 01:32 | |
*** jgriffith has joined #openstack-dev | 01:32 | |
*** jgriffith is now known as Guest21283 | 01:32 | |
*** zul has quit IRC | 01:33 | |
*** primemin1sterp has joined #openstack-dev | 01:33 | |
*** zul has joined #openstack-dev | 01:34 | |
*** thingee has quit IRC | 01:34 | |
*** cmagina has quit IRC | 01:36 | |
*** BLZbubba has quit IRC | 01:36 | |
*** justinsb_ has quit IRC | 01:37 | |
*** cmagina has joined #openstack-dev | 01:37 | |
*** justinsb has joined #openstack-dev | 01:38 | |
*** Drakiz has quit IRC | 01:38 | |
*** Drakiz_ has joined #openstack-dev | 01:38 | |
*** uvirtbot has quit IRC | 01:39 | |
*** uvirtbot has joined #openstack-dev | 01:40 | |
*** Ruetobas has joined #openstack-dev | 01:40 | |
*** Daviey has quit IRC | 01:41 | |
*** akscram has quit IRC | 01:41 | |
*** rturk has quit IRC | 01:41 | |
*** _val_ has quit IRC | 01:41 | |
*** _0x44 has quit IRC | 01:41 | |
*** oneiroi has quit IRC | 01:41 | |
*** errr has quit IRC | 01:41 | |
*** Guest63158 has quit IRC | 01:41 | |
*** jpeeler has quit IRC | 01:41 | |
*** halfss has quit IRC | 01:41 | |
bcwaldon | jeblair: interesting failure to look into tomorrow https://jenkins.openstack.org/job/gate-python-glanceclient-merge/217/consoleFull | 01:41 |
*** BLZbubba has joined #openstack-dev | 01:42 | |
*** dachary has quit IRC | 01:45 | |
*** dolphm has joined #openstack-dev | 01:45 | |
*** oneiroi has joined #openstack-dev | 01:45 | |
*** Daviey has joined #openstack-dev | 01:45 | |
*** akscram has joined #openstack-dev | 01:45 | |
*** rturk has joined #openstack-dev | 01:45 | |
*** _val_ has joined #openstack-dev | 01:45 | |
*** _0x44 has joined #openstack-dev | 01:45 | |
*** jpeeler has joined #openstack-dev | 01:45 | |
*** errr has joined #openstack-dev | 01:45 | |
*** Guest63158 has joined #openstack-dev | 01:45 | |
*** dachary has joined #openstack-dev | 01:46 | |
*** Daviey has quit IRC | 01:46 | |
*** mokas has joined #openstack-dev | 01:48 | |
*** salv-orlando has quit IRC | 01:53 | |
*** Daviey has joined #openstack-dev | 01:57 | |
*** jdurgin has quit IRC | 01:58 | |
*** dolphm has quit IRC | 01:58 | |
jeblair | bcwaldon: turns out there's nothing to prevent you from configuring two slaves in jenkins that point to the same ip address. precise9 and precise10 were actually both running on precise9. sorry about that. | 02:00 |
*** primemin1sterp has quit IRC | 02:00 | |
*** gongys has joined #openstack-dev | 02:01 | |
*** primeministerp has joined #openstack-dev | 02:03 | |
*** mokas has quit IRC | 02:04 | |
*** primeministerp has quit IRC | 02:05 | |
*** mokas has joined #openstack-dev | 02:06 | |
*** pixelbeat has quit IRC | 02:07 | |
*** primeministerp has joined #openstack-dev | 02:08 | |
*** andrewbogott has joined #openstack-dev | 02:08 | |
*** andrewbogott has joined #openstack-dev | 02:08 | |
*** andrewbogott has quit IRC | 02:09 | |
*** salv-orlando has joined #openstack-dev | 02:11 | |
*** anniec has quit IRC | 02:12 | |
*** tgall_foo has joined #openstack-dev | 02:18 | |
*** tgall_foo has joined #openstack-dev | 02:18 | |
*** Aaton is now known as Aaton_off | 02:23 | |
*** galstrom has quit IRC | 02:24 | |
*** rods has quit IRC | 02:35 | |
*** galstrom has joined #openstack-dev | 02:38 | |
*** salv-orlando has left #openstack-dev | 02:38 | |
*** troytoman-away is now known as troytoman | 02:45 | |
*** halfss has joined #openstack-dev | 02:57 | |
*** edygarcia has quit IRC | 03:02 | |
*** edygarcia has joined #openstack-dev | 03:03 | |
*** edygarcia has quit IRC | 03:05 | |
*** halfss has quit IRC | 03:08 | |
*** Guest__ is now known as roge | 03:15 | |
*** mjfork has quit IRC | 03:15 | |
*** edygarcia has joined #openstack-dev | 03:17 | |
*** littleidea has quit IRC | 03:19 | |
*** edygarcia has quit IRC | 03:28 | |
bcwaldon | jeblair: no worries, just thought you might want to nail that down | 03:29 |
bcwaldon | jeblair: thanks! | 03:29 |
*** gongys has quit IRC | 03:32 | |
*** Adri2000 has quit IRC | 03:33 | |
*** Adri2000 has joined #openstack-dev | 03:33 | |
*** edygarcia has joined #openstack-dev | 03:42 | |
*** Guest21283 has quit IRC | 03:53 | |
*** edygarcia has quit IRC | 03:54 | |
*** jgriffith has joined #openstack-dev | 04:00 | |
*** nati_ueno has quit IRC | 04:01 | |
*** edygarcia has joined #openstack-dev | 04:01 | |
*** edygarcia has quit IRC | 04:05 | |
*** halfss has joined #openstack-dev | 04:10 | |
*** littleidea has joined #openstack-dev | 04:11 | |
*** edygarcia has joined #openstack-dev | 04:12 | |
*** tserong has quit IRC | 04:12 | |
*** tserong has joined #openstack-dev | 04:13 | |
*** tserong has joined #openstack-dev | 04:13 | |
*** renier has quit IRC | 04:13 | |
*** edygarcia has quit IRC | 04:13 | |
*** steveb_ has quit IRC | 04:13 | |
*** galstrom has quit IRC | 04:14 | |
*** renier has joined #openstack-dev | 04:15 | |
*** roge has quit IRC | 04:16 | |
*** renier has quit IRC | 04:16 | |
*** renier has joined #openstack-dev | 04:16 | |
*** edygarcia has joined #openstack-dev | 04:16 | |
*** edygarcia has quit IRC | 04:20 | |
*** dtroyer is now known as dtroyer_zzz | 04:24 | |
*** halfss has quit IRC | 04:24 | |
*** jtran has joined #openstack-dev | 04:24 | |
*** mokas has quit IRC | 04:28 | |
*** halfss has joined #openstack-dev | 04:28 | |
*** jtran has quit IRC | 04:29 | |
*** tgall_foo has quit IRC | 04:29 | |
*** steveb_ has joined #openstack-dev | 04:31 | |
*** halfss has quit IRC | 04:38 | |
*** jtran has joined #openstack-dev | 04:40 | |
*** anniec has joined #openstack-dev | 04:46 | |
*** Ryan_Lane has joined #openstack-dev | 04:46 | |
*** sacharya has joined #openstack-dev | 04:51 | |
*** anniec has quit IRC | 04:57 | |
*** anniec has joined #openstack-dev | 04:57 | |
*** nati_ueno has joined #openstack-dev | 04:57 | |
*** mokas has joined #openstack-dev | 05:11 | |
*** anderstj has joined #openstack-dev | 05:12 | |
*** steveb_ has quit IRC | 05:15 | |
*** jtran has quit IRC | 05:16 | |
*** Aaton_off is now known as Aaton | 05:20 | |
*** jtran has joined #openstack-dev | 05:24 | |
*** troytoman is now known as troytoman-away | 05:25 | |
*** davidha has quit IRC | 05:26 | |
*** garyk has quit IRC | 05:27 | |
*** nati_ueno has joined #openstack-dev | 05:31 | |
*** sacharya has quit IRC | 05:47 | |
*** nati_ueno has quit IRC | 05:49 | |
*** nati_ueno has joined #openstack-dev | 05:50 | |
*** jakedahn is now known as jakedahn_zz | 05:51 | |
*** rohitk has joined #openstack-dev | 05:53 | |
*** garyk has joined #openstack-dev | 06:05 | |
*** anderstj has quit IRC | 06:07 | |
*** GheRivero has joined #openstack-dev | 06:08 | |
*** mindpixel has joined #openstack-dev | 06:10 | |
*** armaan has joined #openstack-dev | 06:13 | |
*** eglynn has joined #openstack-dev | 06:17 | |
*** eafonichev has quit IRC | 06:22 | |
*** mrunge has joined #openstack-dev | 06:30 | |
*** littleidea has quit IRC | 06:37 | |
*** nati_uen_ has joined #openstack-dev | 06:37 | |
*** nati_uen_ has quit IRC | 06:38 | |
*** nati_uen_ has joined #openstack-dev | 06:38 | |
*** eafonichev has joined #openstack-dev | 06:40 | |
*** nati_ueno has quit IRC | 06:41 | |
*** dachary has quit IRC | 06:42 | |
*** Aaton is now known as Aaton_off | 06:45 | |
*** dachary has joined #openstack-dev | 06:45 | |
*** armaan has quit IRC | 06:46 | |
*** Aaton_off is now known as Aaton | 06:52 | |
*** nati_uen_ has quit IRC | 06:54 | |
*** davidha has joined #openstack-dev | 07:01 | |
*** erikzaadi has joined #openstack-dev | 07:02 | |
*** aswadrangnekar has joined #openstack-dev | 07:03 | |
*** davidha has quit IRC | 07:19 | |
*** davidha has joined #openstack-dev | 07:20 | |
*** reidrac has joined #openstack-dev | 07:20 | |
*** tserong has quit IRC | 07:32 | |
*** pixelbeat has joined #openstack-dev | 07:35 | |
*** winston-d has joined #openstack-dev | 07:38 | |
winston-d | jgriffith, ping | 07:39 |
*** heyho has joined #openstack-dev | 07:45 | |
GheRivero | morning peopel | 07:46 |
*** Mandell_ has joined #openstack-dev | 08:01 | |
*** Mandell has quit IRC | 08:01 | |
*** derekh has joined #openstack-dev | 08:02 | |
*** Mandell_ has quit IRC | 08:05 | |
*** jtran has quit IRC | 08:05 | |
*** erikzaadi has joined #openstack-dev | 08:06 | |
*** markmc has joined #openstack-dev | 08:07 | |
*** dachary has quit IRC | 08:09 | |
*** davidha1 has joined #openstack-dev | 08:10 | |
*** davidha has quit IRC | 08:11 | |
*** jakedahn_zz is now known as jakedahn | 08:21 | |
*** darraghb has joined #openstack-dev | 08:26 | |
*** Aaton is now known as Aaton_off | 08:32 | |
*** Aaton_off is now known as Aaton | 08:34 | |
*** davidha has joined #openstack-dev | 08:35 | |
*** davidha1 has quit IRC | 08:35 | |
*** sulochan has joined #openstack-dev | 08:52 | |
*** tserong has joined #openstack-dev | 08:53 | |
*** davidha1 has joined #openstack-dev | 08:53 | |
*** davidha has quit IRC | 08:54 | |
*** jakedahn is now known as jakedahn_zz | 09:04 | |
*** hugokuo1 has quit IRC | 09:06 | |
*** mokas has quit IRC | 09:06 | |
*** Aaton is now known as Aaton_off | 09:09 | |
*** hugokuo has joined #openstack-dev | 09:10 | |
*** winston-d has quit IRC | 09:14 | |
*** danpb has joined #openstack-dev | 09:15 | |
zykes- | why isn't paginate_query in use in glance ? | 09:20 |
zykes- | nvm | 09:26 |
*** dolphm has joined #openstack-dev | 09:32 | |
*** asalkeld has quit IRC | 09:36 | |
*** maploin has joined #openstack-dev | 09:37 | |
*** maploin has quit IRC | 09:37 | |
*** maploin has joined #openstack-dev | 09:37 | |
*** dolphm has quit IRC | 09:41 | |
*** kpavel has joined #openstack-dev | 09:51 | |
*** rohitk has quit IRC | 10:03 | |
*** rods has joined #openstack-dev | 10:09 | |
*** erikzaadi has quit IRC | 10:17 | |
*** davidha has joined #openstack-dev | 10:23 | |
*** davidha1 has quit IRC | 10:23 | |
markmc | danpb, what's the canonical reference for your commit messages essay? | 10:29 |
*** dachary has joined #openstack-dev | 10:33 | |
danpb | markmc: the mailing list for now - still on my TODO to transfer it to the wiki | 10:40 |
markmc | danpb, ok, thanks | 10:40 |
markmc | danpb, you'll add a link in HACKING.rst too? | 10:40 |
danpb | yeah eventually | 10:41 |
*** halfss has joined #openstack-dev | 10:42 | |
*** dolphm has joined #openstack-dev | 10:53 | |
*** vanchester has joined #openstack-dev | 11:00 | |
*** hugokuo1 has joined #openstack-dev | 11:01 | |
*** vanchester1 has joined #openstack-dev | 11:04 | |
*** vanchester has quit IRC | 11:04 | |
*** hugokuo has quit IRC | 11:04 | |
*** dachary has quit IRC | 11:06 | |
*** asalkeld has joined #openstack-dev | 11:08 | |
*** davidha1 has joined #openstack-dev | 11:11 | |
*** davidha has quit IRC | 11:12 | |
*** halfss has quit IRC | 11:12 | |
*** dolphm_ has joined #openstack-dev | 11:12 | |
*** dolphm has quit IRC | 11:14 | |
*** mjfork has joined #openstack-dev | 11:21 | |
*** dolphm_ has quit IRC | 11:38 | |
Daviey | markmc: some nice catches on 9534 | 11:44 |
*** aswadrangnekar has quit IRC | 12:02 | |
*** aswadrangnekar has joined #openstack-dev | 12:04 | |
*** markvoelker has joined #openstack-dev | 12:05 | |
*** dolphm has joined #openstack-dev | 12:09 | |
*** mrunge has quit IRC | 12:13 | |
*** salgado has joined #openstack-dev | 12:17 | |
*** sandywalsh has joined #openstack-dev | 12:17 | |
*** littleidea has joined #openstack-dev | 12:22 | |
*** heyho has quit IRC | 12:27 | |
*** roge has joined #openstack-dev | 12:38 | |
*** lts has joined #openstack-dev | 12:47 | |
*** jaypipes has quit IRC | 12:48 | |
*** andrewsmedina has quit IRC | 12:48 | |
vanchester1 | Hello everyone. Where can i find identity API v1 docs? | 12:49 |
dolphm | vanchester1: http://docs.rackspace.com/api/ | 12:49 |
vanchester1 | dolphm, oh, thanks! Didn't thought about it. | 12:50 |
vanchester1 | so API v1.0 is tempauth, isn't it? | 12:53 |
*** matiu has quit IRC | 12:54 | |
*** matiu has joined #openstack-dev | 12:54 | |
*** dprince has joined #openstack-dev | 12:56 | |
*** dachary has joined #openstack-dev | 12:59 | |
*** chrisfer has joined #openstack-dev | 13:00 | |
*** m4xmr has joined #openstack-dev | 13:01 | |
*** rpedde is now known as rpedde_away | 13:02 | |
*** rpedde_away is now known as rpedde | 13:02 | |
*** halfss has joined #openstack-dev | 13:08 | |
*** jaypipes has joined #openstack-dev | 13:16 | |
*** tgall_foo has joined #openstack-dev | 13:18 | |
*** tgall_foo has joined #openstack-dev | 13:18 | |
*** heyho has joined #openstack-dev | 13:19 | |
*** EmilienM has quit IRC | 13:21 | |
*** andrewsmedina has joined #openstack-dev | 13:21 | |
*** EmilienM has joined #openstack-dev | 13:22 | |
*** eglynn_ has joined #openstack-dev | 13:26 | |
*** eglynn has quit IRC | 13:29 | |
*** GheRivero_ has joined #openstack-dev | 13:34 | |
*** edygarcia has joined #openstack-dev | 13:39 | |
*** sacharya has joined #openstack-dev | 13:40 | |
*** markmcclain has joined #openstack-dev | 13:40 | |
*** dtroyer_zzz is now known as dtroyer | 13:44 | |
*** andrewbogott has joined #openstack-dev | 13:50 | |
*** samkottler has joined #openstack-dev | 13:52 | |
annegentle | vanchester1: I don't think v1 Identity docs are published to docs.openstack.org any more, but you could look at http://github.com/identity-api and examine the history to see. It is not the same as tempauth, tempauth is a swift mechanism to make auth easy for testing and only works with swift. | 13:54 |
*** mnewby has joined #openstack-dev | 14:00 | |
*** kbringard has joined #openstack-dev | 14:00 | |
zykes- | what's the use for glance to sort by created_at and then id when id isn't incremental ? | 14:02 |
*** davidha has joined #openstack-dev | 14:05 | |
dprince | zykes-: Glance used to use integer ID's. Those were replaced with UUID's eventually though. | 14:05 |
*** kpavel has quit IRC | 14:06 | |
*** davidha1 has quit IRC | 14:06 | |
dprince | zykes-: sounds like we have some old logic in the codebase for that sort clause. | 14:06 |
dprince | zykes-: where exactly are you looking? | 14:06 |
zykes- | https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/api.py#L333 | 14:07 |
zykes- | dprince: | 14:08 |
zykes- | how do you do pagination with uuid then ? | 14:08 |
*** armaan has joined #openstack-dev | 14:08 | |
dprince | zykes-: We are using markers. | 14:09 |
zykes- | that works with uuid ? | 14:10 |
*** dtroyer is now known as dtroyer_zzz | 14:10 | |
dolphm | zykes-: a client sorting by uuid is pretty much meaningless, but pagination by markers lets the server take care of the actual sorting, if any | 14:13 |
*** maoy has joined #openstack-dev | 14:13 | |
zykes- | dolphm: hmm k | 14:13 |
zykes- | but isn | 14:13 |
zykes- | isn't it using a uuid for something ? | 14:14 |
dprince | zykes-: I was missing some context though. I think ID is required because it is unique. The comments in that function explain it. | 14:14 |
zykes- | ok :) | 14:14 |
zykes- | so you pass the uuid of the previos image ? | 14:14 |
dprince | For marker, yes. | 14:15 |
*** armaan has quit IRC | 14:15 | |
*** armaan has joined #openstack-dev | 14:16 | |
zykes- | can it be numerical as wlel dprince ? | 14:17 |
*** davidha1 has joined #openstack-dev | 14:20 | |
*** davidha has quit IRC | 14:20 | |
*** thingee has joined #openstack-dev | 14:21 | |
*** dtroyer_zzz is now known as dtroyer | 14:23 | |
*** gongys has joined #openstack-dev | 14:24 | |
*** armaan has quit IRC | 14:25 | |
*** kpavel has joined #openstack-dev | 14:27 | |
*** armaan has joined #openstack-dev | 14:28 | |
markmc | eglynn_, there? | 14:29 |
markmc | eglynn_, seen e.g. #1021738 | 14:30 |
eglynn_ | markmc: yeap | 14:30 |
* eglynn_ looking ... | 14:30 | |
markmc | eglynn_, #1021738 | 14:30 |
markmc | eglynn_, sorry, #1021721 | 14:30 |
*** mokas has joined #openstack-dev | 14:30 | |
markmc | eglynn_, #1021748 | 14:31 |
*** cp16net is now known as cp16net|away | 14:32 | |
eglynn_ | markmc: hmmm, so looks like duplication on the similar bugs I was recently fixing | 14:33 |
markmc | eglynn_, yeah, and e.g. b0da2c4 does different from what you did AFAIR | 14:33 |
markmc | eglynn_, i.e. raises a 413 webob exception rather than a NovaException | 14:33 |
eglynn_ | markmc: yep https://review.openstack.org/#/c/9738/ changes the underlying exception type as opposed to rely on the mapping to occur in the FaultWrapper | 14:34 |
*** mokas has quit IRC | 14:35 | |
eglynn_ | markmc: from the stable/essex point of view, that wouldn't work as the NoMoreFloatingIps exception would be wrapped up in a RemoteError that could bubble all the ways up the FaultWrapper | 14:36 |
*** datsun180b has joined #openstack-dev | 14:37 | |
*** rnirmal has joined #openstack-dev | 14:37 | |
eglynn_ | markmc: (as the RPC exception deserialization logic post-dates stable/essex) | 14:37 |
markmc | eglynn_, I guess at this point I care more about everything on master doing things the same way | 14:37 |
markmc | eglynn_, no real opinion yet on what the more correct way is, though | 14:38 |
markmc | eglynn_, just thought I'd point them out | 14:38 |
eglynn_ | markmc: no cool, good spot, I'll link in the bugs appropriately ... | 14:38 |
Adri2000 | anyone knowing the nova (network) code could point me to the right direction for fixing bug #1013726 ? I've been trying different things for a few hours now without luck... https://bugs.launchpad.net/nova/+bug/1013726 | 14:39 |
uvirtbot | Launchpad bug 1013726 in nova "Essex upgrade doesn't ensure networks have uuid" [Medium,Confirmed] | 14:39 |
uvirtbot | Launchpad bug 1013726 in nova "Essex upgrade doesn't ensure networks have uuid" [Medium,Confirmed] https://launchpad.net/bugs/1013726 | 14:39 |
Adri2000 | basically the question is: where in the code could I add a check saying "if that/all network(s) doesn't/don't have an uuid, then generate one and add it to the database" | 14:40 |
markmc | eglynn_, ok, I'm filing a bug that the floating_ips extension should raise FloatingIpLimitExceeded | 14:41 |
markmc | eglynn_, oh, it does - but catches it | 14:42 |
eglynn_ | markmc: cool, assign it to me | 14:42 |
markmc | eglynn_, it should just avoid catching it then? | 14:42 |
eglynn_ | markmc: exactly | 14:42 |
markmc | eglynn_, cool | 14:42 |
*** armaan has left #openstack-dev | 14:43 | |
*** sacharya has quit IRC | 14:49 | |
*** gongys has quit IRC | 14:50 | |
*** cp16net|away is now known as cp16net | 14:50 | |
markmc | eglynn_, I've assigned bug #1021748 to you too since it's also in the security groups stuff you did: | 14:51 |
markmc | def raise_over_quota(msg): | 14:51 |
markmc | raise exc.HTTPBadRequest(explanation=msg) | 14:51 |
uvirtbot | Launchpad bug 1021748 in nova "Security Group Create and adding rule to it, is not raising proper error code for overlimit" [Undecided,Confirmed] https://launchpad.net/bugs/1021748 | 14:51 |
eglynn_ | markmc: cool, I'll take care of that ... | 14:51 |
markmc | eglynn_, excellent | 14:52 |
*** Aaton_off is now known as Aaton | 14:52 | |
*** davidha1 has quit IRC | 14:55 | |
*** danwent has joined #openstack-dev | 14:59 | |
*** salgado has quit IRC | 15:01 | |
chmouel | markmc: do you know if it's a known problem with openstack.common.log ? http://pastie.org/4278303 (openstack.common.log) | 15:01 |
bcwaldon | mtaylor: pbr+glance | 15:01 |
bcwaldon | mtaylor: you workinprogressed | 15:01 |
bcwaldon | mtaylor: then pushed | 15:01 |
bcwaldon | mtaylor: ready for review? | 15:01 |
*** salgado has joined #openstack-dev | 15:02 | |
*** salgado has joined #openstack-dev | 15:02 | |
*** datsun180b_ has joined #openstack-dev | 15:04 | |
jgriffith | winstond: pong | 15:05 |
*** datsun180b_ has joined #openstack-dev | 15:05 | |
andrewbogott | chmouel: I'm the one who moved logging and notifiers into common. That failure is new to me. | 15:05 |
*** rbasak has quit IRC | 15:05 | |
andrewbogott | chmouel: Is cinder using common notifier as well as common logging? | 15:06 |
*** datsun180b has quit IRC | 15:07 | |
*** datsun180b_ is now known as datsun180b | 15:07 | |
*** cdub_ has quit IRC | 15:08 | |
markmc | andrewbogott, see chmouel's draft here: https://review.openstack.org/#/c/9913/ | 15:08 |
mtaylor | bcwaldon: well, let's wait until it passes *@$%@ tests | 15:09 |
bcwaldon | mtaylor: kk | 15:09 |
*** andrewbogott_ has joined #openstack-dev | 15:10 | |
*** andrewbogott has quit IRC | 15:10 | |
*** andrewbogott_ is now known as andrewbogott | 15:10 | |
andrewbogott | markmc: Gerrit doesn't want me to see that page. | 15:10 |
markmc | andrewbogott, wise gerrit | 15:11 |
*** cdub_ has joined #openstack-dev | 15:11 | |
*** sstent has quit IRC | 15:11 | |
*** mindpixel has quit IRC | 15:12 | |
markmc | andrewbogott, https://github.com/markmc/cinder/commits/chmouel-common-logging | 15:13 |
*** garyk has quit IRC | 15:14 | |
zykes- | anyone know if rackerjoe is on irc ? | 15:15 |
*** sstent has joined #openstack-dev | 15:16 | |
andrewbogott | grrr, I hate how git regards a switch to common logging as a move+edit rather than as a remove and an add | 15:16 |
*** rbasak has joined #openstack-dev | 15:19 | |
*** arosen has quit IRC | 15:19 | |
andrewbogott | Well, maybe this is an actual bug. markmc, if I import 'notifier' and notifier is a directory with an __init__.py then I should be able to reference notifier.api later shouldn't I? | 15:20 |
andrewbogott | I fear I'm making some horrible noob python mistake here | 15:20 |
bcwaldon | eglynn_: ping | 15:20 |
eglynn_ | bcwaldon: hey | 15:20 |
bcwaldon | eglynn_: do you have a sec to talk about the refactor-db-layer bp? | 15:21 |
eglynn_ | bcwaldon: sure | 15:21 |
bcwaldon | eglynn_: I want to talk about what we want to get done within F-3 | 15:21 |
eglynn_ | bcwaldon: what's still un-done at this stage? | 15:21 |
bcwaldon | eglynn_: https://blueprints.launchpad.net/glance/+spec/refactor-db-layer | 15:21 |
bcwaldon | eglynn_: you noted some promotion to openstack-common | 15:21 |
bcwaldon | eglynn_: and alighment with Nova | 15:21 |
andrewbogott | chmouel: Does something like this help? http://pastebin.com/wiCRATbt | 15:22 |
bcwaldon | eglynn_: but I'm not really sure that is necessary at this stage | 15:22 |
bcwaldon | eglynn_: I would like to figure out our bootstrap process | 15:22 |
eglynn_ | bcwaldon: yep, I agree | 15:22 |
bcwaldon | eglynn_: I think we should just copy whatever nova does w.r.t. spin up and db creation | 15:22 |
bcwaldon | eglynn_: but we may already be doing that | 15:22 |
bcwaldon | eglynn_: I just dont know | 15:22 |
bcwaldon | eglynn_: would you agree that once that is done, the bp is done? | 15:23 |
eglynn_ | bcwaldon: I need to remind myself wrt. to the nova differences, I haven't looked at that code in a while | 15:23 |
bcwaldon | eglynn_: maybe dprince knows offhand | 15:23 |
*** sacharya has joined #openstack-dev | 15:23 | |
bcwaldon | eglynn_: I know he's dealt with it in the past | 15:23 |
bcwaldon | calling dprince ! | 15:23 |
eglynn_ | bcwaldon: but yes, that would be a reasonable endpoint for the bp | 15:23 |
vishy | markmc: nice job on the extensive cherry picks into cinder | 15:24 |
bcwaldon | eglynn_: ok, I'll clean up the bp definition to reflect tha | 15:24 |
bcwaldon | t | 15:24 |
*** reidrac has quit IRC | 15:24 | |
eglynn_ | bcwaldon: cool | 15:24 |
vishy | jgriffith: are you there? I think we should get all the common sync patches proposed by mark in | 15:24 |
markmc | vishy, thanks; there's plenty more, I was only looking at openstack-common related stuff | 15:24 |
jgriffith | vishy: Agreed, I was going to give one day for folks to review before just approving all of them | 15:24 |
jgriffith | vishy: That one day is up :) | 15:25 |
vishy | I just went through them all and there isn't anything obviously wrong as far as I can tell. | 15:25 |
jgriffith | vishy: Cool, I'll consider them all +1 form you then :) | 15:25 |
vishy | jgriffith: already +2d them all :) | 15:25 |
*** aswadrangnekar has left #openstack-dev | 15:25 | |
jgriffith | vishy: Well, there ya have it :) | 15:26 |
jgriffith | vishy: Thanks!!! | 15:26 |
vishy | jgriffith: you still have to approve them though :) | 15:27 |
jgriffith | vishy: Yep, doing it now | 15:27 |
jgriffith | markmc: The only one that needs looked at is https://review.openstack.org/#/c/9904/2 | 15:28 |
chmouel | andrewbogott: just catching up.. let me try | 15:28 |
*** sacharya1 has joined #openstack-dev | 15:29 | |
markmc | vishy, what needs doing with 9904? | 15:29 |
vishy | markmc, jgriffith: that looks like a suprious error to me | 15:29 |
*** sacharya has quit IRC | 15:30 | |
markmc | vishy, jgriffith, yeah a few of them failed like that | 15:30 |
vishy | just ran a reverify to check | 15:30 |
jgriffith | vishy: markmc: Agreed, there's a couple others | 15:30 |
chmouel | andrewbogott: needs a bit more digging that that | 15:30 |
vishy | markmc: don't know if you noticed while you were gone, but if you put a comment 'reverify' jenkins will check it again | 15:30 |
andrewbogott | chmouel: That results in the same failure? | 15:31 |
chmouel | andrewbogott: http://pastie.org/4278477 | 15:31 |
chmouel | andrewbogott: changed your import tho | 15:31 |
markmc | vishy, oh, thanks for the tip | 15:31 |
andrewbogott | chmouel: OK, to start I think what we need is a test in common that traverses that code. I thought there was one... | 15:32 |
bcwaldon | eglynn_: so the db code is different, but glance does match the same default behavior now | 15:32 |
andrewbogott | If you don't get to it first, I'll work on that in an hour or so. | 15:32 |
bcwaldon | eglynn_: I'm going to run through existing glance db bugs and see what we can do about those | 15:32 |
bcwaldon | eglynn_: then I'll close that db | 15:32 |
bcwaldon | eglynn_: close that bp* | 15:33 |
eglynn_ | bcwaldon: sounds reasonable! | 15:33 |
chmouel | andrewbogott: yeah, let me do some digging more seems weird with the way python does the import | 15:33 |
andrewbogott | Might just be that there's a circular import? | 15:34 |
*** spiffxp has joined #openstack-dev | 15:34 | |
chmouel | andrewbogott: i would expect python to bug us about it | 15:35 |
andrewbogott | me too | 15:35 |
*** spiffxp has quit IRC | 15:36 | |
*** arosen has joined #openstack-dev | 15:38 | |
*** Aaton is now known as Aaton_off | 15:41 | |
*** rkukura has quit IRC | 15:43 | |
*** rkukura has joined #openstack-dev | 15:44 | |
*** dachary has quit IRC | 15:44 | |
*** halfss has quit IRC | 15:46 | |
*** mokas has joined #openstack-dev | 15:47 | |
*** Aaton_off is now known as Aaton | 15:50 | |
*** salgado is now known as salgado-lunch | 15:51 | |
*** anderstj has joined #openstack-dev | 15:53 | |
*** spiffxp has joined #openstack-dev | 15:56 | |
*** sacharya1 has quit IRC | 15:57 | |
*** mokas has quit IRC | 15:58 | |
*** e1mer has quit IRC | 15:59 | |
*** anderstj has quit IRC | 15:59 | |
*** armaan has joined #openstack-dev | 16:00 | |
*** dachary has joined #openstack-dev | 16:02 | |
*** sandywalsh has quit IRC | 16:03 | |
*** sacharya has joined #openstack-dev | 16:04 | |
*** armaan has quit IRC | 16:05 | |
*** cp16net is now known as cp16net|away | 16:08 | |
*** littleidea_ has joined #openstack-dev | 16:08 | |
chmouel | andrewbogott: it's maybe because there is still a cinder/notifier/ in there | 16:08 |
chmouel | andrewbogott: but could not see where is the conflict | 16:09 |
andrewbogott | chmouel: I thought about that, but can't think why it would matter. | 16:09 |
andrewbogott | You should probably remove the cinder notifier as part of this patch anyway. | 16:09 |
chmouel | well I can do that but the patch is a bit big already | 16:09 |
chmouel | and it's a bit of chicken and egg problem which one comes first :) | 16:09 |
*** garyk has joined #openstack-dev | 16:09 | |
chmouel | I guess i need to start removing the notifier | 16:10 |
*** edygarcia_ has joined #openstack-dev | 16:10 | |
andrewbogott | I think when I did this in nova I moved the logging first, and hand-edited the common logging files to point at nova notifier | 16:11 |
andrewbogott | Then a second patch that moved the notifier and reverted the common logging file to their pristine state. | 16:11 |
*** cp16net|away is now known as cp16net | 16:11 | |
chmouel | yeah was going to go for that but not sure what was the policy for this if we are allow to handedit | 16:12 |
andrewbogott | But it may be that the same problem was present and there just wasn't a test that caught it. | 16:12 |
*** littleidea has quit IRC | 16:13 | |
*** littleidea_ is now known as littleidea | 16:13 | |
*** edygarcia has quit IRC | 16:14 | |
*** edygarcia_ is now known as edygarcia | 16:14 | |
*** Aaton is now known as Aaton_off | 16:15 | |
*** Mandell has joined #openstack-dev | 16:17 | |
*** mokas has joined #openstack-dev | 16:17 | |
*** jdurgin has joined #openstack-dev | 16:18 | |
*** nati_ueno has joined #openstack-dev | 16:19 | |
*** nati_ueno has quit IRC | 16:21 | |
*** nati_ueno has joined #openstack-dev | 16:22 | |
*** andrewbogott has quit IRC | 16:22 | |
*** jtran has joined #openstack-dev | 16:23 | |
*** Aaton_off is now known as Aaton | 16:23 | |
*** ayoung has quit IRC | 16:24 | |
*** Aaton is now known as Aaton_off | 16:28 | |
*** nati_ueno has quit IRC | 16:31 | |
chmouel | annegentle: so yeah will go for now using the cinder.notifer which make it pass and will see with removing it next | 16:35 |
*** anniec has quit IRC | 16:35 | |
*** danpb has quit IRC | 16:41 | |
*** dachary has quit IRC | 16:42 | |
*** maploin has quit IRC | 16:43 | |
*** issackelly has joined #openstack-dev | 16:45 | |
*** matwood has joined #openstack-dev | 16:45 | |
*** dachary has joined #openstack-dev | 16:48 | |
*** sacharya has quit IRC | 16:49 | |
*** dachary has quit IRC | 16:49 | |
timello | hey jaypipes! Thank you very much for the great review! Regarding your question... how possible is to have phased approach? I would like to get a point that even though the critical functions are not implemented... we can submit further patches in phases... My concern is to keep adding more code and make the review process slower and hard. | 16:50 |
jaypipes | timello: right, which is why I asked :) just wondering about your thoughts on where to "divide" the work up into phases. | 16:51 |
timello | jaypipes: does it sound possible? | 16:51 |
jaypipes | timello: I think first phase should be completing work on the most basic ops | 16:51 |
jaypipes | timello: for instance: | 16:51 |
jaypipes | spawn, list instances, stop | 16:51 |
jaypipes | timello: I think that's a good enough phase 1, no? | 16:51 |
timello | jaypipes: yeah, I agree. Ok. For the next review, I'll add those! | 16:52 |
*** m4xmr has quit IRC | 16:52 | |
jaypipes | timello: reviewers are going to want to see your roadmap for completing the driver, which is why I bring this up. we've been burned in the past with folks dumping a driver into nova and not maintaining it, so it's important to see a plan. | 16:52 |
jaypipes | timello: cool, sounds good! ping me if you have further questions on how to use stubout, BTW. it can be a bit obtuse when you start working with it. | 16:53 |
timello | jaypipes: the roadmap could be described in the code itself, somewhere? | 16:53 |
jaypipes | timello: a blueprint, please :) | 16:53 |
timello | Ok. | 16:53 |
jaypipes | timello: and then make sure you --amend you commit message to say "partially implements bp <BP_NAME> | 16:53 |
timello | jaypipes: got it. Thanks! | 16:54 |
jaypipes | timello: that way vishy can track your blueprint with inclusion into a milestone (likely in "Grizzly" release...) | 16:54 |
*** wdunn has quit IRC | 16:56 | |
bcwaldon | jaypipes: thoughts on https://review.openstack.org/#/c/9970/ ? | 16:56 |
*** sacharya has joined #openstack-dev | 16:56 | |
timello | jaypipes: Ok! | 16:57 |
*** andrewbogott has joined #openstack-dev | 16:57 | |
*** Ryan_Lane has quit IRC | 16:58 | |
jaypipes | bcwaldon: approved. | 16:59 |
*** dachary has joined #openstack-dev | 16:59 | |
*** galstrom has joined #openstack-dev | 17:00 | |
*** galstrom has quit IRC | 17:00 | |
bcwaldon | jaypipes: awesome, thank you sir | 17:01 |
*** galstrom has joined #openstack-dev | 17:01 | |
*** nati_ueno has joined #openstack-dev | 17:02 | |
bcwaldon | jeblair: seeing odd failures https://jenkins.openstack.org/job/gate-glance-merge/1354/consoleFull | 17:04 |
bcwaldon | jeblair: that job came from this review https://review.openstack.org/#/c/9970/ | 17:04 |
bcwaldon | jeblair: see it was reported as failure | 17:04 |
bcwaldon | on the review | 17:04 |
*** kpavel has quit IRC | 17:04 | |
bcwaldon | jeblair: seeing that kind of failure a lot | 17:05 |
jeblair | bcwaldon: the vote is correct, the message it left for the merge job is wrong.... | 17:05 |
bcwaldon | jeblair: ok | 17:05 |
jeblair | bcwaldon: i actually fixed the bug in the code about 40 minutes ago, but there are 92839487239842342 cinder changes in the queue right now, and i have to wait until they are done to restart. :( | 17:05 |
bcwaldon | ok | 17:06 |
bcwaldon | no problem | 17:06 |
bcwaldon | I can reverify later | 17:06 |
bcwaldon | if necessary | 17:06 |
jeblair | not necessary since the vote is correct | 17:06 |
bcwaldon | kk, cool | 17:06 |
jeblair | (there should be a gate job in the queue somewhere and assuming nothing has changed, that change should merge | 17:06 |
*** derekh has quit IRC | 17:08 | |
*** armaan has joined #openstack-dev | 17:08 | |
*** armaan has left #openstack-dev | 17:09 | |
*** nati_uen_ has joined #openstack-dev | 17:09 | |
*** mokas has quit IRC | 17:10 | |
*** nati_ueno has quit IRC | 17:12 | |
*** mokas has joined #openstack-dev | 17:14 | |
*** littleidea_ has joined #openstack-dev | 17:15 | |
*** littleidea has quit IRC | 17:16 | |
*** littleidea_ is now known as littleidea | 17:16 | |
jgriffith | jeblair: You exagerate, it's only 92839487239842341 ! | 17:16 |
*** littleidea has joined #openstack-dev | 17:16 | |
eglynn_ | mtaylor, jeblair: looks like a /home/jenkins/workspace/gate-nova-merge/.git/refs/remotes/origin/master.lock file may need to be manually blown away on a Jenkins slave | 17:16 |
eglynn_ | mtaylor, jeblair: see https://jenkins.openstack.org/job/gate-nova-merge/4876/consoleFull | 17:16 |
*** lcheng has quit IRC | 17:17 | |
jeblair | eglynn_: looking | 17:18 |
*** PotHix has joined #openstack-dev | 17:19 | |
*** dachary has quit IRC | 17:20 | |
*** dachary has joined #openstack-dev | 17:20 | |
*** primeministerp has quit IRC | 17:21 | |
jeblair | eglynn_: thanks. it was a slave misconfiguration, i'll correct it as soon as the currently running job finishes | 17:21 |
eglynn_ | jeblair: cool, thanks! | 17:21 |
*** salgado-lunch is now known as salgado | 17:24 | |
*** sandywalsh has joined #openstack-dev | 17:25 | |
*** matwood has quit IRC | 17:26 | |
*** zaitcev has joined #openstack-dev | 17:27 | |
*** anderstj has joined #openstack-dev | 17:29 | |
andrewbogott | chmouel: Just got your review request; were you able to hammer out that test failure? | 17:29 |
chmouel | yeah | 17:30 |
andrewbogott | Git makes it pretty hard to read the log.py part of the patch. Is the notifier import the only part you edited? | 17:31 |
*** wdunn has joined #openstack-dev | 17:32 | |
chmouel | yeah that's it | 17:32 |
chmouel | changed the notify | 17:32 |
chmouel | i.e removing None argument since the notifer from cinder doesn't have a context | 17:33 |
*** anniec has joined #openstack-dev | 17:33 | |
chmouel | still the import problem we had is weird and that's just workaround | 17:34 |
chmouel | maybe that's what __path__ is useful for | 17:34 |
*** darraghb has quit IRC | 17:35 | |
*** dachary has quit IRC | 17:36 | |
*** ayoung has joined #openstack-dev | 17:37 | |
*** jshepher has joined #openstack-dev | 17:38 | |
*** dachary has joined #openstack-dev | 17:40 | |
*** galstrom has quit IRC | 17:42 | |
*** jshepher is now known as galstrom | 17:42 | |
*** GheRivero has quit IRC | 17:42 | |
*** GheRivero_ is now known as GheRivero | 17:42 | |
*** dachary has quit IRC | 17:44 | |
*** rafaduran has joined #openstack-dev | 17:45 | |
*** Ryan_Lane has joined #openstack-dev | 17:50 | |
*** vanchester1 has quit IRC | 17:50 | |
*** salgado has quit IRC | 17:50 | |
*** Mandell_ has joined #openstack-dev | 17:50 | |
*** Mandell has quit IRC | 17:53 | |
*** ayoung has quit IRC | 17:58 | |
*** matwood has joined #openstack-dev | 18:00 | |
*** anderstj has quit IRC | 18:00 | |
*** anniec_ has joined #openstack-dev | 18:01 | |
*** anniec_ has quit IRC | 18:02 | |
*** anniec has quit IRC | 18:02 | |
*** dachary has joined #openstack-dev | 18:02 | |
*** otter2 has joined #openstack-dev | 18:02 | |
*** anniec has joined #openstack-dev | 18:03 | |
*** anniec has quit IRC | 18:04 | |
*** otter1 has quit IRC | 18:04 | |
*** anniec has joined #openstack-dev | 18:05 | |
*** jakedahn_zz is now known as jakedahn | 18:06 | |
*** dachary1 has joined #openstack-dev | 18:09 | |
*** GheRivero has quit IRC | 18:09 | |
*** dachary has quit IRC | 18:10 | |
*** salgado has joined #openstack-dev | 18:12 | |
*** salgado has joined #openstack-dev | 18:12 | |
*** mdomsch has joined #openstack-dev | 18:16 | |
dansmith | vishy: how come we use context.elevated() in reboot_instance() but not, say, start_instance()? | 18:17 |
*** dachary1 has quit IRC | 18:22 | |
*** dachary has joined #openstack-dev | 18:22 | |
*** matwood has quit IRC | 18:23 | |
*** galstrom has quit IRC | 18:25 | |
*** galstrom has joined #openstack-dev | 18:25 | |
*** mokas has quit IRC | 18:26 | |
*** jshepher has joined #openstack-dev | 18:27 | |
*** dachary has quit IRC | 18:27 | |
*** eglynn__ has joined #openstack-dev | 18:29 | |
*** eglynn_ has quit IRC | 18:30 | |
*** galstrom has quit IRC | 18:31 | |
*** jshepher is now known as galstrom | 18:31 | |
*** jakedahn is now known as jakedahn_zz | 18:33 | |
*** jakedahn_zz is now known as jakedahn | 18:39 | |
*** davidha1 has joined #openstack-dev | 18:39 | |
*** jakedahn is now known as jakedahn_zz | 18:44 | |
*** gakott has joined #openstack-dev | 18:44 | |
Ryan_Lane | anyone have an idea why the api service may take 9-10 seconds to return a response? | 18:44 |
Ryan_Lane | today, all of a sudden, all of my api requests are taking 10 seconds to return | 18:45 |
*** garyk has quit IRC | 18:45 | |
*** jakedahn_zz is now known as jakedahn | 18:49 | |
*** sacharya has quit IRC | 18:50 | |
*** markmc has quit IRC | 18:53 | |
*** zaitcev has quit IRC | 18:55 | |
jaypipes | dtroyer: ping | 18:56 |
dtroyer | jaypipes: yo | 18:56 |
jaypipes | dtroyer: I'm seeing this on a freshly-pulled devstack install... wondering if you've seen this? http://paste.openstack.org/show/19488/ | 18:57 |
jaypipes | dtroyer: seems like glance-manage db_sync is not being run? | 18:57 |
jaypipes | dtroyer: wondering if something recently changed with glance db migrations? | 18:57 |
jaypipes | bcwaldon: ^^ u too | 18:57 |
dtroyer | I'm not aware of anything changing in devstack wrt glance lately. is that from stack.sh? | 18:58 |
jaypipes | dtroyer: yep. | 18:59 |
*** sacharya has joined #openstack-dev | 19:00 | |
dtroyer | jaypipes: I can't find a 'glance image-list' command in stack.sh…it is in a couple of exercises and they're running for me…but I have a basic minimal service config…no swift, etc | 19:04 |
*** anderstj has joined #openstack-dev | 19:05 | |
Ryan_Lane | where's the recommended place to get help? irc is like a ghost town | 19:06 |
jaypipes | dtroyer: sorry, that's in configure_tempest.sh, but the same traceback occurs when the stack.sh does any glance command. | 19:06 |
jaypipes | Ryan_Lane: ML? | 19:06 |
Ryan_Lane | for diablo support? | 19:07 |
Ryan_Lane | or is there a ML for support? | 19:07 |
jaypipes | Ryan_Lane: no, I was just suggesting posting to the general mailing list | 19:07 |
* Ryan_Lane nods | 19:07 | |
*** danwent has quit IRC | 19:09 | |
dtroyer | jaypipes: I don't see it with swift enabled either... | 19:10 |
*** chrisfer has quit IRC | 19:11 | |
jaypipes | dtroyer: shouldn't have anything to do with swift... | 19:11 |
dtroyer | jaypipes: ok | 19:12 |
dtroyer | jaypipes: config_tempest.sh runs for me too... | 19:12 |
jaypipes | dtroyer: found the issue... | 19:14 |
jaypipes | + /opt/stack/glance/bin/glance-manage db_sync | 19:14 |
jaypipes | 2012-07-18 14:49:36 INFO [glance.db.sqlalchemy.api] auto-creating glance registry DB | 19:14 |
jaypipes | 2012-07-18 14:49:36 INFO [glance.db.sqlalchemy.migration] Upgrading sqlite:///glance.sqlite to version latest | 19:14 |
*** chrisfer has joined #openstack-dev | 19:14 | |
jaypipes | dtroyer: the call to glance-manage db_sync is syncing a SQLite database, but the glance-registry.conf sets the DB connection to a MySQL database (as it should) | 19:15 |
jaypipes | dtroyer: do you have /etc/glance/glance-*.conf files? | 19:17 |
*** danwent has joined #openstack-dev | 19:17 | |
dtroyer | jaypipes: yup and they have sql_connection set to mysql | 19:18 |
jaypipes | dtroyer: ok, so that's the issue... need to pass --config-file to the glance-manage call. I'll submit a patch. | 19:18 |
*** dprince has quit IRC | 19:18 | |
jaypipes | dtroyer: gotta love hard-to-find default configuration settings ;) | 19:18 |
dtroyer | jaypipes: so why don't I see that? | 19:19 |
jaypipes | dtroyer: so... glance-manage looks for /etc/glance/glance-registry.conf if no --config-file=<FILE> option is given. and since you have that file (and I don't), it uses the mysql connection. In my case, I don't have that file and it used the default db_connection setting of a SQLite database. | 19:20 |
*** sulochan has quit IRC | 19:20 | |
*** sulochan_ has joined #openstack-dev | 19:20 | |
dtroyer | jaypipes: ah, I didn't realize you didn't have them…makes sense to me now | 19:20 |
jaypipes | dtroyer: just a simple matter of supplying the --config-file arg when calling glance-manage | 19:20 |
*** rpedde is now known as rpedde_away | 19:23 | |
jaypipes | dtroyer: yup, adding --config-file=$GLANCE_API_CONF fixed it up. patch coming soon. | 19:23 |
*** danwent_ has joined #openstack-dev | 19:25 | |
*** dolphm_ has joined #openstack-dev | 19:25 | |
*** davidkranz has joined #openstack-dev | 19:25 | |
*** rnirmal_ has joined #openstack-dev | 19:26 | |
*** anderstj has quit IRC | 19:27 | |
*** danwent_ has quit IRC | 19:27 | |
*** datsun180b_ has joined #openstack-dev | 19:27 | |
*** danwent_ has joined #openstack-dev | 19:27 | |
*** jakedahn_ has joined #openstack-dev | 19:27 | |
*** seats_ has joined #openstack-dev | 19:28 | |
*** armaan1 has joined #openstack-dev | 19:28 | |
*** armaan1 has left #openstack-dev | 19:28 | |
*** roge_ has joined #openstack-dev | 19:28 | |
*** bhuvan_ has joined #openstack-dev | 19:29 | |
*** Xtrapni has joined #openstack-dev | 19:29 | |
*** anderstj has joined #openstack-dev | 19:29 | |
*** giroro_ has joined #openstack-dev | 19:32 | |
*** chmouel_ has joined #openstack-dev | 19:32 | |
*** anniec has quit IRC | 19:33 | |
*** pandemicsyn2 has joined #openstack-dev | 19:33 | |
*** danwent has quit IRC | 19:34 | |
*** gakott has quit IRC | 19:34 | |
*** datsun180b has quit IRC | 19:34 | |
*** rnirmal has quit IRC | 19:34 | |
*** markmcclain has quit IRC | 19:34 | |
*** matiu has quit IRC | 19:34 | |
*** roge has quit IRC | 19:34 | |
*** dolphm has quit IRC | 19:34 | |
*** Daviey has quit IRC | 19:34 | |
*** Ruetobas has quit IRC | 19:34 | |
*** davidkranz_ has quit IRC | 19:34 | |
*** bhuvan has quit IRC | 19:34 | |
*** linmin has quit IRC | 19:34 | |
*** seats has quit IRC | 19:34 | |
*** pandemicsyn has quit IRC | 19:34 | |
*** trapni has quit IRC | 19:34 | |
*** cloudfly has quit IRC | 19:34 | |
*** chmouel has quit IRC | 19:34 | |
*** jakedahn has quit IRC | 19:34 | |
*** datsun180b_ is now known as datsun180b | 19:34 | |
*** danwent_ is now known as danwent | 19:34 | |
*** rnirmal_ is now known as rnirmal | 19:34 | |
*** seats_ is now known as seats | 19:34 | |
*** anderstj has quit IRC | 19:38 | |
*** Daviey has joined #openstack-dev | 19:39 | |
*** matiu has joined #openstack-dev | 19:39 | |
*** matiu has quit IRC | 19:39 | |
*** matiu has joined #openstack-dev | 19:39 | |
*** gakott has joined #openstack-dev | 19:40 | |
*** linmin has joined #openstack-dev | 19:40 | |
*** benner has quit IRC | 19:42 | |
Ryan_Lane | ok. I generally don't bitch very much…. | 19:43 |
Ryan_Lane | (that's a lie) | 19:43 |
Ryan_Lane | but I just did a show full processlist to find out why why queries are taking so long for my metadata service | 19:44 |
*** novas0x2a|laptop has joined #openstack-dev | 19:44 | |
Ryan_Lane | and I swear I've just seen the worst query I've ever seen in my entire life | 19:44 |
dtroyer | jaypipes: I'm confused…looking at the code to refresh my memory, how are you not getting files in /etc/glance? Not only is it the default but it isn't configurable in localrc either. | 19:44 |
jaypipes | dtroyer: actually, I also have /etc/glance/* installed by devstack. now trying to figure out what glance-manage thinks is the difference if I don'r supply --config-file to it :( | 19:46 |
Ryan_Lane | please. someone tell me why a query like this is ever necessary: http://pastebin.com/fNwxcaVh | 19:46 |
jaypipes | dtroyer: sorry for jumping the gun. | 19:46 |
jaypipes | Ryan_Lane: welcome to ORMs. | 19:46 |
* Ryan_Lane sighs | 19:46 | |
Ryan_Lane | this is why I don't use ORMs | 19:46 |
jaypipes | Ryan_Lane: ya, I know :( | 19:47 |
Ryan_Lane | my metadata requests are taking 10s | 19:47 |
Ryan_Lane | I can't boot instances | 19:47 |
Ryan_Lane | I can't create instances | 19:47 |
Ryan_Lane | how the hell am I supposed to debug a query like that? | 19:47 |
jaypipes | Ryan_Lane: is the request spent entirely in the database query? | 19:51 |
Ryan_Lane | those queries are taking 7 seconds | 19:52 |
*** rpedde_away is now known as rpedde | 19:55 | |
jaypipes | Ryan_Lane: ugh.. :( | 19:56 |
jaypipes | Ryan_Lane: that query has absolutely no where condition on it :( it's reading all of the instances table joined with a dozen other tables... all table scans. | 19:57 |
jaypipes | Ryan_Lane: vishy refactored the metadata query code in essex. perhaps it's worth backporting to essex? | 19:58 |
jaypipes | sorry, backporting to diablo. | 19:58 |
*** mokas has joined #openstack-dev | 19:58 | |
vishy | jaypipes: I did? | 19:58 |
jaypipes | vishy: yeah... you added a caching layer IIRC | 19:59 |
*** markmcclain has joined #openstack-dev | 19:59 | |
*** andrewbogott has quit IRC | 20:01 | |
vishy | jaypipes: oh right, yes jesse and I added that | 20:02 |
vishy | jaypipes: it is probably cherry-pickable | 20:02 |
vishy | jaypipes: although stuff moved around so it will probably have to be done manually | 20:02 |
jaypipes | vishy: git log --author=vish* --oneline | grep metadata | 20:02 |
jaypipes | vishy: it's in there somewhere :) | 20:02 |
jtran | anyone know if ceilometer gerrit doesn't allow draft reviews? | 20:03 |
jtran | To ssh://jtran@review.openstack.org:29418/stackforge/ceilometer.git | 20:03 |
jtran | ! [remote rejected] HEAD -> refs/draft/master/bug/1004449 (can not create new references) | 20:03 |
jtran | error: failed to push some refs to 'ssh://jtran@review.openstack.org:29418/stackforge/ceilometer.git' | 20:03 |
jaypipes | jtran: hop over to #openstack-infra and ask jeblair :) | 20:04 |
jtran | ok thx | 20:04 |
*** tgall_foo has quit IRC | 20:06 | |
*** tgall_foo has joined #openstack-dev | 20:07 | |
*** tgall_foo has joined #openstack-dev | 20:07 | |
jaypipes | Ryan_Lane: ping. any chance you could paste the output of an EXPLAIN SELECT for that query above? | 20:09 |
*** edygarcia_ has joined #openstack-dev | 20:10 | |
*** edygarcia has quit IRC | 20:13 | |
*** edygarcia_ is now known as edygarcia | 20:13 | |
*** eglynn has joined #openstack-dev | 20:15 | |
*** eglynn__ has quit IRC | 20:15 | |
*** cp16net is now known as cp16net|away | 20:15 | |
*** cp16net|away is now known as cp16net | 20:15 | |
*** anniec has joined #openstack-dev | 20:18 | |
*** anniec_ has joined #openstack-dev | 20:19 | |
*** andrewsmedina has left #openstack-dev | 20:20 | |
*** pandemicsyn2 is now known as pandemicsyn | 20:20 | |
*** ChanServ sets mode: +v pandemicsyn | 20:20 | |
*** anniec has quit IRC | 20:22 | |
*** anniec_ is now known as anniec | 20:22 | |
Ryan_Lane | so…. from the slow query log: # Query_time: 6.026755 Lock_time: 0.000607 Rows_sent: 18822 Rows_examined: 42145 | 20:24 |
Ryan_Lane | that's for looking up the metadata for a single instance | 20:26 |
Ryan_Lane | that's crazy | 20:26 |
*** cp16net is now known as cp16net|away | 20:27 | |
*** cp16net|away is now known as cp16net | 20:27 | |
*** sacharya has quit IRC | 20:28 | |
*** andrewbogott has joined #openstack-dev | 20:30 | |
*** galstrom has left #openstack-dev | 20:30 | |
*** vanchester has joined #openstack-dev | 20:31 | |
*** chmouel_ is now known as chmouel | 20:31 | |
*** benner has joined #openstack-dev | 20:34 | |
*** dachary has joined #openstack-dev | 20:36 | |
jaypipes | Ryan_Lane: can you EXPLAIN SELECT any of the queries for me? | 20:40 |
jaypipes | dtroyer: I am an idiot... I had a glance-api.conf file lying around in my ~ directory that was being picked up. :( | 20:41 |
*** sacharya has joined #openstack-dev | 20:42 | |
*** jog0 has joined #openstack-dev | 20:43 | |
*** giroro_ has quit IRC | 20:43 | |
dtroyer | jaypipes: argh! I HATE IT when that happens | 20:44 |
*** s0mik has joined #openstack-dev | 20:45 | |
*** galstrom has joined #openstack-dev | 20:45 | |
*** galstrom has joined #openstack-dev | 20:46 | |
jaypipes | dtroyer: :) abandoned the change in gerrit... | 20:46 |
*** jshepher has joined #openstack-dev | 20:47 | |
mtaylor | Ryan_Lane: you should ping devananda about that too | 20:48 |
mtaylor | Ryan_Lane: I know he's been looking at database optimizations | 20:48 |
*** dachary has quit IRC | 20:50 | |
*** galstrom has quit IRC | 20:51 | |
*** jshepher is now known as galstrom | 20:51 | |
*** Ruetobas has joined #openstack-dev | 20:52 | |
*** Deva has joined #openstack-dev | 20:53 | |
*** Deva is now known as devananda2 | 20:55 | |
jgriffith | dtroyer: I almost forgot, did you ever get a chance to look at the excercise.sh failures? | 20:55 |
devananda2 | mtaylor, ryan_lane, whats up? | 20:55 |
dtroyer | jgriffith: you mean the boot_from_volume failure? | 20:56 |
jgriffith | dtroyer: Yep | 20:56 |
jgriffith | dtroyer: I'm still trying to figure out why the jenkins runs work and nothing else does :( Including the gat job changes | 20:57 |
jgriffith | dtroyer: Well, not still... just came back to it this afternoon | 20:57 |
dtroyer | jgriffith: not really. boot_from_volume isn't run for gating | 20:57 |
*** timjr has joined #openstack-dev | 20:58 | |
mtaylor | devananda2: from earlier (don't know if you was here, Ryan_Lane said "so…. from the slow query log: # Query_time: 6.026755 Lock_time: 0.000607 Rows_sent: 18822 Rows_examined: 42145 ... that's for looking up the metadata for a single instance" | 20:58 |
jgriffith | dtroyer: Well that explains that :) | 20:58 |
dtroyer | jgriffith: I don't recall it ever working, that's why we disabled it | 20:58 |
*** s0mik has quit IRC | 20:59 | |
devananda2 | mtaylor, nope, not at my comp now. thats an awesome query. | 20:59 |
*** s0mik has joined #openstack-dev | 20:59 | |
mtaylor | devananda2: yeah, right? | 21:00 |
devananda2 | ryan_lane, want to send a snippet of that query log, and i can look into it? | 21:01 |
jgriffith | dtroyer: Oh... ok | 21:01 |
jgriffith | dtroyer: So then I'm just down to the one failure for the gate changes | 21:02 |
jgriffith | dtroyer: Sorry, I was confused | 21:02 |
dtroyer | jgriffith: np | 21:03 |
*** Gordonz_ has quit IRC | 21:03 | |
*** novas0x2a|laptop has quit IRC | 21:04 | |
*** novas0x2a|laptop has joined #openstack-dev | 21:04 | |
jgriffith | dtroyer: Do you by chance know what I missed in this patch to get the gate changed over? https://review.openstack.org/#/c/9746/ | 21:04 |
dtroyer | jgriffith: I don't see anything obvious but I'm not too familiar with the CI scripts | 21:06 |
* mtaylor lookie | 21:06 | |
jgriffith | dtroyer: Cool, thanks. Wasn't sure if you were on that side of the devstack stuff too. | 21:06 |
jgriffith | dtroyer: You've answered every other question I've asked so it was worth a shot :) | 21:06 |
mtaylor | jgriffith: it looks like you did actually enable something cinder-wise | 21:07 |
jgriffith | mtaylor: yeah, but something went awry and it failed. | 21:07 |
jgriffith | mtaylor: I need to look at the screen output again I suppose | 21:08 |
*** s0mik has quit IRC | 21:08 | |
mtaylor | jgriffith: yeah - I mean, on VERY cursory look it seems like it mostly perhaps did what you asked? | 21:08 |
jgriffith | mtaylor: Yeah, and what's annoying is it "looks" like it created the volume succesfully as well | 21:09 |
jgriffith | mtaylor: That assert I believe is fomr the python threading bug that shows up all over the place | 21:10 |
*** anniec has quit IRC | 21:10 | |
*** lts has quit IRC | 21:11 | |
*** dolphm_ has quit IRC | 21:12 | |
*** vanchester has quit IRC | 21:12 | |
*** novas0x2a|laptop has quit IRC | 21:13 | |
*** steveb_ has joined #openstack-dev | 21:14 | |
*** zaitcev has joined #openstack-dev | 21:14 | |
*** novas0x2a|laptop has joined #openstack-dev | 21:14 | |
*** s0mik has joined #openstack-dev | 21:17 | |
*** jog0 has quit IRC | 21:18 | |
*** devananda2 has quit IRC | 21:21 | |
*** cloudfly has joined #openstack-dev | 21:23 | |
*** rnirmal has quit IRC | 21:25 | |
zykes- | Should my instance go offline when snapshotting ? | 21:25 |
zykes- | Can't ping it when snapshotting :/ | 21:26 |
*** sacharya has quit IRC | 21:27 | |
Ryan_Lane | jaypipes, devananda2: http://pastebin.com/REtVG8ch | 21:27 |
Ryan_Lane | here's the query: http://pastebin.com/fNwxcaVh | 21:27 |
Ryan_Lane | so, deleted on all of these tables is unindexed | 21:28 |
Ryan_Lane | I'm not sure if that's changed in newer versions of nova, but it's the case in diablo | 21:28 |
*** anniec has joined #openstack-dev | 21:29 | |
*** Devananda2 has joined #openstack-dev | 21:30 | |
*** gongys has joined #openstack-dev | 21:30 | |
*** anniec_ has joined #openstack-dev | 21:31 | |
Devananda2 | Ryan_Lane: can you send the actual query, and/or info on reproducing it in devstack? The explain doesn't help me find the code responsible for the query | 21:32 |
*** markvoelker has quit IRC | 21:32 | |
Ryan_Lane | it's in the pastebin | 21:32 |
Ryan_Lane | http://pastebin.com/fNwxcaVh | 21:32 |
Ryan_Lane | this is a query to get metadata | 21:33 |
Devananda2 | Ah, thanks. On a bad connection, didn't see that paste before | 21:33 |
* Ryan_Lane nods | 21:33 | |
*** anniec has quit IRC | 21:34 | |
*** anniec_ is now known as anniec | 21:34 | |
*** salgado has quit IRC | 21:36 | |
*** ayoung has joined #openstack-dev | 21:36 | |
zykes- | or is it designed like that ? | 21:37 |
*** rafaduran has quit IRC | 21:39 | |
*** danwent has quit IRC | 21:39 | |
*** andrewbogott has quit IRC | 21:40 | |
*** tgall_foo has quit IRC | 21:42 | |
*** troytoman-away is now known as troytoman | 21:44 | |
Ryan_Lane | sooooo. what's that cherry-pick for caching this stuff? | 21:47 |
Ryan_Lane | I really need a working system | 21:47 |
Ryan_Lane | also, another question: why are things marked as deleted in the database, rather than actually being deleted at some point? | 21:48 |
Ryan_Lane | and is there some way for me to delete this old cruft, since every row is making the database increasingly slower | 21:48 |
jaypipes | Ryan_Lane: the ones I identified earlier were e607353 and 1a209e6 at least... | 21:49 |
jaypipes | Ryan_Lane: but of course, pretty sure it won't be an easy cherry-pick without conflict :( | 21:50 |
jaypipes | Ryan_Lane: and we mark deleted instead of deleting because of audit reasons. | 21:50 |
*** EmilienM has quit IRC | 21:51 | |
*** littleidea_ has joined #openstack-dev | 21:51 | |
Ryan_Lane | heh. seems that query returns 391MB of data | 21:52 |
jaypipes | Ryan_Lane: looking into that now... | 21:52 |
Ryan_Lane | which makes it understandable that it takes so long | 21:52 |
*** littleidea__ has joined #openstack-dev | 21:52 | |
Ryan_Lane | it's not the query, it's returning the data across the wire | 21:52 |
jaypipes | Ryan_Lane: would you mind doing something else for me? could you mysqldump the schema only, please? | 21:52 |
jaypipes | Ryan_Lane: I can identify indexes that will speed this up considerably for you -- at least get you past this existing perf issue. | 21:53 |
Ryan_Lane | this isn't an index problem anymore | 21:53 |
Ryan_Lane | the problem is that a query for a single instance is returning data for every single instance | 21:53 |
*** littleidea has quit IRC | 21:55 | |
*** littleidea__ is now known as littleidea | 21:55 | |
jaypipes | Ryan_Lane: well, i need to go back to a stable/diablo (or 2012.2?) branch and see why there isn't any where clause being put on this query :( | 21:55 |
Ryan_Lane | yeah. I'm really hoping this has been fixed in essex+. heh | 21:55 |
* mtaylor blames jaypipes | 21:55 | |
*** EmilienM has joined #openstack-dev | 21:55 | |
*** samkottler has quit IRC | 21:55 | |
*** littleidea_ has quit IRC | 21:56 | |
jaypipes | Ryan_Lane: well, I'm not sure whether the underlying query has been fixed (that's what I'm currently investigating), but I do know for sure that vishy and anotherjesse_zz added caching to the metadata handler in Essex, which speeds stuff up considerably (it essentially memoizes requests for an address' metdata | 21:56 |
* jaypipes git checkout's stable/diablo... | 21:56 | |
vishy | Ryan_Lane: It does a bunch of db requests | 21:57 |
vishy | Ryan_Lane: there is probably one in there that gets all of them, maybe it is because the filter by ip is not done at the db layer? | 21:58 |
*** anniec has quit IRC | 21:58 | |
Ryan_Lane | seems that way | 21:58 |
vishy | Ryan_Lane: it could also be the weird mpi code we added that gets a list of all instances in the same security group | 21:58 |
vishy | (if your instances all belong to the same tenant) | 21:59 |
Ryan_Lane | they are all in different tenants | 21:59 |
*** preilly has joined #openstack-dev | 21:59 | |
*** gongys has quit IRC | 22:00 | |
Devananda2 | Ryan_Lane, you may want to create a cron to purge old deleted records. We have had to do that... | 22:00 |
Ryan_Lane | I'm more than happy to delete the old data | 22:00 |
*** dolphm has joined #openstack-dev | 22:00 | |
Ryan_Lane | but it would be quite nice to have it work without that too :) | 22:00 |
Ryan_Lane | Devananda2: can you give me the cron you use? | 22:01 |
vishy | Ryan_Lane: I'm sure it wouldn't be very hard to fix that issue | 22:01 |
*** galstrom has quit IRC | 22:02 | |
*** dolphm has quit IRC | 22:02 | |
*** EmilienM has quit IRC | 22:02 | |
jaypipes | Ryan_Lane: the database really isn't that big, from what I can tell... it's more a problem with the query the ORM is making IMO. | 22:03 |
Ryan_Lane | that one query returns 391MB of data | 22:03 |
jaypipes | Ryan_Lane: just making sure .. you on 2012.2? | 22:03 |
Ryan_Lane | that much data going across the wire is going to take a while | 22:03 |
Ryan_Lane | jaypipes: I'm running what was in the ppa, which isn't stable | 22:04 |
jaypipes | Ryan_Lane: which PPA? | 22:04 |
Ryan_Lane | well, it was the stable ppa | 22:04 |
Ryan_Lane | which is different from the stable repo (hooray) | 22:04 |
jaypipes | gah | 22:04 |
* Ryan_Lane is looking forward to ubuntu handling this | 22:04 | |
Devananda2 | Ryan_Lane, I will check when I get home. Should be OK .... | 22:05 |
Ryan_Lane | Devananda2: thanks | 22:05 |
Devananda2 | Actually, I should probably submit it upstream... | 22:05 |
Ryan_Lane | oh, and the ppa was deleted :D | 22:06 |
*** danwent has joined #openstack-dev | 22:06 | |
jaypipes | Ryan_Lane: I'm going to go with 2012.2 then... | 22:06 |
Ryan_Lane | likely similar enough | 22:06 |
jaypipes | Ryan_Lane: which is the second point release on diablo | 22:06 |
*** anderstj has joined #openstack-dev | 22:06 | |
*** galstrom has joined #openstack-dev | 22:06 | |
Ryan_Lane | yep | 22:07 |
*** anniec has joined #openstack-dev | 22:08 | |
Devananda2 | Vishy, any thoughts on me adding a database event to purge old deleted records? | 22:08 |
jaypipes | Ryan_Lane: could something be requesting metadata without an address? | 22:09 |
*** dolphm has joined #openstack-dev | 22:09 | |
Ryan_Lane | I'm not seeing how | 22:09 |
*** anderstj has quit IRC | 22:10 | |
zykes- | vishy: can you give a clue on why snapshots fail ? Seems to be hanging on vgscan something | 22:10 |
*** anderstj has joined #openstack-dev | 22:10 | |
*** gongys has joined #openstack-dev | 22:11 | |
*** galstrom has quit IRC | 22:12 | |
Ryan_Lane | my coworkers, going through the code, mention this is likely fixed in newer versions, so the cron job will get me through till we uograde | 22:12 |
Ryan_Lane | *upgrade | 22:12 |
*** littleidea_ has joined #openstack-dev | 22:15 | |
jaypipes | Ryan_Lane: holy shit, I just figured out the source of the bad query... | 22:17 |
Ryan_Lane | oh? | 22:17 |
jaypipes | Ryan_Lane: https://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L1306 | 22:18 |
jaypipes | Ryan_Lane: fixed_ip is not listed in exact match filters, and so the entire set of instances + IP addresses for each is returned, then ... | 22:18 |
jaypipes | https://github.com/openstack/nova/blob/stable/diablo/nova/db/sqlalchemy/api.py#L1227 | 22:19 |
jaypipes | That ^^ is run against that whole set of records :( | 22:19 |
*** jtran has quit IRC | 22:19 | |
jaypipes | Ryan_Lane: all so that (I think!) things like 127.0.* can be used in the query? | 22:19 |
*** Devananda2 has quit IRC | 22:20 | |
*** maoy has quit IRC | 22:20 | |
*** littleidea has quit IRC | 22:20 | |
*** littleidea_ is now known as littleidea | 22:20 | |
jaypipes | Ryan_Lane: if I submit a patch up to Gerrit stable/diablo, you think you can pull it and test it out? | 22:20 |
Ryan_Lane | yep | 22:20 |
*** jakedahn_ is now known as jakedahn_zz | 22:21 | |
jaypipes | Ryan_Lane: k, gimme about an hour. FYI, AT&T is dealing with this exact same slowdown right now and it's causing major headaches... | 22:21 |
Ryan_Lane | :D | 22:21 |
Ryan_Lane | great. thanks. | 22:21 |
jaypipes | np | 22:22 |
*** sulochan_ has quit IRC | 22:22 | |
*** kbringard has quit IRC | 22:24 | |
preilly | jaypipes: what is your proposed patch? | 22:24 |
*** mnewby has quit IRC | 22:24 | |
jaypipes | preilly: I'm currently working on it. | 22:25 |
*** Ryan_Lane has quit IRC | 22:25 | |
*** preilly_ has joined #openstack-dev | 22:25 | |
*** preilly_ has joined #openstack-dev | 22:25 | |
*** Ryan_Lane has joined #openstack-dev | 22:25 | |
*** datsun180b has quit IRC | 22:28 | |
*** sacharya has joined #openstack-dev | 22:28 | |
*** preilly has quit IRC | 22:29 | |
*** preilly_ is now known as preilly | 22:29 | |
*** eglynn has quit IRC | 22:31 | |
devananda | jaypipes: if i'm reading this correctly, the same potential issue is present in trunk. Even though the instance_get_all_by_filters function has been refactored, ip still is not in exact_match_filter_names, soo.... | 22:32 |
jaypipes | devananda: yes. | 22:32 |
jaypipes | devananda: I'm going to see if it works for Ryan_Lane and if it does propose to trunk | 22:33 |
devananda | great | 22:33 |
*** mnewby has joined #openstack-dev | 22:40 | |
*** blamar has quit IRC | 22:42 | |
*** jakedahn_zz is now known as jakedahn | 22:42 | |
*** dachary has joined #openstack-dev | 22:47 | |
*** halfss has joined #openstack-dev | 22:47 | |
*** markmcclain has quit IRC | 22:49 | |
*** pixelbeat has quit IRC | 22:51 | |
*** spiffxp has quit IRC | 22:58 | |
preilly | jaypipes: how's the patch coming along? | 22:58 |
* preilly wants to try it ASAP | 22:59 | |
* preilly works with Ryan btw | 22:59 | |
jaypipes | preilly: about 70% done. | 22:59 |
preilly | jaypipes: okay cool | 22:59 |
preilly | jaypipes: thanks for the update | 22:59 |
Ryan_Lane | we're all walking through the code right now. heh | 22:59 |
*** dtroyer is now known as dtroyer_zzz | 23:00 | |
*** mnewby has quit IRC | 23:02 | |
*** mnewby has joined #openstack-dev | 23:02 | |
*** jog0 has joined #openstack-dev | 23:03 | |
*** jtran has joined #openstack-dev | 23:03 | |
jog0 | vishy: ping | 23:03 |
vishy | jog0: heyo | 23:03 |
*** jog0_ has joined #openstack-dev | 23:04 | |
*** jog0 has quit IRC | 23:04 | |
*** jog0_ is now known as jog0 | 23:04 | |
*** edygarcia has quit IRC | 23:05 | |
jog0 | how is the force_hosts an admin only option? | 23:05 |
*** mnewby has quit IRC | 23:06 | |
vishy | jog0: 474 if context.is_admin and forced_host: | 23:06 |
vishy | jog0: also it circumvents filters, so it allows an admin to force a host that otherwise wouldn't pass filters | 23:06 |
*** kpavel has joined #openstack-dev | 23:07 | |
jog0 | ahh I see. | 23:07 |
jog0 | I will abandon my patch. I only proposed it because of your NOTE on line 298 | 23:08 |
jog0 | but there is nothing that can fully replace this ATM | 23:08 |
vishy | jog0: thanks :) I think the forced host comment still applies | 23:12 |
vishy | jog0: s/comment/code | 23:12 |
vishy | jog0: it is just ugly to pull the parameter out of availability zone | 23:12 |
devananda | vishy, jaypipes: for the archiving/purging of old records (what Ryan_Lane was asking about while I was at lunch), we've got an EVENT that does this | 23:13 |
devananda | right now, it archives instead of deletes, but it could just as well delete things | 23:13 |
*** kpavel has quit IRC | 23:13 | |
*** jog0 has quit IRC | 23:14 | |
Ryan_Lane | archives is fine too | 23:14 |
devananda | how do you guys feel about that, and what's the right place to create an EVENT from (ideally, somehwere that can interpret options such as the prune-age)? | 23:14 |
*** spiffxp has joined #openstack-dev | 23:16 | |
*** jog0 has joined #openstack-dev | 23:17 | |
*** jtran has quit IRC | 23:18 | |
*** preilly has left #openstack-dev | 23:19 | |
*** s0mik has quit IRC | 23:19 | |
jaypipes | Ryan_Lane: OK: https://github.com/jaypipes/nova/commit/31667a8ecb6554e35edfab6ec93067cca5fc24ff | 23:20 |
*** jtran has joined #openstack-dev | 23:20 | |
*** preilly has joined #openstack-dev | 23:20 | |
jaypipes | Ryan_Lane: unfortunately, I haven't been able to run tests locally because run_tests.sh -N bombs on the damn database migrations for some reason in the stable/diablo checkout. | 23:20 |
Ryan_Lane | heh | 23:20 |
jaypipes | Ryan_Lane: perhaps you could give the commit a look over and maybe patch it in and test? | 23:21 |
Ryan_Lane | sure | 23:21 |
jaypipes | Ryan_Lane: really sorry about that :( | 23:21 |
Ryan_Lane | it's cool. thanks for the patch | 23:21 |
jaypipes | Ryan_Lane: tried getting the tests to run but it was one thing after another with old dependencies needed | 23:21 |
*** dachary has quit IRC | 23:22 | |
*** s0mik has joined #openstack-dev | 23:23 | |
*** novas0x2a|laptop has quit IRC | 23:27 | |
*** issackelly has quit IRC | 23:31 | |
*** anniec has quit IRC | 23:32 | |
*** anderstj has quit IRC | 23:34 | |
preilly | jaypipes: You're missing a closing parentheses in query = query.filter((models.VirtualInterface.address == address) | 23:35 |
jaypipes | preilly: dang. thank you. one sec. | 23:35 |
*** dachary has joined #openstack-dev | 23:35 | |
Ryan_Lane | jaypipes: heh | 23:36 |
Ryan_Lane | so.... | 23:36 |
Ryan_Lane | I think this is looking in the wrong spot | 23:36 |
jaypipes | Ryan_Lane: how so? | 23:36 |
*** nati_uen_ has left #openstack-dev | 23:37 | |
*** dtroyer_zzz is now known as dtroyer | 23:37 | |
Ryan_Lane | WHERE virtual_interfaces.address = '10.4.0.35' | 23:38 |
jaypipes | Ryan_Lane: that is definitely what is producing that monster query with no WHERE clause... | 23:38 |
jaypipes | Ryan_Lane: ah, I see... so it's the wrong filter. | 23:38 |
*** anniec has joined #openstack-dev | 23:38 | |
jaypipes | Ryan_Lane: needs to be on the floating and fixed ip address field? | 23:38 |
Ryan_Lane | yep | 23:38 |
jaypipes | Ryan_Lane: k. thought that might be the case, but figured I'd go simple first... | 23:39 |
jaypipes | Ryan_Lane: k, will work further and push in a bit. | 23:39 |
Ryan_Lane | ok | 23:39 |
*** anniec_ has joined #openstack-dev | 23:40 | |
*** anniec has quit IRC | 23:41 | |
*** anniec_ is now known as anniec | 23:41 | |
*** dolphm has quit IRC | 23:41 | |
*** rkukura has quit IRC | 23:45 | |
*** rkukura has joined #openstack-dev | 23:45 | |
*** jakedahn is now known as jakedahn_zz | 23:47 | |
vishy | the vid address is a mac | 23:48 |
vishy | * vif | 23:48 |
vishy | you need virtual_interfaces -> fixed_ips -> address | 23:48 |
vishy | jaypipes, Ryan_Lane ^^ | 23:49 |
* Ryan_Lane nods | 23:49 | |
*** e1mer has joined #openstack-dev | 23:49 | |
*** jog0 has quit IRC | 23:50 | |
jaypipes | vishy: yeah, figured that out :) | 23:50 |
*** mnewby has joined #openstack-dev | 23:51 | |
vishy | is the query still there in trunk? it does: 194 fixed_ip = network.API().get_fixed_ip_by_address(ctxt, address) | 23:51 |
vishy | followed by: instance = db.instance_get(ctxt, fixed_ip['instance_id']) | 23:51 |
Ryan_Lane | that seems like a sane way of going about that | 23:51 |
vishy | jaypipes, Ryan_Lane: or is it a later query that is doing it without the join? | 23:52 |
jaypipes | vishy: it's because the IP is not used in the exact match filters... a regex is used across the entire crossjoin of instances + floating IPs + fixed IPs | 23:52 |
jaypipes | vishy: what's wrong with just joining fixed_ips to instances directly via fixed_ips.instance_id? | 23:54 |
*** mnewby has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!