*** markmcclain has joined #openstack-dev | 00:02 | |
*** fss has quit IRC | 00:03 | |
*** thingee is now known as thingee_zz | 00:06 | |
*** fss has joined #openstack-dev | 00:06 | |
*** asalkeld has quit IRC | 00:08 | |
*** nati_ueno has joined #openstack-dev | 00:10 | |
*** alexpilotti has quit IRC | 00:11 | |
*** roge has quit IRC | 00:22 | |
*** zhuadl has quit IRC | 00:23 | |
*** Dharmit has quit IRC | 00:25 | |
*** johnpostlethwait has quit IRC | 00:26 | |
*** dolphm has quit IRC | 00:27 | |
*** Exhar has joined #openstack-dev | 00:27 | |
*** heckj has quit IRC | 00:30 | |
*** spiffxp has quit IRC | 00:30 | |
*** nati_uen_ has joined #openstack-dev | 00:31 | |
*** Exhar has quit IRC | 00:32 | |
*** lloydde has quit IRC | 00:32 | |
*** nati_uen_ has quit IRC | 00:33 | |
*** jtran has quit IRC | 00:33 | |
*** nati_ueno_2 has joined #openstack-dev | 00:34 | |
*** nati_uen_ has joined #openstack-dev | 00:34 | |
*** nati_ueno has quit IRC | 00:36 | |
*** jtran has joined #openstack-dev | 00:36 | |
*** cbj has quit IRC | 00:39 | |
*** s0mik has quit IRC | 00:43 | |
*** dolphm has joined #openstack-dev | 00:45 | |
*** cloudvirt has joined #openstack-dev | 00:45 | |
*** nati_ueno has joined #openstack-dev | 00:47 | |
*** asalkeld has joined #openstack-dev | 00:48 | |
*** asalkeld has quit IRC | 00:49 | |
*** ncode has quit IRC | 00:49 | |
*** asalkeld has joined #openstack-dev | 00:49 | |
*** nati_uen_ has quit IRC | 00:51 | |
*** nati_ueno has quit IRC | 00:53 | |
*** sunxin has joined #openstack-dev | 00:53 | |
*** cloudvirt has quit IRC | 00:54 | |
*** e1mer has joined #openstack-dev | 00:56 | |
*** nati_ueno has joined #openstack-dev | 00:57 | |
*** amotoki has joined #openstack-dev | 01:12 | |
*** cbj has joined #openstack-dev | 01:16 | |
*** nati_ueno_2 has quit IRC | 01:20 | |
*** nati_ueno_2 has joined #openstack-dev | 01:20 | |
*** markmcclain has quit IRC | 01:21 | |
*** jakedahn_zz is now known as jakedahn | 01:21 | |
*** roge has joined #openstack-dev | 01:23 | |
*** Exhar has joined #openstack-dev | 01:28 | |
*** gyee has quit IRC | 01:28 | |
*** nati_ueno has quit IRC | 01:29 | |
*** Gordonz has quit IRC | 01:31 | |
*** cp16net is now known as cp16net|away | 01:31 | |
*** cp16net|away is now known as cp16net | 01:31 | |
*** Exhar has quit IRC | 01:32 | |
*** Ryan_Lane has quit IRC | 01:32 | |
*** lorin1 has joined #openstack-dev | 01:35 | |
*** jakedahn is now known as jakedahn_zz | 01:36 | |
*** xchu has joined #openstack-dev | 01:41 | |
*** Mandell has quit IRC | 01:43 | |
*** nati_ueno_2 has quit IRC | 01:45 | |
*** dubsquared has joined #openstack-dev | 01:45 | |
*** cbj has quit IRC | 01:48 | |
*** anniec has quit IRC | 01:49 | |
*** PotHix has quit IRC | 01:56 | |
*** cbj has joined #openstack-dev | 01:59 | |
*** dprince has quit IRC | 02:00 | |
*** jakedahn_zz is now known as jakedahn | 02:01 | |
*** s0mik has joined #openstack-dev | 02:02 | |
*** jakedahn is now known as jakedahn_zz | 02:03 | |
*** cbj has quit IRC | 02:07 | |
*** dolka has joined #openstack-dev | 02:08 | |
*** novas0x2a|laptop has quit IRC | 02:09 | |
*** dolka has quit IRC | 02:09 | |
*** cbj has joined #openstack-dev | 02:11 | |
*** ncode has joined #openstack-dev | 02:12 | |
*** turlough has joined #openstack-dev | 02:19 | |
*** dolphm has quit IRC | 02:19 | |
*** samkottler|afk is now known as samkottler | 02:19 | |
*** colinmcnamara has quit IRC | 02:20 | |
*** colinmcnamara has joined #openstack-dev | 02:20 | |
*** pixelbeat has quit IRC | 02:21 | |
*** turlough has quit IRC | 02:23 | |
*** matwood_ has quit IRC | 02:25 | |
*** matwood has joined #openstack-dev | 02:26 | |
*** Exhar has joined #openstack-dev | 02:28 | |
*** cbj has quit IRC | 02:28 | |
*** blamar has quit IRC | 02:29 | |
*** ewindisch has joined #openstack-dev | 02:30 | |
*** ewindisch has quit IRC | 02:31 | |
*** Exhar has quit IRC | 02:33 | |
*** cbj has joined #openstack-dev | 02:34 | |
*** avishay has quit IRC | 02:38 | |
*** Shrews has quit IRC | 02:38 | |
*** turlough has joined #openstack-dev | 02:40 | |
*** turlough has quit IRC | 02:40 | |
*** turlough has joined #openstack-dev | 02:40 | |
*** turlough has quit IRC | 02:41 | |
*** jtran has quit IRC | 02:41 | |
*** johnpur has left #openstack-dev | 02:43 | |
*** danwent has quit IRC | 02:44 | |
*** adalbas has quit IRC | 02:49 | |
*** sunxin has quit IRC | 02:50 | |
*** mjfork has quit IRC | 02:53 | |
*** chrisfer has quit IRC | 03:04 | |
*** localhost has quit IRC | 03:04 | |
*** lifeless has quit IRC | 03:06 | |
*** danwent has joined #openstack-dev | 03:07 | |
*** lorin1 has quit IRC | 03:08 | |
*** turlough has joined #openstack-dev | 03:10 | |
*** johnpostlethwait has joined #openstack-dev | 03:10 | |
*** s0mik has quit IRC | 03:10 | |
*** winston-d has joined #openstack-dev | 03:11 | |
*** samkottler has quit IRC | 03:12 | |
*** samkottler has joined #openstack-dev | 03:12 | |
*** s0mik has joined #openstack-dev | 03:18 | |
*** daddyjoseph97 has quit IRC | 03:18 | |
*** lifeless has joined #openstack-dev | 03:19 | |
*** sunxin has joined #openstack-dev | 03:22 | |
*** fss has quit IRC | 03:26 | |
*** Exhar has joined #openstack-dev | 03:28 | |
*** tgall_foo has joined #openstack-dev | 03:29 | |
*** justinsb has quit IRC | 03:29 | |
*** blamar has joined #openstack-dev | 03:32 | |
*** Exhar has quit IRC | 03:33 | |
*** lifeless has quit IRC | 03:34 | |
*** Mandell has joined #openstack-dev | 03:35 | |
*** s0mik has quit IRC | 03:36 | |
*** littleidea has joined #openstack-dev | 03:36 | |
*** steveb_ has quit IRC | 03:46 | |
*** dayou has joined #openstack-dev | 03:46 | |
*** dayou has left #openstack-dev | 03:49 | |
*** william0 has joined #openstack-dev | 03:54 | |
*** s0mik has joined #openstack-dev | 04:02 | |
*** sniperd has quit IRC | 04:02 | |
*** sniperd has joined #openstack-dev | 04:06 | |
*** turlough has quit IRC | 04:07 | |
*** turlough has joined #openstack-dev | 04:07 | |
*** matwood_ has joined #openstack-dev | 04:17 | |
*** tgall_foo has quit IRC | 04:19 | |
*** matwood has quit IRC | 04:21 | |
*** matwood_ is now known as matwood | 04:21 | |
*** sniperd has quit IRC | 04:25 | |
*** nati_ueno has joined #openstack-dev | 04:28 | |
*** Exhar has joined #openstack-dev | 04:29 | |
*** Exhar has quit IRC | 04:33 | |
*** sacharya1 has quit IRC | 04:34 | |
*** turlough has quit IRC | 04:36 | |
*** johnpostlethwait has quit IRC | 04:37 | |
*** dachary has joined #openstack-dev | 04:37 | |
*** zhuadl has joined #openstack-dev | 04:49 | |
*** dayou has joined #openstack-dev | 04:58 | |
*** steveb_ has joined #openstack-dev | 05:00 | |
*** koolhead17 has joined #openstack-dev | 05:01 | |
*** s0mik has quit IRC | 05:02 | |
*** dolphm has joined #openstack-dev | 05:05 | |
*** matwood has quit IRC | 05:12 | |
*** matwood has joined #openstack-dev | 05:13 | |
*** sunxin has quit IRC | 05:14 | |
*** matwood_ has joined #openstack-dev | 05:23 | |
*** zaitcev has quit IRC | 05:24 | |
*** matwood has quit IRC | 05:28 | |
*** matwood_ is now known as matwood | 05:28 | |
*** Exhar has joined #openstack-dev | 05:29 | |
*** william0 has quit IRC | 05:31 | |
*** sunxin has joined #openstack-dev | 05:32 | |
*** william0 has joined #openstack-dev | 05:32 | |
*** Exhar has quit IRC | 05:34 | |
*** anniec has joined #openstack-dev | 05:36 | |
*** Mandell has quit IRC | 05:36 | |
*** lifeless has joined #openstack-dev | 05:50 | |
*** johnpostlethwait has joined #openstack-dev | 05:50 | |
*** Mandell has joined #openstack-dev | 05:56 | |
*** johnpostlethwait has quit IRC | 05:57 | |
*** roge has quit IRC | 05:58 | |
*** hattwick has quit IRC | 06:01 | |
*** dubsquared has quit IRC | 06:03 | |
*** mindpixel has joined #openstack-dev | 06:07 | |
*** almaisan-away is now known as al-maisan | 06:10 | |
*** mrunge has joined #openstack-dev | 06:13 | |
*** littleidea has quit IRC | 06:17 | |
*** dolphm has quit IRC | 06:20 | |
*** colinmcnamara has quit IRC | 06:21 | |
*** dayou has quit IRC | 06:22 | |
*** Exhar has joined #openstack-dev | 06:30 | |
*** Exhar has quit IRC | 06:34 | |
*** mokas has joined #openstack-dev | 06:45 | |
*** al-maisan is now known as almaisan-away | 06:46 | |
*** shang has quit IRC | 06:47 | |
*** Exhar has joined #openstack-dev | 06:49 | |
*** Exhar has quit IRC | 06:55 | |
*** salv-orlando has joined #openstack-dev | 06:59 | |
*** garyk has joined #openstack-dev | 07:05 | |
*** Exhar has joined #openstack-dev | 07:14 | |
*** Exhar has quit IRC | 07:25 | |
*** anniec_ has joined #openstack-dev | 07:25 | |
*** shang has joined #openstack-dev | 07:27 | |
*** anniec has quit IRC | 07:28 | |
*** anniec_ is now known as anniec | 07:28 | |
*** sunxin has quit IRC | 07:29 | |
*** zaneb has joined #openstack-dev | 07:36 | |
*** dolphm has joined #openstack-dev | 07:37 | |
*** william0 has quit IRC | 07:38 | |
*** william0 has joined #openstack-dev | 07:39 | |
*** EmilienM has joined #openstack-dev | 07:39 | |
*** derekh has joined #openstack-dev | 07:43 | |
*** Lumiere has quit IRC | 07:46 | |
*** Mandell has quit IRC | 07:47 | |
*** zhuadl has quit IRC | 07:56 | |
*** erikzaadi has joined #openstack-dev | 07:59 | |
*** zhuadl has joined #openstack-dev | 08:00 | |
*** zing has joined #openstack-dev | 08:07 | |
*** william0 has quit IRC | 08:09 | |
*** davidha has quit IRC | 08:09 | |
*** davidha has joined #openstack-dev | 08:10 | |
*** pixelbeat has joined #openstack-dev | 08:14 | |
*** davidha has quit IRC | 08:15 | |
*** almaisan-away is now known as al-maisan | 08:18 | |
*** lifeless has quit IRC | 08:32 | |
*** lifeless has joined #openstack-dev | 08:33 | |
*** darraghb has joined #openstack-dev | 08:34 | |
*** winston-d has quit IRC | 08:36 | |
*** winston-d has joined #openstack-dev | 08:37 | |
*** hattwick has joined #openstack-dev | 08:43 | |
*** negronjl has quit IRC | 08:45 | |
*** winston-d has quit IRC | 08:55 | |
*** apevec has joined #openstack-dev | 08:59 | |
*** apevec has joined #openstack-dev | 08:59 | |
*** davidha has joined #openstack-dev | 09:00 | |
*** samkottl1r has joined #openstack-dev | 09:03 | |
*** negronjl has joined #openstack-dev | 09:05 | |
*** samkottler has quit IRC | 09:05 | |
*** samkottl1r is now known as samkottler | 09:06 | |
*** danpb has joined #openstack-dev | 09:06 | |
*** lifeless has quit IRC | 09:06 | |
*** lifeless has joined #openstack-dev | 09:12 | |
*** nati_ueno has quit IRC | 09:13 | |
*** samkottler has quit IRC | 09:15 | |
*** samkottler has joined #openstack-dev | 09:15 | |
*** samkottler has quit IRC | 09:23 | |
*** samkottler has joined #openstack-dev | 09:24 | |
*** danwent has quit IRC | 09:32 | |
*** danwent has joined #openstack-dev | 09:46 | |
*** ncode has quit IRC | 09:46 | |
*** dave_mcn has joined #openstack-dev | 09:49 | |
*** dolphm has quit IRC | 09:51 | |
*** Exhar has joined #openstack-dev | 09:54 | |
*** kyriakos has joined #openstack-dev | 09:55 | |
*** Exhar has quit IRC | 09:56 | |
*** zhuadl has quit IRC | 10:05 | |
*** xchu has quit IRC | 10:10 | |
*** mjfork has joined #openstack-dev | 10:15 | |
*** sniperd has joined #openstack-dev | 10:15 | |
*** danwent has quit IRC | 10:38 | |
*** al-maisan is now known as almaisan-away | 10:45 | |
*** zaneb has quit IRC | 11:03 | |
*** rohitk has joined #openstack-dev | 11:05 | |
*** zaneb has joined #openstack-dev | 11:06 | |
*** dansmith has quit IRC | 11:16 | |
*** dansmith has joined #openstack-dev | 11:16 | |
*** koolhead17 has quit IRC | 11:17 | |
*** fss has joined #openstack-dev | 11:21 | |
*** wiliam has joined #openstack-dev | 11:26 | |
*** wiliam has quit IRC | 11:32 | |
*** rods has joined #openstack-dev | 11:32 | |
*** rods has quit IRC | 11:32 | |
*** alpha_ori has quit IRC | 11:34 | |
*** alpha_ori has joined #openstack-dev | 11:36 | |
*** swifterdarrell has quit IRC | 11:36 | |
*** swifterdarrell has joined #openstack-dev | 11:37 | |
*** jkoelker has quit IRC | 11:41 | |
*** jkoelker has joined #openstack-dev | 11:41 | |
*** cloudvirt has joined #openstack-dev | 11:47 | |
*** maurosr has joined #openstack-dev | 11:48 | |
*** almaisan-away is now known as al-maisan | 11:59 | |
*** al-maisan is now known as almaisan-away | 11:59 | |
*** almaisan-away is now known as al-maisan | 11:59 | |
*** shang has quit IRC | 12:01 | |
*** mnewby has joined #openstack-dev | 12:02 | |
*** benner has quit IRC | 12:05 | |
*** swifterdarrell has quit IRC | 12:06 | |
*** swifterdarrell has joined #openstack-dev | 12:06 | |
*** e1mer has quit IRC | 12:08 | |
*** cloudvirt has quit IRC | 12:10 | |
*** mrunge has quit IRC | 12:11 | |
*** mnewby has quit IRC | 12:11 | |
*** shang has joined #openstack-dev | 12:14 | |
*** koolhead17 has joined #openstack-dev | 12:18 | |
*** sniperd has quit IRC | 12:19 | |
*** lts has joined #openstack-dev | 12:21 | |
*** cloudvirt has joined #openstack-dev | 12:22 | |
*** hugokuo1 has quit IRC | 12:23 | |
*** fss has quit IRC | 12:25 | |
*** cdub has quit IRC | 12:26 | |
*** cdub has joined #openstack-dev | 12:26 | |
*** al-maisan is now known as almaisan-away | 12:27 | |
*** lorin1 has joined #openstack-dev | 12:32 | |
*** davidha1 has joined #openstack-dev | 12:32 | |
*** davidha has quit IRC | 12:33 | |
*** rods has joined #openstack-dev | 12:34 | |
*** almaisan-away is now known as al-maisan | 12:35 | |
*** Shrews has joined #openstack-dev | 12:37 | |
*** maploin has joined #openstack-dev | 12:38 | |
*** maploin has quit IRC | 12:38 | |
*** maploin has joined #openstack-dev | 12:38 | |
*** lifeless has quit IRC | 12:40 | |
*** benner has joined #openstack-dev | 12:41 | |
*** lifeless has joined #openstack-dev | 12:42 | |
*** maploin has quit IRC | 12:46 | |
zul | Daviey: can you +1 https://review.openstack.org/#/c/11387/ | 12:46 |
---|---|---|
*** sniperd has joined #openstack-dev | 12:46 | |
*** flaviamissi has joined #openstack-dev | 12:47 | |
*** roge has joined #openstack-dev | 12:47 | |
*** gongysh has joined #openstack-dev | 12:47 | |
gongysh | ping salvatore | 12:48 |
*** kbringard has joined #openstack-dev | 12:51 | |
*** fss has joined #openstack-dev | 12:53 | |
*** maploin has joined #openstack-dev | 12:54 | |
*** maploin has quit IRC | 12:54 | |
*** maploin has joined #openstack-dev | 12:54 | |
*** roge has quit IRC | 12:54 | |
*** chrisfer has joined #openstack-dev | 12:56 | |
*** kbringard has quit IRC | 13:01 | |
*** dprince has joined #openstack-dev | 13:01 | |
*** kbringard has joined #openstack-dev | 13:02 | |
*** mnewby has joined #openstack-dev | 13:04 | |
*** samkottler is now known as samkottler|mtg | 13:07 | |
*** rpedde_away is now known as rpedde | 13:16 | |
markmc | jgriffith, hey | 13:17 |
*** e1mer has joined #openstack-dev | 13:24 | |
*** jrd-redhat has quit IRC | 13:27 | |
*** reed has joined #openstack-dev | 13:28 | |
*** ayoung has joined #openstack-dev | 13:30 | |
*** PotHix has joined #openstack-dev | 13:33 | |
*** mnewby has quit IRC | 13:37 | |
*** mnewby has joined #openstack-dev | 13:39 | |
*** e1mer has quit IRC | 13:41 | |
*** e1mer has joined #openstack-dev | 13:42 | |
*** zhuadl has joined #openstack-dev | 13:45 | |
*** mtreinish has joined #openstack-dev | 13:51 | |
*** maoy has joined #openstack-dev | 13:54 | |
*** dansmith has quit IRC | 13:55 | |
*** lifeless_ has joined #openstack-dev | 13:55 | |
*** lifeless has quit IRC | 13:56 | |
*** gongysh has quit IRC | 13:57 | |
*** dansmith has joined #openstack-dev | 13:58 | |
*** dolphm has joined #openstack-dev | 13:59 | |
*** japage has joined #openstack-dev | 14:00 | |
*** nati_ueno has joined #openstack-dev | 14:02 | |
*** nati_ueno has quit IRC | 14:03 | |
*** mnewby has quit IRC | 14:03 | |
*** mnewby has joined #openstack-dev | 14:04 | |
*** derekh has quit IRC | 14:04 | |
*** nati_ueno has joined #openstack-dev | 14:09 | |
*** jrd-redhat has joined #openstack-dev | 14:12 | |
*** Gordonz has joined #openstack-dev | 14:12 | |
*** edygarcia has joined #openstack-dev | 14:12 | |
*** dkehn has joined #openstack-dev | 14:12 | |
*** Gordonz has quit IRC | 14:14 | |
*** tgall_foo has joined #openstack-dev | 14:14 | |
*** tgall_foo has quit IRC | 14:14 | |
*** tgall_foo has joined #openstack-dev | 14:14 | |
*** Gordonz has joined #openstack-dev | 14:14 | |
*** cloudvirt has quit IRC | 14:16 | |
*** winston-d has joined #openstack-dev | 14:16 | |
*** cloudvirt has joined #openstack-dev | 14:19 | |
jrd-redhat | salv-orlando ping | 14:19 |
*** littleidea has joined #openstack-dev | 14:20 | |
salv-orlando | jrd-redhat: pong | 14:20 |
*** ewindisch has joined #openstack-dev | 14:21 | |
*** nikhil_ has joined #openstack-dev | 14:23 | |
jrd-redhat | salv-orlando q regarding test code in quantum. I wrote a test for this rootwrap stuff I've been working on. top level TESTING file implies there should be a quantum/tests/functional subdir, which seems the obvious place to put it, but I don't see that dir. Is TESTING out of date? Should Icreate it? | 14:23 |
*** samkottler|mtg has quit IRC | 14:23 | |
*** samkottler has joined #openstack-dev | 14:23 | |
*** nikhil_ is now known as Guest60245 | 14:23 | |
salv-orlando | I am surprised to find that testing file is still there :) Are your tests unit tests? | 14:23 |
salv-orlando | or "functional" tests, meaning that they are designed to validate a whole functionality and hence touch different components of the system? | 14:25 |
*** Guest60245 has quit IRC | 14:25 | |
*** rnirmal has joined #openstack-dev | 14:28 | |
*** sacharya has joined #openstack-dev | 14:28 | |
jrd-redhat | salv-orlando I started by trying to make it a unit test, but it blew up tox. | 14:29 |
jrd-redhat | I talked it over with bob and gary and the concensus is that it should be outside the unit test framework. So had in mind to drop it in the functional area. But there isn't one :-) | 14:29 |
salv-orlando | Yep, I recall the issue you mentioned with tox. | 14:30 |
salv-orlando | We removed that functional directory ages ago, that's why I was surprised of seeing it mentioned again | 14:30 |
jrd-redhat | salv-orlando, well, ok, so TESTING is out of date. | 14:31 |
salv-orlando | How do you run these tests at the moment? | 14:31 |
*** zaneb has quit IRC | 14:31 | |
salv-orlando | jrd-redhat: definitely. I am already fixing it. Frankly I forgot it existed. | 14:31 |
jrd-redhat | Well, right now they're commented out. But what I was doing was running them as part of run_tests.sh | 14:31 |
*** zaneb has joined #openstack-dev | 14:31 | |
jrd-redhat | But that only works in something like a devstack env. Doesn' | 14:31 |
jrd-redhat | Doesn't work in tox. | 14:32 |
salv-orlando | I wonder if your tests are something that can be executed as a devstack exercise - a shell script to be run against a running devstack environment | 14:33 |
*** s0mik has joined #openstack-dev | 14:34 | |
jrd-redhat | salv-orlando sure, something like that would work. The key piece is that you have to have /etc/sudoers set up, as if in a real deployment. Given that, it's a simple command-line pass/fail test. | 14:34 |
*** nunosantos has joined #openstack-dev | 14:35 | |
salv-orlando | so it looks like the devstack exercise is a possible candidate, but still I would like to get coverage from the root wrap code in the unit tests. Do you have any idea whether nova-rootwrap is covered by unit tests? | 14:35 |
jrd-redhat | salv-orlando yes, it is. I've also added similar tests to the quantum rootwrap unit test suite. | 14:36 |
jrd-redhat | But the key bit which doesn't get tested in quantum, and as near as I can tell in nova either, is actually invoking an external command and proving that it ran as root. | 14:36 |
salv-orlando | I see. Then if we take out the unit tests which actually run commands as root, we shall be able to run them without breaking tox? | 14:38 |
jrd-redhat | salv-orlando yes, I believe that's correct. | 14:39 |
salv-orlando | great. so we can have at least *some* unit tests running, which is great. Coming back to your original question, I then think we can do the following: | 14:39 |
salv-orlando | push your tests for review as unit tests, but prepend the module name with an underscore | 14:40 |
jrd-redhat | salv-orlando oh, I think I missed that before. Prepending with underbar causes them to be skipped by the automatic stuff, eg tox? | 14:40 |
*** al-maisan is now known as almaisan-away | 14:41 | |
salv-orlando | Yes, if things haven't changed recently box will just scan for modules starting with "test_ | 14:41 |
salv-orlando | " | 14:41 |
jrd-redhat | salv-orlando ok, I see. So I should be able to put this back, as a unit test, called _test_rootwrap.py | 14:42 |
salv-orlando | correct. In this way jenkins will not complain and we can collectively decide the best course of action | 14:42 |
*** littleidea has quit IRC | 14:42 | |
salv-orlando | I think we can maybe just skip the unit tests that break tox with a flag or something similar | 14:42 |
*** littleidea has joined #openstack-dev | 14:43 | |
salv-orlando | and develop a devstack exercise script for them | 14:43 |
jrd-redhat | salv-orlando got it. Ok, I'll put that stuff back and post an updated patchset to review. | 14:43 |
salv-orlando | ok, great | 14:43 |
jrd-redhat | Tnx for the bits... | 14:43 |
*** s0mik has quit IRC | 14:48 | |
*** hemna has joined #openstack-dev | 14:50 | |
jgriffith | markmc: whats' up? | 14:52 |
markmc | jgriffith, hey | 14:52 |
markmc | jgriffith, I cc-ed you on a nova review which adds a "detaching" status | 14:52 |
jgriffith | markmc: Reading your comments now | 14:52 |
markmc | jgriffith, but actually had a more general question | 14:53 |
jgriffith | markmc: shoot | 14:53 |
markmc | jgriffith, which direction are we syncing nova/cinder stuff? cinder first, then sync into nova? | 14:53 |
jgriffith | markmc: My plan was cinder-->nova | 14:53 |
jgriffith | markmc: The gate tests are *only* running on cinder so that should be first | 14:53 |
markmc | jgriffith, ok, so nova-core should reject any cinder-relevant changes which aren't already in cinder? | 14:54 |
jgriffith | markmc: That would be my preference yes | 14:54 |
markmc | jgriffith, cool :) | 14:54 |
jgriffith | markmc: And it will make my life much simpler next week | 14:54 |
jgriffith | markmc: Or whenever I get around to syncing things up | 14:54 |
markmc | jgriffith, have we told other nova-core folks this? | 14:55 |
*** e1mer has quit IRC | 14:55 | |
jgriffith | markmc: Probably not, vish made the proposal last week but I don't know that he recommended anything to other core folks | 14:55 |
*** amotoki has quit IRC | 14:57 | |
*** winston-d has quit IRC | 14:58 | |
*** adalbas has joined #openstack-dev | 14:59 | |
*** mindpixel has quit IRC | 14:59 | |
*** zhuadl has quit IRC | 15:05 | |
*** datsun180b has joined #openstack-dev | 15:06 | |
*** dubsquared has joined #openstack-dev | 15:06 | |
*** dubsquared has quit IRC | 15:08 | |
smoser | hi. i'dl ike to add 'availability-zone' to the openstack metadata service. | 15:08 |
smoser | anyone think of a reason to object? it doesn't seem completely obvious to do this because availability-zone is obtained via "ec2utils.get_availability_zone_by_host(services, instance['host'])" | 15:09 |
smoser | but that peice of information, giving some info about the "cloud" that is being run on is extremely useful for a guest (ie, in EC2 ubuntu selects mirrors based on it). | 15:09 |
*** nati_ueno has quit IRC | 15:13 | |
smoser | well, i'm impatient, so | 15:13 |
smoser | https://bugs.launchpad.net/nova/+bug/1039579 | 15:13 |
uvirtbot | Launchpad bug 1039579 in nova "availability-zone should be available in openstack metadata" [Undecided,New] | 15:13 |
*** markmcclain has joined #openstack-dev | 15:13 | |
jgriffith | smoser: So I don't delve into the compute stuff much... but | 15:17 |
jgriffith | smoser: On volumes/cinder for example AZ is implemented independent | 15:18 |
*** cloudvirt has quit IRC | 15:18 | |
smoser | implemented independent ... ? | 15:18 |
jgriffith | smoser: I would hate to see it via metadata for one component and as a stand alone setting in another | 15:18 |
jgriffith | smoser: So you actually set AZ via the client... or are you just saying you want to capture/store it there? | 15:19 |
jgriffith | smoser: So like.. "cinder create --availability_zone=blah 1" | 15:19 |
smoser | jgriffith, nah. i think i've failed to explain myself. | 15:19 |
jgriffith | smoser: Oh... ok, sorry then. | 15:20 |
smoser | in ec2, the instances can ask "where am i" (wget http://169.254.169.254.169/latest/metadata/placement/availability-zone) | 15:20 |
smoser | on ec2, that says 'us-east-1'. | 15:20 |
smoser | (err.. 'us-east-1a') | 15:20 |
jgriffith | smoser: got ya | 15:21 |
smoser | but the same basic principle applies. | 15:21 |
smoser | i want to know where this isntance is running, so i can use resources also in that same area. | 15:21 |
jgriffith | smoser: Hmm... sorry, guess I don't understand, I'll spin up a compute and see what you're talking about | 15:23 |
*** maploin has quit IRC | 15:23 | |
jgriffith | smoser: BTW I don't have an opinion, just interested :) | 15:23 |
smoser | ok, simplist use case (existing on ec2): | 15:24 |
maoy | jeblair: ping | 15:24 |
smoser | cloud-init says "oh look, i'm in 'us-east-1a' for my availability-zone". I am going to see if there is a mirror I can use at "http://us-east-1a.ec2.archive.ubuntu.com/ubuntu" | 15:25 |
*** hub_cap has joined #openstack-dev | 15:25 | |
smoser | as canonical runs mirrors in each zone, and that will be very close network-wise to the instance to get good performance. | 15:25 |
jeblair | maoy: pong | 15:26 |
smoser | jgriffith, on ec2, availability-zone of a volume has to match availability-zone of an instance. | 15:26 |
jgriffith | smoser: yeah... I got ya | 15:26 |
smoser | and i thought there was similar restriction in openstack. | 15:26 |
maoy | jeblair: need some help to understand how to play with the silent pipeline. thanks! | 15:26 |
maoy | jeblair: e.g. where do i look for output? | 15:27 |
jgriffith | smoser: So what I was wondering if there's some way to get what you want the same way as in Cinder rather than using metadata | 15:27 |
jgriffith | smoser: or if that even makes sense | 15:27 |
jgriffith | smoser: For example if you do a cinder show xxxxx.... you get the AZ for that volume | 15:27 |
jeblair | maoy: (just read your email btw) 1 sec... | 15:28 |
jgriffith | smoser: Then you could have smart scheduling to matching things up on snaps, attach etc etc | 15:28 |
maoy | jeblair: cool. | 15:28 |
smoser | jgriffith, yes. hte information is available via the api for an instance. | 15:28 |
smoser | but from inside the intsance i dont have api credentials. | 15:28 |
jgriffith | smoser: Ahhhhhh | 15:28 |
jeblair | maoy: https://jenkins.openstack.org/job/gate-nova-pylint/ | 15:28 |
jgriffith | smoser: Now I see what you're getting at | 15:28 |
*** dachary1 has joined #openstack-dev | 15:28 | |
jgriffith | smoser: Good point :) | 15:28 |
jeblair | maoy: each change proposed will trigger a build | 15:29 |
smoser | so, yes, you *could* always launch an instance with "mirror: http://provided-zone.ec2.archive.ubuntu.com" | 15:29 |
jeblair | maoy: you can see which change triggered the build when you click on the build | 15:29 |
smoser | but this removes that. and you dont actually have to specify a zone when you request an instnace. | 15:29 |
*** dachary has quit IRC | 15:29 | |
jgriffith | smoser: Right... I see what you're saying | 15:29 |
jgriffith | smoser: Makes sense to me now | 15:29 |
jgriffith | smoser: Thanks for explaining it to me | 15:29 |
maoy | jeblair: is there a way to click from reviews.openstack.org to here from a patch? | 15:30 |
smoser | the strange part of this is that the metadata code (existing) was going through "ec2_utils" to get to this bit of information | 15:30 |
smoser | which seemed strange. | 15:30 |
smoser | as if "availability-zone" is something relevant to openstack, it seemed wierd that it would go through ec2_utils to get it. | 15:30 |
jgriffith | smoser: Hmmm | 15:30 |
smoser | and if its not really relavant (but just "bolted on for ec2 compat") then i could see why we would'nt want to expose it there. | 15:30 |
jeblair | maoy: no -- it's too silent for that. :( | 15:30 |
jgriffith | smoser: I think it was just for ec2 compat, but I don't see why it has to be limited to that | 15:31 |
jeblair | maoy: if you rebase the patch where you add the pylint tox environment, it'll trigger that job -- so you should be able to see it work then | 15:32 |
maoy | jeblair: yup. found it: https://jenkins.openstack.org/job/gate-nova-pylint/1/console | 15:32 |
smoser | jgriffith, but it seems you're saying its part of cinder also, right? | 15:32 |
smoser | and it seems to me quite reasonable to restrict volume attachment by proximity | 15:33 |
smoser | and that availability-zone seems to provide some notion of proximity | 15:33 |
jeblair | maoy: ah cool. looks like the job was created just in time for the last rebase. :) | 15:33 |
smoser | if there is a better openstack way to get that info, i'm happy to provide *that* instead. | 15:33 |
maoy | jeblair: is the output parseable for you? | 15:33 |
*** cloudvirt has joined #openstack-dev | 15:34 | |
smoser | to be completley forthcoming, what I'm hoping we'll end up settling on is actual useful information in this availability-zone field. | 15:34 |
smoser | ie, something like: az-2.region-a.geo-1.hpcloud | 15:35 |
jgriffith | smoser: makes sense | 15:35 |
maoy | jeblair: it's not a coincidence. :p I rebased it after zuul change is merged. but couldn't find that page last night. :) | 15:36 |
jgriffith | smoser: So we moved it out to the client in cinder, but the same problem as you point out... the instance has no way of knowing | 15:36 |
jgriffith | smoser: But.. to do attach to an instance you need to be outside that layer anyway | 15:36 |
jgriffith | smoser: In other words you're going to create in AZ and attach all in the Openstack or Ec2 api | 15:37 |
jgriffith | smoser: You have the whole view of the world so to speak | 15:37 |
smoser | right. | 15:37 |
*** dachary1 is now known as dachary | 15:37 | |
*** andrewbogott_afk is now known as andrewbogott | 15:38 | |
*** hemna has quit IRC | 15:41 | |
*** Lumiere has joined #openstack-dev | 15:47 | |
kbringard | hey guys, I have a question about how we filter security groups requests in the API | 15:48 |
*** cp16net is now known as cp16net|away | 15:48 | |
*** cp16net|away is now known as cp16net | 15:48 | |
kbringard | or I guess, less a question and more a discussion to start :-D | 15:48 |
kbringard | iptables allows 0/0 as a source "alias" for all, but a lot of stuff only seems to like 0.0.0.0/0 | 15:49 |
kbringard | as Quantum becomes a core project and more people use stuff other than IPtables to enforce their security policies, where do we think is the best place to enforce/translate that? | 15:50 |
kbringard | is that something that should be done in the quantum output plugin? | 15:50 |
kbringard | should we enforce the full dotted quad at the API? | 15:50 |
*** hemna has joined #openstack-dev | 15:53 | |
*** sacharya has quit IRC | 15:55 | |
*** dubsquared has joined #openstack-dev | 15:55 | |
*** erikzaadi has quit IRC | 15:56 | |
*** tgall_foo has quit IRC | 15:56 | |
kbringard | I think my opinion is that it should be done at the output plugin… if the gear you're writing out to doesn't support 0/0, then it should be fairly trivial to catch and convert this one case | 15:57 |
*** lloydde has joined #openstack-dev | 16:00 | |
*** andrewbogott is now known as andrewbogott_afk | 16:01 | |
ijw | kbringard: it makes more sense to me to make the arguments either a canonical form or canonicalised at entry rather than at backend | 16:05 |
*** mokas has quit IRC | 16:07 | |
kbringard | ijw: yea, I'd agree… I'm just not really sure what canon is in this case | 16:08 |
kbringard | I've asked a few of the network guys here and they seem to think that 0/0 is fine | 16:08 |
*** andrewbogott_afk is now known as andrewbogott | 16:08 | |
*** JStoker has quit IRC | 16:08 | |
*** Guest_ has joined #openstack-dev | 16:09 | |
*** Guest_ is now known as roge | 16:09 | |
ijw | Well, true, but if we chose canonical then one of 0.0.0.0/0 and 0/0 is not canonical if they both mean the same thing. I'm thinking that converting to the most widely accepted format (I don't think anything would reject 0.0.0.0/0) in the API layer after receipt would mean minimal complexity in both the output layer and firewalling code. | 16:11 |
kbringard | maybe I should just open a bug and attach a patch to fix it in the API and let the chaos ensue there :-D | 16:11 |
ijw | Well, you'd probably get more feedback that way and the discussions would be recorded for posterity if anyone wanted to revisit it in the future... | 16:12 |
kbringard | yea, 's what I'm thinking | 16:12 |
kbringard | just wanted to start by asking here | 16:12 |
kbringard | in case someone had a strong argument either way, or if it'd been discussed already | 16:12 |
ijw | I have only a gut feeling, sorry ;) | 16:13 |
kbringard | hah, indeed | 16:13 |
kbringard | me too | 16:13 |
kbringard | my gut is telling me it's hungry | 16:13 |
*** sacharya has joined #openstack-dev | 16:13 | |
ijw | There's a corner case with secgroups, too, which is that non-IP protocols aren't dealt with afaik | 16:14 |
kbringard | yea, I think it only allows tcp/udp/icmp | 16:15 |
ijw | It doesn't even filter ipv6 if ipv6 is not enabled for the openstack cluster, from experiment | 16:15 |
ijw | (nor does it define the default, which seems to be protocols it doesn't know about are passed through) | 16:16 |
kbringard | ah so… I suppose that makes sense, but seems like a potential problem waiting to happen | 16:16 |
*** winston-d has joined #openstack-dev | 16:17 | |
ijw | Well, it's a little backward - the firewall's set up paranoid, so everything's closed till you open it. Unless it happens to be outside the scope of the firewall, in which case everything's open and you can't close it. | 16:17 |
*** Exhar has joined #openstack-dev | 16:17 | |
*** Dharmit has joined #openstack-dev | 16:18 | |
*** Dharmit has joined #openstack-dev | 16:18 | |
*** cloudvirt has quit IRC | 16:20 | |
*** Mandell has joined #openstack-dev | 16:20 | |
*** dspano has joined #openstack-dev | 16:20 | |
*** Exhar has quit IRC | 16:21 | |
*** colinmcnamara has joined #openstack-dev | 16:21 | |
kbringard | either way, it looks like the API could use some love in this area… at least in Essex you can do things like "nova secgroup-add-rule test tcp 22 22 10.0.4/0" | 16:23 |
kbringard | and it'll work | 16:23 |
kbringard | well, it'll accept the rule | 16:23 |
kbringard | no kind of idea what it'll do to iptables/quantum/whatever else | 16:23 |
kbringard | I see an is_valid_cidr method in utils.py in master, so I'm going to check stable/essex | 16:24 |
*** mokas has joined #openstack-dev | 16:25 | |
ijw | Do you know what it likes for ipv6? | 16:25 |
*** danpb has quit IRC | 16:25 | |
kbringard | not sure… I was only looking at v4 | 16:26 |
kbringard | it looks like in a couple of places it uses if netaddr.valid_ipv6(server_str): | 16:26 |
kbringard | for CIDR format it does netaddr.IPNetwork(address) then checks to see if there's an AddrFormatError from netaddr | 16:27 |
ijw | v6 is interesting because v6 addresses, even full ones, can be given in different forms, which could potentially mean that what's output is dependent on how you input it if you don't canonicalise, again | 16:27 |
kbringard | that's for both 4 and 6, but I don't know where or if this is used in the API | 16:27 |
kbringard | this is just in utils.py | 16:27 |
kbringard | I'm not super familiar with this part of the code | 16:28 |
kbringard | and yea, ip6 is going to be an interesting beast :-) | 16:28 |
kbringard | I say we offload it all to netaddr and let them deal with it ;-) | 16:28 |
*** JStoker has joined #openstack-dev | 16:29 | |
*** cloudvirt has joined #openstack-dev | 16:29 | |
ijw | Yeah, fraid it's a closed book to me too. I put a comment in that it's lacking docs, but I didn't actually investigate the code when I was using it, just applied guesswork | 16:29 |
*** nunosantos has quit IRC | 16:30 | |
*** nunosantos has joined #openstack-dev | 16:32 | |
*** markmc is now known as mcaway | 16:34 | |
*** EmilienM has left #openstack-dev | 16:37 | |
*** anniec has quit IRC | 16:39 | |
*** ayoung has quit IRC | 16:40 | |
*** mfer has joined #openstack-dev | 16:41 | |
*** hub_cap is now known as hub_cap_afk | 16:43 | |
*** mfer has quit IRC | 16:45 | |
*** thingee_zz is now known as thingee | 16:46 | |
*** ayoung has joined #openstack-dev | 16:48 | |
*** jog0 has joined #openstack-dev | 16:49 | |
*** reed has quit IRC | 16:51 | |
*** darraghb has quit IRC | 16:57 | |
*** cp16net is now known as cp16net|away | 16:59 | |
*** s0mik has joined #openstack-dev | 17:01 | |
*** utlemming has quit IRC | 17:04 | |
*** utlemming has joined #openstack-dev | 17:04 | |
*** cp16net|away is now known as cp16net | 17:04 | |
*** danwent has joined #openstack-dev | 17:05 | |
*** thingee is now known as thingee_zz | 17:07 | |
*** anniec has joined #openstack-dev | 17:07 | |
ijw | Any Quantum guys about? | 17:08 |
ijw | I'm just doing something that Quantum will let me do, but then screws up. I'm not quite sure if I'm looking at a change part-completed or what. | 17:08 |
*** anniec_ has joined #openstack-dev | 17:08 | |
*** patelna has joined #openstack-dev | 17:09 | |
*** anniec has quit IRC | 17:12 | |
*** anniec_ is now known as anniec | 17:12 | |
*** dubsquared1 has joined #openstack-dev | 17:14 | |
*** dubsquared has quit IRC | 17:15 | |
*** andrewsmedina has joined #openstack-dev | 17:16 | |
*** johnpur has joined #openstack-dev | 17:16 | |
*** ChanServ sets mode: +v johnpur | 17:16 | |
*** thingee_zz is now known as thingee | 17:22 | |
*** utlemming has quit IRC | 17:23 | |
swifterdarrell | If a Gerrit-initiated Jenkins run fails due to a transient error (eg. SSL handshake timeout pulling python-swfitclient from github: https://jenkins.openstack.org/job/gate-swift-docs/143/consoleFull), is there a way to resubmit the job to Jenkins without making a bogus change to generate a new PatchSet? | 17:23 |
*** utlemming has joined #openstack-dev | 17:23 | |
jgriffith | swifterdarrell: recheck or reverify | 17:23 |
dansmith | swifterdarrell: post a comment of just "recheck" | 17:23 |
swifterdarrell | jgriffith: dansmith: sweet, thanks! | 17:23 |
*** zing has quit IRC | 17:29 | |
*** Slower_ has joined #openstack-dev | 17:29 | |
*** ncode has joined #openstack-dev | 17:31 | |
*** winston-d is now known as winston-d_zzZ | 17:33 | |
*** garyk has quit IRC | 17:34 | |
colinmcnamara | Bswatz @ Netapp. are you on? | 17:35 |
*** Ryan_Lane has joined #openstack-dev | 17:39 | |
*** kyriakos has quit IRC | 17:42 | |
*** davidha1 has quit IRC | 17:43 | |
*** davidha1 has joined #openstack-dev | 17:44 | |
*** Exhar has joined #openstack-dev | 17:46 | |
*** hub_cap_afk is now known as hub_cap | 17:46 | |
*** koolhead17 has quit IRC | 17:47 | |
*** davidha1 has quit IRC | 17:49 | |
*** apevec has quit IRC | 17:50 | |
*** negronjl` has joined #openstack-dev | 18:01 | |
*** heckj has joined #openstack-dev | 18:02 | |
*** dubsquared1 has quit IRC | 18:02 | |
*** dubsquared has joined #openstack-dev | 18:02 | |
*** negronjl has quit IRC | 18:03 | |
*** edygarcia has quit IRC | 18:06 | |
hemna | devstack is failing to install for me | 18:07 |
hemna | apt is complaining about a bogus hash for python-tempita | 18:07 |
arosen | hey markmcclain, I was wondering if you knew off hand how to pass in multiple params into quantum via its cli? (For example, port-create <id> --fixed_ip = 1.1.1.1 --fixed_ip = 1.1.1.2 ? | 18:09 |
*** matwood has quit IRC | 18:09 | |
*** matwood has joined #openstack-dev | 18:10 | |
markmcclain | arosen: that should work | 18:11 |
*** matwood has quit IRC | 18:11 | |
arosen | markmcclain: i'm getting: duplicated options --fixed_ip 10.0.0.10 --fixed_ip 10.0.0.11 | 18:11 |
arosen | (quantum) port-create c4864d8a-91e2-4c59-9b38-4d94c0385b6e --fixed_ip 10.0.0.10 --fixed_ip 10.0.0.11 | 18:11 |
arosen | duplicated options --fixed_ip 10.0.0.10 --fixed_ip 10.0.0.11 | 18:11 |
*** zaneb has quit IRC | 18:15 | |
markmcclain | yeah… that's a bug | 18:17 |
*** rohitk has quit IRC | 18:18 | |
arosen | hrm it seems like that's the same for all the other fields that can take two+ params | 18:18 |
arosen | dns_nameserver etc | 18:18 |
ayoung | dprince, why didn | 18:21 |
ayoung | t | 18:21 |
ayoung | heh | 18:21 |
ayoung | dprince, why didn't this change re-smokestack: | 18:21 |
ayoung | https://review.openstack.org/#/c/10579/ | 18:21 |
dprince | ayoung: https://bugs.launchpad.net/glance/+bug/1039212 | 18:22 |
uvirtbot | Launchpad bug 1039212 in glance "AttributeError: 'CooperativeReader' object has no attribute 'read'" [Critical,In progress] | 18:22 |
dprince | ayoung: it did... the results failed however due to a critical Glance bug... which should be landing shortly. | 18:22 |
*** andrewbogott is now known as andrewbogott_afk | 18:23 | |
dprince | ayoung: When something is broken like this I usually "throw the switch" so it doesn't -1 everyone else's patch sets with the failure. | 18:23 |
dprince | ayoung: Essentially test are failing. Valid failures. But unrelated to your branch. | 18:23 |
dprince | ayoung: I could also go and turn off those tests. In this case I just decided to fix it. | 18:24 |
ayoung | dprince, is there an equivalent to recheck for smokestack like there is for jenkins? | 18:24 |
*** rohitk has joined #openstack-dev | 18:24 | |
dprince | ayoung: I haven't written that yet. Bellows is listening to streaming Gerrit events so it wouldn't be too hard if people are interested. | 18:26 |
dprince | ayoung: Would 'smokeit' be a better term? | 18:26 |
ayoung | resmoke | 18:27 |
*** sstent has quit IRC | 18:27 | |
dprince | ayoung: I can do that. | 18:27 |
ayoung | dprince, +1 | 18:27 |
*** sstent has joined #openstack-dev | 18:28 | |
*** anniec has quit IRC | 18:28 | |
*** anniec has joined #openstack-dev | 18:29 | |
*** zaitcev has joined #openstack-dev | 18:29 | |
*** matwood has joined #openstack-dev | 18:30 | |
kbringard | is nova-volume required to run horizon? | 18:32 |
*** koolhead17 has joined #openstack-dev | 18:34 | |
*** rohitk has quit IRC | 18:34 | |
*** hub_cap has quit IRC | 18:35 | |
*** dubsquared has quit IRC | 18:38 | |
*** salv-orlando has quit IRC | 18:40 | |
*** samkottler is now known as samkottler|afk | 18:41 | |
*** dubsquared has joined #openstack-dev | 18:42 | |
*** davidha has joined #openstack-dev | 18:49 | |
annegentle | kbringard: according to this doc bug, yes https://bugs.launchpad.net/openstack-manuals/+bug/978510 | 18:53 |
uvirtbot | Launchpad bug 978510 in openstack-manuals "Install and Deploy Manual needs clearer nova volume instructions" [Medium,Fix released] | 18:53 |
kbringard | annegentle: ah ha, thanks | 18:54 |
*** chrisfer has quit IRC | 18:55 | |
colinmcnamara | @kbringard horizon connects to keystone, and nova-api's off top of my head | 18:56 |
*** chrisfer has joined #openstack-dev | 18:56 | |
*** chrisfer has quit IRC | 18:59 | |
*** cloudvirt has quit IRC | 19:00 | |
*** chrisfer has joined #openstack-dev | 19:01 | |
maoy | jeblair: is it possible to attach the pylint result in the jenkins comment, although do not rely it's success/fail input in the gating function? | 19:07 |
*** daddyjoseph97 has joined #openstack-dev | 19:08 | |
ayoung | dolphm, heckj if the meeting is at 1800 EDT I can't make it...I am on a bus then. | 19:08 |
heckj | it's 1400 PST, so I think that means it's 1700 EDT (not entirely sure though) | 19:09 |
*** dubsquared has quit IRC | 19:10 | |
heckj | ayoung: I know there's a mapper for cities - second... | 19:10 |
*** andrewbogott_afk is now known as andrewbogott | 19:11 | |
heckj | ayoung: http://www.timeanddate.com/worldclock/fixedtime.html?iso=20120828T21 | 19:11 |
heckj | looks like 5pm | 19:11 |
heckj | (for you) | 19:11 |
jeblair | maoy: why don't you join #openstack-meeting, we're having a CI meeting there right now | 19:12 |
ayoung | heckj, OK, I can cover, unless dolphm wants to | 19:12 |
ayoung | anything in particular you want me to bring up? | 19:12 |
heckj | ayoung: nope, I think most everything is solid - just need someone there to answer ttx's questions | 19:12 |
ayoung | OK...can do | 19:12 |
heckj | ayoung: thxusir | 19:13 |
*** cloudvirt has joined #openstack-dev | 19:14 | |
*** thingee is now known as thingee_zz | 19:15 | |
*** fss has quit IRC | 19:17 | |
*** heckj has quit IRC | 19:18 | |
dolphm | ayoung: i might be asleep | 19:19 |
dolphm | ayoung: i've been up for 28ish hours | 19:19 |
dolphm | ayoung: so, not going to commit to anything :P | 19:19 |
ayoung | dolphm, get some rest. If you haven't got your health, you haven't got anything | 19:19 |
dolphm | ayoung: i have sufficient coffee for now :) | 19:20 |
*** novas0x2a|laptop has joined #openstack-dev | 19:22 | |
*** koolhead17 has quit IRC | 19:22 | |
*** mcaway is now known as markmc | 19:22 | |
*** markmcclain has quit IRC | 19:24 | |
*** thingee_zz is now known as thingee | 19:25 | |
*** koolhead17 has joined #openstack-dev | 19:35 | |
dansmith | davidkranz: around (and free) ? | 19:36 |
*** markmcclain has joined #openstack-dev | 19:37 | |
*** colinmcnamara has quit IRC | 19:41 | |
*** mokas has quit IRC | 19:51 | |
*** dhellmann has joined #openstack-dev | 19:51 | |
zykes- | any peeps around on the horizon team ? | 19:52 |
*** lifeless_ is now known as lifeless | 19:57 | |
*** cloudvirt has quit IRC | 19:59 | |
*** heckj has joined #openstack-dev | 20:00 | |
*** cloudvirt has joined #openstack-dev | 20:01 | |
*** bitblt has joined #openstack-dev | 20:04 | |
*** ewindisch_ has joined #openstack-dev | 20:13 | |
*** ewindisch has quit IRC | 20:15 | |
*** ewindisch_ is now known as ewindisch | 20:15 | |
*** colinmcnamara has joined #openstack-dev | 20:17 | |
*** dprince has quit IRC | 20:18 | |
*** dwchadwick has joined #openstack-dev | 20:19 | |
*** cp16net is now known as cp16net|away | 20:21 | |
*** markmcclain has quit IRC | 20:22 | |
vishy | rmk: ping | 20:23 |
rmk | vishy: howdy | 20:23 |
vishy | rnk: just noticing that hard reboot doesn't work if you don't have the domain defined | 20:24 |
vishy | * rmk | 20:24 |
vishy | I'm wondering if it should catch domain_not_found and reboot from libvirt.xml | 20:24 |
rmk | That's true, the domain is only defined on compute start (in theory) | 20:25 |
rmk | I think it's a good idea | 20:25 |
*** Exhar has joined #openstack-dev | 20:26 | |
rmk | The more cases we can catch/resolve issues with a reboot, the better -- and I've certainly run into not having domains defined in the past | 20:26 |
*** markmcclain has joined #openstack-dev | 20:27 | |
vishy | rmk: wait it will redefine the domain on compute start now? | 20:30 |
vishy | rmk: i see resume state doing the same thing | 20:30 |
vishy | looks like it will fail if the domain is not defined | 20:31 |
*** colinmcnamara has quit IRC | 20:31 | |
*** Ruetobas has quit IRC | 20:32 | |
*** markmcclain has quit IRC | 20:33 | |
*** markmcclain has joined #openstack-dev | 20:34 | |
rmk | Hmm, I could swear domains were re-registered under some circumstance. I just checked my notes for the last time I did a set of cold VM migrations and didn't need to do domain definitions. Maybe something has changed recently. | 20:35 |
vishy | rmk: cold vm migrations, as in moved from one to the other | 20:35 |
rmk | Right, as in bringing up VMs which were in a shutdown state up on a different hypervisor. | 20:36 |
rmk | Essentially via either NAS or moving files around and updating database entries with the destination hypervisor for the instances being moved. | 20:36 |
rmk | All I had to do was restart compute on the destination node and issue reboots to each of the instances which were moved. | 20:37 |
davidkranz | dansmith: Ping. | 20:38 |
*** Ruetobas has joined #openstack-dev | 20:38 | |
rmk | vishy: I'll test this now on one of our essex deployments. | 20:39 |
vishy | rmk: thanks. I just tried a reboot on essex with undefined xml and it blew up | 20:39 |
dansmith | davidkranz: 64 bytes from dansmith... | 20:40 |
davidkranz | dansmith: ??? | 20:40 |
rmk | vishy: Would suggest setting resume_guests_state_on_host_boot if it isn't and restarting compute before the reboot. | 20:40 |
rmk | replicating now.. | 20:40 |
dansmith | davidkranz: ...sorry, icmp joke :) | 20:40 |
davidkranz | dansmith: :) | 20:41 |
davidkranz | dansmith: I believe there are two real bugs in tempest/nova now. | 20:41 |
rmk | vishy: The other option is to just always define it on reboot and ignore any "already defined" errors. | 20:41 |
davidkranz | I have posted a fix for one which I am going to push through and then submit a skip for the other. | 20:41 |
rmk | which is pretty much what you're proposing | 20:42 |
dansmith | davidkranz: so you think that nova should not be raising NotFound there? | 20:43 |
davidkranz | dansmith: I don't know but this must have changed since this result is not flakey and the code must have worked in the past. | 20:44 |
dansmith | davidkranz: right, so did you see my proposal for this? https://review.openstack.org/#/c/11511/ | 20:44 |
dansmith | I couldn't find where that had changed recently in nova or glance, but I can see an argument for NotFound being the right exception to raise | 20:44 |
*** cp16net|away is now known as cp16net | 20:44 | |
dansmith | davidkranz: if you want me to abandon that, just say the word and I'll nix it :) | 20:45 |
davidkranz | dansmith: No, I just looked. We don't want to do that until we verify that nova did not change. Such a change would not be allowed under the API stability guidelines. | 20:45 |
vishy | rmk: i like reboot using the existing xml if it exists but falling back | 20:45 |
davidkranz | dansmith: I haven't had a chance to investigate that. | 20:45 |
dansmith | davidkranz: okay, that's why I put the BFW on there | 20:45 |
davidkranz | dansmith: THe other failure is in test_images. It seems to be fairly predictable in the devstack gate but I cannot reproduce it locally. | 20:46 |
dansmith | davidkranz: I can reproduce it off and on locally, but usually not | 20:46 |
davidkranz | dansmith: I think if we skip that test it will unblock the queue. | 20:47 |
dansmith | davidkranz: hmm, okay, seems like we've got more problems than that | 20:48 |
dansmith | for example: | 20:48 |
dansmith | https://jenkins.openstack.org/job/gate-tempest-devstack-vm/8627/consoleFull | 20:48 |
dansmith | that's test_list_server_filters | 20:48 |
dansmith | unless you think it's fallout from the previous test_images or something | 20:48 |
davidkranz | dansmith: That may have to do with some xml changes. I am going to submit the other skip now and then we will see. | 20:50 |
dansmith | hmm, okay, it's on the json side, but okay | 20:50 |
dansmith | davidkranz: with my small devstack VM, I often get cascading failues that seem to be related to instances that aren't cleaned up from previous tests, | 20:52 |
dansmith | davidkranz: so I added this to see if it would help: https://review.openstack.org/#/c/11729/ | 20:52 |
dansmith | davidkranz: does that seem reasonable? | 20:52 |
rmk | vishy: Wow yeah, I can't get it to re-register the domain following the same process I've used in the past. | 20:53 |
*** dolphm has quit IRC | 20:53 | |
vishy | rmk: yeah i though tthere was something up there :) | 20:53 |
*** jrd-redhat has quit IRC | 20:53 | |
davidkranz | dansmith: We can't do that because we can't assume that all servers are "owned" by tempest. | 20:53 |
davidkranz | dansmith: Let me submit the skip and move things forward for now. | 20:54 |
dansmith | davidkranz: well, we can if we're in isolated mode, right? | 20:54 |
dansmith | davidkranz: cool, thanks | 20:54 |
davidkranz | dansmith: Yes, perhaps we could in that case. | 20:55 |
*** gabrielhurley has joined #openstack-dev | 20:55 | |
dansmith | davidkranz: okay, I'll adjust accordingly and then you (et al) can decide via gerrit vote :) | 20:56 |
*** heckj has quit IRC | 20:56 | |
*** johnpur has quit IRC | 20:56 | |
*** johnpur has joined #openstack-dev | 20:57 | |
*** ChanServ sets mode: +v johnpur | 20:57 | |
dansmith | on a somewhat-related note..I feel really sorry for the machine that runs jenkins | 21:00 |
*** anniec has quit IRC | 21:00 | |
rmk | vishy: we should also look at making reboot an option regardless of instance state | 21:03 |
rmk | vishy: managed to get this vm into a "failed" state where I know the reboot changes we're making would sort it | 21:04 |
*** maurosr has quit IRC | 21:06 | |
*** anniec has joined #openstack-dev | 21:08 | |
*** devanand1 has joined #openstack-dev | 21:10 | |
*** devanand1 is now known as deva | 21:10 | |
*** devananda has quit IRC | 21:11 | |
*** mnewby has quit IRC | 21:11 | |
*** mnewby has joined #openstack-dev | 21:14 | |
*** edygarcia has joined #openstack-dev | 21:18 | |
*** lorin1 has quit IRC | 21:19 | |
*** deva is now known as devananda | 21:20 | |
hemna | how can I override the nova-volume driver with devstack (essex) ? | 21:23 |
hemna | added the setting in /etc/nova/nova.conf and running stack.sh doesn't seem to do it. | 21:24 |
*** maoy has quit IRC | 21:24 | |
*** Exhar has quit IRC | 21:25 | |
dansmith | davidkranz: your patch hit the server filters error as well, not based on the xml tree, so I think it's legitimately broken/fragile :) | 21:26 |
davidkranz | dansmith: Yes, I just saw that. Will include a skip for that too :( | 21:26 |
dansmith | davidkranz: okay, cool | 21:26 |
dansmith | jenkins is soooooo picky :) | 21:26 |
*** dolphm has joined #openstack-dev | 21:30 | |
*** s0mik has quit IRC | 21:30 | |
*** cloudvirt has left #openstack-dev | 21:31 | |
*** ewindisch has quit IRC | 21:32 | |
*** mtreinish has quit IRC | 21:32 | |
arosen | Hi rkukura: you around? | 21:32 |
*** dolphm has quit IRC | 21:32 | |
*** dhellmann has quit IRC | 21:33 | |
*** s0mik has joined #openstack-dev | 21:34 | |
*** dhellmann has joined #openstack-dev | 21:35 | |
*** lts has quit IRC | 21:37 | |
*** Dharmit has quit IRC | 21:37 | |
*** patelna has quit IRC | 21:42 | |
*** rnirmal has quit IRC | 21:44 | |
*** mokas has joined #openstack-dev | 21:49 | |
*** dwchadwick has quit IRC | 21:49 | |
*** pixelbeat has quit IRC | 21:53 | |
*** dolphm has joined #openstack-dev | 21:54 | |
*** littleidea has quit IRC | 21:55 | |
devananda | vishy: when you have a minute, i'm curious what you're thoughts will be on review #11678 | 21:56 |
*** ewindisch has joined #openstack-dev | 21:57 | |
*** Gordonz has quit IRC | 21:57 | |
*** ayoung has quit IRC | 22:01 | |
rmk | vishy: OK so the domain is already being created on hard reboot. There are just calls before it happens which prevent it from getting there. I'll pastebin a patch for Essex in a second and if you agree with the approach I'll propose one for Folsom too. | 22:02 |
*** nunosantos has quit IRC | 22:03 | |
*** flaviamissi has quit IRC | 22:05 | |
ttx | vishy, markmc: so should we just encourage everyone in nova-core and volunteers to take at least 5 bugs off from that list, first come first serve ? | 22:05 |
vishy | zmk: yes that is what i was saying, it needs to catch the domain not found | 22:05 |
*** anniec_ has joined #openstack-dev | 22:05 | |
ttx | List at: https://bugs.launchpad.net/nova/+bugs?field.status=NEW&field.importance=UNDECIDED | 22:05 |
*** kbringard has quit IRC | 22:05 | |
rmk | vishy: Or just read the xml from disk everytime and pass it to create domain, which is already being called at hard reboot. | 22:06 |
rmk | Again looking at Essex but I don't think it's different in folsom. | 22:06 |
markmc | ttx, I'd have more hope of getting 5 volunteers to knock of 20 each | 22:06 |
*** anniec has quit IRC | 22:06 | |
*** anniec_ is now known as anniec | 22:06 | |
*** dspano has quit IRC | 22:07 | |
ttx | markmc: count me in | 22:07 |
* ttx will try to do 20 tomorrow. | 22:07 | |
rmk | OK yeah folsom is pretty much doing the same thing | 22:07 |
vishy | rmk: as i said i think it should read xml from the domain if it exists | 22:07 |
*** gabrielhurley has quit IRC | 22:07 | |
vishy | rmk: otherwise it should read from disk | 22:07 |
markmc | ttx, so, we'll have at least 40 less this time tomorrow :) | 22:07 |
ttx | markmc: I'd like to make sure we go down to 0 and stay there | 22:08 |
ttx | markmc: ideas on the other 3 victims ? | 22:08 |
markmc | ttx, yep, it's the only way to be sure to catch important stuff as it comes in | 22:08 |
markmc | ttx, I'll ping pixelbeat and dprince | 22:09 |
markmc | ttx, russellb and eglynn would have been up for it, but they're on vaca | 22:09 |
ttx | markmc: ok, sounds good. I guess vishy and/or crew can take a few too | 22:10 |
* ttx goes ot bed now, long triaging day ahead | 22:10 | |
arosen | hiya med_ | 22:10 |
*** pixelbeat has joined #openstack-dev | 22:10 | |
*** matwood has quit IRC | 22:11 | |
*** matwood has joined #openstack-dev | 22:12 | |
*** utlemming has quit IRC | 22:12 | |
*** devananda has quit IRC | 22:15 | |
*** utlemming has joined #openstack-dev | 22:15 | |
*** Slower_ is now known as Slower | 22:16 | |
*** samkottler|afk is now known as samkottler | 22:16 | |
*** devananda has joined #openstack-dev | 22:16 | |
*** andrewsmedina has quit IRC | 22:17 | |
*** dolphm has quit IRC | 22:19 | |
*** markmcclain has quit IRC | 22:19 | |
*** markmc is now known as mcaway | 22:20 | |
*** daddyjoseph97 has quit IRC | 22:21 | |
*** daddyjoseph97 has joined #openstack-dev | 22:22 | |
*** aclark_ has joined #openstack-dev | 22:24 | |
med_ | arosen, howdy. | 22:24 |
med_ | sorry, was afk a bit. | 22:25 |
*** ewindisch has quit IRC | 22:27 | |
*** edygarcia has quit IRC | 22:33 | |
*** datsun180b has quit IRC | 22:33 | |
*** davidha2 has joined #openstack-dev | 22:36 | |
*** davidha has quit IRC | 22:37 | |
*** sacharya has quit IRC | 22:37 | |
*** mnewby has quit IRC | 22:38 | |
*** mnewby has joined #openstack-dev | 22:39 | |
*** mnewby has quit IRC | 22:39 | |
*** mnewby has joined #openstack-dev | 22:39 | |
*** samkottler is now known as samkottler|afk | 22:42 | |
*** matwood has quit IRC | 22:42 | |
*** ewindisch has joined #openstack-dev | 22:42 | |
*** maurosr has joined #openstack-dev | 22:43 | |
*** davidha2 has quit IRC | 22:45 | |
*** davidha has joined #openstack-dev | 22:47 | |
*** maurosr has quit IRC | 22:47 | |
*** maurosr has joined #openstack-dev | 22:49 | |
dansmith | davidkranz: welcome to my world for the last week :) | 22:52 |
*** jimfehlig has quit IRC | 22:53 | |
*** maurosr has quit IRC | 22:53 | |
*** maurosr has joined #openstack-dev | 22:54 | |
rmk | vishy: http://paste.openstack.org/show/NyVFGYrEsrnZkCwYQG7A/ | 22:54 |
*** maurosr has quit IRC | 22:58 | |
*** anniec_ has joined #openstack-dev | 23:07 | |
*** bitblt has quit IRC | 23:09 | |
*** anniec has quit IRC | 23:09 | |
*** anniec_ is now known as anniec | 23:09 | |
*** shang has quit IRC | 23:10 | |
*** maurosr has joined #openstack-dev | 23:12 | |
*** lloydde has quit IRC | 23:12 | |
*** winston-d_zzZ has quit IRC | 23:14 | |
*** aclark_ has quit IRC | 23:14 | |
*** mnewby has quit IRC | 23:18 | |
*** daddyjoseph97 has quit IRC | 23:18 | |
*** mokas has quit IRC | 23:18 | |
*** Hitesh has joined #openstack-dev | 23:22 | |
*** e1mer has joined #openstack-dev | 23:28 | |
*** dolphm has joined #openstack-dev | 23:29 | |
*** flaviamissi has joined #openstack-dev | 23:32 | |
*** dolphm has quit IRC | 23:34 | |
*** ev0ldave has joined #openstack-dev | 23:36 | |
ev0ldave | are there plans for declaring cpu topology through instance flavors? | 23:37 |
*** dhellmann has quit IRC | 23:37 | |
*** markmcclain has joined #openstack-dev | 23:37 | |
*** ev0ldave has quit IRC | 23:39 | |
*** andrewsmedina has joined #openstack-dev | 23:42 | |
*** s0mik has quit IRC | 23:43 | |
*** sniperd has quit IRC | 23:45 | |
*** dhellmann has joined #openstack-dev | 23:45 | |
jgriffith | devananda: ping | 23:48 |
devananda | jgriffith: pong | 23:49 |
jgriffith | devananda: Hey... I was wondering about your work on bug: https://bugs.launchpad.net/cinder/+bug/1007038 | 23:49 |
uvirtbot | Launchpad bug 1007038 in nova "Nova is issuing unnecessary ROLLBACK statements to MySQL" [Low,In progress] | 23:49 |
jgriffith | devananda: Is that going to move forward for RC1 or has it been abandoned? | 23:50 |
devananda | jgriffith: ah, right. so I have a patch up that sort of fixes it | 23:50 |
devananda | however it is a little more "zealous" in retrying queries than some folks may like | 23:50 |
devananda | I think it'll work 95% of the time, which is better than the 0% now | 23:50 |
jgriffith | devananda: this one: https://review.openstack.org/#/c/10797/ | 23:50 |
devananda | jgriffith: yes | 23:51 |
jgriffith | devananda: Ok | 23:51 |
jgriffith | devananda: Noticed it was stalled/expired, and didn't know what kind of feedback or plans you had for it | 23:51 |
devananda | jgriffith: to be completely correct, and never retry queries that shouldn't be retried, we need a change inside sqlalchemy | 23:51 |
jgriffith | devananda: :( | 23:51 |
devananda | and i have no idea how long that will take, ... | 23:51 |
jgriffith | devananda: I gathered that in your write up of the bug | 23:52 |
devananda | so i am happy to leave it to you folks to decide: mostly-fix now, or leave as-is until we can do a complete fix | 23:52 |
jgriffith | devananda: I just thought I'd see if there were plans to move forward with this or if it was Grizzly candidate at this point | 23:52 |
jgriffith | devananda: Ok... I'll probably defer to the Nova side where you have it already | 23:52 |
jgriffith | devananda: I'll be synching changes between the two anyway | 23:53 |
jgriffith | devananda: thanks for the info | 23:53 |
devananda | jgriffith: sure thing | 23:53 |
jgriffith | devananda: FWIW I think *most* cases versus *no* cases is better :) | 23:54 |
devananda | me too ;) | 23:55 |
jgriffith | devananda: But at this point in the release cycle not sure it's criticial enough | 23:55 |
jgriffith | :( | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!