*** eharney has quit IRC | 00:01 | |
*** lifeless has joined #openstack-dev | 00:03 | |
*** otherwiseguy has joined #openstack-dev | 00:03 | |
*** mrdabot is now known as mrda | 00:06 | |
*** yuan has joined #openstack-dev | 00:06 | |
*** rods has quit IRC | 00:06 | |
*** fbo is now known as fbo_away | 00:09 | |
bknudson | morganfainberg: you should be able to +2 this one now: https://review.openstack.org/#/c/39818/ | 00:10 |
---|---|---|
morganfainberg | bknudson: i think we need to rebase it, haven't had a chance to try (local test shows git gets all sorts of confused) | 00:11 |
morganfainberg | bknudson: i'll do the rebase tonight if needed or +2 | 00:12 |
bknudson | morganfainberg: darn. that's what happens when they sit around for too long | 00:12 |
morganfainberg | yeah | 00:12 |
morganfainberg | i've been trying to get to the older ones as i can so they don | 00:12 |
*** sthaha has quit IRC | 00:12 | |
*** sthaha has joined #openstack-dev | 00:12 | |
morganfainberg | 't need it | 00:12 |
morganfainberg | i think the other tox.ini update needs a rebase as well | 00:12 |
morganfainberg | the h404 one | 00:12 |
*** sarob_ has joined #openstack-dev | 00:13 | |
morganfainberg | bknudson: i'm still trying to understand some of the tempest output, is this a recheck or something a bit deeper: https://review.openstack.org/#/c/36326/ | 00:13 |
*** SumitNaiksatam has quit IRC | 00:14 | |
*** sthaha has quit IRC | 00:14 | |
bknudson | morganfainberg: I haven't been able to figure tempest test failures. | 00:15 |
bknudson | look at all those logs! | 00:15 |
morganfainberg | bknudson: ok, i don't feel so bad then | 00:15 |
morganfainberg | bknudson: yeah. | 00:15 |
bknudson | morganfainberg: just guessing, but it looks like a transient failure. | 00:17 |
morganfainberg | bknudson: that was my guess | 00:17 |
*** sthaha has joined #openstack-dev | 00:17 | |
*** sarob has quit IRC | 00:17 | |
morganfainberg | but it's hard to decode some of those | 00:17 |
bknudson | morganfainberg: error in http://logs.openstack.org/26/36326/3/check/gate-tempest-devstack-vm-cells-full/3a6ff48/console.html.gz seems to indicate euca test failed to terminate instance... | 00:17 |
bknudson | not sure how that could be related to the change. | 00:17 |
morganfainberg | exactly | 00:17 |
morganfainberg | if it passes this time around i'll +2 it | 00:18 |
morganfainberg | just told it to recheck | 00:18 |
*** sarob_ has quit IRC | 00:18 | |
morganfainberg | i'll also get a rebase of the h404 one up if needed. | 00:20 |
morganfainberg | or at least a note to the effect that it needs a rebase | 00:21 |
*** wolfdreamer has quit IRC | 00:22 | |
*** gongysh has joined #openstack-dev | 00:23 | |
*** emagana has quit IRC | 00:25 | |
morganfainberg | bknudson: https://review.openstack.org/#/c/39818/ if it looks good now (and jenkins likes it) we should be able to push that through | 00:26 |
morganfainberg | just rebased it | 00:26 |
bknudson | morganfainberg: ok. need to wait for jenkins / smokestack. I got in trouble once for approving early. | 00:27 |
morganfainberg | bknudson: oh i totally understand :) | 00:27 |
morganfainberg | bknudson: i've had to play cleanup on my company's internal jenkins/gerrit setup because someone pushed something before it was validated | 00:28 |
morganfainberg | i'm sure it's harder with the full openstack setup vs. the stripped down stuff I am using internally (and it was still a pain) | 00:28 |
*** dina_belova has joined #openstack-dev | 00:29 | |
*** msmedved has joined #openstack-dev | 00:29 | |
*** lexinator has quit IRC | 00:31 | |
*** dina_belova has quit IRC | 00:31 | |
*** jhesketh has quit IRC | 00:36 | |
*** jhesketh has joined #openstack-dev | 00:36 | |
*** nati_ueno has quit IRC | 00:37 | |
*** edmund has quit IRC | 00:37 | |
*** sudorandom has joined #openstack-dev | 00:37 | |
morganfainberg | lbragstad_: just as an FYI, I've had git-review move the change-id on me in strange ways, maybe i'm doing something wrong (advice on why is of course welcome)? But I just noticed your NIT here: https://review.openstack.org/#/c/41378/1//COMMIT_MSG | 00:37 |
*** lexinator has joined #openstack-dev | 00:38 | |
bknudson | morganfainberg: I thought we had a new process for global requirements... | 00:38 |
gongysh | salv-orlando: ping | 00:39 |
lbragstad_ | morganfainberg: ahh no worries, it was a small comment, just wanted to make sure you were aware of it | 00:39 |
morganfainberg | bknudson: do we? | 00:39 |
morganfainberg | lbragstad_: it's not my fix, i just was commenting :) | 00:39 |
lbragstad_ | morganfainberg: ok | 00:39 |
morganfainberg | bknudson: oh is that the needs to be in the global-reqs repo thing? | 00:39 |
*** zigo has quit IRC | 00:40 | |
bknudson | morganfainberg: https://review.openstack.org/#/c/40284/ | 00:40 |
morganfainberg | right | 00:40 |
*** nati_ueno has joined #openstack-dev | 00:40 | |
*** pcm__ has quit IRC | 00:41 | |
*** zigo has joined #openstack-dev | 00:42 | |
*** rfolco has joined #openstack-dev | 00:42 | |
morganfainberg | bknudson: babel is in global requirements atm. or are you referencing something else? | 00:44 |
*** rwsu is now known as rwsu-away | 00:45 | |
bknudson | morganfainberg: The question is was it updated using https://github.com/openstack/requirements/blob/master/README.rst | 00:45 |
morganfainberg | oh that is a good question | 00:46 |
bknudson | or does that only remove old requirements? | 00:46 |
*** SumitNaiksatam has joined #openstack-dev | 00:46 | |
*** sudorandom has quit IRC | 00:46 | |
morganfainberg | that looks like it only removes requirements that aren't in global-reqs | 00:46 |
morganfainberg | and updates versions to match | 00:46 |
*** sulrich has quit IRC | 00:46 | |
*** sudorandom has joined #openstack-dev | 00:46 | |
bknudson | I'll try it and see what it does with this change. | 00:47 |
*** crazed has quit IRC | 00:47 | |
*** sulrich has joined #openstack-dev | 00:47 | |
*** bdpayne has quit IRC | 00:48 | |
*** nati_ueno has quit IRC | 00:48 | |
*** nati_ueno has joined #openstack-dev | 00:49 | |
bknudson | morganfainberg: looks like keystone has never had requirements update.py done yet... | 00:50 |
morganfainberg | oh dear | 00:50 |
morganfainberg | that sounds scary | 00:50 |
*** nati_uen_ has joined #openstack-dev | 00:51 | |
bknudson | morganfainberg: here it is: https://review.openstack.org/#/c/40756/ | 00:51 |
ayoung | jaypipes, so... 100K users . How should we search through that list. Forget pagination. What is the right solution? | 00:51 |
bknudson | didn't pass jenkins | 00:51 |
*** crazed has joined #openstack-dev | 00:51 | |
morganfainberg | bknudson: hm. | 00:52 |
jaypipes | ayoung: search != list... | 00:52 |
jaypipes | ayoung: just getting a list of users should be paged -- on the server side if the driver supports it. do you agree? | 00:52 |
ayoung | jaypipes, no. disagree | 00:52 |
ayoung | vehemently | 00:52 |
jaypipes | ayoung: can you elaborate? | 00:53 |
ayoung | jaypipes, think cloud scale | 00:53 |
ayoung | what if there are billions of users | 00:53 |
jaypipes | yes? | 00:53 |
ayoung | pagination is dumb | 00:53 |
jaypipes | wha? | 00:53 |
bknudson | if billions of users then can't get the whole list back ever. | 00:53 |
jamielennox | ayoung: you can't paginate ldap without maintaining a cursor/ | 00:53 |
bknudson | paged or not | 00:53 |
ayoung | bknudson, exatamundo | 00:53 |
jamielennox | ? | 00:53 |
ayoung | jamielennox, also correct | 00:53 |
morganfainberg | jamielennox: i think you're right. | 00:53 |
*** nati_ueno has quit IRC | 00:53 | |
jamielennox | ayoung: was a question? | 00:54 |
* jaypipes thinks we shouldn't hamstring deployments just because a particular driver doesn't support pagination. | 00:54 | |
ayoung | jaypipes, wrong | 00:54 |
jaypipes | ayoung: wroing | 00:54 |
ayoung | jaypipes, we shouldn't build broken architectures | 00:54 |
ayoung | seriosuly | 00:54 |
ayoung | I am not trying to be a pain here | 00:54 |
bknudson | we're already broken if you can get back all users | 00:54 |
ayoung | it is an Identity antipattern | 00:54 |
morganfainberg | bknudson: +1 | 00:54 |
bknudson | (attempt to get back all users) | 00:54 |
*** devoid has quit IRC | 00:55 | |
jamielennox | /users is a part of v3, we have to support it the best we can, if people want to iterate that then we should support pagination | 00:55 |
ayoung | jaypipes, I did not organize the keystone core devs here, but you can see they are all kindof agreeing with me. So, let me restart the question. For the user admin page, what are we trying to do? | 00:55 |
ayoung | jamielennox, forget that for now | 00:55 |
jaypipes | ayoung: I don't disagree that returning a list of all users is a bad idea. | 00:55 |
*** gordc has joined #openstack-dev | 00:56 | |
jamielennox | :( | 00:56 |
ayoung | lets get to the right solution, and we can figure out how to fix a broken api afterwards | 00:56 |
jaypipes | ayoung: but it is what the current API supports. | 00:56 |
jaypipes | ayoung: if I do a search in users, and that search returns thousands of records, you still have the same issue of needing some sort of pagination to be a workable list operation | 00:57 |
* jamielennox likes having design discussions at a reasonable hour | 00:57 | |
ayoung | jaypipes, you need to winnow the search. Next Next Next is a broken UI paradigm | 00:57 |
* ayoung likes having design discussions with beer. | 00:57 | |
jaypipes | ayoung: So I guess Google search is a broken design pattern. | 00:58 |
ayoung | win/win | 00:58 |
*** pmathews has joined #openstack-dev | 00:58 | |
ayoung | jaypipes, absolutely | 00:58 |
jaypipes | *sigh* | 00:58 |
ayoung | jaypipes, how often do you go to the second page? | 00:58 |
jaypipes | very often. | 00:58 |
bknudson | third page? | 00:58 |
ayoung | and the third? | 00:58 |
ayoung | heh | 00:58 |
jaypipes | quite often | 00:58 |
jaypipes | depends on the search | 00:59 |
morganfainberg | jaypipes: i think you might be in the minority though. | 00:59 |
bknudson | 100,000th page? | 00:59 |
jaypipes | clearly | 00:59 |
jaypipes | bknudson: never. | 00:59 |
ayoung | jaypipes, for users ,we have clear pattersn. Search by first name, search by last name...there are 50 results returned, if there are more than that, refine your search | 00:59 |
jaypipes | bknudson: but that's my point... the API should give some indication of the extent of the search results, and allow the user to requery with finer sargs | 00:59 |
ayoung | jaypipes, agreed! | 01:00 |
jaypipes | ayoung: that does not happen currently. | 01:00 |
bknudson | I would prefer to get keystone out of the users game. leave the users in ldap or whatever. | 01:00 |
jaypipes | bknudson: that ship has sailed. | 01:00 |
ayoung | bknudson, keystone needs to be an IdP for the time being. It is that side we are focused on. LDAP is a different story. | 01:00 |
jamielennox | bknudson: i agree, but we've got no option now | 01:01 |
bknudson | reinventing the wheel | 01:01 |
ayoung | bknudson, I am just trying to limit the common API such that it makes sense. LDAP is the tool to understand the issues, but even in Pure SQL I would argue pagination is probably a mistake | 01:01 |
morganfainberg | jaypipes: so if you were told 50 users shown, more than 50 results you'd be happy with that? [in some mechanism]? | 01:01 |
*** stevemar has joined #openstack-dev | 01:01 | |
ayoung | morganfainberg, need a way to refine the search after that | 01:02 |
morganfainberg | ayoung: right. | 01:02 |
jaypipes | morganfainberg: absolutely. | 01:02 |
ayoung | jaypipes, so a search API should allow a fragment of first, last, and username. | 01:03 |
ayoung | list users should not return anything if given no filter | 01:03 |
jaypipes | ayoung: email too... | 01:03 |
ayoung | jaypipes, yep | 01:03 |
morganfainberg | jaypipes: regardless of search fields, partial | 01:03 |
morganfainberg | for each | 01:03 |
jaypipes | ayoung: and agreed on not returning anything without filter... absolutely. | 01:03 |
ayoung | jaypipes, would that implementation work better for Horizon? | 01:04 |
ayoung | Anything else it would need? | 01:04 |
ayoung | the ones I was wondering about were like list users for groups | 01:04 |
jaypipes | ayoung: no, that would be excellent -- same for tenants as well, of course... | 01:04 |
ayoung | where thegroup was huge | 01:04 |
ayoung | and for projects | 01:05 |
jaypipes | morganfainberg: sorry, what was that? not sure what you're getting at there... are you asking whether partial search should be available for any field of a user/tenant record? if so, yes, I agree. | 01:05 |
ayoung | jaypipes, he was just generalizing what we were saying. | 01:05 |
jaypipes | ah, ok. | 01:06 |
morganfainberg | jaypipes: i was just commenting that partial for the search fields, regardless of the ones we specify as "search fields" | 01:06 |
jaypipes | ++ | 01:06 |
jaypipes | ayoung: are we discussing adding this functionality only to the v3 API and beyond? | 01:06 |
jaypipes | fine if we are... just curuios | 01:06 |
ayoung | jaypipes, I don't know. I want to understand what we should be doing before we write the schedule | 01:07 |
jaypipes | k | 01:07 |
*** Guest3077 has quit IRC | 01:07 | |
ayoung | jaypipes, obviosuly, this is a major change, and I don't think we can do it in the current API, but that still remains to be seen. Maybe we could. | 01:08 |
bknudson | if it's optional query parameters then should be able to add it. | 01:08 |
*** jasondotstar has joined #openstack-dev | 01:08 | |
*** yaguang has joined #openstack-dev | 01:08 | |
ayoung | jaypipes, I think that LDAP is going to be broken by large queries. I am surprised, however, that LDAP servers are set up to respond with "all" users | 01:09 |
ayoung | I thought it was fairly standard to have a query limit of a hundred or two | 01:09 |
jaypipes | well, I woudl support the following: 1) Changing the API to only return results if a search condition is supplied, 2) Using the same pagination parameters all the other projects currently use (limit + marker), 3) Partial search on all fields in the models, 4) allowing the search conditions to be pushed down to the drivers that support them, and 5) having a "~ X results found" part of the returned search result | 01:09 |
morganfainberg | ayoung: i think most servers have administrators that like to knock on people's doors to tell them they are doing bad things vs. limiting it internally | 01:09 |
jamielennox | the not returning anything if no query is given is not compatible | 01:09 |
ayoung | bknudson, and then a config option that says "return nothing if no filter" | 01:09 |
jamielennox | the rest could be supported with optional params | 01:09 |
ayoung | morganfainberg, not in large organizations. Too many doors | 01:10 |
bknudson | ayoung: +1, was just going to say backwards compatible probably ok if there's a config option. | 01:10 |
morganfainberg | ayoung: yeah, sadly i've still seen it :( | 01:10 |
jaypipes | jamielennox: agreed. it would have to be a major version bump, as it isn't back-compat | 01:10 |
ayoung | http://forums.penny-arcade.com/discussion/151331/trenches-comic-thursday-nov-10-2011-anguish | 01:10 |
*** Chaser has quit IRC | 01:10 | |
morganfainberg | config sounds reasonable. | 01:11 |
*** Chaser has joined #openstack-dev | 01:11 | |
morganfainberg | it feels like it's too early to push a major version bump, if it can be avoided. | 01:12 |
*** armax has left #openstack-dev | 01:12 | |
ayoung | Nah, config option is valid there. | 01:12 |
ayoung | But we need the filter first | 01:12 |
jamielennox | we should run it past horizon as well - does anyone know how they currently work with this? | 01:13 |
jaypipes | morganfainberg: can't really avoid it for backwards-incompatible changes. | 01:13 |
morganfainberg | jaypipes: i know, but in this case, i think the configuration option is viable in this case. | 01:13 |
jaypipes | jamielennox: sure, though horizon folks will use whatever the API provides... which , up until now, has been little or nothing | 01:14 |
ayoung | https://bugs.launchpad.net/keystone/+bug/1211582 | 01:14 |
uvirtbot | Launchpad bug 1211582 in keystone "Filter user list by partial attributes" [Wishlist,New] | 01:14 |
jaypipes | ++ | 01:14 |
jamielennox | is there/there should be a mechanism to expose settings like these over api | 01:15 |
ayoung | jamespage, query the config? | 01:15 |
bknudson | I think it will be obvious to clients if they get back no entries | 01:16 |
*** gordc has quit IRC | 01:16 | |
bknudson | or a result code with message | 01:16 |
ayoung | jamielennox, just don't put the SQL or LDAP urls in there | 01:16 |
jamielennox | bknudson: maybe, that or they think they have misconigured there identity backend and it found nothing | 01:16 |
morganfainberg | bknudson: +1 on the specific code saying "filter required" | 01:16 |
morganfainberg | returning nothing is a bad idea. | 01:16 |
morganfainberg | what if the search query returns legitimately nothing | 01:17 |
jamielennox | but i'm good with the specific code | 01:17 |
bknudson | morganfainberg: then the user can keep typing filters and they still won't get anything. | 01:17 |
ayoung | 413 Request Entity Too Large | 01:17 |
ayoung | 416 Requested Range Not Satisfiable | 01:17 |
bknudson | I think we return 413 for request entity too large already. | 01:17 |
morganfainberg | 416? | 01:17 |
jamielennox | 413 is better | 01:18 |
bknudson | 416 is used when range: header in request... which we could use for pagination. | 01:18 |
ayoung | 418 I'm a teapot (RFC 2324) | 01:18 |
bknudson | it's been used before. | 01:18 |
ayoung | Had to be said. Sorry | 01:18 |
ayoung | 425 Unordered Collection (Internet draft) | 01:18 |
bknudson | I'd probably go with 403 Forbidden. | 01:18 |
ayoung | I like that | 01:18 |
morganfainberg | ayoung: 402 - pay us money to fix this bug | 01:18 |
morganfainberg | :P | 01:18 |
bknudson | we need a more expressive error document. | 01:19 |
jamielennox | morganfainberg: probably a 5xx | 01:19 |
morganfainberg | ayoung: i think 425 would be nice. i think 413 is the wrong side of the request to be throwing it for | 01:20 |
morganfainberg | bknudson: 400 - bad request, filter required? | 01:20 |
bknudson | 400 typically means that the server couldn't understand the request | 01:20 |
bknudson | not that it didn't want to do it. | 01:20 |
morganfainberg | right | 01:21 |
morganfainberg | malformed syntax | 01:21 |
ayoung | maybe 412 Precondition Failed | 01:21 |
ayoung | IE...no filter | 01:21 |
morganfainberg | maybe 417? Expectation Failed? | 01:21 |
morganfainberg | but that seems to be mroe proxy related | 01:21 |
ayoung | Expect request-header field (see section 14.20) | 01:22 |
morganfainberg | yeah | 01:22 |
bknudson | I'm worried about assigning a specific response code to a condition... since that would mean we couldn't use it in a new situation where it really fit. | 01:22 |
ayoung | 412 also says request headers, but it is more ambiguous | 01:22 |
morganfainberg | (from 14.20): expect-params = ";" token [ "=" ( token | quoted-string ) ] | 01:22 |
morganfainberg | as an example | 01:22 |
*** grepory has quit IRC | 01:22 | |
morganfainberg | i think 412 sounds most correct | 01:23 |
*** armax has joined #openstack-dev | 01:23 | |
morganfainberg | but i think it doesn't matter what the code is as long as it's descriptive of why the request wasn't served | 01:23 |
ayoung | http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html | 01:23 |
jamielennox | 412 sounds like the request wanted something the server couldn't deliver, but it's close | 01:23 |
jamielennox | what about just 410 Gone. This information is Gone | 01:24 |
bknudson | add a new field to the error response, "reason" that we can fill in with a non-translated string. | 01:24 |
ayoung | 412 in this case, I think that the request wanted something the server couldn't deliver: a query without a filter | 01:24 |
jaypipes | yes, 412 is the most appropriate IMO | 01:24 |
bknudson | then we could give it a nice name. "reason": "filter_required" | 01:25 |
jamielennox | agree 412 | 01:25 |
ayoung | that should probably be a separate wishlist bug, huh? | 01:25 |
*** vipul is now known as vipul-away | 01:26 | |
jaypipes | yes | 01:26 |
jaypipes | ayoung: yes | 01:26 |
morganfainberg | bknudson: https://review.openstack.org/#/c/39818/ jenkins seems happy with the rebase. | 01:27 |
bknudson | morganfainberg: https://review.openstack.org/#/c/39818/ looks good to me. | 01:28 |
ayoung | https://bugs.launchpad.net/keystone/+bug/1211586 | 01:28 |
morganfainberg | cool. | 01:28 |
uvirtbot | Launchpad bug 1211586 in keystone "Disable user lists without a filter" [Wishlist,New] | 01:28 |
*** armax has quit IRC | 01:29 | |
morganfainberg | bknudson: any issues if i approve that one, even though i did the rebase? not sure on the general policy | 01:29 |
ayoung | morganfainberg, I'm ok with the change, but do we really want to skip :missing copyright header | 01:29 |
*** dina_belova has joined #openstack-dev | 01:29 | |
morganfainberg | ayoung: that was already there. | 01:29 |
ayoung | understood | 01:29 |
morganfainberg | ayoung: i think we shouldn't skip it, but it was added along the way. | 01:30 |
ayoung | morganfainberg, but I hadn't looked at the code critically in a while | 01:30 |
ayoung | morganfainberg, separate bug maybe? | 01:30 |
morganfainberg | ayoung: yeah i'll get it opened | 01:30 |
ayoung | I am guessing that fixing that will require adding in a few headers | 01:30 |
*** lexinator has quit IRC | 01:30 | |
morganfainberg | probably easy enough to do | 01:30 |
ayoung | morganfainberg, +2ed | 01:31 |
morganfainberg | cool | 01:31 |
*** lexinator has joined #openstack-dev | 01:31 | |
jaypipes | ayoung: from Mark Miller at HP... "Performing a “keystone user-list” command against the HP Enterprise Directory locks up keystone for about 1 ½ hours in that it will not perform any other commands until it is done" | 01:32 |
jaypipes | ayoung: ouch. | 01:32 |
ayoung | jaypipes, I was aare of that, yes | 01:32 |
jaypipes | ayoung: heh, sounds like we need that 412 ASAP! :) | 01:32 |
ayoung | jaypipes, I don;'t know if pagination will mitigate | 01:32 |
morganfainberg | https://bugs.launchpad.net/python-keystoneclient/+bug/1211587 | 01:32 |
uvirtbot | Launchpad bug 1211587 in python-keystoneclient "Enable gating on H102: missing copyright header" [Undecided,New] | 01:32 |
ayoung | jaypipes, they need to fix their directory | 01:32 |
ayoung | you should not return all rows that way. | 01:33 |
ayoung | records | 01:33 |
jaypipes | ayoung: agreed | 01:33 |
morganfainberg | i wonder what that did to their poor directory server | 01:33 |
*** dina_belova has quit IRC | 01:34 | |
bknudson | hopefully they have a cluster | 01:34 |
jaypipes | morganfainberg: put the work "Enterprise" in it? ;) | 01:34 |
jaypipes | s/work/word | 01:34 |
ayoung | ldapsearch -x -H ldap://ldap.hp.com -b ou=users,dc=hp,dc=com "(objectclass=*)" | 01:34 |
jaypipes | heh | 01:34 |
morganfainberg | jaypipes: hah! | 01:34 |
bknudson | somebody probably came knocking on his door | 01:35 |
jaypipes | morganfainberg: I've found having the term "Enterprise" in any piece of software is the deathknell for both usability and sanity | 01:35 |
ayoung | http://trenchescomic.com/comic/post/recursion | 01:35 |
bknudson | Enterprise Keystone | 01:35 |
*** yaguang has quit IRC | 01:35 | |
*** freedomhui has joined #openstack-dev | 01:35 | |
*** gongysh has quit IRC | 01:36 | |
morganfainberg | bknudson: ™ | 01:36 |
jaypipes | :) | 01:36 |
*** kaushikc has joined #openstack-dev | 01:36 | |
ayoung | and, to cut to the closure http://trenchescomic.com/comic/post/neologism | 01:36 |
jaypipes | bknudson: you KNOW some marketing geek somewhere is already working that into some company's product portfolio... | 01:36 |
ayoung | jaypipes, like Red Hat Enterprise Linux? Yeah, seems to be sinking us.... | 01:37 |
ayoung | Oh, wait. | 01:37 |
bknudson | jaypipes: I know that marketing geek. | 01:37 |
jaypipes | ayoung: :) | 01:37 |
morganfainberg | ayoung: but no one calls it that! it's just RHEL. | 01:38 |
jaypipes | heh | 01:38 |
jaypipes | ayoung: something about exception not the rule... ;) | 01:38 |
morganfainberg | jaypipes: only one marketing geek? | 01:38 |
jaypipes | morganfainberg: no, an entire team of course :) | 01:38 |
ayoung | So...the question is, for poor old HP Directory server, with no limits on returned queries, what should Keystone be asking by default? | 01:39 |
ayoung | can we add a --sizeLimit 200 in there somehow? | 01:40 |
*** kaushikc has quit IRC | 01:40 | |
*** neelashah has joined #openstack-dev | 01:40 | |
* ayoung needs to find his FreeIPA sample data file with 5000+ names | 01:40 | |
bknudson | ayoung: 5000? even hp is bigger than that. | 01:41 |
ayoung | morganfainberg, jamielennox bknudson BTW: https://review.openstack.org/#/c/41578/ | 01:41 |
*** vipul-away is now known as vipul | 01:41 | |
ayoung | bknudson, yeah, but it is large enough for load testing | 01:41 |
jamielennox | ayoung: it doesn't break backward compat in oslo, just in keystone | 01:42 |
jamielennox | or more juts in the way he bought it into keystone, but yea it's going to be harder to work with whilst it's in oslo | 01:43 |
bknudson | ayoung: that's a weird one. I don't watch oslo-incubator like I should. | 01:43 |
morganfainberg | bknudson: same boat | 01:43 |
morganfainberg | i should watch it more closely | 01:43 |
*** lexinator has quit IRC | 01:43 | |
ayoung | anyway, I also sent him an email telling him we were going to work with him to get the code into Keystone client, but in a backwards compatible way. | 01:44 |
bknudson | yea, shouldn't need it in oslo-incubator since other projects can use keystoneclient. | 01:44 |
*** mjfork has quit IRC | 01:45 | |
jamielennox | bknudson: he's done a few things other than just auth plugins that keystone can share with other projects - just completely in the wrong order | 01:45 |
morganfainberg | so that affects: https://review.openstack.org/#/c/37233/ ? | 01:45 |
ayoung | bknudson, and I have an agreement from the PTOs that it is the right approach | 01:45 |
ayoung | morganfainberg, yeah. Although exceptions should be a stand alone change. | 01:46 |
morganfainberg | right | 01:46 |
ayoung | I don;t want to kill this guys enthusiasm, just get him to work with us on this. | 01:47 |
*** markmcclain has quit IRC | 01:48 | |
morganfainberg | makes sense. | 01:48 |
*** erkules_ has joined #openstack-dev | 01:50 | |
*** jasondotstar has quit IRC | 01:52 | |
*** erkules has quit IRC | 01:52 | |
*** bknudson has quit IRC | 01:52 | |
*** yaguang has joined #openstack-dev | 01:54 | |
*** mrodden1 has quit IRC | 01:55 | |
*** mrodden has joined #openstack-dev | 01:56 | |
ayoung | Ugh, I am way behind on reviews...what is burning? | 01:57 |
*** changbl has joined #openstack-dev | 01:57 | |
*** jasondotstar has joined #openstack-dev | 01:59 | |
ayoung | jamielennox, what happend to CertDownloadMiddlewareTest ? | 02:02 |
jamielennox | ayoung: hmm? | 02:02 |
*** adalbas has quit IRC | 02:02 | |
ayoung | https://review.openstack.org/#/c/41332/2/tests/test_auth_token_middleware.py | 02:02 |
ayoung | line 1221 | 02:02 |
*** anteaya has quit IRC | 02:03 | |
*** prekarat1 has quit IRC | 02:03 | |
jamielennox | ayoung: hmm, i know it was a problem when i changed how certificates were downloaded but it shouldn't be changed in that patch | 02:04 |
jamielennox | blaming that on the number of times i've rebased and sliced up those patches | 02:04 |
*** lexinator has joined #openstack-dev | 02:04 | |
*** haleyb has quit IRC | 02:06 | |
jamielennox | ayoung: oh, right i remember, the test is basically wrong | 02:09 |
ayoung | ? | 02:09 |
jamielennox | it says that if you don't have the certs in place then the test should fail | 02:09 |
jamielennox | that's not what happens | 02:09 |
ayoung | I thought that was testing the fetch> | 02:09 |
ayoung | > | 02:09 |
jamielennox | if you don't have the certs in place it should go and fetch them, i had added the cert paths to the fake http handler and so the certs were being fetched and so the test would pass | 02:09 |
* ayoung going to replace his > key with an extra? | 02:09 | |
jamielennox | i'll remove it for this because i shouldn't be modifying test behaviour - but the test is essentially wrong later on | 02:10 |
*** nati_uen_ has quit IRC | 02:11 | |
ayoung | yeah. It is not the greatest of tests, but it should still be there | 02:11 |
ayoung | jamielennox, how about in the follow on review? | 02:11 |
jamielennox | yea, it can be changed there | 02:12 |
jamielennox | re-submitted | 02:13 |
*** gongysh has joined #openstack-dev | 02:13 | |
jamielennox | so in the second one, i think that is correct | 02:15 |
jamielennox | that test is testing the fake StackResponse thing, it's gone so no need of the test | 02:16 |
ayoung | jamielennox, ok | 02:16 |
ayoung | jamielennox, lost the link to it... | 02:16 |
jamielennox | https://review.openstack.org/#/c/41333 | 02:17 |
*** haleyb has joined #openstack-dev | 02:17 | |
jamielennox | ayoung: i still need to rebase it anyway | 02:17 |
ayoung | jamielennox, I still want that test or some variation | 02:17 |
ayoung | test_fetch_revocation_list_with_expire | 02:18 |
*** anniec has quit IRC | 02:18 | |
jamielennox | shall do | 02:19 |
ayoung | jamielennox, well...maybe I don't care. I am starting to think that revocation list should not be a protected resource | 02:19 |
*** jerryz has joined #openstack-dev | 02:19 | |
morganfainberg | ayoung: i think that would resolve a lot of headaches | 02:19 |
jamielennox | the point of that patch is not to change tests though | 02:19 |
morganfainberg | CRLs typically aren't protected iirc | 02:19 |
morganfainberg | and the revocation-list is sortof CRLish | 02:20 |
ayoung | morganfainberg, file that as a bug and assign to me | 02:20 |
morganfainberg | will do | 02:20 |
ayoung | jamielennox, I'm OK with dropping that particular test, though | 02:21 |
ayoung | it really doesn't make sense to hardcode policy checks in unit tests anyway | 02:21 |
ayoung | jamielennox, assert_valid_last_url(self, token_id): probably should still be there, though | 02:22 |
jamielennox | it is | 02:22 |
ayoung | line 565 | 02:22 |
jamielennox | so if you look down what i've done is changed it from a V3 test that overrides a V2 test into a common base with V3 and V2 overrides | 02:23 |
ayoung | cool | 02:23 |
jamielennox | cause i really hate that | 02:23 |
ayoung | line 789 see it | 02:23 |
*** carl_baldwin has quit IRC | 02:25 | |
ayoung | jamielennox, https://review.openstack.org/#/c/40176/4/keystoneclient/access.py line 328 what is going on there? | 02:26 |
morganfainberg | ayoung: i can't seem to assign the bug to anyone but myself. | 02:27 |
morganfainberg | https://bugs.launchpad.net/keystone/+bug/1211602 | 02:27 |
uvirtbot | Launchpad bug 1211602 in keystone "revocation list should not be a protected resource" [Undecided,New] | 02:27 |
jamielennox | ayoung: nothing i can see | 02:27 |
jamielennox | right review? | 02:27 |
ayoung | jamielennox, # pre grizzly ? | 02:28 |
jamielennox | ayoung: so that i took out of auth_token middleware | 02:28 |
ayoung | Ah, OK | 02:28 |
ayoung | jamielennox, shouldn't there be a corresponding edit in auth_token then? | 02:29 |
jamielennox | the location of tenantName seems to have been moved around in previous releases | 02:29 |
jamielennox | ayoung: i'm not removing it from auth_token yet | 02:30 |
*** dina_belova has joined #openstack-dev | 02:30 | |
jamielennox | i'm just bringing the functionality over to accessinfo | 02:30 |
ayoung | jamespage, OK....add a TODO then in auth_token to remove, or is that patch already in flight? | 02:30 |
jamielennox | ayoung: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L814 | 02:31 |
jamielennox | sorry again jamespage | 02:31 |
jamielennox | ayoung: it'll be part of something bigger | 02:31 |
jamielennox | this is one of the parts that has a standalone use | 02:32 |
ayoung | OK... | 02:32 |
*** jerryz has quit IRC | 02:32 | |
jamielennox | putting accessinfo into auth_token is definetly the plan and it will mean the functionality is the same | 02:33 |
jamielennox | if it's valid for a v2 token it really should be in accessinfo anyway so i don't think it's a problem for the patch to be standalone | 02:33 |
*** melwitt has quit IRC | 02:34 | |
ayoung | jamielennox, OK, I think I'm caught up on your reviews... | 02:34 |
jamielennox | ayoung: have a look at https://review.openstack.org/#/c/34161/ | 02:34 |
jamielennox | it's failing jenkins | 02:35 |
jamielennox | i put a comment at the bottom as to why: http://paste.openstack.org/show/43918/ | 02:35 |
*** dina_belova has quit IRC | 02:35 | |
jamielennox | this is wrong configuration, but it obviously currently works - how do i support both? | 02:36 |
jamielennox | / should i support both | 02:36 |
ayoung | jamielennox, I added dkranz as a reviewer. shardy can you comment on ^^ | 02:36 |
*** yaguang has quit IRC | 02:40 | |
ayoung | jamielennox, we need to bring some HEAT on the HEAT team | 02:45 |
ayoung | they are in your time zone...who is still awake... | 02:46 |
*** rohitk has joined #openstack-dev | 02:46 | |
*** alexxu has joined #openstack-dev | 02:46 | |
jamielennox | i don't think it's a heat thing, i think it's a tempest or infra thing | 02:46 |
ayoung | jamielennox, it is not specific to the heat test? | 02:47 |
jamielennox | yes, but it is because of how tempest configures heat | 02:47 |
jamielennox | do you follow what i meant in the comment? | 02:47 |
ayoung | ah. jamielennox submit a patch to tempest? | 02:47 |
ayoung | regardelss of whether we should support both, we can fix tempest, right? | 02:48 |
jamielennox | i think it's tempest but yes | 02:48 |
ayoung | jamielennox, hmmm | 02:49 |
ayoung | I think, actually, we will break a lot of things if we start enforcing that | 02:49 |
ayoung | keystone_authtoken.auth_uri = http://127.0.0.1:5000/v2.0 is probably everywhere. | 02:49 |
*** gordc has joined #openstack-dev | 02:49 | |
jamielennox | ayoung: right, so my point is it's wrong - but what do we do? | 02:49 |
ayoung | jamielennox, is it really wrong? I is a way to state : use the v2 api instead of autonegotiate. Not preferred, but not wrong, I think | 02:50 |
jamielennox | ayoung: it's a hack around the fact that to use httplib you need a connection | 02:50 |
ayoung | jamielennox, but still, tempest should not lock to 2.0 | 02:50 |
ayoung | shudder | 02:50 |
jamielennox | so instead of specifying simply a url you have to specify a protocol, host, port etc | 02:50 |
*** lbragstad has joined #openstack-dev | 02:51 | |
jamielennox | requests you don't need that (actually you can't) so auth_host etc should be deprecated | 02:51 |
ayoung | well, that is a backwards compat thing we'll have to maintain for a while anyway | 02:51 |
jamielennox | afaik auth_uri should be the same as auth_host etc all written out, just used for different things | 02:51 |
ayoung | agreed, but not all of the clients are aligned on using requests yet, either. There is some resistance from swift | 02:51 |
jamielennox | but that was never really written out anywhere | 02:52 |
ayoung | agreed. But lets allow the v2.0 in there, and deprecate it over time | 02:52 |
jamielennox | ayoung: https://bugs.launchpad.net/python-keystoneclient/+bug/1207517 | 02:53 |
uvirtbot | Launchpad bug 1207517 in python-keystoneclient "auth_token defaults auth_uri config to point to admin endpoint if not set" [Medium,Confirmed] | 02:53 |
jamielennox | ayoung: so i didn't realize, but the only place that auth_uri is used is https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L621 | 02:54 |
jamielennox | so i guess they are slightly different | 02:54 |
jamielennox | or at least they can differ | 02:54 |
*** msmedved has quit IRC | 02:54 | |
ayoung | jamielennox, want to take it? | 02:54 |
ayoung | actually ,confirm with dolphm first | 02:55 |
jamielennox | that bug? i'm not sure on what to fix about it | 02:55 |
ayoung | yeah, leave it to dolph. He probably has an idea already | 02:55 |
jamielennox | possibly then that heat config is correct, though useless | 02:55 |
*** gongysh_ has joined #openstack-dev | 02:56 | |
*** freedomhu has joined #openstack-dev | 02:56 | |
ayoung | jamielennox, work around it for now, but you can submite the HEAT/Tempest change, too | 02:57 |
jamielennox | that's ok, now i know that auth_uri is not supposed to be authoritative for where to submit requests to i can just ignore it | 02:58 |
*** freedomhui has quit IRC | 02:59 | |
*** gongysh has quit IRC | 03:00 | |
*** jimjiang has quit IRC | 03:00 | |
*** egallen has joined #openstack-dev | 03:00 | |
jamielennox | ayoung: just filed: https://bugs.launchpad.net/python-keystoneclient/+bug/1211615 | 03:02 |
uvirtbot | Launchpad bug 1211615 in python-keystoneclient "auth_token middleware doesn't respect admin_prefix for downloading certificates" [Undecided,New] | 03:02 |
jamielennox | can i fix that without breaking existing installs? | 03:02 |
ayoung | what would it look like afterwards? | 03:03 |
ayoung | where does path come from in that case> | 03:03 |
ayoung | ? | 03:03 |
jamielennox | so currently you specify your auth_host, port etc and an auth_prefix so that you can do all your calls against eg http://keystone.example.com:5000/prefix/v2.0/ | 03:04 |
ayoung | yep | 03:04 |
jamielennox | downloading certificates simply ignores auth_prefix and so will download from http://keystone.example.com:5000/v2.0/certificates/ca regardless of auth_prefix | 03:04 |
jamielennox | i cant imagine that if you are using auth_prefix that would work, but it's weird to have never come up before | 03:05 |
jamielennox | i guess it means that there are *no* deployments using PKI and a prefix | 03:05 |
ayoung | I think that was something I put in there in support of https://wiki.openstack.org/wiki/URLs | 03:06 |
ayoung | jamielennox, so, yes, please fix | 03:06 |
jamielennox | guess it never received much adoption :) | 03:06 |
ayoung | nope | 03:08 |
ayoung | OK, bed for me | 03:08 |
*** jecarey has joined #openstack-dev | 03:10 | |
*** jbresnah has quit IRC | 03:12 | |
jamielennox | ayoung: ok, talk to you later | 03:12 |
*** matiu has quit IRC | 03:24 | |
*** ljjjustin has joined #openstack-dev | 03:24 | |
*** yaguang has joined #openstack-dev | 03:25 | |
*** bdpayne has joined #openstack-dev | 03:25 | |
*** comay has quit IRC | 03:28 | |
*** dina_belova has joined #openstack-dev | 03:30 | |
*** sudorandom has quit IRC | 03:32 | |
*** dina_belova has quit IRC | 03:35 | |
*** gordc has quit IRC | 03:37 | |
*** jfriedly has quit IRC | 03:42 | |
*** otherwiseguy has quit IRC | 03:45 | |
*** gordc has joined #openstack-dev | 03:48 | |
*** gordc has quit IRC | 03:48 | |
*** zaitcev has quit IRC | 03:52 | |
*** martitia_ has joined #openstack-dev | 03:54 | |
*** tiamar has quit IRC | 03:54 | |
*** zaitcev has joined #openstack-dev | 03:56 | |
*** noslzzp_ has joined #openstack-dev | 04:03 | |
*** noslzzp has quit IRC | 04:03 | |
*** noslzzp_ is now known as noslzzp | 04:03 | |
*** SergeyLukjanov has joined #openstack-dev | 04:05 | |
*** mberwanger has quit IRC | 04:05 | |
*** zaneb has joined #openstack-dev | 04:05 | |
*** changbl has quit IRC | 04:05 | |
*** changbl has joined #openstack-dev | 04:06 | |
*** zbitter has quit IRC | 04:08 | |
*** jasondotstar has quit IRC | 04:09 | |
*** bdpayne has quit IRC | 04:11 | |
*** zaneb has quit IRC | 04:16 | |
*** Mandell has joined #openstack-dev | 04:21 | |
*** grepory has joined #openstack-dev | 04:28 | |
*** locke105 has quit IRC | 04:29 | |
*** dina_belova has joined #openstack-dev | 04:31 | |
*** locke105 has joined #openstack-dev | 04:31 | |
*** garyk has quit IRC | 04:31 | |
*** kbringard has joined #openstack-dev | 04:32 | |
*** dina_belova has quit IRC | 04:35 | |
*** basha has joined #openstack-dev | 04:40 | |
*** rohitk_alt has joined #openstack-dev | 04:42 | |
*** dina_belova has joined #openstack-dev | 04:42 | |
*** neelashah has quit IRC | 04:43 | |
*** rohitk has quit IRC | 04:43 | |
*** bdpayne has joined #openstack-dev | 04:45 | |
*** dina_belova has quit IRC | 04:48 | |
*** nati_ueno has joined #openstack-dev | 04:52 | |
*** rohitk_alt has quit IRC | 04:55 | |
*** egallen has quit IRC | 04:56 | |
*** zaitcev has quit IRC | 04:56 | |
*** basha has quit IRC | 04:58 | |
*** egallen has joined #openstack-dev | 04:59 | |
*** alexxu has quit IRC | 05:01 | |
*** egallen has quit IRC | 05:02 | |
*** nati_ueno has quit IRC | 05:02 | |
*** kbringard has quit IRC | 05:02 | |
*** nati_ueno has joined #openstack-dev | 05:02 | |
*** jecarey_ has joined #openstack-dev | 05:03 | |
*** sumanthns has joined #openstack-dev | 05:04 | |
*** berendt has joined #openstack-dev | 05:06 | |
*** jecarey has quit IRC | 05:06 | |
*** ruhe has joined #openstack-dev | 05:08 | |
*** basha has joined #openstack-dev | 05:09 | |
*** gsilvis has quit IRC | 05:11 | |
*** adjohn has joined #openstack-dev | 05:16 | |
*** rohitk has joined #openstack-dev | 05:16 | |
*** briancurtin has quit IRC | 05:16 | |
*** alexxu has joined #openstack-dev | 05:18 | |
*** SergeyLukjanov has quit IRC | 05:18 | |
*** jbresnah has joined #openstack-dev | 05:20 | |
*** nayward has joined #openstack-dev | 05:21 | |
*** gsilvis has joined #openstack-dev | 05:23 | |
*** jerryz has joined #openstack-dev | 05:25 | |
*** bdpayne has quit IRC | 05:27 | |
jerryz | hi everyone, when i ran coverage test of cinder, it always gets No module named swiftclient error. but it is already installed in the .tox dir. this does not happen to py27 test. could anyone help? thanks | 05:30 |
*** cmark has joined #openstack-dev | 05:30 | |
*** SergeyLukjanov has joined #openstack-dev | 05:30 | |
*** SergeyLukjanov has quit IRC | 05:31 | |
*** garyk has joined #openstack-dev | 05:37 | |
*** vartom117 has joined #openstack-dev | 05:38 | |
*** mrunge has joined #openstack-dev | 05:39 | |
*** noslzzp has quit IRC | 05:39 | |
*** bdpayne has joined #openstack-dev | 05:40 | |
*** morazi has quit IRC | 05:41 | |
stevemar | hmm, what are the odds morganfainberg is awake... | 05:42 |
morganfainberg | stevemar: odds? | 05:42 |
stevemar | :D | 05:43 |
morganfainberg | what are the odds you're catching me just as i was about to pack up from work? :P | 05:43 |
stevemar | apparently pretty good | 05:43 |
stevemar | d'oh | 05:43 |
morganfainberg | haha all good man | 05:43 |
morganfainberg | whats up? | 05:43 |
stevemar | 3 things | 05:43 |
morganfainberg | sure | 05:43 |
stevemar | 1st https://review.openstack.org/#/c/29130/52/keystone/auth/plugins/token.py | 05:43 |
stevemar | too lazy to fix that one | 05:43 |
morganfainberg | it's a nit, no worries | 05:43 |
*** mrunge has quit IRC | 05:44 | |
stevemar | figured | 05:44 |
stevemar | 2nd https://review.openstack.org/#/c/29130/52/keystone/contrib/delegated_auth/core.py | 05:44 |
*** mmagr has joined #openstack-dev | 05:44 | |
*** mrunge has joined #openstack-dev | 05:44 | |
morganfainberg | anythying i mark as such, meh, i figure best case you fix, worst case… meh | 05:44 |
stevemar | "Should this be a ProjectNotFound and not an Unauthorized? I'm inclined to say this should be an Unauthorized as well" | 05:44 |
stevemar | rookie question, how do i raise 2 exceptions :\ | 05:44 |
stevemar | oh wait | 05:44 |
morganfainberg | sorry i wasn't clear | 05:44 |
stevemar | you wrote NOT | 05:44 |
morganfainberg | yeah | 05:45 |
morganfainberg | it should have said Unauthorized instead | 05:45 |
stevemar | coolio | 05:45 |
morganfainberg | the "as well" was referencing the previous exception | 05:45 |
morganfainberg | on uh… 444? 443? | 05:45 |
*** sarob has joined #openstack-dev | 05:46 | |
stevemar | ah okay | 05:46 |
morganfainberg | so yeah, my thought was unauthorized instead of projectnot found | 05:46 |
stevemar | good point | 05:46 |
stevemar | its more correct | 05:46 |
stevemar | and i'll update the driver api stuff later on :) | 05:46 |
stevemar | last one: https://review.openstack.org/#/c/29130/52/keystone/token/core.py | 05:47 |
morganfainberg | but i also was asking because i wasn't sure if you had a reason besides "project not found was the one that looked good at the time" | 05:47 |
stevemar | lol | 05:47 |
stevemar | you got me pegged there | 05:47 |
morganfainberg | hey, i'm guilty of that stuff too | 05:47 |
morganfainberg | "oh hay, this looks good" | 05:47 |
stevemar | aren't we all | 05:47 |
*** terriyu has quit IRC | 05:47 | |
morganfainberg | yeah that last one, right now, you don't do revocations in the other drivers when a consumer id is passed. | 05:48 |
stevemar | ughhh, yeah, totally missed the boat on that one | 05:48 |
morganfainberg | well to be fair, i think you're goign to delete _every_ token | 05:48 |
morganfainberg | so it's not a security risk… | 05:49 |
*** dina_belova has joined #openstack-dev | 05:49 | |
morganfainberg | for the user that is | 05:49 |
stevemar | yeah, but you and dolph had mentioned to *not* do that :) | 05:49 |
morganfainberg | yeah, it's important to not do that | 05:49 |
morganfainberg | people will be very unhappy | 05:49 |
stevemar | thoughts on it? should i change up the list? or just add some stuff between the list and loop to filter out only the consumer related ones? | 05:49 |
stevemar | though if people are using kvs... | 05:50 |
* stevemar rolls eyes | 05:50 | |
morganfainberg | kvs driver is annoying | 05:50 |
morganfainberg | but.... | 05:50 |
morganfainberg | have to support it until icehouse (officially) | 05:50 |
stevemar | yeah | 05:50 |
morganfainberg | well… question for you, since you might have a thought on this. | 05:50 |
*** nati_uen_ has joined #openstack-dev | 05:50 | |
morganfainberg | should the token driver expose a "list_tokens_for_user_and_consumer" and "list_tokens_for_user_and_trust"? | 05:51 |
morganfainberg | because i'm trying to smash out kwargs in managers/drivers | 05:51 |
morganfainberg | or do you think extending list_tokens() to have another optional arg (that, once caching is in play, you need to specify all arguments for anyways) is more correct? | 05:52 |
*** adjohn has quit IRC | 05:52 | |
stevemar | hmm... | 05:53 |
*** dina_belova has quit IRC | 05:53 | |
morganfainberg | i'd make the token_driver do the work of filtering out the consumer tokens via a list function (in either case). — i don't see a need for "delete_tokens" to get too much smarts in it, especially since you're already looping in the other drivers over a list | 05:53 |
stevemar | true true | 05:53 |
stevemar | delete should do just that | 05:53 |
morganfainberg | yeah, and ignore that the SQL delete_tokens has any real smarts to it | 05:54 |
*** nati_ueno has quit IRC | 05:54 | |
morganfainberg | that is just the nature of SQL needing sessions and the like | 05:54 |
*** henrynash has joined #openstack-dev | 05:54 | |
*** cmark_ has joined #openstack-dev | 05:54 | |
stevemar | yeah, let him be a special case | 05:54 |
*** cmark has quit IRC | 05:54 | |
*** rohitk has quit IRC | 05:55 | |
*** rohitk_alt has joined #openstack-dev | 05:55 | |
stevemar | okay, so make the list a bit smarter | 05:55 |
morganfainberg | either that, or add a new "list" function to extract the consumer specific tokens | 05:56 |
stevemar | yeah, most of the time, the "list" does just that anyway | 05:56 |
morganfainberg | i am thinking that i'll be implementing list_tokens_for_trust(user_id, trust_id) | 05:57 |
morganfainberg | which will call _list_tokens(user_id, tenant_id=None, trust_id=None) | 05:57 |
morganfainberg | and that will be the way i remove the kwargs to list_tokens() | 05:58 |
morganfainberg | stevemar: anyway, i'm going to get going and grab some food and sleep. | 05:59 |
morganfainberg | stevemar: let me know if you need anything else | 05:59 |
stevemar | morganfainberg: have fun dude | 05:59 |
stevemar | morganfainberg: ttyl | 05:59 |
morganfainberg | unrelated, i felt left out without a mic today on the bridge :P | 05:59 |
*** alexxu has quit IRC | 06:02 | |
*** bdpayne has quit IRC | 06:02 | |
*** sarob has quit IRC | 06:03 | |
*** sarob has joined #openstack-dev | 06:03 | |
*** morganfainberg is now known as morganfainberg_a | 06:04 | |
*** sarob has quit IRC | 06:07 | |
*** morazi has joined #openstack-dev | 06:07 | |
*** berendt has quit IRC | 06:08 | |
*** kbringard has joined #openstack-dev | 06:09 | |
*** tkammer has joined #openstack-dev | 06:11 | |
*** ruhe has quit IRC | 06:12 | |
*** ruhe has joined #openstack-dev | 06:14 | |
*** jamielennox is now known as jamielennox|away | 06:16 | |
*** ruhe has quit IRC | 06:18 | |
*** sthaha has quit IRC | 06:18 | |
*** zaneb has joined #openstack-dev | 06:20 | |
*** bashok has joined #openstack-dev | 06:20 | |
*** alexxu has joined #openstack-dev | 06:25 | |
*** odyssey4me has joined #openstack-dev | 06:25 | |
*** stevemar has quit IRC | 06:30 | |
*** adjohn has joined #openstack-dev | 06:34 | |
*** adjohn has quit IRC | 06:37 | |
*** flaper87|afk is now known as flaper87 | 06:40 | |
*** henrynash has quit IRC | 06:41 | |
*** mrunge_ has joined #openstack-dev | 06:43 | |
*** mrunge has quit IRC | 06:43 | |
*** xga has joined #openstack-dev | 06:44 | |
*** asalkeld is now known as asalkeld_food | 06:45 | |
*** ffio has joined #openstack-dev | 06:48 | |
*** jerryz has quit IRC | 06:48 | |
*** kirankv has joined #openstack-dev | 06:49 | |
*** adjohn has joined #openstack-dev | 06:52 | |
*** adjohn has quit IRC | 06:52 | |
*** devvesa has joined #openstack-dev | 06:54 | |
*** lexinator has quit IRC | 06:57 | |
*** nsaje1 has joined #openstack-dev | 06:59 | |
*** Guest6179 is now known as ohadlevy | 06:59 | |
*** ohadlevy has joined #openstack-dev | 06:59 | |
*** reidrac has joined #openstack-dev | 07:02 | |
*** mrunge_ is now known as mrunge | 07:03 | |
*** nati_uen_ has quit IRC | 07:03 | |
*** nati_ueno has joined #openstack-dev | 07:04 | |
*** nshaikh has joined #openstack-dev | 07:05 | |
*** aeperezt has quit IRC | 07:06 | |
*** morganfainberg_a is now known as morganfainberg | 07:07 | |
*** alexxu has quit IRC | 07:09 | |
*** jimjiang has joined #openstack-dev | 07:11 | |
*** adjohn has joined #openstack-dev | 07:13 | |
*** adjohn has quit IRC | 07:13 | |
*** sarob has joined #openstack-dev | 07:14 | |
*** basha has quit IRC | 07:14 | |
*** kenperkins has quit IRC | 07:16 | |
*** kenperkins_ has joined #openstack-dev | 07:16 | |
*** ndipanov_gone is now known as ndipanov | 07:18 | |
*** sarob has quit IRC | 07:18 | |
*** xBsd has joined #openstack-dev | 07:21 | |
*** dosaboy is now known as dosaboy__ | 07:22 | |
*** jaimegil has joined #openstack-dev | 07:23 | |
*** adjohn has joined #openstack-dev | 07:24 | |
*** xga_ has joined #openstack-dev | 07:25 | |
*** adjohn has quit IRC | 07:25 | |
*** xga has quit IRC | 07:28 | |
*** wfoster_away is now known as wfoster | 07:30 | |
*** jistr has joined #openstack-dev | 07:30 | |
*** jprovazn has joined #openstack-dev | 07:32 | |
*** alexb_ has joined #openstack-dev | 07:34 | |
*** ruhe has joined #openstack-dev | 07:34 | |
*** dguitarbite has joined #openstack-dev | 07:35 | |
*** fbo_away is now known as fbo | 07:35 | |
*** nsaje1 has quit IRC | 07:36 | |
*** ifarkas has joined #openstack-dev | 07:36 | |
*** psedlak has joined #openstack-dev | 07:37 | |
*** shang has joined #openstack-dev | 07:39 | |
*** feleouet has joined #openstack-dev | 07:39 | |
*** rohitk has joined #openstack-dev | 07:41 | |
*** alexxu has joined #openstack-dev | 07:42 | |
*** ifarkas has quit IRC | 07:42 | |
*** zoresvit has joined #openstack-dev | 07:42 | |
*** rohitk_alt has quit IRC | 07:42 | |
*** ifarkas has joined #openstack-dev | 07:44 | |
*** troytoman is now known as troytoman-away | 07:49 | |
*** jtomasek has joined #openstack-dev | 07:49 | |
*** nati_uen_ has joined #openstack-dev | 07:52 | |
*** nati_ueno has quit IRC | 07:55 | |
*** afazekas has joined #openstack-dev | 07:55 | |
*** afazekas has quit IRC | 07:55 | |
*** zbitter has joined #openstack-dev | 07:55 | |
*** afazekas has joined #openstack-dev | 07:55 | |
*** basha has joined #openstack-dev | 07:57 | |
*** zaneb has quit IRC | 07:58 | |
*** zaneb has joined #openstack-dev | 07:59 | |
*** MaxV has joined #openstack-dev | 07:59 | |
*** safchain has joined #openstack-dev | 07:59 | |
*** zbitter has quit IRC | 08:00 | |
*** Aj0 has joined #openstack-dev | 08:01 | |
*** safchain has quit IRC | 08:02 | |
*** safchain has joined #openstack-dev | 08:03 | |
*** Gwyxx has joined #openstack-dev | 08:03 | |
*** henrynash has joined #openstack-dev | 08:03 | |
*** zbitter has joined #openstack-dev | 08:04 | |
*** adjohn has joined #openstack-dev | 08:04 | |
*** zaneb has quit IRC | 08:05 | |
*** adjohn has quit IRC | 08:05 | |
*** zaneb has joined #openstack-dev | 08:07 | |
*** Gwyxx has quit IRC | 08:07 | |
*** zbitter has quit IRC | 08:08 | |
*** boris-42 has joined #openstack-dev | 08:08 | |
*** zyluo has joined #openstack-dev | 08:09 | |
*** jpich has joined #openstack-dev | 08:09 | |
zyluo | mikal, ping | 08:10 |
*** sungju has quit IRC | 08:11 | |
*** JordanP has joined #openstack-dev | 08:11 | |
*** asalkeld_food is now known as asalkeld_eaten | 08:12 | |
*** asalkeld_eaten is now known as asalkeld | 08:12 | |
*** safchain has quit IRC | 08:12 | |
*** erkules_ is now known as erkules | 08:13 | |
*** zul has quit IRC | 08:13 | |
*** ffio has quit IRC | 08:14 | |
*** ffio has joined #openstack-dev | 08:14 | |
*** safchain has joined #openstack-dev | 08:14 | |
*** xqueralt-afk is now known as xqueralt | 08:15 | |
*** oNeToWn has joined #openstack-dev | 08:15 | |
*** yaguang has quit IRC | 08:16 | |
*** boden has joined #openstack-dev | 08:17 | |
*** Lily_ has joined #openstack-dev | 08:18 | |
*** lucasagomes has joined #openstack-dev | 08:18 | |
*** zhongwenjia has joined #openstack-dev | 08:18 | |
*** qba73 has joined #openstack-dev | 08:20 | |
*** martyntaylor has joined #openstack-dev | 08:22 | |
*** cmark_ has quit IRC | 08:23 | |
*** mmoya has joined #openstack-dev | 08:25 | |
*** dosaboy has joined #openstack-dev | 08:25 | |
*** yaguang has joined #openstack-dev | 08:28 | |
*** freedomhu has quit IRC | 08:29 | |
*** freedomhui has joined #openstack-dev | 08:29 | |
*** dguitarbite has quit IRC | 08:29 | |
*** Alexei_987 has joined #openstack-dev | 08:33 | |
*** athomas has joined #openstack-dev | 08:34 | |
*** sushils has joined #openstack-dev | 08:34 | |
*** alexxu has quit IRC | 08:35 | |
*** markmc has joined #openstack-dev | 08:37 | |
*** giulivo has joined #openstack-dev | 08:40 | |
*** Mark___ has quit IRC | 08:44 | |
*** lsmola has quit IRC | 08:46 | |
*** jbresnah has quit IRC | 08:46 | |
jprovazn | lifeless: ping | 08:48 |
*** basha has quit IRC | 08:49 | |
*** Lily_ has quit IRC | 08:51 | |
*** japage has quit IRC | 08:52 | |
*** japage has joined #openstack-dev | 08:52 | |
*** rods has joined #openstack-dev | 08:54 | |
*** zyluo has quit IRC | 08:55 | |
holms | al-maisan: available :)? | 08:56 |
*** alexxu has joined #openstack-dev | 08:56 | |
*** bashok has quit IRC | 08:59 | |
*** lsmola has joined #openstack-dev | 09:00 | |
*** lexinator has joined #openstack-dev | 09:00 | |
*** yaguang has quit IRC | 09:00 | |
*** AnilV4 has joined #openstack-dev | 09:02 | |
*** lexinator has quit IRC | 09:05 | |
*** xBsd has quit IRC | 09:05 | |
*** ifarkas has quit IRC | 09:12 | |
*** ifarkas has joined #openstack-dev | 09:12 | |
*** adjohn has joined #openstack-dev | 09:17 | |
*** mmoya has quit IRC | 09:17 | |
*** mmoya has joined #openstack-dev | 09:17 | |
*** yaguang has joined #openstack-dev | 09:17 | |
*** adjohn has quit IRC | 09:21 | |
*** mkerrin has quit IRC | 09:22 | |
*** cmark has joined #openstack-dev | 09:24 | |
*** zbitter has joined #openstack-dev | 09:24 | |
*** gsilvis has quit IRC | 09:25 | |
*** zaneb has quit IRC | 09:25 | |
*** lsmola has quit IRC | 09:26 | |
yaguang | mrodden,ping | 09:30 |
*** zbitter is now known as zaneb | 09:31 | |
*** alexxu has quit IRC | 09:31 | |
*** adjohn has joined #openstack-dev | 09:31 | |
*** ffio has quit IRC | 09:31 | |
*** cmark has quit IRC | 09:33 | |
*** wfoster is now known as wfoster_away | 09:34 | |
*** basha has joined #openstack-dev | 09:36 | |
*** devvesa has quit IRC | 09:36 | |
*** valgrind has joined #openstack-dev | 09:38 | |
*** yolanda has joined #openstack-dev | 09:40 | |
*** lsmola has joined #openstack-dev | 09:40 | |
*** ljjjustin has quit IRC | 09:41 | |
*** mmoya_ has joined #openstack-dev | 09:47 | |
*** SergeyLukjanov has joined #openstack-dev | 09:49 | |
*** mmoya has quit IRC | 09:50 | |
*** adjohn has quit IRC | 09:56 | |
lifeless | jprovazn: pong | 09:59 |
*** dina_belova has joined #openstack-dev | 09:59 | |
*** wfoster_away is now known as wfoster | 10:00 | |
*** ruhe has quit IRC | 10:01 | |
*** annashen has quit IRC | 10:07 | |
*** koolhead11 has quit IRC | 10:08 | |
*** nayward has quit IRC | 10:11 | |
*** nayward has joined #openstack-dev | 10:13 | |
*** adjohn has joined #openstack-dev | 10:15 | |
jprovazn | lifeless: Hi, have a question about this commit: https://github.com/openstack/tripleo-incubator/commit/81335dd0bd43c0d3002e73595b813bb50b41c402 - does it mean that seedrc file should now be part of tripleo-incubator repository? | 10:17 |
*** Aarti has joined #openstack-dev | 10:19 | |
*** adjohn has quit IRC | 10:20 | |
holms | what's the default username in dashboard? just installed devstack | 10:21 |
*** xga_ has quit IRC | 10:25 | |
*** annashen has joined #openstack-dev | 10:26 | |
*** jaimegil has quit IRC | 10:26 | |
*** jaimegil has joined #openstack-dev | 10:27 | |
*** jlabocki1 has joined #openstack-dev | 10:31 | |
*** henrynash_ has joined #openstack-dev | 10:31 | |
*** mrodden1 has joined #openstack-dev | 10:31 | |
*** zbitter has joined #openstack-dev | 10:32 | |
*** nati_ueno has joined #openstack-dev | 10:32 | |
*** Aarti_ has joined #openstack-dev | 10:32 | |
*** zaneb has quit IRC | 10:33 | |
*** rods has quit IRC | 10:33 | |
*** cp16net_ has joined #openstack-dev | 10:33 | |
*** topol has joined #openstack-dev | 10:34 | |
*** comstud_ has joined #openstack-dev | 10:35 | |
*** zbitter has quit IRC | 10:35 | |
*** slagle_ has joined #openstack-dev | 10:35 | |
*** amerine_ has joined #openstack-dev | 10:35 | |
*** clayg_ has joined #openstack-dev | 10:36 | |
*** lifeless_ has joined #openstack-dev | 10:36 | |
*** BLZbubba_ has joined #openstack-dev | 10:36 | |
*** martitia_ has quit IRC | 10:36 | |
*** tiamar has joined #openstack-dev | 10:37 | |
*** kashyap` has joined #openstack-dev | 10:38 | |
*** zaneb has joined #openstack-dev | 10:39 | |
*** _cerberu` has joined #openstack-dev | 10:39 | |
*** samalba_ has joined #openstack-dev | 10:39 | |
*** Aarti has quit IRC | 10:40 | |
*** SergeyLukjanov has quit IRC | 10:40 | |
*** ifarkas has quit IRC | 10:40 | |
*** dosaboy has quit IRC | 10:40 | |
*** oNeToWn has quit IRC | 10:40 | |
*** henrynash has quit IRC | 10:40 | |
*** Aj0 has quit IRC | 10:40 | |
*** nati_uen_ has quit IRC | 10:40 | |
*** rohitk has quit IRC | 10:40 | |
*** mrunge has quit IRC | 10:40 | |
*** tkammer has quit IRC | 10:40 | |
*** mrodden has quit IRC | 10:40 | |
*** lifeless has quit IRC | 10:40 | |
*** ayoung has quit IRC | 10:40 | |
*** jlabocki has quit IRC | 10:40 | |
*** amerine has quit IRC | 10:40 | |
*** slagle has quit IRC | 10:40 | |
*** sdake_ has quit IRC | 10:40 | |
*** llu has quit IRC | 10:40 | |
*** doude has quit IRC | 10:40 | |
*** cp16net has quit IRC | 10:40 | |
*** ianw has quit IRC | 10:40 | |
*** BLZbubba has quit IRC | 10:40 | |
*** yamahata has quit IRC | 10:40 | |
*** dansmith has quit IRC | 10:40 | |
*** harlowja has quit IRC | 10:40 | |
*** s2r2 has quit IRC | 10:40 | |
*** Vivek has quit IRC | 10:40 | |
*** samalba has quit IRC | 10:40 | |
*** akscram has quit IRC | 10:40 | |
*** maurosr has quit IRC | 10:40 | |
*** clayg has quit IRC | 10:40 | |
*** toddnni has quit IRC | 10:40 | |
*** comstud has quit IRC | 10:40 | |
*** kashyap has quit IRC | 10:40 | |
*** _cerberus_ has quit IRC | 10:40 | |
*** uvirtbot has quit IRC | 10:40 | |
*** henrynash_ is now known as henrynash | 10:40 | |
*** Aarti_ is now known as Aarti | 10:40 | |
*** cp16net_ is now known as cp16net | 10:40 | |
*** samalba_ is now known as samalba | 10:40 | |
*** zbitter has joined #openstack-dev | 10:41 | |
*** zaneb has quit IRC | 10:43 | |
*** ianw has joined #openstack-dev | 10:45 | |
*** ruhe has joined #openstack-dev | 10:45 | |
*** sdake_ has joined #openstack-dev | 10:45 | |
*** sdake_ has quit IRC | 10:45 | |
*** sdake_ has joined #openstack-dev | 10:45 | |
*** adjohn has joined #openstack-dev | 10:45 | |
*** zbitter has quit IRC | 10:46 | |
*** uvirtbot has joined #openstack-dev | 10:46 | |
*** tkammer has joined #openstack-dev | 10:46 | |
*** dosaboy has joined #openstack-dev | 10:46 | |
*** oNeToWn has joined #openstack-dev | 10:46 | |
*** Aj0 has joined #openstack-dev | 10:46 | |
*** rohitk has joined #openstack-dev | 10:46 | |
*** mrunge has joined #openstack-dev | 10:46 | |
*** doude has joined #openstack-dev | 10:46 | |
*** dansmith has joined #openstack-dev | 10:46 | |
*** Vivek has joined #openstack-dev | 10:46 | |
*** akscram has joined #openstack-dev | 10:46 | |
*** maurosr has joined #openstack-dev | 10:46 | |
*** toddnni has joined #openstack-dev | 10:46 | |
*** tkammer has quit IRC | 10:46 | |
*** tkammer has joined #openstack-dev | 10:46 | |
*** yamahata has joined #openstack-dev | 10:46 | |
*** SergeyLukjanov has joined #openstack-dev | 10:46 | |
*** ayoung has joined #openstack-dev | 10:46 | |
*** zbitter has joined #openstack-dev | 10:47 | |
*** oNeToWn has quit IRC | 10:47 | |
*** mmoya_ has quit IRC | 10:47 | |
*** ifarkas has joined #openstack-dev | 10:48 | |
*** adjohn has quit IRC | 10:50 | |
*** gongysh_ has quit IRC | 10:51 | |
*** yaguang has quit IRC | 10:52 | |
*** ruhe has quit IRC | 10:53 | |
*** annashen has quit IRC | 10:54 | |
*** fbo is now known as fbo_away | 10:56 | |
*** anniec has joined #openstack-dev | 10:58 | |
*** mjfork has joined #openstack-dev | 10:58 | |
*** radez_g0n3 is now known as radez | 10:58 | |
*** cmark has joined #openstack-dev | 10:59 | |
*** annashen has joined #openstack-dev | 10:59 | |
*** pcm_ has joined #openstack-dev | 11:00 | |
*** anniec_ has joined #openstack-dev | 11:02 | |
*** SergeyLukjanov has quit IRC | 11:02 | |
*** anniec has quit IRC | 11:02 | |
*** anniec_ is now known as anniec | 11:02 | |
*** mkollaro has joined #openstack-dev | 11:05 | |
*** cmark has quit IRC | 11:07 | |
*** lucasagomes is now known as lucas-hungry | 11:10 | |
*** zbitter is now known as zaneb | 11:11 | |
*** mrda is now known as mrdabot | 11:15 | |
*** dina_belova has quit IRC | 11:21 | |
*** martyntaylor has quit IRC | 11:21 | |
*** basha has quit IRC | 11:22 | |
*** basha has joined #openstack-dev | 11:24 | |
*** dina_belova has joined #openstack-dev | 11:24 | |
*** ffio has joined #openstack-dev | 11:25 | |
*** ruhe has joined #openstack-dev | 11:25 | |
*** woodspa has joined #openstack-dev | 11:25 | |
*** adalbas has joined #openstack-dev | 11:26 | |
*** slagle_ has quit IRC | 11:28 | |
*** s2r2 has joined #openstack-dev | 11:31 | |
*** tkammer has quit IRC | 11:31 | |
*** zbitter has joined #openstack-dev | 11:31 | |
*** zaneb has quit IRC | 11:32 | |
*** zbitter is now known as zaneb | 11:32 | |
*** xga has joined #openstack-dev | 11:36 | |
*** SergeyLukjanov has joined #openstack-dev | 11:37 | |
*** nshaikh has left #openstack-dev | 11:39 | |
*** Aj0 has quit IRC | 11:40 | |
*** fbo_away is now known as fbo | 11:43 | |
*** martyntaylor has joined #openstack-dev | 11:44 | |
*** FunnyLookinHat has joined #openstack-dev | 11:46 | |
*** adjohn has joined #openstack-dev | 11:46 | |
*** Aj0 has joined #openstack-dev | 11:46 | |
*** noslzzp has joined #openstack-dev | 11:47 | |
*** shang has quit IRC | 11:47 | |
*** nshaikh has joined #openstack-dev | 11:48 | |
*** xga_ has joined #openstack-dev | 11:50 | |
*** adjohn has quit IRC | 11:51 | |
*** xga has quit IRC | 11:54 | |
*** tmclaugh[work] has joined #openstack-dev | 11:54 | |
*** dina_belova has quit IRC | 11:57 | |
*** steveg_afk has joined #openstack-dev | 11:57 | |
*** alexxu has joined #openstack-dev | 11:58 | |
*** rfolco has joined #openstack-dev | 11:59 | |
*** yaguang has joined #openstack-dev | 11:59 | |
*** sgordon has quit IRC | 11:59 | |
*** dina_belova has joined #openstack-dev | 12:01 | |
*** tkammer has joined #openstack-dev | 12:03 | |
*** dina_belova has quit IRC | 12:05 | |
*** branen_ has joined #openstack-dev | 12:05 | |
*** VictorLin has joined #openstack-dev | 12:06 | |
*** branen has quit IRC | 12:08 | |
*** zbitter has joined #openstack-dev | 12:09 | |
*** ayoung has quit IRC | 12:10 | |
*** xga has joined #openstack-dev | 12:11 | |
*** zul has joined #openstack-dev | 12:11 | |
*** jasondotstar has joined #openstack-dev | 12:12 | |
*** zaneb has quit IRC | 12:12 | |
*** xga_ has quit IRC | 12:12 | |
*** xga_ has joined #openstack-dev | 12:14 | |
*** zbitter has quit IRC | 12:15 | |
*** zaneb has joined #openstack-dev | 12:16 | |
*** xga has quit IRC | 12:16 | |
*** Aarti has quit IRC | 12:17 | |
*** adjohn has joined #openstack-dev | 12:17 | |
*** Ryan_Lane has joined #openstack-dev | 12:17 | |
*** martine has joined #openstack-dev | 12:19 | |
*** martine is now known as Guest8956 | 12:19 | |
*** jruzicka has joined #openstack-dev | 12:19 | |
*** troytoman-away is now known as troytoman | 12:19 | |
*** valgrind has quit IRC | 12:20 | |
*** mberwanger has joined #openstack-dev | 12:20 | |
*** adjohn has quit IRC | 12:21 | |
*** egallen has joined #openstack-dev | 12:22 | |
*** ruhe has quit IRC | 12:22 | |
*** dina_belova has joined #openstack-dev | 12:24 | |
*** zbitter has joined #openstack-dev | 12:25 | |
*** sandywalsh has quit IRC | 12:25 | |
*** jonesld has joined #openstack-dev | 12:26 | |
*** zaneb has quit IRC | 12:27 | |
*** radez is now known as radez_g0n3 | 12:29 | |
*** morazi has quit IRC | 12:31 | |
*** slagle has joined #openstack-dev | 12:31 | |
*** dvarga has joined #openstack-dev | 12:33 | |
*** jonesld has quit IRC | 12:33 | |
*** dina_belova has quit IRC | 12:34 | |
*** dina_belova has joined #openstack-dev | 12:34 | |
*** psedlak has quit IRC | 12:35 | |
*** dvarga has quit IRC | 12:36 | |
*** zul has quit IRC | 12:37 | |
*** sandywalsh has joined #openstack-dev | 12:39 | |
*** zul has joined #openstack-dev | 12:40 | |
*** afazekas has quit IRC | 12:41 | |
*** basha has quit IRC | 12:43 | |
*** basha has joined #openstack-dev | 12:43 | |
*** mrunge has quit IRC | 12:44 | |
*** Guest8956 is now known as martine_ | 12:45 | |
*** basha has quit IRC | 12:46 | |
*** adjohn has joined #openstack-dev | 12:48 | |
*** lbragstad has quit IRC | 12:49 | |
*** adjohn has quit IRC | 12:52 | |
*** xga_ has quit IRC | 12:55 | |
*** prad_ has joined #openstack-dev | 12:56 | |
*** steveg_afk is now known as sgordon | 12:57 | |
*** jaimegil has quit IRC | 12:57 | |
*** gordc has joined #openstack-dev | 12:58 | |
*** lucas-hungry is now known as lucasagomes | 12:59 | |
*** joesavak has joined #openstack-dev | 13:01 | |
*** zul has quit IRC | 13:02 | |
*** prad_ has quit IRC | 13:03 | |
*** mberwanger has quit IRC | 13:03 | |
*** xga has joined #openstack-dev | 13:03 | |
*** alexpilotti has joined #openstack-dev | 13:04 | |
*** zul has joined #openstack-dev | 13:04 | |
*** anteaya has joined #openstack-dev | 13:05 | |
*** dprince has joined #openstack-dev | 13:07 | |
*** ruhe has joined #openstack-dev | 13:10 | |
*** tkammer has quit IRC | 13:10 | |
*** leif has joined #openstack-dev | 13:11 | |
*** jsavak has joined #openstack-dev | 13:11 | |
*** leif is now known as Guest95014 | 13:11 | |
*** psedlak has joined #openstack-dev | 13:12 | |
*** zul has quit IRC | 13:15 | |
*** joesavak has quit IRC | 13:16 | |
*** prad_ has joined #openstack-dev | 13:16 | |
*** Ryan_Lane1 has joined #openstack-dev | 13:17 | |
*** Ryan_Lane has quit IRC | 13:17 | |
*** burt has joined #openstack-dev | 13:18 | |
*** sumanthns has quit IRC | 13:18 | |
*** adjohn has joined #openstack-dev | 13:18 | |
*** dina_belova has quit IRC | 13:19 | |
*** morazi has joined #openstack-dev | 13:20 | |
*** dina_belova has joined #openstack-dev | 13:22 | |
*** vartom117 has quit IRC | 13:22 | |
*** ffio has quit IRC | 13:22 | |
*** ffio has joined #openstack-dev | 13:23 | |
*** bcrochet has quit IRC | 13:23 | |
*** rharwood has joined #openstack-dev | 13:23 | |
*** adjohn has quit IRC | 13:23 | |
*** navid__ has joined #openstack-dev | 13:24 | |
*** bcrochet has joined #openstack-dev | 13:25 | |
*** jayg|g0n3 is now known as jayg | 13:26 | |
*** neelashah has joined #openstack-dev | 13:26 | |
*** nshaikh has quit IRC | 13:26 | |
*** rods has joined #openstack-dev | 13:27 | |
*** ruhe has quit IRC | 13:28 | |
*** litong has joined #openstack-dev | 13:28 | |
*** boris-42 has quit IRC | 13:29 | |
*** boris-42 has joined #openstack-dev | 13:30 | |
*** bknudson has joined #openstack-dev | 13:30 | |
*** haleyb has quit IRC | 13:32 | |
*** FunnyLookinHat has quit IRC | 13:32 | |
*** tkammer has joined #openstack-dev | 13:33 | |
*** changbl has quit IRC | 13:34 | |
*** stevemar has joined #openstack-dev | 13:35 | |
*** jpeeler has joined #openstack-dev | 13:37 | |
*** afazekas has joined #openstack-dev | 13:37 | |
*** jpeeler has quit IRC | 13:37 | |
*** jpeeler has joined #openstack-dev | 13:37 | |
*** mmoya has joined #openstack-dev | 13:37 | |
*** anteaya has quit IRC | 13:41 | |
*** lbragstad has joined #openstack-dev | 13:41 | |
*** anteaya has joined #openstack-dev | 13:42 | |
*** zhongwenjia has quit IRC | 13:42 | |
*** nati_ueno has quit IRC | 13:45 | |
*** jrgcombr has joined #openstack-dev | 13:45 | |
*** ruhe has joined #openstack-dev | 13:51 | |
*** pmathews has quit IRC | 13:52 | |
*** jprovazn has quit IRC | 13:52 | |
*** edmund has joined #openstack-dev | 13:52 | |
*** zbitter is now known as zaneb | 13:52 | |
*** briancurtin has joined #openstack-dev | 13:56 | |
*** jprovazn has joined #openstack-dev | 13:56 | |
*** jrgcombr has quit IRC | 13:56 | |
jswarren | flaper87: Any chance you could review https://review.openstack.org/#/c/40885/ and its dependencies? They are t18n changes for glance, along the lines of what others have done in nova, ceilometer, etc. | 13:56 |
flaper87 | jswarren: sure, I'll take a look | 13:57 |
*** jimfehlig has joined #openstack-dev | 13:57 | |
*** jrgcombr has joined #openstack-dev | 13:58 | |
*** Ryan_Lane1 has quit IRC | 14:00 | |
*** msbrown has joined #openstack-dev | 14:00 | |
jswarren | flaper87: Many thanks! | 14:00 |
*** markmcclain has joined #openstack-dev | 14:00 | |
*** msbrown has left #openstack-dev | 14:00 | |
*** xga_ has joined #openstack-dev | 14:01 | |
*** ydacheville has joined #openstack-dev | 14:01 | |
*** topol has quit IRC | 14:01 | |
*** anniec has quit IRC | 14:01 | |
*** blamar has joined #openstack-dev | 14:02 | |
*** zul has joined #openstack-dev | 14:02 | |
*** ms_brown has joined #openstack-dev | 14:03 | |
*** ruhe has quit IRC | 14:04 | |
*** xga has quit IRC | 14:04 | |
*** ayoung has joined #openstack-dev | 14:05 | |
*** kbringard has joined #openstack-dev | 14:06 | |
*** eharney has joined #openstack-dev | 14:08 | |
*** fifieldt has quit IRC | 14:08 | |
*** armax has joined #openstack-dev | 14:10 | |
*** haleyb has joined #openstack-dev | 14:10 | |
*** ruhe has joined #openstack-dev | 14:11 | |
*** rnirmal has joined #openstack-dev | 14:12 | |
*** dina_belova has quit IRC | 14:14 | |
*** jrgcombr has quit IRC | 14:16 | |
*** cppcabrera has joined #openstack-dev | 14:16 | |
*** otherwiseguy has joined #openstack-dev | 14:17 | |
*** jrgcombr has joined #openstack-dev | 14:18 | |
*** radez_g0n3 is now known as radez | 14:19 | |
*** zaneb has quit IRC | 14:20 | |
*** zackf has joined #openstack-dev | 14:23 | |
*** alexb_ has quit IRC | 14:25 | |
*** utlemming has joined #openstack-dev | 14:27 | |
*** datsun180b has joined #openstack-dev | 14:27 | |
*** basha has joined #openstack-dev | 14:27 | |
*** FunnyLookinHat has joined #openstack-dev | 14:28 | |
*** rcleere has quit IRC | 14:28 | |
*** mmagr has quit IRC | 14:29 | |
*** rohitk has quit IRC | 14:29 | |
*** basha_ has joined #openstack-dev | 14:30 | |
*** cppcabrera has left #openstack-dev | 14:30 | |
*** alunduil has quit IRC | 14:30 | |
*** basha has quit IRC | 14:32 | |
*** alexb_ has joined #openstack-dev | 14:34 | |
*** zaneb has joined #openstack-dev | 14:34 | |
*** basha_ has quit IRC | 14:34 | |
*** lexinator has joined #openstack-dev | 14:35 | |
*** devvesa has joined #openstack-dev | 14:35 | |
*** devvesa has quit IRC | 14:35 | |
*** galstrom_zzz is now known as galstrom | 14:36 | |
*** devvesa has joined #openstack-dev | 14:36 | |
*** bswartz has quit IRC | 14:39 | |
*** alexxu has quit IRC | 14:39 | |
*** mdenny has joined #openstack-dev | 14:40 | |
*** changbl has joined #openstack-dev | 14:41 | |
*** mkollaro has quit IRC | 14:41 | |
*** esheffield has joined #openstack-dev | 14:41 | |
*** esheffield has left #openstack-dev | 14:42 | |
*** carl_baldwin has joined #openstack-dev | 14:42 | |
*** MIDENN_ has joined #openstack-dev | 14:44 | |
*** dina_belova has joined #openstack-dev | 14:44 | |
*** esheffield has joined #openstack-dev | 14:45 | |
*** mdenny has quit IRC | 14:45 | |
*** wolfdreamer has joined #openstack-dev | 14:45 | |
*** ruhe has quit IRC | 14:47 | |
*** mdenny has joined #openstack-dev | 14:47 | |
*** topol has joined #openstack-dev | 14:47 | |
*** matiu has joined #openstack-dev | 14:49 | |
*** basha has joined #openstack-dev | 14:49 | |
*** aloga_ has quit IRC | 14:50 | |
*** grepory has quit IRC | 14:51 | |
*** basha_ has joined #openstack-dev | 14:53 | |
*** egallen has quit IRC | 14:54 | |
*** basha has quit IRC | 14:54 | |
*** rcleere has joined #openstack-dev | 14:56 | |
*** jprovazn has quit IRC | 14:57 | |
*** jgallard has joined #openstack-dev | 14:57 | |
*** joesavak has joined #openstack-dev | 14:57 | |
*** bswartz has joined #openstack-dev | 14:58 | |
*** jsavak has quit IRC | 14:58 | |
*** hartsocks has joined #openstack-dev | 14:59 | |
*** reidrac has quit IRC | 14:59 | |
*** basha_ has quit IRC | 14:59 | |
*** mrodden1 has quit IRC | 14:59 | |
*** mkollaro has joined #openstack-dev | 15:00 | |
*** edmund has quit IRC | 15:01 | |
*** basha has joined #openstack-dev | 15:01 | |
*** mdenny has quit IRC | 15:02 | |
*** mdenny has joined #openstack-dev | 15:02 | |
*** sthaha has joined #openstack-dev | 15:03 | |
*** aelkikhia has joined #openstack-dev | 15:03 | |
*** hartsocks has left #openstack-dev | 15:04 | |
*** lexinator has quit IRC | 15:05 | |
*** basha has quit IRC | 15:06 | |
*** noslzzp is now known as noslzzp_lunch | 15:06 | |
*** noslzzp_lunch has quit IRC | 15:08 | |
*** _TheDodd_ has joined #openstack-dev | 15:09 | |
*** viraptor has joined #openstack-dev | 15:09 | |
*** sushils has quit IRC | 15:09 | |
*** jecarey_ has quit IRC | 15:10 | |
viraptor | hi all, does anyone know where in the code are the instance disks chowned to kvm/libvirt? I can't find the place which does that :/ the only explicit change I can see is to root in case of "uml" virtualisation | 15:11 |
*** mrodden has joined #openstack-dev | 15:11 | |
*** markwash has quit IRC | 15:11 | |
*** sushils has joined #openstack-dev | 15:12 | |
*** rackerjoe has quit IRC | 15:14 | |
*** briancurtin has quit IRC | 15:14 | |
JordanP | viraptor, I believe libvirt does the chown | 15:15 |
*** phschwartz has quit IRC | 15:15 | |
*** lorin1 has joined #openstack-dev | 15:15 | |
JordanP | viraptor, ./qemu.conf:#dynamic_ownership = 1 | 15:15 |
viraptor | JordanP: that would explain the missing code :) thanks | 15:16 |
*** hughsaunders has quit IRC | 15:16 | |
*** slagle has quit IRC | 15:17 | |
*** troytoman has quit IRC | 15:17 | |
*** alunduil has joined #openstack-dev | 15:17 | |
*** devvesa has quit IRC | 15:19 | |
*** vkmc has joined #openstack-dev | 15:20 | |
*** vkmc has quit IRC | 15:20 | |
*** vkmc has joined #openstack-dev | 15:20 | |
*** basha has joined #openstack-dev | 15:21 | |
*** briancurtin has joined #openstack-dev | 15:21 | |
*** basha_ has joined #openstack-dev | 15:22 | |
*** terriyu has joined #openstack-dev | 15:23 | |
*** jcannava has quit IRC | 15:25 | |
*** basha has quit IRC | 15:25 | |
*** Aj0 has quit IRC | 15:26 | |
*** basha_ has quit IRC | 15:27 | |
*** basha_ has joined #openstack-dev | 15:28 | |
*** pmathews has joined #openstack-dev | 15:28 | |
*** ruhe has joined #openstack-dev | 15:28 | |
*** alexb_ has quit IRC | 15:28 | |
*** jmontemayor has joined #openstack-dev | 15:30 | |
*** jtomasek has quit IRC | 15:30 | |
*** jsavak has joined #openstack-dev | 15:30 | |
*** gsilvis has joined #openstack-dev | 15:30 | |
*** devoid has joined #openstack-dev | 15:31 | |
*** basha_ has quit IRC | 15:32 | |
*** basha has joined #openstack-dev | 15:32 | |
*** jecarey has joined #openstack-dev | 15:33 | |
*** zbitter has joined #openstack-dev | 15:33 | |
*** hughsaunders has joined #openstack-dev | 15:33 | |
*** joesavak has quit IRC | 15:33 | |
*** basha_ has joined #openstack-dev | 15:34 | |
*** zaneb has quit IRC | 15:35 | |
*** basha has quit IRC | 15:36 | |
*** zaneb has joined #openstack-dev | 15:36 | |
*** ifarkas has quit IRC | 15:36 | |
*** phschwartz has joined #openstack-dev | 15:37 | |
*** Mandell has quit IRC | 15:37 | |
*** zbitter has quit IRC | 15:38 | |
*** troytoman-away has joined #openstack-dev | 15:38 | |
*** rackerjoe has joined #openstack-dev | 15:39 | |
*** basha_ has quit IRC | 15:39 | |
*** basha has joined #openstack-dev | 15:42 | |
*** basha_ has joined #openstack-dev | 15:46 | |
*** basha has quit IRC | 15:47 | |
*** basha__ has joined #openstack-dev | 15:48 | |
*** markwash has joined #openstack-dev | 15:49 | |
*** spzala has joined #openstack-dev | 15:50 | |
*** basha_ has quit IRC | 15:51 | |
*** ruhe has quit IRC | 15:51 | |
*** drewlander has joined #openstack-dev | 15:51 | |
*** devvesa has joined #openstack-dev | 15:52 | |
*** basha__ has quit IRC | 15:52 | |
*** basha has joined #openstack-dev | 15:53 | |
*** clayg_ is now known as clayg | 15:54 | |
mordred | markmc: dude. the indentation in nova is so bonghits | 15:54 |
markmc | mordred, whyso? | 15:54 |
mordred | markmc: because NONE of the indentation rules are enforced | 15:54 |
markmc | mordred, whyso? | 15:54 |
mordred | markmc: if you turn any of them on it is an absolute phonebook of problems | 15:54 |
markmc | ignore = E121,E122,E123,E124,E126,E127,E128,E711,E712,H102,H302,H404,F403,H501,F811,F841 | 15:55 |
markmc | this? | 15:55 |
mordred | markmc: yeah. all of the E12 | 15:55 |
mordred | you can't turn on any of them, because it's that bad | 15:55 |
mordred | even 'multiple of four' | 15:55 |
markmc | ah | 15:55 |
mordred | forget about over or under indented for visual indent :) | 15:55 |
markmc | the assertEqual() patch shouldn't make it worse though | 15:55 |
mordred | I don't know how to find the errors | 15:57 |
mordred | because the error checker is useless | 15:57 |
*** basha has quit IRC | 15:57 | |
*** troytoman-away is now known as troytoman | 15:57 | |
*** doron has joined #openstack-dev | 15:57 | |
mordred | without actually maually looking at all bazillion lines of it - at some point, we or someone needs to write a "please properly pep8 indent my code kthxbai" tool | 15:58 |
*** jgallard has quit IRC | 15:58 | |
*** ruhe has joined #openstack-dev | 15:58 | |
mordred | and then we need to run it over nova when we're all sitting in the room at the summit | 15:58 |
markmc | mordred, well, whoever reviews it should look at all the bazillion lines | 15:58 |
*** basha has joined #openstack-dev | 15:59 | |
*** lexinator has joined #openstack-dev | 15:59 | |
*** bdpayne has joined #openstack-dev | 15:59 | |
*** hemna has joined #openstack-dev | 16:01 | |
mordred | markmc: sure. but that's scanning a bunch of obviously global search and replaced lines. sigh. in any case - lemme see if I can figure out a way to script figure it out | 16:02 |
*** ociuhandu has joined #openstack-dev | 16:02 | |
*** tkammer has quit IRC | 16:03 | |
*** sarob has joined #openstack-dev | 16:03 | |
*** mmagr has joined #openstack-dev | 16:03 | |
*** safchain has quit IRC | 16:04 | |
*** troytoman is now known as troytoman-away | 16:04 | |
*** colinmcnamara has joined #openstack-dev | 16:05 | |
*** navid__ has left #openstack-dev | 16:05 | |
*** basha has quit IRC | 16:05 | |
*** colinmcnamara has left #openstack-dev | 16:05 | |
*** doron is now known as doron_afk | 16:05 | |
*** dripton_ is now known as dripton | 16:06 | |
*** jistr has quit IRC | 16:07 | |
*** mrodden has quit IRC | 16:09 | |
*** psedlak has quit IRC | 16:10 | |
*** grepory has joined #openstack-dev | 16:11 | |
*** basha has joined #openstack-dev | 16:11 | |
*** markmc has quit IRC | 16:11 | |
ayoung | henrynash, https://review.openstack.org/#/c/39530/17/keystone/common/config.py | 16:13 |
ayoung | https://review.openstack.org/#/c/39530/16..17/keystone/common/config.py | 16:14 |
henrynash | ayoung: so the only reason I didn't do it that way was in case we wante dot break out the individual groups to be done closer to the code (i.e. the ldap group was moved to the ldap driver or whatever) | 16:15 |
henrynash | ayoung: however, I'm fine with the approach you have added | 16:15 |
*** basha has quit IRC | 16:16 | |
*** comstud_ is now known as comstud | 16:16 | |
henrynash | ayoung: nice | 16:16 |
*** mrodden has joined #openstack-dev | 16:18 | |
*** zackf is now known as jrclouda | 16:18 | |
*** rwsu-away is now known as rwsu | 16:18 | |
*** jrclouda is now known as zackf | 16:19 | |
*** blamar has quit IRC | 16:20 | |
*** garyk has quit IRC | 16:20 | |
*** jbresnah has joined #openstack-dev | 16:20 | |
*** xga has joined #openstack-dev | 16:20 | |
*** xqueralt is now known as xqueralt-afk | 16:20 | |
*** sarob has quit IRC | 16:21 | |
*** xga_ has quit IRC | 16:23 | |
*** comay has joined #openstack-dev | 16:24 | |
*** kaushikc has joined #openstack-dev | 16:25 | |
*** troytoman-away is now known as troytoman | 16:27 | |
*** slagle has joined #openstack-dev | 16:27 | |
*** freedomhui has quit IRC | 16:28 | |
*** sarob has joined #openstack-dev | 16:28 | |
*** xga has quit IRC | 16:29 | |
*** lexinator1 has joined #openstack-dev | 16:30 | |
*** flaper87 is now known as flaper87|afk | 16:31 | |
*** lexinator has quit IRC | 16:32 | |
*** cppcabrera has joined #openstack-dev | 16:33 | |
*** cppcabrera has left #openstack-dev | 16:33 | |
*** radez is now known as radez_g0n3 | 16:33 | |
*** sarob has quit IRC | 16:34 | |
*** sarob has joined #openstack-dev | 16:34 | |
*** stevemar has quit IRC | 16:34 | |
*** doron_afk has quit IRC | 16:35 | |
*** aeperezt has joined #openstack-dev | 16:37 | |
*** psedlak has joined #openstack-dev | 16:38 | |
*** Bobba is now known as BobBall | 16:40 | |
*** rwsu has quit IRC | 16:41 | |
*** ruhe has quit IRC | 16:41 | |
*** gyee has joined #openstack-dev | 16:42 | |
*** ruhe has joined #openstack-dev | 16:43 | |
*** yaguang has quit IRC | 16:44 | |
*** HenryG_ has quit IRC | 16:44 | |
*** HenryG has joined #openstack-dev | 16:45 | |
*** emagana has joined #openstack-dev | 16:46 | |
*** rwsu has joined #openstack-dev | 16:47 | |
*** kbrierly has joined #openstack-dev | 16:48 | |
*** mmoya has quit IRC | 16:48 | |
*** MaxV has quit IRC | 16:49 | |
*** amir1 is now known as asadoughi | 16:50 | |
*** mrodden has quit IRC | 16:50 | |
*** mrodden1 has joined #openstack-dev | 16:50 | |
*** ruhe has quit IRC | 16:52 | |
*** fabio_ has joined #openstack-dev | 16:52 | |
*** fbo is now known as fbo_away | 16:53 | |
*** MaxV has joined #openstack-dev | 16:54 | |
*** lcheng has quit IRC | 16:54 | |
*** kaushikc has quit IRC | 16:54 | |
*** fabio has quit IRC | 16:55 | |
*** lucasagomes has quit IRC | 16:55 | |
*** sarob has quit IRC | 16:55 | |
*** lcheng has joined #openstack-dev | 16:55 | |
*** mdenny has quit IRC | 16:55 | |
*** MIDENN_ has quit IRC | 16:55 | |
*** mdenny has joined #openstack-dev | 16:55 | |
*** MIDENN_ has joined #openstack-dev | 16:56 | |
*** lexinator1 has quit IRC | 16:57 | |
*** mrunge has joined #openstack-dev | 16:57 | |
*** xqueralt-afk is now known as xqueralt | 16:59 | |
*** sthaha has quit IRC | 16:59 | |
*** kirankv has quit IRC | 17:00 | |
*** lexinator has joined #openstack-dev | 17:00 | |
*** troytoman is now known as troytoman-away | 17:00 | |
ayoung | henrynash, went to lunch...you can still break out individual entries if you want | 17:01 |
ayoung | this just manages the values for the big config file. | 17:01 |
henrynash | ayoung: sure, I'm OK with either approach | 17:01 |
*** sthaha has joined #openstack-dev | 17:02 | |
*** sthaha has quit IRC | 17:02 | |
*** sthaha has joined #openstack-dev | 17:02 | |
*** alop has joined #openstack-dev | 17:03 | |
*** alunduil has quit IRC | 17:04 | |
*** dosaboy has quit IRC | 17:04 | |
*** sthaha has quit IRC | 17:04 | |
*** ruhe has joined #openstack-dev | 17:05 | |
*** mrodden has joined #openstack-dev | 17:05 | |
*** JordanP has quit IRC | 17:06 | |
*** mmoya has joined #openstack-dev | 17:07 | |
*** mrodden1 has quit IRC | 17:07 | |
*** stevemar has joined #openstack-dev | 17:07 | |
*** cmark has joined #openstack-dev | 17:07 | |
henrynash | ayoung: btw, now that you have updated the patch, how do I update my local git to contain you changes? | 17:08 |
*** Aj0 has joined #openstack-dev | 17:09 | |
*** noslzzp has joined #openstack-dev | 17:10 | |
*** nati_ueno has joined #openstack-dev | 17:10 | |
*** SumitNaiksatam has quit IRC | 17:12 | |
ayoung | henrynash, gitrevew -d <reviewid> | 17:12 |
ayoung | minus the typos | 17:13 |
henrynash | and will that update my existing one? | 17:13 |
henrynash | (i.e. the copy I have locally) | 17:13 |
ayoung | git review -d I489e8e50035f88eca4235908ae8b1a532645daab | 17:13 |
ayoung | will make a new local branch | 17:13 |
*** colinmcnamara has joined #openstack-dev | 17:13 | |
ayoung | and fetch the commit from the gerrit repo | 17:13 |
henrynash | ok, so i just ditch my original branch | 17:13 |
ayoung | henrynash, have you done any more work on it? | 17:13 |
henrynash | no, not since 16 | 17:14 |
henrynash | ok, thx | 17:14 |
ayoung | then yeah. I use git review even when working on my own changes | 17:14 |
ayoung | that way I never accidentally work on an older copy | 17:14 |
ayoung | it makes a decent branch structure. I use it for review when I want to run the code as well. | 17:15 |
*** wfoster is now known as wfoster_away | 17:15 | |
henrynash | ayoung: and fetching the commit - you mean just the id or the whole commit message? | 17:16 |
*** afazekas has quit IRC | 17:16 | |
*** slagle has quit IRC | 17:17 | |
*** BobBall is now known as BobBall_Away | 17:18 | |
*** xqueralt is now known as xqueralt-afk | 17:19 | |
*** alexb_ has joined #openstack-dev | 17:19 | |
*** cmark has quit IRC | 17:20 | |
*** harlowja has joined #openstack-dev | 17:22 | |
*** garyk has joined #openstack-dev | 17:22 | |
*** fabio has joined #openstack-dev | 17:22 | |
*** dina_belova has quit IRC | 17:23 | |
fabio | ayoung: I am trying to move my OS-EP-FILTER extension to the your new database migration solution | 17:23 |
*** Mandell has joined #openstack-dev | 17:23 | |
fabio | ayoung: and I am struggling to get my tables built in the db, can you shed some light, please? | 17:24 |
*** martyntaylor has quit IRC | 17:24 | |
*** dina_belova has joined #openstack-dev | 17:24 | |
*** vipul is now known as vipul-away | 17:25 | |
*** yolanda has quit IRC | 17:25 | |
*** francois_eleouet has joined #openstack-dev | 17:26 | |
gyee | ayoung, I think fabio is the first one using the new extension migration framework | 17:26 |
*** vipul-away is now known as vipul | 17:27 | |
henrynash | ayoung: ok, got it, np | 17:28 |
*** freedomhui has joined #openstack-dev | 17:28 | |
*** colinmcnamara has quit IRC | 17:30 | |
*** jonesld has joined #openstack-dev | 17:30 | |
*** neelashah has quit IRC | 17:30 | |
*** Guest95014 has quit IRC | 17:33 | |
*** slagle has joined #openstack-dev | 17:33 | |
*** neelashah has joined #openstack-dev | 17:34 | |
*** cyeoh has quit IRC | 17:35 | |
*** cyeoh has joined #openstack-dev | 17:35 | |
*** SumitNaiksatam has joined #openstack-dev | 17:35 | |
*** briancurtin has quit IRC | 17:36 | |
*** vartom117 has joined #openstack-dev | 17:36 | |
*** jasond has joined #openstack-dev | 17:37 | |
*** sarob has joined #openstack-dev | 17:40 | |
*** jfriedly has joined #openstack-dev | 17:40 | |
*** mrunge has quit IRC | 17:44 | |
*** jonesld has quit IRC | 17:44 | |
*** martyntaylor has joined #openstack-dev | 17:45 | |
*** sarob has quit IRC | 17:46 | |
*** vipul is now known as vipul-away | 17:46 | |
*** ondergetekende_ has joined #openstack-dev | 17:46 | |
*** ondergetekende_ has quit IRC | 17:47 | |
ayoung | gyee, it is in the oauth review , too | 17:47 |
ayoung | fabio, what is the problem | 17:47 |
fabio | ayoung, I created a new repo following your example | 17:47 |
fabio | but how do I register it for the db to create the table, please? | 17:48 |
fabio | the db_sync does not pick it up | 17:48 |
ayoung | fabio, explicit call | 17:48 |
*** nati_ueno has quit IRC | 17:48 | |
ayoung | keystone-manage db_sync --- | 17:48 |
*** dina_belova has quit IRC | 17:49 | |
fabio | ayoung, ok I will give it a try, thanks | 17:49 |
ayoung | keystone-manage db_sync --extension yourextension | 17:49 |
*** dina_belova has joined #openstack-dev | 17:49 | |
fabio | ayoung, is yourextension the migrate_repo of the extension? | 17:50 |
*** gordc has quit IRC | 17:50 | |
ayoung | fabio, the assumption is that all extensions that go in to H3 are disabled by default, and have to be explicitly enabled. If we want to make one explicitly enabled in Icehouse, we will put in a list of extension that also get migrated via the core call | 17:50 |
ayoung | so something like | 17:50 |
ayoung | for extension in ['kds', 'foo','bar'] : migration.db_version_control(....) | 17:51 |
*** jbresnah has quit IRC | 17:51 | |
ayoung | but since we don't have any yet, that code is not yet written | 17:51 |
fabio | ayoung, I guess EP Filter will be the first then | 17:51 |
gyee | ayoung, what does that mean? we have to enable the extension in order for migration to work? | 17:52 |
*** tjones has joined #openstack-dev | 17:53 | |
*** zul has quit IRC | 17:55 | |
ayoung | gyee, other way around | 17:55 |
ayoung | gyee, we will have to explictly run the migration in order to be able to use the extension | 17:55 |
*** jruzicka has quit IRC | 17:55 | |
gyee | so enabling extension and migration are two different thing | 17:55 |
ayoung | gyee, one is a DB thing, the other a pasteconfig pipeline change | 17:56 |
*** martyntaylor has quit IRC | 17:56 | |
gyee | right, but they don't have to occur in certain order, just need to do both at some point before the extension is usable | 17:56 |
ayoung | gyee, however, if you get dolph to sign off on it, I am ok with making the migration run by default. It just not code that is written yet | 17:56 |
*** mrunge has joined #openstack-dev | 17:56 | |
ayoung | fabio, gyee see keystone/cli.py line 74 | 17:57 |
*** zbitter has joined #openstack-dev | 17:57 | |
ayoung | line 77-91 should be refactored out to a function migrate_extension(extension_name) | 17:57 |
*** dolphm has joined #openstack-dev | 17:58 | |
*** sarob has joined #openstack-dev | 17:59 | |
*** jruzicka has joined #openstack-dev | 17:59 | |
*** vipul-away is now known as vipul | 17:59 | |
*** zaneb has quit IRC | 18:00 | |
gyee | ayoung, got it, we don't need to enable extension migration by default as long as they are self-contained as they supposed to be | 18:00 |
ayoung | gyee, sounds good. Idea is that we will move some migrations into the default list in Icehouse. | 18:00 |
*** leif has joined #openstack-dev | 18:01 | |
*** mmagr has quit IRC | 18:01 | |
*** leif is now known as Guest2281 | 18:01 | |
*** alunduil has joined #openstack-dev | 18:01 | |
*** boris-42 has quit IRC | 18:02 | |
*** spzala has quit IRC | 18:03 | |
*** francois_eleouet has quit IRC | 18:03 | |
*** sudorandom has joined #openstack-dev | 18:04 | |
*** spzala has joined #openstack-dev | 18:04 | |
*** zbitter is now known as zaneb | 18:04 | |
*** neelashah1 has joined #openstack-dev | 18:05 | |
*** blamar has joined #openstack-dev | 18:05 | |
*** neelashah has quit IRC | 18:05 | |
*** Guest2281 has quit IRC | 18:06 | |
*** gordc has joined #openstack-dev | 18:06 | |
*** alexb_ has quit IRC | 18:06 | |
*** jonesld has joined #openstack-dev | 18:07 | |
*** leif_ has joined #openstack-dev | 18:07 | |
*** ffio_ has joined #openstack-dev | 18:08 | |
*** ffio has quit IRC | 18:09 | |
*** martine_ has quit IRC | 18:09 | |
*** martine has joined #openstack-dev | 18:09 | |
*** martine is now known as martine_ | 18:09 | |
iccha | annegentle: spoke to koolhead17 , up for the pdl | 18:11 |
koolhead17 | annegentle, ^^ | 18:12 |
*** radez_g0n3 is now known as radez | 18:13 | |
*** sushils has quit IRC | 18:14 | |
*** leif__ has joined #openstack-dev | 18:15 | |
*** leif_ has quit IRC | 18:15 | |
*** ociuhandu has quit IRC | 18:15 | |
*** terryh has joined #openstack-dev | 18:17 | |
*** jhesketh has quit IRC | 18:17 | |
*** francois_eleouet has joined #openstack-dev | 18:17 | |
*** ruhe has quit IRC | 18:17 | |
*** alexb_ has joined #openstack-dev | 18:20 | |
*** loteriety has joined #openstack-dev | 18:20 | |
*** Mandell has quit IRC | 18:21 | |
*** boris-42 has joined #openstack-dev | 18:22 | |
annegentle | iccha: awesome, thanks. Still working through it but will put your name in. | 18:23 |
*** briancurtin has joined #openstack-dev | 18:24 | |
*** xga has joined #openstack-dev | 18:26 | |
*** dina_belova has quit IRC | 18:28 | |
*** SergeyLukjanov has quit IRC | 18:28 | |
*** otherwiseguy has quit IRC | 18:29 | |
*** ruhe has joined #openstack-dev | 18:29 | |
*** ruhe has quit IRC | 18:29 | |
*** zul has joined #openstack-dev | 18:30 | |
*** xga has quit IRC | 18:30 | |
*** devvesa has quit IRC | 18:30 | |
*** venkatesh has joined #openstack-dev | 18:32 | |
*** Mandell has joined #openstack-dev | 18:34 | |
*** jonesld has quit IRC | 18:35 | |
*** edmund has joined #openstack-dev | 18:37 | |
*** nati_ueno has joined #openstack-dev | 18:37 | |
*** jmontemayor has quit IRC | 18:37 | |
*** alexpilotti has quit IRC | 18:38 | |
*** aelkikhia has left #openstack-dev | 18:39 | |
*** novas0x2a|laptop has joined #openstack-dev | 18:39 | |
*** terryh has quit IRC | 18:44 | |
*** tjones has quit IRC | 18:44 | |
*** alexb_ has quit IRC | 18:45 | |
*** nayward has quit IRC | 18:46 | |
*** Alexei_987 has quit IRC | 18:48 | |
*** melwitt has joined #openstack-dev | 18:48 | |
*** jasdeepH has joined #openstack-dev | 18:49 | |
*** SergeyLukjanov has joined #openstack-dev | 18:56 | |
*** freedomhui has quit IRC | 18:57 | |
*** noslzzp has quit IRC | 18:58 | |
*** datsun180b_ has joined #openstack-dev | 19:00 | |
*** comay has quit IRC | 19:00 | |
*** francois_eleouet has quit IRC | 19:00 | |
*** comay has joined #openstack-dev | 19:00 | |
*** jlabocki1 has quit IRC | 19:01 | |
*** datsun180b has quit IRC | 19:01 | |
*** datsun180b_ is now known as datsun180b | 19:01 | |
*** Aj0 has quit IRC | 19:01 | |
*** colinmcnamara has joined #openstack-dev | 19:03 | |
*** edmund has quit IRC | 19:04 | |
*** troytoman-away is now known as troytoman | 19:04 | |
jasond | is anybody on the oslo.config team around? | 19:04 |
*** ffio_ has quit IRC | 19:06 | |
*** zaneb has quit IRC | 19:06 | |
*** zaneb has joined #openstack-dev | 19:07 | |
*** colinmcnamara has quit IRC | 19:08 | |
*** t-8ch has quit IRC | 19:09 | |
*** datsun180b has quit IRC | 19:10 | |
*** t-8ch has joined #openstack-dev | 19:10 | |
*** datsun180b has joined #openstack-dev | 19:10 | |
*** Aj0 has joined #openstack-dev | 19:11 | |
*** zaneb has quit IRC | 19:12 | |
*** martine_ has quit IRC | 19:12 | |
*** zaneb has joined #openstack-dev | 19:13 | |
*** Chaser has quit IRC | 19:14 | |
*** nati_ueno has quit IRC | 19:15 | |
*** Chaser has joined #openstack-dev | 19:16 | |
*** markmc has joined #openstack-dev | 19:16 | |
*** francois_eleouet has joined #openstack-dev | 19:17 | |
*** adalbas has quit IRC | 19:17 | |
markmc | simo, hey | 19:19 |
*** jbresnah has joined #openstack-dev | 19:19 | |
*** spandhe has joined #openstack-dev | 19:19 | |
simo | markmc: sup ? | 19:21 |
markmc | simo, wondering what's the latest on the secure messaging stuff | 19:21 |
markmc | simo, before release meeting in a couple of hours | 19:21 |
simo | markmc: working on it today | 19:22 |
simo | markmc: I should have patches for you tomorrow | 19:23 |
simo | markmc: some provisional as we are still reviewing the KDS API in keystone | 19:23 |
simo | markmc: but it should be only a minor change to KDSClient | 19:23 |
markmc | simo, yeah ... but there hasn't been any updates to the KDS patch review either? | 19:23 |
markmc | simo, where have the KDS API discussions been going on? | 19:24 |
simo | markmc: they told me late we needed to ogo through an api patch review first | 19:24 |
simo | so we are reviewing the api document now | 19:24 |
simo | once that is final I can push a new revised patch for KDS itself | 19:24 |
simo | I have those patches ready | 19:24 |
*** gyee has quit IRC | 19:25 | |
markmc | ah, this: https://review.openstack.org/#/c/40692/ | 19:25 |
* markmc looks | 19:25 | |
markmc | I'll add a comment to the blueprint and gerrit review | 19:25 |
markmc | because anyone checking on the status just sees that there's been no progress | 19:25 |
jasond | markmc: do you have any suggestions on how we might ensure the CLI options override the config file options? http://dunsmor.com/heat/bug-1195236.html | 19:25 |
*** JonnyNomad has joined #openstack-dev | 19:25 | |
simo | markmc: thanks | 19:26 |
simo | sorry I coldn't speed this up,. but I had to work on a different project last week | 19:26 |
jasond | right now --verbose and --debug are separate options. making a --log-level option would solve this, but is there a nicer way? | 19:26 |
*** vipul is now known as vipul-away | 19:27 | |
*** cthulhup has joined #openstack-dev | 19:27 | |
*** neelashah1 has quit IRC | 19:27 | |
markmc | simo, was there a bunch of discussion around patch set 1-4 of that review? | 19:28 |
simo | stevemar: Steve Martinelli ? | 19:28 |
markmc | simo, I only see stuff starting from patch set 5 | 19:28 |
stevemar | simo: hola | 19:28 |
*** odyssey4me has quit IRC | 19:28 | |
simo | stevemar: I am reading your review, it is too dense | 19:28 |
simo | half of your remarks I can't understand what you want | 19:28 |
*** dina_belova has joined #openstack-dev | 19:28 | |
simo | stevemar: what do you want to put in the header ? | 19:29 |
markmc | jasond, what version of oslo.config is this? | 19:29 |
stevemar | simo: anything I can help with. sure, let me find an example | 19:29 |
*** adalbas has joined #openstack-dev | 19:29 | |
simo | stevemar: keep in mind these code is already done | 19:29 |
simo | stevemar: so I want *very* good reasons for changes :) | 19:29 |
stevemar | simo: the implementation? | 19:30 |
*** chuckieb has quit IRC | 19:30 | |
markmc | jasond, see http://docs.openstack.org/developer/oslo.config/#a3 | 19:30 |
stevemar | simo: i just have issues with the spec :) | 19:30 |
markmc | jasond, https://bugs.launchpad.net/oslo/+bug/1176817 | 19:30 |
uvirtbot | Launchpad bug 1176817 in oslo "Give priority to CLI args" [High,Fix released] | 19:30 |
stevemar | simo: if you look at https://review.openstack.org/#/c/37545/10/openstack-identity-api/v3/src/markdown/identity-api-v3-os-quotas-ext.md | 19:30 |
simo | stevemar: yeah the spec came after the implementation for various reasons | 19:31 |
*** xBsd has joined #openstack-dev | 19:31 | |
stevemar | the headers all have the same format ie: #### Get resource list: `GET /OS-QUOTAS/resources` | 19:31 |
*** dina_belova has quit IRC | 19:31 | |
stevemar | simo: whereas yours have: #### Request attributes | 19:31 |
stevemar | simo: then the method/endpoint afterward | 19:31 |
simo | stevemar: ooh | 19:31 |
simo | ok | 19:32 |
stevemar | simo: just not consistent with the others :) | 19:32 |
simo | I told you you were too dense | 19:32 |
simo | I thought you meant HTTP Headers | 19:32 |
stevemar | oh haha | 19:32 |
simo | and I was all WTF ? | 19:32 |
stevemar | nah nah | 19:32 |
stevemar | sorry, i was trying to do too many things at once | 19:32 |
simo | np | 19:32 |
stevemar | let me know if you have any other q's, i was very liberal in not being specific :) | 19:33 |
simo | if it is just the document headers I am going to fix and push now | 19:33 |
stevemar | a few others too, I think you used Returns: or Reply: in some places, stick with "Response" | 19:34 |
stevemar | simo^ | 19:34 |
simo | yup I just saw that and was fixin; | 19:34 |
*** giulivo has quit IRC | 19:34 | |
stevemar | cool cool | 19:34 |
*** otherwiseguy has joined #openstack-dev | 19:35 | |
*** neelashah has joined #openstack-dev | 19:36 | |
*** tiamar has left #openstack-dev | 19:36 | |
ayoung | stevemar, thanks for the KDS review. Putting you through the paces paid off. | 19:37 |
stevemar | haha, ayoung: yep, i've learned | 19:38 |
*** jmontemayor has joined #openstack-dev | 19:38 | |
morganfainberg | simo: i think i have a couple of added notes regarding the phrasing, but it really doesn't have much that needs fixing | 19:38 |
*** dina_belova has joined #openstack-dev | 19:38 | |
simo | stevemar: the link is perfectly valid though, why you say it is not valid ? | 19:38 |
simo | morganfainberg: ack | 19:38 |
stevemar | simo: it wouldn't be click-able :D | 19:38 |
simo | stevemar: how do you make it clickable ? | 19:39 |
morganfainberg | simo: about to post my comments but they are mostly just for ease of reading :) | 19:39 |
stevemar | simo: http://daringfireball.net/projects/markdown/dingus | 19:39 |
simo | I couldn't find a way, I am not markdown-savvy | 19:39 |
jasond | markmc: i actually tested that code, but it didn't fix the problem | 19:39 |
*** qba73_ has joined #openstack-dev | 19:39 | |
jasond | markmc: the issue stems from the fact that --verbose and --debug are treated separately | 19:39 |
*** tiamar has joined #openstack-dev | 19:40 | |
stevemar | simo: like this New link, click [here](http://www.blah.org) | 19:40 |
jasond | when they are really one option | 19:40 |
stevemar | the text that you want to hyper-link should be in square braces | 19:40 |
stevemar | and the actual link in () | 19:40 |
stevemar | simo^ | 19:40 |
*** sarob has quit IRC | 19:40 | |
simo | stevemar: ok | 19:40 |
*** qba73_ has left #openstack-dev | 19:40 | |
*** sarob has joined #openstack-dev | 19:41 | |
*** dina_belova has quit IRC | 19:43 | |
markmc | jasond, ok - looking closer, that seems like the right behaviour to me | 19:44 |
markmc | jasond, verbose increases the log level to INFO, debug increases it to DEBUG | 19:44 |
*** cthulhup has quit IRC | 19:44 | |
markmc | jasond, it's the behaviour I'd expect | 19:44 |
morganfainberg | simo: published my comments. It looks good from a readablility standpoint (and Stevemar got most of the other things i would say in his comments) | 19:45 |
markmc | jasond, if you want debug message, but not info messages ... using --log-config should do it I think | 19:45 |
* markmc adds those comments to the bug | 19:45 | |
jasond | markmc: senario #2 specifically http://dunsmor.com/heat/bug-1195236.html | 19:45 |
jasond | in that case, the CLI option is being overridden by the config file | 19:46 |
markmc | verbose=True, debug=True heat-engine -v | 19:46 |
markmc | that one ? | 19:46 |
markmc | -v sets verbose=True | 19:47 |
markmc | the config file sets verbose=True | 19:47 |
jasond | yes. but those options aren't independent | 19:47 |
jasond | --verbose is like --log-level=INFO | 19:48 |
markmc | what behaviour do you expect in scenario #2 and why? | 19:48 |
jasond | --debug is like --log-level=DEBUG | 19:48 |
*** portante is now known as portante|afk | 19:48 | |
markmc | not exactly, no | 19:48 |
markmc | debug is enable debugging | 19:49 |
markmc | only debug=False will turn off debugging | 19:49 |
markmc | verbose=True has no effect if debug=True | 19:49 |
* markmc goes for dinner | 19:49 | |
*** fabio has quit IRC | 19:50 | |
*** dina_belova has joined #openstack-dev | 19:50 | |
jasond | markmc: if the config file says log-level=DEBUG and the CLI says --log-level=INFO, the log level should be INFO, not DEBUG | 19:51 |
ayoung | markmc, when you come back, tell me if this is the general approach to configuration you think we should support: https://review.openstack.org/#/c/39530/17/keystone/common/config.py | 19:51 |
ayoung | henrynash, can you +1 your own review request if you think it is good, and I will do the same? | 19:51 |
ayoung | https://review.openstack.org/#/c/39530/17 | 19:51 |
*** alop_ has joined #openstack-dev | 19:52 | |
*** lifeless_ is now known as lifeless | 19:52 | |
*** xBsd has quit IRC | 19:52 | |
*** alop has quit IRC | 19:52 | |
*** alop_ is now known as alop | 19:52 | |
*** ruhe has joined #openstack-dev | 19:53 | |
*** topol has quit IRC | 19:53 | |
*** pcm_ has quit IRC | 19:53 | |
*** zaitcev has joined #openstack-dev | 19:54 | |
*** lexinator1 has joined #openstack-dev | 19:54 | |
*** mdenny has quit IRC | 19:55 | |
*** MIDENN_ has quit IRC | 19:55 | |
*** cthulhup has joined #openstack-dev | 19:55 | |
*** AlanClark has joined #openstack-dev | 19:55 | |
*** lexinator has quit IRC | 19:56 | |
*** mdenny has joined #openstack-dev | 19:56 | |
simo | morganfainberg: the principal advantage is one, why do you want me to make it plural ? | 19:56 |
*** MIDENN_ has joined #openstack-dev | 19:56 | |
*** jruzicka has quit IRC | 19:56 | |
morganfainberg | simo: you have a run-on sentence that is more of a list of "advantages" in the way it's written | 19:56 |
*** devvesa has joined #openstack-dev | 19:56 | |
simo | no the 'and' is not a separator that define 2 advantages | 19:57 |
*** adjohn has joined #openstack-dev | 19:57 | |
simo | it is a conjunction that expands on the only one | 19:57 |
*** drewlander has quit IRC | 19:57 | |
morganfainberg | sec. | 19:57 |
simo | morganfainberg: I blame ayoung for that convoluted phrase though, :) | 19:57 |
morganfainberg | hehe | 19:58 |
morganfainberg | the conjunction is just not clear | 19:58 |
*** adjohn has quit IRC | 19:58 | |
morganfainberg | "the Encryption and Signing Key exchange can be regulated by the Key Server" one phrase, "and it can apply access control" second phrase, "and deny communication between arbitrary peers in the system" | 19:59 |
morganfainberg | thrd | 19:59 |
bknudson | ayoung: you asked to be added to LDAP reviews, so I added you to some I submitted. | 19:59 |
morganfainberg | the issue is that when reading it, you get "and this and that" | 19:59 |
simo | morganfainberg: I can see that | 20:00 |
morganfainberg | simo: so rephrasing without the second "and" would make it more readable, or call it multiple principal benefits :) | 20:00 |
simo | not sure how to fix it | 20:00 |
morganfainberg | simo: if you give me a few moments i'll see if i can come up with something. | 20:00 |
*** neelashah has quit IRC | 20:00 | |
*** francois_eleouet has quit IRC | 20:01 | |
*** sandywalsh has quit IRC | 20:01 | |
*** Aj0 has quit IRC | 20:02 | |
simo | morganfainberg: yup, still going through dolphm comments | 20:02 |
morganfainberg | simo: "The principal advantage of using a Key Server instead of a pure public-key based system is that the Encryption and Signing Key exchange can be regulated by the Key Server allowing application of access controls and denying communications between arbitrary peers within the system." ? | 20:03 |
*** francois_eleouet has joined #openstack-dev | 20:03 | |
*** zul has quit IRC | 20:04 | |
*** jonesld has joined #openstack-dev | 20:04 | |
*** colinmcnamara has joined #openstack-dev | 20:06 | |
*** tjones has joined #openstack-dev | 20:06 | |
*** spzala has quit IRC | 20:07 | |
*** Aj0 has joined #openstack-dev | 20:08 | |
*** datsun180b_ has joined #openstack-dev | 20:08 | |
*** jruzicka has joined #openstack-dev | 20:09 | |
simo | morganfainberg: I'll think about that, it look good at a quick read | 20:09 |
*** mkollaro has quit IRC | 20:10 | |
morganfainberg | simo: sure. thing, just as an option. | 20:10 |
*** datsun180b has quit IRC | 20:11 | |
*** datsun180b_ is now known as datsun180b | 20:11 | |
*** venkatesh has quit IRC | 20:11 | |
*** dprince has quit IRC | 20:12 | |
*** sandywalsh has joined #openstack-dev | 20:13 | |
*** dolphm has quit IRC | 20:13 | |
*** troytoman is now known as troytoman-away | 20:13 | |
*** vipul-away is now known as vipul | 20:14 | |
*** adjohn has joined #openstack-dev | 20:16 | |
*** vkmc has quit IRC | 20:16 | |
*** sandywalsh has quit IRC | 20:20 | |
*** neelashah has joined #openstack-dev | 20:20 | |
ayoung | stevemar, do you think you might want sql_upgrade testing for oauth? | 20:23 |
ayoung | I won't insist on it, but it is probably worth adding | 20:23 |
*** colinmcnamara has quit IRC | 20:24 | |
boris-42 | mordred Hi | 20:24 |
ayoung | bknudson, since you wrote, and sahdev reviewed, I felt OK +2 and approving a few of those LDAP changes | 20:25 |
*** jkyle has quit IRC | 20:25 | |
bknudson | ayoung: great. We've got someone here testing active directory and they had these problems. | 20:26 |
bknudson | and I felt the need to update tests. | 20:26 |
ayoung | bknudson, I want to reenable the Unicode one once we have a solution there. | 20:27 |
bknudson | ayoung: yes. I put the skip in because I wanted to get clean runs. | 20:27 |
ayoung | bknudson, agreed. We really need to get LDAP support in the gate job. With the split backend, it should be easier | 20:28 |
ayoung | we'll get testing of both SQL and LDAP in one pass | 20:28 |
morganfainberg | ayoung: that will be nice | 20:28 |
bknudson | just need an active directory server | 20:29 |
bknudson | ;) | 20:29 |
*** vkmc has joined #openstack-dev | 20:29 | |
ayoung | bknudson, no. No we do not. | 20:30 |
*** tserong_ has joined #openstack-dev | 20:30 | |
*** tserong has quit IRC | 20:33 | |
*** sandywalsh has joined #openstack-dev | 20:33 | |
*** cthulhup has quit IRC | 20:35 | |
*** jonesld has quit IRC | 20:35 | |
*** woodspa has quit IRC | 20:35 | |
ayoung | bknudson, is https://review.openstack.org/#/c/40893/5/keystone/identity/backends/ldap.py still safe for normal LDAP? | 20:38 |
ayoung | int(self.enabled_default)) seems to imply it must be an integer. THought that was an AD thing only | 20:38 |
*** dina_belova has quit IRC | 20:39 | |
bknudson | ayoung: we only get into this code if they have self.enabled_mask set. | 20:39 |
*** vipul is now known as vipul-away | 20:39 | |
ayoung | right...I misread that. So it compares one int with another this way... | 20:40 |
bknudson | ayoung: so if you have enabled_mask set, then enabled_default must be an integer | 20:40 |
*** francois_eleouet has quit IRC | 20:40 | |
ayoung | cfg.IntOpt('user_enabled_mask', default=0), | 20:40 |
*** nachi has joined #openstack-dev | 20:41 | |
*** ruhe has quit IRC | 20:41 | |
bknudson | ayoung: the enabled_mask is checked for != 0 at line 120 | 20:41 |
ayoung | yep. +2ed and approved | 20:42 |
ayoung | get sahdev to chime in on https://review.openstack.org/#/c/40996/ and I'll approve as well. Or someone else with LDAP background | 20:42 |
*** adjohn has quit IRC | 20:43 | |
ayoung | bknudson, https://review.openstack.org/#/c/41515/3/keystone/common/ldap/core.py do we always want to normalize? This seems too AD specific too me | 20:45 |
*** ruhe has joined #openstack-dev | 20:45 | |
bknudson | ayoung: it is a little heavy-weight. | 20:45 |
*** mrunge has quit IRC | 20:45 | |
*** vipul-away is now known as vipul | 20:45 | |
bknudson | ayoung: but I didn't make it AD-specific because it's really about LDAP compatibility | 20:45 |
*** adalbas has quit IRC | 20:45 | |
bknudson | ayoung: I don't think there's anything in the spec that says the server can't normalize DN attribute values. | 20:46 |
*** ruhe has quit IRC | 20:46 | |
bknudson | this is where it would be useful to have an AD-specific LDAP backend. | 20:46 |
nachi | topol: you online | 20:47 |
bknudson | I think an LDAP server (and maybe AD does this) could do more types of normalization than just capitalizing the attr names... | 20:47 |
ayoung | bknudson, this code bothers me. I am not comfortable with doing something AD specific that might break non AD LDAP deployments. | 20:47 |
bknudson | could probably change "commonName=xxx" to "CN=xxx" if it wanted. | 20:47 |
benner | ls | 20:48 |
ayoung | not by default, and not if there is another way to confgure that gets the same result | 20:48 |
bknudson | ayoung: the only thing we actually do is normalize the DNs when compare DNs in the role check. | 20:48 |
*** tmclaugh[work] has quit IRC | 20:48 | |
bknudson | https://review.openstack.org/#/c/41515/3/keystone/assignment/backends/ldap.py | 20:48 |
bknudson | That's the only real change. The others are testing. | 20:48 |
*** xqueralt-afk is now known as xqueralt | 20:49 | |
*** troytoman-away is now known as troytoman | 20:49 | |
bknudson | there's no change to how the entries are sent to the db. | 20:49 |
*** xqueralt is now known as xqueralt-afk | 20:50 | |
bknudson | I changed FakeLDAP to also mess up the member attribute and found that there was noplace where that caused a problem with comparing DNs. | 20:50 |
ayoung | yeah, I see that. I am not saying no, just seeing if my stomach settles before OKing this one | 20:50 |
bknudson | try ginger ale | 20:51 |
stevemar | ayoung: ping | 20:53 |
ayoung | stevemar, yep | 20:53 |
stevemar | ayoung: ugh, nvm, i ping'ed too hastily... | 20:53 |
* stevemar walks away awkwardly | 20:54 | |
morganfainberg | stevemar: ministry of funny walks time? | 20:54 |
stevemar | morganfainberg: possibly | 20:55 |
ayoung | stevemar, It's not particularly silly, is it? I mean, the right leg isn't silly at all and the left leg merely does a forward aerial half turn every alternate step. | 20:56 |
morganfainberg | lbragstad: just checking one more thing on your (initial implementation) logging patch, it's looking good | 20:56 |
*** loteriety has quit IRC | 20:56 | |
*** boris-42 has quit IRC | 21:00 | |
*** vkmc has quit IRC | 21:00 | |
*** troytoman is now known as troytoman-away | 21:00 | |
*** dolphm has joined #openstack-dev | 21:00 | |
lbragstad | morganfainberg: cool, there is one dependent on it that does more of the refactoring | 21:01 |
*** moted has quit IRC | 21:02 | |
*** vipul is now known as vipul-away | 21:02 | |
*** moted has joined #openstack-dev | 21:02 | |
*** boris-42 has joined #openstack-dev | 21:02 | |
*** gabrielhurley has joined #openstack-dev | 21:03 | |
*** ms_brown has quit IRC | 21:03 | |
*** lorin1 has quit IRC | 21:03 | |
morganfainberg | lbragstad: yeah. i saw that. | 21:06 |
ayoung | dolphm, https://review.openstack.org/#/c/41606/5 leaves me wondering if we should not be stating what the service types are at all. | 21:06 |
stevemar | ayoung: added upgrade/downgrade tests for sql in my oauth patch | 21:06 |
lbragstad | morganfainberg: cool, thanks again for checking it out | 21:06 |
ayoung | stevemar, cool, I'll look | 21:06 |
dolphm | ayoung: agree | 21:06 |
morganfainberg | lbragstad: i am just setting up httpd keystone so i can verify it looks good, but it's easy, not surprises yet | 21:06 |
*** boris-42 has quit IRC | 21:07 | |
morganfainberg | no* | 21:07 |
dolphm | ayoung: especially with 'one of' instead of simply 'e.g.' | 21:07 |
*** adjohn has joined #openstack-dev | 21:07 | |
lbragstad | morganfainberg: good deal! | 21:07 |
dolphm | ayoung: sounds like that list is going to be enforced | 21:07 |
*** jsavak has quit IRC | 21:07 | |
*** andymccr has quit IRC | 21:07 | |
*** t-8ch has quit IRC | 21:08 | |
ayoung | dolphm, yeah, and I think we will see an explosion of services in the not-too-distant future | 21:08 |
dolphm | ayoung: already seeing it! | 21:09 |
*** xBytez has quit IRC | 21:09 | |
*** t-8ch has joined #openstack-dev | 21:11 | |
*** sushils has joined #openstack-dev | 21:11 | |
*** rfolco has quit IRC | 21:12 | |
*** andymccr has joined #openstack-dev | 21:12 | |
ayoung | stevemar, +2 from me | 21:13 |
ayoung | well done | 21:13 |
*** vartom117 has quit IRC | 21:14 | |
*** jpich has quit IRC | 21:14 | |
stevemar | ayoung, yay! thanks man | 21:14 |
*** MaxV has quit IRC | 21:17 | |
morganfainberg | stevemar: i'm going to do 1 more pass on it, but i should get to that in the next 20 mins | 21:19 |
ayoung | stevemar, did yousee what I wrote to fabio_ about migrations for extensions? Right now,they will not be run unless you explicitly pass them to keystone-manage. IN Icehouse, we can add supported extensions to the list of migrations run by default. | 21:19 |
*** devvesa has quit IRC | 21:19 | |
*** bswartz has quit IRC | 21:19 | |
morganfainberg | stevemar: but it looks like you hit the last of my concerns easily with the last patchsets. | 21:20 |
stevemar | ayoung: i didn't see that written to fabio, but i noticed it in the docs. | 21:20 |
stevemar | morganfainberg: i think so, between last night and this morning | 21:20 |
morganfainberg | stevemar: yeah, it was def. super close. | 21:21 |
*** adjohn has quit IRC | 21:21 | |
stevemar | maybe dolphm wants the final stamp of approval? he recommended the last 3 access_token apis | 21:21 |
morganfainberg | I was going to +2 if it was good but not approve | 21:22 |
dolphm | stevemar: which patch? | 21:22 |
morganfainberg | stevemar: in case someone else wanted to say something. | 21:22 |
stevemar | dolphm: latest | 21:22 |
*** t-8ch has quit IRC | 21:22 | |
*** andymccr has quit IRC | 21:22 | |
stevemar | morganfainberg: ah | 21:22 |
dolphm | stevemar: oauth impl? | 21:22 |
stevemar | dolphm: is there anything else i do? yes :) | 21:22 |
*** galstrom has quit IRC | 21:22 | |
morganfainberg | stevemar: it's pretty massive changeset. lots of eyes and all | 21:23 |
*** Thor^^ has joined #openstack-dev | 21:23 | |
*** markmc has quit IRC | 21:23 | |
*** Thor has quit IRC | 21:23 | |
morganfainberg | oh whoopse. crap, did I approve before smokestack on that logging one? | 21:24 |
*** jkyle has joined #openstack-dev | 21:24 | |
ayoung | mhu, I like what you are doing with ec2 token stuff. just want to make sure you rebase your approach on the other credential work going on. Let me know if you have any questions. | 21:24 |
morganfainberg | noticed jenkins said +1 but not smoekstack =/ sorry if that was wrong | 21:25 |
*** vipul-away is now known as vipul | 21:25 | |
*** nati_ueno has joined #openstack-dev | 21:25 | |
*** xBsd has joined #openstack-dev | 21:25 | |
lbragstad | morganfainberg: thanks for the +2, I repushed the dep. commit. ayoung looked at that one too. https://review.openstack.org/#/c/41484/ | 21:26 |
morganfainberg | lbragstad: ok. | 21:26 |
*** jasondotstar has quit IRC | 21:26 | |
morganfainberg | lbragstad: i'm going to take a bit more time on that one. there is a bunch of stuff (nothing major, but still) | 21:27 |
morganfainberg | i don't expect it'll be any issue though. | 21:27 |
stevemar | simo: one last fix and i promise +1 next time :D | 21:28 |
lbragstad | morganfainberg: yeah, I agree.. that commit touches a lot of files. | 21:28 |
*** adjohn has joined #openstack-dev | 21:28 | |
ayoung | lbragstad, tell me notifiers should not be stand alone library: merge downs of +7351 lines... | 21:28 |
dolphm | simo: o/ | 21:28 |
*** andymccr has joined #openstack-dev | 21:28 | |
lbragstad | ayoung: that is the notifier and it's deps... | 21:29 |
lbragstad | I didn't add or remove anything. that's just the sync from Oslo | 21:29 |
*** t-8ch has joined #openstack-dev | 21:29 | |
bknudson | we must have all of oslo by now | 21:29 |
lbragstad | bknudson: pretty close | 21:29 |
ayoung | lbragstad, I am trusting that you did not put any of your own backdoors in there | 21:29 |
morganfainberg | bknudson: on the plus side, we wont be lagging behind :P | 21:29 |
lbragstad | ayoung: hah no I didn't | 21:29 |
ayoung | there, I have it in writing | 21:30 |
simo | dolphm: hi | 21:30 |
lbragstad | ayoung: just a bunch of eventlet rewrites | 21:30 |
ayoung | heh | 21:30 |
dolphm | simo: are you following #openstack-meeting? | 21:30 |
*** galstrom has joined #openstack-dev | 21:30 | |
morganfainberg | lbragstad: oh my… just looked at the oslo sync.... | 21:30 |
lbragstad | morganfainberg: hah yeah, that was my reaction too | 21:30 |
simo | dolphm: sorry no, let me join | 21:31 |
morganfainberg | ayoung: unless you have issue with it, i'll follow your lead in regards to that one. (the … 7000+ lines) | 21:31 |
ayoung | simo, probably too late, but you will get the logs from evesdrop...I'll link | 21:31 |
simo | ayoung: ok | 21:31 |
dolphm | simo: bit late... but we discussed the state of kds during oslo and keystone | 21:31 |
simo | ok | 21:31 |
dolphm | simo: check the meeting logs? | 21:31 |
ayoung | simo http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2013-08-13.log | 21:31 |
dolphm | ayoung: danke! | 21:31 |
*** cp16net has left #openstack-dev | 21:32 | |
lbragstad | ayoung: morganfainberg the majority of the change lies within https://github.com/openstack/oslo-incubator/tree/master/openstack/common/rpc and https://github.com/openstack/oslo-incubator/tree/master/openstack/common/notifier | 21:32 |
*** gyee has joined #openstack-dev | 21:33 | |
*** neelashah has quit IRC | 21:33 | |
morganfainberg | lbragstad: yeah i uhm. | 21:34 |
morganfainberg | it's a ton | 21:34 |
morganfainberg | :P | 21:34 |
*** boden has quit IRC | 21:34 | |
simo | dolphm: checked, no much discussion I can see, except questions of whther kds should be included or not | 21:35 |
*** cthulhup has joined #openstack-dev | 21:35 | |
simo | I am of course in favor | 21:35 |
* simo totally unbiased :) | 21:36 | |
*** diogogmt has joined #openstack-dev | 21:36 | |
lbragstad | morganfainberg: yeah, I know it... quite a bit of code. | 21:37 |
morganfainberg | stevemar: yeah +2'd just not clicking the approved so if dolphm wants to weigh in, etc they have a chance. like i said, tons of code, deserves a hard look. | 21:37 |
morganfainberg | dolphm or others that is. | 21:37 |
dolphm | morganfainberg: stevemar: send me a link | 21:37 |
morganfainberg | dolphm: https://review.openstack.org/#/c/29130/ | 21:38 |
dolphm | would love to | 21:38 |
stevemar | beat me to it! | 21:38 |
morganfainberg | and still waiting on jenkins too it looks like. | 21:38 |
dolphm | morganfainberg: stevemar: thanks! | 21:38 |
stevemar | morganfainberg: dolphm: i'm getting out of here for now anyway. ayoung: thx for looking at the patch today | 21:39 |
morganfainberg | stevemar: see ya later. | 21:39 |
*** dina_belova has joined #openstack-dev | 21:39 | |
*** lbragstad has quit IRC | 21:39 | |
bknudson | ayoung: sent spzala a note and he was quick to review https://review.openstack.org/#/c/40996/ | 21:40 |
ayoung | stevemar, approved. | 21:40 |
*** litong has quit IRC | 21:40 | |
ayoung | Oops. dolphm want me to hold off on that? | 21:40 |
morganfainberg | hehe | 21:41 |
ayoung | droppped the approved, not sure if that stops the gate. | 21:41 |
dolphm | ayoung: yeah, i'd like to take a pass | 21:41 |
morganfainberg | don't know what happens in that case ayoung | 21:41 |
morganfainberg | guess we'll find out right? | 21:42 |
dolphm | ayoung: i think you killed the check and verification and another check will be started | 21:42 |
ayoung | morganfainberg, it takes a while to get through anyway, so dolphm has time to review even if it continues processing. | 21:42 |
dolphm | ayoung: adding an +approve kills a running check; removing the +approve kills the verification | 21:42 |
morganfainberg | ayoung: yeah. | 21:42 |
*** armax has left #openstack-dev | 21:42 | |
morganfainberg | dolphm: oh, good to know | 21:43 |
ayoung | but it looks like it is still in the zuul queue | 21:43 |
dolphm | (i could be lying - check zuul!) | 21:43 |
*** stevemar has quit IRC | 21:43 | |
ayoung | http://status.openstack.org/zuul/ | 21:43 |
morganfainberg | zuul seems to still be chugging on it | 21:43 |
ayoung | still there. | 21:43 |
morganfainberg | quick −2 it! | 21:43 |
morganfainberg | :P | 21:43 |
ayoung | but the queue is like 45 minutes long. | 21:43 |
morganfainberg | right | 21:43 |
*** dina_belova has quit IRC | 21:44 | |
morganfainberg | a −2 would prevent merge if i understand gerrit | 21:44 |
ayoung | let me see. | 21:44 |
morganfainberg | but, don't know if it would stop the gate | 21:44 |
*** cthulhup has quit IRC | 21:44 | |
dolphm | simo: relevant bit- http://paste.openstack.org/raw/44075/ | 21:44 |
morganfainberg | i don't know how we do merging tbh, if gerrit does the merging, −2 or lack of approved should hold it. | 21:44 |
morganfainberg | if jenkins does the actual merge, no idea | 21:45 |
dolphm | morganfainberg: it's a jenkins job | 21:45 |
morganfainberg | dolphm: ah, then i don't know what the end result will be. | 21:45 |
dolphm | morganfainberg: the change is only in the check queue, not the queue to gate | 21:45 |
morganfainberg | ahh | 21:45 |
morganfainberg | good ot know | 21:45 |
ayoung | dolphm, I have a -2 on oauth for now. Tell me and I will lift it. | 21:46 |
dolphm | ayoung: go ahead and lift it | 21:46 |
dolphm | ayoung: i'm just writing an email and then i'll review it | 21:46 |
*** pmathews has quit IRC | 21:47 | |
ayoung | dolphm, done. On KDS, I think it is safe to get in to Keystone, as it will not be enabled by default. If it is not there, no one can use it. However, it is a significant imporvment over the existing RPC approach of no message security, so I would think it would not have a negative effect even if it were broken | 21:48 |
ayoung | I'd say it is low risk | 21:48 |
*** Aj0 has quit IRC | 21:49 | |
dolphm | ayoung: going to start a discussion on list about it | 21:49 |
*** dina_belova has joined #openstack-dev | 21:49 | |
*** MaxV has joined #openstack-dev | 21:50 | |
*** dina_belova has quit IRC | 21:54 | |
*** rharwood has quit IRC | 21:54 | |
*** stevemar-droid has joined #openstack-dev | 21:56 | |
*** ayoung has quit IRC | 21:57 | |
dolphm | henrynash: your biggest pagination stakeholder has spoken up on list :) (thanks gabrielhurley!) | 21:57 |
gabrielhurley | heh. for sure. | 21:58 |
gabrielhurley | I'm all for killing pagination. it blows. kill it. | 21:58 |
gabrielhurley | I just don't want to build pagination on top of an API that doesn't do a good job of it. | 21:58 |
gabrielhurley | making everything else better is a great alternative | 21:58 |
*** rnirmal has quit IRC | 21:59 | |
*** beagles has quit IRC | 22:01 | |
*** datsun180b has quit IRC | 22:03 | |
*** burt has quit IRC | 22:04 | |
*** SergeyLu_ has joined #openstack-dev | 22:04 | |
*** kbringard has quit IRC | 22:05 | |
*** SergeyLukjanov has quit IRC | 22:06 | |
*** beagles has joined #openstack-dev | 22:06 | |
*** SergeyLu_ has quit IRC | 22:09 | |
*** jecarey has quit IRC | 22:09 | |
*** sarob has quit IRC | 22:12 | |
*** aeperezt has quit IRC | 22:12 | |
*** adjohn has quit IRC | 22:12 | |
*** sarob has joined #openstack-dev | 22:12 | |
*** stevemar-droid has quit IRC | 22:14 | |
*** adjohn has joined #openstack-dev | 22:15 | |
*** jasondotstar has joined #openstack-dev | 22:16 | |
*** sarob has quit IRC | 22:17 | |
*** andymccr has quit IRC | 22:19 | |
*** t-8ch has quit IRC | 22:20 | |
*** galstrom has quit IRC | 22:21 | |
dolphm | cc: ttx russellb jd__ http://lists.openstack.org/pipermail/openstack-dev/2013-August/013592.html | 22:21 |
dolphm | because i didn't want to bump into the cc limit of openstack-dev again ;) | 22:22 |
*** mrodden has quit IRC | 22:23 | |
bknudson | "what percentage of the time do you click to the second page of results in Google" -- ayoung asked that yesterday. | 22:23 |
*** esheffield has quit IRC | 22:25 | |
*** galstrom has joined #openstack-dev | 22:25 | |
*** vkmc has joined #openstack-dev | 22:26 | |
*** briancurtin has quit IRC | 22:26 | |
*** adjohn has quit IRC | 22:26 | |
*** andymccr has joined #openstack-dev | 22:27 | |
*** jcannava has joined #openstack-dev | 22:28 | |
gabrielhurley | darn. I missed that. I thought I was being original. | 22:28 |
*** _TheDodd_ has quit IRC | 22:28 | |
*** t-8ch has joined #openstack-dev | 22:28 | |
russellb | dolphm: syn-ack | 22:29 |
*** changbl has quit IRC | 22:31 | |
*** gabrielhurley has quit IRC | 22:31 | |
*** dripton has quit IRC | 22:31 | |
*** t-8ch has quit IRC | 22:33 | |
*** MaxV has quit IRC | 22:35 | |
*** dripton has joined #openstack-dev | 22:35 | |
*** xBsd has quit IRC | 22:35 | |
*** andymccr has quit IRC | 22:36 | |
*** galstrom is now known as galstrom_zzz | 22:36 | |
*** beagles has quit IRC | 22:36 | |
*** t-8ch has joined #openstack-dev | 22:38 | |
*** sarob has joined #openstack-dev | 22:38 | |
*** andymccr has joined #openstack-dev | 22:38 | |
*** cthulhup has joined #openstack-dev | 22:41 | |
*** hartsocks has joined #openstack-dev | 22:41 | |
*** jhesketh has joined #openstack-dev | 22:41 | |
*** beagles has joined #openstack-dev | 22:42 | |
*** FunnyLookinHat has quit IRC | 22:42 | |
*** troytoman-away is now known as troytoman | 22:42 | |
*** AlanClark has quit IRC | 22:43 | |
*** morazi has quit IRC | 22:43 | |
*** spandhe has quit IRC | 22:44 | |
*** hartsocks has quit IRC | 22:45 | |
*** hartsocks has joined #openstack-dev | 22:46 | |
*** troytoman is now known as troytoman-away | 22:47 | |
*** cthulhup has quit IRC | 22:49 | |
*** sudorandom has quit IRC | 22:49 | |
*** dina_belova has joined #openstack-dev | 22:50 | |
*** jimfehlig has quit IRC | 22:53 | |
*** dina_belova has quit IRC | 22:55 | |
*** troytoman-away is now known as troytoman | 22:57 | |
*** amerine_ has quit IRC | 22:58 | |
*** wolfdreamer has quit IRC | 22:58 | |
*** devoid has quit IRC | 22:59 | |
*** carl_baldwin has quit IRC | 22:59 | |
*** amerine has joined #openstack-dev | 23:00 | |
*** anniec has joined #openstack-dev | 23:04 | |
*** vaml has joined #openstack-dev | 23:07 | |
samalba | does anyone have the answer of that: https://answers.launchpad.net/devstack/+question/233734 ? | 23:09 |
samalba | I get that on my VM (after running ./rejoin.sh on devstack) | 23:10 |
*** xBsd has joined #openstack-dev | 23:10 | |
*** _cerberu` is now known as _cerberus_ | 23:11 | |
*** sdague has quit IRC | 23:13 | |
*** bknudson has quit IRC | 23:16 | |
*** otherwiseguy has quit IRC | 23:16 | |
morganfainberg | aha, dolphm looks like removing approved means it verifies but doesn't merge (just looking att he state of the oauth stuff) | 23:16 |
*** xBsd has quit IRC | 23:16 | |
*** kbrierly has quit IRC | 23:17 | |
*** blamar has quit IRC | 23:18 | |
*** jmontemayor has quit IRC | 23:23 | |
*** jhesketh has quit IRC | 23:29 | |
*** jhesketh has joined #openstack-dev | 23:29 | |
*** vaml1 has joined #openstack-dev | 23:32 | |
*** adjohn has joined #openstack-dev | 23:37 | |
*** tjones has quit IRC | 23:39 | |
dolphm | morganfainberg: weird, good to know | 23:40 |
*** markwash has quit IRC | 23:40 | |
*** alop has quit IRC | 23:40 | |
*** alop has joined #openstack-dev | 23:41 | |
*** rcleere has quit IRC | 23:42 | |
*** adjohn has quit IRC | 23:42 | |
*** hartsocks has left #openstack-dev | 23:46 | |
*** armax has joined #openstack-dev | 23:47 | |
*** dina_belova has joined #openstack-dev | 23:50 | |
*** athomas has quit IRC | 23:50 | |
*** dina_belova has quit IRC | 23:53 | |
*** sungju has joined #openstack-dev | 23:56 | |
*** adjohn has joined #openstack-dev | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!