*** dstanek has quit IRC | 00:03 | |
*** dvarga has joined #openstack-dev | 00:07 | |
*** dstanek has joined #openstack-dev | 00:07 | |
*** hemna is now known as hemnafk | 00:08 | |
*** danwent has joined #openstack-dev | 00:08 | |
*** jasdeepH has quit IRC | 00:09 | |
*** jamiem has quit IRC | 00:10 | |
*** jecarey has quit IRC | 00:11 | |
*** xBsd has quit IRC | 00:11 | |
*** Ryan_Lane has quit IRC | 00:14 | |
*** Ryan_Lane has joined #openstack-dev | 00:14 | |
*** Ryan_Lane has quit IRC | 00:14 | |
*** jamiem has joined #openstack-dev | 00:14 | |
*** Ryan_Lane has joined #openstack-dev | 00:15 | |
*** jamiem has quit IRC | 00:17 | |
*** herndon has quit IRC | 00:20 | |
*** jasdeepH has joined #openstack-dev | 00:22 | |
*** jamiem has joined #openstack-dev | 00:24 | |
*** krtaylor has quit IRC | 00:25 | |
*** moted has quit IRC | 00:26 | |
*** moted has joined #openstack-dev | 00:26 | |
*** gmurphy has joined #openstack-dev | 00:26 | |
*** sushils has quit IRC | 00:27 | |
*** hailiang has quit IRC | 00:28 | |
*** morganfainberg is now known as morganfainberg|a | 00:30 | |
*** krtaylor has joined #openstack-dev | 00:33 | |
*** sushils has joined #openstack-dev | 00:33 | |
*** danwent has quit IRC | 00:34 | |
*** gyee has quit IRC | 00:35 | |
*** sungju has joined #openstack-dev | 00:35 | |
*** danwent has joined #openstack-dev | 00:35 | |
*** waa has joined #openstack-dev | 00:36 | |
*** markwash has quit IRC | 00:37 | |
*** hailiang has joined #openstack-dev | 00:38 | |
*** sarob has quit IRC | 00:39 | |
*** dvarga has quit IRC | 00:39 | |
*** jamiem has quit IRC | 00:41 | |
*** dvarga has joined #openstack-dev | 00:41 | |
*** rcrit has quit IRC | 00:42 | |
*** danwent has quit IRC | 00:45 | |
*** nati_ueno has quit IRC | 00:47 | |
*** sarob has joined #openstack-dev | 00:49 | |
*** Tross has joined #openstack-dev | 00:49 | |
*** rcrit has joined #openstack-dev | 00:55 | |
*** Mandell has quit IRC | 00:55 | |
*** sthaha has joined #openstack-dev | 00:57 | |
*** sthaha has quit IRC | 00:57 | |
*** sthaha has joined #openstack-dev | 00:57 | |
*** sthaha has quit IRC | 00:58 | |
*** maheshp has joined #openstack-dev | 00:58 | |
*** joe-hernandez has joined #openstack-dev | 01:02 | |
*** SumitNaiksatam has quit IRC | 01:05 | |
*** topol has joined #openstack-dev | 01:08 | |
*** shardy has quit IRC | 01:08 | |
*** joe-hernandez has left #openstack-dev | 01:09 | |
*** maheshp has quit IRC | 01:09 | |
*** jasondotstar has joined #openstack-dev | 01:10 | |
*** giulivo has quit IRC | 01:11 | |
*** sthaha has joined #openstack-dev | 01:12 | |
*** sthaha has quit IRC | 01:12 | |
*** sthaha has joined #openstack-dev | 01:12 | |
*** dstanek has quit IRC | 01:14 | |
*** dstanek has joined #openstack-dev | 01:15 | |
*** briancurtin has joined #openstack-dev | 01:18 | |
*** jasdeepH has quit IRC | 01:19 | |
*** hailiang has quit IRC | 01:20 | |
*** erkules_ has joined #openstack-dev | 01:22 | |
*** erkules has quit IRC | 01:25 | |
*** lbragstad has joined #openstack-dev | 01:26 | |
*** dvarga has quit IRC | 01:27 | |
*** galstrom_zzz is now known as galstrom | 01:31 | |
*** freedomhui has joined #openstack-dev | 01:33 | |
*** lbragstad1 has joined #openstack-dev | 01:33 | |
*** lbragstad has quit IRC | 01:34 | |
*** jaypipes has joined #openstack-dev | 01:34 | |
*** maheshp has joined #openstack-dev | 01:41 | |
bknudson | seen this running keystone tests? | 01:41 |
---|---|---|
bknudson | AssertionError: Environmental variable PATH_INFO is not a string: <type 'unicode'> (value: u'/v3 | 01:41 |
bknudson | File "/opt/stack/keystone/.venv/local/lib/python2.7/site-packages/webtest/lint.py", line 332, in check_environ | 01:41 |
jamielennox | bknudson, no, but i do remember that there was some issues with unicode and webtest. for example i think if you put headers in as unicode then it failed | 01:43 |
jamielennox | i'm not sure if that's webtest not keeping up with the times or if it is a legitimate you can't have unicode in headers | 01:44 |
*** sushils has quit IRC | 01:46 | |
*** zodiak has quit IRC | 01:46 | |
*** maheshp has quit IRC | 01:46 | |
*** nati_ueno has joined #openstack-dev | 01:46 | |
*** cdub_ has quit IRC | 01:51 | |
*** cbaesema has joined #openstack-dev | 01:51 | |
*** galstrom is now known as galstrom_zzz | 01:52 | |
*** jimjiang has quit IRC | 01:52 | |
*** cdub_ has joined #openstack-dev | 01:53 | |
*** neelashah has joined #openstack-dev | 01:54 | |
*** cdub has quit IRC | 01:57 | |
*** cdub has joined #openstack-dev | 01:59 | |
*** d34dh0r53 has joined #openstack-dev | 01:59 | |
*** gongysh has quit IRC | 01:59 | |
*** SumitNaiksatam has joined #openstack-dev | 02:01 | |
*** boden has joined #openstack-dev | 02:01 | |
*** d34dh0r53 has quit IRC | 02:02 | |
*** sthaha has quit IRC | 02:03 | |
*** anteaya has quit IRC | 02:05 | |
*** ljjjustin has joined #openstack-dev | 02:06 | |
*** jasdeepH has joined #openstack-dev | 02:06 | |
*** yaguang has joined #openstack-dev | 02:06 | |
*** dvarga has joined #openstack-dev | 02:08 | |
dstanek | jamielennox: iirc there was some discussion about that on web-sig. some headers need to be bytes based on the HTTP spec | 02:10 |
*** adalbas has joined #openstack-dev | 02:10 | |
*** sthaha has joined #openstack-dev | 02:11 | |
*** sthaha has quit IRC | 02:11 | |
*** sthaha has joined #openstack-dev | 02:11 | |
jamielennox | dstanek, it's not something i know enough about - i would think as a python testing framework webtest should just let it through but possibly if you are going through httpd or something with unicode env variables they might really want to catch that | 02:11 |
*** Ryan_Lane has quit IRC | 02:12 | |
dstanek | jamielennox: your guess is as good as mine | 02:12 |
*** morganfainberg|a is now known as morganfainberg | 02:13 | |
*** Tross has quit IRC | 02:13 | |
*** sarob has quit IRC | 02:15 | |
novas0x2a|laptop | bknudson, dstanek, jamielennox: not sure if it's the problem here, but 1) webtest also wraps any wsgi app you're testing in a wsgi validator to (theoretically) make sure it's not breaking pep 3333 and 2) yes, PATH_INFO is supposed to be bytes and not unicode (see http://www.python.org/dev/peps/pep-3333/#a-note-on-string-types) | 02:17 |
novas0x2a|laptop | but it sounds like there might be a bug somewhere because i think PATH_INFO is supposed to be represented on the app side by a native string, not a bytestring. | 02:20 |
*** zul has quit IRC | 02:20 | |
*** michchap has quit IRC | 02:20 | |
*** michchap has joined #openstack-dev | 02:21 | |
*** ljjjustin has quit IRC | 02:22 | |
*** ljjjustin has joined #openstack-dev | 02:23 | |
*** dvarga has quit IRC | 02:23 | |
novas0x2a|laptop | actually, yep, looks like webtest's check is correct. PATH_INFO should always be a str in python2 or python3. (webtest is actually less strict than it should be, looks like it would accept bytes() in python3, which isn't correct. | 02:24 |
*** d34dh0r53 has joined #openstack-dev | 02:28 | |
*** erkules_ is now known as erkules | 02:32 | |
*** d34dh0r53 has quit IRC | 02:33 | |
*** boden has quit IRC | 02:35 | |
jamielennox | novas0x2a|laptop, i'm not sure if any of this answers bknudson's question but it is good to know, thans | 02:36 |
*** prad_ has quit IRC | 02:37 | |
novas0x2a|laptop | heh, well, it means that (most likely) one of the tests is building a path string to fetch with unicode() instead of str() | 02:38 |
*** prad_ has joined #openstack-dev | 02:39 | |
*** dstanek has quit IRC | 02:39 | |
*** Tross has joined #openstack-dev | 02:40 | |
*** stevemar has joined #openstack-dev | 02:40 | |
*** prad_ has left #openstack-dev | 02:42 | |
morganfainberg | novas0x2a|laptop: oh interesting | 02:45 |
novas0x2a|laptop | i think i ran into the same problem when i wrote an adapter that mocks the requests module and feeds it to the app via wsgi instead, because requests does an encode() and my mock did not | 02:46 |
novas0x2a|laptop | er, s/via wsgi/via webtest/ | 02:46 |
*** pixelbeat has quit IRC | 02:48 | |
morganfainberg | bknudson: ping (if you're here) | 02:48 |
*** SergeyLukjanov has joined #openstack-dev | 02:50 | |
*** SumitNaiksatam has quit IRC | 02:50 | |
*** SumitNaiksatam has joined #openstack-dev | 02:51 | |
*** zaitcev has quit IRC | 02:53 | |
*** sthaha has quit IRC | 02:55 | |
*** comay has quit IRC | 02:59 | |
*** rackerjoe has left #openstack-dev | 03:00 | |
*** rackerjoe has joined #openstack-dev | 03:00 | |
*** rackerjoe has left #openstack-dev | 03:00 | |
*** neelashah has quit IRC | 03:00 | |
*** melwitt has quit IRC | 03:01 | |
*** rcleere has joined #openstack-dev | 03:01 | |
*** nati_ueno has quit IRC | 03:03 | |
*** novas0x2a|laptop has quit IRC | 03:04 | |
*** dstanek has joined #openstack-dev | 03:05 | |
*** shanewang_away is now known as shanewang | 03:05 | |
*** rwsu has quit IRC | 03:05 | |
*** sthaha has joined #openstack-dev | 03:08 | |
*** stevemar has quit IRC | 03:08 | |
*** Qu310 has joined #openstack-dev | 03:09 | |
*** vkmc has quit IRC | 03:11 | |
*** bknudson has left #openstack-dev | 03:11 | |
*** stevemar has joined #openstack-dev | 03:12 | |
*** dstanek has quit IRC | 03:14 | |
*** briancurtin has quit IRC | 03:15 | |
Qu310 | I'm trying to make a small change to horizon, I've applyed a patch "https://github.com/openstack/horizon/commit/3247e19ba86d3ee3f48a2c2769c94125871c2354" which allow users to create a volume from an Image, so i want to disable the "Instance Source" requirement for Image to be selected. I tried just adding a noop to the project/instances/workflows/create_instance.py as ('', _("Boot From | 03:16 |
Qu310 | volume.")), however the form submits with an error. I think its possibly something to do with maybe some kind of hard coded requirement for a image_source? | 03:16 |
*** Tross has quit IRC | 03:16 | |
*** morazi has joined #openstack-dev | 03:18 | |
*** comay has joined #openstack-dev | 03:18 | |
*** briancurtin has joined #openstack-dev | 03:19 | |
*** insanidade has joined #openstack-dev | 03:21 | |
*** jfriedly has quit IRC | 03:22 | |
*** martine has joined #openstack-dev | 03:22 | |
*** martine is now known as Guest13302 | 03:23 | |
*** sthaha has quit IRC | 03:24 | |
*** sthaha has joined #openstack-dev | 03:24 | |
*** sthaha has quit IRC | 03:24 | |
*** sthaha has joined #openstack-dev | 03:24 | |
*** osier has joined #openstack-dev | 03:26 | |
*** Tross has joined #openstack-dev | 03:30 | |
*** X-Scale has joined #openstack-dev | 03:32 | |
*** SergeyLukjanov has quit IRC | 03:34 | |
*** Guest13302 has quit IRC | 03:35 | |
*** zodiak has joined #openstack-dev | 03:37 | |
*** morazi has quit IRC | 03:39 | |
*** Ryan_Lane has joined #openstack-dev | 03:40 | |
*** prekarat1 has joined #openstack-dev | 03:40 | |
*** Tross has quit IRC | 03:43 | |
*** gongysh has joined #openstack-dev | 03:45 | |
*** gareth_kun has joined #openstack-dev | 03:45 | |
*** Dr_Who has joined #openstack-dev | 03:48 | |
*** jcoufal has joined #openstack-dev | 03:51 | |
*** aditirav has joined #openstack-dev | 03:52 | |
*** dina_belova has joined #openstack-dev | 03:54 | |
*** dina_belova has quit IRC | 03:56 | |
*** dina_belova has joined #openstack-dev | 03:57 | |
*** dina_belova has quit IRC | 04:01 | |
*** melwitt has joined #openstack-dev | 04:01 | |
*** terryh has quit IRC | 04:04 | |
*** HenryG has quit IRC | 04:07 | |
*** jamespage has quit IRC | 04:08 | |
*** jamespage has joined #openstack-dev | 04:09 | |
*** jamespage has joined #openstack-dev | 04:09 | |
*** gongysh has quit IRC | 04:09 | |
*** vartom7 has joined #openstack-dev | 04:13 | |
*** comay_ has joined #openstack-dev | 04:15 | |
*** comay_ has quit IRC | 04:15 | |
*** aditirav has quit IRC | 04:18 | |
*** basha has joined #openstack-dev | 04:19 | |
*** stevemar has quit IRC | 04:22 | |
*** raies has joined #openstack-dev | 04:23 | |
raies | ffieldt: will you please check https://review.openstack.org/#/c/42624/ | 04:24 |
*** vartom7 has quit IRC | 04:28 | |
*** boris-42 has joined #openstack-dev | 04:30 | |
*** arezadr has quit IRC | 04:31 | |
*** nshaikh has joined #openstack-dev | 04:31 | |
*** amotoki has joined #openstack-dev | 04:33 | |
*** arezadr has joined #openstack-dev | 04:33 | |
*** Dr_Who is now known as tgall_foo | 04:35 | |
*** arezadr has quit IRC | 04:36 | |
*** stevemar has joined #openstack-dev | 04:37 | |
*** vartom7 has joined #openstack-dev | 04:37 | |
*** arezadr has joined #openstack-dev | 04:37 | |
*** reed has quit IRC | 04:37 | |
*** sandywalsh has quit IRC | 04:37 | |
*** Tross has joined #openstack-dev | 04:40 | |
*** X-Scale has quit IRC | 04:49 | |
*** sthaha has quit IRC | 04:50 | |
*** sthaha has joined #openstack-dev | 04:50 | |
*** sthaha has quit IRC | 04:50 | |
*** sthaha has joined #openstack-dev | 04:50 | |
*** vartom7 has quit IRC | 04:51 | |
*** Mandell has joined #openstack-dev | 04:56 | |
*** aeperezt has quit IRC | 04:56 | |
*** jasdeepH has quit IRC | 04:56 | |
*** jasdeepH has joined #openstack-dev | 04:58 | |
*** prekarat has joined #openstack-dev | 04:59 | |
*** prekarat1 has quit IRC | 05:00 | |
*** CaptTofu has quit IRC | 05:03 | |
*** CaptTofu has joined #openstack-dev | 05:03 | |
*** avishay_afk is now known as avishay | 05:05 | |
*** markwash has joined #openstack-dev | 05:07 | |
*** eharney has quit IRC | 05:07 | |
*** dina_belova has joined #openstack-dev | 05:07 | |
*** sandywalsh has joined #openstack-dev | 05:07 | |
*** CaptTofu has quit IRC | 05:08 | |
*** rcleere has quit IRC | 05:11 | |
*** SergeyLukjanov has joined #openstack-dev | 05:11 | |
*** dina_belova has quit IRC | 05:12 | |
*** SergeyLukjanov has quit IRC | 05:13 | |
*** SergeyLukjanov has joined #openstack-dev | 05:16 | |
*** eglynn has joined #openstack-dev | 05:16 | |
*** radsy has quit IRC | 05:17 | |
*** [wchrisj_ has joined #openstack-dev | 05:19 | |
*** topol has quit IRC | 05:19 | |
*** SergeyLukjanov has quit IRC | 05:21 | |
*** SergeyLukjanov has joined #openstack-dev | 05:23 | |
*** martyntaylor has quit IRC | 05:29 | |
*** SkyRocknRoll has joined #openstack-dev | 05:31 | |
*** SergeyLukjanov has quit IRC | 05:32 | |
*** openfly has quit IRC | 05:33 | |
*** vartom7 has joined #openstack-dev | 05:34 | |
*** Mandell has quit IRC | 05:38 | |
*** kushal has joined #openstack-dev | 05:39 | |
*** bswartz has quit IRC | 05:40 | |
*** [wchrisj_ has quit IRC | 05:44 | |
*** SergeyLukjanov has joined #openstack-dev | 05:48 | |
*** xqueralt-afk is now known as xqueralt | 05:48 | |
*** henrynash has joined #openstack-dev | 05:49 | |
*** mrunge has joined #openstack-dev | 05:50 | |
*** SergeyLukjanov has quit IRC | 05:53 | |
*** SergeyLukjanov has joined #openstack-dev | 05:56 | |
*** Mandell has joined #openstack-dev | 06:00 | |
*** SergeyLukjanov has quit IRC | 06:02 | |
*** bswartz has joined #openstack-dev | 06:03 | |
*** corXi has joined #openstack-dev | 06:03 | |
*** tgall_foo has quit IRC | 06:12 | |
*** eharney has joined #openstack-dev | 06:13 | |
*** devvesa has joined #openstack-dev | 06:14 | |
*** briancurtin has quit IRC | 06:15 | |
*** doron_afk has joined #openstack-dev | 06:19 | |
*** devvesa has quit IRC | 06:20 | |
*** garyk has joined #openstack-dev | 06:20 | |
*** marios has joined #openstack-dev | 06:23 | |
*** bashok has joined #openstack-dev | 06:23 | |
*** eharney has quit IRC | 06:25 | |
*** MaxV has joined #openstack-dev | 06:26 | |
*** jtomasek has joined #openstack-dev | 06:31 | |
*** jcoufal has quit IRC | 06:32 | |
*** sumanthns has joined #openstack-dev | 06:32 | |
sumanthns | All, I am facing a problem while running ./run_tests.sh in nova | 06:33 |
sumanthns | getting this error "db type could not be determined | 06:34 |
sumanthns | error: testr failed (3)" | 06:34 |
*** xqueralt is now known as xqueralt-afk | 06:34 | |
sumanthns | I recreated my virtual environment, but still facing the same problem | 06:34 |
sumanthns | any help would be very much appreciated | 06:34 |
*** MaxV has quit IRC | 06:35 | |
*** amotoki has quit IRC | 06:38 | |
*** amotoki has joined #openstack-dev | 06:39 | |
*** networkstatic has quit IRC | 06:42 | |
*** amotoki_ has joined #openstack-dev | 06:42 | |
*** jpich has joined #openstack-dev | 06:43 | |
*** devvesa has joined #openstack-dev | 06:45 | |
*** Tross has quit IRC | 06:45 | |
*** amotoki has quit IRC | 06:46 | |
*** jtomasek has quit IRC | 06:47 | |
*** jtomasek has joined #openstack-dev | 06:47 | |
*** xga has joined #openstack-dev | 06:49 | |
*** romcheg1 has joined #openstack-dev | 06:49 | |
*** mrunge has quit IRC | 06:50 | |
*** jcoufal has joined #openstack-dev | 06:52 | |
*** mrunge has joined #openstack-dev | 06:54 | |
*** pcm_ has quit IRC | 06:56 | |
*** reidrac has joined #openstack-dev | 06:57 | |
*** lbragstad has joined #openstack-dev | 06:58 | |
*** romcheg1 has quit IRC | 06:58 | |
*** lbragstad1 has quit IRC | 06:59 | |
morganfainberg | jamielennox: ping | 06:59 |
*** hailiang has joined #openstack-dev | 06:59 | |
jamielennox | morganfainberg, do you sleep? | 06:59 |
morganfainberg | jamielennox: no. | 06:59 |
jamielennox | what can i do for you then? | 06:59 |
*** xga has quit IRC | 07:00 | |
morganfainberg | jamielennox: want a second brain on this one, aggressive caching (cache on create) | 07:00 |
morganfainberg | jamielennox: there is an issue with doing this on tokens. someone could request an expired token to be created. | 07:00 |
morganfainberg | jamielennox: i think that is silly… but we allow it… in fact… we have a test to validate it works (in a round-about manner) | 07:00 |
morganfainberg | jamielennox: if i do aggressive caching, i have to inspect every token for expiry on issuance | 07:01 |
jamielennox | really? i didn't know that - i thought expiry was always time + some server set window | 07:01 |
morganfainberg | jamielennox: you can request a token with expiry of <blah> | 07:01 |
jamielennox | seems like a bad idea but let that slide for now | 07:01 |
morganfainberg | jamielennox: do i refactor the test and make issue_token tell the requestor "uh. no. stop being dumb" | 07:01 |
morganfainberg | or, do i just not aggressively cache (i don't want to inspect every single token create for expiry) | 07:02 |
morganfainberg | downside is, we take an extra hit to the backend because the token isn't immidiately cached | 07:03 |
jamielennox | so i would figure out if that is a real policy or just something that's snuck in, because if i'm an admin i don't want people creating tokens with a year of expiry | 07:03 |
*** MaxV has joined #openstack-dev | 07:03 | |
morganfainberg | jamielennox: it's intended | 07:03 |
jamielennox | but what i would think is can you flag it on the way into the system | 07:03 |
morganfainberg | jamielennox: it's the issue with bearer tokens. | 07:03 |
jamielennox | i'm not sure that's any cheaper | 07:03 |
jamielennox | but just don't cache any inbound request with an expiry in the payload | 07:03 |
morganfainberg | jamielennox: it would be cheaper only insomuch as we only inspect if an expiry is passed in on the payload | 07:04 |
jamielennox | well it would simply be a if 'expiry' in dict rather than an actual time decode and compare | 07:04 |
morganfainberg | by the time we get to caching, i can't tell what the original payload was | 07:04 |
jamielennox | ah | 07:04 |
*** michchap has quit IRC | 07:05 | |
*** zodiak has quit IRC | 07:05 | |
*** tkammer has joined #openstack-dev | 07:05 | |
*** michchap has joined #openstack-dev | 07:05 | |
morganfainberg | i'm just concerned that aggressive caching will bite me down the line. | 07:05 |
morganfainberg | but this is the last hurdle for the outstanding caching reviews…(before it's just pending people marking them up) i had to punt on identity caching =/ no time to get a review up (was away from a computer almost all day) | 07:06 |
jamielennox | unfortunately with a UUID token, it's one of the main places where you actually want to do it | 07:06 |
morganfainberg | jamielennox: yes. | 07:06 |
jamielennox | i think just cache everything | 07:07 |
morganfainberg | jamielennox: like i said, i could refactor the issue token stuff to tell people to stop being dumb. | 07:07 |
morganfainberg | actually sec. | 07:07 |
jamielennox | if the token is going to exist in the database anyway the fact that you're caching something expired is not that much excess | 07:08 |
*** bashok has quit IRC | 07:08 | |
jamielennox | assuming people will move away from the expired tokens they will get flushed out | 07:08 |
jamielennox | can you set a cache length? | 07:08 |
morganfainberg | jamielennox: https://github.com/openstack/keystone/blob/master/keystone/tests/test_backend.py#L2433 | 07:08 |
morganfainberg | that is the test | 07:08 |
morganfainberg | jamielennox: i can set cache length (in the current design) at the method level | 07:09 |
jamielennox | ok, that's not letting a client specify an invalid token | 07:09 |
jamielennox | sorry expired toke | 07:09 |
jamielennox | n | 07:09 |
morganfainberg | jamielennox: right i was wrong | 07:09 |
*** wfoster_away is now known as wfoster | 07:09 | |
morganfainberg | jamielennox: but i know you can request tokens valid for <insert time>. | 07:09 |
*** MaxV has quit IRC | 07:10 | |
morganfainberg | jamielennox: in anycase. | 07:10 |
jamielennox | i would suggest cache everythin | 07:10 |
jamielennox | if the API logic has let it passed then it's going to the db anyway | 07:10 |
morganfainberg | and just make that test stop complaining? | 07:10 |
jamielennox | ah right | 07:10 |
*** basha has quit IRC | 07:10 | |
jamielennox | no, you will need to inspect the output of the cache | 07:11 |
jamielennox | that's crap | 07:11 |
morganfainberg | jamielennox: yeah the expectation of a lot of code is that the back-end will never return an expired token | 07:11 |
*** jhesketh has quit IRC | 07:11 | |
*** jhesketh has joined #openstack-dev | 07:12 | |
morganfainberg | because of caching, i've had to work around that in some cases… and provide some heavy invalidation logic in a couple cases. | 07:12 |
morganfainberg | heck. | 07:12 |
jamielennox | can you refactor the token stuff and move the expiry check outside of the retrieval | 07:12 |
jamielennox | the format should be standard there | 07:12 |
morganfainberg | jamielennox: this review was all about that issue https://review.openstack.org/#/c/43608/ | 07:12 |
*** flaper87|afk is now known as flaper87 | 07:12 | |
*** xqueralt-afk is now known as xqueralt | 07:12 | |
morganfainberg | hrm. | 07:13 |
morganfainberg | grr. inspecting every token's cache is going to be expensive. | 07:14 |
morganfainberg | well in theory, everything should check the token is expired... | 07:14 |
aloga | jog0: ping | 07:14 |
jamielennox | it won't | 07:14 |
morganfainberg | this test is kind of spurious | 07:14 |
jamielennox | i think the auth path doesn't | 07:14 |
morganfainberg | validate_X_token does now | 07:14 |
jamielennox | it relies on the token backend throwing a not auth | 07:15 |
*** amotoki_ is now known as amotoki | 07:15 | |
morganfainberg | auth uses provider.validate_token | 07:15 |
jamielennox | ah, so it's changed since i looked recently then | 07:15 |
morganfainberg | yeah like changed in the last uhmm. day? | 07:15 |
morganfainberg | it was silly that token providers would merrily validate an expired token | 07:15 |
jamielennox | i've been client side for a couple of weeks and i feel like the whole code base has changed | 07:15 |
morganfainberg | jamielennox: we've moved a TON in the last 2 weeks | 07:16 |
morganfainberg | jamielennox: it's been a challenge to keep up even spending most of my time in the code base. | 07:16 |
morganfainberg | hrm. | 07:17 |
morganfainberg | jamielennox: does auth_middleware check token expiry | 07:17 |
morganfainberg | jamielennox: i am sure it does…but… it's late here :P | 07:17 |
jamielennox | client side | 07:17 |
jamielennox | it relies on the server to tell it what's valid | 07:18 |
morganfainberg | unless it's PKI i assume? | 07:18 |
morganfainberg | or does it do a "check" on that as well? | 07:18 |
jamielennox | hmmm | 07:18 |
*** blentz has quit IRC | 07:19 | |
jamielennox | morganfainberg, yep, it validates expiry | 07:20 |
*** SkyRocknRoll has quit IRC | 07:20 | |
*** SkyRocknRoll has joined #openstack-dev | 07:20 | |
*** afazekas has joined #openstack-dev | 07:21 | |
jamielennox | for UUID and for PKI | 07:21 |
morganfainberg | jamielennox: ok this test is def. spurious then | 07:21 |
morganfainberg | jamielennox: well more like… superfluous | 07:21 |
morganfainberg | ugh. i really don't want to upload a test removal patchset… but it's good practice :P | 07:21 |
morganfainberg | test removal should not be mixed in with the main patchset. | 07:22 |
jamielennox | yea, and it's a tough one to justify because it really is changing the way it works, so you need to catch that everywhere | 07:23 |
*** Mandell has quit IRC | 07:24 | |
morganfainberg | jamielennox: yeah. | 07:24 |
morganfainberg | jamielennox: but i think most everything that actually calls get_token is smart now. | 07:25 |
*** yolanda has joined #openstack-dev | 07:25 | |
morganfainberg | jamielennox: erk. looks like there are more places =/. | 07:27 |
jamielennox | the auth path in keystone itself is tragic | 07:27 |
jamielennox | v2 is completely different to v3 and there are a lot of places that retrieve tokens from the backend | 07:27 |
jamielennox | i think i had a blueprint at one point to move all the token handling of keystone into a middleware component as well | 07:28 |
jamielennox | it never took off | 07:28 |
*** openfly has joined #openstack-dev | 07:28 | |
morganfainberg | jamielennox: well… if we are lucky v2 tokens can go bye-bye in the L release? | 07:29 |
morganfainberg | jamielennox: assuming the api is deprecated in Icehouse | 07:30 |
*** dkehn has quit IRC | 07:31 | |
*** mrunge is now known as mrunge_brb | 07:32 | |
*** gmurphy has quit IRC | 07:32 | |
*** SergeyLukjanov has joined #openstack-dev | 07:32 | |
*** shardy has joined #openstack-dev | 07:33 | |
*** SergeyLukjanov has quit IRC | 07:33 | |
*** hailiang has quit IRC | 07:33 | |
*** xga has joined #openstack-dev | 07:34 | |
morganfainberg | jamielennox: ok v2 tokens look safe to never _actually_ build an expired token. actually, it looks like you can't request a token for longer than the default expire time now (wonder when that changed) | 07:34 |
jamielennox | i'm still not certain you ever could | 07:35 |
jamielennox | that's a really bad thing to have left up to the user to determine | 07:35 |
morganfainberg | jamielennox: i'm fair certain you could. like essex or diablo | 07:35 |
jamielennox | oh, that's before my time | 07:35 |
morganfainberg | jamielennox: my company still deals with some essex stuff | 07:35 |
*** gongysh has joined #openstack-dev | 07:35 | |
*** SergeyLukjanov has joined #openstack-dev | 07:36 | |
morganfainberg | jamielennox: so, sometimes i cross wires about versions | 07:36 |
*** ndipanov_gone is now known as ndipanov | 07:37 | |
*** MaxV has joined #openstack-dev | 07:37 | |
*** MaxV has joined #openstack-dev | 07:37 | |
jamielennox | morganfainberg, https://review.openstack.org/#/c/44014/ | 07:39 |
jamielennox | +870, -2041 | 07:39 |
morganfainberg | jamielennox: w00t! | 07:39 |
morganfainberg | jamielennox: i promise to look at it tomorrow? want to get token stuffs done. | 07:39 |
morganfainberg | then sleep | 07:39 |
jamielennox | that's fine | 07:39 |
*** JordanP has joined #openstack-dev | 07:40 | |
jamielennox | i'm just happy to get it out, i imagine it'll be a hard review | 07:40 |
morganfainberg | s/sleep/something that i swear isn't really sleep/ | 07:40 |
*** kushal has quit IRC | 07:40 | |
*** gongysh has quit IRC | 07:40 | |
jamielennox | morganfainberg, no need to brag about your love life | 07:40 |
morganfainberg | jamielennox: i did the last review on it. it wasn't bad… just long. | 07:40 |
*** gongysh has joined #openstack-dev | 07:41 | |
morganfainberg | jamielennox: *sigh* i wish i could claim that. i'll take a 2 doses of insomnia (or more like works better as a night owl) and see a doctor in the morning | 07:41 |
morganfainberg | :P | 07:42 |
jamielennox | morganfainberg, alright i'm out, going for a run or something before it get's too dark | 07:42 |
*** jgallard has joined #openstack-dev | 07:42 | |
morganfainberg | jamielennox: have a good one. | 07:42 |
jamielennox | that's two working days you've got through :) | 07:42 |
morganfainberg | LOL | 07:42 |
*** michchap has quit IRC | 07:43 | |
*** doron_afk is now known as doron | 07:43 | |
*** mrunge_brb is now known as mrunge | 07:45 | |
*** jaimegil has joined #openstack-dev | 07:45 | |
*** henrynash has quit IRC | 07:47 | |
*** fbo_away is now known as fbo | 07:48 | |
*** gongysh has quit IRC | 07:48 | |
*** romcheg has joined #openstack-dev | 07:48 | |
*** xga_ has joined #openstack-dev | 07:51 | |
*** SergeyLukjanov has quit IRC | 07:51 | |
*** jistr has joined #openstack-dev | 07:52 | |
*** giulivo has joined #openstack-dev | 07:53 | |
*** jcoufal has quit IRC | 07:54 | |
*** jcoufal_ has joined #openstack-dev | 07:54 | |
*** xga has quit IRC | 07:55 | |
*** MaxV has quit IRC | 07:55 | |
*** eglynn has quit IRC | 07:55 | |
*** MaxV has joined #openstack-dev | 07:56 | |
*** SergeyLukjanov has joined #openstack-dev | 07:58 | |
*** romcheg has quit IRC | 07:58 | |
*** sandeepr_ltp has quit IRC | 07:58 | |
*** yassine has joined #openstack-dev | 07:59 | |
*** SergeyLukjanov has quit IRC | 07:59 | |
*** sandeepr_ltp has joined #openstack-dev | 07:59 | |
*** corXi has quit IRC | 07:59 | |
*** doron is now known as doron_afk | 07:59 | |
*** tkammer has quit IRC | 08:01 | |
*** gongysh has joined #openstack-dev | 08:02 | |
*** boden has joined #openstack-dev | 08:03 | |
*** michchap has joined #openstack-dev | 08:04 | |
*** xga has joined #openstack-dev | 08:06 | |
*** xga_ has quit IRC | 08:07 | |
*** derekh has joined #openstack-dev | 08:10 | |
*** safchain has joined #openstack-dev | 08:12 | |
*** SkyRocknRoll has quit IRC | 08:14 | |
*** vsergeyev has joined #openstack-dev | 08:16 | |
*** freedomhui has quit IRC | 08:18 | |
*** gongysh has quit IRC | 08:23 | |
*** eglynn has joined #openstack-dev | 08:25 | |
*** SergeyLukjanov has joined #openstack-dev | 08:27 | |
*** lucasagomes has joined #openstack-dev | 08:28 | |
*** henrynash has joined #openstack-dev | 08:32 | |
bauzas | morning all | 08:36 |
bauzas | I spotted an error when deploying devstack with baremetal and neutron | 08:36 |
bauzas | when using both, we need to set OVS_PHYSICAL_BRIDGE | 08:36 |
bauzas | as the default value is null, it will loose eth0 connectivity if not set | 08:37 |
bauzas | commit 37a8d157a11abe55736707fdec2fc8a273027a2f | 08:37 |
bauzas | Author: Devananda van der Veen <devananda.vdv@gmail.com> | 08:37 |
bauzas | Date: Tue Jan 15 17:27:34 2013 -0800 | 08:37 |
bauzas | is devenanda there ? | 08:38 |
bauzas | ^devananda | 08:38 |
uvirtbot | bauzas: Error: "devananda" is not a valid command. | 08:38 |
JordanP | ^lol | 08:38 |
uvirtbot | JordanP: Error: "lol" is not a valid command. | 08:38 |
*** garyk has quit IRC | 08:41 | |
*** garyk has joined #openstack-dev | 08:41 | |
*** athomas has joined #openstack-dev | 08:41 | |
*** romcheg has joined #openstack-dev | 08:42 | |
*** basha has joined #openstack-dev | 08:44 | |
*** melwitt has quit IRC | 08:46 | |
*** basha has quit IRC | 08:46 | |
*** prekarat has quit IRC | 08:48 | |
*** reidrac has left #openstack-dev | 08:49 | |
*** jbresnah has quit IRC | 08:50 | |
*** sumansn_ has joined #openstack-dev | 08:51 | |
morganfainberg | henrynash: ping | 08:52 |
*** reidrac has joined #openstack-dev | 08:53 | |
henrynash | morganfainberg: hi | 08:53 |
morganfainberg | henrynash: you might want to toss DocImpact on your filtering patchset as well. | 08:53 |
*** freedomhui has joined #openstack-dev | 08:53 | |
morganfainberg | henrynash: i was about to log out and head to bed, but did one last pass on reviews ;) | 08:54 |
*** sumanthns has quit IRC | 08:54 | |
morganfainberg | henrynash: i don't think it'd be an issue w/o it, but you know… someone might say something | 08:54 |
henrynash | morganfainberg: although is there any doc impact? Ahh, maybe for the limit? | 08:54 |
morganfainberg | henrynash: yep. | 08:54 |
*** SergeyLukjanov has quit IRC | 08:54 | |
henrynash | morganfainberg: good point | 08:54 |
henrynash | morganfainberg: thx | 08:54 |
morganfainberg | henrynash: of course! trying to save ya more patchsets when people comment about that stuff ;) | 08:55 |
henrynash | morganfainberg: :-) | 08:55 |
*** martyntaylor has joined #openstack-dev | 08:56 | |
*** arezmerita has quit IRC | 08:56 | |
*** pcm_ has joined #openstack-dev | 08:57 | |
*** donaldh has joined #openstack-dev | 08:57 | |
*** ruhe has joined #openstack-dev | 09:00 | |
*** pcm_ has quit IRC | 09:01 | |
*** johnthetubaguy has joined #openstack-dev | 09:02 | |
*** stevemar has quit IRC | 09:02 | |
morganfainberg | henrynash: how often do we merge transifex stuff? ours is only up to… uhm… 43k lines changeset now :P | 09:03 |
henrynash | morganfainberg: i don't actually know how/what triggers that... | 09:03 |
*** alexpilotti has joined #openstack-dev | 09:03 | |
morganfainberg | henrynash: anyways.. g'night and if you get a chance, https://review.openstack.org/#/c/43195/, https://review.openstack.org/#/c/44211/1, https://review.openstack.org/#/c/43609/ (though if you're busy, not a worry, I'm sure i'll have some people in the morning looking at it) | 09:04 |
henrynash | morganfainverg: will do | 09:04 |
morganfainberg | henrynash: looks like i'm going to have to punt on identity caching. was out all day today =/ didn't get a chance to write much code until it was almost midnight pacific time | 09:04 |
*** dstanek has joined #openstack-dev | 09:05 | |
*** sushils has joined #openstack-dev | 09:05 | |
*** corXi has joined #openstack-dev | 09:05 | |
henrynash | morganfainberg: not necessarily, I think the freeze is only a proposal freeze…(i.e. from today nother newly proposed will get in), but the actual code freeze is sept 4th | 09:05 |
morganfainberg | henrynash: my understanding is that all code for proposals had to be up for review. iteration (bugs etc) was fine. | 09:06 |
morganfainberg | henrynash: but it had to have reviews up. i'll clarify tomorrow. | 09:07 |
*** dachary has quit IRC | 09:07 | |
henrynash | morganfainberg: that's true…so if there are features missing, then yes, those features can't be added | 09:07 |
*** basha has joined #openstack-dev | 09:07 | |
morganfainberg | henrynash: yep. aka caching identity ;) | 09:07 |
henrynash | morganfainberg: probably, yes :-( | 09:07 |
*** dachary has joined #openstack-dev | 09:07 | |
morganfainberg | henrynash: but i got assignment! and token_revocation! and likely tokens. | 09:08 |
morganfainberg | well, hopefully assignment caching goes in. | 09:08 |
morganfainberg | anyways.. g'night! | 09:08 |
henrynash | morganfainberg: which is a major step forward | 09:08 |
henrynash | morganfianberg: indeed, goodnight | 09:08 |
*** danpb has joined #openstack-dev | 09:09 | |
*** danpb has left #openstack-dev | 09:09 | |
*** rods1 has joined #openstack-dev | 09:11 | |
psedlak | can anyone familiar with keystoneclient middleware please look at http://logs.openstack.org/23/43723/4/gate/gate-tempest-devstack-vm-full/3fefc90/logs/screen-c-api.txt.gz#_2013-08-28_06_24_24_814 ... what is the 'wrong' part there ... failing openssl cms verify - unable to get issuer ... or the probable retry - unable to find auth token in headers? | 09:14 |
*** mmagr has joined #openstack-dev | 09:15 | |
*** bashok has joined #openstack-dev | 09:15 | |
*** arezmerita has joined #openstack-dev | 09:16 | |
*** morganfainberg is now known as morganfainberg|a | 09:17 | |
*** prekarat has joined #openstack-dev | 09:18 | |
*** henrynash has quit IRC | 09:18 | |
*** doron_afk is now known as doron | 09:19 | |
*** freedomhu has joined #openstack-dev | 09:19 | |
*** freedomhui has quit IRC | 09:23 | |
*** henrynash has joined #openstack-dev | 09:26 | |
*** romcheg has quit IRC | 09:26 | |
*** yongli has quit IRC | 09:32 | |
*** henrynash has quit IRC | 09:32 | |
*** doron is now known as doron_afk | 09:33 | |
*** pixelbeat has joined #openstack-dev | 09:33 | |
*** pcm_ has joined #openstack-dev | 09:34 | |
*** apevec has joined #openstack-dev | 09:37 | |
*** apevec has joined #openstack-dev | 09:37 | |
*** tkammer has joined #openstack-dev | 09:37 | |
*** apevec has left #openstack-dev | 09:37 | |
*** doron_afk is now known as doron | 09:39 | |
*** ljjjustin has quit IRC | 09:41 | |
sgran | any neutron devs around? | 09:41 |
*** romcheg has joined #openstack-dev | 09:42 | |
sgran | I'm chasing what seems to be a bug in the OVS agent, but I wanted to ask some questions about the test suite | 09:42 |
*** romcheg has quit IRC | 09:42 | |
*** prekarat has quit IRC | 09:43 | |
*** doron is now known as doron_afk | 09:44 | |
*** romcheg has joined #openstack-dev | 09:47 | |
*** markmc has joined #openstack-dev | 09:47 | |
*** doron_afk is now known as doron | 09:47 | |
*** romcheg has quit IRC | 09:49 | |
*** romcheg has joined #openstack-dev | 09:49 | |
sgran | or is there a better channel to find neutron devs? | 09:50 |
*** dstanek has quit IRC | 09:51 | |
*** romcheg1 has joined #openstack-dev | 09:53 | |
*** romcheg has quit IRC | 09:56 | |
*** senk has quit IRC | 09:57 | |
ndipanov | #openstack-neutron | 09:57 |
ndipanov | sgran, ^ maybe? | 09:58 |
*** romcheg1 has quit IRC | 10:00 | |
sgran | brilliant, thanks | 10:01 |
*** vartom7 has quit IRC | 10:03 | |
*** romcheg has joined #openstack-dev | 10:04 | |
*** prekarat has joined #openstack-dev | 10:04 | |
*** SlickNik has quit IRC | 10:07 | |
*** romcheg has quit IRC | 10:09 | |
*** romcheg has joined #openstack-dev | 10:10 | |
*** romcheg has quit IRC | 10:12 | |
*** basha has quit IRC | 10:12 | |
*** senk has joined #openstack-dev | 10:13 | |
*** dkehn has joined #openstack-dev | 10:13 | |
*** martyntaylor has quit IRC | 10:13 | |
*** xga has quit IRC | 10:13 | |
*** xga has joined #openstack-dev | 10:14 | |
*** yassine has quit IRC | 10:14 | |
*** yassine_ has joined #openstack-dev | 10:14 | |
*** SlickNik has joined #openstack-dev | 10:15 | |
*** xga_ has joined #openstack-dev | 10:17 | |
*** ruhe has quit IRC | 10:18 | |
*** tkammer has quit IRC | 10:18 | |
*** vartom7 has joined #openstack-dev | 10:20 | |
*** xga has quit IRC | 10:20 | |
*** romcheg has joined #openstack-dev | 10:22 | |
*** aditirav has joined #openstack-dev | 10:24 | |
*** doron is now known as doron_afk | 10:27 | |
*** fifieldt has quit IRC | 10:29 | |
*** ema has joined #openstack-dev | 10:30 | |
*** ema has joined #openstack-dev | 10:30 | |
*** pcm_ has quit IRC | 10:31 | |
*** gareth_kun has left #openstack-dev | 10:32 | |
*** doron_afk has quit IRC | 10:32 | |
*** garyk has quit IRC | 10:33 | |
*** prekarat has quit IRC | 10:39 | |
*** morazi has joined #openstack-dev | 10:42 | |
*** martyntaylor has joined #openstack-dev | 10:44 | |
*** basha has joined #openstack-dev | 10:45 | |
*** romcheg has quit IRC | 10:46 | |
*** ydacheville_ has quit IRC | 10:47 | |
*** ydacheville has joined #openstack-dev | 10:47 | |
*** wfoster is now known as wfoster_away | 10:53 | |
*** sandeepr_ltp has quit IRC | 10:53 | |
*** sandeepr_ltp has joined #openstack-dev | 10:53 | |
*** ruhe has joined #openstack-dev | 10:53 | |
*** sandeepr_ltp has quit IRC | 10:58 | |
*** yaguang has quit IRC | 10:59 | |
*** sandeepr_ltp has joined #openstack-dev | 10:59 | |
*** dprince has joined #openstack-dev | 11:01 | |
*** ruhe has quit IRC | 11:01 | |
*** ruhe has joined #openstack-dev | 11:02 | |
*** romcheg has joined #openstack-dev | 11:03 | |
*** romcheg has left #openstack-dev | 11:04 | |
*** clairence has joined #openstack-dev | 11:04 | |
*** henrynash has joined #openstack-dev | 11:04 | |
*** ruhe has quit IRC | 11:10 | |
*** avishay has quit IRC | 11:10 | |
*** ruhe has joined #openstack-dev | 11:10 | |
*** SkyRocknRoll has joined #openstack-dev | 11:11 | |
raies | hi everybody :) is there someone from neutron team ? | 11:11 |
*** SkyRocknRoll has quit IRC | 11:11 | |
*** SkyRocknRoll has joined #openstack-dev | 11:11 | |
*** clairence has quit IRC | 11:13 | |
*** matiu has quit IRC | 11:15 | |
*** aditirav has quit IRC | 11:16 | |
*** aditirav has joined #openstack-dev | 11:16 | |
*** dstanek has joined #openstack-dev | 11:18 | |
*** ccorrigan has quit IRC | 11:19 | |
*** jasondotstar has quit IRC | 11:20 | |
*** wfoster_away is now known as wfoster | 11:21 | |
*** dstanek has quit IRC | 11:23 | |
*** egallen has joined #openstack-dev | 11:23 | |
*** dstufft has quit IRC | 11:27 | |
*** dstufft has joined #openstack-dev | 11:28 | |
*** dstufft has quit IRC | 11:30 | |
*** dstufft has joined #openstack-dev | 11:31 | |
*** xga_ has quit IRC | 11:33 | |
henrynash | bdpayne: ping | 11:35 |
*** xga has joined #openstack-dev | 11:36 | |
*** yolanda has quit IRC | 11:36 | |
*** AndreyGrebenniko has joined #openstack-dev | 11:37 | |
AndreyGrebenniko | Hi there people, may anyone help me to switch domains support in keystone? I've already read a ton of info, but I didn't actually found how to operate with it | 11:37 |
*** yolanda has joined #openstack-dev | 11:38 | |
*** tmclaugh[work] has joined #openstack-dev | 11:39 | |
*** Guest83706 has joined #openstack-dev | 11:41 | |
*** dprince has quit IRC | 11:42 | |
*** FunnyLookinHat has joined #openstack-dev | 11:44 | |
*** ema_ has joined #openstack-dev | 11:44 | |
*** ema_ has joined #openstack-dev | 11:44 | |
*** pcm_ has joined #openstack-dev | 11:44 | |
*** martine has joined #openstack-dev | 11:45 | |
*** martine is now known as Guest39451 | 11:45 | |
*** Guest39451 is now known as martine_ | 11:45 | |
*** HenryG has joined #openstack-dev | 11:46 | |
*** ema has quit IRC | 11:47 | |
*** lucasagomes is now known as lucas-hungry | 11:47 | |
*** prad_ has joined #openstack-dev | 11:47 | |
*** johnthetubaguy has quit IRC | 11:48 | |
*** johnthetubaguy has joined #openstack-dev | 11:48 | |
*** martyntaylor has quit IRC | 11:49 | |
*** johnthetubaguy1 has joined #openstack-dev | 11:50 | |
*** johnthetubaguy has quit IRC | 11:51 | |
*** maheshp has joined #openstack-dev | 11:51 | |
*** sthaha has quit IRC | 11:56 | |
*** sthaha has joined #openstack-dev | 11:57 | |
*** sthaha has quit IRC | 11:57 | |
*** sthaha has joined #openstack-dev | 11:57 | |
*** michchap has quit IRC | 11:58 | |
*** jamielennox has quit IRC | 11:59 | |
*** michchap has joined #openstack-dev | 11:59 | |
*** jamielennox|away has joined #openstack-dev | 11:59 | |
*** maheshp has quit IRC | 11:59 | |
*** rfolco has joined #openstack-dev | 12:00 | |
*** martyntaylor has joined #openstack-dev | 12:02 | |
*** xga has quit IRC | 12:02 | |
*** dolphm has joined #openstack-dev | 12:03 | |
*** romcheg has joined #openstack-dev | 12:04 | |
*** xga has joined #openstack-dev | 12:07 | |
*** Tross has joined #openstack-dev | 12:07 | |
*** dstufft has quit IRC | 12:08 | |
*** lucas-hungry is now known as lucasagomes | 12:10 | |
*** dvarga has joined #openstack-dev | 12:14 | |
*** SergeyLukjanov has joined #openstack-dev | 12:15 | |
*** dstufft has joined #openstack-dev | 12:16 | |
*** Murali_Balcha has joined #openstack-dev | 12:17 | |
*** SergeyLukjanov has quit IRC | 12:20 | |
*** CaptTofu has joined #openstack-dev | 12:20 | |
*** osier has quit IRC | 12:21 | |
*** jamiem has joined #openstack-dev | 12:21 | |
*** johnthetubaguy1 is now known as johnthetubaguy | 12:21 | |
*** dkranz has quit IRC | 12:21 | |
*** osier has joined #openstack-dev | 12:21 | |
*** ruhe has quit IRC | 12:22 | |
*** dstufft has quit IRC | 12:25 | |
*** dstufft has joined #openstack-dev | 12:26 | |
*** dims has joined #openstack-dev | 12:26 | |
*** jaimegil has quit IRC | 12:26 | |
*** henrynash has quit IRC | 12:27 | |
*** Ruetobas has joined #openstack-dev | 12:29 | |
*** pixelbeat has quit IRC | 12:29 | |
*** jergerber has joined #openstack-dev | 12:30 | |
*** nshaikh has left #openstack-dev | 12:33 | |
*** dstanek_ has joined #openstack-dev | 12:41 | |
*** Ruetobas has quit IRC | 12:42 | |
*** romcheg has left #openstack-dev | 12:42 | |
*** aloga has quit IRC | 12:44 | |
*** terryh has joined #openstack-dev | 12:44 | |
*** sandywalsh has quit IRC | 12:46 | |
*** pixelbeat has joined #openstack-dev | 12:48 | |
*** Ruetobas has joined #openstack-dev | 12:49 | |
*** basha has quit IRC | 12:50 | |
*** Dr_Who has joined #openstack-dev | 12:50 | |
*** basha has joined #openstack-dev | 12:50 | |
*** sandeepr_ltp has quit IRC | 12:50 | |
*** shanewang is now known as shanewang_away | 12:51 | |
*** anteaya has joined #openstack-dev | 12:51 | |
*** dstanek_ has quit IRC | 12:51 | |
*** sandeepr_ltp has joined #openstack-dev | 12:51 | |
*** jasondotstar has joined #openstack-dev | 12:52 | |
*** basha has quit IRC | 12:53 | |
*** romcheg has joined #openstack-dev | 12:54 | |
*** dstanek has joined #openstack-dev | 12:54 | |
*** SkyRocknRoll has quit IRC | 12:56 | |
*** kbringard has joined #openstack-dev | 12:56 | |
*** afazekas has quit IRC | 12:57 | |
*** blentz has joined #openstack-dev | 12:57 | |
*** markmc has quit IRC | 12:59 | |
*** radez_g0n3 is now known as radez | 13:00 | |
*** blentz_ has joined #openstack-dev | 13:00 | |
*** sandywalsh has joined #openstack-dev | 13:01 | |
*** blentz_ has quit IRC | 13:01 | |
*** Dr_Who is now known as tgall_foo | 13:01 | |
*** blentz has quit IRC | 13:02 | |
*** blentz has joined #openstack-dev | 13:02 | |
*** sthaha has quit IRC | 13:03 | |
*** jayg|g0n3 is now known as jayg | 13:07 | |
*** basha has joined #openstack-dev | 13:08 | |
*** ruhe has joined #openstack-dev | 13:08 | |
*** hartsocks has joined #openstack-dev | 13:09 | |
*** hartsocks has left #openstack-dev | 13:10 | |
*** jimfehlig has joined #openstack-dev | 13:11 | |
*** osier has quit IRC | 13:13 | |
*** alunduil has quit IRC | 13:15 | |
*** maheshp has joined #openstack-dev | 13:15 | |
*** rcrit has quit IRC | 13:16 | |
*** leif has joined #openstack-dev | 13:16 | |
*** leif is now known as Guest76118 | 13:17 | |
*** stevemar has joined #openstack-dev | 13:18 | |
*** eharney has joined #openstack-dev | 13:20 | |
*** gordc has joined #openstack-dev | 13:21 | |
*** aditirav has quit IRC | 13:22 | |
*** ruhe has quit IRC | 13:25 | |
*** [wchrisj_ has joined #openstack-dev | 13:25 | |
*** jruzicka has joined #openstack-dev | 13:26 | |
*** ruhe has joined #openstack-dev | 13:27 | |
*** vartom7 has quit IRC | 13:28 | |
*** tgall_foo has quit IRC | 13:30 | |
*** rcrit has joined #openstack-dev | 13:31 | |
*** afazekas has joined #openstack-dev | 13:33 | |
*** ruhe_ has joined #openstack-dev | 13:34 | |
*** xga_ has joined #openstack-dev | 13:34 | |
*** sandeepr_ltp has quit IRC | 13:35 | |
*** xga has quit IRC | 13:35 | |
*** ruhe has quit IRC | 13:35 | |
*** osier has joined #openstack-dev | 13:35 | |
*** alunduil has joined #openstack-dev | 13:35 | |
*** FunnyLookinHat has quit IRC | 13:36 | |
*** basha has quit IRC | 13:37 | |
*** marun has joined #openstack-dev | 13:37 | |
*** dkehn_ has joined #openstack-dev | 13:38 | |
*** dkehn has quit IRC | 13:40 | |
*** xga_ has quit IRC | 13:42 | |
*** xga has joined #openstack-dev | 13:43 | |
*** changbl has quit IRC | 13:43 | |
*** dkehn_ is now known as dkehn | 13:44 | |
*** bswartz has quit IRC | 13:44 | |
*** neelashah has joined #openstack-dev | 13:48 | |
*** herndon has joined #openstack-dev | 13:49 | |
*** jdennis1 has quit IRC | 13:49 | |
*** lbragstad has quit IRC | 13:52 | |
*** herndon has quit IRC | 13:52 | |
*** jcoufal_ has quit IRC | 13:53 | |
*** sumansn_ has quit IRC | 13:54 | |
*** davidlanouette1 has joined #openstack-dev | 13:56 | |
*** dkranz has joined #openstack-dev | 13:58 | |
*** topol has joined #openstack-dev | 13:59 | |
*** egallen has quit IRC | 14:00 | |
*** henrynash has joined #openstack-dev | 14:00 | |
*** jprovazn has joined #openstack-dev | 14:01 | |
*** codenamekt has joined #openstack-dev | 14:02 | |
*** prad has quit IRC | 14:02 | |
*** stevemar has quit IRC | 14:04 | |
*** egallen has joined #openstack-dev | 14:05 | |
*** radez is now known as radez_g0n3 | 14:07 | |
*** spzala has joined #openstack-dev | 14:07 | |
*** jecarey has joined #openstack-dev | 14:08 | |
*** davidlanouette1 has left #openstack-dev | 14:09 | |
*** bswartz has joined #openstack-dev | 14:10 | |
*** rwsu has joined #openstack-dev | 14:10 | |
*** alexpilotti has quit IRC | 14:10 | |
*** davidlanouette1 has joined #openstack-dev | 14:13 | |
*** esheffield has joined #openstack-dev | 14:14 | |
*** aeperezt has joined #openstack-dev | 14:14 | |
*** michchap has quit IRC | 14:16 | |
*** tgall_foo has joined #openstack-dev | 14:18 | |
*** tgall_foo has quit IRC | 14:18 | |
*** tgall_foo has joined #openstack-dev | 14:18 | |
*** henrynash has quit IRC | 14:18 | |
*** janisg has quit IRC | 14:19 | |
*** alexpilotti has joined #openstack-dev | 14:20 | |
*** networkstatic has joined #openstack-dev | 14:22 | |
*** adalbas has quit IRC | 14:23 | |
*** eharney has quit IRC | 14:24 | |
*** basha has joined #openstack-dev | 14:24 | |
*** alexpilotti has quit IRC | 14:25 | |
*** basha has quit IRC | 14:25 | |
*** herndon has joined #openstack-dev | 14:26 | |
*** athomas has quit IRC | 14:26 | |
*** eharney has joined #openstack-dev | 14:27 | |
*** tserong_ has joined #openstack-dev | 14:27 | |
*** tserong has quit IRC | 14:29 | |
*** mlavalle has joined #openstack-dev | 14:29 | |
*** herndon has quit IRC | 14:29 | |
*** dhellmann_ is now known as dhellmann | 14:29 | |
*** briancurtin has joined #openstack-dev | 14:30 | |
*** janisg has joined #openstack-dev | 14:30 | |
*** athomas has joined #openstack-dev | 14:31 | |
*** rnirmal has joined #openstack-dev | 14:32 | |
*** alexb_ has joined #openstack-dev | 14:32 | |
*** jprovazn has quit IRC | 14:34 | |
*** yaguang has joined #openstack-dev | 14:34 | |
*** souvik has joined #openstack-dev | 14:35 | |
*** alexb_ has quit IRC | 14:35 | |
*** dkehn_ has joined #openstack-dev | 14:36 | |
*** jdennis1 has joined #openstack-dev | 14:38 | |
*** kbrierly has joined #openstack-dev | 14:38 | |
*** dkehn has quit IRC | 14:38 | |
*** stevemar has joined #openstack-dev | 14:39 | |
*** stevemar has quit IRC | 14:39 | |
*** ruhe_ has quit IRC | 14:39 | |
*** jdennis1 has quit IRC | 14:39 | |
*** ruhe has joined #openstack-dev | 14:40 | |
*** alexb_ has joined #openstack-dev | 14:42 | |
*** jvrbanac has joined #openstack-dev | 14:42 | |
*** carl_baldwin has joined #openstack-dev | 14:43 | |
*** dstanek has quit IRC | 14:43 | |
*** davidlanouette1 has quit IRC | 14:43 | |
*** adalbas has joined #openstack-dev | 14:44 | |
*** alexb_ has quit IRC | 14:44 | |
*** dkehn_ is now known as dkehn | 14:44 | |
*** michchap has joined #openstack-dev | 14:47 | |
*** changbl has joined #openstack-dev | 14:47 | |
*** matiu has joined #openstack-dev | 14:47 | |
*** matiu has quit IRC | 14:47 | |
*** matiu has joined #openstack-dev | 14:47 | |
*** jprovazn has joined #openstack-dev | 14:49 | |
*** rcleere has joined #openstack-dev | 14:49 | |
*** alexb_ has joined #openstack-dev | 14:49 | |
*** davidlanouette1 has joined #openstack-dev | 14:50 | |
*** datsun180b has joined #openstack-dev | 14:50 | |
*** carl_baldwin has quit IRC | 14:52 | |
*** carl_baldwin has joined #openstack-dev | 14:53 | |
*** pmathews has joined #openstack-dev | 14:55 | |
*** shakayumi has joined #openstack-dev | 14:55 | |
*** michchap_ has joined #openstack-dev | 14:55 | |
*** litong has joined #openstack-dev | 14:55 | |
*** michchap has quit IRC | 14:55 | |
*** yaguang has quit IRC | 14:56 | |
*** michchap has joined #openstack-dev | 14:56 | |
*** edmund has joined #openstack-dev | 14:58 | |
*** michcha__ has joined #openstack-dev | 14:59 | |
*** michchap_ has quit IRC | 14:59 | |
*** davidlanouette1 has left #openstack-dev | 15:01 | |
*** henrynash has joined #openstack-dev | 15:01 | |
*** michchap has quit IRC | 15:01 | |
*** souvik has quit IRC | 15:01 | |
*** michchap has joined #openstack-dev | 15:01 | |
*** rupakg has joined #openstack-dev | 15:02 | |
*** Murali_Balcha has quit IRC | 15:03 | |
*** michchap_ has joined #openstack-dev | 15:03 | |
*** reidrac has quit IRC | 15:03 | |
*** michcha__ has quit IRC | 15:03 | |
*** dstanek has joined #openstack-dev | 15:03 | |
*** jcoufal has joined #openstack-dev | 15:04 | |
*** stevemar has joined #openstack-dev | 15:05 | |
*** xmltok has quit IRC | 15:05 | |
dolphm | dstanek: git ready https://gist.github.com/dolph/6369538 | 15:05 |
*** marios has quit IRC | 15:05 | |
*** michchap has quit IRC | 15:06 | |
dstanek | dolphm: thanks | 15:06 |
*** michchap_ has quit IRC | 15:08 | |
*** pschaef has joined #openstack-dev | 15:08 | |
*** hemna has joined #openstack-dev | 15:10 | |
*** iartarisi has joined #openstack-dev | 15:10 | |
*** jmontemayor has joined #openstack-dev | 15:13 | |
*** Mandell has joined #openstack-dev | 15:13 | |
*** Murali_Balcha has joined #openstack-dev | 15:15 | |
*** egallen has quit IRC | 15:15 | |
*** alexb_ has quit IRC | 15:18 | |
*** amscanne has quit IRC | 15:18 | |
*** egallen has joined #openstack-dev | 15:19 | |
*** galstrom_zzz is now known as galstrom | 15:19 | |
*** amscanne has joined #openstack-dev | 15:19 | |
*** radez_g0n3 is now known as radez | 15:21 | |
*** basha has joined #openstack-dev | 15:24 | |
*** amscanne has quit IRC | 15:25 | |
*** jprovazn has quit IRC | 15:26 | |
*** gyee has joined #openstack-dev | 15:27 | |
*** MaxV has quit IRC | 15:27 | |
*** derekh has quit IRC | 15:29 | |
*** ifarkas has quit IRC | 15:30 | |
*** jpich has quit IRC | 15:30 | |
*** bashok has quit IRC | 15:32 | |
*** markwash has quit IRC | 15:33 | |
*** alexpilotti has joined #openstack-dev | 15:34 | |
*** networkstatic has quit IRC | 15:40 | |
*** celor has joined #openstack-dev | 15:42 | |
celor | hi! | 15:43 |
*** souvik has joined #openstack-dev | 15:43 | |
celor | I have seen that Oauth1.0 will be in Havanna, Does anybody knows why they have implement the v1.0 and in instance of the v2.0? | 15:43 |
*** souvik1 has joined #openstack-dev | 15:43 | |
*** freedomhu has quit IRC | 15:45 | |
*** jfriedly has joined #openstack-dev | 15:47 | |
*** souvik has quit IRC | 15:47 | |
*** wfoster is now known as wfoster_away | 15:48 | |
*** maheshp has quit IRC | 15:49 | |
*** zodiak has joined #openstack-dev | 15:49 | |
*** alop has joined #openstack-dev | 15:49 | |
*** souvik1 has left #openstack-dev | 15:50 | |
*** tgall_foo has quit IRC | 15:53 | |
*** MaxV has joined #openstack-dev | 15:54 | |
*** bugsduggan has quit IRC | 15:54 | |
*** changbl has quit IRC | 15:55 | |
*** maheshp has joined #openstack-dev | 15:55 | |
*** jcoufal has quit IRC | 15:56 | |
stevemar | celor: oauth 2.0 python libraries that had server side support were ... hard to find and incomplete to say the least | 15:57 |
*** pmathews1 has joined #openstack-dev | 15:57 | |
*** pmathews has quit IRC | 15:58 | |
*** xga has quit IRC | 15:59 | |
*** celor1 has joined #openstack-dev | 16:00 | |
*** xga has joined #openstack-dev | 16:01 | |
*** stevemar is now known as stevemar|afk | 16:01 | |
*** datsun180b has quit IRC | 16:01 | |
*** mmagr has quit IRC | 16:01 | |
*** celor has quit IRC | 16:01 | |
*** roz_ has quit IRC | 16:02 | |
*** jhesketh has quit IRC | 16:03 | |
*** basha has quit IRC | 16:04 | |
*** devoid has joined #openstack-dev | 16:04 | |
*** MaxV has quit IRC | 16:05 | |
*** alexpilotti has quit IRC | 16:06 | |
*** bugsduggan has joined #openstack-dev | 16:06 | |
*** alop_ has joined #openstack-dev | 16:07 | |
*** alop has quit IRC | 16:08 | |
*** alop_ is now known as alop | 16:08 | |
*** rupakg has quit IRC | 16:08 | |
*** radez is now known as radez_g0n3 | 16:09 | |
*** freedomhui has joined #openstack-dev | 16:09 | |
*** celor1 has quit IRC | 16:10 | |
*** celor has joined #openstack-dev | 16:11 | |
*** janisg has quit IRC | 16:11 | |
*** romcheg has left #openstack-dev | 16:11 | |
*** changbl has joined #openstack-dev | 16:13 | |
*** zaneb has quit IRC | 16:13 | |
*** celor has quit IRC | 16:14 | |
*** celor has joined #openstack-dev | 16:14 | |
*** alexpilotti has joined #openstack-dev | 16:14 | |
*** wfoster_away is now known as wfoster | 16:16 | |
*** danwent has joined #openstack-dev | 16:16 | |
*** iartarisi has quit IRC | 16:18 | |
clayg | clarkb: re https://bugs.launchpad.net/swift/+bug/1217288 - I'm not sure that it *is* new setuptools, it happened as soon as setuptools 1.1 was pushed to pypi, but I'm not sure on correlation vs. causation | 16:18 |
uvirtbot | Launchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed] | 16:18 |
*** celor has quit IRC | 16:19 | |
*** FunnyLookinHat has joined #openstack-dev | 16:19 | |
*** markwash has joined #openstack-dev | 16:19 | |
*** amotoki has quit IRC | 16:19 | |
*** arezadr has quit IRC | 16:19 | |
*** wfoster is now known as wfoster_away | 16:19 | |
*** danwent has quit IRC | 16:21 | |
*** Ryan_Lane has quit IRC | 16:21 | |
*** networkstatic has joined #openstack-dev | 16:21 | |
*** dina_belova has joined #openstack-dev | 16:22 | |
*** mkerrin has quit IRC | 16:23 | |
*** jistr has quit IRC | 16:23 | |
*** zaitcev has joined #openstack-dev | 16:24 | |
*** jgallard has quit IRC | 16:24 | |
clarkb | clayg: ok. I ask because between 0.9 and 1.0 there were some backward incompatible changes in setuptools | 16:24 |
*** hemna has quit IRC | 16:25 | |
clarkb | clayg: but if 1.0 is ok then those changes are probably not at fault | 16:25 |
*** flaper87 is now known as flaper87|afk | 16:25 | |
*** zaneb has joined #openstack-dev | 16:26 | |
*** SergeyLukjanov has joined #openstack-dev | 16:26 | |
*** flaper87|afk is now known as flaper87 | 16:26 | |
*** jtomasek has quit IRC | 16:29 | |
*** JordanP has quit IRC | 16:29 | |
clayg | clarkb: well... when did 1.0 come out? | 16:30 |
*** turduks has joined #openstack-dev | 16:30 | |
clarkb | clayg: 2013-08-17 | 16:30 |
clarkb | https://pypi.python.org/pypi/setuptools/1.0 | 16:31 |
*** ondergetekende_ has joined #openstack-dev | 16:31 | |
*** ondergetekende_ has quit IRC | 16:31 | |
*** reed has joined #openstack-dev | 16:32 | |
*** adepti37 has quit IRC | 16:32 | |
*** arezmerita has quit IRC | 16:32 | |
*** jbresnah has joined #openstack-dev | 16:33 | |
*** jtomasek has joined #openstack-dev | 16:34 | |
clayg | it's just the xattr and python-swiftclient that have problems installing, one relationship there is that they both also have "setup_requires" directives | 16:34 |
*** xqueralt is now known as xqueralt-afk | 16:34 | |
*** mestery has joined #openstack-dev | 16:35 | |
*** adepti37 has joined #openstack-dev | 16:35 | |
*** networkstatic has quit IRC | 16:35 | |
*** herndon has joined #openstack-dev | 16:36 | |
*** devoid has quit IRC | 16:37 | |
*** networkstatic has joined #openstack-dev | 16:37 | |
*** devoid1 has joined #openstack-dev | 16:37 | |
clarkb | clayg: do xattr and python-swfitclient install cleanly on their own? | 16:37 |
*** devoid1 has quit IRC | 16:37 | |
*** devoid1 has joined #openstack-dev | 16:38 | |
*** devoid1 has quit IRC | 16:38 | |
clarkb | clayg: xattr would be the more interesting one because it doesn't use our toolchain | 16:38 |
clayg | clarkb: hoooray! works cleaning with 0.9.8 :) | 16:38 |
*** devoid1 has joined #openstack-dev | 16:38 | |
clarkb | interesting, perhaps it is related to the incompatible changes | 16:38 |
clayg | clarkb: yeah they both install fine on their own (hence the pip install -r requirements.txt before setup.py develop is a workaround) | 16:39 |
clarkb | dstufft: ^ | 16:39 |
*** corXi has quit IRC | 16:39 | |
*** devoid1 has quit IRC | 16:39 | |
*** devoid1 has joined #openstack-dev | 16:39 | |
dstufft | whats up? | 16:39 |
clarkb | dstufft: if you could take a look at https://bugs.launchpad.net/swift/+bug/1217288 that would be awesome | 16:39 |
uvirtbot | Launchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed] | 16:39 |
clarkb | dstufft: the tl;dr is swift cannot install with setuptools >= 1.0 | 16:40 |
*** turduks has quit IRC | 16:40 | |
*** devoid1 has left #openstack-dev | 16:41 | |
dstufft | clarkb: looks like a setuptools bug | 16:42 |
clarkb | dstufft: so this isn't pbr being aweful again? :) | 16:42 |
*** jdennis1 has joined #openstack-dev | 16:42 | |
dstufft | clarkb: I don't think so | 16:42 |
*** alop has quit IRC | 16:43 | |
clarkb | dstufft: I guess next steps may be filing an upstream bug and working around it until upstream fixes? Is there a sane way of requiring a specific version of setuptools? the distribute merger seemed to imply that we are at the hands of external forces there | 16:44 |
*** xqueralt-afk is now known as xqueralt | 16:44 | |
*** radez_g0n3 is now known as radez | 16:44 | |
dstufft | There's not a real good sane way to require a specific version | 16:44 |
dstufft | you could test it against a specific version by creating a venv | 16:45 |
dstufft | since venv's bundle a specific version | 16:45 |
*** shakayumi has quit IRC | 16:45 | |
clarkb | dstufft: I think that is why the gate isn't broken | 16:45 |
*** turduks has joined #openstack-dev | 16:45 | |
*** alop has joined #openstack-dev | 16:46 | |
*** ruhe has quit IRC | 16:48 | |
*** turduks has quit IRC | 16:48 | |
*** danwent has joined #openstack-dev | 16:48 | |
*** flaper87 is now known as flaper87|afk | 16:49 | |
*** romcheg has joined #openstack-dev | 16:50 | |
*** ema_ has quit IRC | 16:50 | |
*** romcheg has left #openstack-dev | 16:50 | |
*** athomas has quit IRC | 16:51 | |
*** networkstatic has quit IRC | 16:51 | |
*** morganfainberg|a is now known as morganfainberg | 16:51 | |
*** morganfainberg is now known as morganfainberg|a | 16:52 | |
*** morganfainberg|a is now known as morganfainberg | 16:53 | |
*** jecarey has quit IRC | 16:54 | |
*** jecarey has joined #openstack-dev | 16:54 | |
*** dina_belova has quit IRC | 16:54 | |
*** dina_belova has joined #openstack-dev | 16:55 | |
*** kushal has joined #openstack-dev | 16:57 | |
*** lucasagomes has quit IRC | 16:58 | |
*** dina_belova has quit IRC | 16:59 | |
*** dachary has quit IRC | 16:59 | |
*** alop_ has joined #openstack-dev | 17:00 | |
*** alop has quit IRC | 17:00 | |
*** alop_ is now known as alop | 17:00 | |
clarkb | clayg: in the launchpad bug you mention you have an idea for a setuptools patch. Will you be filing a bug upstream and potentially fixing it? | 17:00 |
*** xga has quit IRC | 17:01 | |
clarkb | clayg: dstufft: also is the bug in setuptools described at https://bugs.launchpad.net/swift/+bug/1217288/comments/12 ? | 17:01 |
uvirtbot | Launchpad bug 1217288 in swift "Swift installation crashes" [High,Confirmed] | 17:01 |
*** tkammer has joined #openstack-dev | 17:01 | |
*** fbo is now known as fbo_away | 17:01 | |
*** kushal has quit IRC | 17:04 | |
*** athomas has joined #openstack-dev | 17:05 | |
*** tkammer_ has joined #openstack-dev | 17:05 | |
*** tkammer has quit IRC | 17:06 | |
*** maheshp has quit IRC | 17:06 | |
*** turduks has joined #openstack-dev | 17:07 | |
*** danwent has quit IRC | 17:07 | |
dstufft | clarkb: tha' what it sounds like to me | 17:07 |
*** SumitNaiksatam has quit IRC | 17:09 | |
*** danwent has joined #openstack-dev | 17:09 | |
*** yassine_ has quit IRC | 17:14 | |
clayg | clarkb: dstufft: yeah if either of you feels qualified to shepard my fix upstream it'd be nice for me to not have to try and muddle through it - I've already burned a whole day on that mess | 17:15 |
clarkb | dstufft is definitely the person to help in that area :) | 17:15 |
clarkb | clayg: probably would help to submit a bug with what you have in comment 12 on the lp bug | 17:15 |
* clayg mummbles something about hg branches | 17:15 | |
*** safchain has quit IRC | 17:16 | |
clayg | clarkb: you mean file a bug against setuptools on bitbucket? | 17:16 |
clarkb | ya | 17:16 |
*** Tross has quit IRC | 17:16 | |
*** ydacheville has quit IRC | 17:16 | |
*** ydacheville has joined #openstack-dev | 17:17 | |
*** turduks has quit IRC | 17:18 | |
harlowja | samalba thx for looking at the usage of undomanager :) | 17:18 |
harlowja | sadly the error recovery is one of openstacks flaws right now | 17:19 |
harlowja | *the general concept of error recovery | 17:19 |
*** danwent has quit IRC | 17:19 | |
*** otherwiseguy has quit IRC | 17:22 | |
*** freedomhui has quit IRC | 17:23 | |
*** doude has quit IRC | 17:24 | |
*** Tross has joined #openstack-dev | 17:24 | |
*** pabelanger_ has joined #openstack-dev | 17:25 | |
*** sandeepr_ltp has joined #openstack-dev | 17:25 | |
*** pabelanger_ has quit IRC | 17:25 | |
*** pabelanger_ has joined #openstack-dev | 17:25 | |
clayg | clarkb: https://bitbucket.org/pypa/setuptools/issue/73/ (posted as anon, formatting all messed up - but, I tried) | 17:25 |
*** pabelanger has quit IRC | 17:25 | |
samalba | harlowja: hey thanks to you | 17:26 |
*** pabelanger_ is now known as pabelanger | 17:26 | |
harlowja | np | 17:26 |
samalba | you raised a good point | 17:26 |
*** pabelanger_ has joined #openstack-dev | 17:26 | |
clarkb | clayg: I am sure I would've done no better | 17:26 |
clarkb | clayg: bitbucket and hg are not things that play nice | 17:26 |
*** HenryG has quit IRC | 17:27 | |
*** nunosantos_ has quit IRC | 17:27 | |
*** jruzicka has quit IRC | 17:27 | |
*** nsantos has joined #openstack-dev | 17:27 | |
*** nsantos is now known as nunofsantos | 17:27 | |
*** nunofsantos is now known as nunosantos | 17:27 | |
*** HenryG has joined #openstack-dev | 17:27 | |
*** nunosantos has quit IRC | 17:27 | |
*** nunosantos has joined #openstack-dev | 17:28 | |
*** MaxV has joined #openstack-dev | 17:28 | |
*** jtomasek has quit IRC | 17:28 | |
*** pcm_ has quit IRC | 17:28 | |
*** MaxV has quit IRC | 17:28 | |
harlowja | samalba i put up a few responses, nothing major i think | 17:29 |
*** rackerjoe has joined #openstack-dev | 17:29 | |
*** dstufft has quit IRC | 17:30 | |
*** datsun180b has joined #openstack-dev | 17:30 | |
*** dstufft has joined #openstack-dev | 17:30 | |
*** dprince has joined #openstack-dev | 17:31 | |
*** xqueralt is now known as xqueralt-afk | 17:32 | |
*** pcm_ has joined #openstack-dev | 17:33 | |
*** danwent has joined #openstack-dev | 17:33 | |
*** Farooque has joined #openstack-dev | 17:33 | |
*** amscanne has joined #openstack-dev | 17:33 | |
*** jasondotstar has quit IRC | 17:33 | |
*** donaldh has quit IRC | 17:34 | |
*** jasdeepH has joined #openstack-dev | 17:34 | |
*** SumitNaiksatam has joined #openstack-dev | 17:35 | |
*** jasondotstar has joined #openstack-dev | 17:35 | |
*** Farooque has left #openstack-dev | 17:35 | |
*** dstufft has quit IRC | 17:35 | |
*** eglynn has quit IRC | 17:35 | |
*** thedodd has joined #openstack-dev | 17:36 | |
*** dstufft has joined #openstack-dev | 17:36 | |
*** danwent has quit IRC | 17:37 | |
*** souvik has joined #openstack-dev | 17:38 | |
*** dstufft has quit IRC | 17:38 | |
*** hemnafk is now known as hemna | 17:39 | |
*** dstufft has joined #openstack-dev | 17:39 | |
*** dstufft has quit IRC | 17:40 | |
*** dstufft has joined #openstack-dev | 17:40 | |
*** jtomasek has joined #openstack-dev | 17:41 | |
*** dstufft has quit IRC | 17:41 | |
samalba | harlowja: ok | 17:41 |
*** dstufft has joined #openstack-dev | 17:41 | |
*** dstanek has quit IRC | 17:42 | |
*** dstufft has quit IRC | 17:43 | |
*** dstufft has joined #openstack-dev | 17:43 | |
*** networkstatic has joined #openstack-dev | 17:43 | |
*** pabelanger has quit IRC | 17:44 | |
*** pabelanger has joined #openstack-dev | 17:44 | |
*** thedodd has quit IRC | 17:46 | |
*** dstufft has quit IRC | 17:46 | |
*** dstufft has joined #openstack-dev | 17:46 | |
*** thedodd has joined #openstack-dev | 17:47 | |
*** pschaef has quit IRC | 17:48 | |
*** X-Scale has joined #openstack-dev | 17:51 | |
*** alop has quit IRC | 17:52 | |
*** SergeyLukjanov has quit IRC | 17:52 | |
*** ndipanov has quit IRC | 17:52 | |
*** shakayumi has joined #openstack-dev | 17:52 | |
*** comay has quit IRC | 17:52 | |
*** sballe has joined #openstack-dev | 17:52 | |
*** SergeyLukjanov has joined #openstack-dev | 17:53 | |
*** dina_belova has joined #openstack-dev | 17:53 | |
*** stevemar|afk is now known as stevemar | 17:54 | |
*** jasondotstar has quit IRC | 17:55 | |
*** flaper87|afk is now known as flaper87 | 17:56 | |
*** codenamekt has quit IRC | 17:56 | |
*** tstevenson has joined #openstack-dev | 17:56 | |
*** egallen has quit IRC | 17:57 | |
*** Ryan_Lane has joined #openstack-dev | 17:57 | |
*** woodspa has joined #openstack-dev | 17:58 | |
*** kevinconway has quit IRC | 17:59 | |
*** rcleere_ has joined #openstack-dev | 17:59 | |
*** jasondotstar has joined #openstack-dev | 17:59 | |
*** insanida1e has joined #openstack-dev | 18:00 | |
*** rcleere has quit IRC | 18:00 | |
*** rcleere_ is now known as rcleere | 18:00 | |
*** jmontemayor has quit IRC | 18:03 | |
insanida1e | what's the difference between a quantum agent and a quantum plugin ? | 18:03 |
*** dina_belova has quit IRC | 18:03 | |
*** Tross has quit IRC | 18:03 | |
*** dina_belova has joined #openstack-dev | 18:04 | |
*** gyee has quit IRC | 18:04 | |
*** alop has joined #openstack-dev | 18:06 | |
*** kevinconway has joined #openstack-dev | 18:06 | |
*** tkammer_ has quit IRC | 18:06 | |
*** otherwiseguy has joined #openstack-dev | 18:07 | |
*** jmontemayor has joined #openstack-dev | 18:07 | |
*** amohn9 has joined #openstack-dev | 18:07 | |
*** johnthetubaguy has quit IRC | 18:08 | |
*** shakayumi has quit IRC | 18:08 | |
*** dina_belova has quit IRC | 18:08 | |
*** bknudson has joined #openstack-dev | 18:08 | |
morganfainberg | dolphm: ping | 18:09 |
*** ruhe_ has joined #openstack-dev | 18:10 | |
*** mhu has quit IRC | 18:12 | |
*** xqueralt-afk is now known as xqueralt | 18:12 | |
*** jbresnah has quit IRC | 18:14 | |
sc68cal | Small openstack.org patch - noticed that there was no link to the dev doc for Nova | 18:14 |
sc68cal | https://review.openstack.org/#/c/44331/ | 18:14 |
*** Ryan_Lane has quit IRC | 18:14 | |
*** maheshp has joined #openstack-dev | 18:14 | |
*** dstufft has quit IRC | 18:15 | |
*** dstufft has joined #openstack-dev | 18:15 | |
*** briancurtin has quit IRC | 18:16 | |
*** X-Scale has quit IRC | 18:17 | |
*** mhu has joined #openstack-dev | 18:18 | |
*** Ryan_Lane has joined #openstack-dev | 18:18 | |
*** insanida1e has quit IRC | 18:20 | |
*** mmagr has joined #openstack-dev | 18:20 | |
*** souvik has quit IRC | 18:22 | |
*** aeperezt has quit IRC | 18:22 | |
*** briancurtin has joined #openstack-dev | 18:23 | |
*** Murali_Balcha has quit IRC | 18:23 | |
*** dina_belova has joined #openstack-dev | 18:24 | |
*** melwitt has joined #openstack-dev | 18:24 | |
*** iambossjones has joined #openstack-dev | 18:24 | |
*** dmakogon_ has joined #openstack-dev | 18:26 | |
*** donaldh has joined #openstack-dev | 18:26 | |
*** spzala has quit IRC | 18:28 | |
*** iambossjones is now known as bossjones | 18:29 | |
*** doude has joined #openstack-dev | 18:31 | |
*** networkstatic has quit IRC | 18:32 | |
*** X-Scale has joined #openstack-dev | 18:32 | |
*** Guest76118 has quit IRC | 18:32 | |
*** mhu has quit IRC | 18:33 | |
insanidade | anyone alive ? | 18:33 |
*** devvesa has quit IRC | 18:34 | |
*** mhu has joined #openstack-dev | 18:34 | |
*** vipul is now known as vipul-away | 18:34 | |
*** vipul-away is now known as vipul | 18:35 | |
*** bossjones has left #openstack-dev | 18:35 | |
*** sarob has joined #openstack-dev | 18:39 | |
stevemar | i think a few people are alive | 18:39 |
*** MaxV has joined #openstack-dev | 18:39 | |
morganfainberg | stevemar: speak for yourself, i'm a zombie :P | 18:39 |
stevemar | insanidade^ | 18:39 |
stevemar | morgan! | 18:39 |
stevemar | my favorite zombie | 18:39 |
insanidade | stevemar: hey | 18:40 |
*** pabelanger has quit IRC | 18:40 | |
stevemar | morganfainberg: i hear zombies like to review patches: https://review.openstack.org/#/c/43600/ | 18:40 |
*** mattymo has quit IRC | 18:40 | |
insanidade | stevemar: what is the difference between an agent and a plugin ? | 18:41 |
*** mattymo has joined #openstack-dev | 18:41 | |
insanidade | for isntance: a quantum agent and a quantum plugin. | 18:41 |
*** terryh has quit IRC | 18:42 | |
*** rackerjoe has left #openstack-dev | 18:42 | |
*** herndon has quit IRC | 18:43 | |
*** pabelanger has joined #openstack-dev | 18:43 | |
*** MaxV has quit IRC | 18:43 | |
*** terryh has joined #openstack-dev | 18:43 | |
*** donaldh has quit IRC | 18:46 | |
*** ruhe_ has quit IRC | 18:46 | |
stevemar | insanidade: no idea, but no one else was replying to you =\ | 18:46 |
insanidade | stevemar: yes :( | 18:47 |
insanidade | stevemar: I'll keep researching. | 18:47 |
*** dstanek_ has joined #openstack-dev | 18:47 | |
stevemar | insanidade: good luck! | 18:47 |
morganfainberg | stevemar: yeah, i am doing reviews now. but also meetings and stuff going on here :P | 18:48 |
stevemar | morganfainberg: excuses! jk. thanks for your suggestion btw for creating a get_consumer_with_secret | 18:49 |
morganfainberg | yeah seems like a better approach | 18:49 |
morganfainberg | np! | 18:49 |
*** donaldh has joined #openstack-dev | 18:50 | |
*** danwent has joined #openstack-dev | 18:50 | |
dolphm | morganfainberg: moar decorators https://review.openstack.org/#/c/41970/ | 18:51 |
dolphm | morganfainberg: also, pong | 18:51 |
*** danwent has quit IRC | 18:51 | |
*** dina_belova has quit IRC | 18:51 | |
morganfainberg | dolphm: notifications? yeah was pinging you for that | 18:51 |
*** dina_belova has joined #openstack-dev | 18:52 | |
dolphm | morganfainberg: yay | 18:52 |
morganfainberg | dolphm: so i wanted to ask if you minded loosing the __module__ and __docstring__ information for the methods at runtime (e.g. from the methods calling the decorated methods) | 18:54 |
morganfainberg | dolphm: most of our decorators don't use functools.wraps (which solves that) so it might not be terribly important | 18:54 |
*** maheshp has quit IRC | 18:54 | |
morganfainberg | dolphm: didn't see a need to mark up the gerrit review for something we may not be hung up on ;) | 18:54 |
dolphm | morganfainberg: i personally don't ... but i'd be happy to use functools (i just have more experience not using it, so i didn't) | 18:55 |
morganfainberg | dolphm: the object setup you're using precludes it, so i think iteration on it in Icehouse ;) | 18:55 |
morganfainberg | dolphm: it's not a huge deal. | 18:55 |
*** bswartz has quit IRC | 18:55 | |
morganfainberg | dolphm: functionality wont be changed by using functools in most cases. | 18:56 |
dolphm | morganfainberg: you can't use functools.wraps on my inner wrapper() to preserve the original docstr, etc? | 18:56 |
morganfainberg | dolphm: you'd need to use it form the __init__ since __call__ needs to be updated. | 18:56 |
morganfainberg | erm, self | 18:56 |
morganfainberg | s/__call__/self | 18:56 |
morganfainberg | and currently __init__ doesn't know the function, since f isn't passed in until __call__ | 18:57 |
*** dina_belova has quit IRC | 18:57 | |
morganfainberg | (wow, that sounds like technobabble) | 18:57 |
dolphm | morganfainberg: ++ | 18:57 |
*** jmontemayor has quit IRC | 18:57 | |
morganfainberg | dolphm: long and the short, time to review decorators! | 18:57 |
*** sushils has quit IRC | 18:58 | |
*** novas0x2a|laptop has joined #openstack-dev | 18:58 | |
*** yolanda has quit IRC | 18:58 | |
*** jbresnah has joined #openstack-dev | 18:59 | |
*** devoid1 has joined #openstack-dev | 18:59 | |
*** maheshp has joined #openstack-dev | 18:59 | |
*** maheshp1 has joined #openstack-dev | 18:59 | |
*** devoid1 has left #openstack-dev | 18:59 | |
dolphm | morganfainberg: since i didn't use functools.wraps, should i document that i used an abstract base class to implement concrete callable objects which accept arguments to return wrappers of functions which call the notification function based on the arguments to the wrapped function? :-/ | 19:01 |
*** boris-42 has quit IRC | 19:03 | |
*** jasondotstar has quit IRC | 19:03 | |
*** briancurtin has quit IRC | 19:04 | |
*** briancurtin has joined #openstack-dev | 19:04 | |
*** sarob_ has joined #openstack-dev | 19:04 | |
morganfainberg | dolphm: I don't think documentation will hurt, but I don't think that is really required. though if developing.rst doesn't make reference to the decorators for notifications | 19:04 |
morganfainberg | dolphm: that should be added :) | 19:04 |
*** briancurtin has left #openstack-dev | 19:05 | |
dolphm | morganfainberg: that might actually be in a different patch from the bp... | 19:05 |
*** alunduil has quit IRC | 19:05 | |
morganfainberg | dolphm: yeah, i haven't looked at the repo to verify that yet. | 19:05 |
dolphm | morganfainberg: this is the doc-only patch https://review.openstack.org/#/c/42205/ | 19:06 |
*** jasondotstar has joined #openstack-dev | 19:06 | |
morganfainberg | aha | 19:06 |
morganfainberg | nice | 19:06 |
morganfainberg | and gyee aready hit the developing.rst front here | 19:06 |
morganfainberg | there* | 19:06 |
*** alexb_ has joined #openstack-dev | 19:07 | |
*** jmontemayor has joined #openstack-dev | 19:07 | |
*** sarob has quit IRC | 19:07 | |
*** sarob has joined #openstack-dev | 19:07 | |
*** dstanek_ is now known as dstanek | 19:07 | |
*** ianw has quit IRC | 19:08 | |
*** sarob_ has quit IRC | 19:08 | |
*** sarob has quit IRC | 19:09 | |
*** sarob has joined #openstack-dev | 19:09 | |
*** ssurana has left #openstack-dev | 19:12 | |
*** sarob_ has joined #openstack-dev | 19:12 | |
*** sarob has quit IRC | 19:13 | |
*** eglynn has joined #openstack-dev | 19:17 | |
*** tmclaugh[work] has quit IRC | 19:18 | |
dolphm | bknudson: addressed all your comments except 'classes should be capitalized' (left an inline comment) | 19:19 |
bknudson | dolphm: I'll look in a minute | 19:19 |
*** Ryan_Lane has quit IRC | 19:20 | |
dolphm | bknudson: i also missed your 'revert whitespace change' until just now ... i've got that ready locally pending more comments | 19:21 |
bknudson | dolphm: I was wondering about that. | 19:22 |
*** athomas has quit IRC | 19:22 | |
bknudson | dolphm: and I have no other comments. | 19:22 |
bknudson | looks good. | 19:22 |
morganfainberg | dolphm: local module names bound to the classes is a good solution to the caps | 19:22 |
dolphm | bknudson: let me post the whitespace cahnge then | 19:22 |
dolphm | bknudson: ^ do you prefer that approach? | 19:22 |
morganfainberg | dolphm: other than what bknudson pointed out, this looks good. | 19:23 |
*** leif has joined #openstack-dev | 19:23 | |
*** leif is now known as Guest22275 | 19:23 | |
*** ecarlin has joined #openstack-dev | 19:24 | |
morganfainberg | dolphm: if anyone else points out lowercase names and you don't move to the module alias names, i'd toss a comment into the code (someone might try and "clean it up") | 19:25 |
dolphm | morganfainberg: writing that comment now! | 19:25 |
bknudson | dolphm: I don't think adding a created = Created alias would be useful. | 19:25 |
dolphm | morganfainberg: bknudson: updated with Capitalized classes plus a # comment to explain wtf | 19:26 |
morganfainberg | cool. | 19:26 |
*** sandeepr_ltp has quit IRC | 19:26 | |
bknudson | dolphm: could created/updated/deleted actually be functions and not classes? | 19:27 |
*** jecarey has quit IRC | 19:27 | |
bknudson | I guess I could try it out myself. | 19:27 |
dolphm | bknudson: if you can do that, i don't know how? i need the __init__ to capture the resource type in @created('user') | 19:28 |
morganfainberg | bknudson: it's fairly easy to do, it's what i had henrynash do for @protected | 19:28 |
*** jecarey has joined #openstack-dev | 19:28 | |
dolphm | morganfainberg: can what i did be simplified? | 19:28 |
bknudson | it's just a function that takes arguments and returns a function | 19:28 |
morganfainberg | dolphm: yeah it could be made into a function | 19:29 |
*** rods1 has quit IRC | 19:30 | |
morganfainberg | dolphm: something like http://paste.openstack.org/show/45414/ | 19:31 |
morganfainberg | dolphm: so. | 19:31 |
*** boris-42 has joined #openstack-dev | 19:32 | |
*** SergeyLukjanov has quit IRC | 19:32 | |
*** vipul is now known as vipul-away | 19:32 | |
*** vipul-away is now known as vipul | 19:32 | |
dolphm | morganfainberg: ah, okay... i've seen this before, but never thought much about it | 19:32 |
*** bswartz has joined #openstack-dev | 19:32 | |
morganfainberg | dolphm: now, it doesn't give you the resource id, you'd likely need to do some inspection to get that. | 19:34 |
morganfainberg | dolphm: that is the biggest benefit to your implementation, self is a sideeffect. | 19:35 |
dolphm | morganfainberg: http://pasteraw.com/pal3h4xl1m6w3qx2xccrjigcha3ng5j :D | 19:35 |
morganfainberg | dolphm: are these decorators only ever valid on bound methods? | 19:35 |
morganfainberg | erm class/bound methods? | 19:36 |
dolphm | morganfainberg: yes | 19:36 |
morganfainberg | then no issue (though a comment would be good to that effect) | 19:36 |
dolphm | morganfainberg: ++ | 19:36 |
*** egallen has joined #openstack-dev | 19:36 | |
morganfainberg | if you go with the function decorators you could do f.__self__.__class__.__name__.lower() | 19:37 |
morganfainberg | :P | 19:37 |
morganfainberg | if only bound methods, | 19:37 |
*** pabelanger has quit IRC | 19:37 | |
*** alexb_ has quit IRC | 19:38 | |
*** gyee has joined #openstack-dev | 19:39 | |
*** alexb_ has joined #openstack-dev | 19:40 | |
*** nati_ueno has joined #openstack-dev | 19:40 | |
*** egallen has quit IRC | 19:41 | |
*** tmclaugh[work] has joined #openstack-dev | 19:41 | |
morganfainberg | dolphm: http://paste.openstack.org/show/45418/ quick example more function-like | 19:41 |
*** SergeyLukjanov has joined #openstack-dev | 19:41 | |
dolphm | morganfainberg: https://review.openstack.org/#/c/41970/24/keystone/notifications.py | 19:42 |
dolphm | morganfainberg: looking at rewriting as functions now... | 19:42 |
*** nati_ueno has quit IRC | 19:42 | |
morganfainberg | dolphm: nod. | 19:43 |
*** nati_ueno has joined #openstack-dev | 19:43 | |
*** sushils has joined #openstack-dev | 19:43 | |
morganfainberg | dolphm: ah, mine had some copy-pasta errors :P | 19:43 |
dolphm | morganfainberg: i see :P | 19:44 |
dolphm | morganfainberg: i don't want to have 3 of these triple nested functions either.. | 19:44 |
morganfainberg | dolphm: fair enough | 19:46 |
morganfainberg | dolphm: decorators with arguments tend to be a bit of namespace abuse :P | 19:46 |
*** vipul is now known as vipul-away | 19:47 | |
morganfainberg | using the classes, like you are, isn't a bad option. | 19:47 |
*** egallen has joined #openstack-dev | 19:48 | |
dolphm | morganfainberg: yeah, i'm going to be done with this for the moment... i think my brain is in a knot | 19:49 |
*** branen__ has joined #openstack-dev | 19:49 | |
morganfainberg | dolphm: i think making it functions isn't worth the headache, especially if you want to avoid 3x3nested functions | 19:49 |
morganfainberg | me, i'm going to go get some lunch. :) bbib | 19:51 |
dolphm | morganfainberg: /salute | 19:51 |
*** egallen_ has joined #openstack-dev | 19:52 | |
*** branen_ has quit IRC | 19:52 | |
*** egallen has quit IRC | 19:53 | |
*** egallen_ is now known as egallen | 19:53 | |
bknudson | dolphm: def created(resource_type, host=None): return BaseManagerNotificationWrapper('created', resource_type, host=host) | 19:53 |
*** prad has joined #openstack-dev | 19:54 | |
bknudson | dolphm: http://paste.openstack.org/show/45420/ -- the tests pass. | 19:55 |
*** briancurtin has joined #openstack-dev | 19:58 | |
*** hartsocks has joined #openstack-dev | 19:58 | |
*** martine_ has quit IRC | 19:59 | |
*** SergeyLukjanov has quit IRC | 19:59 | |
stevemar | bknudson: i uploaded another patch of sql update for oauth: https://review.openstack.org/#/c/43600/ | 19:59 |
*** egallen has quit IRC | 19:59 | |
stevemar | bknudson: you seem to be actively viewing it | 20:00 |
*** pixelbeat has quit IRC | 20:00 | |
*** pcm_ has quit IRC | 20:00 | |
*** fbo_away is now known as fbo | 20:00 | |
dolphm | bknudson: ++ i like that | 20:01 |
*** hartsocks has left #openstack-dev | 20:01 | |
*** ecarlin has quit IRC | 20:01 | |
dolphm | bknudson: https://review.openstack.org/#/c/41970/26/keystone/notifications.py | 20:02 |
*** dina_belova has joined #openstack-dev | 20:02 | |
*** egallen has joined #openstack-dev | 20:02 | |
*** HenryG has quit IRC | 20:02 | |
bknudson | dolphm: do you want to remove Base from the class name since it's not a base class for anything? | 20:03 |
bknudson | BaseManagerNotificationWrapper | 20:03 |
dolphm | bknudson: yeah, i guess that's true now | 20:05 |
*** jasdeepH has quit IRC | 20:06 | |
*** mrunge has quit IRC | 20:07 | |
dolphm | bknudson: https://review.openstack.org/#/c/41970/27/keystone/notifications.py | 20:07 |
bknudson | stevemar: just a couple of comments to clean up the docstring. otherwise looks good to me. | 20:07 |
*** dina_belova has quit IRC | 20:07 | |
stevemar | bknudson: cool | 20:07 |
*** egallen has quit IRC | 20:07 | |
*** ianw has joined #openstack-dev | 20:08 | |
dolphm | stevemar: make session the first argument, not last | 20:08 |
stevemar | dolphm: is that the usual? cool | 20:09 |
dolphm | stevemar: all the other _get_whatever(self, session, whatever_id) follow that pattern | 20:09 |
*** boris-42 has quit IRC | 20:09 | |
*** dprince has quit IRC | 20:11 | |
*** doude has quit IRC | 20:11 | |
*** briancurtin has quit IRC | 20:14 | |
*** Guest22275 has quit IRC | 20:15 | |
*** leif has joined #openstack-dev | 20:16 | |
*** leif is now known as Guest4676 | 20:16 | |
*** afazekas has quit IRC | 20:16 | |
*** zodiak has quit IRC | 20:17 | |
*** jbresnah has quit IRC | 20:18 | |
*** doude has joined #openstack-dev | 20:18 | |
stevemar | dolphm, bkundson: should be good | 20:19 |
bknudson | dolphm: are there tests that identity create user, etc., sends notifications? | 20:21 |
*** NobodyCam_ has joined #openstack-dev | 20:23 | |
*** sandywalsh has quit IRC | 20:23 | |
*** NobodyCam_ has quit IRC | 20:23 | |
*** doude has quit IRC | 20:23 | |
*** donaldh has quit IRC | 20:24 | |
*** moted has quit IRC | 20:24 | |
*** jasdeepH has joined #openstack-dev | 20:24 | |
*** doude has joined #openstack-dev | 20:25 | |
gyee | dolphm, need your opinion on this one, https://review.openstack.org/#/c/43257/24/keystone/tests/filter_pagination.py, line 4 | 20:25 |
*** dachary_ has joined #openstack-dev | 20:25 | |
*** nati_ueno has quit IRC | 20:26 | |
*** dstufft has quit IRC | 20:27 | |
*** dstufft has joined #openstack-dev | 20:27 | |
*** dstufft has quit IRC | 20:28 | |
*** dstufft has joined #openstack-dev | 20:28 | |
*** amerine has quit IRC | 20:28 | |
*** maheshp1 has quit IRC | 20:30 | |
ekarlso- | Anyone ehre that knows what tool Horizon guys use for mockups ? | 20:30 |
dolphm | bknudson: not at the moment | 20:31 |
*** romcheg has joined #openstack-dev | 20:32 | |
*** vipul-away is now known as vipul | 20:32 | |
dolphm | gyee: replied, the copyright can stay / doesn't matter | 20:34 |
morganfainberg | The only nit is that the OpenStack LLC one should either be removed or… made to say OpenStack Foundation | 20:34 |
gyee | dolphm, k, sounds good | 20:34 |
morganfainberg | likley omitted | 20:34 |
morganfainberg | but in either case, Foundation is the right one:P not LLC | 20:35 |
dolphm | and IBM doesn't matter | 20:35 |
morganfainberg | what dolphm said :) | 20:35 |
*** sandywalsh has joined #openstack-dev | 20:35 | |
dolphm | gyee: you can add (c) Guang Yee to every file you touch if it makes you happy | 20:35 |
*** nati_ueno has joined #openstack-dev | 20:35 | |
*** donaldh has joined #openstack-dev | 20:36 | |
gyee | dolphm, nah, don't want to leave any evident | 20:36 |
dolphm | gyee: lol | 20:36 |
gyee | no evident, no crime | 20:36 |
*** vladimir3p has joined #openstack-dev | 20:36 | |
morganfainberg | gyee: ooh, so i should start adding (c) Guang Yee to files you haven't touched? :P | 20:36 |
gyee | doh! | 20:36 |
*** dmakogon_ has quit IRC | 20:37 | |
fabio | morganfainberg: maybe I will start to do that :-) | 20:37 |
morganfainberg | fabio: i know we can count on you! | 20:37 |
dolphm | gyee: i personally think they're super obnoxious as they pretty much just serve as advertising to other developers | 20:39 |
gyee | dolphm, I only do that in my resume | 20:39 |
morganfainberg | dolphm: except that it's my company's policy to add one (I said we shouldn't bother), I would just omit them at this point. | 20:40 |
dolphm | gyee: plaster copyright notices everywhere? | 20:40 |
dolphm | morganfainberg: "Come work at Company X because we touch a lot of files!" | 20:40 |
gyee | haha | 20:40 |
morganfainberg | dolphm: hehe | 20:40 |
dolphm | great? ... as i have to scoll past the growing list of copyrights to get to work ... | 20:40 |
gyee | dolphm not sure about you but I have fond memories with everything I touched :) | 20:41 |
bknudson | dolphm: another suggestion for notifications wrappers: http://paste.openstack.org/show/45422/ | 20:41 |
*** sarob has joined #openstack-dev | 20:41 | |
bknudson | avoids duplicating the 'user' string when decorating the different methods. | 20:41 |
bknudson | not totally tested. | 20:42 |
*** doude has quit IRC | 20:43 | |
*** sarob has quit IRC | 20:43 | |
*** sarob__ has joined #openstack-dev | 20:43 | |
*** vladimir3p has quit IRC | 20:43 | |
*** doude has joined #openstack-dev | 20:44 | |
*** romcheg has quit IRC | 20:44 | |
*** sarob_ has quit IRC | 20:45 | |
*** martyntaylor has quit IRC | 20:47 | |
*** tmclaugh[work] has quit IRC | 20:47 | |
dolphm | bknudson: that's a lot of not totally tested code to move a string argument 'user' to an object attribute .user. | 20:47 |
portante | dmllr? | 20:48 |
*** eglynn has quit IRC | 20:48 | |
morganfainberg | bknudson: i think that might make it harder to read. not saying it isn't an optimization to avoid some duplication | 20:48 |
dolphm | bknudson: you could try and parse the wrapped function name to try and get them both for free? (operation, resource_type) = f.__name__.split('_', 1) | 20:49 |
*** alexpilotti has quit IRC | 20:49 | |
dolphm | bknudson: leaning towards magical though | 20:49 |
morganfainberg | dolphm: I'm going to say I prefer a bit easier to read in this case, and both bknudson and the f.__name__.split is going to be a bit harder to read overall | 20:50 |
dolphm | bknudson: particularly dangerous because it's producing an API behind the scenes that other projects will end consuming | 20:50 |
dolphm | morganfainberg: ++ | 20:50 |
morganfainberg | erm s/bknudson/bknudson's suggestion/ | 20:50 |
insanidade | hey, guys. quick question on the way things are developed in the openstack ecosystem: what happens to devstack when something is commited in the main openstack development branch? is it introduced in the latest devstack available for download ? How do I update my current devstack environmetn with that new code ? | 20:50 |
bknudson | dolphm: morganfainberg: ok, it was an experiment to see if the repeated string could be not repeated | 20:50 |
morganfainberg | bknudson: fun expiriment though :) | 20:51 |
bknudson | since it's only repeated 3 times, not a big deal. | 20:51 |
bknudson | and it's generally a short string. | 20:51 |
dolphm | insanidade: yes, devstack works with master branches by default | 20:52 |
insanidade | dolphm: and how do update it? rerun stack.sh ? | 20:52 |
*** briancurtin has joined #openstack-dev | 20:54 | |
*** dachary_ is now known as dachary | 20:54 | |
dolphm | insanidade: i think that should work... i honestly never work with a single devstack install long enough need updates from other projects | 20:54 |
morganfainberg | insanidade: i believe devstack wont download/update code if the code is already cloned locally, you could either git pull in the specific clone, or delete the clone from /opt/stack, which case devstack will redownload. | 20:55 |
dolphm | insanidade: you can also git pull the individual repos, and restart each service, etc | 20:55 |
*** ydacheville has quit IRC | 20:56 | |
*** ydacheville_ has joined #openstack-dev | 20:56 | |
insanidade | dolphm, morganfainberg : hmm, ok. I'm setting up a dev environment for me. I'm trying to define how I'm going to work on code, update my local code, that sort of thing. | 20:56 |
insanidade | dolphm , morganfainberg : the simple git way of updating your code, right ? | 20:57 |
insanidade | thanks for the info. | 20:57 |
*** alunduil has joined #openstack-dev | 20:57 | |
*** mhu has quit IRC | 20:57 | |
*** briancurtin has left #openstack-dev | 20:57 | |
dolphm | is there a good 'typical developer workflow with devstack' article somewhere? | 20:58 |
*** johnthetubaguy has joined #openstack-dev | 20:58 | |
clarkb | anteaya: ^ | 20:58 |
insanidade | dolphm: not that I'm aware of. | 20:58 |
dolphm | i found some slides... | 20:59 |
morganfainberg | dolphm / insanidade: i think most people teardown/restack from scratch each time. | 20:59 |
*** mhu has joined #openstack-dev | 20:59 | |
morganfainberg | dolphm / insanidade: thats what i was doing w/ vagrant until my box files got a little out of date (need to dedicate some time to fix that) | 20:59 |
anteaya | dolphm: I have been working on bits and pieces towards a working with devstack post/article/page but right now it is kind of in bits | 21:00 |
*** sarob__ has quit IRC | 21:01 | |
insanidade | morganfainberg , dolphm : looks like my set up. vagrant + virtualbox (centos) | 21:01 |
dolphm | anteaya: i'd love to have something to point people to, if it existed | 21:01 |
*** sarob has joined #openstack-dev | 21:01 | |
anteaya | dolphm: here are my rough notes for standing up a devstack using vagrant: https://gist.github.com/anteaya/dedca991f761c48bb262 | 21:01 |
anteaya | you are right, time for a blog post or something on the topic, let me cobble something together that is more polished | 21:02 |
*** amohn9 has quit IRC | 21:02 | |
anteaya | might be a day or so before I have a url I can share | 21:02 |
*** eglynn has joined #openstack-dev | 21:02 | |
morganfainberg | anteaya: that would be awesome! | 21:02 |
dolphm | anteaya: this isn't bad, but it's a little heavy on the 'steps' and light on the explanation / overview http://docs.openstack.org/folsom/openstack-ops/content/customize.html | 21:02 |
anteaya | morganfainberg: thanks, okay what kinds of details, questions do you want to see answered | 21:02 |
anteaya | dolphm: yes | 21:03 |
*** dina_belova has joined #openstack-dev | 21:03 | |
anteaya | mostly my notes I use when I do it myself | 21:03 |
anteaya | it needs some expansion | 21:03 |
dolphm | morganfainberg: awaiting your gracious downvote https://review.openstack.org/#/c/41970/ | 21:04 |
*** Guest4676 has quit IRC | 21:04 | |
morganfainberg | dolphm: lol, probably not going to get one today. probably an upboat^Hupvote :P | 21:04 |
*** leif has joined #openstack-dev | 21:04 | |
*** jmontemayor_ has joined #openstack-dev | 21:05 | |
*** leif is now known as Guest29767 | 21:05 | |
dolphm | morganfainberg: i should do a keystoneclient release based on your hacking fixes | 21:05 |
morganfainberg | dolphm: i'm going to have to see if i can wedge the update_wrapper stuff into this stype of decorator | 21:05 |
*** sarob has quit IRC | 21:05 | |
dolphm | morganfainberg: Release Notes: THE CODE IS MUCH MORE SHINY WE SWEAR | 21:05 |
morganfainberg | dolphm: in the future. | 21:05 |
morganfainberg | dolphm: LOL. | 21:05 |
morganfainberg | 0.3.2.0.0.0.0.1 ? | 21:06 |
*** stevemar has quit IRC | 21:06 | |
dolphm | lol | 21:06 |
dolphm | morganfainberg: approved the first two... third needs a rebase | 21:07 |
*** boden has quit IRC | 21:07 | |
morganfainberg | dolphm: ah not surprised. | 21:07 |
*** mhu has quit IRC | 21:07 | |
morganfainberg | dolphm: funny, this notification code, i feel like i've reviewed it already :P | 21:07 |
*** nati_ueno has quit IRC | 21:07 | |
*** dina_belova has quit IRC | 21:08 | |
*** rfolco has quit IRC | 21:08 | |
*** jmontemayor has quit IRC | 21:08 | |
*** nati_ueno has joined #openstack-dev | 21:09 | |
dstanek | anteaya: dolphm: i just a shell script to bootstrap devstack on Rackspace - with small mods it could work for vagrant too | 21:09 |
dstanek | https://gist.github.com/dstanek/6383436 | 21:09 |
*** dvarga has quit IRC | 21:10 | |
*** mhu has joined #openstack-dev | 21:10 | |
anteaya | dstanek: yes, the problem is that for newbies if the shell script doesn't give them an installation you spend the blog post trouble shooting the shell script rather than explaining the steps | 21:10 |
anteaya | for new people, I err on the side of manual steps with explanation so they learn, so they understand, whether they use a script or recipe or not down the road | 21:11 |
anteaya | and thanks for the link | 21:11 |
*** jamielennox|away is now known as jamielennox | 21:13 | |
*** nati_ueno has quit IRC | 21:15 | |
*** sarob has joined #openstack-dev | 21:15 | |
*** sarob has quit IRC | 21:16 | |
*** sarob has joined #openstack-dev | 21:16 | |
*** Ryan_Lane has joined #openstack-dev | 21:16 | |
dolphm | gyee: henrynash: bknudson: this is rather simple, just for tests, and a blocker for the bp goal https://review.openstack.org/#/c/44211/ | 21:20 |
*** jasondotstar has quit IRC | 21:20 | |
morganfainberg | yeah i split that out from the other one so it was easier to see and to fix both patchset's tests | 21:21 |
*** dachary has quit IRC | 21:22 | |
*** doude has quit IRC | 21:22 | |
bknudson | morganfainberg: on https://review.openstack.org/#/c/44211/ -- is CacheIsolatingProxy only useful for testing? | 21:23 |
gyee | dolphm, looking | 21:23 |
morganfainberg | bknudson: if you're using the memory backend, for any reason | 21:23 |
bknudson | if so it should be in keystone.tests and not keystone.common | 21:23 |
morganfainberg | it's useful | 21:23 |
morganfainberg | not that i recommend it. | 21:23 |
morganfainberg | i could move it to tests if you think it's more appropriate | 21:24 |
morganfainberg | (no big deal) | 21:24 |
bknudson | I don't want someone to think they should use it if it's not recommended. | 21:24 |
morganfainberg | actually. i am going to argue that it should probably be in core until i get a fix upstream to dogpile.cache | 21:24 |
morganfainberg | if we want tempest or anything else to use the memory cache for testing | 21:25 |
dolphm | morganfainberg: i wonder if they avoid that in dogpile for performance? | 21:25 |
morganfainberg | having it in tests is sub-optimal | 21:25 |
dolphm | morganfainberg: would be an expensive default implementation | 21:25 |
morganfainberg | dolphm: memory backend is really not meant for production use, | 21:25 |
morganfainberg | dolphm: and since everything is a reference, if you don't copy the data structure, you end up with mutable cache | 21:26 |
dolphm | morganfainberg: not even for super light duty caching needs? | 21:26 |
morganfainberg | dolphm: nope. the _cache dict never is cleaned up | 21:26 |
*** xmltok has joined #openstack-dev | 21:26 | |
morganfainberg | dolphm: so unless you explicitly invalidate, invalid data builds up in there. | 21:26 |
morganfainberg | even if it's expired. | 21:26 |
gyee | ouch | 21:26 |
morganfainberg | yeah, thats why there is a massive warning everywhere in code and in docs against using the memory cacher by default, heck, it's why i made the no-op one that is configured as our default. you have to go out of your way to shoot yourself in the foot in a real deployment | 21:27 |
bknudson | morganfainberg: https://review.openstack.org/#/c/44211/ -- posted my comments... suggest reduce duplicated code. | 21:28 |
morganfainberg | bknudson: cool! I'll get on it | 21:28 |
morganfainberg | bknudson: thanks :) | 21:28 |
*** dachary has joined #openstack-dev | 21:29 | |
morganfainberg | dolphm / bknudson / gyee: so should the isolation proxy move to tests and we work w/ infra / devstack / whatever to use memcache when testing in tempest (eventually)? | 21:29 |
morganfainberg | or leave as is? | 21:29 |
bknudson | morganfainberg: I would prefer it's in tests if you don't recommend using it. | 21:29 |
morganfainberg | bknudson: done. | 21:29 |
gyee | morganfainberg, I am a big fan of testing reality | 21:29 |
gyee | so yeah | 21:29 |
bknudson | or maybe at least add a comment saying it's not recommended. | 21:29 |
dolphm | morganfainberg: happy to have it in tests, that would avoid the same complaints we've gotten about kvs drivers | 21:30 |
*** alexb_ has quit IRC | 21:31 | |
morganfainberg | bknudson: http://docs-draft.openstack.org/11/44211/1/check/gate-keystone-docs/4ec030d/doc/build/html/configuration.html#caching-layer | 21:31 |
morganfainberg | bknudson: i'll add another warning aorund the proxy as well. | 21:32 |
*** johnthetubaguy has quit IRC | 21:32 | |
*** xqueralt is now known as xqueralt-afk | 21:35 | |
*** jasdeepH has quit IRC | 21:35 | |
*** doude has joined #openstack-dev | 21:35 | |
*** dkranz has quit IRC | 21:35 | |
*** topol_ has joined #openstack-dev | 21:36 | |
*** topol has quit IRC | 21:36 | |
*** topol_ is now known as topol | 21:36 | |
*** jimfehlig has quit IRC | 21:37 | |
dstanek | hmmm...is there a Keystone test that uses multiple domain backends already? | 21:38 |
dolphm | dstanek: believe so... | 21:40 |
dolphm | henrynash: ^ | 21:40 |
dolphm | dstanek: keystone.domain1.conf and keystone.domain2.conf in test dir.. | 21:41 |
*** litong has quit IRC | 21:41 | |
*** kspear has quit IRC | 21:42 | |
*** amerine has joined #openstack-dev | 21:43 | |
*** mhu has quit IRC | 21:45 | |
*** mhu has joined #openstack-dev | 21:45 | |
dstanek | dolphm: thanks | 21:47 |
*** datsun180b has quit IRC | 21:50 | |
dolphm | henrynash: dstanek: looks like only ldap+ldap is tested? | 21:50 |
*** flaper87 is now known as flaper87|afk | 21:51 | |
*** kspear has joined #openstack-dev | 21:55 | |
*** henrynash has quit IRC | 21:56 | |
*** networkstatic has joined #openstack-dev | 21:57 | |
*** jtomasek has quit IRC | 21:57 | |
*** jasdeepH has joined #openstack-dev | 21:58 | |
*** jmontemayor_ has quit IRC | 22:00 | |
*** ydacheville_ has quit IRC | 22:02 | |
*** dstanek has quit IRC | 22:02 | |
*** alop_ has joined #openstack-dev | 22:03 | |
*** jvrbanac has quit IRC | 22:03 | |
*** dina_belova has joined #openstack-dev | 22:03 | |
*** mhu has quit IRC | 22:03 | |
*** mhu has joined #openstack-dev | 22:05 | |
*** alop has quit IRC | 22:05 | |
*** alop_ is now known as alop | 22:05 | |
*** dina_belova has quit IRC | 22:08 | |
*** Ryan_Lane has quit IRC | 22:08 | |
*** alexb_ has joined #openstack-dev | 22:10 | |
*** tstevenson has quit IRC | 22:10 | |
*** donaldh has quit IRC | 22:11 | |
*** burt has quit IRC | 22:11 | |
*** alop has quit IRC | 22:12 | |
*** kbringard has quit IRC | 22:12 | |
*** otherwiseguy has quit IRC | 22:14 | |
*** alop has joined #openstack-dev | 22:14 | |
*** Murali_Balcha has joined #openstack-dev | 22:14 | |
*** mmagr has quit IRC | 22:15 | |
*** prad has quit IRC | 22:17 | |
*** jecarey has quit IRC | 22:17 | |
*** portante is now known as portante|afk | 22:20 | |
*** jhesketh has joined #openstack-dev | 22:21 | |
*** jasdeepH has quit IRC | 22:21 | |
*** rods1 has joined #openstack-dev | 22:21 | |
*** jhesketh__ has quit IRC | 22:22 | |
*** galstrom is now known as galstrom_zzz | 22:23 | |
*** adalbas has quit IRC | 22:24 | |
*** jmontemayor has joined #openstack-dev | 22:25 | |
*** insanidade has quit IRC | 22:25 | |
*** fbo is now known as fbo_away | 22:25 | |
*** changbl has quit IRC | 22:26 | |
*** leif has joined #openstack-dev | 22:28 | |
*** leif is now known as Guest30677 | 22:28 | |
*** henrynash has joined #openstack-dev | 22:29 | |
henrynash | dophm: I thought I had a test that had ldap & sql…hold on | 22:29 |
*** nachi has joined #openstack-dev | 22:30 | |
*** eglynn has quit IRC | 22:31 | |
*** Guest29767 has quit IRC | 22:32 | |
henrynash | dolphm: yes, MultiLDAPandSQLIdentity in test_baclend_ldap has both sql and ldap domains | 22:32 |
*** rnirmal has quit IRC | 22:33 | |
*** litong has joined #openstack-dev | 22:33 | |
henrynash | dstanek: ^ | 22:34 |
morganfainberg | bknudson: https://review.openstack.org/#/c/44211/ cleaned up and duplicated code reduced. (when you have a moment) | 22:36 |
*** adalbas has joined #openstack-dev | 22:36 | |
gyee | morganfainberg, I like the description | 22:36 |
*** kbrierly has quit IRC | 22:37 | |
morganfainberg | gyee: hehe, i tried to be descriptive | 22:37 |
*** alop has quit IRC | 22:40 | |
morganfainberg | gyee: hopefully that gets the point across, and people don't try and use it. | 22:40 |
*** rcleere has quit IRC | 22:40 | |
*** edmund has quit IRC | 22:41 | |
*** thedodd has quit IRC | 22:41 | |
gyee | morganfainberg, yeah, unless you can animate the warning in the rst file :) | 22:42 |
morganfainberg | gyee hmm, animated rst, we need this! | 22:42 |
*** FunnyLookinHat has quit IRC | 22:43 | |
*** topol has quit IRC | 22:43 | |
*** jbresnah has joined #openstack-dev | 22:44 | |
*** gmurphy has joined #openstack-dev | 22:44 | |
*** neelashah has quit IRC | 22:47 | |
*** dstanek_ has joined #openstack-dev | 22:48 | |
*** radsy has joined #openstack-dev | 22:50 | |
*** pabelanger_ has quit IRC | 22:53 | |
*** pabelanger has joined #openstack-dev | 22:53 | |
*** gordc has quit IRC | 22:54 | |
*** nati_ueno has joined #openstack-dev | 22:55 | |
*** jdennis1 has quit IRC | 22:57 | |
*** Ryan_Lane has joined #openstack-dev | 22:57 | |
*** jmontemayor has quit IRC | 23:00 | |
*** mlavalle has quit IRC | 23:01 | |
*** dstanek_ is now known as dstanek | 23:01 | |
*** Tross has joined #openstack-dev | 23:03 | |
*** pmathews1 has quit IRC | 23:03 | |
*** jhesketh has quit IRC | 23:03 | |
*** dina_belova has joined #openstack-dev | 23:04 | |
nachi | morganfainberg:hey | 23:05 |
dolphm | morganfainberg: all 4 of those methods should be one liners now ;) | 23:08 |
*** henrynash_ has joined #openstack-dev | 23:09 | |
*** dina_belova has quit IRC | 23:09 | |
*** henrynash has quit IRC | 23:10 | |
*** henrynash_ is now known as henrynash | 23:10 | |
*** hemna is now known as hemnafk | 23:12 | |
*** sarob has quit IRC | 23:14 | |
*** sarob has joined #openstack-dev | 23:14 | |
*** sarob has quit IRC | 23:18 | |
*** nati_ueno has quit IRC | 23:19 | |
*** dims has quit IRC | 23:19 | |
*** carl_baldwin has quit IRC | 23:20 | |
morganfainberg | dolphm: all four what? | 23:23 |
morganfainberg | nachi: hi | 23:23 |
morganfainberg | dolphm: oh the cache methods on the proxy :P | 23:24 |
nachi | morganfainberg: I had a question on one of your review comments. I replied on the review. https://review.openstack.org/#/c/40036/10/keystone/auth/plugins/signature.py | 23:24 |
nachi | sorry incorrect file | 23:24 |
morganfainberg | dolphm: crud, you're right. | 23:24 |
morganfainberg | dolphm: *facepalm* I should have seen that. | 23:25 |
nachi | morganfainberg:https://review.openstack.org/#/c/40036/10/keystone/auth/utils.py | 23:25 |
*** Dr_Who has joined #openstack-dev | 23:25 | |
*** Dr_Who has joined #openstack-dev | 23:25 | |
morganfainberg | nachi: well, ideally you shouldn't instantiate a new manager on every call | 23:26 |
morganfainberg | nachi: the @dependency.requires takes care of providing the right manager on your local object. so you can do self.token_api.<method> for example | 23:27 |
morganfainberg | nachi: the way you' | 23:27 |
morganfainberg | re structured now, every time you need to get the identity_api, you instantiate a manager. | 23:27 |
*** jhesketh_ has joined #openstack-dev | 23:27 | |
morganfainberg | nachi: you might be able to do this as a class and all @classmethod s | 23:28 |
nachi | ok. | 23:28 |
dolphm | nachi: why does this start at patchset 5? where's 1-4? | 23:29 |
nachi | dolphm: i had in draft review | 23:29 |
*** otherwiseguy has joined #openstack-dev | 23:29 | |
dolphm | nachi: oh, interesting | 23:29 |
morganfainberg | nachi: i just think you should avoid the overhead of instantiating the manager every time you do use these functions. from what i've seen this would be a lot of new manager objects since the plugins use it. | 23:29 |
morganfainberg | dolphm: draft reviews are strange :P WIP is more friendly. | 23:30 |
morganfainberg | drafts are hiddent from anyone that isn't an explicit reviewer. | 23:30 |
dolphm | morganfainberg: ++ | 23:30 |
*** huats has quit IRC | 23:30 | |
morganfainberg | s/plugins/auth plugins | 23:30 |
dolphm | morganfainberg: did some identity_api -> assignment_api refactoring for project crud methods, and applied @notifications to the result https://review.openstack.org/#/c/43340/ | 23:31 |
nachi | morganfainberg: i will update the review | 23:31 |
*** dims has joined #openstack-dev | 23:32 | |
morganfainberg | dolphm: ah yah some of that needed cleanup. | 23:33 |
morganfainberg | dolphm: nice. | 23:33 |
dolphm | morganfainberg: a fraction of it | 23:33 |
morganfainberg | dolphm: not adding to domains while you're in there? | 23:33 |
*** jamiem has quit IRC | 23:34 | |
morganfainberg | or going to have ldbragst do that | 23:34 |
*** nachi has left #openstack-dev | 23:34 | |
*** sushils has quit IRC | 23:34 | |
morganfainberg | notifier on domains that is. | 23:34 |
*** huats has joined #openstack-dev | 23:34 | |
*** huats has joined #openstack-dev | 23:34 | |
*** jamiem has joined #openstack-dev | 23:35 | |
dstanek | dolphm: there is a test class in test_backend.py that isn't picked up by tox because of the class name :-( | 23:37 |
dstanek | errrr....or maybe i'm reading it wrong | 23:37 |
morganfainberg | dolphm: changes look good in that review. that should be a win to get notifications that projects have gone bye-bye. | 23:38 |
*** ydacheville has joined #openstack-dev | 23:39 | |
* rootard is trying really hard to find documentation about ceph+kvm interaction. AFAICT my instance is being trying to connect to ceph but has auth_supported=none when it should be auth_supported=cephx. No matter what I set in the virsh secret list, it seems to always use auth_supported=none. Any tips? | 23:42 | |
dolphm | morganfainberg: yay! | 23:42 |
dolphm | morganfainberg: this will kill our last 6-digit bug :D | 23:42 |
morganfainberg | dolphm: w00t! | 23:42 |
dolphm | morganfainberg: that's a complete lie * | 23:43 |
dolphm | morganfainberg: this will kill our last high priority 6-digit bug :D | 23:43 |
morganfainberg | dolphm: hehe | 23:43 |
morganfainberg | dolphm: still cause for celebration | 23:44 |
*** sarob has joined #openstack-dev | 23:45 | |
*** jasdeepH has joined #openstack-dev | 23:47 | |
*** jayg is now known as jayg|g0n3 | 23:47 | |
*** sarob_ has joined #openstack-dev | 23:48 | |
*** jamiem has quit IRC | 23:48 | |
*** jbresnah has quit IRC | 23:49 | |
*** jhesketh_ has quit IRC | 23:51 | |
*** Dr_Who has quit IRC | 23:52 | |
*** jhesketh_ has joined #openstack-dev | 23:52 | |
dolphm | gyee: bknudson: can we knock out another bp today? :D https://review.openstack.org/#/c/43340/ | 23:52 |
dolphm | henrynash: ^ | 23:52 |
*** sarob has quit IRC | 23:52 | |
*** pixelbeat has joined #openstack-dev | 23:52 | |
morganfainberg | dolphm: i don't think there is much controversial about that one. (was much easier to review) | 23:54 |
henrynash | dolphm: will look in 15 mins or so…just getting rear to post another filtering patch, with changes in response to latest comments | 23:55 |
morganfainberg | dolphm: kinda nice to have the gate less swamped than i'm sure next week is going to look. | 23:55 |
roaet | Is it normal to put the bug fix # in the code as a comment or just leave it to the commit? | 23:55 |
*** markwash has quit IRC | 23:55 | |
dolphm | morganfainberg: i think it's been swamped mostly because of transient failures + reverify :( | 23:56 |
morganfainberg | dolphm: yeah, those have been rough. | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!