| morganfainberg | mostly because caching introduces odd interactions sometimes - i don't want to double our test times. | 00:00 |
|---|---|---|
| *** glucas has joined #openstack-dev | 00:00 | |
| bknudson | it doesn't need to double the test time | 00:00 |
| bknudson | as long as they aren't keystoneclient tests ... those are the slow ones, I assume. | 00:00 |
| bknudson | since they start up a server for every test. | 00:00 |
| morganfainberg | bknudson, hm. | 00:01 |
| morganfainberg | bknudson, i'll benchmark it and see how bad it is. | 00:02 |
| *** che-arne has quit IRC | 00:02 | |
| *** galstrom_zzz is now known as galstrom | 00:03 | |
| morganfainberg | bknudson, if it doesn't significantly increase times i'll propose a fix that runs it w/o caching and with. | 00:03 |
| bknudson | morganfainberg: the tests just need a huge refactoring. | 00:04 |
| morganfainberg | bknudson, yes they do | 00:04 |
| bknudson | morganfainberg: we've test_backend which is the kitchen sink | 00:04 |
| morganfainberg | bknudson, actually maybe i'll hold off till we extract stuff into tempest. | 00:04 |
| bknudson | and test_keystoneclient is another kitchen sink | 00:04 |
| bknudson | morganfainberg: we're not going to extract stuff into tempest. | 00:04 |
| morganfainberg | bknudson, oh we're not? | 00:04 |
| morganfainberg | darn | 00:04 |
| morganfainberg | ok | 00:04 |
| bknudson | they don't want our keystoneclient tests since they don't want python api tests. | 00:04 |
| morganfainberg | oh. | 00:05 |
| bknudson | so what we'll get in tempest is nothing like the keystoneclient tests we have now. | 00:05 |
| morganfainberg | good ot knpw | 00:05 |
| morganfainberg | know* | 00:05 |
| bknudson | for client tests, we could probably get "scenario" tests in | 00:05 |
| bknudson | but these are like "do a bunch of operations like an application would' | 00:06 |
| bknudson | not tests for the keystoneclient per se | 00:06 |
| morganfainberg | well test_backend is mostly just classes we could pull apart and into subdirectories... (logically named and all) do we have a "work-plan" on this stuff yet? | 00:06 |
| morganfainberg | e.g. what the test structure should look like? | 00:07 |
| bknudson | work-plans? | 00:07 |
| bknudson | I'm lucky if I put stuff to do in notepad. | 00:07 |
| morganfainberg | lol | 00:07 |
| *** rods1 has quit IRC | 00:07 | |
| morganfainberg | maybe we should wait till M3 to "shuffle" tests | 00:07 |
| morganfainberg | makes landing api-impacting stuff ... less infuriating... | 00:08 |
| morganfainberg | rebase, rebase, rebase, rebase | 00:08 |
| bknudson | or, we could catch up on reviews. | 00:08 |
| morganfainberg | true | 00:08 |
| morganfainberg | perhaps a little of column a, and a lot of column b | 00:08 |
| morganfainberg | reminds me, i need to poke at fabio | 00:09 |
| *** xmltok has quit IRC | 00:10 | |
| *** kgriffs is now known as kgriffs_afk | 00:10 | |
| *** jhesketh has joined #openstack-dev | 00:10 | |
| *** mgagne has quit IRC | 00:10 | |
| *** otherwiseguy has joined #openstack-dev | 00:15 | |
| dstanek | bknudson: morganfainberg: will we be keeping the test_backend stuff then? | 00:20 |
| *** DennyZhang has joined #openstack-dev | 00:20 | |
| bknudson | dstanek: as far as I know there's no reason to lose the test_backend stuff. | 00:20 |
| dstanek | bknudson: someone mentioned that we wouldn't need them once tempest has more REST API coverage | 00:21 |
| dstanek | i need to update my testing etherpad | 00:21 |
| bknudson | tempest would have to do more than just more REST API coverage... | 00:22 |
| bknudson | tempest's REST API coverage is pretty comprehensive as it is. | 00:22 |
| *** galstrom is now known as galstrom_zzz | 00:22 | |
| dstanek | bknudson: when you have time https://etherpad.openstack.org/p/keystone-test-restructuring | 00:22 |
| bknudson | I think what tempest would need to do is test more of the backends (e.g., LDAP) | 00:22 |
| morganfainberg | dstanek, i think it should be broken up some. | 00:23 |
| *** MaxV has joined #openstack-dev | 00:23 | |
| morganfainberg | dstanek, instead of "test_backend" maybe assignment/test_<something> | 00:23 |
| dstanek | i have ideas for breaking up the functional tests, but i was under the impression that they'd be moving | 00:23 |
| morganfainberg | because right now you have assignment, identity, token, etc all in the same "test_backend" file | 00:24 |
| dstanek | morganfainberg: i'll update it with my original thoughts now | 00:24 |
| morganfainberg | it might be super awesome to break that up logically based upon the "entry point" being tested (e.g. delete_project is assignment, delete_user is identity, delete_domain is assingment even though it touches identity currently) | 00:25 |
| *** MaxV has quit IRC | 00:25 | |
| *** MaxV has joined #openstack-dev | 00:25 | |
| morganfainberg | dstanek, just spitballing ideas though. i might propose some patches if we have a good direciton | 00:25 |
| morganfainberg | dstanek, oh etherpad! | 00:25 |
| morganfainberg | dstanek, oh that looks good, yay something i can reference if i'm poking at tests shuffling | 00:28 |
| *** che-arne has joined #openstack-dev | 00:28 | |
| bknudson | is there a blueprint references this? | 00:28 |
| morganfainberg | bknudson, doesn't look like it | 00:28 |
| dstanek | bknudson: there was one from Jamie that i was going to use, but i can't find it | 00:29 |
| dstanek | should i just make a new one? | 00:29 |
| morganfainberg | dstanek, if you can't find it, i'd say yes new one | 00:29 |
| dstanek | morganfainberg: done | 00:29 |
| bknudson | if you're going to submit changes based on this then would be best to have a blueprint | 00:30 |
| bknudson | unless you were going to do it in 1 big commit | 00:30 |
| *** yjiang5 is now known as yjiang5_away | 00:31 | |
| dstanek | bknudson: i don't think i could get anyone to review one big commit | 00:31 |
| *** dave_tucker is now known as dave_tucker_zzz | 00:32 | |
| *** dims has quit IRC | 00:32 | |
| morganfainberg | dstanek, oh i think the way it'll need to work is pick a <subsystem> and <unit/whatever> and do that as a commit | 00:32 |
| morganfainberg | e.g. do unit/token | 00:32 |
| morganfainberg | then unit/identity | 00:32 |
| morganfainberg | etc etc | 00:32 |
| bknudson | are these new tests or moving things around? | 00:32 |
| morganfainberg | bknudson, moving. | 00:32 |
| *** akrivoka has quit IRC | 00:32 | |
| morganfainberg | at least at first. | 00:32 |
| bknudson | I think jamielennox|away did try to do this once | 00:33 |
| bknudson | move stuff around. | 00:33 |
| morganfainberg | bknudson, he did it in keystoneclient soem | 00:33 |
| morganfainberg | was hard to get reviews on because it was a lot of change | 00:33 |
| morganfainberg | not sure if he also tried it in keystone proper | 00:33 |
| *** dave_tucker_zzz is now known as dave_tucker | 00:34 | |
| bknudson | morganfainberg: dstanek: https://review.openstack.org/#/c/28773/ | 00:34 |
| bknudson | https://review.openstack.org/#/c/28770/ | 00:35 |
| morganfainberg | ah | 00:35 |
| morganfainberg | so he did | 00:35 |
| bknudson | https://review.openstack.org/#/c/28387/ | 00:35 |
| *** jergerber has quit IRC | 00:35 | |
| bknudson | +2365, -2022 | 00:35 |
| morganfainberg | ah yes | 00:35 |
| morganfainberg | well, i think it's time to revisit this | 00:36 |
| bknudson | we've got momentum | 00:36 |
| morganfainberg | yep | 00:36 |
| *** DennyZhang has quit IRC | 00:36 | |
| *** garyk has joined #openstack-dev | 00:36 | |
| morganfainberg | dstanek, unit/test_assignment.py or unit/assignment/test_<thing> | 00:37 |
| morganfainberg | ? | 00:37 |
| morganfainberg | or unit/v2/test_assignment.py | 00:37 |
| morganfainberg | or unit/assignment/test_v2.py | 00:37 |
| morganfainberg | bknudson, ^ | 00:38 |
| morganfainberg | i think maybe unit/v2/test_assignment.py is the cleanest | 00:38 |
| *** garyk has quit IRC | 00:38 | |
| morganfainberg | then unit/v3/test_*.py | 00:38 |
| bknudson | maybe this is the reason the tests weren't put into separate directories | 00:38 |
| bknudson | couldn't figure out the order | 00:38 |
| dstanek | morganfainberg: i don't know that i would bread up unit tests into v2/v3 | 00:39 |
| morganfainberg | eh, we have a reference doc we'll decide on and reference when everyone else comes back ;) | 00:39 |
| bknudson | the backends don't have a version | 00:39 |
| bknudson | only the controllers | 00:39 |
| dstanek | i personally like them named somewhat close to the module name that it's testing | 00:39 |
| morganfainberg | bknudson, ah yes | 00:39 |
| bknudson | might be useful to have unit/backend/assignment | 00:39 |
| bknudson | unit/controller/assignment | 00:40 |
| morganfainberg | bknudson, ok | 00:40 |
| bknudson | unit/service/assignment | 00:40 |
| dstanek | morganfainberg: comes back from where? | 00:40 |
| bknudson | oops, we don't have a service! | 00:40 |
| morganfainberg | dstanek, holiday breaks ;) | 00:40 |
| dstanek | morganfainberg: ah, right; i keep forgetting | 00:40 |
| dstanek | i'll be hanging around here | 00:40 |
| morganfainberg | bknudson, controllers are usually in the "functional" category, no? | 00:40 |
| bknudson | we can't have unit tests for controllers? | 00:41 |
| morganfainberg | or do we actually _unit_ test them as well? | 00:41 |
| bknudson | maybe that's why the tests take so long! | 00:41 |
| morganfainberg | lol | 00:41 |
| morganfainberg | probably. | 00:41 |
| morganfainberg | i think controllers are mostly tested with RESTful testcase | 00:41 |
| morganfainberg | i'm good with either unit/assignment/test_<backend|controller|etc>.py or unit/(backend|controller|etc)/test_assignment.py | 00:43 |
| morganfainberg | i lean towards the former, so all tests for a "subsystem" are in one directory | 00:43 |
| morganfainberg | just the way my brain works | 00:43 |
| bknudson | we need a "service" layer to split the connection between the controllers and the backends. | 00:44 |
| bknudson | controller -> backend only makes sense if you're just doing CRUD | 00:44 |
| dstanek | morganfainberg: the way you have it in the doc is the way i was thinking of it | 00:44 |
| morganfainberg | bknudson, i think we had this discussion and ayoung was against it. or that the manager was the "service layer" | 00:44 |
| dstanek | unit/assignment/test_* | 00:44 |
| morganfainberg | dstanek, ok i like that | 00:44 |
| *** dims has joined #openstack-dev | 00:45 | |
| morganfainberg | bknudson, actually i like it a lot because the new "pivot" (whatever it is called, manager, etc) would be where i stick caching | 00:45 |
| dstanek | morganfainberg: then i think that would be as deep as the directories go | 00:45 |
| *** DennyZhang has joined #openstack-dev | 00:45 | |
| dstanek | so we'd have unit/assignment/test_backend_sql.py or something like that | 00:45 |
| morganfainberg | bknudson, so controller (request parsed to something usable) -> service layer (buisness logic) -> pivot (caching / driver loader) | 00:46 |
| morganfainberg | rather than what we have which collapses service and pivot into "manager" now | 00:46 |
| bknudson | dstanek: why have test_backend and test_backend_sql and not test_backend/sql | 00:46 |
| bknudson | the filesystem allows us to do nesting. | 00:47 |
| morganfainberg | bknudson, i think we don't need to get too deep of a structure, unless we have like > 5 backends to test, i'm not too worried | 00:47 |
| bknudson | although python has this odd need to put lots of parts in one file. | 00:47 |
| morganfainberg | bknudson, python sure isn't java (been working on some java code for a pycharm plugin to run flake8 + OS hacking - "live") | 00:48 |
| bknudson | so why not just put sql, kvs, etc test classes in assignment/test_backend | 00:48 |
| morganfainberg | bknudson, i'm actually ok with that. | 00:48 |
| *** angdraug has quit IRC | 00:49 | |
| bknudson | the test_assignment_sql tests should be really small since it's just test_assignment with a few skips or something. | 00:49 |
| dstanek | depends on how big the files get - i really hate to have 1000s of lines of only semi related code in one file | 00:49 |
| dstanek | plus part of what i think we should be doing is splitting up the classes into moar classes | 00:49 |
| dstanek | see the "Test Organization Around Setup" section | 00:50 |
| morganfainberg | if that is the case, unit/assignment/backend/test_(sql|kvs|etc) | 00:50 |
| morganfainberg | so the rule is if there is 1 "thing" you make it test_thing, if there are "things"(plural) it is thing/test_thingtype.py | 00:51 |
| dstanek | morganfainberg: if we are going that far we might as well say the the structure should mimic the production code's structure | 00:51 |
| morganfainberg | dstanek, ok | 00:52 |
| morganfainberg | i don't mind that actually | 00:52 |
| bknudson | that would make it too easy to find the code under test. | 00:52 |
| dstanek | we did that at my last job and it made the tests easy to find | 00:52 |
| bknudson | we want keystone development to be a challenge | 00:52 |
| dstanek | bknudson: you're right - random names! | 00:52 |
| morganfainberg | bknudson, sha256 hashes | 00:52 |
| bknudson | start with A, B, C | 00:52 |
| morganfainberg | bknudson, dstanek, like what i have in the doc now? | 00:53 |
| dstanek | morganfainberg: yes, we may need some test specific files in there like core.py or base.py for common stuff | 00:54 |
| *** herndon has quit IRC | 00:55 | |
| morganfainberg | sure | 00:55 |
| morganfainberg | i think _base? | 00:55 |
| morganfainberg | erm base.py | 00:55 |
| bknudson | I thought we called it core.py? | 00:55 |
| *** radsy has quit IRC | 00:55 | |
| morganfainberg | bknudson, common code for tests? | 00:55 |
| morganfainberg | not testing the "common" part of a subsystem | 00:55 |
| bknudson | is base.py a base class or something? | 00:56 |
| morganfainberg | bknudson, dstanek, maybe it's "fixtures" we're looking for | 00:56 |
| dstanek | bknudson: we use core mostly for stuff that belongs in an __init__ | 00:56 |
| morganfainberg | subsystem specific fixtures? | 00:56 |
| *** sarob has quit IRC | 00:56 | |
| morganfainberg | because most "common" test code goes in tests.core | 00:57 |
| dstanek | morganfainberg: i can imagine base test classes too | 00:57 |
| *** sarob has joined #openstack-dev | 00:57 | |
| morganfainberg | dstanek, hm, oh "assignment_base" | 00:57 |
| morganfainberg | ok base sounds most correct. | 00:57 |
| dstanek | or up in the functional section i added a test_common, but i don't know that it's the right name | 00:57 |
| bknudson | ok, so first question is where does test_auth_plugin.py go ? | 00:58 |
| morganfainberg | as long as it's consistent and makes some semblance of sense, i don't really care what it's called | 00:58 |
| bknudson | next question is where does test_auth.py go | 00:58 |
| bknudson | and so forth | 00:58 |
| morganfainberg | test_auth is RESTful test case right? | 00:59 |
| morganfainberg | *checks* | 00:59 |
| morganfainberg | oh | 00:59 |
| morganfainberg | hrm | 00:59 |
| morganfainberg | unit/auth/ | 00:59 |
| bknudson | doesn't look RESTful to me | 00:59 |
| morganfainberg | ? | 00:59 |
| bknudson | test_v3_* are the restful ones | 00:59 |
| morganfainberg | ah yes | 00:59 |
| bknudson | unit.auth.test_auth_plugin and unit.auth.test_auth? | 01:00 |
| bknudson | or are they just under unit/? | 01:00 |
| bknudson | unit/test_auth.py , unit/test_auth_plugin.py | 01:00 |
| *** gongysh has joined #openstack-dev | 01:00 | |
| morganfainberg | well, we have keystone.auth | 01:00 |
| morganfainberg | i'm inclined to break up test_auth some | 01:01 |
| morganfainberg | but unit/auth | 01:01 |
| bknudson | ok, to match the source structure. | 01:01 |
| *** reed has quit IRC | 01:01 | |
| dstanek | at first glance i would say that it's not a unit test | 01:01 |
| morganfainberg | so it'd be keystone.test.unit.auth.<stuff> | 01:01 |
| morganfainberg | yep | 01:01 |
| *** PaulM1 has joined #openstack-dev | 01:01 | |
| *** sarob has quit IRC | 01:01 | |
| bknudson | test_auth_plugin is going through the controllers | 01:01 |
| dstanek | it's not really testing keystone.auth is it? it looks more like a functional test since it is calling controllers | 01:02 |
| morganfainberg | dstanek, it does look functional | 01:02 |
| bknudson | ok, functional/test_auth_plugin.py | 01:02 |
| morganfainberg | yes that i could see | 01:03 |
| bknudson | function/test_auth.py | 01:03 |
| morganfainberg | dstanek, i look forward to the day all fixtures are in a consistent place. | 01:03 |
| dstanek | functional/auth/test_plugin? | 01:03 |
| bknudson | or funcational/auth/test_plugin.py & test_auth.py or whatever | 01:03 |
| *** PaulM has quit IRC | 01:03 | |
| morganfainberg | that are really fixtures. | 01:03 |
| morganfainberg | not... | 01:03 |
| morganfainberg | stuck on the class cause we can | 01:03 |
| morganfainberg | bknudson, functional/auth/test_(plugin|auth) | 01:04 |
| morganfainberg | since it mirrors our code-tree | 01:04 |
| morganfainberg | that way(ish) | 01:04 |
| dstanek | morganfainberg: good, then i have some patches for you! | 01:04 |
| *** DennyZhang has quit IRC | 01:04 | |
| morganfainberg | dstanek, i'm slowly going through your current ones (the ones bknudson +2'd already) | 01:04 |
| morganfainberg | dstanek, one of them went in already | 01:05 |
| dstanek | i saw that there were a few changes i need to make | 01:05 |
| morganfainberg | dstanek, yeah and one jenkins is unhappy about | 01:05 |
| dstanek | i've been trying to do code reviews everyday, but there is just so many of them | 01:05 |
| *** sarob has joined #openstack-dev | 01:05 | |
| morganfainberg | dstanek, honestly i do them in batches | 01:06 |
| morganfainberg | dstanek, take ½ a day and do reviews (or a whole day) | 01:06 |
| morganfainberg | next day, focus on code... or reviews... | 01:06 |
| morganfainberg | following day do "company specific work"... or reviews (see a pattern?) | 01:06 |
| morganfainberg | :P | 01:06 |
| dstanek | i'll have to come up with a workflow that works for me...just so much to do and so little time | 01:07 |
| morganfainberg | dstanek yay! no more FD leaks! | 01:07 |
| dstanek | morganfainberg: there are still some :-) | 01:07 |
| dstanek | test_keystoneclient_sql.py seems to really leak and i haven't had time to look into it | 01:08 |
| morganfainberg | dstanek, it's also why my code patchsets tend to be "bursty" - 4 or 5 up in quick sucession | 01:08 |
| morganfainberg | dstanek, my guess on tesT_keystoneclient_sql is the reaplcement SQL backend isn't getting closed down properly | 01:08 |
| dstanek | i had to fix those leaks and the memory problem because the tests wouldn't run until i did | 01:08 |
| morganfainberg | so you leak on each new/clean db | 01:08 |
| *** colinmcnamara has quit IRC | 01:10 | |
| *** rwsu has quit IRC | 01:11 | |
| morganfainberg | dstanek, self.greenthread could evaluate to boolean false and still need killing? | 01:11 |
| morganfainberg | dstanek, *blink* | 01:11 |
| *** morazi has quit IRC | 01:11 | |
| morganfainberg | not that i doubt you, just... huh | 01:11 |
| dstanek | morganfainberg: yes, i had to talk to the eventlet guys to figure it out | 01:11 |
| *** rods1 has joined #openstack-dev | 01:12 | |
| morganfainberg | that's obnoxious | 01:12 |
| morganfainberg | got the readers digest version of "wtf"? handy? | 01:12 |
| dstanek | it's truthy value indicates if it's already running | 01:12 |
| morganfainberg | oh | 01:12 |
| morganfainberg | i.. sure | 01:12 |
| morganfainberg | gee .running sounds like a better approach though | 01:12 |
| dstanek | so we had tests calling start() and finishing before the scheduled eventlet started | 01:12 |
| dstanek | so it would still start in the background | 01:13 |
| morganfainberg | but i'm not an eventlet developer so i guess i have little say in this | 01:13 |
| dstanek | :-) it's definitely not obvious | 01:13 |
| bknudson | how did our tests work if eventlet didn't start? | 01:13 |
| morganfainberg | bknudson, not everything needs the eventlet server (another flaw) | 01:14 |
| morganfainberg | it might be started in erroneous cases | 01:14 |
| dstanek | bknudson: it's the problem i describe in restructruing based on setup - we have some test that don't use the server, but it is setup automatically because it's in the same class | 01:14 |
| dstanek | bknudson: i also worry that if our code is a little faster tests will randomly fail because they execute before the server actually starts | 01:15 |
| bknudson | put a sleep() in there. | 01:15 |
| bknudson | can we have a callback for when the server's ready? | 01:15 |
| *** rwsu has joined #openstack-dev | 01:16 | |
| *** rnirmal has joined #openstack-dev | 01:16 | |
| morganfainberg | bknudson, i'm sure we can. but that doesn't solve the "need to issue kill() if greenthread != None" | 01:16 |
| *** flashgordon is now known as jog0 | 01:16 | |
| *** jeblair is now known as corvus | 01:17 | |
| *** cpallares has joined #openstack-dev | 01:17 | |
| bknudson | if we waited for the callback then the test for "if greenthread" would be accurate? | 01:17 |
| dstanek | the way i have it will kill it properly now | 01:18 |
| morganfainberg | bknudson, sure, but do we want to block tests waiting on calling kill? | 01:18 |
| *** cpallares has quit IRC | 01:18 | |
| dstanek | you can kill the thread before the server starts - it'll just never start | 01:18 |
| morganfainberg | bknudson, or just move on if we're not using eventlet. | 01:18 |
| morganfainberg | in that case. | 01:18 |
| bknudson | if we're not using eventlet then don't start the server to begin with | 01:19 |
| dstanek | bknudson: ++ | 01:19 |
| morganfainberg | bknudson, ++ i think part of the restructure will help with that | 01:19 |
| morganfainberg | don't have one massive heirarchy that does "OMG START ALL THE THNIGS" | 01:19 |
| morganfainberg | in all cases | 01:19 |
| bknudson | if we are using eventlet then wait for the server to start before testing | 01:19 |
| morganfainberg | bknudson, ++ totally for that | 01:20 |
| morganfainberg | but i think we ned to restructure this to get there | 01:20 |
| morganfainberg | well, thats the best approach rather than restructure to restructure again | 01:20 |
| dstanek | we're not at that point.. | 01:20 |
| *** DennyZhang has joined #openstack-dev | 01:21 | |
| *** rwsu has quit IRC | 01:21 | |
| *** xarses has quit IRC | 01:21 | |
| dstanek | morganfainberg: i started to pull out the test cases that don't need to server, but i don't entirely like it because there are not 2 classes for every client version that i'm testing | 01:21 |
| dstanek | i'm still planning on submitting it and you guys can tell me if i am crazy | 01:22 |
| morganfainberg | dstanek, | 01:22 |
| morganfainberg | .needs_eventlet_server | 01:22 |
| morganfainberg | if .needs_eventlet_server: start | 01:22 |
| morganfainberg | ? | 01:22 |
| *** krotscheck has quit IRC | 01:23 | |
| morganfainberg | dstanek, @start_eventlet | 01:23 |
| *** pberis has quit IRC | 01:23 | |
| morganfainberg | ? | 01:23 |
| *** mlavalle has quit IRC | 01:23 | |
| bknudson | @requires_fixture(eventlet_server) | 01:24 |
| morganfainberg | bknudson, ++ | 01:24 |
| dstanek | i would have to do non-obvious stuff to pull that off because it's a setup fixture | 01:24 |
| dstanek | bknudson: that i think i could do | 01:24 |
| bknudson | does fixtures have that already? | 01:24 |
| dstanek | but the vast majority of the tests use the server | 01:24 |
| morganfainberg | dstanek, metaclass and @exclude_fixture(eventlet_server) ? [don't hate me] | 01:25 |
| morganfainberg | nah, ^ that is a bad idea | 01:26 |
| dstanek | morganfainberg: too late - i hate you now | 01:26 |
| morganfainberg | dstanek, lol | 01:26 |
| bknudson | morganfainberg: I'm with dstanek. | 01:26 |
| morganfainberg | crap. | 01:26 |
| morganfainberg | the @requires_fixture seems like a good approach though | 01:27 |
| morganfainberg | even if _most_ require it. | 01:27 |
| dstanek | morganfainberg, bknudson: i'll that a go then | 01:27 |
| bknudson | at least it will be obvious that some tests need the fixture and some don't... | 01:28 |
| morganfainberg | yes. | 01:28 |
| bknudson | so then we'll know what to split out | 01:28 |
| morganfainberg | i've +A the .kill, make tests not leak FDs, following patchsets can make it better | 01:29 |
| dstanek | fixing the rest of my crap now | 01:29 |
| dstanek | beyond the ones i've already submitted i have 2 or 3 more reviews coming depending on how i break up my current work | 01:30 |
| bknudson | dstanek: these latest ones were really easy to review. | 01:30 |
| morganfainberg | ++ | 01:31 |
| *** sarob has quit IRC | 01:31 | |
| *** jasdeepH has quit IRC | 01:32 | |
| morganfainberg | bknudson, as much as havana's code in keystone improved from essex, folsom, and grizzly, Icehouse is seeming like it's going to be a massive improvement | 01:34 |
| morganfainberg | over havana, code structure and all | 01:34 |
| *** jcooley_ has quit IRC | 01:34 | |
| *** changlp has quit IRC | 01:35 | |
| dstanek | bknudson: what do you mean in your comment here: https://review.openstack.org/#/c/63460/1/keystone/tests/test_keystoneclient.py | 01:35 |
| *** aeperezt has quit IRC | 01:35 | |
| *** MaxV has quit IRC | 01:37 | |
| bknudson | dstanek: rather than add code to tearDown(), use self.addCleanup() | 01:37 |
| lifeless | +100000 | 01:37 |
| dstanek | bknudson: i didn't realize that TestCases had an addCleanup() | 01:38 |
| bknudson | dstanek: you're the one who says to do this ... https://etherpad.openstack.org/p/keystone-test-restructuring | 01:38 |
| *** melwitt has quit IRC | 01:38 | |
| *** garyk has joined #openstack-dev | 01:38 | |
| bknudson | dstanek: or didn't you write that? | 01:38 |
| *** PaulM1 has quit IRC | 01:38 | |
| dstanek | that's in a fixture that i was talking about | 01:38 |
| *** tmclaugh[work] has quit IRC | 01:39 | |
| dstanek | no i wrote it | 01:39 |
| bknudson | maybe lifeless snuck into the etherpad. | 01:39 |
| *** DennyZhang has quit IRC | 01:39 | |
| lifeless | I don't think | 01:39 |
| lifeless | I don't think so | 01:39 |
| lifeless | but yeah, we added addCleanup to upstream unittest in 2.7 | 01:39 |
| lifeless | the design came out of bzr | 01:39 |
| dstanek | hmm...wait - i meant that to be a fixture | 01:39 |
| bknudson | dstanek: the etherpad has class C(tests.TestCase) -- and it's not a fixture! | 01:40 |
| bknudson | lol | 01:40 |
| bknudson | turns out it's a good idea anyways | 01:40 |
| *** garyk has quit IRC | 01:40 | |
| dstanek | lifeless: does testtools provide an addCleanup on TestCase? | 01:40 |
| *** dripton has quit IRC | 01:40 | |
| lifeless | dstanek: yup. | 01:40 |
| lifeless | dstanek: since forever | 01:40 |
| dstanek | lifeless: perfect, thanks | 01:41 |
| *** rnirmal has quit IRC | 01:41 | |
| *** DennyZhang has joined #openstack-dev | 01:44 | |
| *** sarob has joined #openstack-dev | 01:45 | |
| *** jcooley_ has joined #openstack-dev | 01:46 | |
| *** gongysh has quit IRC | 01:47 | |
| *** DennyZhang has quit IRC | 01:47 | |
| *** DennyZhang has joined #openstack-dev | 01:49 | |
| morganfainberg | lifeless did sneak into the etherpad! at least in spirit | 01:49 |
| *** pixelb has quit IRC | 01:50 | |
| lifeless | the lifeless spirit compells you | 01:51 |
| *** dripton has joined #openstack-dev | 01:51 | |
| morganfainberg | lifeless, oh sweet, i can blame you for everything now | 01:52 |
| *** vladikr has joined #openstack-dev | 01:52 | |
| *** buzztroll has quit IRC | 01:54 | |
| *** torgomatic has left #openstack-dev | 01:54 | |
| *** arnaud___ has joined #openstack-dev | 02:00 | |
| marun | lifeless: are you aware of whether any of the core apps implement even optimistic locking? | 02:01 |
| marun | lifeless: I'm under the impression that closely spaced updates will result in silent overwrites | 02:01 |
| *** krotscheck has joined #openstack-dev | 02:02 | |
| lifeless | marun: I'm fairly certain that none of OpenStack implements locking, because locking is (rightly) considered a significant burden:) | 02:02 |
| marun | lifeless: er | 02:02 |
| lifeless | marun: however with a RESTful API, collections can be really quite safe w/o locking | 02:03 |
| marun | lifeless: if you say so | 02:03 |
| lifeless | marun: that said I know that e.g. Nova used to depend on the DB for locking semantics | 02:03 |
| marun | lifeless: so the answer is, yes, closely spaced updates will silently overwrite | 02:03 |
| lifeless | marun: MySQL would lock ranges during requests | 02:03 |
| *** gongysh has joined #openstack-dev | 02:03 | |
| lifeless | marun: yes | 02:03 |
| marun | lifeless: ok, cool. Thank you for the confirmation. | 02:03 |
| lifeless | marun: I suspect that the heavy conductor usage and object passaround now has changed what locks implicitly happen | 02:04 |
| marun | lifeless: I'm looking at implementing row versioning to improve the reliability of agent notification. | 02:04 |
| marun | lifeless: currently there is no way of determining the order in which changes to the agent should be applied | 02:05 |
| *** kashyap has quit IRC | 02:05 | |
| *** xarses has joined #openstack-dev | 02:05 | |
| lifeless | marun: Did you consider making the changes associative? Or is the problem deletes? | 02:05 |
| marun | lifeless: I'm not sure what you mean by associative. The problem is definitely updates. | 02:06 |
| marun | lifeless: there's no way to authoritatively determine the order of successive network down/up or enable/disable dhcp on subnet events | 02:07 |
| lifeless | ok | 02:07 |
| lifeless | so yeah, classic delta approach issue | 02:07 |
| lifeless | why row versioning rather than a serial per message? | 02:07 |
| marun | lifeless: how would I determine the serial across processes? | 02:08 |
| marun | lifeless: row versioning seems the easy path. is there a drawback? | 02:08 |
| lifeless | I'm not sure | 02:09 |
| lifeless | just exploring | 02:09 |
| lifeless | how will you order between different rows | 02:09 |
| marun | lifeless: I couldn't see a good way of ensuring a monotonically increasing serial across processes (and potentially, hosts) without a separate service, and it seems much simpler to rely on the db. | 02:09 |
| marun | lifeless: ordering between different rows isn't important, | 02:10 |
| marun | lifeless: the order is only important for a given row | 02:10 |
| lifeless | marun: hmmm, I must be misunderstanding. | 02:10 |
| lifeless | marun: say you have two ports in one subnet | 02:10 |
| lifeless | A and B, neither of which exist at the same time. | 02:10 |
| lifeless | both get the same IP address | 02:10 |
| lifeless | sequence is delete A, add B with the IP A had. | 02:11 |
| lifeless | Processing the add of B without the delete of A seems bad. | 02:11 |
| marun | lifeless: good point :/ | 02:11 |
| lifeless | do we have a row in the db for each (agent,subnet) tuple? | 02:12 |
| marun | lifeless: I've been mainly worried about networks and subnets, which can't conflict like ip allocation | 02:12 |
| marun | lifeless: no, we only have for network/agent | 02:12 |
| lifeless | if we do, we could put a serial in that row, which would get you locking and coordination for those messages. | 02:12 |
| lifeless | oh, so we schedule at (network,agent) granularity? Probably good enough. | 02:13 |
| *** spzala has joined #openstack-dev | 02:13 | |
| marun | lifeless: hmmm | 02:14 |
| marun | lifeless: that would be complicated | 02:14 |
| *** colinmcnamara has joined #openstack-dev | 02:15 | |
| *** matsuhashi has joined #openstack-dev | 02:15 | |
| *** unacceptable is now known as amcrn | 02:16 | |
| marun | lifeless: the challenge is that sending notifications can't really occur in the same transaction as the update. but it might be reasonable to update the version of the subnet or network on port update and use the combined network/port version when determining ordering | 02:19 |
| marun | lifeless: scratch that, a per-agent serial could work | 02:20 |
| *** dave_tucker is now known as dave_tucker_zzz | 02:20 | |
| *** matsuhashi has quit IRC | 02:21 | |
| marun | lifeless: Thank you for the food for thought, though. Neutron really needs more rigor. | 02:22 |
| *** matsuhashi has joined #openstack-dev | 02:22 | |
| *** vladikr has quit IRC | 02:23 | |
| *** sdake has joined #openstack-dev | 02:23 | |
| *** mjfork has quit IRC | 02:24 | |
| *** rm_work is now known as rm_work|away | 02:25 | |
| lifeless | marun: you're welcome | 02:25 |
| *** ayoung-afk has quit IRC | 02:25 | |
| *** matsuhas_ has joined #openstack-dev | 02:25 | |
| lifeless | marun: anything I can do to help, I'm delighted to do ! | 02:25 |
| marun | lifeless: :) | 02:26 |
| *** matsuhashi has quit IRC | 02:27 | |
| *** jcooley_ has quit IRC | 02:27 | |
| *** jcooley_ has joined #openstack-dev | 02:27 | |
| *** matsuhas_ has quit IRC | 02:33 | |
| *** matsuhashi has joined #openstack-dev | 02:34 | |
| *** erkules_ has joined #openstack-dev | 02:38 | |
| *** erkules has quit IRC | 02:41 | |
| *** vipul has quit IRC | 02:46 | |
| *** erkules_ has quit IRC | 02:46 | |
| *** vipul has joined #openstack-dev | 02:47 | |
| *** erkules_ has joined #openstack-dev | 02:48 | |
| *** arnaud__ has quit IRC | 02:53 | |
| *** arnaud has quit IRC | 02:53 | |
| *** arnaud___ is now known as arnaud | 02:53 | |
| *** xarses has quit IRC | 02:54 | |
| *** matsuhashi has quit IRC | 02:56 | |
| *** matsuhashi has joined #openstack-dev | 02:57 | |
| *** nati_ueno has quit IRC | 03:01 | |
| *** DennyZha` has joined #openstack-dev | 03:01 | |
| *** matsuhashi has quit IRC | 03:01 | |
| *** DennyZhang has quit IRC | 03:02 | |
| *** sarob has quit IRC | 03:10 | |
| *** sarob has joined #openstack-dev | 03:10 | |
| *** yjiang5_away has quit IRC | 03:10 | |
| *** chandankumar has joined #openstack-dev | 03:11 | |
| *** krotscheck has quit IRC | 03:15 | |
| *** sarob has quit IRC | 03:15 | |
| *** sdake_ has quit IRC | 03:15 | |
| *** markvoelker1 has joined #openstack-dev | 03:18 | |
| *** DennyZha` has quit IRC | 03:24 | |
| *** pmathews has joined #openstack-dev | 03:24 | |
| *** dougshelley66 has quit IRC | 03:26 | |
| *** faramir has joined #openstack-dev | 03:31 | |
| *** hdd_ has joined #openstack-dev | 03:32 | |
| *** jcooley_ has quit IRC | 03:34 | |
| *** jcooley_ has joined #openstack-dev | 03:35 | |
| *** Shaan7 has quit IRC | 03:38 | |
| *** yjiang5 has joined #openstack-dev | 03:38 | |
| *** glucas has quit IRC | 03:40 | |
| *** chandankumar_ has joined #openstack-dev | 03:40 | |
| *** chandankumar has quit IRC | 03:41 | |
| *** buzztroll has joined #openstack-dev | 03:47 | |
| *** colinmcnamara has quit IRC | 03:48 | |
| *** jergerber has joined #openstack-dev | 03:48 | |
| *** jergerber has quit IRC | 03:48 | |
| *** che-arne has quit IRC | 03:48 | |
| *** jergerber has joined #openstack-dev | 03:48 | |
| *** jergerber has quit IRC | 03:48 | |
| *** colinmcnamara has joined #openstack-dev | 03:49 | |
| *** jasdeepH has joined #openstack-dev | 03:49 | |
| *** rods1 has quit IRC | 03:55 | |
| *** CaptTofu has joined #openstack-dev | 03:59 | |
| *** glucas has joined #openstack-dev | 04:01 | |
| *** kushal has joined #openstack-dev | 04:01 | |
| *** jcooley_ has quit IRC | 04:05 | |
| *** jcooley_ has joined #openstack-dev | 04:06 | |
| *** che-arne has joined #openstack-dev | 04:09 | |
| *** matsuhashi has joined #openstack-dev | 04:11 | |
| *** ngoracke has joined #openstack-dev | 04:20 | |
| *** sarob has joined #openstack-dev | 04:21 | |
| *** pub_tap is now known as hub_cap | 04:22 | |
| *** jcooley_ has quit IRC | 04:22 | |
| *** chandankumar_ has quit IRC | 04:22 | |
| *** jcooley_ has joined #openstack-dev | 04:23 | |
| *** sarob has quit IRC | 04:25 | |
| *** matsuhashi has quit IRC | 04:26 | |
| *** jcooley_ has quit IRC | 04:27 | |
| *** guardianx has joined #openstack-dev | 04:28 | |
| *** Mandell has quit IRC | 04:30 | |
| *** matsuhashi has joined #openstack-dev | 04:30 | |
| *** epopt37 has quit IRC | 04:32 | |
| *** CaptTofu has quit IRC | 04:33 | |
| *** CaptTofu has joined #openstack-dev | 04:33 | |
| *** dsirrine has quit IRC | 04:39 | |
| *** matsuhashi has quit IRC | 04:39 | |
| *** ladquin_afk has quit IRC | 04:43 | |
| *** jcooley_ has joined #openstack-dev | 04:43 | |
| *** spzala has quit IRC | 04:45 | |
| *** epopt37 has joined #openstack-dev | 04:46 | |
| *** matsuhashi has joined #openstack-dev | 04:50 | |
| *** DennyZhang has joined #openstack-dev | 04:52 | |
| *** erkules_ is now known as erkules | 04:53 | |
| *** colinmcnamara has quit IRC | 04:57 | |
| *** jcooley_ has quit IRC | 04:58 | |
| *** markwash has quit IRC | 04:59 | |
| *** nermina has joined #openstack-dev | 05:00 | |
| *** kushal has quit IRC | 05:00 | |
| *** markwash has joined #openstack-dev | 05:03 | |
| *** jecarey has joined #openstack-dev | 05:05 | |
| *** Tross1 has joined #openstack-dev | 05:06 | |
| *** nati_ueno has joined #openstack-dev | 05:06 | |
| *** Tross has quit IRC | 05:07 | |
| *** matsuhashi has quit IRC | 05:07 | |
| *** SergeyLukjanov has joined #openstack-dev | 05:07 | |
| *** nati_ueno has quit IRC | 05:08 | |
| *** swaT30 has quit IRC | 05:08 | |
| *** yaguang has joined #openstack-dev | 05:15 | |
| *** yeylon__ has joined #openstack-dev | 05:17 | |
| *** DennyZhang has quit IRC | 05:17 | |
| *** colinmcnamara has joined #openstack-dev | 05:19 | |
| *** haomaiwang has joined #openstack-dev | 05:22 | |
| *** haomaiwang has quit IRC | 05:22 | |
| *** haomaiwang has joined #openstack-dev | 05:23 | |
| *** nati_ueno has joined #openstack-dev | 05:23 | |
| *** haomaiwang has quit IRC | 05:25 | |
| *** swaT30 has joined #openstack-dev | 05:25 | |
| *** haomaiwang has joined #openstack-dev | 05:26 | |
| *** jcooley_ has joined #openstack-dev | 05:27 | |
| *** matsuhashi has joined #openstack-dev | 05:32 | |
| *** jcooley_ has quit IRC | 05:33 | |
| *** che-arne has quit IRC | 05:34 | |
| *** harlowja has quit IRC | 05:43 | |
| *** sdake has quit IRC | 05:49 | |
| *** colinmcnamara has quit IRC | 05:50 | |
| *** sdake_ has joined #openstack-dev | 05:54 | |
| *** yeylon__ has quit IRC | 05:55 | |
| *** che-arne has joined #openstack-dev | 05:57 | |
| *** markwash has quit IRC | 05:59 | |
| *** jcooley_ has joined #openstack-dev | 06:00 | |
| *** jecarey has quit IRC | 06:01 | |
| *** sdake has joined #openstack-dev | 06:03 | |
| *** matsuhashi has quit IRC | 06:08 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 06:15 | |
| *** ffio has joined #openstack-dev | 06:19 | |
| *** jcooley_ has quit IRC | 06:21 | |
| *** SergeyLukjanov has joined #openstack-dev | 06:22 | |
| *** sarob has joined #openstack-dev | 06:22 | |
| *** vkozhukalov has joined #openstack-dev | 06:28 | |
| *** zaitcev has quit IRC | 06:30 | |
| *** hdd_ has quit IRC | 06:36 | |
| *** che-arne has quit IRC | 06:37 | |
| *** garyk has joined #openstack-dev | 06:37 | |
| *** jyhc has quit IRC | 06:38 | |
| *** chandankumar has joined #openstack-dev | 06:38 | |
| *** garyk has quit IRC | 06:39 | |
| *** jyhc has joined #openstack-dev | 06:40 | |
| *** novas0x2a|laptop has quit IRC | 06:44 | |
| *** sdake_ has quit IRC | 06:45 | |
| *** sdake has quit IRC | 06:46 | |
| *** chandankumar has quit IRC | 06:49 | |
| *** krotscheck has joined #openstack-dev | 06:53 | |
| *** jcooley_ has joined #openstack-dev | 06:56 | |
| *** sdake has joined #openstack-dev | 06:58 | |
| *** sdake_ has joined #openstack-dev | 06:58 | |
| *** che-arne has joined #openstack-dev | 07:00 | |
| *** krotscheck has quit IRC | 07:02 | |
| *** matsuhashi has joined #openstack-dev | 07:03 | |
| *** yaguang has quit IRC | 07:05 | |
| *** matsuhashi has quit IRC | 07:11 | |
| *** SergeyLukjanov has quit IRC | 07:16 | |
| *** prekarat has joined #openstack-dev | 07:19 | |
| *** jcooley_ has quit IRC | 07:19 | |
| *** matsuhashi has joined #openstack-dev | 07:22 | |
| *** sarob has quit IRC | 07:25 | |
| *** sarob has joined #openstack-dev | 07:26 | |
| *** sarob has quit IRC | 07:30 | |
| *** comay has quit IRC | 07:31 | |
| *** gongysh has quit IRC | 07:32 | |
| *** matsuhashi has quit IRC | 07:34 | |
| *** che-arne has quit IRC | 07:35 | |
| *** xarses has joined #openstack-dev | 07:36 | |
| *** marun has quit IRC | 07:43 | |
| *** evgenyf has joined #openstack-dev | 07:46 | |
| *** faramir has quit IRC | 07:47 | |
| *** marun has joined #openstack-dev | 07:48 | |
| *** jcooley_ has joined #openstack-dev | 07:52 | |
| *** matsuhashi has joined #openstack-dev | 07:54 | |
| *** che-arne has joined #openstack-dev | 07:59 | |
| *** jcooley_ has quit IRC | 08:03 | |
| *** jcooley_ has joined #openstack-dev | 08:05 | |
| *** sarob has joined #openstack-dev | 08:09 | |
| *** prekarat has quit IRC | 08:09 | |
| *** mohits has joined #openstack-dev | 08:12 | |
| *** ffio has quit IRC | 08:13 | |
| *** sarob has quit IRC | 08:14 | |
| *** achampion has quit IRC | 08:14 | |
| *** ngoracke has quit IRC | 08:17 | |
| *** matsuhashi has quit IRC | 08:18 | |
| *** fire has joined #openstack-dev | 08:19 | |
| *** SergeyLukjanov has joined #openstack-dev | 08:21 | |
| *** yolanda_ has joined #openstack-dev | 08:22 | |
| *** jcooley_ has quit IRC | 08:23 | |
| *** nermina has quit IRC | 08:23 | |
| *** jcooley_ has joined #openstack-dev | 08:24 | |
| *** sarob has joined #openstack-dev | 08:24 | |
| *** chandankumar has joined #openstack-dev | 08:27 | |
| *** glucas has quit IRC | 08:27 | |
| *** sarob has quit IRC | 08:29 | |
| *** achampion has joined #openstack-dev | 08:34 | |
| *** Drankis has joined #openstack-dev | 08:35 | |
| *** pmathews has quit IRC | 08:43 | |
| *** jcooley_ has quit IRC | 08:43 | |
| *** dstanek has quit IRC | 08:44 | |
| *** boris-42 has joined #openstack-dev | 08:45 | |
| *** evgenyf has quit IRC | 08:46 | |
| *** gongysh has joined #openstack-dev | 08:48 | |
| *** guardianx has quit IRC | 08:50 | |
| *** markvoelker1 has quit IRC | 08:51 | |
| *** Drankis has quit IRC | 08:56 | |
| *** Drankis has joined #openstack-dev | 09:07 | |
| *** MaxV has joined #openstack-dev | 09:10 | |
| *** sarob has joined #openstack-dev | 09:25 | |
| *** SergeyLukjanov has quit IRC | 09:26 | |
| *** eglynn has joined #openstack-dev | 09:28 | |
| *** sarob has quit IRC | 09:30 | |
| *** eglynn has quit IRC | 09:32 | |
| *** chandankumar has quit IRC | 09:43 | |
| *** MaxV has quit IRC | 09:49 | |
| *** MaxV has joined #openstack-dev | 09:50 | |
| *** MaxV has quit IRC | 09:52 | |
| *** eglynn has joined #openstack-dev | 09:53 | |
| *** gongysh has quit IRC | 09:57 | |
| *** romcheg has joined #openstack-dev | 10:01 | |
| *** fire has quit IRC | 10:02 | |
| *** fire has joined #openstack-dev | 10:06 | |
| *** changlp has joined #openstack-dev | 10:12 | |
| *** MaxV has joined #openstack-dev | 10:14 | |
| *** sandywalsh has quit IRC | 10:18 | |
| *** sarob has joined #openstack-dev | 10:25 | |
| *** amotoki_ has joined #openstack-dev | 10:28 | |
| *** vkozhukalov has quit IRC | 10:29 | |
| *** sarob has quit IRC | 10:29 | |
| *** sandywalsh has joined #openstack-dev | 10:32 | |
| *** eglynn has quit IRC | 10:34 | |
| *** jhesketh has quit IRC | 10:36 | |
| *** glucas has joined #openstack-dev | 10:53 | |
| *** MaxV has quit IRC | 10:54 | |
| ttx | morganfainberg: starting now, mail for anything urgent. Won't be checking IRC that much over the next two weeks | 10:54 |
| *** MaxV has joined #openstack-dev | 10:55 | |
| *** romcheg has left #openstack-dev | 10:55 | |
| *** davidhadas_ has quit IRC | 10:56 | |
| *** sushils has quit IRC | 10:58 | |
| *** jimjiang has quit IRC | 11:09 | |
| *** sushils has joined #openstack-dev | 11:10 | |
| *** jimjiang has joined #openstack-dev | 11:10 | |
| *** sandywalsh has quit IRC | 11:14 | |
| *** MaxV has quit IRC | 11:15 | |
| *** jhesketh__ has quit IRC | 11:16 | |
| *** MaxV has joined #openstack-dev | 11:16 | |
| *** sarob has joined #openstack-dev | 11:25 | |
| *** sandywalsh has joined #openstack-dev | 11:27 | |
| *** sarob has quit IRC | 11:30 | |
| *** mohits_ has joined #openstack-dev | 11:39 | |
| *** mohits has quit IRC | 11:39 | |
| *** jcooley_ has joined #openstack-dev | 11:46 | |
| *** jcooley_ has quit IRC | 11:47 | |
| *** jimjiang has quit IRC | 12:01 | |
| *** jimjiang has joined #openstack-dev | 12:01 | |
| *** Mandell has joined #openstack-dev | 12:02 | |
| *** sushils has quit IRC | 12:02 | |
| *** guardianx has joined #openstack-dev | 12:03 | |
| *** garyk has joined #openstack-dev | 12:03 | |
| *** rods1 has joined #openstack-dev | 12:03 | |
| *** mohits has joined #openstack-dev | 12:03 | |
| *** mohits_ has quit IRC | 12:06 | |
| *** mohits has quit IRC | 12:07 | |
| *** yamahata has joined #openstack-dev | 12:07 | |
| *** Mandell has quit IRC | 12:12 | |
| *** Mandell has joined #openstack-dev | 12:13 | |
| *** Mandell has quit IRC | 12:17 | |
| *** romcheg has joined #openstack-dev | 12:18 | |
| *** romcheg has left #openstack-dev | 12:18 | |
| *** pvo has quit IRC | 12:19 | |
| *** VeggieMeat_ has joined #openstack-dev | 12:20 | |
| *** e0ne has joined #openstack-dev | 12:20 | |
| *** VeggieMeat has quit IRC | 12:21 | |
| *** pvo has joined #openstack-dev | 12:22 | |
| *** sarob has joined #openstack-dev | 12:25 | |
| *** garyk has quit IRC | 12:25 | |
| *** chandankumar has joined #openstack-dev | 12:28 | |
| *** sarob has quit IRC | 12:30 | |
| *** yolanda_ has quit IRC | 12:30 | |
| *** mohits has joined #openstack-dev | 12:38 | |
| *** SergeyLukjanov has joined #openstack-dev | 12:41 | |
| *** MaxV has quit IRC | 12:43 | |
| *** yolanda_ has joined #openstack-dev | 12:57 | |
| *** yolanda_ has quit IRC | 13:00 | |
| *** nati_ueno has quit IRC | 13:01 | |
| *** dstanek has joined #openstack-dev | 13:02 | |
| *** mohits has quit IRC | 13:14 | |
| *** mohits has joined #openstack-dev | 13:14 | |
| *** markwash has joined #openstack-dev | 13:17 | |
| *** mrunge has joined #openstack-dev | 13:21 | |
| *** jimjiang has quit IRC | 13:21 | |
| *** jimjiang has joined #openstack-dev | 13:22 | |
| *** e0ne has quit IRC | 13:23 | |
| *** sarob has joined #openstack-dev | 13:25 | |
| *** vladan has quit IRC | 13:26 | |
| *** fifieldt has joined #openstack-dev | 13:28 | |
| *** sarob has quit IRC | 13:30 | |
| *** davidhadas has joined #openstack-dev | 13:38 | |
| *** vladan has joined #openstack-dev | 13:40 | |
| *** mohits has quit IRC | 13:45 | |
| *** mjfork has joined #openstack-dev | 13:47 | |
| *** vladikr has joined #openstack-dev | 13:48 | |
| *** swaT30 has quit IRC | 13:49 | |
| *** swaT30 has joined #openstack-dev | 13:52 | |
| *** lbalbalba has joined #openstack-dev | 13:53 | |
| *** CaptTofu has quit IRC | 13:53 | |
| *** CaptTofu has joined #openstack-dev | 13:53 | |
| lbalbalba | hi. is it just me, or is http://review.openstack.org/ unresponsive ? | 13:54 |
| *** vladikr has quit IRC | 13:55 | |
| *** CaptTofu has quit IRC | 13:55 | |
| *** buzztroll has quit IRC | 13:56 | |
| *** sgordon` has quit IRC | 13:57 | |
| *** krotscheck has joined #openstack-dev | 13:58 | |
| lbalbalba | ah. there we go... | 13:58 |
| *** sgordon` has joined #openstack-dev | 13:58 | |
| *** mriedem has joined #openstack-dev | 13:59 | |
| *** lbalbalba has left #openstack-dev | 14:01 | |
| *** e0ne has joined #openstack-dev | 14:02 | |
| *** fifieldt has quit IRC | 14:04 | |
| *** mohits has joined #openstack-dev | 14:06 | |
| *** e0ne has quit IRC | 14:06 | |
| *** dougshelley66 has joined #openstack-dev | 14:08 | |
| *** CaptTofu has joined #openstack-dev | 14:10 | |
| *** davidhadas has quit IRC | 14:23 | |
| *** guardianx has left #openstack-dev | 14:24 | |
| *** davidhadas has joined #openstack-dev | 14:24 | |
| *** CrackerJackMack has quit IRC | 14:24 | |
| *** CrackerJackMack has joined #openstack-dev | 14:24 | |
| *** sarob has joined #openstack-dev | 14:25 | |
| *** flaper87|afk is now known as flaper87 | 14:28 | |
| *** mriedem has quit IRC | 14:29 | |
| *** sarob has quit IRC | 14:30 | |
| *** vartom1111110 has joined #openstack-dev | 14:34 | |
| *** markwash has quit IRC | 14:37 | |
| *** romcheg1 has joined #openstack-dev | 14:41 | |
| *** jimjiang has quit IRC | 14:44 | |
| *** jimjiang has joined #openstack-dev | 14:45 | |
| *** romcheg1 has quit IRC | 14:45 | |
| *** enchantner has quit IRC | 14:48 | |
| *** dkuffner has joined #openstack-dev | 14:48 | |
| *** changlp has quit IRC | 14:49 | |
| *** changlp has joined #openstack-dev | 14:49 | |
| *** sushils has joined #openstack-dev | 14:50 | |
| *** davidhadas has quit IRC | 14:55 | |
| *** chandankumar has quit IRC | 14:56 | |
| *** davidhadas has joined #openstack-dev | 14:56 | |
| *** e0ne has joined #openstack-dev | 15:02 | |
| *** davidhadas has quit IRC | 15:07 | |
| *** e0ne has quit IRC | 15:07 | |
| *** buzztroll has joined #openstack-dev | 15:07 | |
| *** buzztroll has quit IRC | 15:11 | |
| *** buzztroll has joined #openstack-dev | 15:13 | |
| *** terry_howe has quit IRC | 15:16 | |
| *** sarob has joined #openstack-dev | 15:25 | |
| *** sarob has quit IRC | 15:29 | |
| *** colinmcnamara has joined #openstack-dev | 15:32 | |
| *** buzztroll has quit IRC | 15:34 | |
| *** vartom1111110 has quit IRC | 15:38 | |
| *** buzztroll has joined #openstack-dev | 15:43 | |
| *** MaxV has joined #openstack-dev | 15:45 | |
| *** sarob has joined #openstack-dev | 15:46 | |
| *** buzztroll has quit IRC | 15:47 | |
| *** buzztroll has joined #openstack-dev | 15:47 | |
| *** matiu has quit IRC | 15:50 | |
| *** MaxV has quit IRC | 15:52 | |
| *** buzztroll has quit IRC | 15:52 | |
| *** sarob has quit IRC | 15:57 | |
| *** sarob has joined #openstack-dev | 15:57 | |
| *** VeggieMeat_ is now known as VeggieMeat | 15:59 | |
| *** Ruetobas has quit IRC | 16:01 | |
| *** e0ne has joined #openstack-dev | 16:01 | |
| *** Alexei_987 has quit IRC | 16:01 | |
| *** Alexei_987 has joined #openstack-dev | 16:02 | |
| *** sarob has quit IRC | 16:02 | |
| *** Ruetobas has joined #openstack-dev | 16:03 | |
| *** e0ne has quit IRC | 16:06 | |
| *** giroro_ has joined #openstack-dev | 16:06 | |
| *** matiu has joined #openstack-dev | 16:07 | |
| *** matiu has quit IRC | 16:07 | |
| *** matiu has joined #openstack-dev | 16:07 | |
| *** nermina has joined #openstack-dev | 16:07 | |
| *** Ruetobas has quit IRC | 16:08 | |
| *** abramley__ has quit IRC | 16:09 | |
| *** pcm_ has quit IRC | 16:13 | |
| *** amotoki_ has quit IRC | 16:14 | |
| *** mrunge has quit IRC | 16:21 | |
| *** CaptTofu has quit IRC | 16:21 | |
| *** CaptTofu has joined #openstack-dev | 16:22 | |
| *** colinmcnamara has quit IRC | 16:22 | |
| *** shathan has quit IRC | 16:22 | |
| *** buzztroll has joined #openstack-dev | 16:23 | |
| *** nati_ueno has joined #openstack-dev | 16:24 | |
| *** buzztroll has quit IRC | 16:24 | |
| *** buzztroll has joined #openstack-dev | 16:25 | |
| *** davidhadas has joined #openstack-dev | 16:25 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 16:28 | |
| *** _SergeyLukjanov is now known as SergeyLukjanov | 16:29 | |
| *** CaptTofu has quit IRC | 16:29 | |
| *** CaptTofu has joined #openstack-dev | 16:30 | |
| *** buzztroll has quit IRC | 16:30 | |
| *** MaxV has joined #openstack-dev | 16:30 | |
| *** persia has quit IRC | 16:31 | |
| *** persia has joined #openstack-dev | 16:31 | |
| *** persia is now known as Guest38628 | 16:31 | |
| *** vkozhukalov has joined #openstack-dev | 16:33 | |
| *** sushils has quit IRC | 16:36 | |
| *** nkinder has quit IRC | 16:41 | |
| *** chandankumar has joined #openstack-dev | 16:48 | |
| *** nkinder has joined #openstack-dev | 16:52 | |
| *** sarob has joined #openstack-dev | 16:55 | |
| *** nati_ueno has quit IRC | 16:56 | |
| *** tris has quit IRC | 16:57 | |
| *** SergeyLukjanov has quit IRC | 16:58 | |
| *** tris has joined #openstack-dev | 16:58 | |
| *** garyk has joined #openstack-dev | 16:59 | |
| *** flaper87 is now known as flaper87|afk | 16:59 | |
| *** sarob has quit IRC | 17:02 | |
| *** e0ne has joined #openstack-dev | 17:02 | |
| *** sarob has joined #openstack-dev | 17:03 | |
| *** nermina has quit IRC | 17:03 | |
| *** e0ne has quit IRC | 17:07 | |
| *** nermina has joined #openstack-dev | 17:07 | |
| *** fire has quit IRC | 17:16 | |
| *** CaptTofu has quit IRC | 17:17 | |
| *** cyeoh has quit IRC | 17:17 | |
| *** CaptTofu has joined #openstack-dev | 17:18 | |
| *** MaxV has quit IRC | 17:18 | |
| *** CaptTofu has quit IRC | 17:20 | |
| *** CaptTofu has joined #openstack-dev | 17:20 | |
| *** sushils has joined #openstack-dev | 17:21 | |
| *** fire has joined #openstack-dev | 17:21 | |
| *** gimpspace has joined #openstack-dev | 17:23 | |
| *** garyk has quit IRC | 17:24 | |
| *** mohits has quit IRC | 17:24 | |
| *** buzztroll has joined #openstack-dev | 17:26 | |
| *** pmathews has joined #openstack-dev | 17:27 | |
| *** sarob has quit IRC | 17:30 | |
| *** sarob has joined #openstack-dev | 17:31 | |
| *** e0ne has joined #openstack-dev | 17:31 | |
| *** sarob has quit IRC | 17:35 | |
| *** e0ne has quit IRC | 17:36 | |
| *** chandankumar has quit IRC | 17:36 | |
| *** Alexei_987 has quit IRC | 17:38 | |
| *** ywu has quit IRC | 17:41 | |
| *** rektide has joined #openstack-dev | 17:44 | |
| *** akrivoka has joined #openstack-dev | 17:45 | |
| *** CaptTofu has quit IRC | 17:49 | |
| *** CaptTofu has joined #openstack-dev | 17:50 | |
| *** akrivoka has quit IRC | 17:52 | |
| *** pmathews has quit IRC | 17:56 | |
| *** nermina has quit IRC | 17:56 | |
| *** buzztroll has quit IRC | 17:59 | |
| *** otherwiseguy has quit IRC | 18:00 | |
| *** Andrei89 has joined #openstack-dev | 18:00 | |
| *** nermina has joined #openstack-dev | 18:02 | |
| Andrei89 | looking for someone with good knowledge - DevStack/Openstack/localrc/VIRTUAL BOX/UBUNTU - I just want to deploy Openstack with Devstack and can't manage to have public and private network topology | Willing to pay for the help! | 18:02 |
| *** SergeyLukjanov has joined #openstack-dev | 18:06 | |
| *** pmathews has joined #openstack-dev | 18:07 | |
| *** SergeyLukjanov is now known as _SergeyLukjanov | 18:07 | |
| *** _SergeyLukjanov is now known as SergeyLukjanov | 18:07 | |
| *** krtaylor has quit IRC | 18:12 | |
| *** pmathews has quit IRC | 18:17 | |
| *** Mandell has joined #openstack-dev | 18:32 | |
| *** jimjiang has quit IRC | 18:33 | |
| *** jimjiang has joined #openstack-dev | 18:33 | |
| *** krotscheck has quit IRC | 18:34 | |
| *** yolanda_ has joined #openstack-dev | 18:37 | |
| *** jimjiang has quit IRC | 18:39 | |
| *** jimjiang has joined #openstack-dev | 18:40 | |
| *** jcooley_ has joined #openstack-dev | 18:40 | |
| *** Mandell has quit IRC | 18:40 | |
| *** sarob has joined #openstack-dev | 18:41 | |
| *** sarob has quit IRC | 18:46 | |
| *** harlowja has joined #openstack-dev | 18:47 | |
| *** e0ne has joined #openstack-dev | 18:47 | |
| *** buzztroll has joined #openstack-dev | 18:48 | |
| *** nermina has quit IRC | 18:49 | |
| *** nati_ueno has joined #openstack-dev | 18:50 | |
| *** colinmcnamara has joined #openstack-dev | 18:51 | |
| *** e0ne has quit IRC | 18:52 | |
| *** nermina has joined #openstack-dev | 18:56 | |
| *** mrodden has quit IRC | 18:56 | |
| *** flor3n has joined #openstack-dev | 19:01 | |
| *** CaptTofu has quit IRC | 19:01 | |
| *** CaptTofu has joined #openstack-dev | 19:01 | |
| *** jcooley_ has quit IRC | 19:05 | |
| *** buzztroll has quit IRC | 19:06 | |
| *** jcooley_ has joined #openstack-dev | 19:07 | |
| *** jimjiang has quit IRC | 19:14 | |
| *** jimjiang has joined #openstack-dev | 19:15 | |
| *** buzztroll has joined #openstack-dev | 19:17 | |
| *** jimjiang has quit IRC | 19:21 | |
| *** mjfork has quit IRC | 19:21 | |
| *** afazekas_ has joined #openstack-dev | 19:21 | |
| *** jimjiang has joined #openstack-dev | 19:21 | |
| *** krotscheck has joined #openstack-dev | 19:25 | |
| *** buzztroll has quit IRC | 19:27 | |
| *** jimjiang has quit IRC | 19:28 | |
| *** jimjiang has joined #openstack-dev | 19:29 | |
| *** buzztroll has joined #openstack-dev | 19:31 | |
| *** CaptTofu has quit IRC | 19:32 | |
| *** CaptTofu has joined #openstack-dev | 19:32 | |
| *** buzztroll has quit IRC | 19:36 | |
| *** jcooley_ has quit IRC | 19:37 | |
| *** krotscheck has quit IRC | 19:38 | |
| *** colinmcnamara has quit IRC | 19:44 | |
| *** colinmcnamara has joined #openstack-dev | 19:45 | |
| *** yolanda_ has quit IRC | 19:48 | |
| *** yolanda_ has joined #openstack-dev | 19:56 | |
| *** buzztroll has joined #openstack-dev | 19:57 | |
| *** salv-orlando_ has joined #openstack-dev | 19:58 | |
| *** salv-orlando_ has quit IRC | 19:58 | |
| *** salv-orlando has quit IRC | 19:59 | |
| *** salv-orlando has joined #openstack-dev | 19:59 | |
| *** Ryan_Lane has joined #openstack-dev | 20:00 | |
| *** Ryan_Lane has quit IRC | 20:00 | |
| *** Ryan_Lane has joined #openstack-dev | 20:00 | |
| *** ngoracke has joined #openstack-dev | 20:02 | |
| *** colinmcnamara has quit IRC | 20:04 | |
| *** boris-42 has quit IRC | 20:11 | |
| *** buzztroll has quit IRC | 20:19 | |
| *** buzztroll has joined #openstack-dev | 20:20 | |
| *** Andrei89 has quit IRC | 20:23 | |
| *** Andrei89 has joined #openstack-dev | 20:24 | |
| *** Andrei89 has quit IRC | 20:24 | |
| *** CaptTofu has quit IRC | 20:27 | |
| *** CaptTofu has joined #openstack-dev | 20:27 | |
| *** fire has quit IRC | 20:27 | |
| *** fire has joined #openstack-dev | 20:32 | |
| *** buzztroll has quit IRC | 20:35 | |
| *** jimjiang has quit IRC | 20:48 | |
| *** jimjiang has joined #openstack-dev | 20:48 | |
| *** boris-42 has joined #openstack-dev | 20:53 | |
| *** jimjiang has quit IRC | 20:54 | |
| *** jimjiang has joined #openstack-dev | 20:55 | |
| *** uaberme has joined #openstack-dev | 20:55 | |
| *** pmathews has joined #openstack-dev | 20:57 | |
| *** markwash has joined #openstack-dev | 21:00 | |
| *** markwash has quit IRC | 21:04 | |
| *** buzztroll has joined #openstack-dev | 21:06 | |
| *** markwash has joined #openstack-dev | 21:08 | |
| *** otherwiseguy has joined #openstack-dev | 21:08 | |
| *** sc68cal has quit IRC | 21:10 | |
| *** buzztroll has quit IRC | 21:11 | |
| *** pmathews has quit IRC | 21:13 | |
| *** sc68cal has joined #openstack-dev | 21:14 | |
| *** krotscheck has joined #openstack-dev | 21:19 | |
| *** pmathews has joined #openstack-dev | 21:20 | |
| *** nermina has quit IRC | 21:23 | |
| *** otherwiseguy has quit IRC | 21:23 | |
| *** krotscheck has quit IRC | 21:24 | |
| *** CaptTofu has quit IRC | 21:27 | |
| *** CaptTofu has joined #openstack-dev | 21:27 | |
| *** markwash has quit IRC | 21:28 | |
| *** sushils has quit IRC | 21:34 | |
| *** kenperkins has quit IRC | 21:35 | |
| *** kenperkins has joined #openstack-dev | 21:37 | |
| *** otherwiseguy has joined #openstack-dev | 21:39 | |
| *** harlowja is now known as harlowja_away | 21:41 | |
| *** ngoracke has quit IRC | 21:41 | |
| *** buzztroll has joined #openstack-dev | 21:43 | |
| *** colinmcnamara has joined #openstack-dev | 21:48 | |
| *** SergeyLukjanov has quit IRC | 21:50 | |
| *** hdd_ has joined #openstack-dev | 21:51 | |
| *** vkozhukalov has quit IRC | 21:53 | |
| *** buzztroll has quit IRC | 21:54 | |
| *** buzztroll has joined #openstack-dev | 21:56 | |
| *** markwash has joined #openstack-dev | 21:58 | |
| *** pmathews1 has joined #openstack-dev | 21:59 | |
| *** pmathews has quit IRC | 21:59 | |
| *** markwash has quit IRC | 22:00 | |
| *** rushiagr has joined #openstack-dev | 22:02 | |
| *** s2r2 has quit IRC | 22:03 | |
| *** s2r2 has joined #openstack-dev | 22:03 | |
| *** pmathews1 has quit IRC | 22:04 | |
| *** Nytrix has joined #openstack-dev | 22:10 | |
| *** gimpspace has quit IRC | 22:13 | |
| *** xmltok has joined #openstack-dev | 22:15 | |
| morganfainberg | ttx, no nothing urgent. have good holidays | 22:16 |
| *** rushiagr has quit IRC | 22:17 | |
| *** gimpspace has joined #openstack-dev | 22:18 | |
| *** xmltok has quit IRC | 22:19 | |
| *** colinmcnamara has quit IRC | 22:21 | |
| *** Nytrix has quit IRC | 22:22 | |
| *** buzztroll has quit IRC | 22:26 | |
| *** dkuffner has quit IRC | 22:27 | |
| *** saranusu has joined #openstack-dev | 22:29 | |
| *** saranusu has quit IRC | 22:31 | |
| *** erkrnt has joined #openstack-dev | 22:31 | |
| *** afazekas_ has quit IRC | 22:32 | |
| *** jecarey has joined #openstack-dev | 22:32 | |
| *** uaberme has quit IRC | 22:39 | |
| *** jimjiang has quit IRC | 22:40 | |
| *** jimjiang has joined #openstack-dev | 22:41 | |
| *** gimpspace has quit IRC | 22:42 | |
| *** gimpspace has joined #openstack-dev | 22:47 | |
| *** CaptTofu has quit IRC | 22:53 | |
| *** CaptTofu has joined #openstack-dev | 22:53 | |
| *** jimjiang has quit IRC | 23:02 | |
| *** sarob has joined #openstack-dev | 23:02 | |
| *** jimjiang has joined #openstack-dev | 23:02 | |
| *** dave_tucker_zzz is now known as dave_tucker | 23:07 | |
| *** dave_tucker is now known as dave_tucker_zzz | 23:08 | |
| *** yolanda_ has quit IRC | 23:14 | |
| *** vladikr has joined #openstack-dev | 23:21 | |
| *** buzztroll has joined #openstack-dev | 23:21 | |
| *** sarob has quit IRC | 23:21 | |
| *** sarob has joined #openstack-dev | 23:22 | |
| *** sarob_ has joined #openstack-dev | 23:23 | |
| *** dkuffner has joined #openstack-dev | 23:26 | |
| *** sarob has quit IRC | 23:26 | |
| *** nati_ueno has quit IRC | 23:27 | |
| *** dkuffner has quit IRC | 23:27 | |
| *** sarob_ has quit IRC | 23:28 | |
| *** HenryG has quit IRC | 23:30 | |
| *** Drankis has quit IRC | 23:30 | |
| *** HenryG has joined #openstack-dev | 23:30 | |
| *** fire has quit IRC | 23:34 | |
| *** Slidey has quit IRC | 23:34 | |
| *** Slidey has joined #openstack-dev | 23:35 | |
| *** mancdaz_away has quit IRC | 23:37 | |
| *** davidhadas has quit IRC | 23:41 | |
| *** hdd_ has quit IRC | 23:45 | |
| *** mancdaz_away has joined #openstack-dev | 23:47 | |
| *** mancdaz_away is now known as mancdaz | 23:47 | |
| *** neoXsys has quit IRC | 23:49 | |
| *** fbo is now known as fbo_away | 23:49 | |
| *** Drankis has joined #openstack-dev | 23:49 | |
| *** zzelle has joined #openstack-dev | 23:50 | |
| *** neoXsys has joined #openstack-dev | 23:50 | |
| *** zzelle has quit IRC | 23:50 | |
| *** sarob has joined #openstack-dev | 23:52 | |
| *** zzelle has joined #openstack-dev | 23:54 | |
| *** sarob has quit IRC | 23:54 | |
| *** sarob has joined #openstack-dev | 23:54 | |
| *** sarob has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!