Saturday, 2013-12-28

*** slagle has joined #openstack-dev00:04
*** markwash has joined #openstack-dev00:08
*** JordanRinke has joined #openstack-dev00:10
*** markwash has quit IRC00:16
*** beisner has joined #openstack-dev00:21
*** DennyZhang has joined #openstack-dev00:27
*** slagle has quit IRC00:27
*** nermina has joined #openstack-dev00:44
*** xchu has joined #openstack-dev00:46
*** slagle has joined #openstack-dev00:49
*** dstanek has joined #openstack-dev00:50
*** adalbas has quit IRC00:51
*** Ryan_Lane has quit IRC00:51
*** vkmc has quit IRC00:54
*** dstanek has quit IRC00:55
*** achampion has joined #openstack-dev00:57
*** slagle has quit IRC01:00
*** achampion has quit IRC01:01
*** otherwiseguy has quit IRC01:20
*** loq_mac has joined #openstack-dev01:21
*** danielbruno has quit IRC01:22
*** loq_mac has quit IRC01:28
*** tkay has quit IRC01:30
*** achampion has joined #openstack-dev01:33
*** carlp has quit IRC01:43
*** alex_xu has quit IRC01:52
*** loq_mac has joined #openstack-dev01:53
morganfainberggyee, ping (not sure if you're around)01:53
*** nermina has quit IRC01:55
*** rods1 has quit IRC02:03
*** loq_mac has quit IRC02:05
*** faramir has joined #openstack-dev02:07
*** DennyZha` has joined #openstack-dev02:08
*** DennyZhang has quit IRC02:09
*** faramir has quit IRC02:11
*** DennyZha` has quit IRC02:13
*** loq_mac has joined #openstack-dev02:18
*** aspiers has quit IRC02:21
*** dims has quit IRC02:22
*** loquacities has joined #openstack-dev02:23
*** loq_mac has quit IRC02:23
*** harlowja has quit IRC02:24
*** xchu has quit IRC02:24
*** radez_g0` has joined #openstack-dev02:27
*** radez_g0n3 has quit IRC02:27
*** faramir has joined #openstack-dev02:28
*** erkules_ has joined #openstack-dev02:30
*** erkules has quit IRC02:32
*** DennyZha` has joined #openstack-dev02:35
*** dims has joined #openstack-dev02:37
*** DennyZha` has quit IRC02:39
*** Mandell has joined #openstack-dev02:40
*** krotscheck has quit IRC02:40
*** sushils has quit IRC02:43
*** nati_ueno has quit IRC02:44
*** yamahata has quit IRC03:00
*** markwash has joined #openstack-dev03:01
*** krotscheck has joined #openstack-dev03:06
*** loquacities has quit IRC03:09
*** harlowja has joined #openstack-dev03:15
*** dougshelley66 has quit IRC03:16
*** angdraug has quit IRC03:17
*** SergeyLukjanov has joined #openstack-dev03:18
*** anniec has quit IRC03:19
*** achampion has quit IRC03:20
*** loq_mac has joined #openstack-dev03:23
*** achampion has joined #openstack-dev03:23
*** reed has quit IRC03:24
*** colinmcnamara has joined #openstack-dev03:27
*** terriyu has quit IRC03:30
*** faramir has quit IRC03:35
*** hartsocks1 has joined #openstack-dev03:49
*** SergeyLukjanov has quit IRC03:59
*** dguitarbite has joined #openstack-dev04:06
*** krotscheck has quit IRC04:09
*** dstanek has joined #openstack-dev04:20
*** jhesketh_ has quit IRC04:20
*** nermina has joined #openstack-dev04:24
*** achampion has quit IRC04:24
*** achampion has joined #openstack-dev04:25
*** xarg__ has quit IRC04:25
*** pingveno_ is now known as pingveno04:30
*** DennyZhang has joined #openstack-dev04:31
*** jhesketh_ has joined #openstack-dev04:33
*** nermina has quit IRC04:36
*** Hien has quit IRC04:36
*** achampion has quit IRC04:37
*** achampion has joined #openstack-dev04:38
*** rongze has joined #openstack-dev04:45
*** DennyZhang has quit IRC04:46
*** DennyZhang has joined #openstack-dev04:48
*** Hien has joined #openstack-dev04:59
*** boris-42 has joined #openstack-dev05:01
*** achampio1 has joined #openstack-dev05:02
*** achampion has quit IRC05:03
*** DennyZhang has quit IRC05:03
*** DennyZhang has joined #openstack-dev05:07
*** dstanek has quit IRC05:15
*** colinmcnamara has quit IRC05:28
*** DennyZhang has quit IRC05:42
*** achampio1 has quit IRC05:48
*** harlowja has quit IRC05:50
*** arnaud___ has quit IRC05:52
*** harlowja has joined #openstack-dev05:53
*** harlowja has quit IRC05:53
*** harlowja has joined #openstack-dev05:53
*** arnaud___ has joined #openstack-dev05:54
*** loq_mac has quit IRC05:58
*** rongze has quit IRC05:59
*** achampion has joined #openstack-dev06:11
*** epopt37 has quit IRC06:13
*** stevemar has joined #openstack-dev06:14
*** Mandell has quit IRC06:15
*** ngoracke has joined #openstack-dev06:21
*** epopt37 has joined #openstack-dev06:25
*** chandankumar has quit IRC06:46
*** DennyZhang has joined #openstack-dev06:51
*** aeperezt has quit IRC06:52
*** harlowja is now known as harlowja_away06:53
*** markwash has quit IRC06:56
*** vartom1111110 has joined #openstack-dev06:59
*** harlowja_away is now known as harlowja07:04
*** erkrnt has quit IRC07:07
*** DennyZhang has quit IRC07:10
*** DennyZhang has joined #openstack-dev07:10
*** DennyZhang has quit IRC07:21
*** vartom1111110 has quit IRC07:25
*** pmathews has quit IRC07:26
*** dougshelley66 has joined #openstack-dev07:31
*** ig has joined #openstack-dev07:46
*** SergeyLukjanov has joined #openstack-dev07:48
*** Drankis has joined #openstack-dev07:50
*** Drankis has quit IRC07:56
*** SergeyLukjanov has quit IRC07:57
*** ig1 has joined #openstack-dev08:03
*** harlowja is now known as harlowja_away08:04
*** ig1 has quit IRC08:04
*** ig has quit IRC08:06
*** Drankis has joined #openstack-dev08:09
*** ig has joined #openstack-dev08:09
*** ngoracke has quit IRC08:09
*** ig has left #openstack-dev08:10
*** alexpilotti has quit IRC08:17
*** koofoss has joined #openstack-dev08:28
*** MaxV has joined #openstack-dev08:28
*** alunduil has quit IRC08:40
*** alunduil has joined #openstack-dev09:00
*** loq_mac has joined #openstack-dev09:10
*** xarg_ has joined #openstack-dev09:22
*** rossella_s has joined #openstack-dev09:26
*** xchu has joined #openstack-dev09:29
*** Drankis has quit IRC09:36
*** sushils has joined #openstack-dev09:43
*** Drankis has joined #openstack-dev09:49
*** MaxV has quit IRC09:58
*** jhesketh_ has quit IRC10:05
*** ig has joined #openstack-dev10:22
*** ig has quit IRC10:23
*** prekarat has joined #openstack-dev10:32
*** loq_mac has quit IRC10:42
*** loq_mac has joined #openstack-dev10:42
*** michchap has quit IRC10:52
*** michchap has joined #openstack-dev10:53
*** vartom1111110 has joined #openstack-dev10:54
*** rossella_s has quit IRC11:00
*** MaxV has joined #openstack-dev11:00
*** MaxV has quit IRC11:02
*** MaxV has joined #openstack-dev11:02
*** stevemar has quit IRC11:03
*** yatin has joined #openstack-dev11:05
*** yatin has left #openstack-dev11:06
*** vartom1111110 has quit IRC11:13
*** xchu has quit IRC11:17
*** prekarat has quit IRC11:24
*** vartom1111110 has joined #openstack-dev11:27
*** aspiers has joined #openstack-dev12:44
*** adalbas has joined #openstack-dev13:03
*** vartom1111111 has joined #openstack-dev13:15
*** achampion has quit IRC13:15
*** MaxV has quit IRC13:15
*** vartom1111110 has quit IRC13:17
*** e0ne has joined #openstack-dev13:21
*** vartom1111111 has quit IRC13:31
*** rods1 has joined #openstack-dev13:34
*** e0ne_ has joined #openstack-dev13:35
*** markwash has joined #openstack-dev13:37
*** e0ne has quit IRC13:38
*** mrunge has joined #openstack-dev13:40
*** MaxV has joined #openstack-dev13:41
*** mrunge has quit IRC13:41
*** achampion has joined #openstack-dev13:43
*** MaxV has quit IRC13:45
*** MaxV has joined #openstack-dev13:46
*** MaxV has quit IRC13:51
*** colinmcnamara has joined #openstack-dev13:51
*** e0ne_ has quit IRC13:51
*** aspiers has quit IRC13:59
*** MaxV has joined #openstack-dev14:01
*** pcm_ has joined #openstack-dev14:01
*** pcm_ has quit IRC14:05
*** MaxV has quit IRC14:05
*** pcm_ has joined #openstack-dev14:05
*** MaxV has joined #openstack-dev14:07
*** e0ne has joined #openstack-dev14:14
*** sgran has quit IRC14:17
*** CaptTofu has joined #openstack-dev14:20
*** dstanek has joined #openstack-dev14:24
*** sgran has joined #openstack-dev14:29
*** MaxV has quit IRC14:30
*** koofoss has quit IRC14:33
*** wendell has joined #openstack-dev14:47
*** CaptTofu has quit IRC14:48
*** wendell has left #openstack-dev14:48
*** aeperezt has joined #openstack-dev14:58
*** dougshelley66 has quit IRC15:11
*** dave_tucker_zzz is now known as dave_tucker15:18
*** anniec has joined #openstack-dev15:18
*** CaptTofu has joined #openstack-dev15:19
*** mwj has quit IRC15:21
*** Drankis has quit IRC15:21
*** anniec_ has joined #openstack-dev15:22
*** anniec has quit IRC15:23
*** anniec_ is now known as anniec15:23
*** MaxV has joined #openstack-dev15:23
*** SergeyLukjanov has joined #openstack-dev15:24
*** salv-orlando has quit IRC15:24
*** dstanek has quit IRC15:25
*** markwash has quit IRC15:28
*** dstanek has joined #openstack-dev15:29
*** markwash has joined #openstack-dev15:32
*** markwash has quit IRC15:33
*** Drankis has joined #openstack-dev15:34
*** Drankis has quit IRC15:34
*** Drankis has joined #openstack-dev15:35
*** CaptTofu has quit IRC15:36
*** dguitarbite has quit IRC15:43
*** harlowja_away is now known as harlowja15:44
*** Ruetobas has quit IRC16:01
*** Ruetobas has joined #openstack-dev16:03
*** giroro_ has joined #openstack-dev16:06
*** terriyu has joined #openstack-dev16:07
*** Ruetobas has quit IRC16:07
*** Tross has quit IRC16:15
*** salv-orlando has joined #openstack-dev16:27
*** dstanek has quit IRC16:30
*** colinmcnamara has quit IRC16:35
*** salv-orlando_ has joined #openstack-dev16:39
*** colinmcnamara has joined #openstack-dev16:40
*** nati_ueno has joined #openstack-dev16:40
*** salv-orlando has quit IRC16:42
*** salv-orlando_ is now known as salv-orlando16:42
*** nati_ueno has quit IRC16:42
*** holms has quit IRC16:44
*** colinmcnamara has quit IRC16:44
*** jaypipes has quit IRC16:47
*** harlowja is now known as harlowja_away16:49
*** SergeyLukjanov has quit IRC16:50
*** dstanek has joined #openstack-dev17:02
*** salv-orlando has quit IRC17:03
*** salv-orlando has joined #openstack-dev17:05
*** alunduil has quit IRC17:09
*** salv-orlando has quit IRC17:10
*** colinmcnamara has joined #openstack-dev17:10
*** salv-orlando has joined #openstack-dev17:16
*** salv-orlando has quit IRC17:17
*** ozialien_ has quit IRC17:23
*** colinmcnamara has quit IRC17:24
*** dave_tucker is now known as dave_tucker_zzz17:32
*** Tross has joined #openstack-dev17:34
*** Mandell has joined #openstack-dev17:35
*** vartom1111111 has joined #openstack-dev17:37
*** e0ne has quit IRC17:40
*** colinmcnamara has joined #openstack-dev17:48
*** Mandell_ has joined #openstack-dev17:48
*** sushils has quit IRC17:48
*** che-arne has quit IRC17:50
*** Mandell has quit IRC17:51
*** che-arne has joined #openstack-dev17:52
*** MaxV has quit IRC17:56
*** MaxV has joined #openstack-dev17:56
*** MaxV has quit IRC17:57
*** SergeyLukjanov has joined #openstack-dev18:01
*** jimjiang has quit IRC18:02
*** jimjiang has joined #openstack-dev18:03
*** SergeyLukjanov is now known as _SergeyLukjanov18:03
*** vartom1111111 has quit IRC18:03
*** _SergeyLukjanov has quit IRC18:07
*** colinmcnamara has quit IRC18:13
*** salv-orlando has joined #openstack-dev18:15
*** SergeyLukjanov has joined #openstack-dev18:16
*** colinmcnamara has joined #openstack-dev18:16
*** gimpspace has joined #openstack-dev18:16
*** jaypipes has joined #openstack-dev18:21
*** adalbas has quit IRC18:32
*** vartom1111111 has joined #openstack-dev18:44
*** riskable has joined #openstack-dev18:52
*** vartom1111111 has quit IRC19:04
*** pcm_ has quit IRC19:05
*** dave_tucker_zzz is now known as dave_tucker19:28
*** vartom1111111 has joined #openstack-dev19:29
*** anniec has quit IRC19:31
*** gimpspace has quit IRC19:37
jaypipesmorganfainberg: thx for the review! :)19:49
*** Ryan_Lane has joined #openstack-dev19:49
morganfainbergjaypipes, of course!19:49
morganfainbergjaypipes, told ya i'd star it and get to it :)19:49
jaypipesmorganfainberg: :) thx, it's very much appreciated! I should be able to get to those requests today.19:50
morganfainbergjaypipes, and on the topic of making deletes idempotent, any thoughts?  i'm mulling over the work it would take to handle that across the board19:50
morganfainbergjaypipes, i think it would be a good approach personally.  calling .delete_<thing> just works, no NotFound raised internally.  but from the HTTP interface, it is relevant to say 404 if DELETE /project/<id> isn't found19:51
morganfainbergfeel free to tell me that i'm wrong on that front ;)19:51
jaypipesmorganfainberg: I don't see much issue in leaving it the way it is... it's easy enough to do a try: except NotFound: pass block if that is the desired behaviour of a caller of the internal API.19:52
jaypipesmorganfainberg: you aren't wrong at all... it's just a preference I believe.19:52
morganfainbergjaypipes, actually, thinking about it a bit more, i see an issue with it.  a lot of the delete_* calls require a get_ anyway.19:53
morganfainbergto handle business logic19:53
jaypipesindeed.19:53
morganfainbergsoooo, it would add more overhead to just raise 404 at the controller and try/except at the manager19:54
*** che-arne has quit IRC19:54
*** che-arne has joined #openstack-dev19:55
morganfainbergok, well that means i can focus on the other icky change i have coming down the line then.  removing "domain" from users.  so domain is only an assignment construct19:55
morganfainbergthat way we can support multiple user idenity backends (ldap1, ldap2, sql1, ldap3, sql2, federated via SAML, etc) more easily...19:56
morganfainbergall at once.19:56
*** colinmcnamara has quit IRC19:58
jaypipesmorganfainberg: ++20:03
jaypipesmorganfainberg: hmm :( I disagree with a lot of the use of transactions in https://review.openstack.org/#/c/56430/9/keystone/assignment/backends/sql.py ...20:06
morganfainbergjaypipes, semanitacally they are the same in SQLAlchemy, it';s just explicit demarcation20:06
*** salv-orlando has quit IRC20:06
morganfainbergfor single-call stuff20:07
jaypipesmorganfainberg: ? not sure what you're referring to...20:07
morganfainbergbasically the assignment stuff was (and in some cases still is) suffering from race conditions20:07
morganfainbergso that patch solves it20:07
jaypipesmorganfainberg: no it doesn't.20:08
morganfainbergjaypipes, it does in some cases, not all20:08
morganfainbergthe issue was race within a single transactional call. not a pure race20:08
morganfainberge.g. delete needing to cleanup a seconary grant row20:08
morganfainbergnot to solve 2 separate keystone process trying to delete the same user.20:09
jaypipesmorganfainberg: there's no point in putting SELECT requests into a new transaction unless the SELECT is using FOR UPDATE... I think there's a misunderstanding of what the SQLAlchemy session.begin() is actually doing...20:09
jaypipesmorganfainberg: I completely agree that doing things like create_grant() should put all modifying statements into a single transaction, but the way it's done in that patch for SELECT statements is wrong.20:11
*** jimjiang has quit IRC20:11
*** jimjiang has joined #openstack-dev20:12
morganfainbergjaypipes, i think i'm seeing that now.20:12
jaypipesmorganfainberg: for example, there's no point in putting list_grants() code under a transaction.20:12
morganfainbergjaypipes, i am not sure if there is an isolation benefit on any of the backend RDBMS20:13
morganfainbergi'll need to go look at sqlalchemy20:13
jaypipesmorganfainberg: because it isn't modifying data. if the list_grants() is called by another routine that *does* modify data, then that calling routine should have already begun a transaction, and if the calling routine must rely on the results of the list_grants() call not changing until some savepoint or commit, then the caller should ask that the SELECT done in list_grants() be done with_lockmode('update')20:13
*** Ryan_Lane has quit IRC20:14
morganfainbergjaypipes, sure then the approach would be to switch to the lockmode.20:14
morganfainbergjaypipes, again, i need to spend some time and look at sqlalchemy it looks like.20:14
morganfainbergjaypipes, there _might_ be some specific isolation benefit in how it gets passed to the db server.20:15
jaypipesmorganfainberg: right, and an appropriate kwarg passed to list_grants(), so that it can control whether it issues a SELECT or a SELECT FOR UPDATE.20:15
jaypipesmorganfainberg: there is not. :)20:15
morganfainberghave to be _very_ careful with kwargs.20:15
morganfainbergit makes caching a royal pain (memoization)20:16
morganfainbergso more _list_thing type methods20:16
morganfainbergthat are backend specific20:16
jaypipessure20:16
*** tdruiva has joined #openstack-dev20:18
*** gimpspace has joined #openstack-dev20:20
morganfainbergjaypipes, in either case mind tossing the bug/bp reference in your comment before the next patchset20:20
morganfainberg(likely a bug since not everything in a quick scan defines the extra column)20:20
jaypipesmorganfainberg: agreed... but if you try adding a new model without an extra column, boom... blows up :)20:23
morganfainbergjaypipes, oh i am not saying don't do what you're doing! :) just that the comment should point to the bug id ;)20:23
morganfainbergand .. at least somehow it works20:24
morganfainbergin some cases20:24
*** Ryan_Lane has joined #openstack-dev20:24
morganfainbergI haven't looked too closely20:24
jaypipesmorganfainberg: yup, I will do that20:24
morganfainbergcool20:24
morganfainbergjaypipes, and if i'm understanding it correctly, you'll add the "select for update" where appropriate for say... "_get_region"?20:26
morganfainbergjaypipes, also ignore the comment on line 154, it's outside of scope of the changes *whoopse*20:26
jaypipesmorganfainberg: well, with regions, nothing is currently FK'd to them... I will add the select for update behaviour in the future when I clean up the current references to "region" in things like endpoint that do not yet refer to the new "real" regions.20:27
morganfainbergok thats fine20:27
morganfainbergbe careful about FK between subsystems fwiw.20:28
morganfainbergbut i think you're 100% in catalog20:29
morganfainbergso...20:29
morganfainbergnon-issue?20:29
jaypipescorrect.20:29
morganfainbergcool20:29
morganfainbergsorry, it's holiday time and no coffee yet today20:29
jaypipesno worries at all!20:29
* morganfainberg resists urge to go buy some more entertaining things today.20:30
morganfainbergstick to coffee and food until next year :P20:30
jaypipeshehe20:36
*** NikitaKonovalov has joined #openstack-dev20:37
*** NikitaKonovalov has quit IRC20:37
*** Ryan_Lane has quit IRC20:38
*** tdruiva has quit IRC20:43
*** tdruiva has joined #openstack-dev20:44
*** DennyZhang has joined #openstack-dev20:46
*** vartom1111111 has quit IRC20:51
*** dripton__ has quit IRC21:07
*** dougshelley66 has joined #openstack-dev21:18
*** achampion has quit IRC21:33
*** comay has quit IRC21:35
*** mwj has joined #openstack-dev21:36
*** mwj has quit IRC21:44
*** mwj has joined #openstack-dev21:47
*** mwj has quit IRC21:57
*** erkrnt has joined #openstack-dev22:00
*** Ryan_Lane has joined #openstack-dev22:10
*** achampion has joined #openstack-dev22:11
*** Drankis has quit IRC22:19
*** dripton__ has joined #openstack-dev22:20
*** loq_mac has joined #openstack-dev22:21
*** ozialien_ has joined #openstack-dev22:26
*** dougshelley66 has quit IRC22:33
*** sushils has joined #openstack-dev22:36
*** SergeyLukjanov has quit IRC22:47
*** DennyZha` has joined #openstack-dev22:55
*** DennyZhang has quit IRC22:57
*** DennyZha` has quit IRC22:59
*** loq_mac has quit IRC23:29
*** comay has joined #openstack-dev23:37
*** achampion has quit IRC23:39
*** akrivoka has quit IRC23:41
*** tdruiva has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!