*** marvin_mhg has quit IRC | 00:05 | |
*** bobh has joined #openstack-dev | 00:13 | |
*** bobh has quit IRC | 00:17 | |
*** bobh has joined #openstack-dev | 00:27 | |
*** bobh has quit IRC | 00:28 | |
*** bobh has joined #openstack-dev | 00:29 | |
*** boazel has quit IRC | 01:38 | |
*** MattMan_ has quit IRC | 01:48 | |
*** MattMan_ has joined #openstack-dev | 01:49 | |
*** rosey99 has quit IRC | 01:52 | |
*** bobh has quit IRC | 02:04 | |
*** bobh has joined #openstack-dev | 02:15 | |
*** bobh has quit IRC | 02:19 | |
*** bobh has joined #openstack-dev | 02:27 | |
*** bobh has quit IRC | 02:32 | |
*** bobh has joined #openstack-dev | 02:42 | |
*** superdan is now known as dansmith | 02:44 | |
*** bobh has quit IRC | 02:47 | |
*** bobh has joined #openstack-dev | 02:53 | |
*** bobh has quit IRC | 02:57 | |
*** bobh has joined #openstack-dev | 03:04 | |
*** bobh has quit IRC | 03:08 | |
*** bobh has joined #openstack-dev | 03:14 | |
*** bobh has quit IRC | 03:18 | |
*** bobh has joined #openstack-dev | 03:24 | |
*** bobh has quit IRC | 03:29 | |
*** Leo_m has quit IRC | 03:42 | |
*** bobh has joined #openstack-dev | 04:07 | |
*** bobh has quit IRC | 04:11 | |
*** bobh has joined #openstack-dev | 04:28 | |
*** bobh has quit IRC | 04:32 | |
*** bobh has joined #openstack-dev | 04:46 | |
*** bobh has quit IRC | 04:50 | |
*** bobh has joined #openstack-dev | 04:57 | |
*** bobh has quit IRC | 05:01 | |
*** bobh has joined #openstack-dev | 05:11 | |
*** bobh has quit IRC | 05:15 | |
*** bobh has joined #openstack-dev | 05:25 | |
*** bobh has quit IRC | 05:30 | |
*** bobh has joined #openstack-dev | 05:35 | |
*** bobh has quit IRC | 05:39 | |
*** bobh has joined #openstack-dev | 05:45 | |
*** bobh has quit IRC | 05:49 | |
*** bobh has joined #openstack-dev | 05:55 | |
*** bobh has quit IRC | 06:00 | |
*** nijaba has quit IRC | 06:04 | |
*** bobh has joined #openstack-dev | 06:06 | |
*** nijaba has joined #openstack-dev | 06:07 | |
*** bobh has quit IRC | 06:10 | |
*** bobh has joined #openstack-dev | 06:16 | |
*** bobh has quit IRC | 06:20 | |
*** bobh has joined #openstack-dev | 06:27 | |
*** bobh has quit IRC | 06:31 | |
*** bobh has joined #openstack-dev | 06:35 | |
*** bobh has quit IRC | 06:40 | |
*** bobh has joined #openstack-dev | 06:45 | |
*** bobh has quit IRC | 06:49 | |
*** bobh has joined #openstack-dev | 06:54 | |
*** bobh has quit IRC | 06:59 | |
*** bobh has joined #openstack-dev | 07:07 | |
*** bobh has quit IRC | 07:11 | |
*** bobh has joined #openstack-dev | 07:15 | |
*** adrianc has joined #openstack-dev | 07:17 | |
*** bobh has quit IRC | 07:20 | |
*** slaweq has joined #openstack-dev | 07:23 | |
*** bobh has joined #openstack-dev | 07:28 | |
*** bobh has quit IRC | 07:32 | |
*** bobh has joined #openstack-dev | 07:35 | |
*** bobh has quit IRC | 07:39 | |
*** bobh has joined #openstack-dev | 07:45 | |
*** bobh has quit IRC | 07:49 | |
*** bobh has joined #openstack-dev | 07:54 | |
*** bobh has quit IRC | 07:58 | |
*** maharg101 has joined #openstack-dev | 08:01 | |
*** bobh has joined #openstack-dev | 08:09 | |
*** bobh has quit IRC | 08:13 | |
*** bobh has joined #openstack-dev | 08:14 | |
*** bobh has quit IRC | 08:18 | |
*** maharg101 has quit IRC | 08:18 | |
*** bobh has joined #openstack-dev | 08:40 | |
*** bobh has quit IRC | 08:44 | |
*** bobh has joined #openstack-dev | 08:45 | |
*** bobh has quit IRC | 08:49 | |
*** slaweq has quit IRC | 08:57 | |
*** bobh has joined #openstack-dev | 08:58 | |
*** bobh has quit IRC | 09:03 | |
*** bobh has joined #openstack-dev | 09:06 | |
*** bobh has quit IRC | 09:10 | |
*** bobh has joined #openstack-dev | 09:16 | |
*** bobh has quit IRC | 09:21 | |
*** bobh has joined #openstack-dev | 09:26 | |
*** bobh has quit IRC | 09:31 | |
*** slaweq has joined #openstack-dev | 09:31 | |
*** slaweq has quit IRC | 09:36 | |
*** bobh has joined #openstack-dev | 09:37 | |
*** bobh has quit IRC | 09:42 | |
*** bobh has joined #openstack-dev | 10:09 | |
*** bobh has quit IRC | 10:13 | |
*** bobh has joined #openstack-dev | 10:15 | |
*** bobh has quit IRC | 10:19 | |
*** bobh has joined #openstack-dev | 10:27 | |
*** bobh has quit IRC | 10:32 | |
*** bobh has joined #openstack-dev | 10:38 | |
*** bobh has quit IRC | 10:42 | |
*** bobh has joined #openstack-dev | 10:44 | |
*** bobh has quit IRC | 10:49 | |
*** bobh has joined #openstack-dev | 10:55 | |
*** bobh has quit IRC | 10:59 | |
*** bobh has joined #openstack-dev | 11:05 | |
*** bobh has quit IRC | 11:09 | |
*** brokencycle has joined #openstack-dev | 11:16 | |
*** bobh has joined #openstack-dev | 11:20 | |
*** bobh has quit IRC | 11:23 | |
*** bobh has joined #openstack-dev | 11:36 | |
*** bobh has quit IRC | 11:40 | |
*** dasp has quit IRC | 11:43 | |
*** dasp has joined #openstack-dev | 11:45 | |
*** bobh has joined #openstack-dev | 11:50 | |
*** bobh has quit IRC | 11:54 | |
*** bobh has joined #openstack-dev | 11:55 | |
*** bobh has quit IRC | 12:00 | |
*** bobh has joined #openstack-dev | 12:10 | |
*** bobh has quit IRC | 12:13 | |
*** bobh_ has joined #openstack-dev | 12:13 | |
*** dsneddon has quit IRC | 12:15 | |
*** bobh_ has quit IRC | 12:17 | |
*** bobh has joined #openstack-dev | 12:27 | |
*** gkadam has joined #openstack-dev | 12:30 | |
*** bobh has quit IRC | 12:32 | |
*** gkadam has quit IRC | 12:34 | |
*** bobh has joined #openstack-dev | 12:35 | |
*** bobh has quit IRC | 12:39 | |
*** bobh has joined #openstack-dev | 13:06 | |
*** bobh has quit IRC | 13:10 | |
*** bobh has joined #openstack-dev | 13:14 | |
*** bobh has quit IRC | 13:19 | |
*** bobh has joined #openstack-dev | 13:26 | |
*** bobh has quit IRC | 13:28 | |
*** bobh has joined #openstack-dev | 13:28 | |
*** Bhujay has joined #openstack-dev | 13:43 | |
*** pbourke has quit IRC | 14:02 | |
*** pbourke has joined #openstack-dev | 14:04 | |
*** luzC has quit IRC | 14:23 | |
*** nguyenhai93 has joined #openstack-dev | 14:27 | |
dhellmann | hi, nguyenhai93 | 14:28 |
---|---|---|
nguyenhai93 | hi | 14:28 |
nguyenhai93 | https://review.openstack.org/#/c/592810/, the problem is on pike branch of python-vitrageclient. I am working on python3-first patches but I meet the error related to tox_install.sh | 14:29 |
*** luzC has joined #openstack-dev | 14:30 | |
dhellmann | nguyenhai93 : I think that branch is too stale to work with that job | 14:30 |
nguyenhai93 | same as in python-tackerclient | 14:30 |
*** AJaeger has joined #openstack-dev | 14:31 | |
dhellmann | to fix it, I think there are a couple of options | 14:31 |
dhellmann | 1. make the tox_install.sh work properly | 14:31 |
dhellmann | 2. remove tox_install.sh and see if the job works that way | 14:31 |
nguyenhai93 | https://review.openstack.org/#/c/593012/, example build-openstack-sphinx-docs job in stable/ocata of python-tackerclient | 14:31 |
dhellmann | 3. drop that job from the repo entirely and only add it on branches where it works | 14:32 |
dhellmann | 4. do 3, but add the new documentation build job to the pike branch so we still have pike documentation | 14:32 |
dhellmann | I'm not sure which of those options is best | 14:32 |
dhellmann | I would probably start with option 2 and then try 3 and 4 | 14:32 |
nguyenhai93 | oh sorry, in python-tackerclient, there is no document on the old branches | 14:32 |
dhellmann | ah, ok | 14:33 |
AJaeger | dhellmann: I strongly advise against 1 in favor of 2. | 14:33 |
nguyenhai93 | then we should remove that job, right? | 14:33 |
dhellmann | we had another case like that | 14:33 |
AJaeger | ah, in this case, just drop it... | 14:33 |
dhellmann | yes | 14:33 |
dhellmann | remove that 1 job (or template) from that repo in project-config | 14:33 |
nguyenhai93 | for example, in python-tackerclient, it only has document until queens | 14:34 |
nguyenhai93 | got it | 14:34 |
dhellmann | it's better to land the patches to import the settings in the other branches first, but it's not too big of a deal if we don't | 14:34 |
dhellmann | and then we should probably file bugs against those projects that end up with missing jobs, so that someone goes back and fixes them | 14:35 |
dhellmann | if the branches are still open we should publish documentation from them | 14:35 |
nguyenhai93 | in case of python-vitrageclient, it has docs in that branch | 14:35 |
nguyenhai93 | in pike branch | 14:35 |
dhellmann | in that case we should try to make some version of the job work | 14:35 |
dhellmann | it might be easier to make the new job that uses "tox -e docs" work | 14:35 |
dhellmann | than to make the old job work | 14:35 |
dhellmann | I never really understood exactly what tox_install.sh was expected to do | 14:36 |
dhellmann | AJaeger : do you know if tox_install.sh was supposed to do something special if it was given no arguments? | 14:36 |
dhellmann | didn't we have that error once before? | 14:36 |
AJaeger | dhellmann: different teams used different ways of calling tox_install ;( when we changed jobs, we couldn't accomodate all of them. | 14:37 |
dhellmann | oh, fun | 14:37 |
AJaeger | Just backport the change to remove tox_install... | 14:37 |
dhellmann | nguyenhai93 : ^^ | 14:37 |
AJaeger | dhellmann: far too much fun, ask mordred, he did most of the work | 14:38 |
dhellmann | yes, I stayed out of all of that at the time | 14:38 |
AJaeger | dhellmann: I wish I had ;) | 14:39 |
nguyenhai93 | tox_install.sh was removed in pike branch in python-vitrageclient | 14:45 |
nguyenhai93 | https://github.com/openstack/python-vitrageclient/commit/0e164982df675626f8c1b76bc4426f4963346ebd | 14:45 |
dhellmann | the file is still there when I check out stable/pike though | 14:45 |
dhellmann | did a later commit put it back? | 14:46 |
dhellmann | or was that change you linked to not backported to pike? | 14:46 |
nguyenhai93 | ah i see | 14:47 |
dhellmann | $ git branch --contains 0e164982df675626f8c1b76bc4426f4963346ebd | 14:47 |
dhellmann | master | 14:47 |
dhellmann | stable/queens | 14:47 |
dhellmann | stable/rocky | 14:47 |
dhellmann | so it was not backported to pike | 14:47 |
*** brokencycle has quit IRC | 14:47 | |
*** bobh has quit IRC | 14:48 | |
dhellmann | running git log tools/tox_install.sh in pike only shows 1 commit to add it | 14:49 |
*** bobh has joined #openstack-dev | 14:55 | |
nguyenhai93 | can you submit a patch to overcome this error? dhellmann | 15:03 |
dhellmann | nguyenhai93 : I think you will want to backport the changes in https://github.com/openstack/python-vitrageclient/commit/0e164982df675626f8c1b76bc4426f4963346ebd to the pike branch and then rebase the patch you have to import the job settings on top of the backported patch | 15:04 |
dhellmann | let's try that, before we remove the documentation job | 15:04 |
dhellmann | if that does not work, then you can submit a patch to project-config to do something like what we had to do for oslo.messaging: https://review.openstack.org/#/c/592029/ | 15:05 |
dhellmann | and we can make the patch to import the settings depend on that project-config change | 15:06 |
dhellmann | how does that sound? | 15:06 |
nguyenhai93 | sound good | 15:28 |
dhellmann | nguyenhai93 : ok. I am going to sign off for a while, but let me know if you run into any trouble and we can look at other options. | 15:30 |
nguyenhai93 | thanks | 15:30 |
dhellmann | thank *you* for helping with so many patches! :-) | 15:30 |
*** cswang has quit IRC | 15:32 | |
*** cswang has joined #openstack-dev | 15:33 | |
*** sshnaidm|off has quit IRC | 15:44 | |
*** sshnaidm|off has joined #openstack-dev | 15:45 | |
*** achampion has quit IRC | 15:55 | |
*** morazi has joined #openstack-dev | 15:59 | |
*** Douhet has quit IRC | 16:24 | |
*** tristanC has quit IRC | 16:24 | |
*** timburke has quit IRC | 16:24 | |
*** mordred has quit IRC | 16:24 | |
*** ildikov has quit IRC | 16:24 | |
*** mrda has quit IRC | 16:24 | |
*** khappone has quit IRC | 16:24 | |
*** netapp has quit IRC | 16:24 | |
*** aluria has quit IRC | 16:24 | |
*** mattoliverau has quit IRC | 16:24 | |
*** mmedvede has quit IRC | 16:26 | |
*** DinaBelova has quit IRC | 16:27 | |
*** mmedvede has joined #openstack-dev | 16:28 | |
*** tristanC has joined #openstack-dev | 16:28 | |
*** Douhet has joined #openstack-dev | 16:29 | |
*** DinaBelova has joined #openstack-dev | 16:30 | |
*** mordred has joined #openstack-dev | 16:31 | |
*** sshnaidm|off is now known as sshnaidm | 16:37 | |
*** bobh has quit IRC | 16:38 | |
*** jamesmcarthur has joined #openstack-dev | 16:44 | |
*** bobh has joined #openstack-dev | 16:45 | |
*** bobh has quit IRC | 16:50 | |
*** bobh has joined #openstack-dev | 16:55 | |
*** bcafarel has quit IRC | 16:57 | |
*** bobh has quit IRC | 17:00 | |
*** bobh has joined #openstack-dev | 17:06 | |
*** brokencycle has joined #openstack-dev | 17:08 | |
*** bcafarel has joined #openstack-dev | 17:09 | |
*** bobh has quit IRC | 17:10 | |
*** bobh has joined #openstack-dev | 17:14 | |
*** bobh has quit IRC | 17:18 | |
*** Bhujay has quit IRC | 17:27 | |
*** jamesmcarthur has quit IRC | 17:30 | |
*** jamesmcarthur has joined #openstack-dev | 17:31 | |
*** jamesmcarthur has quit IRC | 17:35 | |
*** jamesmcarthur has joined #openstack-dev | 17:35 | |
*** bobh has joined #openstack-dev | 17:46 | |
*** jamesmcarthur has quit IRC | 17:46 | |
*** jamesmcarthur has joined #openstack-dev | 17:47 | |
*** jamesmcarthur has quit IRC | 17:51 | |
*** e0ne has joined #openstack-dev | 17:58 | |
*** ircuser-1 has quit IRC | 18:03 | |
*** Arkaniad has quit IRC | 19:16 | |
*** bobh has quit IRC | 19:20 | |
*** Arkaniad has joined #openstack-dev | 19:20 | |
*** bobh has joined #openstack-dev | 19:20 | |
*** pcaruana has quit IRC | 19:21 | |
*** adrianc has quit IRC | 19:50 | |
*** zaneb has joined #openstack-dev | 19:55 | |
*** e0ne has quit IRC | 20:13 | |
*** e0ne has joined #openstack-dev | 20:16 | |
*** ildikov has joined #openstack-dev | 20:21 | |
*** e0ne has quit IRC | 20:25 | |
*** jamesmcarthur has joined #openstack-dev | 20:51 | |
*** jamesmcarthur has quit IRC | 20:56 | |
*** slaweq has joined #openstack-dev | 20:58 | |
*** bobh has quit IRC | 20:59 | |
*** markvoelker has joined #openstack-dev | 21:04 | |
*** saint__ has joined #openstack-dev | 21:06 | |
*** saint_ has quit IRC | 21:07 | |
*** zaneb has quit IRC | 21:10 | |
*** markvoelker has quit IRC | 21:10 | |
*** bobh has joined #openstack-dev | 21:24 | |
*** brokencycle has quit IRC | 21:33 | |
*** brokencycle has joined #openstack-dev | 21:37 | |
*** ekcs has quit IRC | 22:05 | |
*** xarses_ has quit IRC | 22:06 | |
*** xarses_ has joined #openstack-dev | 22:06 | |
*** ekcs has joined #openstack-dev | 22:06 | |
*** zaneb has joined #openstack-dev | 22:14 | |
*** rcernin has joined #openstack-dev | 22:34 | |
*** bobh has quit IRC | 22:36 | |
*** mattoliverau has joined #openstack-dev | 23:11 | |
*** FracKen has quit IRC | 23:14 | |
*** jamesmcarthur has joined #openstack-dev | 23:15 | |
*** jamesmcarthur has quit IRC | 23:52 | |
*** brokencycle has quit IRC | 23:55 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!