Monday, 2018-10-01

*** jamesmcarthur has quit IRC00:08
*** slaweq has joined #openstack-dev00:11
*** slaweq has quit IRC00:16
*** bobh has joined #openstack-dev00:25
*** bobh has quit IRC00:35
*** efried has quit IRC00:38
*** efried has joined #openstack-dev00:38
*** gnufied has quit IRC01:01
*** slaweq has joined #openstack-dev01:11
*** jamesmcarthur has joined #openstack-dev01:14
*** slaweq has quit IRC01:16
*** med_ has joined #openstack-dev01:18
*** jamesmcarthur has quit IRC01:24
*** gnufied has joined #openstack-dev01:27
*** ijw has joined #openstack-dev01:32
*** med_ has quit IRC01:51
*** med_ has joined #openstack-dev02:10
*** gnufied has quit IRC02:14
*** gnufied has joined #openstack-dev02:18
*** markvoelker has joined #openstack-dev02:40
*** gnufied has quit IRC02:43
*** markvoelker has quit IRC02:45
*** markvoelker has joined #openstack-dev02:50
*** HuyNQ has joined #openstack-dev02:52
*** psachin has joined #openstack-dev02:55
*** maddtux has joined #openstack-dev03:22
*** Dinesh_Bhor has joined #openstack-dev03:31
*** ijw has quit IRC03:34
*** Dinesh_Bhor has quit IRC03:56
*** med_ has quit IRC03:59
*** pcaruana has joined #openstack-dev04:06
*** med_ has joined #openstack-dev04:14
*** shyamb has joined #openstack-dev04:15
*** pcaruana has quit IRC04:23
*** jamesmcarthur has joined #openstack-dev04:24
*** jamesmcarthur has quit IRC04:29
*** skazi has quit IRC04:40
*** shyamb has quit IRC04:45
*** shyamb has joined #openstack-dev05:07
*** Dinesh_Bhor has joined #openstack-dev05:29
*** skazi has joined #openstack-dev05:39
*** shyamb has quit IRC05:42
*** jbadiapa has joined #openstack-dev05:45
*** shyamb has joined #openstack-dev05:45
*** pcaruana has joined #openstack-dev05:51
*** maddtux has quit IRC05:56
*** maddtux has joined #openstack-dev05:57
*** shyamb has quit IRC06:07
*** med_ has quit IRC06:08
*** shyamb has joined #openstack-dev06:09
*** markvoelker has quit IRC06:33
*** markvoelker has joined #openstack-dev06:34
*** markvoelker has quit IRC06:38
*** vnogin has quit IRC06:44
*** shyamb has quit IRC06:51
*** piepmatz has joined #openstack-dev06:52
*** slaweq has joined #openstack-dev06:52
*** vnogin has joined #openstack-dev06:53
*** tosky__ has joined #openstack-dev06:54
*** shyamb has joined #openstack-dev06:55
*** vnogin has quit IRC06:59
*** jtomasek has joined #openstack-dev07:09
*** shardy has joined #openstack-dev07:14
*** MattMan_1 has quit IRC07:18
*** MattMan_1 has joined #openstack-dev07:18
*** Emine has joined #openstack-dev07:29
*** Dinesh_Bhor has quit IRC07:33
*** nplanel_ has joined #openstack-dev07:34
*** markvoelker has joined #openstack-dev07:34
*** Dinesh_Bhor has joined #openstack-dev07:35
*** shyamb has quit IRC07:38
*** vnogin has joined #openstack-dev07:43
*** Dinesh_Bhor has quit IRC07:44
*** vnogin has quit IRC07:47
*** nplanel_ has quit IRC07:48
*** nplanel_ has joined #openstack-dev07:48
*** d0ugal has joined #openstack-dev07:52
*** jpich has joined #openstack-dev07:53
*** ijw has joined #openstack-dev07:56
*** brokencycle has joined #openstack-dev07:59
*** ijw has quit IRC08:01
*** gfidente has joined #openstack-dev08:06
*** HuyNQ has quit IRC08:07
*** dalvarez has joined #openstack-dev08:16
*** lpetrut has joined #openstack-dev08:28
*** electrofelix has joined #openstack-dev08:30
*** vnogin has joined #openstack-dev08:32
*** ijw has joined #openstack-dev08:32
*** vnogin has quit IRC08:37
*** ijw has quit IRC08:37
*** shyamb has joined #openstack-dev08:41
*** tosky has joined #openstack-dev08:43
*** tosky__ has quit IRC08:44
*** shyamb has quit IRC08:45
*** shyamb has joined #openstack-dev08:45
*** gmoro has joined #openstack-dev08:46
*** ttsiouts has joined #openstack-dev08:55
*** ttsiouts has quit IRC08:56
*** ttsiouts has joined #openstack-dev08:56
*** Dinesh_Bhor has joined #openstack-dev08:57
*** e0ne has joined #openstack-dev08:59
*** maharg101 has quit IRC09:01
*** Dinesh_Bhor has quit IRC09:05
*** Dinesh_Bhor has joined #openstack-dev09:06
*** priteau has joined #openstack-dev09:16
*** psachin has quit IRC09:17
*** Dinesh_Bhor has quit IRC09:22
*** salmankhan has joined #openstack-dev09:28
*** shyamb has quit IRC09:30
*** ijw has joined #openstack-dev09:30
*** ijw has quit IRC09:35
*** shyamb has joined #openstack-dev09:37
*** dtantsur|afk is now known as dtantsur09:48
*** Dinesh_Bhor has joined #openstack-dev09:53
*** ijw has joined #openstack-dev09:56
*** ijw has quit IRC10:00
*** vnogin has joined #openstack-dev10:04
*** vnogin has quit IRC10:09
*** shyamb has quit IRC10:22
*** jamesmcarthur has joined #openstack-dev10:25
*** ttsiouts has quit IRC10:28
*** jamesmcarthur has quit IRC10:29
*** ijw has joined #openstack-dev10:32
*** boazel has quit IRC10:35
*** shyamb has joined #openstack-dev10:35
*** Luzi has joined #openstack-dev10:36
*** ijw has quit IRC10:37
*** nplanel_ has quit IRC10:37
*** shyamb has quit IRC10:42
*** salmankhan1 has joined #openstack-dev10:46
*** salmankhan has quit IRC10:48
*** salmankhan1 is now known as salmankhan10:48
*** Dinesh_Bhor has quit IRC10:49
*** vnogin has joined #openstack-dev10:53
*** dave-mccowan has joined #openstack-dev10:56
*** vnogin has quit IRC10:58
*** shyamb has joined #openstack-dev10:59
*** ttsiouts has joined #openstack-dev11:04
*** olivermller has joined #openstack-dev11:04
*** boazel has joined #openstack-dev11:04
*** phillu has joined #openstack-dev11:05
*** tpsilva has joined #openstack-dev11:41
*** vnogin has joined #openstack-dev11:52
*** markvoelker has quit IRC11:56
*** vnogin has quit IRC11:58
*** e0ne has quit IRC12:01
*** raildo has joined #openstack-dev12:02
*** e0ne has joined #openstack-dev12:08
*** mmethot has joined #openstack-dev12:21
*** dave-mccowan has quit IRC12:22
*** ttsiouts has quit IRC12:26
*** jamesmcarthur has joined #openstack-dev12:27
*** salmankhan1 has joined #openstack-dev12:30
*** ttsiouts has joined #openstack-dev12:30
*** med_ has joined #openstack-dev12:33
*** salmankhan has quit IRC12:34
*** salmankhan1 is now known as salmankhan12:34
*** jamesmcarthur has quit IRC12:35
*** Emine has quit IRC12:38
*** skazi has quit IRC12:38
*** dave-mccowan has joined #openstack-dev12:46
*** kgiusti has joined #openstack-dev12:49
*** morazi has joined #openstack-dev12:49
*** shyamb has quit IRC12:51
*** jcoufal has joined #openstack-dev12:51
*** vnogin has joined #openstack-dev12:51
*** Emine has joined #openstack-dev12:52
*** jroll has quit IRC12:54
*** jroll has joined #openstack-dev12:55
*** vnogin has quit IRC12:56
*** iyamahat_ has joined #openstack-dev12:57
*** mmethot_ has joined #openstack-dev12:57
*** rloo has joined #openstack-dev12:58
*** mmethot has quit IRC12:58
*** iyamahat has quit IRC12:58
*** Emine has quit IRC12:59
*** jamesmcarthur has joined #openstack-dev12:59
*** ccamposr__ has joined #openstack-dev13:01
*** gary_perkins has joined #openstack-dev13:01
*** beagles is now known as beagles_mtg13:07
*** shyamb has joined #openstack-dev13:10
*** nplanel_ has joined #openstack-dev13:10
*** maddtux has quit IRC13:14
*** jamesmcarthur has quit IRC13:15
*** phantax has joined #openstack-dev13:16
*** shyamb has quit IRC13:17
*** dave-mccowan has quit IRC13:17
*** Emine has joined #openstack-dev13:17
*** ttsiouts has quit IRC13:21
*** dave-mccowan has joined #openstack-dev13:21
*** awaugama has joined #openstack-dev13:25
*** ttsiouts has joined #openstack-dev13:27
*** cdent has joined #openstack-dev13:28
*** skazi has joined #openstack-dev13:32
*** jamesmcarthur has joined #openstack-dev13:36
*** jamesmcarthur has quit IRC13:37
*** jamesmcarthur has joined #openstack-dev13:38
*** dklyle has joined #openstack-dev13:47
*** nflondo_ has quit IRC14:04
*** olivermller has quit IRC14:07
*** markvoelker has joined #openstack-dev14:09
*** hongbin has joined #openstack-dev14:12
*** gnufied has joined #openstack-dev14:14
*** markvoelker has quit IRC14:15
*** markvoelker has joined #openstack-dev14:17
*** beekneemech is now known as bnemec14:21
*** markvoelker has quit IRC14:26
*** lpetrut has quit IRC14:27
*** nijaba has joined #openstack-dev14:27
*** ttsiouts has quit IRC14:28
*** ttsiouts has joined #openstack-dev14:28
*** Luzi has quit IRC14:29
*** mlavalle has joined #openstack-dev14:34
*** bobh has joined #openstack-dev14:35
*** Adri2000 has quit IRC14:58
*** Adri2000 has joined #openstack-dev14:59
*** kukacz_ is now known as kukacz14:59
*** ttsiouts has quit IRC15:02
*** lpetrut has joined #openstack-dev15:02
*** med_ has quit IRC15:03
*** corvus has joined #openstack-dev15:06
*** nplanel_ has quit IRC15:07
*** mriedem has joined #openstack-dev15:07
*** vnogin has joined #openstack-dev15:09
*** vnogin has quit IRC15:14
*** lpetrut has quit IRC15:18
*** lpetrut has joined #openstack-dev15:18
*** pcaruana has quit IRC15:30
*** nplanel_ has joined #openstack-dev15:31
*** lpetrut has quit IRC15:42
*** cswang has quit IRC15:44
*** cswang has joined #openstack-dev15:45
*** jamesmcarthur has quit IRC15:49
*** med_ has joined #openstack-dev15:50
*** jamesmcarthur has joined #openstack-dev15:51
*** ttsiouts has joined #openstack-dev15:56
*** ttsiouts has quit IRC15:56
*** ttsiouts has joined #openstack-dev15:56
*** nijaba has quit IRC15:57
*** dave-mccowan has quit IRC15:58
*** e0ne has quit IRC15:58
*** boazel has quit IRC16:00
*** ttsiouts has quit IRC16:01
*** beagles_mtg is now known as beagle16:02
*** boazel has joined #openstack-dev16:13
*** nijaba has joined #openstack-dev16:13
*** lpetrut has joined #openstack-dev16:14
*** piepmatz has quit IRC16:17
*** phantax has quit IRC16:18
*** rods_ has quit IRC16:24
*** rods has joined #openstack-dev16:24
*** phantax has joined #openstack-dev16:28
*** jpich has quit IRC16:29
*** shardy has quit IRC16:30
*** gyee has joined #openstack-dev16:30
*** jamesmcarthur has quit IRC16:34
*** med_ has quit IRC16:45
*** zzzeek_ has joined #openstack-dev16:51
*** ccamposr__ has quit IRC16:51
*** d0ugal has quit IRC16:54
*** dave-mccowan has joined #openstack-dev16:54
*** pcaruana has joined #openstack-dev16:56
*** kgiusti has quit IRC16:58
mriedembnemec: are you just waiting on https://review.openstack.org/#/q/project:openstack/oslo.upgradecheck+status:open to merge before cutting a release?16:59
mriedemdhellmann: i'm +2 on ^ there are a couple needing another +W17:00
bnemecmriedem: I think https://review.openstack.org/#/c/604421/ would be wanted in particular since it's an API change.17:00
*** nplanel_ has quit IRC17:00
mriedemyeah17:00
*** kgiusti has joined #openstack-dev17:01
*** dtantsur is now known as dtantsur|afk17:03
*** jamesmcarthur has joined #openstack-dev17:04
*** mriedem has quit IRC17:04
*** dsneddon_ has quit IRC17:12
*** dsneddon has joined #openstack-dev17:14
dhellmannbnemec , mriedem: one -1 on https://review.openstack.org/#/c/604421/ but +2 on the others17:15
*** electrofelix has quit IRC17:16
bnemecdhellmann: I'll double check, but I think there was a problem with calling Designate's config init function without first registering the category parser.17:17
bnemecSo because of the ordering, we either neede two separate functions or one that called a callback in the middle.17:18
bnemec*needed17:18
bnemecBut I will verify that and respond on the review.17:19
dhellmannwon't each project need their own main()?17:19
dhellmannoh, the category subcommand thing17:19
dhellmannhmm17:19
dhellmannare they registering command line options?17:19
bnemecI think it was trying to parse cli opts and failing.17:20
dhellmannoh, they shouldn't be parsing the command line options17:20
bnemecWell, it ran cfg.CONF(sys.argv[1:]), which tries to parse them.17:21
dhellmannwhy is that not happening inside this main() function?17:21
dhellmannmaybe we have 2 different views of this17:22
bnemecIt doesn't, it's part of the config setup code in Designate.17:22
bnemecLet me find the actual code.17:22
dhellmannI thought the idea was to have them provide a main() that creates a config object, registers some options, then passes it on to the library to do all the real work17:22
dhellmannit sounds like the main() in designate is doing more than that17:22
bnemecOriginally that was the idea. When I tested, I found out that if we don't reuse the project's setup code then we have to explicitly pass the config file every time.17:23
*** e0ne has joined #openstack-dev17:24
bnemechttps://github.com/openstack/designate/blob/master/designate/utils.py#L10617:24
bnemecThe main thing is that it sets up default_config_files sanely for the project.17:25
dhellmannis that a new function written for use with the upgrade checker? or are we trying to reuse something that existed before?17:25
bnemecReuse17:25
dhellmannok17:25
dhellmannthat was not what I expected us to try to do17:25
bnemecThe actual designate review is here: https://review.openstack.org/#/c/604430/17:26
dhellmannpassing project and prog to main in the library ought to be enough to have it find the configuration files17:26
dhellmannoh, they have their own custom defaults for locations for those17:26
dhellmannjoy17:26
bnemecApparently cinder does too since that's where the search code came from.17:27
dhellmannit's a shame we have no way to share things like that aside from copying code around17:29
dhellmannI don't feel like what we have here is really structured for good reuse17:30
dhellmannmaybe we don't want a main in the library at ll?17:31
*** salmankhan has quit IRC17:31
dhellmannor maybe teams are going to need to do a little more work on boilerplate to use it?17:31
*** salmankhan has joined #openstack-dev17:31
dhellmannI feel like what we have now is trying to be reusable but just requires them to do stuff that isn't obvious17:32
*** nplanel_ has joined #openstack-dev17:32
dhellmannlike, either parse the options yourself and call some functions in the library, or let the library do all of it17:32
dhellmannnot both at the same time17:32
dhellmannbnemec : do you have an example of updating nova, too?17:33
*** tosky has quit IRC17:33
dhellmannor I guess any other project17:33
bnemecdhellmann: There is a patch to convert Nova, but it's taking the "parse the options yourself" approach because they had already done that.17:34
bnemechttps://review.openstack.org/60349917:34
bnemecSo they don't call the library's main at all.17:34
dhellmannyeah17:34
dhellmannI feel like that makes more sense17:34
dhellmannmaybe for designate, too17:35
dhellmannor the library main should take some instances or classes and do all of the work17:35
*** salmankhan has quit IRC17:36
dhellmannalthough I guess if everyone needs to pass special defaults for locations for config files, then no one would be able to use a generic main17:36
dhellmannmaybe we should separate out the parts that add the library's options to the config object17:36
bnemecI think you're kind of describing the two separate functions implementation, where the library provides a function to register the appropriate category opts on the project's conf object.17:37
dhellmannor maybe just not provide a main() at all17:37
*** e0ne has quit IRC17:37
bnemecSo instead of passing a callback, the project calls upgradecheck.register_opts(cfg.CONF) and then does their config parsing and calls main.17:37
dhellmannno17:38
dhellmannwell, I agree that's an option, it's just not what I'm thinking we want any more17:38
dhellmannI don't think the library should register any command line options at all17:38
dhellmannand I don't think it should provide a main17:38
bnemecThen everyone has to copy boilerplate code to do that.17:39
dhellmannthese main functions aren't big and they look much less hairy when they're just inline17:39
dhellmannthey all need some main() anyway17:39
dhellmannI guess we could provide a convenience function to register "upgrade check" as a set of nested parsers with a callback17:39
dhellmannbut using it should be optional17:39
dhellmannlet me poke at this review some17:40
*** e0ne has joined #openstack-dev17:40
*** e0ne has quit IRC17:41
bnemecOkay.17:41
bnemecI may be too deep in this and not understanding the complexity from the user perspective.17:42
dhellmannwhy is that subparser called "category"?17:42
dhellmannor subcommandopt17:42
bnemecNova :-)17:42
*** nplanel_ has quit IRC17:42
bnemecWe could call it anything though.17:43
dhellmannI wonder if we would have been better off saying we were going to write a new command rather than trying to fit into the foo-manage commands17:44
*** iyamahat_ has quit IRC17:44
bnemecIt is a new command. $SERVICE-status17:45
dhellmanneven in nova?17:45
bnemecYeah17:45
bnemecI think they did it this way so they could add more status commands later if they wanted.17:45
bnemecI don't know if they had any specific ones in mind though.17:46
dhellmannso one would run it as "foo-status upgrade"?17:46
bnemecfoo-status upgrade check17:46
dhellmannwell, I guess "foo-status upgrade check"17:46
bnemecYeah17:46
dhellmannthen why are we worried about retrofitting into any existing code?17:46
bnemecSo all of the project's cli commands work the same.17:47
dhellmannlet's just add arguments for the stuff we need to pass to conf()17:47
dhellmannis it more important for all of the status commands to be similar, or all of the foo project commands to be similar?17:48
dhellmannI think the former, since this is a new cross-project thing17:48
bnemecAgreed.17:48
bnemecThe main thing was I didn't want everyone to have to always specify the location of the config file.17:48
dhellmannthey shouldn't have to17:49
bnemecBut if we allowed them to pass in default_config_files then I think that also addresses that concern.17:49
*** lpetrut has quit IRC17:49
dhellmannthey'll need to give us a project value17:49
dhellmannand that, yeah17:49
bnemecYeah, I think that works for me.17:49
dhellmannok, let me see if I can put together a patch on top of yours that does that17:49
bnemecAt least in Designate's case they already have a method exposed that provides the correct list of files: https://github.com/openstack/designate/blob/master/designate/utils.py#L7817:50
*** kgiusti has quit IRC17:57
*** iyamahat has joined #openstack-dev17:58
*** kgiusti has joined #openstack-dev17:58
*** kgiusti has quit IRC18:02
*** e0ne has joined #openstack-dev18:14
*** phantax has quit IRC18:14
*** e0ne has quit IRC18:14
*** markvoelker has joined #openstack-dev18:15
*** kgiusti has joined #openstack-dev18:17
*** mriedem has joined #openstack-dev18:20
*** phantax has joined #openstack-dev18:21
*** markvoelker has quit IRC18:24
*** diablo_rojo has joined #openstack-dev18:34
*** e0ne has joined #openstack-dev18:37
*** vnogin has joined #openstack-dev18:40
*** alexperreault has joined #openstack-dev18:49
*** vnogin has quit IRC18:49
*** jamesmcarthur has quit IRC18:58
*** diablo_rojo has quit IRC19:08
*** tosky has joined #openstack-dev19:09
*** rockyg has joined #openstack-dev19:10
*** diablo_rojo has joined #openstack-dev19:14
*** nplanel_ has joined #openstack-dev19:20
*** jamesmcarthur has joined #openstack-dev19:38
openstackgerritMerged openstack/governance master: Retire fuxi projects  https://review.openstack.org/60452719:41
openstackgerritMerged openstack/governance master: Retire charm-ceph  https://review.openstack.org/60453019:45
*** phantax has quit IRC19:53
*** gfidente has quit IRC19:53
*** nplanel_ has quit IRC20:16
*** MasterofJOKers has quit IRC20:16
*** diablo_rojo has quit IRC20:24
*** jcoufal has quit IRC20:25
*** kgiusti has left #openstack-dev20:34
*** alexperreault has quit IRC20:40
*** mriedem has quit IRC20:42
*** pcaruana has quit IRC20:43
*** e0ne_ has joined #openstack-dev20:54
*** e0ne has quit IRC20:54
*** raildo has quit IRC21:00
*** bobh has quit IRC21:03
*** diablo_rojo has joined #openstack-dev21:03
*** bobh has joined #openstack-dev21:04
*** v12aml has quit IRC21:05
*** bobh has quit IRC21:09
*** v12aml has joined #openstack-dev21:09
*** priteau has quit IRC21:13
*** priteau has joined #openstack-dev21:16
*** phantax has joined #openstack-dev21:17
*** priteau has quit IRC21:18
*** morazi has quit IRC21:19
*** phillu has quit IRC21:24
*** jamesmcarthur has quit IRC21:30
*** phantax has quit IRC21:43
*** bobh has joined #openstack-dev21:44
*** cdent has quit IRC21:51
*** jamesmcarthur has joined #openstack-dev21:55
*** jamesmcarthur has quit IRC21:59
*** jamesmcarthur has joined #openstack-dev22:03
*** e0ne_ has quit IRC22:04
*** e0ne has joined #openstack-dev22:05
*** e0ne has quit IRC22:06
*** slaweq has quit IRC22:15
*** bobh has quit IRC22:15
*** ianw is now known as ianw_pto22:17
*** jtomasek has quit IRC22:20
*** alexperreault has joined #openstack-dev22:30
*** jcoufal has joined #openstack-dev22:33
*** mriedem has joined #openstack-dev22:36
*** boazel has quit IRC22:37
*** threestrands has joined #openstack-dev22:42
*** jamesmcarthur has quit IRC22:42
*** tosky has quit IRC22:43
*** jamesmcarthur has joined #openstack-dev22:44
*** jamesmcarthur has quit IRC22:46
*** jamesmcarthur has joined #openstack-dev22:48
*** rcernin has joined #openstack-dev22:49
*** tpsilva has quit IRC22:50
*** nplanel_ has joined #openstack-dev22:53
*** jamesmcarthur has quit IRC22:55
*** hongbin has quit IRC22:56
*** efried has quit IRC22:57
*** nplanel_ has quit IRC22:57
*** pbourke has quit IRC23:02
*** brokencycle has quit IRC23:02
*** pbourke has joined #openstack-dev23:02
*** jcoufal has quit IRC23:05
*** jcoufal has joined #openstack-dev23:07
*** med_ has joined #openstack-dev23:20
*** phantax has joined #openstack-dev23:30
*** jcoufal has quit IRC23:41
*** gyee has quit IRC23:47
*** med_ has quit IRC23:51
*** vnogin has joined #openstack-dev23:54
*** MasterofJOKers has joined #openstack-dev23:57
*** vnogin has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!