| *** owalsh_ has joined #openstack-dib | 00:02 | |
| *** owalsh_ has quit IRC | 00:04 | |
| *** owalsh-afk has quit IRC | 00:04 | |
| *** owalsh-afk has joined #openstack-dib | 00:05 | |
| *** owalsh-afk has quit IRC | 00:05 | |
| *** owalsh has quit IRC | 00:21 | |
| *** owalsh has joined #openstack-dib | 00:22 | |
| *** jamielennox is now known as jamielennox|away | 00:41 | |
| *** jamielennox|away is now known as jamielennox | 00:44 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder feature/v2: Run indent checks of diskimage_builder/lib https://review.openstack.org/442878 | 00:55 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder feature/v2: Run indent checks in diskimage_builder/lib https://review.openstack.org/442878 | 00:58 |
| ianw | might try bashate-ing them too | 00:59 |
| *** owalsh has quit IRC | 01:50 | |
| *** owalsh has joined #openstack-dib | 01:57 | |
| *** owalsh has quit IRC | 02:00 | |
| *** owalsh has joined #openstack-dib | 02:00 | |
| *** owalsh has quit IRC | 02:45 | |
| *** owalsh has joined #openstack-dib | 02:45 | |
| *** owalsh has quit IRC | 02:55 | |
| *** owalsh has joined #openstack-dib | 02:59 | |
| *** frontrunner has quit IRC | 03:16 | |
| yolanda | well, the only problem that this patch solves into upper layer, is the partition sorting | 06:31 |
| yolanda | i created https://review.openstack.org/442479 because i was testing v2 without that patch, and hit the problem https://review.openstack.org/442479 | 06:32 |
| yolanda | but then saw that in that patch, dict changed to a list | 06:32 |
| yolanda | so you'd prefer to merge my patch to temporarily fix the sorting problem, and then merge Andreas patch after merging v2? | 06:36 |
| yolanda | just removed my -w | 06:36 |
| *** chatter29 has joined #openstack-dib | 06:41 | |
| *** chatter29 has quit IRC | 06:53 | |
| *** chhavi has joined #openstack-dib | 07:13 | |
| yolanda | ianw, what's status of merge? do you need to take some action on 441723? | 07:24 |
| *** chhavi has quit IRC | 07:31 | |
| *** aparnav has joined #openstack-dib | 07:46 | |
| *** andreas-f has quit IRC | 07:57 | |
| *** andreas-f has joined #openstack-dib | 08:02 | |
| ianw | yolanda: yeah, i'll have to remerge that | 08:07 |
| yolanda | ianw, do you need help? | 08:22 |
| yolanda | if you send it i can monitor during the day, in case it needs rechecks | 08:22 |
| openstackgerrit | Merged openstack/diskimage-builder feature/v2: Use OrderedDict for partitions instead of simple dictionary https://review.openstack.org/442479 | 08:25 |
| *** chhavi has joined #openstack-dib | 08:26 | |
| ianw | yolanda: i'm re-merge it when that other little dib-lint fix merges and we can let it run CI | 08:28 |
| ianw | i need to look at the nodepool jobs | 08:28 |
| yolanda | ok. I'm doing some tests and, apart from the limitations i mentioned on the review of https://review.openstack.org/426618 , it seems to be working | 08:29 |
| yolanda | it created partitions and filesystems properly with the right mount points and content | 08:30 |
| yolanda | i'm going to try that now in the scope of tripleo | 08:30 |
| ianw | yolanda: awesome, thanks | 08:44 |
| openstackgerrit | Merged openstack/diskimage-builder feature/v2: Run indent checks in diskimage_builder/lib https://review.openstack.org/442878 | 08:45 |
| *** sudipto has joined #openstack-dib | 08:50 | |
| *** sudipto_ has joined #openstack-dib | 08:50 | |
| *** pmannidi has quit IRC | 08:51 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Merge "Run indent checks in diskimage_builder/lib" into feature/v2 https://review.openstack.org/441723 | 08:52 |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** hashar has joined #openstack-dib | 09:06 | |
| *** chhavi has quit IRC | 09:16 | |
| ianw | yolanda: ^ ok, that's the v2->master merge. all green. not sure there is much else to do but merge it and see how we go | 09:59 |
| yolanda | that's cool! | 10:00 |
| ianw | let's merge it, tomorrow my time i'll try my best to fix those nodepool jobs | 10:01 |
| ianw | if i can get that done, i'll feel confident tagging it as 2.0.0 | 10:01 |
| yolanda | let me know if you need some help | 10:02 |
| ianw | if we get seriously stuck, however, we can pretty easily make a v1 branch from 1.28 | 10:02 |
| ianw | ok ... in flight ... that kind of puts the clock on any late changes we want/need before a 2.0.0 tag. | 10:11 |
| ianw | i'll see how i go tomorrow. if not, i don't really want to release the day after (friday my time) so probably tag on the 13th | 10:12 |
| ianw | ttyl | 10:12 |
| yolanda | have a good night. Tomorrow i won't be available, but will monitor in the afternoon | 10:17 |
| *** chhavi has joined #openstack-dib | 10:33 | |
| *** openstackgerrit has joined #openstack-dib | 10:36 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder feature/v2: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/426618 | 10:36 |
| openstackgerrit | Merged openstack/diskimage-builder master: Merge "Run indent checks in diskimage_builder/lib" into feature/v2 https://review.openstack.org/441723 | 11:01 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Send custom parameters in bootloader to GRUB_CMDLINE https://review.openstack.org/441086 | 11:07 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Send custom parameters in bootloader to GRUB_CMDLINE https://review.openstack.org/441086 | 11:16 |
| *** aparnav has quit IRC | 11:22 | |
| *** chhavi_ has joined #openstack-dib | 11:44 | |
| *** chhavi has quit IRC | 11:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/diskimage-builder master: Updated from global requirements https://review.openstack.org/440038 | 12:22 |
| *** frontrunner has joined #openstack-dib | 13:05 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Send custom parameters in bootloader to GRUB_CMDLINE https://review.openstack.org/443132 | 13:41 |
| *** strigazi_AFK is now known as strigazi | 14:04 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Send custom parameters in bootloader to GRUB_CMDLINE https://review.openstack.org/443132 | 14:43 |
| openstackgerrit | Holger Smolinski proposed openstack/diskimage-builder master: Add zipl support for s390x architecture https://review.openstack.org/443171 | 15:21 |
| *** dmarlin has joined #openstack-dib | 15:46 | |
| *** sudipto has quit IRC | 15:52 | |
| *** sudipto_ has quit IRC | 15:52 | |
| openstackgerrit | Holger Smolinski proposed openstack/diskimage-builder master: Oops, left the (C) statement erronoeously in the patch. https://review.openstack.org/443197 | 15:53 |
| openstackgerrit | Holger Smolinski proposed openstack/diskimage-builder master: Add zipl support for s390x architecture https://review.openstack.org/443171 | 15:54 |
| openstackgerrit | Monty Taylor proposed openstack/diskimage-builder master: Include systemd-sysv for debian stretch https://review.openstack.org/443201 | 16:01 |
| *** aparnav has joined #openstack-dib | 16:02 | |
| openstackgerrit | Monty Taylor proposed openstack/diskimage-builder master: Include systemd-sysv for debian stretch https://review.openstack.org/443201 | 16:09 |
| openstackgerrit | Monty Taylor proposed openstack/diskimage-builder master: Include systemd-sysv for debian stretch https://review.openstack.org/443201 | 16:14 |
| *** chhavi_ has quit IRC | 16:35 | |
| *** hashar has quit IRC | 17:06 | |
| *** aparnav has quit IRC | 17:26 | |
| *** adam_g has quit IRC | 18:46 | |
| *** adam_g has joined #openstack-dib | 18:47 | |
| *** bkero has joined #openstack-dib | 19:00 | |
| bkero | Hi there, I started seeing these errors in my logs today. /tmp/tmpJ6_l8j/extra-data.d/10-create-pkg-map-dir: line 11: get_image_element_array: command not found | 19:01 |
| bkero | I don't see any commits on master or feature/v2 that would have caused it though. | 19:02 |
| openstackgerrit | Leehom Li proposed openstack/diskimage-builder master: Fix problem unable disable iptables service https://review.openstack.org/419703 | 19:18 |
| openstackgerrit | Paul Belanger proposed openstack/diskimage-builder master: DNM: testing nodepool-dsvm job https://review.openstack.org/443296 | 19:26 |
| yolanda | hi bkero , with the merge from v2 to master, get_image_element_array function now is on diskimage-builder/diskimage_builder/lib | 19:32 |
| yolanda | see it's nested on a deeper level, maybe it's causing the problem | 19:33 |
| yolanda | btw, ianw , packaging has been fixed for dib, and now the ovb jobs are green | 19:36 |
| bkero | yolanda: I'm suspecting it's going on somewhere in here, although I won't have logs until CI passes complete in another 20-30m. http://git.openstack.org/cgit/openstack-infra/tripleo-ci/tree/scripts/bootstrap-overcloud-full.sh#n90 | 19:41 |
| bkero | yolanda: is get_image_element_array actually tested though? | 19:50 |
| * bkero trying to replicate locally, don't actually see element-info producin the get_image_element_array function | 19:57 | |
| yolanda | bkero, it shall be tested yes... we've been running all the ci for tripleo integration on feature/v2 branch | 20:00 |
| bkero | yolanda: http://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/lib/common-functions#n265 says that element-info will create the function. I don't actually see where it does that. http://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/element_dependencies.py#n324 | 20:01 |
| yolanda | bkero, i know that there has been a major refactor on that | 20:02 |
| yolanda | i see the get_image_element_array being defined here http://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/element_dependencies.py#n293 | 20:04 |
| bkero | Hmm, it looks like that only gets called if args.env is true | 20:06 |
| yolanda | indeed, can you try passing that flag? | 20:08 |
| bkero | I would love to if I can figure out where it is being called from | 20:08 |
| bkero | I'm guessing I have to find where tripleo-build-images lives | 20:09 |
| yolanda | instack? | 20:10 |
| bkero | I mean the repo, looks like tripleo-common | 20:10 |
| yolanda | ah | 20:10 |
| yolanda | if you can overlap with ianw , he may be able to help you, or andreas-f as well | 20:13 |
| yolanda | bkero, also... if the dib jobs didn't detect that breakage in dib, do you think we could add some extra jobs there? currently we have something like http://logs.openstack.org/32/443132/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/97eded1/ | 20:14 |
| yolanda | but seems the coverage is not enough | 20:14 |
| openstackgerrit | Paul Belanger proposed openstack/diskimage-builder master: DNM: testing nodepool-dsvm job https://review.openstack.org/443296 | 20:31 |
| *** frontrunner has quit IRC | 20:42 | |
| bkero | yolanda: it also appears to be intermittent. Maybe it's a race condition? Is any of that code parallel? | 20:48 |
| *** hashar has joined #openstack-dib | 21:08 | |
| bkero | Nix the intermittent. I seem to have inadvertently caused the jobs to continue despite having the same error. | 21:08 |
| bkero | I'm suspecting it's something to do with the context this file is run in: http://git.openstack.org/cgit/openstack/diskimage-builder/tree/diskimage_builder/elements/pkg-map/extra-data.d/10-create-pkg-map-dir | 21:09 |
| openstackgerrit | Michael Johnson proposed openstack/diskimage-builder master: squash-package-install to use the correct python https://review.openstack.org/443336 | 22:21 |
| *** chhavi_ has joined #openstack-dib | 22:31 | |
| *** chhavi_ has quit IRC | 22:35 | |
| *** dmarlin has quit IRC | 23:10 | |
| *** pmannidi has joined #openstack-dib | 23:27 | |
| *** hashar has quit IRC | 23:34 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!