| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions https://review.openstack.org/463627 | 01:15 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: unmount_dir : don't unmount root https://review.openstack.org/463629 | 01:15 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 01:15 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions https://review.openstack.org/463627 | 01:50 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 01:50 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: unmount_dir : don't unmount root https://review.openstack.org/463629 | 01:50 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 01:51 |
| *** chhavi_ has joined #openstack-dib | 03:46 | |
| *** andreas-f has joined #openstack-dib | 04:44 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 05:14 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 05:14 |
| *** pmannidi has quit IRC | 05:52 | |
| *** pmannidi has joined #openstack-dib | 05:53 | |
| *** owalsh_ has joined #openstack-dib | 06:26 | |
| *** owalsh has quit IRC | 06:28 | |
| *** isaacb has joined #openstack-dib | 06:31 | |
| *** andreas-f has quit IRC | 07:01 | |
| *** aparnav has joined #openstack-dib | 07:30 | |
| *** hashar has joined #openstack-dib | 07:37 | |
| ianw | yolanda: around? | 07:56 |
| *** pmannidi has quit IRC | 08:07 | |
| *** owalsh_ is now known as owalsh | 10:07 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 10:12 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 10:12 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions; rollback on all exceptions https://review.openstack.org/463627 | 10:12 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 10:12 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 10:12 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 10:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 10:13 |
| yolanda | hi ianw , i've been out for the morning, back now | 10:17 |
| ianw | yolanda: hey | 10:19 |
| ianw | so what i did was put the sudo_exec patch underneath the block-device refactor | 10:19 |
| yolanda | i've been seeing the discussion about the return parameters | 10:19 |
| ianw | it ended up failing due to a bad umount call that is now caught by sudo_exec raising an exception | 10:20 |
| ianw | i've proposed https://review.openstack.org/#/c/463629/ which seems to work | 10:20 |
| yolanda | the sudo_exec still has -1... | 10:20 |
| ianw | the other angle might be that that umount call is allowed/supposed to fail | 10:20 |
| ianw | in that case we can except/pass it | 10:21 |
| yolanda | i approved the patch | 10:21 |
| yolanda | makes sense | 10:21 |
| ianw | yeah ... i want to force us to check the return values of these calls | 10:21 |
| ianw | if things are ok to ignore, let's mark it explicitly | 10:22 |
| ianw | otherwise, we end up like this ... i don't know if we are supposed to ignore the failure, or if we just forgot to check it, and it is a bigger problem | 10:22 |
| yolanda | now with exec_sudo raising exception, we should not care of capturing the output, as if that fails, code will be aborted | 10:22 |
| yolanda | so maybe just remove the return value from exec_sudo? just raise the exception, because the return 0 is not providing value. If that failed, an exception will be raised, if not, we can continue | 10:23 |
| ianw | yolanda: it's just the same as check_call() | 10:25 |
| ianw | yolanda: we can drop the "return 0" line ... it's a small thing | 10:26 |
| yolanda | ianw, i'd drop that return 0, yes. And that is one of the options that Andreas suggested so this could help to remove the -1 | 10:27 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions; rollback on all exceptions https://review.openstack.org/463627 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: unmount_dir : don't unmount root https://review.openstack.org/463629 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: exec_sudo: check cmd for str, log output and raise exception https://review.openstack.org/463427 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 10:38 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 10:38 |
| ianw | yolanda: right, we seem to have confirmation on that, i'll do the squash | 10:40 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions; rollback on all exceptions https://review.openstack.org/463627 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 10:45 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions; rollback on all exceptions https://review.openstack.org/463627 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: exec_sudo: check cmd for str, log output and raise exception https://review.openstack.org/463427 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 11:00 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Deprecate block-device commands incompatible with config file https://review.openstack.org/463243 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move config out of parameter YAML file https://review.openstack.org/463242 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Let exec_sudo raise exceptions https://review.openstack.org/463627 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove _config_error thrower https://review.openstack.org/463630 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Take --params from environment https://review.openstack.org/461637 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move YAML parsing into cmd.py; default to env https://review.openstack.org/461636 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move to subparsers https://review.openstack.org/461639 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Create BlockDeviceCmd object https://review.openstack.org/461638 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: exec_sudo: check cmd for str, log output and raise exception https://review.openstack.org/463427 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move dib-block-device implementation into cmd.py https://review.openstack.org/461635 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove unused val_else_none https://review.openstack.org/461634 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 11:13 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 11:13 |
| ianw | yolanda: ok, i'm about done ... | 11:21 |
| ianw | i know it looks like a lot, but i think the patches are stacked in a fairly logical fashion | 11:22 |
| yolanda | long queue! | 11:23 |
| yolanda | i'll start to take a look | 11:23 |
| ianw | pretty much all of the first few are negative diffstats | 11:26 |
| ianw | the less code we have the better! | 11:26 |
| yolanda | ++ | 11:36 |
| ianw | hmm, need to figure out a way to stop the nodepool tests if the build fails, instead of having them timeout | 12:30 |
| ianw | yolanda: feel free to squash the change as described in 444586 | 12:43 |
| ianw | or, revert sudo_exec to returning 0 (not my preference) | 12:43 |
| ianw | yolanda: also, see my comment ... the suse job looks legitimately unhappy with it | 12:46 |
| *** aparnav has quit IRC | 13:04 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 13:07 |
| openstackgerrit | Andreas Florath proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 13:25 |
| *** andreas-f has joined #openstack-dib | 13:37 | |
| *** isaacb has quit IRC | 13:58 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Use check_output https://review.openstack.org/463471 | 14:15 |
| *** isaacb has joined #openstack-dib | 14:22 | |
| *** hashar has quit IRC | 14:50 | |
| *** isaacb has quit IRC | 15:08 | |
| yolanda | looking at the suse error: /tmp/in_target.d/post-install.d/10-mkinitrd: line 16: dib-block-device: command not found . I cannot see dib-block-device there, looks as a red herring, or not telling the proper error | 15:19 |
| yolanda | i'm trying an opensuse build just now | 15:19 |
| openstackgerrit | Martin André proposed openstack/diskimage-builder master: Make sure target exists before running it https://review.openstack.org/463806 | 15:21 |
| *** chhavi_ has quit IRC | 15:33 | |
| *** hashar has joined #openstack-dib | 15:53 | |
| andreas-f | yolanda: I changed things in diskimage_builder/elements/zypper/post-install.d/10-mkinitrd in my last update. The information about the root fs is needed there. Because it runs outside the chroot it should have found dib-block-device. | 15:58 |
| andreas-f | The other problem was, that there was a strange call to sed - which I have no explanation for. | 15:59 |
| yolanda | ah, i was getting mad, because i was not even seeing the dib-block-device call there :) | 15:59 |
| yolanda | then let's retry the tests... | 16:00 |
| andreas-f | There are so many open and different patches out there - it is really hard to tell which contains the root cause.... | 16:04 |
| *** chhavi_ has joined #openstack-dib | 16:55 | |
| *** hashar has quit IRC | 17:05 | |
| *** hashar has joined #openstack-dib | 17:06 | |
| *** hashar has quit IRC | 17:07 | |
| *** chhavi_ has quit IRC | 18:22 | |
| *** dabarban has joined #openstack-dib | 19:05 | |
| yolanda | hi andreas-f , so it is not finding the dib-block-device, even with the last recheck | 19:40 |
| yolanda | also post-install seems to be run inside chroot, code calls run_d_in_target post-install | 19:47 |
| yolanda | so it could be useful if that function is seen inside the chroot, i need the same for the change in mountpoints and selinux | 19:48 |
| andreas-f | Yolanda: I started already working on this - but this is somewhat complex and I did not find a good solution until now. | 20:17 |
| *** LiCeUser1 has joined #openstack-dib | 20:18 | |
| *** dabarban has quit IRC | 20:21 | |
| *** LiCeUser1 has quit IRC | 20:23 | |
| *** andreas-f has quit IRC | 20:46 | |
| ianw | yolanda: http://logs.openstack.org/86/444586/45/check/gate-dib-dsvm-functests-python2-ubuntu-trusty-extras-nv/c7bd6f9/console.html#_2017-05-10_19_41_44_891340 | 21:19 |
| ianw | new failure? | 21:19 |
| ianw | 2017-05-10 19:41:44.891427 | [opensuse/build-succeeds] /tmp/in_target.d/post-install.d/10-mkinitrd: line 16: dib-block-device: command not found | 21:19 |
| *** pmannidi has joined #openstack-dib | 22:53 | |
| *** pmannidi has quit IRC | 22:53 | |
| *** pmannidi has joined #openstack-dib | 22:54 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: block_device: reorder imports https://review.openstack.org/461632 | 23:47 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: exec_sudo: check cmd for str, log output and raise exception https://review.openstack.org/463427 | 23:47 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 23:47 |
| *** pmannidi has quit IRC | 23:51 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move blockdevicesetupexception.py into blockdevice.py https://review.openstack.org/461633 | 23:56 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!