| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 00:13 |
|---|---|---|
| openstackgerrit | Merged openstack/diskimage-builder master: Remove args from BlockDevice() init https://review.openstack.org/461640 | 01:18 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Move rollback into plugin_base object https://review.openstack.org/464105 | 02:08 |
| *** chhavi has joined #openstack-dib | 04:48 | |
| *** aparnav has joined #openstack-dib | 05:01 | |
| *** pmannidi has quit IRC | 05:07 | |
| *** pmannidi has joined #openstack-dib | 05:45 | |
| ianw | andreas-f: when you get a minute, could you please propose a review with *extremely* detailed inline comments on _config_tree_to_digraph() and create_graph() and what a NodePluginBase is, compared to a PluginBase. i mean like a paragraph for every line if you have to; assume I know *nothing* | 05:55 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 06:24 |
| ianw | yolanda: ^ ok, should be good | 06:24 |
| yolanda | do you think it's ready to go? | 06:25 |
| ianw | if it passes everything, yes | 06:26 |
| ianw | i'd rather us start iterating on it in smaller chunks, rather than keep rebasing this one over and over :) | 06:26 |
| *** jamielennox is now known as jamielennox|away | 06:53 | |
| *** chhavi has quit IRC | 06:58 | |
| *** pmannidi has quit IRC | 07:13 | |
| *** chhavi has joined #openstack-dib | 09:41 | |
| *** brault is now known as brault|away | 10:57 | |
| yolanda | ok going to take care of it today | 11:05 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 11:47 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 11:47 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 11:52 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 12:18 |
| *** jamielennox|away is now known as jamielennox | 12:30 | |
| *** aparnav has quit IRC | 12:59 | |
| *** brault|away is now known as brault | 13:11 | |
| *** brault is now known as brault|away | 14:02 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Refactor: block-device filesystem creation, mount and fstab https://review.openstack.org/444586 | 14:19 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 14:28 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Apply setfiles on all mountpoints https://review.openstack.org/447076 | 14:37 |
| *** brault|away is now known as brault | 14:37 | |
| *** chhavi has quit IRC | 14:57 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 15:00 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 15:03 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Add lvm management to diskimage-builder https://review.openstack.org/444403 | 15:38 |
| yolanda | ianw, andreas-f , this is ready for review now https://review.openstack.org/#/c/447076/ | 15:44 |
| yolanda | i'm testing my change on volumes, but i'm hitting some problems with unmount | 15:44 |
| yolanda | andreas-f, ianw , so unmount is even failing if i add different partitions without volumes. I tried to create just different mountpoints for / and /var, and i'm getting failures | 15:59 |
| yolanda | http://paste.openstack.org/show/609449/ | 16:00 |
| yolanda | https://paste.fedoraproject.org/paste/~VlUHfGflFVbBXLcyZtXuF5M1UNdIGYhyRLivL9gydE=/ | 16:02 |
| andreas-f | Yolanda: the unmount is the known problem that the unmount_dir already unmounts all these (see line 3878 in your second paste). I thought that Ian had a patch for this. | 16:10 |
| yolanda | looking, but i cannot find. There is a patch about rollback, but not really applying to this case | 16:12 |
| yolanda | maybe we can add a check in unmount here, and just unmount if the mountpoint exists, what do you think? | 16:12 |
| *** chhavi has joined #openstack-dib | 16:52 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Only unmount directories that are mounted https://review.openstack.org/464235 | 16:59 |
| yolanda | andreas-f, ianw . So i found two different problems. First one, on nested mountpoints, see /var and /var/log. When unmounting /var/log, it was complaining about directory not found, so i added the os.path.exists | 17:01 |
| yolanda | second one, when unmounting /var, it was complainig about filesystem already being unmounted. So i captured the exception, logged it, but is non-critical, so continuing | 17:02 |
| yolanda | and it works, i validated now | 17:02 |
| *** chhavi has quit IRC | 18:40 | |
| *** chhavi has joined #openstack-dib | 18:52 | |
| *** chhavi has quit IRC | 19:05 | |
| *** yolanda has quit IRC | 20:35 | |
| *** yolanda has joined #openstack-dib | 20:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!