| *** openstackgerrit has joined #openstack-dib | 00:03 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Remove PluginBase/NodePluginBase class https://review.openstack.org/464538 | 00:03 |
|---|---|---|
| *** Sukhdev has joined #openstack-dib | 01:55 | |
| *** Sukhdev has quit IRC | 01:56 | |
| *** saneax has joined #openstack-dib | 02:07 | |
| *** pmannidi has quit IRC | 03:18 | |
| *** pmannidi has joined #openstack-dib | 03:19 | |
| *** Sukhdev has joined #openstack-dib | 03:27 | |
| *** xinliang has joined #openstack-dib | 03:36 | |
| *** aparna has joined #openstack-dib | 03:55 | |
| *** aparna has quit IRC | 03:55 | |
| *** xinliang has quit IRC | 04:04 | |
| *** xinliang has joined #openstack-dib | 04:05 | |
| *** xinliang has quit IRC | 04:05 | |
| *** xinliang has joined #openstack-dib | 04:05 | |
| *** chhavi has joined #openstack-dib | 05:22 | |
| *** Sukhdev has quit IRC | 05:23 | |
| yolanda | hi ianw , can you look at https://review.openstack.org/464235 ? | 05:46 |
| ianw | yolanda: hey, yeah sorry ... been pretty deep in config stuff, have a review in a sec too :) | 05:47 |
| yolanda | ++ | 05:47 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Start at cleaning up tree/graph config split https://review.openstack.org/465417 | 06:04 |
| ianw | yolanda: so i'd appreciate if you could add some configs to ^ so we can clear up this tree->graph conversion | 06:04 |
| ianw | andreas-f: ^ i'd appreciate comments on what's happening with partitions in the above | 06:06 |
| ianw | they seem to break the model, and i think that got a bit ignored with the "pconfig" argument that started getting passed around | 06:06 |
| yolanda | hi ianw , what do you mean with adding some configs? | 06:21 |
| yolanda | you mean, some samples for the partitions? | 06:21 |
| ianw | yolanda: yeah, some of the configs you use, and the corresponding graph representation, so we can confirm we're getting it right | 06:21 |
| yolanda | ok i can send the multiple partition config that i'm using now, with / , /var and /var/log | 06:22 |
| ianw | cool, if you can just add to the change that would be awesome :) | 06:31 |
| yolanda | sure | 06:34 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Only unmount directories that are mounted https://review.openstack.org/464235 | 06:37 |
| *** makowals has joined #openstack-dib | 06:47 | |
| *** mgagne has quit IRC | 06:53 | |
| *** mgagne has joined #openstack-dib | 06:56 | |
| *** mgagne is now known as Guest24103 | 06:56 | |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Remove PluginBase/NodePluginBase class https://review.openstack.org/464538 | 07:04 |
| openstackgerrit | yolanda.robla proposed openstack/diskimage-builder master: Start at cleaning up tree/graph config split https://review.openstack.org/465417 | 07:04 |
| yolanda | ok i added my configs there | 07:07 |
| ianw | thanks :) | 07:42 |
| ianw | yolanda: i'm not sure if that graph config works as is. the repeated "partition" key will just overwrite? | 07:45 |
| ianw | it's not clear to me how you're supposed to write it | 07:45 |
| ianw | andreas-f: ^ insights in to what you think would be good | 07:46 |
| yolanda | ianw, honestly i just used the tree for that config | 07:55 |
| yolanda | but as a graph is not supposed to work like that? i mean, declare all entries independently? | 07:56 |
| yolanda | for volumes, i was passing something like: | 07:56 |
| ianw | something like that ... this is why i want to clear up the parsing with some tests :) | 07:57 |
| yolanda | http://paste.openstack.org/show/609742/ | 07:57 |
| yolanda | but i cannot add that config yet because volumes has not landed | 07:57 |
| ianw | hmm that's interesting because that's a list, which is not what we show in the documentation | 07:58 |
| yolanda | i haven't tested that on a while, so it may have changed | 07:58 |
| yolanda | in the past it worked like that | 07:58 |
| *** makowals_ has joined #openstack-dib | 08:21 | |
| *** andreas-f has quit IRC | 08:21 | |
| *** makowals has quit IRC | 08:22 | |
| *** isaacb has joined #openstack-dib | 08:22 | |
| *** radez has quit IRC | 08:26 | |
| yolanda | looks as the docs check is failing | 08:48 |
| *** aparnav has joined #openstack-dib | 08:49 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Use fakelogger in test_blockdevice_mbr https://review.openstack.org/465464 | 08:51 |
| ianw | yolanda: yeah, i think need to get that requirements update in | 08:51 |
| ianw | ahh, it might help if i actually committed test cases | 08:55 |
| yolanda | there is an update on requirements that needs to land on dib? | 09:02 |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Start at cleaning up tree/graph config split https://review.openstack.org/465417 | 09:06 |
| ianw | yolanda: 465235 , but looks like it's one of those days with gate failures :/ | 09:08 |
| yolanda | that happens... | 09:13 |
| yolanda | 465235 is my change about umont that fails | 09:13 |
| yolanda | ah, sorry, 464235 | 09:13 |
| *** isaacb has quit IRC | 09:16 | |
| *** isaacb has joined #openstack-dib | 09:25 | |
| *** pmannidi has quit IRC | 09:31 | |
| *** pmannidi has joined #openstack-dib | 09:32 | |
| openstackgerrit | Ian Wienand proposed openstack/diskimage-builder master: Start at cleaning up tree/graph config split https://review.openstack.org/465417 | 10:06 |
| ianw | yolanda: ^ that actually has the test-suite, might make more sense :) | 10:06 |
| *** radez has joined #openstack-dib | 12:00 | |
| *** aparnav has quit IRC | 12:14 | |
| *** chhavi has quit IRC | 12:46 | |
| *** chhavi has joined #openstack-dib | 12:53 | |
| *** pmannidi has quit IRC | 12:58 | |
| *** chhavi_ has joined #openstack-dib | 14:24 | |
| *** chhavi has quit IRC | 14:26 | |
| *** Guest24103 is now known as mgagne | 14:32 | |
| *** mgagne has quit IRC | 14:32 | |
| *** mgagne has joined #openstack-dib | 14:32 | |
| *** Sukhdev has joined #openstack-dib | 15:40 | |
| fungi | heads up! i just took over https://launchpad.net/diskimage-builder and fixed the maintainer/owner/part-of/bug-supervisor/sharing settings to no longer be tripleo | 15:48 |
| fungi | also, because of http://lists.openstack.org/pipermail/openstack-dev/2017-May/116897.html i've switched bug 1671842 from private security to public security while it gets triaged | 15:51 |
| openstack | bug 1671842 in diskimage-builder "/etc/dib-manifests/ has too broad permissions and discloses sensitive information" [Undecided,New] https://launchpad.net/bugs/1671842 | 15:51 |
| yolanda | hi fungi, thx. I just read about that bug today as well | 15:52 |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder master: Set manifests to mode 600 and owner root https://review.openstack.org/465655 | 15:52 |
| fungi | seems like options are to either restrict permissions on those files, or filter their contents to exclude known sensitive values (maybe both?), or remove those files altogether | 15:53 |
| yolanda | seems that Greg just landed that patch | 15:54 |
| greghaynes | oh hey, you all are talking about that | 15:54 |
| greghaynes | not landed, I just figured id throw something up | 15:54 |
| yolanda | bad english words, you just sent that patch :) | 15:54 |
| openstackgerrit | Merged openstack/diskimage-builder master: Updated from global requirements https://review.openstack.org/465235 | 15:55 |
| greghaynes | ah :). I think we should be restrictive regardless. IMO we should also document any values which do things like require exposing passwords in env vars. If you see the env var being reported in the bug we actually document that it is insecure and should not be used | 15:55 |
| greghaynes | I dont know any other vars offhand which are similarly sensitive, though | 15:56 |
| fungi | greghaynes: do you mind assigning that bug to yourself while you're hacking on it? and pick a status/importance which seems reasonable to you | 15:56 |
| greghaynes | fungi: will do | 15:56 |
| fungi | thanks! given it looks like the ball was dropped here (mostly my fault for not visiting the lp settings sooner), anything to make the activity on it now more obvious can help | 15:57 |
| greghaynes | makes sense, thanks for fixing up LP | 15:59 |
| *** isaacb has quit IRC | 16:00 | |
| *** isaacb has joined #openstack-dib | 16:20 | |
| fungi | greghaynes: thanks for tackling the "harder" part of this situation! ;) | 16:23 |
| *** chhavi_ has quit IRC | 17:09 | |
| *** isaacb has quit IRC | 17:12 | |
| *** Guest80969 has joined #openstack-dib | 17:17 | |
| *** Guest80969 has quit IRC | 17:30 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Only unmount directories that are mounted https://review.openstack.org/464235 | 17:32 |
| *** Sukhdev has quit IRC | 17:35 | |
| *** jamielennox is now known as jamielennox|away | 17:59 | |
| *** jamielennox|away is now known as jamielennox | 18:05 | |
| *** Sukhdev has joined #openstack-dib | 18:10 | |
| *** mordred has quit IRC | 19:05 | |
| *** mordred has joined #openstack-dib | 19:06 | |
| *** Sukhdev has quit IRC | 19:47 | |
| *** Sukhdev has joined #openstack-dib | 21:05 | |
| *** Sukhdev has quit IRC | 21:50 | |
| *** pmannidi has joined #openstack-dib | 23:14 | |
| *** pmannidi has quit IRC | 23:15 | |
| *** pmannidi has joined #openstack-dib | 23:15 | |
| openstackgerrit | Merged openstack/diskimage-builder master: Use fakelogger in test_blockdevice_mbr https://review.openstack.org/465464 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!