| ianw | ahh, libpod_3.4.7+ds1-3_changelog has fixed it | 02:59 |
|---|---|---|
| ianw | now suse failed | 02:59 |
| ianw | in dib-functests | 02:59 |
| opendevreview | Ian Wienand proposed openstack/diskimage-builder master: Move image validation into extract-image https://review.opendev.org/c/openstack/diskimage-builder/+/839294 | 03:53 |
| opendevreview | Ian Wienand proposed openstack/diskimage-builder master: Move image validation into extract-image https://review.opendev.org/c/openstack/diskimage-builder/+/839294 | 05:07 |
| opendevreview | Ian Wienand proposed openstack/diskimage-builder master: Move image validation into extract-image https://review.opendev.org/c/openstack/diskimage-builder/+/839294 | 06:46 |
| opendevreview | Ian Wienand proposed openstack/diskimage-builder master: centos: avoid head pipe failure https://review.opendev.org/c/openstack/diskimage-builder/+/839307 | 07:28 |
| opendevreview | Ian Wienand proposed openstack/diskimage-builder master: Move image validation into extract-image https://review.opendev.org/c/openstack/diskimage-builder/+/839294 | 07:34 |
| opendevreview | Merged openstack/diskimage-builder master: Add a job to test building jammy https://review.opendev.org/c/openstack/diskimage-builder/+/836228 | 09:47 |
| rpittau | clarkb: https://review.opendev.org/c/openstack/bifrost/+/839329 | 09:53 |
| opendevreview | Merged openstack/diskimage-builder master: yum-minimal: clean up release package installs https://review.opendev.org/c/openstack/diskimage-builder/+/837248 | 09:54 |
| opendevreview | Merged openstack/diskimage-builder master: Move reset-bls-entries to post-install https://review.opendev.org/c/openstack/diskimage-builder/+/838792 | 10:02 |
| clarkb | rpittau: looks like the bullseye job(s) pass? In that case maybe I should clean up my change and make it mergeable. Then either we squash it into the revert or land the two chagnes back to back? | 14:32 |
| rpittau | clarkb: yep, that looks ok, would be great to squash them together so I can retest with just one, but up to you :) | 14:35 |
| clarkb | ianw: ^ if you think squashing is a good idea let me know when your day starts and I'll get that done | 15:14 |
| clarkb | ianw: once you've had breakfast and have a chane to think this one over let me knwo what you think the best approach is and I'll restructure/rebase/squash the changes to reflect that | 19:56 |
| ianw | sorry which changes are we squashing? | 19:57 |
| ianw | 839080 i was just wondering about the dhcp6 stuff in there | 19:58 |
| ianw | i guess combining that with the revert change? | 19:58 |
| clarkb | ianw: https://review.opendev.org/c/openstack/diskimage-builder/+/839080/3 squashed into https://review.opendev.org/c/openstack/diskimage-builder/+/838863/4 is the request from rpittau | 19:58 |
| clarkb | I'm happy to split out the fixes into separate changes on top of the revert and try to land them close together instead | 19:59 |
| clarkb | I guess the option would be to put the fixes under the revert | 19:59 |
| clarkb | then we land the fixes first in separate changes then revert | 19:59 |
| clarkb | or we squash it all together into one | 19:59 |
| clarkb | and yes those are different fixes I had to make to make it work. Makes me wonder if those were the real issue all along | 20:00 |
| clarkb | ianw: how about that: one change to fix the eni content, one change to add |move to the udev rule, then the revert change on top in that order | 20:00 |
| ianw | i think i'm happy to squash, if you like. we don't particularly need the bits about net.ifnames etc. in that changelog, if we're merging a fix with it | 20:01 |
| ianw | but perhaps splitting out the dhcp file name changes as a change underneath is good, yep | 20:02 |
| clarkb | ok so |move together with the squash and cleanup the release notes in the squash | 20:02 |
| clarkb | but ENI fixes under. That sounds good and I'll get that together after lunch | 20:02 |
| ianw | thanks! | 20:03 |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: Fix dhcp-all-interfaces on debuntu systems https://review.opendev.org/c/openstack/diskimage-builder/+/839080 | 20:45 |
| opendevreview | Clark Boylan proposed openstack/diskimage-builder master: Revert "Fallback to persistent netifs names with systemd" https://review.opendev.org/c/openstack/diskimage-builder/+/838863 | 20:45 |
| clarkb | ianw: something like that | 20:45 |
| ianw | lgtm will let it process | 21:27 |
| clarkb | let me see if I can update rpittau's depends on | 21:46 |
| clarkb | https://review.opendev.org/c/openstack/bifrost/+/839329 commit message updated to depend on 838863 and give us a bit more feedback | 21:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!