| opendevreview | John L. Villalovos proposed openstack/diskimage-builder master: chore: support building Fedora on arm64 AKA aarch64 https://review.opendev.org/c/openstack/diskimage-builder/+/877112 | 17:32 |
|---|---|---|
| jlvillal | clarkb, It has been awhile since I've done a Gerrit proposal. But the one above is to fix the issue I had with Fedora not building on 'aarch64' | 17:34 |
| clarkb | cool looks like that follows the pattern of converting amd64 to x86_64 | 17:35 |
| jlvillal | Yep | 17:39 |
| jlvillal | clarkb, So it has been awhile since I used Gerrit. When I go to Gerrit it says "Your Turn" to me about https://review.opendev.org/c/openstack/diskimage-builder/+/877112 But I'm unsure what it is I should do? | 21:00 |
| jlvillal | Do I just click my name and that is it? | 21:01 |
| clarkb | jlvillal: new gerrit has this idea that if a reviewer reviews something then its back to the owner to do something to move things along. Its an assumption that doesn't quite fit our two reviewer approval process | 21:01 |
| jlvillal | clarkb, Thanks. I'll just click my name to dismiss then. | 21:02 |
| clarkb | think of it as a "someone else human or bot reported on the change so you should check it to make sure you don't need further action" in this case zuul is +1 and I'm +2 so you're good and can wait for a second reviewer | 21:02 |
| jlvillal | Excellent. Thanks. | 21:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!