| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Stop using deprecated pkg_resources API https://review.opendev.org/c/openstack/diskimage-builder/+/907691 | 03:23 |
|---|---|---|
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Stop using deprecated pkg_resources API https://review.opendev.org/c/openstack/diskimage-builder/+/907691 | 03:49 |
| JayF | ianw: is there a way, in python packaging, to guarantee we never end up zipped up? | 15:04 |
| JayF | ianw: I don't know details around this, was just trying to fix the deprecation and fit the interface docs as I read 'em, and it makes me nervous to introduce something I know will be breaky (new lib w/o the ctxt manager bit) unless we can disable zip installation | 15:05 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: DNM: CI science around gentoo fixes https://review.opendev.org/c/openstack/diskimage-builder/+/907757 | 15:21 |
| clarkb | JayF: sdists are tarballs which are zipped. I'm not sure I understand your question | 16:20 |
| JayF | The context is in the pkg_resources pr | 16:21 |
| clarkb | I think what importlib is saying there is that if zipimport is used (which may be implicit via import) you can import things straight out of sdists that haven't been "properly" installed. In the case of dib since dib is referring to its own things this seems highly unlikely. But I guess maybe possible | 16:26 |
| *** ravlew is now known as Guest1715 | 16:29 | |
| JayF | It sounds like the ideal patch might be detecting that case and exiting with a message, and then eliminating support for zipfile | 16:51 |
| JayF | and then if that breaks someone, we know exactly how/where/what use case | 16:52 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Fix various minor issues with Gentoo; make CI pass https://review.opendev.org/c/openstack/diskimage-builder/+/907757 | 20:33 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Re-enable voting on Gentoo DIB CI job https://review.opendev.org/c/openstack/diskimage-builder/+/907904 | 20:33 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Fix various minor issues with Gentoo; make CI pass https://review.opendev.org/c/openstack/diskimage-builder/+/907757 | 20:35 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Re-enable voting on Gentoo DIB CI job https://review.opendev.org/c/openstack/diskimage-builder/+/907904 | 20:35 |
| JayF | ^ is ready for your review; we could've gone further (as mentioned in the commit) but we wanted to get to working, push a patch up, and pause :D | 20:38 |
| JayF | TheJulia: ^ I know we had talked in passing about gentoo-based ramdisk being a candidate for an ultra-slim IPA, this would the starting point for it | 20:39 |
| JayF | I'll also note generally: I'm willing to be a core on DIB and review the generic and gentoo-specific changes if you'd all like. | 21:00 |
| clarkb | I have no problem with that. Will let ianw weigh in before making any changes to corem embership though | 21:04 |
| JayF | The Gentoo folks are relatively excited about getting this support fixed. Super common workflow in Gentoo, especially on ARM, to prebuild disk images, and the existing way of doing it for them is basically a completely separate config language. | 21:07 |
| JayF | This is gonna enable them to document use of diskimage-builder for those cases, and it's going to be great | 21:07 |
| clarkb | what is with the unset of YACC and LEX env vars? Maybe that is a problem wehn running dib on gentoo and the host gentoo affects the build env? | 21:17 |
| clarkb | those aren't vars I would expect to be set generally though | 21:17 |
| JayF | I saw that in a self-review and was gonna ask Sam (plz put that ocmment on gerrit) | 21:36 |
| JayF | There's a nonzero chance it's leftover. I don't even want to know how ridiculous the dev environment looks like for someone who commits as many random gentoo fixes as I see him do lol | 21:36 |
| JayF | he's over in europe so hopefully resting r/nm | 21:36 |
| clarkb | done | 21:36 |
| TheJulia | so clark's question on https://review.opendev.org/c/openstack/diskimage-builder/+/907757/3/diskimage_builder/elements/gentoo/bin/install-packages is also sort of shared by me. Any additional context would be helpful | 22:01 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Fix various minor issues with Gentoo; make CI pass https://review.opendev.org/c/openstack/diskimage-builder/+/907757 | 22:06 |
| opendevreview | Jay Faulkner proposed openstack/diskimage-builder master: Fix various minor issues with Gentoo; make CI pass https://review.opendev.org/c/openstack/diskimage-builder/+/907757 | 22:11 |
| JayF | context provided in the review + in a comment | 22:20 |
| JayF | and as a bonus I spotted an extra mistake and fixed it | 22:20 |
| TheJulia | \o/ | 22:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!