| noonedeadpunk | hey folks! Can I ask for some attention on https://review.opendev.org/c/openstack/diskimage-builder/+/922109 ? | 16:47 |
|---|---|---|
| noonedeadpunk | as it's around for over a year and it already makes limited snese | 16:47 |
| noonedeadpunk | I'd love to push changes for 42 already, but if they have no prespecitve to be merged - potentially I should just keep maintiaing fedora element downstream? | 16:48 |
| clarkb | (I noted that those of us who maintain dib as part of openstac infra/opendev don't really have the resources to support fedora. Not sure if the ironic folks that dabble in dib are interested in keeping fedora afloat) | 16:49 |
| noonedeadpunk | I'm fine with helping with it's maintenance | 16:50 |
| noonedeadpunk | we do use dib for produicing openstack images for tenants, so we'd need to maintain that either upstream or downstream | 16:50 |
| clarkb | then also centos 9 stream testing is still broken because centos 9 stream published bad images | 16:51 |
| JayF | I don't have enough knowledge about fedora to feel like a "maintainer" | 16:51 |
| clarkb | I know there is a bug for that in centos' tracker but it seems to have happened multiple times and hasn't been corrected so not sure if we need to push harder for a resoltuon there or consider dropping centos 9 stream testing with upstream images (the -minimal maintained images can continue to cover that platform) | 16:51 |
| JayF | but I'm willing to review changes for reasonableness/safety and +2 them if we have a consensus that's okay | 16:51 |
| clarkb | s/-minimal maintained/-minimal based/ | 16:51 |
| JayF | my thought on stuff like that is as long as we're sure it's not dangerous, arguably mostly-working fedora support (Assuming review misses some thing) is better than no support at all as long as folks are responsive to bugs | 16:52 |
| JayF | and I think that's what noonedeadpunk is volunteering to do | 16:52 |
| noonedeadpunk | Also given that CI is passing - this should lower risk... hopefully | 16:53 |
| noonedeadpunk | but yes | 16:53 |
| noonedeadpunk | I'd rather do this as upstream best effort | 16:53 |
| clarkb | noonedeadpunk: I posted some general testing remarks that will need an update | 16:59 |
| clarkb | given this is only modifying the upstream image locations (I guess they added -Generic then switched the order of arch vs release in the filename?) I'm probably ok approve that myself | 16:59 |
| clarkb | I was worred it was going to require a bunch of networking updates and so on which is pretty typical of fedora updates | 17:00 |
| noonedeadpunk | yeah, they've messed up with naming conventions quite a bit | 17:00 |
| noonedeadpunk | I'm obviously having some downstream version of the element right now, and images seems to be working | 17:00 |
| noonedeadpunk | but yeah... your comments are absolutely valid | 17:01 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/diskimage-builder master: Add support for building Fedora 40 https://review.opendev.org/c/openstack/diskimage-builder/+/922109 | 17:06 |
| clarkb | I'll rereview it right now so I don't forget (I expect ci to fail fwiw but thats ok we can approve once ci is happy | 17:06 |
| clarkb | noonedeadpunk: were you going to update the tools/ test job check script thing too? | 17:07 |
| noonedeadpunk | so far I'm not sure what exactly needs to be changed there | 17:08 |
| noonedeadpunk | as it looks kinda generic so far | 17:09 |
| clarkb | noonedeadpunk: https://review.opendev.org/c/zuul/nodepool/+/946136/2/tools/functional-test-check.sh | 17:09 |
| clarkb | you made that change in nodepool to fix things then linked to it in the zuul config indicating that is why the job is non voting | 17:10 |
| noonedeadpunk | oh well | 17:10 |
| clarkb | I'm saying you can put that in dib itself then we don't need to make the job non voting. | 17:10 |
| noonedeadpunk | I forgot about that :D | 17:10 |
| clarkb | (because dib no longer uses nodepool for its ci) | 17:10 |
| noonedeadpunk | right | 17:10 |
| noonedeadpunk | thanks for pointing this out | 17:11 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/diskimage-builder master: Add support for building Fedora 40 https://review.opendev.org/c/openstack/diskimage-builder/+/922109 | 17:12 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!