| opendevreview | Tadas Sutkaitis proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 12:32 |
|---|---|---|
| opendevreview | Tadas Sutkaitis proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 12:38 |
| opendevreview | Tadas Sutkaitis proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 12:39 |
| opendevreview | Tadas Sutkaitis proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 15:18 |
| opendevreview | Tadas Sutkaitis proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names. Script logic inspired by: https://github.com/openstack/diskimage-builder/commit/93442d09cff0eadfc18b17793c24789dac094600 https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 15:20 |
| opendevreview | Mohammed Naser proposed openstack/diskimage-builder master: feat: introduce new cloud-init service names. https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 15:23 |
| opendevreview | Merged openstack/diskimage-builder master: feat: introduce new cloud-init service names. https://review.opendev.org/c/openstack/diskimage-builder/+/959316 | 17:42 |
| opendevreview | Merged openstack/diskimage-builder master: Drop remaining reference to TripleO https://review.opendev.org/c/openstack/diskimage-builder/+/958884 | 18:28 |
| opendevreview | Merged openstack/diskimage-builder master: Remove mirror from experimental debian jobs https://review.opendev.org/c/openstack/diskimage-builder/+/953256 | 18:54 |
| opendevreview | Merged openstack/diskimage-builder master: Fix debian-systemd element for non-root user https://review.opendev.org/c/openstack/diskimage-builder/+/952875 | 18:54 |
| opendevreview | Merged openstack/diskimage-builder master: Add support for DNF5-based systems https://review.opendev.org/c/openstack/diskimage-builder/+/934332 | 19:03 |
| mnasiadka | clarkb/JayF: willing to have a look at https://review.opendev.org/c/openstack/diskimage-builder/+/949493 ? | 19:07 |
| clarkb | mnasiadka: I don't understand why that was failing before | 19:19 |
| clarkb | mnasiadka: the if statement should mean that false return codes are acceptable then fall into the else block | 19:19 |
| clarkb | it will log that grub2-mkconfig was not found but that shouldn't cause things to fail should it? | 19:20 |
| clarkb | I don't think that change hurts anything I just wonder if it helps | 19:20 |
| mnasiadka | It helps users complaining that this is the erroe that is causing things to fail - I have such downstream users ;) | 19:21 |
| mnasiadka | s/erroe/error/ | 19:21 |
| mnasiadka | (Damn phone keyboard) | 19:21 |
| clarkb | ok so its a change to reduce confusion about where the actual error is rather than fixing a problem directly. I'm willing to accept that | 19:23 |
| mnasiadka | Thanks | 19:31 |
| opendevreview | Merged openstack/diskimage-builder master: Add a sha256sum check for CentOS Cloud Images https://review.opendev.org/c/openstack/diskimage-builder/+/957983 | 20:17 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!